[00:00:36] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Use PNG (not SVG) for notification emails so they work in Gmail - https://phabricator.wikimedia.org/T127794#2566361 (10jmatazzoni) 05Open>03Resolved [00:01:01] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Special:Notifications broken when EventLogging extension is not enabled - https://phabricator.wikimedia.org/T143092#2566362 (10jmatazzoni) 05Open>03Resolved [00:01:47] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, 13Patch-For-Review: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2566365 (10jmatazzoni) [00:01:49] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 07User-notice: [betalabs-Regression] Incorrect count when only cross-wiki notifications are present - https://phabricator.wikimedia.org/T140327#2566364 (10jmatazzoni) 05Open>03Resolved [00:03:35] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Measure how often the "mark all as read" action is used in the Notification Panel - https://phabricator.wikimedia.org/T127955#2566367 (10jmatazzoni) 05Open>03Resolved [00:03:37] 06Collaboration-Team-Triage, 10Notifications, 07Epic, 07Tracking: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#2566368 (10jmatazzoni) [00:04:07] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Special:Notifications - no-js page briefly displayed when page is loading - https://phabricator.wikimedia.org/T142451#2566369 (10jmatazzoni) 05Open>03Resolved [00:05:19] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): [betalabs-Regression] Special:Notifications page displays wrong date format for messages - https://phabricator.wikimedia.org/T141915#2566383 (10jmatazzoni) 05Open>03Resolved [00:09:46] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Unseen notifications jump to the bottom and then back to the top - https://phabricator.wikimedia.org/T143067#2566384 (10jmatazzoni) 05Open>03Resolved [00:10:39] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Flow: Update to stop using buildCssLinks and for related ConfirmEdit change - https://phabricator.wikimedia.org/T140472#2566385 (10jmatazzoni) 05Open>03Resolved [00:10:55] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "Call to a member function getTimestamp() on a non-object" on backfillUnreadWikis for frwiktionary - https://phabricator.wikimedia.org/T140697#2566387 (10jmatazzoni) 05Open>03Resolved [00:11:37] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, 13Patch-For-Review: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2566389 (10jmatazzoni) [00:11:40] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Notifications from moderated post are not purged - https://phabricator.wikimedia.org/T142758#2566388 (10jmatazzoni) 05Open>03Resolved [00:15:09] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, 13Patch-For-Review: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2566391 (10jmatazzoni) 05Open>03Resolved [00:17:02] mooeypoo, do you know a good person on Hebrew Wikipedia to talk to about AbuseFilter specifically or technical things in general? [00:17:20] I need a change made to the filter, and I think it's probably better to get a local admin to do it then do it ourselves. [00:17:48] matt_flaschen, matanya and eran [00:18:04] eranroz [00:18:11] do what mooeypoo ? [00:18:21] matanya, ^^ matt_flaschen could use help with AbuseFilter on hewiki [00:18:28] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review: Change deleted topic titles to be consistently visible and reflect this in permissions system - https://phabricator.wikimedia.org/T119234#2566394 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [00:19:12] Hey matanya. I would like to tweak https://he.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%9E%D7%A1%D7%A0%D7%9F_%D7%94%D7%94%D7%A9%D7%97%D7%AA%D7%95%D7%AA/47 . [00:19:27] I'll PM you since it's a hidden filter. [00:20:20] ok [00:31:49] mooeypoo, BTW, I merged the RevisionSlider change. [00:32:02] oh, which one? [00:32:09] oh the puppet? [00:32:49] Yeah, just wanted to let you know. [00:35:32] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Reconsider styling of excerpts within bundles in light of fact that they have no close quote - https://phabricator.wikimedia.org/T141034#2566425 (10jmatazzoni) @Sbisson asks: > Should the new-topi... [00:37:08] nice! I should set it up on vagrant then! :) [00:37:17] ok I'm off for the evening. See you all tomorrow [00:40:34] Have a good night. [00:42:51] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review: Change deleted topic titles to be consistently visible and reflect this in permissions system - https://phabricator.wikimedia.org/T119234#2566430 (10Mattflaschen-WMF) a:05jmatazzoni>03Mattflaschen-WMF [00:48:37] mooeypoo: git bisect says https://gerrit.wikimedia.org/r/#/c/305054/ is the culprit and I think it's pretty obviously right [00:49:09] Volker basically moved a whole bunch of .oo-ui-foobarWidget .oo-ui-menuSelectWidget { width: 100%; } rules up into MenuSelectWidget.less [00:53:44] (03PS1) 10Catrope: Make dotdotdot menu not be extremely wide [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305602 [00:53:50] mooeypoo: ---&& [00:55:55] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Support-and-Safety: Give WMF staff with global-flow-create the right to rename pages globally - https://phabricator.wikimedia.org/T133901#2566438 (10Mattflaschen-WMF) I figured out what the issue was, and came up with a combina... [00:56:17] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Support-and-Safety: Hebrew Wikipedia abuse filter is blocking global-flow-create moves - https://phabricator.wikimedia.org/T133901#2566441 (10Mattflaschen-WMF) [01:01:45] (03CR) 10Catrope: [C: 032] Mobile action menu should stick to bottom of screen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305572 (https://phabricator.wikimedia.org/T142013) (owner: 10Mooeypoo) [01:08:41] (03Merged) 10jenkins-bot: Mobile action menu should stick to bottom of screen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305572 (https://phabricator.wikimedia.org/T142013) (owner: 10Mooeypoo) [01:10:11] (03PS1) 10Mattflaschen: Make server-side logging always check whether schema is enabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305603 (https://phabricator.wikimedia.org/T143092) [01:12:58] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis: [REQUEST] Which features of RecentChanges are most often used? - https://phabricator.wikimedia.org/T141319#2566475 (10Neil_P._Quinn_WMF) a:05HJiang-WMF>03Neil_P._Quinn_WMF [01:17:39] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, 10Wikimedia-Site-requests: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2566479 (10Mattflaschen-WMF) Since we haven't done this in a while, I will do it on Beta C... [01:21:43] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, 10Wikimedia-Site-requests: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2566496 (10Mattflaschen-WMF) Correction, for 1-2 on Beta Cluster I'll use NS_PROJECT_TALK. [01:49:04] (03PS1) 10Mattflaschen: WIP: Fifth parameter is header suffix, not archive pattern [extensions/Flow] - 10https://gerrit.wikimedia.org/r/305607 [01:49:45] (03PS2) 10Mattflaschen: WIP: Fix parameter for convertNamespaceFromWikitext.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/305607 (https://phabricator.wikimedia.org/T140588) [01:50:03] (03CR) 10Mattflaschen: "I will de-WIP this after I test it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/305607 (https://phabricator.wikimedia.org/T140588) (owner: 10Mattflaschen) [02:10:48] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2566527 (10Mattflaschen-WMF) Also, as part of steps 1 and 4: populateContentModel.php on 'revision', 'arc... [02:13:04] convertNamespaceToWikitext.php testing in Beta Cluster is done. [02:13:06] Heading out. [05:58:08] 06Collaboration-Team-Triage, 10Flow: Flow user mentioning shouldn't be case-sensitive - https://phabricator.wikimedia.org/T143387#2566731 (10Amire80) [06:39:16] (03CR) 10WMDE-leszek: [C: 031] Make server-side logging always check whether schema is enabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305603 (https://phabricator.wikimedia.org/T143092) (owner: 10Mattflaschen) [07:31:07] 06Collaboration-Team-Triage, 10Notifications: Provide a single entry point for notification that anticipates the urgency of the notifications received - https://phabricator.wikimedia.org/T142981#2566815 (10Pginer-WMF) Thanks for the clarification @jmatazzoni. That seems an approach worth considering. I was try... [08:34:01] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend: Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2566946 (10Pginer-WMF) >>! In T141404#2507241, @Mooeypoo wrote: > Sending the 'seen' and 'unseen' behavior in the mobile badge to QA re... [08:51:59] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Find out if mention notifications are used - https://phabricator.wikimedia.org/T140928#2566950 (10Addshore) Just pending a dashboard in the coming days now! [09:10:04] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Find out if mention notifications are used - https://phabricator.wikimedia.org/T140928#2566970 (10Addshore) Started @ https://grafana.wikimedia.org/dashboard/db/echo-mention-status-notifications [09:42:30] (03CR) 10Jakob: [C: 031 V: 031] Log edits in multiple sections that could trigger mentions. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [09:42:39] (03CR) 10WMDE-Fisch: [C: 031] Make server-side logging always check whether schema is enabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305603 (https://phabricator.wikimedia.org/T143092) (owner: 10Mattflaschen) [09:46:02] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Find out if mention notifications are used - https://phabricator.wikimedia.org/T140928#2567003 (10Lea_WMDE) @addshore would it be possible to have a seperate graph that shows the same for test? [09:50:28] (03CR) 10Addshore: [C: 032] Make server-side logging always check whether schema is enabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305603 (https://phabricator.wikimedia.org/T143092) (owner: 10Mattflaschen) [09:56:58] (03Merged) 10jenkins-bot: Make server-side logging always check whether schema is enabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305603 (https://phabricator.wikimedia.org/T143092) (owner: 10Mattflaschen) [10:06:18] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Find out if mention notifications are used - https://phabricator.wikimedia.org/T140928#2567039 (10Addshore) >>! In T140928#2567003, @Lea_WMDE wrote: > @addshore would it be possible to have a seperate graph that... [10:36:10] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Support-and-Safety: Hebrew Wikipedia abuse filter is blocking global-flow-create moves - https://phabricator.wikimedia.org/T133901#2567070 (10Trizek-WMF) >>! In T133901#2559592, @Mattflaschen-WMF wrote: > Are there any other wi... [10:51:02] 06Collaboration-Team-Triage, 10Notifications, 06TCB-Team: mention anomalies with certain diffs - https://phabricator.wikimedia.org/T143313#2567090 (10WMDE-Fisch) After some digging it seems that wikidiff2 is part of the problem. So with wikidiff2 installed and enabled the change gets misinterpreted as desc... [11:14:10] (03PS3) 10WMDE-Fisch: DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) [11:18:32] (03CR) 10jenkins-bot: [V: 04-1] DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) (owner: 10WMDE-Fisch) [11:33:28] (03PS4) 10WMDE-Fisch: DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) [11:38:55] (03CR) 10jenkins-bot: [V: 04-1] DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) (owner: 10WMDE-Fisch) [12:33:15] (03PS1) 10Addshore: Always use php based diff in EchoDiscussionParserTest [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305642 [12:35:30] (03PS2) 10Addshore: Always use php based diff in EchoDiscussionParserTest [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305642 [12:54:40] 06Collaboration-Team-Triage, 10Notifications, 06TCB-Team: mention anomalies with certain diffs - https://phabricator.wikimedia.org/T143313#2567305 (10Addshore) So it looks like in the test wikidiff2 was confusing us, https://gerrit.wikimedia.org/r/#/c/305642/ might help clear that up. Further looking into t... [12:56:27] (03CR) 10WMDE-leszek: [C: 031] Always use php based diff in EchoDiscussionParserTest [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305642 (owner: 10Addshore) [14:40:23] (03CR) 10Sbisson: [C: 032] Always use php based diff in EchoDiscussionParserTest [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305642 (owner: 10Addshore) [14:51:12] (03CR) 10jenkins-bot: [V: 04-1] Always use php based diff in EchoDiscussionParserTest [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305642 (owner: 10Addshore) [15:00:47] (03CR) 10Addshore: [C: 032] "re +2 to try gate-submite again after a random segfault..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305642 (owner: 10Addshore) [15:11:40] (03Merged) 10jenkins-bot: Always use php based diff in EchoDiscussionParserTest [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305642 (owner: 10Addshore) [15:49:23] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Support-and-Safety: Hebrew Wikipedia abuse filter is blocking global-flow-create moves - https://phabricator.wikimedia.org/T133901#2567828 (10Mattflaschen-WMF) >>! In T133901#2566438, @Mattflaschen-WMF wrote: > However, while m... [16:26:42] Re: monobook/echo badges - One editor commented on how the badge icons touch the top of the window, and asked how to tweak it a bit lower. I checked, and showed him https://en.wikipedia.org/w/index.php?title=User:Quiddity_(WMF)/monobook.css&oldid=735121620 - Is that a thing we could officially put in? Or are there cross-browser compatibility issues? (I know monobook/IE has been troublesome) [16:46:49] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Page-deletion, 05MW-1.28-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Failed restore and data loss on ar_rev_id collisions - https://phabricator.wikimedia.org/T135852#2312948 (10Etonkovidova) On vagrant checked the scenario of del... [16:47:39] matt_flaschen: re my comment on https://phabricator.wikimedia.org/T135852: it makes me think that my vagrant might be not updated to the patch for the issue ... [16:48:33] matt_flaschen: I will update again my vagrant, then re-check deletion, and also try deletion scenarios that you described (multiple revisions) [17:46:11] 06Collaboration-Team-Triage, 10Flow: case-insensitive autocomplete for mentions - https://phabricator.wikimedia.org/T101254#2568228 (10Mattflaschen-WMF) [17:46:13] 06Collaboration-Team-Triage, 10Flow: Flow user mentioning shouldn't be case-sensitive - https://phabricator.wikimedia.org/T143387#2568230 (10Mattflaschen-WMF) [17:46:43] 06Collaboration-Team-Triage, 10Flow: Case-insensitive autocomplete for Flow mentions - https://phabricator.wikimedia.org/T101254#1333604 (10Mattflaschen-WMF) [17:55:16] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Page-deletion, 05MW-1.28-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Failed restore and data loss on ar_rev_id collisions - https://phabricator.wikimedia.org/T135852#2568283 (10Mattflaschen-WMF) It looks like that MySQL query is... [17:56:00] etonkovidova, no, that is what is expected to happen. Before the fix, it is much worse. The row is lost forever (unless you have a backup, obviously); it's in neither archive nor revision tables. [17:57:11] matt_flaschen: thx - it's great. But I will check for multiversion revision deletion [17:57:58] RoanKattouw, doing kabwiki in production now. [17:58:02] Just user talk for now. [18:01:19] OK [18:20:37] (03PS1) 10Mooeypoo: [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 [18:40:17] RoanKattouw, can you delete https://kab.wikipedia.org/wiki/Amyannan_umsqedac:Ijon ? It's beause I accidentally interrupted the conversion. The archive page with the actual content is at https://kab.wikipedia.org/wiki/Amyannan_umsqedac:Ijon/Archive_1 . I'll move that back afterwards, then restart the conversion. [18:58:34] (03PS2) 10Mooeypoo: [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 [18:59:18] 06Collaboration-Team-Triage, 10Flow, 10Dumps-Generation: Flow: Handle missing content when dumping - https://phabricator.wikimedia.org/T139791#2568459 (10Mattflaschen-WMF) No, but only the Flow dumps are failing. Everything else is still being dumped as normal. [18:59:54] matt_flaschen: Done [19:01:58] RoanKattouw, thanks, sorry about that. Can you also move https://kab.wikipedia.org/wiki/Amyannan_umsqedac:Ijon/Archive_1 to https://kab.wikipedia.org/wiki/Amyannan_umsqedac:Ijon without leaving a redirect? [19:02:42] (03CR) 10jenkins-bot: [V: 04-1] [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 (owner: 10Mooeypoo) [19:02:59] matt_flaschen: Done [19:03:04] Now going to lunch [19:03:13] (03CR) 10Sbisson: [C: 04-1] "I would suggest removing the word 'fake'." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 (owner: 10Mooeypoo) [19:03:27] RoanKattouw, thanks, restarting now. [19:08:13] (03PS3) 10Mooeypoo: [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 [19:13:28] (03CR) 10jenkins-bot: [V: 04-1] [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 (owner: 10Mooeypoo) [19:14:33] (03PS4) 10Mooeypoo: [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 [19:16:37] (03CR) 10Sbisson: [C: 04-1] [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 (owner: 10Mooeypoo) [19:20:30] RoanKattouw, it re-imported normally: https://kab.wikipedia.org/wiki/Amyannan_umsqedac:Ijon . [20:55:20] mooey|food: Please review https://gerrit.wikimedia.org/r/305602 https://gerrit.wikimedia.org/r/304584 https://gerrit.wikimedia.org/r/305161 [21:00:11] RoanKattouw, you found the regression? [21:00:20] Yes, right after you left yesterday [21:00:38] (03CR) 10Mooeypoo: [C: 032] Tweak badge styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304584 (https://phabricator.wikimedia.org/T141923) (owner: 10Catrope) [21:00:54] why was width: 100% added? :\ [21:01:32] Because lots of / all users of MenuSelectWidget in OOUI itself added width: 100% in their own styles [21:01:44] (03CR) 10Mooeypoo: [C: 032] Make Monobook use the same badge color scheme as Vector [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305161 (owner: 10Catrope) [21:01:45] e.g. https://gerrit.wikimedia.org/r/#/c/305054/1/src/styles/elements/LookupElement.less [21:01:58] There were 4 of those [21:02:07] * mooeypoo mutters [21:02:27] well, to be fair, we *are* abusing this widget [21:02:36] it's not quite supposed to do what we're telling it to do [21:02:48] though that, too, is a mistake in ooui imho, but that's a different issue [21:04:15] Yeah there's a gap in OOUI's feature set that we're hacking this widget to fill [21:05:06] RoanKattouw, just one comment on your menu fix, then [21:05:23] we already have (small) styles for the action menu in mw.echo.ui.NotificationItemWidget.less [21:05:29] you want to move those now to the new less file? [21:05:39] or put this rule in there [21:06:36] Oh -actions-menu, is that where it is? [21:06:43] Maybe my width: auto; rule should be there then [21:06:48] yeah [21:07:03] in the popup though [21:07:06] I couldn't find anything targeting the menu directly, but I guess it's using -menu instead of .oo-ui-menuSelectWidget [21:07:17] oh, we could still have that less file [21:07:25] but then just move those few stylings in there [21:07:29] whatever seems more organized [21:08:59] Ahm, here's the problem [21:09:03] The menu is in an overlay [21:09:12] So the rules you're pointing to, I don't think they're applied to anything [21:10:02] $('.mw-echo-ui-notificationItemWidget-content-actions-menu .oo-ui-popupWidget-popup') [21:10:02] [] [21:10:09] -menu is the dotdotdot button [21:10:15] But the popup is not inside of it, it's in an overlay [21:11:40] ooh [21:11:47] wow [21:11:48] ha [21:12:04] okay, well, that sorts it out, doesn't it :P We should move the .oo-ui-popupWidget-popup { ... } rule into the new file [21:12:12] or, considering it wasn't applied and no one missed it, delete it [21:12:14] Now checking if it's always always in an overlay [21:12:20] If so I'll delete those rules [21:12:31] The font-size fix is done on the overlay, and I'm not sure the padding rule makes any sense [21:13:51] RoanKattouw, I think it is, yeah [21:13:59] It used not not be [21:14:06] (I almost wrote it usedn't, hehe) [21:14:51] (03Merged) 10jenkins-bot: Tweak badge styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304584 (https://phabricator.wikimedia.org/T141923) (owner: 10Catrope) [21:14:54] (03CR) 10jenkins-bot: [V: 04-1] Make Monobook use the same badge color scheme as Vector [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305161 (owner: 10Catrope) [21:19:54] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Page-deletion, 05MW-1.28-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Failed restore and data loss on ar_rev_id collisions - https://phabricator.wikimedia.org/T135852#2568704 (10Etonkovidova) Checked the second scenario - **One pa... [21:20:23] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10ORES: Research system for signifying ORES good-faith and damaging scores - https://phabricator.wikimedia.org/T143451#2568705 (10Mattflaschen-WMF) [21:22:52] uh [21:23:06] RoanKattouw, https://gerrit.wikimedia.org/r/305161 seemed to have failed for no reason? [21:23:14] do I re-+2? [21:23:22] RoanKattouw, re:^ Can we (I!) safely add ".mw-echo-notifications-badge::before {top:2px;}" in order to nudge the icons down a bit, so that they're not touching the top of the window? [21:23:50] err, scrolled now, but re: Tweak badge styles [21:24:18] quiddity: Is this still a problem on beta labs now that my "Tweak badge styles" patch has merged? [21:24:20] etonkovidova, you followed the steps under "One page with multiple deleted revisions." exactly? [21:24:28] https://phabricator.wikimedia.org/T135852#2548746 [21:24:30] yup [21:24:31] Not that I deliberately tried to change the alignment in Monobook though [21:24:33] Hmm OK [21:24:46] RoanKattouw, quiddity wait, some people argued it was too low though...no? Or was that just in monobook? [21:24:49] * RoanKattouw checks what that looks like and what the current top value is [21:24:57] We might want to make it smaller in general [21:24:58] I'm just talking about monobook. [21:25:14] matt_flaschen: I am re-checking, but I am pretty sure that I followed exactly the same steps. [21:25:25] and it was the number that was too low. xaosflux notes that the icons are too high. [21:25:26] mooeypoo: "Segmentation fault" so yes it failed for no reason. Vote 0 and then vote +2 again [21:25:30] of course, I just realized that's the patch... quiddity so if it needs to be lower but higher, should we make it **smaller** / [21:25:46] RoanKattouw, should I, or should I wait now? [21:25:47] The alignment of the number did change with my patch [21:25:50] mooeypoo: Do it [21:25:54] dooo itttt [21:26:05] etonkovidova, okay, make sure you restart at the beginning too as it says. I would expect all 3 to get restored if there are no collisions (obviously not a real problem, just means it didn't hit the intended test scenario). [21:26:06] NAO [21:26:24] (03CR) 10Mooeypoo: Make Monobook use the same badge color scheme as Vector [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305161 (owner: 10Catrope) [21:26:36] (03CR) 10Mooeypoo: [C: 032] Make Monobook use the same badge color scheme as Vector [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305161 (owner: 10Catrope) [21:26:44] * mooeypoo stares [21:26:48] go go go [21:27:06] quiddity: OK I see what you mean. Your suggestion however moves the icons down but not the numbers and that makes it look kind of weird post my patch IMO [21:27:15] matt_flaschen: I got an impression that Special:Log and Special:Undelete do different stuff when I am restoring pages... will re-check [21:27:29] RoanKattouw, how about move the icon down and the numbers up ? [21:27:38] IE, make it "smaller" vertically? [21:27:39] We did just move the numbers up in my patch [21:27:46] upperer [21:27:52] up up and awaaaaay [21:27:54] My concern is that the numbers now mostly overlap the icon [21:28:11] etonkovidova, make sure you delete it normally with the delete tab, not from history page/revdel. I think you did for the other scenario, though. [21:28:53] matt_flaschen: yeah, I am deleting with the delete tab [21:29:02] Hmm but alignment-wise 2px is probably the right value [21:29:07] RoanKattouw, well... that's one way to encourage people to mark all notifications as read [21:30:24] eh, I'll just submit a patch, and you can accept or decline. patches! fun! [21:31:26] (03CR) 10jenkins-bot: [V: 04-1] Make Monobook use the same badge color scheme as Vector [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305161 (owner: 10Catrope) [21:32:07] quiddity: I've just got it actually, there are other Monobook-specific top rules already and I found a way to tweak those rather than add a third [21:32:27] nod. <3 [21:32:43] Although now I do feel bad for depriving you of an opportunity to submit a patch [21:32:45] err [21:32:52] etonkovidova, if it happens again, let me know and I'll retest. Also before you restore, do a DB query on the archive table. [21:33:06] RoanKattouw, it seems jenkins just doesn't like you [21:33:19] RoanKattouw, maybe you should give this patch to quiddity [21:33:28] hah [21:33:30] ;p [21:33:41] /jenkins https://i.imgur.com/zuGQrYX.png [21:33:42] Or jenkins doesn't like me +2ing [21:34:10] (03PS1) 10Catrope: Move the badges down a bit in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305741 [21:34:30] quiddity: ---^^ If there's a task number that I forgot, please add it [21:34:53] nope, I didn't file anything. Just user feedback at VPT so far. [21:35:21] One day we should take all the monobook patches we have and plot them in an animation [21:35:28] matt_flaschen: sigh... I do not see ar_rev_id collision for your first scenario. But please do not test anything yet - I am still checking [21:35:57] mooeypoo: https://gerrit.wikimedia.org/r/305741:) [21:36:10] "move up move down move left move up no no, move down, a little mo-- yes! now revert, move up, twist, down, and do the samba." <-- the collected summary of monobook CSS fixes [21:37:01] omg, no one can tell me one pixel is irrelevant anymore [21:37:12] or two. [21:37:57] (03CR) 10Mooeypoo: [C: 032] Move the badges down a bit in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305741 (owner: 10Catrope) [21:38:12] Go go power jenkins! [21:39:37] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143455#2568756 (10jmatazzoni) [21:41:29] OK that was a bit of investigation but it turns out that nothing attempts to use NotificationItemWidget without an overlay [21:41:36] That said, it appears to be legal to do so [21:43:37] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10ORES: Research system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143451#2568788 (10jmatazzoni) [21:44:18] Oh but even then it uses itself as the "overlay" [21:44:22] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143455#2568790 (10jmatazzoni) [21:45:18] Oh and... it's not a popup any more anyway [21:45:19] D'oh [21:45:23] OK so that CSS can just be removed [21:46:30] (03Merged) 10jenkins-bot: Move the badges down a bit in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305741 (owner: 10Catrope) [21:48:06] matt_flaschen: that's it - I cannot reproduce the results that I had in the morning! There is no ar_rev_id collisions - not at all. [21:48:47] matt_flaschen: it's either your fix is really great, or mysql is deceiving me when it reports that it's re-started :) [21:49:26] (03PS2) 10Catrope: Make dotdotdot menu not be extremely wide [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305602 [21:49:30] mooeypoo: ---^^ [21:49:55] RoanKattouw, the dotdotdot should always be in an overlay [21:50:03] we fixed that because otherwise it's "clipped" inside the popup [21:50:05] Yes, and it is [21:50:19] But even if for some reason it's not, it also isn't (and does not contain) a PopupWidget [21:50:33] So those styles were useless for two reasons [21:50:38] yeah [21:50:44] Anyway PS2 removes them [21:50:55] (03CR) 10Mooeypoo: [C: 032] Make dotdotdot menu not be extremely wide [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305602 (owner: 10Catrope) [21:50:59] I saw [21:51:05] now let's hope jenkins agrees [21:51:05] (03CR) 10Catrope: [C: 032] Make Monobook use the same badge color scheme as Vector [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305161 (owner: 10Catrope) [21:51:20] brb [21:51:21] Trying that one ---^^ one more time, if it fails again I'll complain to releg [21:51:36] 06Collaboration-Team-Triage, 10MediaWiki-History-or-Diffs, 10Parsoid, 10VisualEditor, 07Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#2568838 (10Jdforrester-WMF) [21:51:57] 06Collaboration-Team-Triage, 10MediaWiki-History-or-Diffs, 10Parsoid, 10VisualEditor, 07Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#1437960 (10Jdforrester-WMF) [21:52:25] 06Collaboration-Team-Triage, 10MediaWiki-History-or-Diffs, 10Parsoid, 10VisualEditor, 07Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#1437960 (10Jdforrester-WMF) [21:52:40] 06Collaboration-Team-Triage, 10MediaWiki-History-or-Diffs, 10Parsoid, 10VisualEditor, 07Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#1437960 (10Jdforrester-WMF) [21:53:27] (03CR) 10Catrope: [C: 032] Log edits in multiple sections that could trigger mentions. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [21:58:13] (03CR) 10Catrope: Moderate notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) (owner: 10Sbisson) [21:58:31] (03Merged) 10jenkins-bot: Make dotdotdot menu not be extremely wide [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305602 (owner: 10Catrope) [21:58:34] (03Merged) 10jenkins-bot: Make Monobook use the same badge color scheme as Vector [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305161 (owner: 10Catrope) [21:59:41] I keep reading Stephane's commit title as MAH-duh-ruht notifications (i.e. "moderate" as an adjective), even though he clearly means MAH-duh-rayt notifications (i.e. "moderate" as a verb) [22:00:01] (English...) [22:00:45] (03Merged) 10jenkins-bot: Log edits in multiple sections that could trigger mentions. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [22:03:43] (03PS3) 10Catrope: Log potential notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305022 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [22:06:00] (03PS4) 10Jakob: Log potential notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305022 (https://phabricator.wikimedia.org/T138938) [22:06:07] (03CR) 10Catrope: [C: 032] Log potential notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305022 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [22:08:11] etonkovidova, okay, re-testing. [22:13:26] (03Merged) 10jenkins-bot: Log potential notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305022 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [22:19:34] (03PS5) 10Mooeypoo: [EXPERIMENTAL] [DON'T MERGE] Add timestamps to generated notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 [22:21:10] (03PS9) 10Sbisson: Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) [22:24:12] (03CR) 10Catrope: [C: 032] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) (owner: 10Sbisson) [22:25:18] etonkovidova, it still works for me as I expect. [22:25:26] etonkovidova, do you want to screen share or just move on? [22:25:36] Just to confirm, ar_id is different from ar_rev_id. [22:25:56] matt_flaschen: yes, of course it's different hmm... [22:26:09] matt_flaschen: and you restart mysql as I do? [22:26:39] etonkovidova, yes, I restart exactly the same. [22:27:42] matt_flaschen: ok, then I will do some other stuff and re-check all scenarios later today - it's not like something is not working; it's kind of working too well :))) [22:28:48] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design interface for signaling and filtering ORES Good-Faith and Damaging scores as well as New Users - https://phabricator.wikimedia.org/T143452#2568924 (10jmatazzoni) a:03Pginer-WMF [22:31:06] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143455#2568934 (10jmatazzoni) [22:31:08] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10ORES: Research system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143451#2568935 (10jmatazzoni) [22:31:10] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design interface for signaling and filtering ORES Good-Faith and Damaging scores as well as New Users - https://phabricator.wikimedia.org/T143452#2568933 (10jmatazzoni) [22:34:18] (03Merged) 10jenkins-bot: Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) (owner: 10Sbisson) [22:34:54] (03CR) 10Catrope: [C: 04-1] Maintenance: moderate notifications linked to missing pages (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302480 (https://phabricator.wikimedia.org/T141816) (owner: 10Sbisson) [22:35:21] (03CR) 10Catrope: "This also needs a rebase, it conflicts with changes in the parent change in ways I don't know how to resolve" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302480 (https://phabricator.wikimedia.org/T141816) (owner: 10Sbisson) [22:36:02] 06Collaboration-Team-Triage, 06Design-Research, 10Edit-Review-Improvements, 10ORES: Research system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143451#2568949 (10jmatazzoni) a:03Capt_Swing [22:36:28] 03Collab-Team-Q1-July-Sep-2016, 06Design-Research, 10Edit-Review-Improvements, 10ORES: Research system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143451#2568684 (10jmatazzoni) [22:37:02] 03Collab-Team-Q1-July-Sep-2016, 06Design-Research, 10Edit-Review-Improvements, 10ORES: Research system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143451#2568684 (10jmatazzoni) [22:37:20] (03CR) 10Catrope: "Is this patch still needed? With the changes to TargetPageMapper that ended up landing, the title of the commit is now technically inaccur" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301618 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [22:37:22] 03Collab-Team-Q1-July-Sep-2016, 06Design-Research, 10Edit-Review-Improvements, 10ORES: Research system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143451#2568684 (10jmatazzoni) [22:39:24] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Design system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143455#2568958 (10jmatazzoni) [22:40:06] quiddity: Last time I'll bug you about this: do you happen to know which phab task Adam and I are referring to in the commit msg of https://gerrit.wikimedia.org/r/#/c/304452/2 ? [22:40:45] If you're able to locate it, I (or you) can add it to the commit message so it gets tagged. If not, no big deal, we can find the task 6 weeks from now and go "oh wasn't this fixed ages ago" as we do from time to time [22:41:14] (03CR) 10Catrope: [C: 032] DiscussionParser stripSig from mention content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304452 (owner: 10Addshore) [22:41:38] Whoops, canceling +2 [22:41:54] It would be counter-productive for me to merge that change 1 minute after asking someone to possibly amend it [22:42:08] RoanKattouw, nothing beyond last time. Aug 12 12:52:41 RoanKattouw, I can't find anything directly about it, only this related task (and the one mentioned within) https://phabricator.wikimedia.org/T130157 [22:43:09] Sorry I missed that response at the time, looking [22:43:26] OK no that's not really what I was looking for [22:43:31] I'll merge without a bug number then [22:43:37] (03CR) 10Catrope: [C: 032] DiscussionParser stripSig from mention content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304452 (owner: 10Addshore) [22:47:45] np! [22:47:55] (03Merged) 10jenkins-bot: DiscussionParser stripSig from mention content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304452 (owner: 10Addshore) [23:19:49] (03CR) 10Catrope: [C: 04-1] Add dynamic secondary actions to notification items (0312 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [23:20:25] 03Collab-Team-Q1-July-Sep-2016, 06Design-Research, 10Edit-Review-Improvements, 10ORES: Research system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143451#2569003 (10jmatazzoni) [23:22:39] 03Collab-Team-Q1-July-Sep-2016, 06Design-Research, 10Edit-Review-Improvements, 10ORES: Research system for signifying ORES Good-Faith and Damaging scores - https://phabricator.wikimedia.org/T143451#2569005 (10jmatazzoni) [23:26:47] 06Collaboration-Team-Triage, 10Notifications: Evaluate design of notifications inbox (“tray”) icon - https://phabricator.wikimedia.org/T142511#2569011 (10jmatazzoni) [23:30:26] 06Collaboration-Team-Triage, 10Flow: [betalabs] Check mark for Resolved topics placed too low - https://phabricator.wikimedia.org/T132195#2569015 (10jmatazzoni) [23:39:35] (03CR) 10Catrope: [C: 04-1] Add unwatch topic/board dynamic action for Flow notifications (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [23:46:06] RoanKattouw, is phpdoc also an automatic thing? [23:46:22] Yes, it uses software called Doxygen [23:46:25] Finding the link [23:46:26] does it know to mark things as optional if they're set in the method signature? or is this just for people reading the code? [23:46:34] https://doc.wikimedia.org/mediawiki-core/master/php/ [23:46:38] I believe it does [23:46:42] Looking for an exmaple [23:46:43] ooh [23:46:50] Do we have it for Echo/ [23:47:06] https://doc.wikimedia.org/mediawiki-core/master/php/classTitle.html#a6f93e53917900606c94cd72191f85042 [23:47:08] We probably should, considering we let people add notification types and interact with Echo's core [23:47:35] Hmm apparently not [23:47:36] And yes [23:47:37] oh okay, interesting. God forbid there will be consistency between documentation methods [23:47:41] We should [23:47:56] But yeah, we probably should - and wouldn't hurt to do the same for Echo front end [23:47:56] CentralAuth doesn't have it either, that's another important one [23:47:59] And there are probably more [23:48:02] indeed [23:48:09] Yup, Flow JS already has docs rigged up [23:48:21] We take such good care documenting (for the most part, ahem) we might as wlel [23:48:22] Echo JS does not, apparently, or at least it's not on the doc.wm.o home page [23:48:34] also, it goes iwth the task of documenting how to add new notification typs [23:48:35] types [23:48:56] We do have jsduck running in Echo [23:49:02] seems to be just a matter of publishing it? [23:50:21] "just" ... I have no idea what that entails [23:52:15] mooeypoo, yeah, my dad hates that word, one sec, I'll dig it up. [23:52:40] "just" ? [23:52:47] 06Collaboration-Team-Triage, 10Flow: Automatically generate JSDuck documentation on commit - https://phabricator.wikimedia.org/T88201#2569035 (10Mattflaschen-WMF) [23:52:49] 06Collaboration-Team-Triage, 10Flow, 07Documentation, 13Patch-For-Review: jsduck for Flow - https://phabricator.wikimedia.org/T94625#2569037 (10Mattflaschen-WMF) [23:52:49] That's an odd word to hate. Though understandable. [23:53:19] mooeypoo, he is skeptical of it when used in that sense (oh, it must be easy). [23:53:44] 06Collaboration-Team-Triage, 10Flow, 07Documentation, 13Patch-For-Review: jsduck for Flow - https://phabricator.wikimedia.org/T94625#1168385 (10Mattflaschen-WMF) [23:53:46] 06Collaboration-Team-Triage, 10Flow: Automatically generate JSDuck documentation on commit - https://phabricator.wikimedia.org/T88201#1005981 (10Mattflaschen-WMF) [23:53:55] 06Collaboration-Team-Triage, 10Flow, 07Documentation, 13Patch-For-Review: jsduck for Flow - https://phabricator.wikimedia.org/T94625#1168385 (10Mattflaschen-WMF) 05duplicate>03Resolved [23:54:37] mooeypoo, https://gerrit.wikimedia.org/r/217448 . [23:54:46] And https://gerrit.wikimedia.org/r/217961 .