[00:01:52] RoanKattouw, hm I can't find a test device. [00:02:10] I'll try again tomorrow morning when people are at the office again? [00:02:15] I know it's late but hopefully someone from Reading is over on the other side of 3 and can give you a device? [00:02:32] Or ask Elena where they are kept [00:02:39] Or, yeah, try tomorrow [00:08:38] I have a device [00:08:39] it's infernal [00:08:43] I am giving up [00:09:06] Is there no way to move the cursor if you want to change 1 character at the middle !? [00:09:14] * mooeypoo stares at the infernal device in horror [00:11:39] RoanKattouw, well, it's not happening in this device [00:11:41] it's wrapping properly [00:11:44] I am at a loss [00:11:44] Hah [00:11:56] Also, the screen is cracked and I have no idea how to check what version this is [00:12:07] AND i had to log in AGAIN. Twice. [00:12:08] Maybe ask Elena tomorrow to reproduce on iOS and then try reproducing on Android or on desktop [00:12:15] * mooeypoo nods [00:12:17] with her account I mean [00:12:19] yeah [00:12:36] ok I'm giving the device back to where it came from [00:12:37] Cause you've generated a notification that you *think* might trigger it but we don't actually know anything except that Elena has one that triggers it [00:12:47] Yep [00:46:14] 06Collaboration-Team-Triage, 10ArchCom-RfC, 10MediaWiki-ContentHandler, 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2563148 (10RobLa-WMF) [00:46:44] 06Collaboration-Team-Triage, 10Notifications: Provide a single entry point for notification that anticipates the urgency of the notifications received - https://phabricator.wikimedia.org/T142981#2553013 (10kaldari) Here are my 2 cents (as both a notifications power user and the tech lead of the original Echo t... [00:51:29] 06Collaboration-Team-Triage, 10ArchCom-RfC, 10MediaWiki-ContentHandler, 07ArchCom-Has-shepherd, 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2563154 (10RobLa-WMF) [01:35:52] 06Collaboration-Team-Triage, 10Notifications: Provide a single entry point for notification that anticipates the urgency of the notifications received - https://phabricator.wikimedia.org/T142981#2563228 (10Volker_E) >>! In T142981#2563149, @kaldari wrote: > * Red used to consistently indicate "unread" (not blu... [06:04:17] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 07Need-volunteer, and 4 others: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#1582085 (10Johan) This has been marked for inclusion in Tech News and is resolved, but these... [07:11:06] 06Collaboration-Team-Triage, 10Notifications: Provide a single entry point for notification that anticipates the urgency of the notifications received - https://phabricator.wikimedia.org/T142981#2563432 (10kaldari) >Red is in most UI (and real-world information-design) contexts used as urgent/error/strong warn... [07:43:28] 06Collaboration-Team-Triage, 10Notifications: Provide a single entry point for notification that anticipates the urgency of the notifications received - https://phabricator.wikimedia.org/T142981#2563457 (10Pginer-WMF) >>! In T142981#2562737, @jmatazzoni wrote: > The idea that I'd see a red "7", but that only t... [08:57:32] (03PS5) 10WMDE-Fisch: Log edits in multiple sections that could trigger mentions. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) [09:00:37] (03CR) 10WMDE-Fisch: Log edits in multiple sections that could trigger mentions. (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [09:51:00] (03CR) 10Jakob: [C: 04-1] Log edits in multiple sections that could trigger mentions. (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [10:11:00] (03PS6) 10WMDE-Fisch: Log edits in multiple sections that could trigger mentions. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) [10:11:19] (03CR) 10WMDE-Fisch: Log edits in multiple sections that could trigger mentions. (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [10:16:53] (03CR) 10Jakob: Log edits in multiple sections that could trigger mentions. (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [10:17:14] (03PS1) 10WMDE-Fisch: Bold usernames in single mention status messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305473 [10:18:14] (03PS2) 10WMDE-Fisch: Bold usernames in single mention status messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305473 [11:10:12] (03CR) 10Sbisson: [C: 04-1] "In some cases you check if its the use talk page before adding the unwatch action and in some cases you don't. Any reason for that?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [11:12:37] (03CR) 10Jakob: [C: 031 V: 031] "Looks good!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305473 (owner: 10WMDE-Fisch) [12:24:30] (03PS1) 10WMDE-Fisch: DNM Test diff of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 [12:28:29] (03CR) 10jenkins-bot: [V: 04-1] DNM Test diff of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (owner: 10WMDE-Fisch) [12:43:05] (03PS2) 10WMDE-Fisch: DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) [12:47:12] (03CR) 10jenkins-bot: [V: 04-1] DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) (owner: 10WMDE-Fisch) [12:58:09] (03PS7) 10WMDE-Fisch: Log edits in multiple sections that could trigger mentions. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) [12:59:43] (03CR) 10WMDE-Fisch: Log edits in multiple sections that could trigger mentions. (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [13:02:07] (03Abandoned) 10WMDE-Fisch: Bold usernames in single mention status messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305473 (owner: 10WMDE-Fisch) [13:03:20] (03CR) 10Jakob: [C: 031 V: 031] Add bold names for mentions status notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304196 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch) [16:37:00] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): [betalabs-Regression] Special:Notifications page displays wrong date format for messages - https://phabricator.wikimedia.org/T141915#2564829 (10Etonkovidova) Checked the fix in betalabs. [17:15:45] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Notification side panel: For current wiki with zero unread notifications the title should be greyed out - https://phabricator.wikimedia.org/T139646#2565067 (10Etonkovidova) Checked in b... [17:16:35] Hey folks. I'll be running a little late to the ERI meeting today [17:16:43] Or EIR meeting lol [17:16:50] Edit improvements review! [17:24:31] halfak, I think EIR is the permanent acronym at this point. It's like SAT, it doesn't stand for anything. But it is synonymous with Edit Review Improvements. [17:25:53] Getting lunch now. I will be out later 12:15 - 3:45 Pacific for the OSM thing. Will be on after that. [17:32:01] Actually, I am probably leave work a little later than that since I'm driving now. [17:54:52] 06Collaboration-Team-Triage, 10MediaWiki-History-or-Diffs, 10Parsoid, 10VisualEditor, 07Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#2565214 (10Jdforrester-WMF) [18:14:31] [The word "signify" keeps coming up in this meeting. Obligatory link to https://en.wikipedia.org/wiki/Signifyin%27 ;) ] [18:23:10] 06Collaboration-Team-Triage, 10ArchCom-RfC, 10MediaWiki-ContentHandler, 07ArchCom-Has-shepherd, 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2565322 (10RobLa-WMF) Daniel provided a summary of the 2016W33 ArchCom office hour discussion (E261) in T142980, which I'll quote h... [18:24:40] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: How did a PageTriage review log entry and notification appear a month after initial page-patrol - https://phabricator.wikimedia.org/T143286#2562956 (10Etonkovidova) The issue - the patrolled and reviewed events are separated by some time interva... [18:36:46] 06Collaboration-Team-Triage, 10Flow: templates are not parsed in Flow topic headings - https://phabricator.wikimedia.org/T143243#2561763 (10Etonkovidova) Also, there was much work done on keeping Flow titles safe for Echo Notificaitons - {T120291} and {T120324}. One unresolved issue {T141460} shows how diffe... [18:57:18] 06Collaboration-Team-Triage, 10Flow: templates are not parsed in Flow topic headings - https://phabricator.wikimedia.org/T143243#2565468 (10Mattflaschen-WMF) 05Open>03declined I agree with @quiddity , declining. [19:14:31] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Support-and-Safety: Give WMF staff with global-flow-create the right to rename pages globally - https://phabricator.wikimedia.org/T133901#2565499 (10Mattflaschen-WMF) It turns out this is a hidden abuse filter: https://he.wikip... [19:21:26] James_F or RoanKattouw, can you check what https://he.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%9E%D7%A1%D7%A0%D7%9F_%D7%94%D7%94%D7%A9%D7%97%D7%AA%D7%95%D7%AA/47 does and PM me? [19:21:35] It's a private abuse filter causing T133901 . [19:21:35] T133901: Give WMF staff with global-flow-create the right to rename pages globally - https://phabricator.wikimedia.org/T133901 [19:30:12] (03CR) 10Mooeypoo: "> In some cases you check if its the use talk page before adding the" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [19:33:53] Heading out, will be back on later. [19:58:34] RoanKattouw, You mentioned something about editing the overflow-x of the popup menus? I am running into a recurring issue now that I have no idea where it came from unless we did something new? [20:00:08] (03CR) 10Sbisson: "Ok, but why checking only for some event types? From the header-edited notification I cannot unwatch my own talk page but from new-topic I" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [20:02:54] (03CR) 10Mooeypoo: "> Ok, but why checking only for some event types? From the" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [20:10:13] mooeypoo: See NotificationBadgeWidget.less lines 40-44 [20:10:31] I put in overflow-y and -x rules to work around two different bugs [20:10:57] I feel like overflow-x: auto; applied to the wrong thing could conceivably cause scrollability in mobile [20:11:14] But this only applies to the popup, not the special page, so I think I was wrong [20:13:04] (03CR) 10Catrope: [C: 032] Add bold names for mentions status notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304196 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch) [20:13:31] (03PS1) 10Mooeypoo: Mobile action menu should stick to bottom of screen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305572 (https://phabricator.wikimedia.org/T142013) [20:13:54] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 07Mobile, 13Patch-For-Review: [mobile] the dotdotdot menu layout improvements on Special:Notifications page - https://phabricator.wikimedia.org/T142013#2565711 (10Mooeypoo) a:03Mooeypoo [20:14:05] RoanKattouw, the action menu now appears 100% width for me, but this is new [20:14:09] and I'm not sure where this came from [20:14:28] I was wondering if it's something with the overflow since you said it has to do with the clippable behavior [20:14:30] but I am not sure [20:15:44] halfak, matt_flaschen: EIR stands for Environmental Impact Review, a component of California's development (dis)approval bureaucracy [20:16:00] loool :) [20:16:03] mooeypoo: What is the "action menu"? [20:16:07] Fitting, as it sounds like "air" [20:16:13] RoanKattouw, the dotdotdot menu [20:16:21] halfak: https://en.wikipedia.org/wiki/California_Environmental_Quality_Act#Environmental_Impact_Report_.28EIR.29 [20:16:30] click it = it stretches all the way to the right edge of the screen now [20:16:32] this is new :\ [20:18:02] On the special page, or in the popup? On desktop or mobile? [20:18:43] Sorry, yeah, in the special page desktop [20:18:58] mobile popup is being overridden (and now will also in the special page mobile) [20:19:13] halfak: Basically if you are a NIMBY in California and you want to delay/block a construction project, you sue the relevant govt agency under CEQA arguing that their EIR was in some way defective [20:19:13] I'm doublechecking for the desktop popup [20:19:32] And if you are a govt agency trying to build something in CA, you spend a year plus writing a hopefully watertight EIR [20:19:38] RoanKattouw, happens in desktop in both the special page and popup for me [20:19:46] Hmm OK [20:19:48] click the dotdotdot menu, and it stretches all the way to the edge of the screen [20:19:48] :\ [20:19:55] I guess I have to download your patch so that I will have notifs that have dotdotdot at all [20:20:04] yeah I think we didn't notice it because of ithat [20:20:24] RoanKattouw, you don't have to -- you can tweak the NotificationItemWidget code to put everything inside the dotdotdot [20:20:24] But wait, bundled notifs have one [20:20:34] change the counter condition [20:20:52] The ones inside bundles WFM in master [20:20:55] Oh yes, good point [20:21:01] set mw.echo.config.maxPrioritizedActions = 0 [20:21:20] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Measure how often the "mark all as read" action is used in the Notification Panel - https://phabricator.wikimedia.org/T127955#2059562 (10Etonkovidova) 'mark-entire-xwiki-bundle-read-click' event is... [20:22:24] I set mw.echo.config.maxPrioritizedActions = 0; in the console after opening one popup but before opening the other, and still WFM [20:22:27] No 100% width issues [20:22:34] (03Merged) 10jenkins-bot: Add bold names for mentions status notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304196 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch) [20:22:59] RoanKattouw, meh, http://imgur.com/a/FV8mB [20:23:40] RoanKattouw, is your mw repo up to date? [20:23:46] Good point [20:23:48] I am wondering if this is an ooui thing [20:23:59] This could be an OOUI regression [20:24:57] Yeah, that's what I'm thinking too, since the width of the popup seems to be stuck at 100% [20:25:14] And I can't figure out how to take it out ... I'm wondering if it's something with clippable or something [20:25:41] Yup I can reproduce [20:25:59] Do you want to git blame this or shall I? [20:28:33] RoanKattouw, if you have a moment that'll be greta, I'm fixing the unwatch flow fix [20:29:17] speaking of which, stephanebisson, re your point about checking for user page -- it strikes me now that if I'm already going to check all pages for isUserPage and put that check in the FlowPresentationModel - I might as well also check "is page watched" in there too.... [20:29:52] stephanebisson, just to verify here that I'm not missing something that I'm not thinking about, but that seems like the simplest, easiest and much more organized way to go, since we don't have "watch this page" reverse action anyways, and that isn't planned either [20:30:24] mooeypoo: sounds good [20:30:31] awesome, changing now [20:35:27] *git bisect [20:35:32] I'll get on that right after I grab a sandwich [20:38:10] (03PS14) 10Mooeypoo: Add unwatch topic/board dynamic action for Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [20:38:20] stephanebisson, ^^ I think this is much simpler now [20:38:43] thanks for the comments! I am still getting used to the php side of things, I think I overcomplicated while testing my way around it ;) [20:40:53] RoanKattouw, also, wait, how the do you even bisect ooui inside mw?? the repo is outside and requires build and copy-over and--- oh. yikes... O.o [20:58:15] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Instrument how frequently Special:Notifications is visited - https://phabricator.wikimedia.org/T121939#1891989 (10Etonkovidova) @Mooeypoo A question: should ` 'action' => 'special-page-... [21:05:58] mooeypoo: Yes that's why I offered to do it [21:06:06] I have a 1:1 with Trevor now but after that I'll bisect [21:07:11] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Instrument how frequently Special:Notifications is visited - https://phabricator.wikimedia.org/T121939#2565979 (10Mooeypoo) >>! In T121939#2565928, @Etonkovidova wrote: > @Mooeypoo A qu... [21:07:28] RoanKattouw, meh^n https://phabricator.wikimedia.org/T121939#2565979 [21:07:29] wtf? [21:07:39] also, say hi to Trevor [21:08:17] OK I can look into that but not during a meeting [21:09:17] * mooeypoo nods [21:09:47] Seems the xwiki bundle is correct, now that I am rereading, but the special page *action* isn't logged right? Is it possible we have an issue wth the php version of the logging... I'm also trying to check [21:12:14] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Mobile: Different size boxes for bundled notifications - https://phabricator.wikimedia.org/T142662#2566001 (10Mooeypoo) I checked on an iOS device and I can't reproduce it either there. This is either not about the length of the username/topic name, or it mi... [21:13:02] etonkovidova, can you take another look at https://phabricator.wikimedia.org/T142662 ? I couldn't reproduce it in Android and in iOS, but I was using a slightly different example. A bit at a loss, can you try to see if you get the same in Android at all? I'm trying to see if this is an iOS issue or if this has to do with the exact example you're using [21:13:31] mooeypoo: sure. I m looking ... [21:14:06] very weird. I thought it was the length of the username, but it seems usernames and topics wrap correctly when I tried longer ones. [21:16:03] (I'm out for a bit, brain melting in the heat, bbl.) [21:36:39] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 10WikiProject-X, 07Design, 07Persona-Active-Editor: Explore ideas for Review Feeds - https://phabricator.wikimedia.org/T137814#2566102 (10Harej) [21:45:44] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Mobile: Different size boxes for bundled notifications - https://phabricator.wikimedia.org/T142662#2566118 (10Etonkovidova) @Mooeypoo There is a discrepancy in how the issue is displayed on the real device (iPhone 6s, iOS 9.3.2) and Chrome mobile emulator. H... [21:52:12] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-23_(1.28.0-wmf.16): Notification side panel: For current wiki with zero unread notifications the title should be greyed out - https://phabricator.wikimedia.org/T139646#2566122 (10jmatazzoni) 05Open>03Re... [21:55:44] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749049 (10Jdforrester-WMF) [22:12:53] 06Collaboration-Team-Triage, 10Notifications: Provide a single entry point for notification that anticipates the urgency of the notifications received - https://phabricator.wikimedia.org/T142981#2566173 (10jmatazzoni) @Pginer-WMF wrote: > their decision point is **before** the panel is opened. If we want to... [22:20:03] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2566200 (10Jdforrester-WMF) I also strongly li... [22:22:29] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Special:Notifications broken when EventLogging extension is not enabled - https://phabricator.wikimedia.org/T143092#2556730 (10Etonkovidova) Checked locally - no crashes. [22:37:17] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 07User-notice: [betalabs-Regression] Incorrect count when only cross-wiki notifications are present - https://phabricator.wikimedia.org/T140327#2566270 (10Etonkovidova) Re-checked all scenarios in betalabs - all seem to be fixed. Occasionally,... [23:13:12] Thanks, RoanKattouw and James_F|Away . [23:22:21] RoanKattouw, did you have time to upgrade linux to 16.04 yet? It's asking me if I want to, and I am wondering if it's safe and worthy [23:27:37] mooeypoo: I haven't yet, I'm waiting for a free weekend which I won't have for a while [23:28:13] And probably/hopefully my new laptop will arrive by then so I'll just do a fresh install of 16.04 on that one rather than upgrading this one [23:29:10] mooeypoo: xenial has PHP7! [23:29:43] one of my wikis is on 16.04 and it's doing pretty well so far [23:31:12] hmmm [23:31:17] Maybe I'll do it over the weekend [23:31:23] I should backup my document first, just in case [23:31:34] ... I hope I won't have to reinstall vagrant [23:59:07] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2566355 (10jmatazzoni) 05Open>03Resolved