[08:09:08] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 07Need-volunteer, and 4 others: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2552628 (10Pginer-WMF) >>! In T110604#2515956, @Trizek-WMF wrote: > I think @Pginer-WMF input... [08:50:09] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Reconsider styling of excerpts within bundles in light of fact that they have no close quote - https://phabricator.wikimedia.org/T141034#2552714 (10Pginer-WMF) >>! In T141034#2492567, @jmatazzoni wrote: > Note that the gray italic message e... [09:37:50] (03CR) 10Addshore: [C: 04-1] "Per discussion this should now be altered to log mentions that would be sent (and not actually send them)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300528 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [09:37:53] (03CR) 10Addshore: [C: 04-1] "Per discussion this should now be altered to log mentions that would be sent (and not actually send them)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [09:49:46] (03CR) 10WMDE-Fisch: [C: 04-1] "DNM we will log first what mentions would happen before adding this feature." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [09:50:23] (03PS5) 10WMDE-Fisch: DNM Send mentions when editing multiple sections in between sections. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) [11:13:48] (03PS1) 10WMDE-Fisch: Log edits in multiple sections that could trigger mentions. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) [11:17:29] (03CR) 10jenkins-bot: [V: 04-1] Log edits in multiple sections that could trigger mentions. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [11:19:46] (03PS2) 10WMDE-Fisch: Log edits in multiple sections that could trigger mentions. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) [11:56:17] (03CR) 10Addshore: [C: 04-1] Log edits in multiple sections that could trigger mentions. (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [12:01:18] 06Collaboration-Team-Triage, 10Notifications: Provide a single entry point for notification that anticipates the urgency of the notifications received - https://phabricator.wikimedia.org/T142981#2553013 (10Pginer-WMF) [12:04:51] (03PS6) 10Jakob: Send mentions when editing multiple sections in between sections. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [12:04:54] (03PS1) 10Jakob: [DNM] Send notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304807 (https://phabricator.wikimedia.org/T138938) [12:05:39] (03PS1) 10WMDE-Fisch: Fix mention failures not beeing sent. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304808 [12:12:20] (03CR) 10WMDE-leszek: [V: 031] "It indeed fixes the bug." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304808 (owner: 10WMDE-Fisch) [12:20:56] (03Abandoned) 10Jakob: Send notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300528 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [12:23:14] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Evaluate design of notifications inbox (“tray”) icon - https://phabricator.wikimedia.org/T142511#2553053 (10Pginer-WMF) >>! In T142511#2544161, @SBisson wrote: > The more I use Echo the more confused I am about having 2 panels. I always end up opening both or cl... [12:25:45] (03PS2) 10WMDE-Fisch: Fix mention failures not beeing sent. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304808 [12:26:48] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Evaluate design of notifications inbox (“tray”) icon - https://phabricator.wikimedia.org/T142511#2553068 (10Pginer-WMF) >>! In T142511#2544254, @Trizek-WMF wrote: >>>! In T142511#2544161, @SBisson wrote: >> If I knew how to write a user script, I would write one... [12:30:58] (03CR) 10WMDE-leszek: [C: 031] Fix mention failures not beeing sent. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304808 (owner: 10WMDE-Fisch) [12:32:43] 06Collaboration-Team-Triage, 10Notifications: Sitewide notifications through Echo - https://phabricator.wikimedia.org/T58361#608596 (10Branch) Any updates on this? It would be awesome! [12:40:14] (03CR) 10Addshore: [C: 032] Fix mention failures not beeing sent. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304808 (owner: 10WMDE-Fisch) [12:48:45] (03Merged) 10jenkins-bot: Fix mention failures not beeing sent. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304808 (owner: 10WMDE-Fisch) [13:33:31] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 03TCB-Team-Sprint-2016-08-11: Find the correct limits for mentions - https://phabricator.wikimedia.org/T142988#2553226 (10Lea_WMDE) [14:07:54] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Alerts and Notices icons are too large on 1.28-wmf.13 - https://phabricator.wikimedia.org/T141923#2553333 (10Pginer-WMF) >>! In T141923#2549905, @Catrope wrote: > @Pginer-WMF If you... [14:47:50] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review: Notification side panel: For current wiki with zero unread notifications the title should be greyed out - https://phabricator.wikimedia.org/T139646#2553419 (10Pginer-WMF) >>! In T139646#2480757, @jmatazzoni wrote: >So the questi... [16:05:27] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2553693 (10Lea_WMDE) 05Open>03Invalid Having discussed what happened on Friday, we (#tcb-team) decided to not pursue with e... [16:06:12] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 07Documentation: Make sure all changes are reflected in documentation - https://phabricator.wikimedia.org/T142189#2553697 (10Lea_WMDE) [16:13:15] (03CR) 10Sbisson: [C: 04-1] "EchoHtmlDigestEmailFormatter contains icons as well." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304299 (https://phabricator.wikimedia.org/T127794) (owner: 10Mooeypoo) [16:27:15] (03CR) 10Sbisson: "Did you think about no-js?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [17:12:28] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 03TCB-Team-Sprint-2016-08-11: Find the correct limits for mentions - https://phabricator.wikimedia.org/T142988#2553226 (10Addshore) The maximum number of people that can be mentioned in a single edit is deifned in the Echo... [17:12:50] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 03TCB-Team-Sprint-2016-08-11: Find the correct limits for mentions - https://phabricator.wikimedia.org/T142988#2553226 (10Addshore) a:03Addshore [17:22:56] 06Collaboration-Team-Triage, 10Notifications: Provide a single entry point for notification that anticipates the urgency of the notifications received - https://phabricator.wikimedia.org/T142981#2553981 (10Quiddity) [17:27:38] 06Collaboration-Team-Triage, 10Notifications, 07Design: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264#2554008 (10Quiddity) [17:38:52] (03CR) 10Mooeypoo: "> Did you think about no-js?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [17:42:08] RoanKattouw: I was talking about this ticket - https://phabricator.wikimedia.org/T137502 Do not see it working in betalabs ... [18:11:18] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2554251 (10Mattflaschen-WMF)... [18:12:33] (03PS2) 10Catrope: Tweak badge styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304584 (https://phabricator.wikimedia.org/T141923) [18:14:11] (03PS1) 10Catrope: Make footer notice link blue in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304865 [18:20:11] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Invite users to try the new Notifications page (using the Notifications panel) - https://phabricator.wikimedia.org/T141414#2497647 (10Etonkovidova) In Monobook skin (Ch... [18:32:08] mooeypoo, could use a re-review on https://gerrit.wikimedia.org/r/#/c/280366/ (Don't actually flip direction of page for directionality unit tests). [18:35:11] Getting lunch [18:36:21] (03PS1) 10Catrope: Follow-up 4e64643eb: Count pageless notifications when counting pageless notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304873 (https://phabricator.wikimedia.org/T137502) [18:49:10] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15): Notifications from moderated post are not purged - https://phabricator.wikimedia.org/T142758#2554452 (10Etonkovidova) Checked in betalab. All notifications generated from deleted/suppressed posts a... [18:50:39] (03PS9) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [18:53:53] (03CR) 10Catrope: [C: 04-1] Log Special:Notifications page visits (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303079 (https://phabricator.wikimedia.org/T121939) (owner: 10Mooeypoo) [18:54:41] (03CR) 10Catrope: [C: 032] Log the mark entire cross-wiki bundle as read action [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303291 (https://phabricator.wikimedia.org/T127955) (owner: 10Mooeypoo) [18:54:48] (03CR) 10jenkins-bot: [V: 04-1] Log the mark entire cross-wiki bundle as read action [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303291 (https://phabricator.wikimedia.org/T127955) (owner: 10Mooeypoo) [18:59:33] (03PS5) 10Mooeypoo: Add a rasterized email icons to Echo modules for email [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304299 (https://phabricator.wikimedia.org/T127794) [19:00:35] (03CR) 10Mooeypoo: Log Special:Notifications page visits (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303079 (https://phabricator.wikimedia.org/T121939) (owner: 10Mooeypoo) [19:02:12] (03PS10) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [19:04:15] (03PS7) 10Mooeypoo: [wip] Allow unwatching of boards from Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [19:05:15] (03CR) 10jenkins-bot: [V: 04-1] Add a rasterized email icons to Echo modules for email [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304299 (https://phabricator.wikimedia.org/T127794) (owner: 10Mooeypoo) [19:12:46] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, 13Patch-For-Review: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2554688 (10Etonkovidova) {T142758} was checked - all notifications generated fro... [19:14:34] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07JavaScript, 07Technical-Debt: Remove use of jquery.tipsy in PageTriage - https://phabricator.wikimedia.org/T143039#2554716 (10Jdforrester-WMF) [19:19:30] (03CR) 10Sbisson: [C: 032] Follow-up 4e64643eb: Count pageless notifications when counting pageless notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304873 (https://phabricator.wikimedia.org/T137502) (owner: 10Catrope) [19:28:02] (03Merged) 10jenkins-bot: Follow-up 4e64643eb: Count pageless notifications when counting pageless notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304873 (https://phabricator.wikimedia.org/T137502) (owner: 10Catrope) [19:41:14] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "Call to a member function getTimestamp() on a non-object" on backfillUnreadWikis for frwiktionary - https://phabricator.wikimedia.org/T140697#2473206 (10Etonkovidova) Seemed to be fixed - no such errors in /srv/mw-log/exception.log [20:39:43] stephanebisson, so, I'm working on switching to full i18n keys rather than contructed ones, but it makes the API response more complicated... I think it works okay, but I am worried I'm over-engineering it. I'd like you to to have another pass on it when I'm done [20:40:35] mooeypoo: sure, are you sending the confirmation message as part of the secondary link or some other way? [20:41:05] stephanebisson, yeah I'll have to send both the item key and confirmation key -- thing is, we support having a title and description to both, so I have to give that option too [20:41:55] meh I am having a php syntax error, let me fix that and then I'll push the WIP [20:42:14] mooeypoo: alright, let me know when you want me to take a look [20:42:46] mooeypoo: it'll be a nice break from the darkness of flow caching [20:43:39] hah [20:43:55] I hope my fix doesn't make your eyes bleed like Echo-MVC's API layer [20:44:01] (which, btw, we should fix at some point) [20:45:53] (03PS11) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [20:46:07] (03PS8) 10Mooeypoo: [wip] Allow unwatching of boards from Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [20:46:19] stephanebisson, ^^ not tested yet but take a look at the 'data' structure? [20:47:55] mooeypoo: why do you send key and params instead of a formatted message? [20:48:16] stephanebisson, hm.... good.... point.... [20:48:27] also, wtf, "Call to undefined method Flow\NewTopicPresentationModel::getUser()" !? [20:48:38] Is it just me, or did this work before [20:49:21] stephanebisson, wait, so I don't need to register ANY i18n message keys... I just pass the full message as the data [20:49:26] ... that's ... simpler. [20:49:38] I would vote for that [20:49:44] Yeah, agreed [20:49:47] Didn't think about that [20:50:30] I don't think there's presentationModel::getUser, it comes up often as "would be useful", you can add it [20:51:49] stephanebisson, but this worked! [20:51:56] the condition existed before... [20:52:20] if ( $this->getUser()->isWatched( $this->event->getTitle() ) ) { .... [20:52:34] ^^ this existed in the previous patchsets and it worked ....... :/ [20:52:49] I rebased; could we have changed something recently? [20:53:53] mooeypoo: maybe it was "$this->user" which is private inside EchoEventPresentationModel [20:53:58] I added it in anyways now [20:54:00] yeah I see that [20:54:08] maybe it was a fluke I didn't notice... hm [20:54:16] anyways, I added 'getUser' now. Seems super useful anyways. [21:01:05] stephanebisson, you know, I'm deleting large chunks of code that -- only until moments ago -- I considered super clever. [21:02:47] There must be a special code-graveyard for clever but completely unnecessary code. [21:03:00] 10Collaboration-Team-Archive-2015-2016, 06Collaboration-Team-Triage, 10Notifications, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2555148 (10Quiddity) [21:03:45] mooeypoo: you mean like, most repos [21:04:02] stephanebisson, good point. [21:04:46] mooeypoo: being deleted is the natural end of the code lifecycle, it just got there faster, which is good [21:05:40] 06Collaboration-Team-Triage, 10Flow, 10Thanks: error code:http - Error message for network connection can be improved - https://phabricator.wikimedia.org/T142781#2555162 (10Catrope) [21:05:46] Tell that to MW core... [21:05:57] Or to monobook [21:06:55] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Resolved topics should be able to be deleted or suppressed without reopening them first - https://phabricator.wikimedia.org/T142779#2555164 (10Catrope) [21:07:29] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Resolved topics should be able to be deleted or suppressed without reopening them first - https://phabricator.wikimedia.org/T142779#2546121 (10Catrope) The issue here IMO is that deleting and resolving resolved topics should not be blocked, it should be allowed. You can... [21:08:11] one thing comes right from my adventure in PHP, I am starting to learn how to recognize the cryptic error messages [21:12:53] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Mobile: Different size boxes for bundled notifications - https://phabricator.wikimedia.org/T142662#2555176 (10Catrope) Clarification: this is about the different widths. The different heights are expected due to wrapping. [21:14:17] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Support-and-Safety: Give WMF staff with global-flow-create the right to rename pages globally - https://phabricator.wikimedia.org/T133901#2555181 (10Catrope) @Mattflaschen-WMF Do you know what might be going on here? [21:15:06] matt_flaschen: Is https://phabricator.wikimedia.org/T68699 done? I moved it to "In Development" but the comments suggest it might be more done than that [21:16:55] RoanKattouw, config change to flip the switch will be deployed tomorrow morning: https://gerrit.wikimedia.org/r/#/c/230954/ [21:17:20] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Convert LQT->Flow on en.wikinews - https://phabricator.wikimedia.org/T142707#2555186 (10Quiddity) I'm moving this into the RFP column, primarily for consistency with the other subtasks. How this actually gets resolved remains to be determined. The primary Enwikinews edit... [21:17:27] mooeypoo, getUser was part of the self-mention patch. [21:17:39] matt_flaschen, okay, so it *was* changed recently? [21:17:40] So that's why it used to exist. [21:17:42] aaahh [21:18:08] okay, I thought I went mad. It worked before, and I didn't change that line. Any objections for me bringing it back? Seems useful... but I guess I can also just use $this->user [21:18:39] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Make Notification page filters bookmarkable - https://phabricator.wikimedia.org/T137862#2555187 (10Catrope) [21:18:48] mooeypoo, no objections from me. Definition before was: [21:18:50] - final public function getUser() { [21:18:52] - return $this->user; [21:18:53] - } [21:19:00] yup, I added the same thing [21:21:04] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Reconsider styling of excerpts within bundles in light of fact that they have no close quote - https://phabricator.wikimedia.org/T141034#2555190 (10Catrope) So compared to the current state, what should we change? Just remove the italics bu... [21:21:38] 06Collaboration-Team-Triage, 10Flow: Add mediawiki.feedback dialog to Flow - https://phabricator.wikimedia.org/T124689#2555191 (10Quiddity) [21:22:19] 06Collaboration-Team-Triage, 10Flow: Add mediawiki.feedback dialog to Flow - https://phabricator.wikimedia.org/T124689#1962880 (10Quiddity) a:05Quiddity>03None [21:23:12] (03CR) 10Catrope: Log Special:Notifications page visits (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303079 (https://phabricator.wikimedia.org/T121939) (owner: 10Mooeypoo) [21:31:46] 06Collaboration-Team-Triage, 10Flow: Flow pages: better warning info/handling for edit conflicts - https://phabricator.wikimedia.org/T139219#2555249 (10Catrope) [21:33:03] 06Collaboration-Team-Triage, 10Flow, 07Regression: [production] Regression: FF only- flow-menu-js-drop cannot be dismissed after pressing Cancel - https://phabricator.wikimedia.org/T132211#2555271 (10Catrope) [21:36:21] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification: Dummy title used when section name is a magicword - https://phabricator.wikimedia.org/T141460#2555288 (10Catrope) Oh, ugh, I see, that's terrible. We'd have to parse it using the correct title somehow. [21:38:55] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Look into Echo charts - https://phabricator.wikimedia.org/T119424#2555310 (10Catrope) 05Open>03Invalid Closing as invalid since these graphs stopped working altogether, see {T132116} [21:39:33] 06Collaboration-Team-Triage, 10Flow: Validate which Flow moves are allowed? - https://phabricator.wikimedia.org/T96304#2555317 (10Catrope) [21:40:25] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, 10Wikimedia-Site-requests: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2555322 (10Catrope) a:05Catrope>03Mattflaschen-WMF [21:41:12] 06Collaboration-Team-Triage, 10Flow, 10Notifications: read-only mode for Notifications/Flow does not display user-friendly message - https://phabricator.wikimedia.org/T129925#2555327 (10Catrope) [21:43:44] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: "CAS update failed on gu_cas_token" thrown by CentralAuth autocreation jobs - https://phabricator.wikimedia.org/T140692#2555345 (10Catrope) 05Open>03Resolved a:03Catrope This shouldn't be happ... [21:44:10] 03Collab-Team-Q1-July-Sep-2016: Delete old instances that are no longer used - https://phabricator.wikimedia.org/T129389#2555350 (10Quiddity) [21:48:26] mooeypoo, I think I thought you needed to do it the message key way because there were client-side parameters. I guess not. [21:48:47] RoanKattouw, have kabwiki been noticed about the Flow support plan for user talk vs. other talk pages. [21:49:32] matt_flaschen, I thought so too, but I don't think so now... [21:50:27] 03Collab-Team-Q1-July-Sep-2016: [test2wiki] "[EchoInteraction] Missing or empty schema" error after expanding flyout - https://phabricator.wikimedia.org/T141669#2555355 (10Catrope) 05Open>03Invalid Turns out test2wiki is set up to use its own Schema namespace for testing, so this is "not a bug". [21:52:40] matt_flaschen: quiddity is finding out [21:53:01] (Benoît is on vacation so he can't answer that question) [21:53:35] Thanks [22:01:40] hey RoanKattouw! I have a quick question if you are around :0 [22:01:52] addshore: Hey, yeah sure [22:02:06] How do you feel about this in Echo https://gerrit.wikimedia.org/r/#/c/304805/2/includes/DiscussionParser.php [22:02:27] basically after the bad stuff with self mentions that we didnt foresee the figured this may be a much safer route for the other additions [22:03:04] log diffs of cases where these new mentions would be added, review the diffs for a few weeks, determine if the correct thing is being done / no odd edge cases pop up and then switch the code to actually send the mentions! [22:03:54] Oh that's a great idea [22:04:00] matt_flaschen, not that I can see, based on a g-translation of their April onwiki discussion. Do you think I should just link them to https://www.mediawiki.org/wiki/Flow#Development_status and request confirmation that they understand? [22:04:20] Thanks for being thoughtful here, I didn't initially realize that change also had the potential to turn into a self-mention-like debacle [22:04:39] We did basically the same thing for thank-you-edit when it was broken, disabled it but had it log every time it would have notified [22:04:46] * RoanKattouw should rip that logging back out now [22:04:51] haha! [22:05:11] okay, we will do this for all cases of new mentions then and I'll just get them in and we can review it all :) [22:05:41] yeh, in hindsight doing this for self mentions would have identified the cases we didnt consider before showing them to the community, but heh, oh well.... [22:05:45] addshore, FYI: I just tried out the mention notifications at Beta Cluster. The mention-success worked well! However I also tried to trigger a mention-failed notification by signing with 5 tildes ~~~~~ (a common mistake), and nothing happened. IDK if this circumstance is easily detectable though. [22:06:05] (03PS1) 10Catrope: Remove noisy logging of every single thank-you-edit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304932 [22:06:31] ooh, yeh, I don't think that is a mentions failure case that is easy to spot at all :/ ewhat does 5 tildas return? [22:06:36] addshore: Yup, well glad you guys are proceeding cautiously [22:07:27] 5tildes = timestamp [22:07:28] (03PS2) 10Catrope: Remove noisy logging of every single thank-you-edit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304932 [22:07:31] (03CR) 10Addshore: [C: 032] Remove noisy logging of every single thank-you-edit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304932 (owner: 10Catrope) [22:07:59] hmm, we might be able to identify that, I'll add a note and mention it to the team in the morning [22:08:45] (03CR) 10Catrope: [C: 04-1] Log edits in multiple sections that could trigger mentions. (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304805 (https://phabricator.wikimedia.org/T141863) (owner: 10WMDE-Fisch) [22:10:21] brilliant :) Right, time for bed RoanKattouw, unless you also feel like doin some review @ https://gerrit.wikimedia.org/r/#/c/290417/ ;) [22:11:17] quiddity, the part that is missing there is that currently only user talk gets first class support. [22:12:15] Exact message should probably be refined with RoanKattouw and maybe jmatazzoni___. [22:12:55] I.E. we're much less likely to add features intended only/primarily for non-user talk use cases. [22:14:31] (03Merged) 10jenkins-bot: Remove noisy logging of every single thank-you-edit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304932 (owner: 10Catrope) [22:20:01] nod, i'll leave it for now then. [22:26:47] matt_flaschen, quiddity: Would it be feasible / desirable to convert the user talk namespace first, then ask if they want to convert the rest? [22:26:56] mooeypoo: Could you review https://gerrit.wikimedia.org/r/304865 ? [22:27:26] RoanKattouw, that sounds very reasonable. [22:27:41] Cause I'd like to get at least part of that task unstuck [22:29:12] Yeah, definitely. [22:30:52] RoanKattouw, will do in a minute, dealing with the unwatch patch [22:34:13] matt_flaschen, RoanKattouw I have $this->msg( .. )->params( .. )->parse() to a message that has "foo [$1 $2]" --> I am getting it with "foo [bar baz]" instead of the html... isn't "parse()" parsing the wikitext to html?! what am I missing? [22:38:24] (03PS12) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [22:38:33] (03PS9) 10Mooeypoo: [wip] Allow unwatching of boards from Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [22:42:19] (03CR) 10jenkins-bot: [V: 04-1] Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [22:44:14] mooeypoo, probably, you need to make $1 a full URL. Try calling getFullURL instead of getLocalURL. [22:46:57] (03CR) 10Mooeypoo: [C: 032] Make footer notice link blue in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304865 (owner: 10Catrope) [22:48:57] matt_flaschen, it's already using 'getFullURL [22:49:34] mooeypoo, is the patch with that up? [22:49:38] I'll take a look. [22:50:05] matt_flaschen, I *think* I got it [22:50:52] matt_flaschen, I'm silly. I used the wrong parameter :\ [22:53:03] (03PS10) 10Mooeypoo: [wip] Allow unwatching of boards from Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [22:53:11] (03PS13) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [23:06:23] (03Merged) 10jenkins-bot: Make footer notice link blue in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304865 (owner: 10Catrope) [23:11:02] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Unseen notifications jump to the bottom and then back to the top - https://phabricator.wikimedia.org/T143067#2555751 (10Catrope) [23:11:23] mooeypoo: Fun bug for you --^^ [23:16:30] etonkovidova, I see you renamed T132393 from "[iOS 8.2] The dotdotdot menu does not work properly" to "[mobile] Notification overlay: the dotdotdot menu does not work properly". [23:16:32] T132393: [mobile] Notification overlay: the dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393 [23:16:39] Were you able to reproduce it beyond iOS 8.2? Just checking. [23:18:03] matt_flaschen: that's exactly what I am going to do right now - after bug triage meeting I made a list of issues to re-check. And that issue is on the list :) [23:19:31] etonkovidova, okay, thanks. It's not fixed in iOS 8.2 AFAIK (i'm working on it right now), but I was just wondering if there was anything new. [23:19:49] matt_flaschen: checking ... [23:24:32] (03PS14) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [23:29:11] matt_flaschen: https://phabricator.wikimedia.org/T132393 is still bad for iOS 9.3.2 too [23:29:46] matt_flaschen: especially if you do a little bit scroll up first, and then click on the dotdotdot menu [23:30:24] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: [iOS mobile] Notification overlay: the dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393#2555811 (10Mattflaschen-WMF) [23:31:36] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: [iOS mobile] Notification overlay: the dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393#2555817 (10Etonkovidova) Re-checked - 'Mark as read/unread' is removed from the dotdotdot menu (see {T141788}) - now the dotdotdot menu ha... [23:42:18] (03PS1) 10Catrope: Take seentime into account in the CheckLastModified hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304944 (https://phabricator.wikimedia.org/T134855) [23:52:59] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: [iOS mobile] Notification overlay: the dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393#2555843 (10Etonkovidova) [23:53:07] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2555844 (10Catrope) >>! In T134855#2497914, @Catrope wrote: > Moreover, seentime is not taken i... [23:56:21] (03PS1) 10Mooeypoo: Emit sortChange only for read/unread actions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304946 (https://phabricator.wikimedia.org/T143067) [23:56:47] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Unseen notifications jump to the bottom and then back to the top - https://phabricator.wikimedia.org/T143067#2555863 (10Mooeypoo) a:03Mooeypoo [23:57:01] (03CR) 10Catrope: [C: 032] Emit sortChange only for read/unread actions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304946 (https://phabricator.wikimedia.org/T143067) (owner: 10Mooeypoo) [23:59:54] mooeypoo: Also if you address the -1 on https://gerrit.wikimedia.org/r/303079 it can be merged