[00:00:06] I can live with $userName, especially when it has proper type (string or User) but some are meh [00:00:33] Yeah, I meant @param string $userName , but yeah. [00:00:50] (03CR) 10Mooeypoo: Add dynamic secondary actions to notification items (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [00:02:15] (03CR) 10Mooeypoo: [C: 04-1] "Temporarily -1'ing this so I can correct a few issues:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [00:02:27] I just -1'ed my commit so it's clear i should work on it more [00:02:36] I need to think and see what to do with the icons [00:02:46] The message bit is easy, I just need to fix it up, but the icons, hm. [00:03:35] ok I'm heading out for the weekend [00:03:50] I'll see you guys monday! have a good weekend [00:07:00] mooeypoo, yeah, I couldn't think of anything but making the presentation model return the family name, and using dynamic RL again. [00:07:24] Some clever way of looking up the family name from the icon name would be nice, but there is apparently no metadata at all (even family -> icon metadata). [00:07:29] mooeypoo, have a good weekend. [00:07:37] matt_flaschen, ... meh, sure, I guess we coudl do that... I'm a little meh about loading an entire package just for 1 icon [00:07:41] but I am not sure we can avoid that [00:08:48] mooeypoo, yeah, I don't see a valid alternative with the way the icons are currently packaged. [00:08:55] anyways, I'll think about this over the weekend, hopefully I'll have some clever/demonic idea by Monday [00:08:57] ;) [00:09:03] have a good weekend! see you monday [00:09:08] You too [00:39:18] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Display page-less notifications together with the user page - https://phabricator.wikimedia.org/T137502#2549989 (10Etonkovidova) Presently, in betalbs, pageless notifications grouped in... [01:08:39] 06Collaboration-Team-Triage, 10WikiLove, 10Brickimedia, 10Refreshed: WikiLove doesn't work with Refreshed - https://phabricator.wikimedia.org/T142534#2550005 (10ashley) Readding #WikiLove to get some input from upstream as this is (IMHO) more of a WikiLove bug than (just) a Refreshed bug. [01:36:00] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Flow: Update to stop using buildCssLinks and for related ConfirmEdit change - https://phabricator.wikimedia.org/T140472#2550024 (10Mattflaschen-WMF) >>! In T140472#2549890, @Etonkovidova wrote: > Re-checked in `1.28.0-wmf.14 (b... [01:41:37] 06Collaboration-Team-Triage, 06Labs: Investigate and remove NFS from editor-engagement project - https://phabricator.wikimedia.org/T102663#2550027 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03None [01:42:01] 06Collaboration-Team-Triage, 10Flow, 10Notifications, 13Patch-For-Review: Email notification about "someone edited the description on Flow board" should point to the diff, not the page - https://phabricator.wikimedia.org/T135136#2550028 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03None [01:46:11] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "Call to a member function getTimestamp() on a non-object" on backfillUnreadWikis for frwiktionary - https://phabricator.wikimedia.org/T140697#2550030 (10Mattflaschen-WMF) Should be fixed by {ed626af0ade5e7cdcd9cf30b695cba5a2e044c60} [01:58:18] Have a great weekend, everyone. [02:24:21] 06Collaboration-Team-Triage, 10WikiLove, 10Brickimedia, 10Refreshed: WikiLove doesn't work with Refreshed - https://phabricator.wikimedia.org/T142534#2538489 (10Legoktm) Is there/what is the skin-agnostic way to get the `` tag associated with `ca-wikilove`? [02:52:19] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2550044 (10Tgr) >>! In T6869... [08:08:13] (03PS9) 10Addshore: Bundle mention success and failure notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch) [08:08:25] (03CR) 10Addshore: [C: 032] Bundle mention success and failure notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch) [08:16:25] (03Merged) 10jenkins-bot: Bundle mention success and failure notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch) [08:31:04] 06Collaboration-Team-Triage, 10Thanks, 10Revision-Slider, 06TCB-Team, 03TCB-Team-Sprint-2016-08-11: RevisionSlider fails to re-trigger the Thanks JS code when the diff changes - https://phabricator.wikimedia.org/T142636#2541631 (10Addshore) I had a quick look around and couldn't really find a specific di... [11:32:02] 06Collaboration-Team-Triage, 10WikiLove, 10Brickimedia, 10Refreshed: WikiLove doesn't work with Refreshed - https://phabricator.wikimedia.org/T142534#2550284 (10LegoFan4000) [14:01:13] 06Collaboration-Team-Triage, 10Notifications, 07Privacy: Do not display content snippet of sent email - https://phabricator.wikimedia.org/T142910#2550442 (10Danny_B) [14:01:22] 06Collaboration-Team-Triage, 10Notifications, 07Privacy: Do not display content snippet of sent email - https://phabricator.wikimedia.org/T142910#2550455 (10Danny_B) p:05Triage>03High [15:18:35] 10Collab-Notifications-Page, 06Collaboration-Team-Triage: Notifications page HTML markup - https://phabricator.wikimedia.org/T51269#2550478 (10matej_suchanek) 05Open>03Resolved [22:10:52] 06Collaboration-Team-Triage, 10Notifications: "Notification-header-reverted" should have a period - https://phabricator.wikimedia.org/T142917#2551194 (10Guycn2) [22:38:19] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2551245 (10MZMcBride) >>! In...