[00:01:14] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Create design for adding ORES good-faith data to Recent Changes - https://phabricator.wikimedia.org/T142785#2546316 (10jmatazzoni) [00:01:15] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Add ORES Good Faith test to Recent Changes pages (for wikis on which ORES is enabled) - https://phabricator.wikimedia.org/T142783#2546315 (10jmatazzoni) [00:17:21] 03Collab-Team-Q1-July-Sep-2016: Collaboration FY2015-16 Retro reviewed and published - https://phabricator.wikimedia.org/T140824#2546334 (10Etonkovidova) [00:17:46] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Build an augmenteed RCStream feed that includes ORES scores - https://phabricator.wikimedia.org/T142786#2546335 (10jmatazzoni) [00:22:43] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2388575 (10PrimeHunter) Example templates which use {{REVISIONUSER}} to make code like "I'm [[User:PrimeHunter|PrimeHunter]]" w... [00:32:22] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2546409 (10jmatazzoni) A couple of answers to @Mooeypoo's questions > Reversible / opposite actions: This ticket only discusse... [00:34:16] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Notifications, 05MW-1.28-release-notes, and 2 others: Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2546425 (10jmatazzoni) 05Open>03Resolved [01:10:42] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2546560 (10MZMcBride) For what it's worth, I think RoanKattouw: Trouble a-brewin'. [01:20:14] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2546576 (10MZMcBride) >>! In T138080#2546361, @PrimeHunter wrote: > Example templates which use {{REVISIONUSER}} to make code l... [01:26:29] 06Collaboration-Team-Triage, 10Notifications: Echo: Remove the signature-requirement for Mention notifications - https://phabricator.wikimedia.org/T66778#683278 (10MZMcBride) Related: {T128535}. [01:27:51] 06Collaboration-Team-Triage, 10Notifications: Consider ping parser function instead of link-based mention - https://phabricator.wikimedia.org/T128535#2546590 (10MZMcBride) Related: {T138080}. Specifically T138080#2546576. [01:28:27] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Notification badges misaligned in Monobook in IE11 and below - https://phabricator.wikimedia.org/T142053#2521072 (10matmarex) The hack was undone (https://gerrit.wikimedia.org/r/#/q/Ia5a0a6b6be3698436a04... [01:37:19] so… how did i mention myself in the edit? https://commons.wikimedia.org/w/index.php?title=Commons:Village_pump&oldid=prev&diff=203742927 [01:38:45] 06Collaboration-Team-Triage, 10Notifications: False "You mentioned yourself" notification - https://phabricator.wikimedia.org/T142798#2546615 (10matmarex) [01:40:06] MatmaRex, don't know, but I'm about to disable it. [01:43:59] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2546640 (10Quiddity) [01:44:01] 06Collaboration-Team-Triage, 10Notifications: False "You mentioned yourself" notification - https://phabricator.wikimedia.org/T142798#2546642 (10Quiddity) [01:44:31] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2388575 (10Quiddity) They're working on turning it off, right now. [01:48:05] (03Merged) 10jenkins-bot: Revert "Allow self mentions" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304426 (owner: 10Mattflaschen) [01:50:02] (03PS1) 10Mattflaschen: Revert "Allow self mentions" [extensions/Echo] (wmf/1.28.0-wmf.14) - 10https://gerrit.wikimedia.org/r/304427 [01:50:04] 06Collaboration-Team-Triage, 10Notifications: False "You mentioned yourself" notification - https://phabricator.wikimedia.org/T142798#2546650 (10matmarex) I don't see how this is a duplicate of T138080. My edit did not have any weird parser functions or templates (other than {{ping}}). I don't mind the feature... [01:50:21] (03CR) 10Mattflaschen: [C: 032] Revert "Allow self mentions" [extensions/Echo] (wmf/1.28.0-wmf.14) - 10https://gerrit.wikimedia.org/r/304427 (owner: 10Mattflaschen) [01:57:36] (03Merged) 10jenkins-bot: Revert "Allow self mentions" [extensions/Echo] (wmf/1.28.0-wmf.14) - 10https://gerrit.wikimedia.org/r/304427 (owner: 10Mattflaschen) [02:11:17] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2546676 (10Mattflaschen-WMF) Due to the issues with accidental self-mentions with templates (see above), I've disabled this pen... [02:25:33] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2546685 (10Danny_B) ↑ since it will need another notifice obviously as it was already noticed to be turned on in https://meta.w... [02:28:21] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2546688 (10Danny_B) >>! In T138080#2546576, @MZMcBride wrote: > I think the real issue here is that Echo decided to re-use/stea... [02:29:41] matt_flaschen: how did you manage to comment the task without automatical subscription to it? [02:33:35] Danny_B, I don't know, I feel like maybe that doesn't happen anymore. I don't think that's the first time I've noticed it. [02:35:00] seeeing it actually subscribed me twice indicates some issue then [02:35:28] Danny_B: You may be interested in subscribing to https://phabricator.wikimedia.org/T128535 [02:36:36] Debra: {{done}}, thx for pinging me ;-) [02:36:52] :-) [02:45:44] 06Collaboration-Team-Triage, 10Notifications: Consider ping parser function instead of link-based mention - https://phabricator.wikimedia.org/T128535#2546696 (10Danny_B) Re the reasoning: There are also so called "hidden pings" which are super annoyable (using constructions like `{{#ifeq:{{{hide}}}|yes| (03CR) 10Mattflaschen: [C: 032] Browser tests: update to mw-selenium 1.7.2 and https [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/304307 (https://phabricator.wikimedia.org/T129483) (owner: 10Sbisson) [04:07:51] (03Merged) 10jenkins-bot: Browser tests: update to mw-selenium 1.7.2 and https [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/304307 (https://phabricator.wikimedia.org/T129483) (owner: 10Sbisson) [04:52:51] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 07Availability, 07Wikimedia-Multiple-active-datacenters: Flow: Use WAN cache delete() and slave populations to avoid merge() - https://phabricator.wikimedia.org/T120009#2546808 (10aaron) [07:08:13] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2546880 (10Pginer-WMF) >>! In T132975#2529662, @Mooeypoo wrote: > Action item: We need to get those icons into ooui. After dis... [07:08:53] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2546881 (10Pginer-WMF) [07:37:45] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2546942 (10Pginer-WMF) >>! In T132975#2545813, @Mooeypoo wrote: > A couple of questions were raised while working on this featu... [07:44:37] 06Collaboration-Team-Triage, 10Notifications, 07Design: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264#2546960 (10Pginer-WMF) [08:36:57] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki-Links, and 3 others: [Regression wmf23] On creating a wikilink/an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#2547069 (10QuimGil) It works indeed! Thank you very mu... [08:53:03] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2547091 (10Addshore) Okay, this is something that we did not foresee. It sounds like it would be best to hold off on this until... [08:57:00] 06Collaboration-Team-Triage, 10Flow, 07Easy: Flow mention search should ignore letter case - https://phabricator.wikimedia.org/T142813#2547094 (10QuimGil) [08:58:49] (03PS8) 10WMDE-Fisch: Bundle mention success and failure notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) [09:04:22] (03PS4) 10WMDE-Fisch: Send mentions when editing multiple sections in between sections. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304198 (https://phabricator.wikimedia.org/T141863) [09:05:20] (03CR) 10WMDE-Fisch: "PS8: manual rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch) [09:05:38] (03PS1) 10Addshore: DiscussionParser stripSig from mention content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304452 [09:14:31] 06Collaboration-Team-Triage, 10Notifications: False "You mentioned yourself" notification - https://phabricator.wikimedia.org/T142798#2546615 (10Addshore) So the content here that ended up in the DB is: > *** {{ping|Slowking4}} The upload wizard is perfectly capable of handling up to 50 uploads at once. We're... [11:48:37] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Mention notifications anomalies - https://phabricator.wikimedia.org/T137755#2377768 (10Addshore) > [[https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Notifications&oldid=724041632#Retriggered_notification_for_mention... [13:05:33] (03PS1) 10Sbisson: Browser tests: update to mw-selenium 1.7.2 and https [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/304467 (https://phabricator.wikimedia.org/T129483) [13:21:23] (03CR) 10Sbisson: "About the watch/unwatch action, I agree that it is generic enough to be used by others, and I agree that it is not used by others and ther" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [13:46:03] (03CR) 10Sbisson: [wip] Add dynamic secondary actions to items (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [14:07:01] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Alerts and Notices icons are too large on 1.28-wmf.13 - https://phabricator.wikimedia.org/T141923#2547883 (10Pginer-WMF) I'd propose a couple of small adjustments that can be done for the badges to bette... [15:07:59] 06Collaboration-Team-Triage, 10ArchCom-RfC, 10MediaWiki-ContentHandler, 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2547999 (10RobLa-WMF) [15:11:20] 06Collaboration-Team-Triage, 10ArchCom-RfC, 10MediaWiki-ContentHandler, 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2548000 (10RobLa-WMF) [15:43:02] (03PS1) 10Sbisson: Fix notification cleanup on post moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/304480 (https://phabricator.wikimedia.org/T142758) [15:43:19] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Notifications from moderated post are not purged - https://phabricator.wikimedia.org/T142758#2548074 (10SBisson) a:03SBisson [15:54:04] 06Collaboration-Team-Triage, 06Design-Research-Backlog, 10Edit-Review-Improvements: Page Curation user workflows and Edit Review prototype concept validation - https://phabricator.wikimedia.org/T140161#2548098 (10Capt_Swing) Sorry, @jmatazzoni I was on vacation for a week. Should have clarified that. [17:06:17] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2548401 (10Mooeypoo) Awesome, this clarifies things for me. Thank you both! [17:31:44] 06Collaboration-Team-Triage, 06Design-Research, 10Edit-Review-Improvements: Page Curation user workflows and Edit Review prototype concept validation - https://phabricator.wikimedia.org/T140161#2548484 (10Capt_Swing) [17:58:19] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2548544 (10Mattflaschen-WMF)... [19:02:48] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Page-deletion, 13Patch-For-Review: Failed restore and data loss on ar_rev_id collisions - https://phabricator.wikimedia.org/T135852#2548746 (10Mattflaschen-WMF) A couple exact test cases I've been using to test this: ``` Two separate pages with one revision each... [19:21:16] matt_flaschen, do you remember what the popup notice in MW JS is called? I can't find it... the bubble thing that pops up with confirmation when you watch/unwatch a page [19:22:34] mooeypoo, that one is mw.notify/mediawiki.notification. I'm not sure that has HTML support, though. [19:23:08] matt_flaschen: Pretty sure Flow puts icons in those [19:23:17] So there's some kind of support for... sometihng [19:24:24] RoanKattouw, it's not the same function. That is some Flow thing (flow-ui-tooltip). [19:24:25] (03CR) 10Catrope: [C: 032] Fix notification cleanup on post moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/304480 (https://phabricator.wikimedia.org/T142758) (owner: 10Sbisson) [19:24:34] Let me check if mw.notify supports HTML somehow. [19:24:37] Yeh I thought so too, but I'll see [19:24:40] matt_flaschen: I mean the thing that appears after you watch a board [19:24:48] matt_flaschen, RoanKattouw "worse" case I can also use ooui dialog [19:24:57] but that would mean having a window manager and overlay, etc etc [19:24:59] prefer not [19:25:02] Pretty sure that's mw.notify and it has the big-watch-star-with-three-horizontal-things icon [19:25:03] also, it's more "in your face" [19:25:18] Yeah no that's ugly, don't do that [19:25:35] https://www.mediawiki.org/wiki/ResourceLoader/Modules#mediawiki.notify [19:25:41] ^^ according to this, it supports html [19:26:04] RoanKattouw, the Flow one is definitely not mw.notify. [19:27:06] mooeypoo, yeah, I looked more now, you're right, you just have to pass it in as a DOM element. [19:27:30] matt_flaschen, hm, trying to see if it accepts only raw html or jquery [19:28:20] woah we're overriding mw.notify in Flow [19:28:38] flow-board.js function _overrideWatchlistNotification() {...} [19:29:44] And it accepts jQuery objects [19:31:16] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Invite users to try the new Notifications page (using the Notifications panel) - https://phabricator.wikimedia.org/T141414#2497647 (10Sjoerddebruin) Why is there so lit... [19:31:37] RoanKattouw, oh, never mind, the topic watch thing in Flow is a Flow thing, the board one is a Flow thing inside of mw.notify it looks like. [19:31:54] Right because why would we use the same thing twice :P [19:32:32] mooeypoo, you probably saw by now, but the stock mw.notify also accepts jQuery. [19:32:43] matt_flaschen, yep just saw it [19:32:51] (03Merged) 10jenkins-bot: Fix notification cleanup on post moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/304480 (https://phabricator.wikimedia.org/T142758) (owner: 10Sbisson) [19:37:27] 06Collaboration-Team-Triage, 10Flow: Flow mention search should ignore letter case - https://phabricator.wikimedia.org/T142813#2548782 (10Mattflaschen-WMF) It's not. The first character is different because the first character of usernames is canonicalized to capital. The rest is case-sensitive. [19:39:23] 06Collaboration-Team-Triage, 10Flow: case-insensitive autocomplete for mentions - https://phabricator.wikimedia.org/T101254#2548786 (10Mattflaschen-WMF) [19:39:25] 06Collaboration-Team-Triage, 10Flow: Flow mention search should ignore letter case - https://phabricator.wikimedia.org/T142813#2548788 (10Mattflaschen-WMF) [19:42:10] (03CR) 10Mattflaschen: [C: 032] Browser tests: update to mw-selenium 1.7.2 and https [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/304467 (https://phabricator.wikimedia.org/T129483) (owner: 10Sbisson) [19:43:05] (03Merged) 10jenkins-bot: Browser tests: update to mw-selenium 1.7.2 and https [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/304467 (https://phabricator.wikimedia.org/T129483) (owner: 10Sbisson) [19:43:20] (03PS2) 10Addshore: DiscussionParser stripSig from mention content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304452 [19:43:39] quiddity: Oh knower of Phabricator tasks, do you know which task https://gerrit.wikimedia.org/r/#/c/304452/ might be referring to? [19:43:50] *dost thou [19:44:35] heh, hmm, not offfhand, but sounds familiar, I'll search [19:45:23] Thanks [19:48:47] (03PS5) 10Mooeypoo: [wip] Allow watching and unwatching of boards from Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [19:48:58] (03PS6) 10Mooeypoo: [wip] Add dynamic secondary actions to items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [19:52:46] RoanKattouw, I can't find anything directly about it, only this related task (and the one mentioned within) https://phabricator.wikimedia.org/T130157 [19:53:32] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add dynamic secondary actions to items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [20:02:14] (03PS7) 10Mooeypoo: [wip] Add dynamic secondary actions to items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [20:10:11] RoanKattouw, do you know any way to override the language to qqx for a POST request? [20:10:55] It has to be without cookies. [20:13:48] RoanKattouw, never mind, I thought maybe there were two versions of the message, and we forgot to change one. [20:13:53] But it's just Beta being crazy. [20:14:39] etonkovidova, RoanKattouw, James_F, I put the one-year 'remember me' (T68699) on Beta Cluster. [20:14:40] T68699: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699 [20:16:12] It's working fine, except Beta is arbitrarily only sometimes showing my MW namespace override (https://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Userlogin-remembermypassword&oldid=344299). [20:16:53] matt_flaschen: ok [20:17:03] Sometimes when I load https://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin it shows " Keep me logged in (for up to 365 days)", then when I refresh the same page, it shows "Keep me logged in". [20:17:40] I'm not too worried about that, I think it's probably a temporary caching issue, and enwiki at least already has this message. [20:17:44] I will see if it's tracked, though. [20:26:00] matt_flaschen: Awesome, thanks. [20:28:28] ^ Above is T142863. I tracked it down more. [20:28:29] T142863: On Beta Cluster, MediaWiki namespace override is inconsistently applied - https://phabricator.wikimedia.org/T142863 [20:31:34] 03Collab-Team-Q1-July-Sep-2016, 10Beta-Cluster-Infrastructure, 07Beta-Cluster-reproducible, 07I18n: On Beta Cluster, MediaWiki namespace override is inconsistently applied - https://phabricator.wikimedia.org/T142863#2549253 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [20:49:36] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2549331 (10Mattflaschen-WMF)... [20:50:15] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2549332 (10Mattflaschen-WMF) [21:05:11] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 07User-notice: [betalabs-Regression] Incorrect count when only cross-wiki notifications are present - https://phabricator.wikimedia.org/T140327#2549372 (10Etonkovidova) Could not find any instances of the issue in production - `1.28.0-wmf.14 (b... [21:06:34] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2549376 (10Tgr) Thanks for m... [21:27:52] 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 06Community-Liaisons (Jul-Sep-2016), and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2549403 (10Mattflaschen-WMF)... [21:37:05] (03CR) 10Mooeypoo: "> One way to evaluate a decision is to consider the cost of changing" (039 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [21:38:09] (03PS8) 10Mooeypoo: Add dynamic secondary actions to notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [21:39:50] (03CR) 10Mooeypoo: [wip] Allow watching and unwatching of boards from Flow notifications (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [21:40:37] (03PS6) 10Mooeypoo: [wip] Allow unwatching of boards from Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [22:37:39] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Notification badges misaligned in Monobook in IE11 and below - https://phabricator.wikimedia.org/T142053#2521072 (10Etonkovidova) Re-checked in `1.28.0-wmf.14 (ba1c692)` for IE11 enwiki monobook {F43581... [22:38:55] 03Collab-Team-Q1-July-Sep-2016, 10Beta-Cluster-Infrastructure, 07Beta-Cluster-reproducible, 07I18n: On Beta Cluster, MediaWiki namespace override is inconsistently applied - https://phabricator.wikimedia.org/T142863#2549649 (10Mattflaschen-WMF) [22:48:49] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2549687 (10Catrope) [23:11:25] 06Collaboration-Team-Triage, 10Thanks: New thank dialog should have some return button to go back on diff/history page - https://phabricator.wikimedia.org/T142886#2549825 (10Dvorapa) [23:19:32] 06Collaboration-Team-Triage, 10Thanks: New thank dialog should have some return button to go back on diff/history page - https://phabricator.wikimedia.org/T142886#2549825 (10Legoktm) Can you clarify which dialog you're referring to...? I don't think anything new has been added recently... [23:20:11] (03PS1) 10Catrope: Tweak badge styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/304584 (https://phabricator.wikimedia.org/T141923) [23:32:58] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Flow: Update to stop using buildCssLinks and for related ConfirmEdit change - https://phabricator.wikimedia.org/T140472#2549890 (10Etonkovidova) Re-checked in `1.28.0-wmf.14 (ba1c692)`- Flow spam filter warning is displayed. in... [23:35:16] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#2549897 (10Mattflaschen-WMF) >>! In T122262#2538645, @Etonkovidova wrote: > Re-checked the scenario @Mattflaschen-WMF described: Just... [23:37:15] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Alerts and Notices icons are too large on 1.28-wmf.13 - https://phabricator.wikimedia.org/T141923#2549903 (10Catrope) >>! In T141923#2547883, @Pginer-WMF wrote: > ``` > #pt-notifica... [23:38:41] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Alerts and Notices icons are too large on 1.28-wmf.13 - https://phabricator.wikimedia.org/T141923#2549905 (10Catrope) @Pginer-WMF If your Vagrant install isn't still all screwed up,... [23:45:00] RoanKattouw, before I head off for the evening -- I am curious what you and matt_flaschen think about stephane's comment in the 'unwatch flow boards' patch... he asked why we're using action strings to produce i18n messages instead of letting extensions just supply whatever message they need and then have Echo read that as part of the action data. I see benefits in either side (the method I'm currently using may be more restrictive [23:45:01] , but is easier and more intuitive, and avoids problems of duplication of keys and other issues, but his suggestion is less restrictive and means we don't really need to build the i18n messages, or build them - we just need to read whatever the extension gave us. [23:45:04] any thoughts on that? [23:45:49] matt_flaschen, RoanKattouw context: https://gerrit.wikimedia.org/r/#/c/303314/5/Hooks.php@98 [23:48:59] mooeypoo, you would still have the RL hook, right, just reading the message keys from the presentation model instead of generating the keys? [23:49:12] yep [23:49:46] (Also, running into an unexpected problem -- if extensions use certain icons in their actions, they'll have to add them manually too....... we might have to see how to load those as well :\ ) [23:50:15] He has a point, it would be better for greppability, the downside is you get inconsistent keys, but that's not that big a deal. [23:51:01] I'm less concerned about greppability -- we have a bunch ofthose built i18n messages that we trust the creators to **comment** the full message [23:51:30] But the second thing is that if we know the format of the message, greppability is easy too. If you know you have prefix-{action} then you can grep for the {action} part [23:52:27] mooeypoo, yeah, but when you're debugging starting from qqx, it's a pain to have to know the pattern. [23:52:36] I guess that's true [23:52:37] mooeypoo, it's the same as any other secondary link, right? [23:52:56] Yeah but in this case we also need messages for the confirmation and confirmation-description [23:53:01] Register with $wgEchoNotificationIcons or BeforeCreateEchoEvent ? [23:53:08] mooeypoo, no, I meant about the icon. [23:53:09] oh [23:53:16] yeah meh, I guess so [23:53:27] well, I'm running into this problem because of unstar icon is not loading [23:53:37] and I just saw it's probabl becaues the ooui icon package isn't loaded [23:53:47] Or am I wrong about the secondary link icons work. [23:54:06] No, you're correct - the icons are registered in $wgEchoNotificationIcons [23:54:11] wait, no [23:54:18] those are for the notification icons, not the secondary link icons [23:54:26] the secondary links are supposed to only use OOUI icons [23:54:31] Yeah, I thought at first it was both but apparently not. [23:54:35] which is fine, but then, we don't automatically load all ooui icon packages [23:55:30] mooeypoo, could you document that BTW, since getIconType says where it's defined, but the secondary doesn't? [23:55:37] In getSecondaryLinks. [23:55:57] Nothing is documented in our presentation models :( we need to really fix that [23:56:00] I'll add that in [23:56:24] Zanzu loves you. [23:56:39] icon is actually documented (EventPresentationModel.php), just not this one thing. [23:56:49] it's documented as symbolic name [23:56:58] Yeah [23:57:02] that's not helping in terms of being a symbolic name of an ooui icon [23:57:11] " 'icon' => (bool|string) symbolic ooui icon name (or false if there is none)," [23:57:13] I know, that's what I'm complaining about. :) [23:57:18] Aye, I'm commiserating [23:57:24] It's just "Nothing is documented in our presentation models" seems a little exaggerated. [23:57:40] 06Collaboration-Team-Triage, 10Thanks: New thank dialog should have some return button to go back on diff/history page - https://phabricator.wikimedia.org/T142886#2549911 (10Dvorapa) Steps to reproduce: # Thank for some edit on cswiki. # Yesterday it openned a browser's default confirm dialog to confirm an... [23:57:42] Yeah, you're right [23:57:43] (I'm also heading out. Have a good weekend all :) [23:58:14] But compared to our javascript code, the php side is really lacking proper documentation. It seems it's perfectly fine to have a docblock that only has param type and names without explanation of purpose of the method or of any of the parameters [23:58:21] enjoy your weekend, quiddity ! [23:59:36] mooeypoo, yeah, I feel a little bad when it's "@param $userName", saying "Please document $userName" (when it's obvious like that). [23:59:56] I try to ask when it's at all ambiguous, but I should probably do so in more cases.