[00:01:14] Hmm. Fun. [00:14:10] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 07Tracking: Enable the Flow personal talk opt-in Beta Feature on some wikis - https://phabricator.wikimedia.org/T117990#2525352 (10Mattflaschen-WMF) [00:51:01] (03PS1) 10Mattflaschen: Skip deleted boards in FlowUpdateResolvedNotifTitles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303117 (https://phabricator.wikimedia.org/T137501) [00:51:22] (03CR) 10Catrope: [C: 032] Skip deleted boards in FlowUpdateResolvedNotifTitles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303117 (https://phabricator.wikimedia.org/T137501) (owner: 10Mattflaschen) [01:01:19] re: kanban boards, interesting. We really need a 3rd dimension. I look forward to using VR to move tasks between columns in 2 directions at once! [01:02:53] (03Merged) 10jenkins-bot: Skip deleted boards in FlowUpdateResolvedNotifTitles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303117 (https://phabricator.wikimedia.org/T137501) (owner: 10Mattflaschen) [01:37:57] (03CR) 10Mattflaschen: [C: 04-1] Log 'mark all read' button click actions (038 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303015 (https://phabricator.wikimedia.org/T127955) (owner: 10Mooeypoo) [01:46:00] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 07Performance: VE preview on Flow pages take too long (1min+) to load in debug mode - https://phabricator.wikimedia.org/T118090#2525544 (10Krinkle) [02:04:42] Have a good night. [07:32:11] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-LiquidThreads: Mention notification is broken on talk pages where LiquidThreads is enabled (e.g. [[mw:]] and [[pt:wikibooks:]]) - https://phabricator.wikimedia.org/T58311#2525958 (10Nemo_bis) p:05Lowest>03Normal [07:32:14] 06Collaboration-Team-Triage, 10MediaWiki-extensions-LiquidThreads, 07Wikimedia-log-errors: LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#2525959 (10Nemo_bis) p:05Lowest>03Normal [08:34:20] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#1932012 (10Johan) I'm partial of course,... [08:47:57] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2526120 (10Johan) Just to be on the safe side: unlike {T135717} and {T139623} this is not opt-in? [08:49:04] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2308308 (10Johan) When will this be deployed to content wikis? [09:59:13] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Also send mention notifications to self - https://phabricator.wikimedia.org/T138080#2526200 (10Lea_WMDE) @Johan yes, this is not opt-in [10:35:34] 06Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2526292 (10Johan) Or phrased differently:... [10:56:10] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 03TCB-Team-Sprint-2016-08-11: Make sure all changes are reflected in documentation - https://phabricator.wikimedia.org/T142189#2526358 (10Lea_WMDE) [10:57:08] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 03TCB-Team-Sprint-2016-08-11: Make sure all changes are reflected in documentation - https://phabricator.wikimedia.org/T142189#2526380 (10Lea_WMDE) [10:57:57] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, 03TCB-Team-Sprint-2016-08-11: Make sure all changes are reflected in documentation - https://phabricator.wikimedia.org/T142189#2526358 (10Lea_WMDE) @WMDE-leszek could you link your suggestion for how to change documentation... [11:05:26] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Accessibility, 13Patch-For-Review, and 2 others: Low contrast and small text for notification badges in monobook - https://phabricator.wikimedia.org/T142149#2526416 (10SBisson) a:03Catrope [11:22:19] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 2 others: Make sure all changes are reflected in documentation - https://phabricator.wikimedia.org/T142189#2526439 (10Danny_B) [11:46:31] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2526697 (10Lea_WMDE) @WMDE-Fisch we talked about bundling per save, not per page. Since I realized this is the title of the story... [12:41:26] 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 3 others: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2526769 (10Lea_WMDE) We are planning to have it on the test cluster for about a month for extended testing, and will deploy it to the... [13:27:59] (03PS1) 10Sbisson: Output wgNotificationsSpecialPageLinks js var even if no local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303158 (https://phabricator.wikimedia.org/T142148) [13:28:24] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review: Special:Notifications fails to show foreign notifications (or any UI at all) on wikis where you've never received a notification - https://phabricator.wikimedia.org/T142148#2526894 (10SBisson) a:03SBisson [14:41:50] 06Collaboration-Team-Triage, 10MediaWiki-ContentHandler, 10ArchCom-RfC (ArchCom-Approved), 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2527363 (10daniel) I propose to introduce a separate table to hold meta-information about revision content (e.g. model and format, but als... [14:49:44] 06Collaboration-Team-Triage, 10MediaWiki-ContentHandler, 10ArchCom-RfC (ArchCom-Approved), 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2527428 (10daniel) For the record, I do not consider this blocked on {T107595}. Rather the other way around: this can be one step towards... [16:26:43] 06Collaboration-Team-Triage, 10ArchCom-RfC, 10MediaWiki-ContentHandler, 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2527724 (10daniel) a:05Legoktm>03daniel Putting this back into the ArchCom inbox, to push it a bit. I'm claiming this as a shepherd in the context of a... [16:40:38] (03PS1) 10Reedy: Remove 'UnitTestList' hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/303190 (https://phabricator.wikimedia.org/T142120) [16:58:30] (03CR) 10Jforrester: [C: 032] Remove 'UnitTestList' hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/303190 (https://phabricator.wikimedia.org/T142120) (owner: 10Reedy) [17:05:59] (03Merged) 10jenkins-bot: Remove 'UnitTestList' hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/303190 (https://phabricator.wikimedia.org/T142120) (owner: 10Reedy) [17:06:43] (03Abandoned) 10Mooeypoo: Convert to local time when calculating weeks difference in moment [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302620 (https://phabricator.wikimedia.org/T141915) (owner: 10Mooeypoo) [17:43:34] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2528198 (10Etonkovidova) Re-run the updated script - no errors. [17:46:07] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Notifications: Write email formatter that uses presentation models - https://phabricator.wikimedia.org/T121067#2528227 (10Etonkovidova) [17:46:09] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Watchlist, 07I18n: Make e-mail notifications clearer and more precise on page renames - https://phabricator.wikimedia.org/T140214#2528228 (10Etonkovidova) [17:47:13] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-Watchlist, 07I18n: Make e-mail notifications clearer and more precise on page renames - https://phabricator.wikimedia.org/T140214#2456774 (10Etonkovidova) [17:49:13] 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Notifications: Write email formatter that uses presentation models - https://phabricator.wikimedia.org/T121067#1868422 (10Etonkovidova) Checked in betalabs. The subtask {T140214} is removed - this is a separate issue that should be add... [17:49:17] 06Collaboration-Team-Triage, 10Notifications, 10Thanks: Inline AJAX support for thanking users from links in the notification flyout - https://phabricator.wikimedia.org/T127335#2528258 (10Mattflaschen-WMF) [17:49:42] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension), 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Clean up how ConfirmEdit tracks modules associated with CAPTCHA - https://phabricator.wikimedia.org/T141300#2528264 (10Florian) [17:50:57] (03PS1) 10Jforrester: build: Fix stylelint devDependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303223 [17:52:16] (03CR) 10Esanders: [C: 032] build: Fix stylelint devDependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303223 (owner: 10Jforrester) [17:52:27] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12), 05WMF-deploy-2016-08-02_(1.28.0-wmf.13): Dismantle the old notification formatter system - https://phabricator.wikimedia.org/T121612#1883636 (10Etonkovidova) Checked in betalabs along with {T1210... [17:56:31] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2528283 (10Mattflaschen-WMF) [17:58:12] 06Collaboration-Team-Triage, 10ArchCom-RfC, 10MediaWiki-ContentHandler, 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#1448507 (10jcrespo) Thank you, daniel! I am happy and interested to apply this change to the db (that would potentially solve ongoing issues some people com... [18:02:14] (03Merged) 10jenkins-bot: build: Fix stylelint devDependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303223 (owner: 10Jforrester) [18:09:24] https://etherpad.wikimedia.org/p/2016-08-05_Unsubscribe [18:22:51] RoanKattouw: matt_flaschen - do you know if somebody is looking into MWException from line 176 of /srv/mediawiki/php-master/includes/Hooks.php: Invalid callback Timeline::onParserFirstCallInit in hooks for ParserFirstCallInit ? [18:25:54] etonkovidova, I haven't seen that, is there a task? I'm in a meeting right now. [18:26:43] matt_flaschen: not sure if there is a task... I just asked in case that somebody is aware of it [18:28:24] RoanKattouw, mooeypoo https://phabricator.wikimedia.org/F3957578 [18:57:47] etonkovidova, I don't see it. Could you file? [19:08:20] 06Collaboration-Team-Triage, 06Community-Liaisons, 10Edit-Review-Improvements, 07Documentation: Define Edit Review Improvements glossary - https://phabricator.wikimedia.org/T141449#2528528 (10Mattflaschen-WMF) [19:08:23] 06Collaboration-Team-Triage, 10Notifications, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Create a glossary about Notifications - https://phabricator.wikimedia.org/T141429#2528529 (10Mattflaschen-WMF) [19:08:25] 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2528530 (10Mattflaschen-WMF) [19:08:27] 06Collaboration-Team-Triage, 10Notifications: Notifications not updated across languages - https://phabricator.wikimedia.org/T139454#2528533 (10Mattflaschen-WMF) [19:08:29] 06Collaboration-Team-Triage, 06Design-Research-Backlog, 10Edit-Review-Improvements: Page Curation user workflows and Edit Review prototype concept validation - https://phabricator.wikimedia.org/T140161#2528531 (10Mattflaschen-WMF) [19:08:32] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-API, 10MediaWiki-extensions-OAuth, 10VisualEditor: With some accounts but not others, API throws badsession error on OAuth options update - https://phabricator.wikimedia.org/T140006#2528532 (10Mattflaschen-WMF) [19:08:33] 06Collaboration-Team-Triage, 10Notifications, 07I18n: Echo's momentjs usage produces incorrect time format in ce - https://phabricator.wikimedia.org/T138363#2528534 (10Mattflaschen-WMF) [19:08:35] 06Collaboration-Team-Triage, 10Design Research and product team collaboration, 06Design-Research, 10Edit-Review-Improvements, and 2 others: [Epic] New editor support strategies research - https://phabricator.wikimedia.org/T137987#2528535 (10Mattflaschen-WMF) [19:08:37] 06Collaboration-Team-Triage, 10Flow, 10Notifications: username is shown twice when a user replies on her own Flowified user talk page - https://phabricator.wikimedia.org/T135895#2528537 (10Mattflaschen-WMF) [19:08:39] 06Collaboration-Team-Triage, 10Notifications, 06Performance-Team, 07Availability: MWEchoEmailBundler should batch updates - https://phabricator.wikimedia.org/T135798#2528538 (10Mattflaschen-WMF) [19:08:43] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 10VisualEditor: Allow people to add customized buttons to OOUI/VE toolbar in an easy way - https://phabricator.wikimedia.org/T136152#2528536 (10Mattflaschen-WMF) [19:08:45] 06Collaboration-Team-Triage, 10Flow: Flow ignores oldid parameter - https://phabricator.wikimedia.org/T135765#2528539 (10Mattflaschen-WMF) [19:08:47] 06Collaboration-Team-Triage, 10Flow: Make "log in" in [[MediaWiki:Flow-error-can-not-edit-logged-out]] a link - https://phabricator.wikimedia.org/T135016#2528540 (10Mattflaschen-WMF) [19:08:49] 06Collaboration-Team-Triage, 10Thanks: $1 displayed for Thanks error (upon trying to thank self) - https://phabricator.wikimedia.org/T133003#2528541 (10Mattflaschen-WMF) [19:08:53] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor: Ctrl+M on VE mode has unexpected behavour on VE and on VE mode on Flow with an Azerty keyboard - https://phabricator.wikimedia.org/T134164#2528542 (10Mattflaschen-WMF) [19:08:55] 06Collaboration-Team-Triage, 10Notifications, 07Design, 07Easy: The document title should be dynamically updated to include a (n) notifications count in the browser title bar. - https://phabricator.wikimedia.org/T75209#2528544 (10Mattflaschen-WMF) [19:08:58] 06Collaboration-Team-Triage, 10Notifications: When mentioning other users, indicate mention notifications in the "your edit was saved" message - https://phabricator.wikimedia.org/T68078#2528545 (10Mattflaschen-WMF) [19:09:01] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email: Email backend for notifications to supplement/consolidate enotif with common notification infrastructure - https://phabricator.wikimedia.org/T34285#2528548 (10Mattflaschen-WMF) [19:14:51] legoktm, do you know how to get wikibugs back? Sorry, I thought that was a small enough number it wouldn't cause problems. [19:17:13] 06Collaboration-Team-Triage, 10Notifications, 07Browser-Support-Opera: New notification badge acts funny on Opera 12 - https://phabricator.wikimedia.org/T142248#2528562 (10matmarex) [19:17:25] 06Collaboration-Team-Triage, 10Notifications, 07Browser-Support-Opera: New notification badge acts funny on Opera 12 - https://phabricator.wikimedia.org/T142248#2528575 (10matmarex) p:05Triage>03Lowest a:03matmarex [19:17:59] 06Collaboration-Team-Triage, 10ArchCom-RfC, 10MediaWiki-ContentHandler, 07RfC: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2528578 (10daniel) I might help with the implementation, https://gerrit.wikimedia.org/r/#/c/302492/ is already a good start, i think. [19:23:51] matt_flaschen, IIRC, it autorejoins a channel when a new message arrives for that particular channel (after it has re-connected). [19:23:58] (03PS1) 10Bartosz Dziewoński: mw.echo.badge: Use 'background-image' rather than 'content' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303253 (https://phabricator.wikimedia.org/T142042) [19:26:11] quiddity, oh, that's good. [19:27:30] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Vagrant: Role echo throws errors at vagrant - https://phabricator.wikimedia.org/T128903#2528616 (10Mattflaschen-WMF) 05Open>03Invalid Reopen if you can reproduce. [19:28:57] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Vagrant: Separate cross-wiki infrastructure in Echo MediaWiki-Vagrant into separate crosswikiecho role - https://phabricator.wikimedia.org/T139203#2528620 (10Mattflaschen-WMF) [19:29:26] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Vagrant: Separate cross-wiki infrastructure in Echo MediaWiki-Vagrant into separate crosswikiecho role - https://phabricator.wikimedia.org/T139203#2422562 (10Mattflaschen-WMF) This is necessary for testing cross-wiki notifications, but it doesn't have... [19:29:47] matt_flaschen: re T142246: are you going to rename collaboration-team-triage to collaboration-team then? [19:29:47] T142246: Change Collab-Team-Q1-July-Sep-2016 from subproject to milestone - https://phabricator.wikimedia.org/T142246 [19:35:26] Danny_B, I don't know. I don't care about the name much either way. [19:35:37] (03PS1) 10Bartosz Dziewoński: mw.echo.badge: Use 'color: transparent' rather than 'font-size: 0' to hide text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303257 [19:36:11] matt_flaschen: re the "small enough number" - everything more than five is quite a big spam... ;-) feel free to poke me if you need any batch edit [19:37:56] (03CR) 10Bartosz Dziewoński: "I didn't actually test this on IEs affected by T142042, so please verify that this patch doesn't regress it." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303253 (https://phabricator.wikimedia.org/T142042) (owner: 10Bartosz Dziewoński) [20:22:50] 06Collaboration-Team-Triage, 10Flow: WikiToLearn: flow-new-post permissions does not seem to work - https://phabricator.wikimedia.org/T139627#2438101 (10Mattflaschen-WMF) There is not a right for this. Are you trying to block anons from all edits to Flow boards and topics? If so, see https://www.mediawiki.or... [20:23:05] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Accessibility, 13Patch-For-Review, and 2 others: Low contrast and small text for notification badges in monobook - https://phabricator.wikimedia.org/T142149#2524459 (10Etonkovidova) Monobook with the fix for the font size. {F4339609} {F4339607} The scree... [20:25:32] (03PS5) 10Mooeypoo: Log 'mark all read' button click actions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303015 (https://phabricator.wikimedia.org/T127955) [20:27:19] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-API, 10MediaWiki-extensions-OAuth, 10VisualEditor: With some accounts but not others, API throws badsession error on OAuth options update - https://phabricator.wikimedia.org/T140006#2528789 (10Ragesoss) 05Open>03Resolved [20:27:39] (03PS6) 10Mooeypoo: Log 'mark all read' button click actions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303015 (https://phabricator.wikimedia.org/T127955) [20:27:45] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-API, 10MediaWiki-extensions-OAuth, 10VisualEditor: With some accounts but not others, API throws badsession error on OAuth options update - https://phabricator.wikimedia.org/T140006#2449675 (10Ragesoss) I haven't had the error again since the fix... [20:28:07] (03PS2) 10Mooeypoo: Log Special:Notifications page visits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303079 (https://phabricator.wikimedia.org/T121939) [20:32:16] (03CR) 10jenkins-bot: [V: 04-1] Log Special:Notifications page visits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303079 (https://phabricator.wikimedia.org/T121939) (owner: 10Mooeypoo) [20:33:13] (03PS1) 10Mooeypoo: Log the mark entire cross-wiki bundle as read action [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303291 (https://phabricator.wikimedia.org/T127955) [20:33:53] (03PS7) 10Mooeypoo: Log 'mark all read' button click actions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303015 (https://phabricator.wikimedia.org/T127955) [20:34:31] (03PS3) 10Mooeypoo: Log Special:Notifications page visits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303079 (https://phabricator.wikimedia.org/T121939) [20:37:24] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2528832 (10Mooeypoo) a:05Pginer-WMF>03Mooeypoo [20:37:26] (03CR) 10jenkins-bot: [V: 04-1] Log the mark entire cross-wiki bundle as read action [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303291 (https://phabricator.wikimedia.org/T127955) (owner: 10Mooeypoo) [20:39:02] (03PS2) 10Mooeypoo: Log the mark entire cross-wiki bundle as read action [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303291 (https://phabricator.wikimedia.org/T127955) [20:43:15] (03CR) 10jenkins-bot: [V: 04-1] Log Special:Notifications page visits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303079 (https://phabricator.wikimedia.org/T121939) (owner: 10Mooeypoo) [20:44:06] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Regression, and 2 others: [regression- pre-wmf.14] Persistent cross-wiki notifications - cannot 'Mark as read' cross-wiki bundle from flyout - https://phabricator.wikimedia.org/T142143#2528952 (10Etonkovidova) Checked in betalabs - the... [20:55:46] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: "TypeError: Cannot read property 'preferences' of null TypeError" when there is no local notifications on Special Notifications page - https://phabricator.wikimedia.org/T142257#2529182 (10Etonkovidova) [20:57:57] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: "TypeError: Cannot read property 'preferences' of null TypeError" when there is no local notifications on Special Notifications page - https://phabricator.wikimedia.org/T142257#2529216 (10SBisson) [20:57:59] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review: Special:Notifications fails to show foreign notifications (or any UI at all) on wikis where you've never received a notification - https://phabricator.wikimedia.org/T142148#2529214 (10SBisson) [21:17:09] (03CR) 10Catrope: [C: 032] Output wgNotificationsSpecialPageLinks js var even if no local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303158 (https://phabricator.wikimedia.org/T142148) (owner: 10Sbisson) [21:17:37] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review: Special:Notifications fails to show foreign notifications (or any UI at all) on wikis where you've never received a notification - https://phabricator.wikimedia.org/T142148#2529315 (10Catrope) >>! In T142148#2526891, @gerritbot... [21:20:11] (03CR) 10Catrope: "@Etonkovidova could you check if this patch regresses T142042 and friends in IE?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303253 (https://phabricator.wikimedia.org/T142042) (owner: 10Bartosz Dziewoński) [21:20:37] (03CR) 10Catrope: [C: 032] mw.echo.badge: Use 'color: transparent' rather than 'font-size: 0' to hide text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303257 (owner: 10Bartosz Dziewoński) [21:21:02] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Browser-Support-Opera: New notification badge acts funny on Opera 12 - https://phabricator.wikimedia.org/T142248#2529333 (10Catrope) [21:28:37] (03CR) 10Catrope: [V: 031] "I ended up testing this because I have a better IE testing setup. This patch does not regress T142042 in IE." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303253 (https://phabricator.wikimedia.org/T142042) (owner: 10Bartosz Dziewoński) [21:29:08] (03Merged) 10jenkins-bot: Output wgNotificationsSpecialPageLinks js var even if no local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303158 (https://phabricator.wikimedia.org/T142148) (owner: 10Sbisson) [21:32:25] mooeypoo: https://gerrit.wikimedia.org/r/302854 [21:33:13] (03CR) 10Mooeypoo: [C: 032] Hack around browser bug in IE breaking badge alignment in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302854 (https://phabricator.wikimedia.org/T142053) (owner: 10Catrope) [21:35:15] (03PS2) 10Catrope: mw.echo.badge: Use 'background-image' rather than 'content' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303253 (https://phabricator.wikimedia.org/T142042) (owner: 10Bartosz Dziewoński) [21:35:30] mooeypoo: https://gerrit.wikimedia.org/r/303253 and https://gerrit.wikimedia.org/r/#/c/303257 [21:37:59] mooeypoo: https://gerrit.wikimedia.org/r/302927 [21:38:02] (03CR) 10Mooeypoo: [C: 032] "Awesome, thank you for the patch, I was planning to do this too." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303253 (https://phabricator.wikimedia.org/T142042) (owner: 10Bartosz Dziewoński) [21:40:48] 06Collaboration-Team-Triage, 10Notifications: Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2529364 (10Esanders) [21:41:44] (03PS2) 10Mooeypoo: mw.echo.badge: Use 'color: transparent' rather than 'font-size: 0' to hide text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303257 (owner: 10Bartosz Dziewoński) [21:41:54] (03CR) 10Mooeypoo: [C: 032] mw.echo.badge: Use 'color: transparent' rather than 'font-size: 0' to hide text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303257 (owner: 10Bartosz Dziewoński) [21:44:38] 06Collaboration-Team-Triage, 10Notifications: Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2529393 (10Catrope) I think this is how it was originally designed. @Pginer-WMF is on vacation for a few more days but should hopefully be able to respond to this once he gets... [21:45:04] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2529399 (10Catrope) [21:47:14] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification group has a redundant separator - https://phabricator.wikimedia.org/T142260#2529402 (10Esanders) Expanded: {F4339766,size=full} [21:51:34] (03CR) 10Mooeypoo: [C: 032] Enable local bundles on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302927 (owner: 10Sbisson) [21:53:04] (03Merged) 10jenkins-bot: Hack around browser bug in IE breaking badge alignment in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302854 (https://phabricator.wikimedia.org/T142053) (owner: 10Catrope) [21:54:12] matt_flaschen, I'm adding $wgEchoDynamicSecondaryActions = array(); to Echo.php, but where should I read and add the stuff in the array into the message module? Which hook do I use for that? [21:54:43] matt_flaschen, onResourceLoaderRegisterModules ? [21:56:13] RoanKattouw and I were talking about it. I think we said to just use a field of $wgEchoNotifications . [21:56:37] mooeypoo, but yeah, that's the right hook. Note, you can not modify an existing module. You have to create the module in the hook (this is a recent-ish change). [21:56:52] * mooeypoo nods [21:57:20] matt_flaschen, hm, we said we'd add the definition to $wgEchoNotifications, not start a new definition array? [21:57:26] I guess it's simpler [21:58:03] (03Merged) 10jenkins-bot: mw.echo.badge: Use 'background-image' rather than 'content' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303253 (https://phabricator.wikimedia.org/T142042) (owner: 10Bartosz Dziewoński) [21:58:04] mooeypoo, yeah, I think that is where we ended up. And it can be de-duplicated in the hook (though RL does it anyway). Something like secondary-link-types, maybe? [21:58:06] (03Merged) 10jenkins-bot: mw.echo.badge: Use 'color: transparent' rather than 'font-size: 0' to hide text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303257 (owner: 10Bartosz Dziewoński) [21:59:38] matt_flaschen, I may be missing something, but grepping for wgEchoNotifications in Flow gives me weird options - includes/Import/Postporocessor/LqtNotifications.php (lqt related) maintenance/FlowFixLinks.php and something in tests/phpunit [21:59:46] where are we defining the flow notification types in Flow ? [22:00:37] (03Merged) 10jenkins-bot: Enable local bundles on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302927 (owner: 10Sbisson) [22:02:01] matt_flaschen, ok, I think I got it. In Notifications.php [22:02:06] mooeypoo, Notifications.php. I was sort of right/wrong about the hook. [22:02:28] mooeypoo, but it's actually not a problem, since $wgExtensionFunctions should run before ResourceLoaderRegisterModules (and before any hook) [22:02:58] mooeypoo, see initEchoExtension in Echo. But you can see it ends up in wgEchoNotifications, so it should be fine. [22:03:34] hm [22:04:02] matt_flaschen, also, seeing as each notification type has a type name, and I'm just ending up duplicating it as the action name, I'm wondering if this should just be a boolean flag instead [22:04:15] 'dynamic_action' => true [22:04:16] or something [22:04:38] then I just take the notification key and use it as the action name + i18n key [22:04:50] otherwise, I am just repeating that key anyways. [22:06:11] mooeypoo, it's not the same name as the action, though, right? [22:06:42] mooeypoo, e.g. flow-post-reply has unwatch-topic . [22:06:43] matt_flaschen, meh, right, right. [22:06:47] And also the same ones can have two. [22:06:57] So it needs to be an array in itself [22:07:14] Yes [22:09:26] (03Merged) 10jenkins-bot: Prevent duplicate thank-you-edit notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302759 (https://phabricator.wikimedia.org/T128249) (owner: 10Sbisson) [22:09:49] 06Collaboration-Team-Triage, 10Notifications: 'Pending' blocks don't match the width of the items they are placeholders for during notifications page load - https://phabricator.wikimedia.org/T142263#2529454 (10Esanders) [22:10:53] 06Collaboration-Team-Triage, 10Notifications: 'Pending' blocks don't match the width of the items they are placeholders for during notifications page load - https://phabricator.wikimedia.org/T142263#2529471 (10Esanders) Stills: {F4339815} {F4339817} {F4339819} [22:25:17] 06Collaboration-Team-Triage, 10Notifications: 'Pending' blocks don't match the width of the items they are placeholders for during notifications page load - https://phabricator.wikimedia.org/T142263#2529515 (10Mooeypoo) The initial pending block appears before the JavaScript lodas, so we couldn't really use th... [22:39:21] 06Collaboration-Team-Triage, 10Notifications: 'Pending' blocks don't match the width of the items they are placeholders for during notifications page load - https://phabricator.wikimedia.org/T142263#2529527 (10Esanders) Shouldn't you be loading OOUI onto this page synchronously? [22:47:45] (03PS1) 10Mooeypoo: [wip] Add dynamic secondary actions to items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [22:48:22] (03PS1) 10Mooeypoo: [wip] Allow watching and unwatching of boards from Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [22:52:45] RoanKattouw: sigh - badges in monobook looks weird again - everywhere [22:54:37] in monobook !== everywhere, no matter how much legoktm would like us to believe otherwise [22:54:40] * mooeypoo is checking into it [22:55:02] mooeypoo: right :) [22:56:49] uhm. It working in my local machine. [22:59:14] ok I see it now. It helps if I'm actually on master. [23:01:05] (03PS1) 10Mooeypoo: Fix top position of badges in monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303319 [23:01:07] RoanKattouw, trivial ^ [23:24:31] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add dynamic secondary actions to items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo) [23:36:04] mooeypoo, updated the GuidedTour patch. I'm heading out, have a good weekend. [23:36:17] matt_flaschen, you too! [23:36:27] (https://gerrit.wikimedia.org/r/#/c/280366/) (actually I updated the other one too though) [23:36:56] * mooeypoo nods [23:36:59] i'll take a look [23:38:22] Thanks [23:39:55] still wrestling with the resourceloader things, I'll try to get to that befor eI go home for the weekend, though [23:52:17] (03PS2) 10Mooeypoo: [wip] Add dynamic secondary actions to items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) [23:52:32] (03PS2) 10Mooeypoo: [wip] Allow watching and unwatching of boards from Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/303315 (https://phabricator.wikimedia.org/T132975) [23:54:50] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2529662 (10Mooeypoo) Action item: We need to get those icons into ooui. [23:55:42] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add dynamic secondary actions to items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/303314 (https://phabricator.wikimedia.org/T132975) (owner: 10Mooeypoo)