[00:00:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adjust notification badges for monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302625 (https://phabricator.wikimedia.org/T141923) (owner: 10Mooeypoo)
[00:04:11] <mooeypoo>	 legoktm, awesomesauce, thanks!
[00:04:52] <mooeypoo>	 RoanKattouw, matt_flaschen you may like this fix... https://gerrit.wikimedia.org/r/#/c/302620/
[00:05:10] <mooeypoo>	 Or in other words: Whoops
[00:07:24] <matt_flaschen>	 mooeypoo, I thought I specifically checked that.
[00:07:27] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MonoBook: New notices and alerts icons overlap MonoBook tabs - https://phabricator.wikimedia.org/T141942#2517562 (10Mooeypoo) a:03Mooeypoo I should have tagged this ticket too: https://gerrit.wikimedia.org/r/#/c/302625/ fixes this problem.
[00:07:46] <mooeypoo>	 matt_flaschen, this was super easy to fix, because it DOES use local -- just... later
[00:07:49] <mooeypoo>	 too much later
[00:08:15] <mooeypoo>	 it sounds reasonable that we'd like to first compare UTC and then localize, but now() is localized, and moment.utc( fromModel ) is UTC
[00:08:28] <mooeypoo>	 the funny thing is that this bug only happened at a VERY specific set of conditions
[00:08:34] <mooeypoo>	 *and* only in the middle of  the day :P
[00:09:13] <RoanKattouw>	 mooeypoo: Are you sure that makes a difference?
[00:09:18] <RoanKattouw>	 For ts diffs tz shouldn't matter
[00:09:28] <RoanKattouw>	 I have a different theory why this is happening but it may be that you're right and I'm wrong
[00:09:32] * RoanKattouw finishes posting theory to phab
[00:09:55] <mooeypoo>	 Hm, interesting point...
[00:10:21] <mooeypoo>	 RoanKattouw, I couldn't test it, since it's only visible before 3pm
[00:10:27] <mooeypoo>	 and changing my own local timezone didn't workk
[00:10:29] <matt_flaschen>	 mooeypoo:
[00:10:30] <matt_flaschen>	 mw.loader.using( 'moment' ).done( function() { var now = moment(); var momentTimestamp = moment.utc( '2016-07-31T14:00:00' ); console.log( now.diff( momentTimestamp, 'hours' ) ); } );
[00:10:34] <matt_flaschen>	 mw.loader.using( 'moment' ).done( function() { var now = moment(); var momentTimestamp = moment.utc( '2016-07-31T14:00:00' ).local(); console.log( now.diff( momentTimestamp, 'hours' ) ); } );
[00:10:37] <matt_flaschen>	 I tested it earlier.
[00:10:52] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabs-Regression] Special:Notifications page displays wrong date format for messages - https://phabricator.wikimedia.org/T141915#2517567 (10Catrope) >>! In T141915#2517393, @Mooeypoo wrote: > We are calculating the "am I after 7 days" wrong. >  >...
[00:10:58] <mooeypoo>	 you also need to have lots of notifications from different days of the week and then from the day that is beyond this week, which I don't
[00:11:06] <RoanKattouw>	 matt_flaschen: And? Same result or different?
[00:11:08] <mooeypoo>	 hm, okay, maybe I'm wrong :\
[00:11:17] <RoanKattouw>	 mooeypoo: Phab post w my theory ---^^
[00:11:19] <matt_flaschen>	 RoanKattouw, mooeypoo, same.
[00:11:33] <RoanKattouw>	 I looked at this on Elena's laptop in the morning but forgot to write down the results or communicate them to you, sorry about that
[00:13:08] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabs-Regression] Special:Notifications page displays wrong date format for messages - https://phabricator.wikimedia.org/T141915#2517568 (10Mooeypoo) >>! In T141915#2517567, @Catrope wrote: >>>! In T141915#2517393, @Mooeypoo wrote: >> We are calc...
[00:13:25] <mooeypoo>	 RoanKattouw, and here I felt so smug
[00:25:39] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow, 13Patch-For-Review: Better transactionality for Flow undeletion - https://phabricator.wikimedia.org/T135883#2314090 (10Etonkovidova) Checked in betalabs - no new deletion issues have been found.   Clicking 'Delete' on Flow board page redirects to action=delete page tha...
[00:27:06] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "AFAICT, this makes no difference." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302620 (https://phabricator.wikimedia.org/T141915) (owner: 10Mooeypoo)
[00:27:21] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow: [betalabs] Check mark for Resolved topics placed too low - https://phabricator.wikimedia.org/T132195#2191194 (10Mooeypoo) Seems to be resolved. @Etonkovidova can you verify?
[00:28:01] <mooeypoo>	 matt_flaschen, aww, and I thought I was being so smaaaaaaht
[00:28:13] <mooeypoo>	 matt_flaschen, RoanKattouw anyways, how **do** we fix this :\
[00:29:00] <RoanKattouw>	 mooeypoo: My proposal: for each date header, don't use the "timestamp" of the set (i.e. the max of the set) as that date's timestamp, but use midnight of that day
[00:29:17] <RoanKattouw>	 I think that makes more sense in other contexts too, but it would avoid this bug
[00:29:51] <James_F>	 RoanKattouw: You and/or your team almost certainly have Views™ about T141951
[00:29:51] <stashbot>	 T141951: Add local_user_id and global_user_id to localuser table in centralauth database - https://phabricator.wikimedia.org/T141951
[00:30:06] <RoanKattouw>	 James_F: I made Kaldari create that task
[00:30:07] <RoanKattouw>	 So yes :P
[00:30:13] <James_F>	 (And if you don't, tough, you lot own that area. ;-P)
[00:30:16] <James_F>	 Good-o.
[00:30:26] <RoanKattouw>	 Also, no this team does not own CentralAuth
[00:30:36] <James_F>	 You own "users" and "login".
[00:30:40] * RoanKattouw beats away CA work with a large stick
[00:30:48] <James_F>	 Talk to me about what part of that doesn't include CA. :-P
[00:31:58] <matt_flaschen>	 <James_F> You own "users" and "login".
[00:31:59] <matt_flaschen>	 WAT?
[00:33:01] <James_F>	 matt_flaschen: When Editing/Reading/Discovery were created, Editing got users. But then Reading did a year's worth of work on it. I mildly objected at the time.
[00:34:17] <matt_flaschen>	 James_F, and how it did go from "Editing got users" to "Collaboration got users"?
[00:34:49] <matt_flaschen>	 Or is that 'you' more of a 'we'?
[00:35:23] <James_F>	 matt_flaschen: Because you're the only team that does anything to do with accounts. And because I said so, mostly. Subject to negotiations as always.
[00:35:52] <James_F>	 (That said, the link from Notifications to accounts is… tenuous.)
[00:41:32] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 05WMF-deploy-2016-08-02_(1.28.0-wmf.13): [Pre-wmf.13] New notifications icons aren't nicely aligned when there's nothing unread - https://phabricator.wikimedia.org/T141677#2507374 (10Etonkovidova) Checked in betalabs and testwiki (1.28.0-wmf.13 (7db0698))  bet...
[00:46:16] * matt_flaschen goes to tag T68699 in Q1.
[00:46:19] <matt_flaschen>	 Now officially in scope.
[00:46:44] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-extensions-CentralAuth, 06Research-and-Data, 10Wikimedia-General-or-Unknown, and 4 others: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - https://phabricator.wikimedia.org/T68699#2517668 (10Mattflaschen-WMF)
[00:47:59] <James_F>	 matt_flaschen: Awesome how that works out. ;-) But I appreciate that Collab have a lot to work on that doesn't involve CA, and should avoid working on it unless it's more important. :-)
[00:54:00] <grrrit-wm>	 (03CR) 10Krinkle: ConfirmEdit: Stop using buildCssLinks, adapt to ConfirmEdit refactor (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301897 (https://phabricator.wikimedia.org/T140472) (owner: 10Mattflaschen)
[00:57:49] <matt_flaschen>	 Okay, heading out.  Have a good night.
[05:15:22] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Alerts and Notices icons are too large on 1.28-wmf.13 - https://phabricator.wikimedia.org/T141923#2517905 (10Guycn2) Thanks for the patch
[05:20:50] <grrrit-wm>	 (03PS1) 10Catrope: Adjust notification badges for monobook [extensions/Echo] (wmf/1.28.0-wmf.13) - 10https://gerrit.wikimedia.org/r/302654 (https://phabricator.wikimedia.org/T141923) 
[06:31:56] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications: Handle misconfigured notifications in old notification system in a deliberate way - https://phabricator.wikimedia.org/T138534#2518036 (10Kghbln) Let's hope for REL1_28 then. It's a bit sad since no e-mails are sent because of the warnings and notices emitted howeve...
[07:33:11] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Document how to add a new Notification type created by an extension to the Help pages - https://phabricator.wikimedia.org/T141884#2518115 (10Trizek-WMF) >>! In T141884...
[08:31:26] <Nikerabbit>	 are the notification icons supposed to be as big as they are on https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page ?
[08:46:20] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 07Mobile: [mobile] Special:Notification page has horizontal scrolling - https://phabricator.wikimedia.org/T141949#2518204 (10Aklapper)
[09:06:12] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 6 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2518261 (10WMDE-Fisch) @Charlie_WMDE:  @Lea_WMDE @Jan_Dittrich and me favor  `4 new notifications about mentions you made on the...
[09:13:24] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10CologneBlue, 10Modern: Consider not using icons in Modern and CologneBlue skins for notifications - https://phabricator.wikimedia.org/T141944#2518270 (10Legoktm) Right, keeping the icons in MonoBook-based skins (Vector and MonoBook), but get rid of them in ev...
[10:04:06] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Add tests for events on multiple sections edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302449 (owner: 10WMDE-Fisch)
[10:13:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add tests for events on multiple sections edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302449 (owner: 10WMDE-Fisch)
[10:44:02] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications: Mention notifications anomalies - https://phabricator.wikimedia.org/T137755#2518518 (10Lea_WMDE)
[11:02:28] <grrrit-wm>	 (03PS5) 10WMDE-Fisch: Send notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300528 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob)
[11:06:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Send notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300528 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob)
[11:24:39] <grrrit-wm>	 (03PS7) 10Addshore: Allow self mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) 
[11:25:18] <grrrit-wm>	 (03CR) 10Addshore: "PS7 was a rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore)
[11:25:56] <grrrit-wm>	 (03PS8) 10Addshore: Allow self mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) 
[11:26:07] <grrrit-wm>	 (03CR) 10Addshore: "PS7&8 combined are a rebase..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore)
[11:30:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow self mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore)
[11:35:53] <grrrit-wm>	 (03PS9) 10Addshore: Allow self mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) 
[11:38:07] <grrrit-wm>	 (03CR) 10WMDE-leszek: [C: 04-1] Allow self mentions (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore)
[11:38:43] <grrrit-wm>	 (03PS10) 10Addshore: Allow self mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) 
[12:12:37] <grrrit-wm>	 (03PS4) 10WMDE-Fisch: Bundle mention success and failure notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) 
[12:31:41] <grrrit-wm>	 (03PS1) 10: Fix phpdoc in DiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302696 (owner: 10Addshore)
[12:35:39] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Flow, 10DBA, 13Patch-For-Review: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#1828148 (10jcrespo) a:05jcrespo>03None
[12:41:18] <grrrit-wm>	 (03PS1) 10: Add test for EchoDiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302697 (owner: 10Addshore)
[12:41:39] <grrrit-wm>	 (03PS1) 10: Remove unused generateUserIdsForValidUserMentions in test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302698 (owner: 10Addshore)
[12:54:16] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Notifications: Multiple "You made your <milestone> edit!" notifications - https://phabricator.wikimedia.org/T128249#2518746 (10SBisson) a:03SBisson
[13:03:25] <grrrit-wm>	 (03PS1) 10: Add extra case to EchoDiscussionParserTest::testGetSectionCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302702 (owner: 10Addshore)
[13:35:23] <grrrit-wm>	 (03CR) 10WMDE-Fisch: [C: 031] Fix phpdoc in DiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302696 (owner: 10Addshore)
[13:37:05] <grrrit-wm>	 (03CR) 10WMDE-Fisch: [C: 031] "Ups must be a leftover..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302698 (owner: 10Addshore)
[13:39:39] <grrrit-wm>	 (03CR) 10WMDE-Fisch: [C: 031] Add test for EchoDiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302697 (owner: 10Addshore)
[13:43:09] <grrrit-wm>	 (03CR) 10WMDE-Fisch: [C: 031] Add extra case to EchoDiscussionParserTest::testGetSectionCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302702 (owner: 10Addshore)
[14:13:01] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team: Mention notifications anomalies - https://phabricator.wikimedia.org/T137755#2518920 (10matej_suchanek)
[14:31:49] <grrrit-wm>	 (03CR) 10Matěj Suchánek: "one issue and two comments" (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[15:02:57] <grrrit-wm>	 (03CR) 10Matěj Suchánek: [C: 04-1] Bundle mention success and failure notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[15:11:16] <grrrit-wm>	 (03PS5) 10WMDE-Fisch: Bundle mention success and failure notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) 
[15:13:11] <grrrit-wm>	 (03CR) 10WMDE-Fisch: Bundle mention success and failure notifications (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302265 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[15:24:39] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#2519252 (10Qgil)
[15:24:43] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 07Documentation: Create a page about (more) advanced Flow features - https://phabricator.wikimedia.org/T111529#2519254 (10Qgil)
[15:24:47] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 07Documentation: Create an help page about Flow history system - https://phabricator.wikimedia.org/T113581#2519257 (10Qgil)
[15:25:07] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Document Echo Mentions whitelist and blacklist options on Notifications help page - https://phabricator.wikimedia.org/T129642#2519258 (10Qgil)
[15:25:50] <grrrit-wm>	 (03PS1) 10WMDE-Fisch: Small corrections to anonymous mention failure message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) 
[15:41:41] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: In mobile view, bundled notifications extend outside the screen limit - https://phabricator.wikimedia.org/T140523#2519306 (10jmatazzoni) 05Resolved>03Open Moving this to QA, just to be sure we're all good before closing.
[15:54:19] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Timeless: Skin Timeless works currently not for logged in users. - https://phabricator.wikimedia.org/T141894#2519338 (10matmarex) It's probably Echo. Hmm, {T141944} might be relevant.
[15:56:45] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 6 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2519344 (10WMDE-Fisch) Hey @jmatazzoni   I filled the doc with the current status of our messages in regard of failure and succee...
[16:02:23] <grrrit-wm>	 (03PS1) 10WMDE-Fisch: Remove secondary link in bundled messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302730 
[16:03:27] <grrrit-wm>	 (03CR) 10WMDE-Fisch: "PM approved by Lea" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302730 (owner: 10WMDE-Fisch)
[16:04:18] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Timeless: Skin Timeless works currently not for logged in users. - https://phabricator.wikimedia.org/T141894#2519384 (10Isarra) This may be T131738 becoming more severe.
[16:04:33] <grrrit-wm>	 (03PS2) 10WMDE-Fisch: Remove secondary link in bundled messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302730 
[16:05:01] <grrrit-wm>	 (03CR) 10WMDE-Fisch: "PS2: Rebased onto master." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302730 (owner: 10WMDE-Fisch)
[16:23:06] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 05WMF-deploy-2016-08-02_(1.28.0-wmf.13): Fade-out effect breaks sorting order when marking many notifs as read at the same time - https://phabricator.wikimedia.org/T141419#2519437 (10Etonkovidova) Checked the fix in betalabs - in the scenarios...
[16:25:50] <etonkovidova>	 matt_flaschen: re https://phabricator.wikimedia.org/T135883 Are there any plans to make Flow board deletion more like normal wiki pages deletion? 
[16:27:21] <etonkovidova>	 matt_flaschen: right now there is no selection of revision and the history page is not titled as 'Revision history of page'. 
[16:28:11] <matt_flaschen>	 etonkovidova, you mean selection of revision on the history page of a non-Flow page?
[16:28:34] <matt_flaschen>	 etonkovidova, that is RevisionDelete, which is not really applicable to Flow.
[16:28:53] <etonkovidova>	 matt_flaschen: exactly
[16:29:20] <wikibugs>	 06Collaboration-Team-Triage, 10Flow: Flow: Put 'History' in title of Flow topic's history page - https://phabricator.wikimedia.org/T141012#2519489 (10Mattflaschen-WMF)
[16:29:22] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 07Tracking: Flow history page issues (tracking) - https://phabricator.wikimedia.org/T85563#2519488 (10Mattflaschen-WMF)
[16:29:58] <etonkovidova>	 matt_flaschen: I was just surprised how understandable is the process of wikipages deletion is. You can select the revision and delete; it's not the case for Flow pages
[16:30:23] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 07Design, 07Easy: Flow: Topic history page doesn't reflect action in h1 heading or <title> tag - https://phabricator.wikimedia.org/T72472#2519505 (10Mattflaschen-WMF)
[16:30:25] <wikibugs>	 06Collaboration-Team-Triage, 10Flow: Flow: Put 'History' in title of Flow topic's history page - https://phabricator.wikimedia.org/T141012#2484265 (10Mattflaschen-WMF)
[16:31:43] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 07Tracking: Board history page doesn't say Revision history of "Talk:Sandbox" - https://phabricator.wikimedia.org/T142004#2519512 (10Mattflaschen-WMF)
[16:32:21] <wikibugs>	 06Collaboration-Team-Triage, 10Flow, 07Tracking: Board history page doesn't say Revision history of "Full:Board_Title"" - https://phabricator.wikimedia.org/T142004#2519512 (10Mattflaschen-WMF)
[16:33:10] <matt_flaschen>	 etonkovidova, my understanding is that this kind of major feature enhancement is not scheduled for Flow this year.
[16:33:33] <etonkovidova>	 matt_flaschen: it's my understanding too - thx 
[16:33:45] <matt_flaschen>	 etonkovidova, for Flow there is demand for the same kind of feature (deleting just one revision of a post), but currently it does not exist yet.
[16:34:49] <matt_flaschen>	 etonkovidova, the title is a minor thing, T142004 and T72472 .
[16:34:50] <stashbot>	 T142004: Board history page doesn't say Revision history of "Full:Board_Title"" - https://phabricator.wikimedia.org/T142004
[16:34:50] <stashbot>	 T72472: Flow: Topic history page doesn't reflect action in h1 heading or <title> tag - https://phabricator.wikimedia.org/T72472
[16:36:27] <etonkovidova>	 matt_flaschen: right. It's just when I see on deletion action page for Flow the phrase about "This page has a history with approximately 3 revisions: Page history" and going to Page history I cannot figure out what *actual* revisions are there - it's confusing :)
[16:38:33] <etonkovidova>	 stephanebisson: re https://phabricator.wikimedia.org/T131498 -- I saw your comment. I think that the issue is duplicate to https://phabricator.wikimedia.org/T141788
[16:38:51] <matt_flaschen>	 etonkovidova, yeah, you can get the real revisions with https://www.mediawiki.org/wiki/API:Revisions but I completely agree it's confusing to a normal user.
[16:39:43] <etonkovidova>	 matt_flaschen: yes, I can get revision from the db table :) I was talking about user experience, esp since it differs from wikitext page deletion 
[16:39:49] <stephanebisson>	 etonkovidova: yeah, it's the same thing
[16:39:52] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Small corrections to anonymous mention failure message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[16:40:01] <grrrit-wm>	 (03CR) 10Addshore: "wtf" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[16:40:36] <etonkovidova>	 stephanebisson: I am thinking about closing https://phabricator.wikimedia.org/T131498. I filed a separate bug about that horizontal scrolling in mobile - https://phabricator.wikimedia.org/T141949
[16:40:45] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] "I think all the quotes should be removed, as username can include quotes." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[16:41:57] <etonkovidova>	 stephanebisson: it's not exactly what you meant in your comment :), I'd leave what needs to be done about it to, say, design decisions, maybe
[16:42:48] <stephanebisson>	 etonkovidova: my comment was about the menu that is different
[16:43:24] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 6 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2519595 (10WMDE-Fisch) Together with @Lea_WMDE and @Addshore  we just decided on removing the quotes also in the unknown username...
[16:43:36] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Secondary links overflow the width on mobile - https://phabricator.wikimedia.org/T131498#2168807 (10Mooeypoo) This was just fixed with these two commits:   * Mobile version of Special:Notifications https://gerrit.wikimedia.org/r/#/c/302369/ * MobileF...
[16:45:02] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Secondary links overflow the width on mobile - https://phabricator.wikimedia.org/T131498#2519607 (10Mooeypoo) >>! In T131498#2516580, @SBisson wrote: > Why is the dotdotdot menu displaying as a standard mobile menu (at the bottom) in the flyout but a...
[16:45:28] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Secondary links overflow the width on mobile - https://phabricator.wikimedia.org/T131498#2519610 (10Mooeypoo) a:03Mooeypoo
[16:45:39] <grrrit-wm>	 (03PS2) 10WMDE-Fisch: Small corrections to anonymous mention failure message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) 
[16:46:37] <mooeypoo>	 stephanebisson, etonkovidova ha, did I just blindly override your conversation without noticing, re T131498 ? sorry, I just saw you were talking about it above
[16:46:37] <stashbot>	 T131498: Secondary links overflow the width on mobile - https://phabricator.wikimedia.org/T131498
[16:47:32] <mooeypoo>	 stephanebisson, etonkovidova we do need the ticket about the dotdotdot menu behavior in the mobile special page, that's a slightly different problem
[16:49:11] <grrrit-wm>	 (03PS3) 10WMDE-Fisch: Remove double quotes around usernames in failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) 
[16:49:18] <etonkovidova>	 mooeypoo: yup 
[16:50:05] <etonkovidova>	 mooeypoo: stephanebisson we need design overhaul or some major layout corrections for mobile  
[16:55:07] <mooeypoo>	 etonkovidova, I don't know that we need a complete overhault, to be honest. There are fixes we can put in that will make the behavior consistent and workable - the page doesn't look bad otherwise
[16:56:48] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Remove double quotes around usernames in failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[16:59:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove double quotes around usernames in failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[17:02:50] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Remove double quotes around usernames in failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[17:03:40] <MatmaRex>	 Echo master build is broken?
[17:03:50] <MatmaRex>	 https://integration.wikimedia.org/ci/job/mediawiki-extensions-php55/6151/console
[17:04:06] <MatmaRex>	 Strict standards: Declaration of ApiEchoUnreadNotificationPages::getFromForeign() should be compatible with ApiCrossWikiBase::getFromForeign($wikis = NULL, array $paramOverrides = Array) in /mnt/jenkins-workspace/workspace/mediawiki-extensions-php55/src/extensions/Echo/includes/api/ApiEchoUnreadNotificationPages.php on line 206
[17:04:14] <MatmaRex>	 mooeypoo: ^ does that look like a real failure to you?
[17:04:30] <MatmaRex>	 matt_flaschen: ^
[17:05:08] <addshore>	 oooh *reads up*
[17:05:43] <matt_flaschen>	 MatmaRex, it doesn't look new.  I will fix, though.
[17:08:25] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Document how to add a new Notification type created by an extension to the Help pages - https://phabricator.wikimedia.org/T141884#2519695 (10Trizek-WMF)
[17:08:27] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Notifications, 07Documentation: Document new Echo formatting system - https://phabricator.wikimedia.org/T116612#2519694 (10Trizek-WMF)
[17:09:11] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Collaboration-Team-Archive-2015-2016, 10Notifications, 07Documentation: Document new Echo formatting system - https://phabricator.wikimedia.org/T116612#1753838 (10Trizek-WMF) Note: that task has been raised as important during today's standup.
[17:14:29] <wikibugs>	 06Collaboration-Team-Triage, 10Flow: Clicking escape after switching from wikitext to visual editor mode will hide the draft - https://phabricator.wikimedia.org/T142011#2519740 (10Quiddity)
[17:14:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove double quotes around usernames in failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302719 (https://phabricator.wikimedia.org/T140224) (owner: 10WMDE-Fisch)
[17:26:56] <James_F>	 RoanKattouw: https://phabricator.wikimedia.org/T141861
[17:38:13] <grrrit-wm>	 (03PS1) 10Mooeypoo: Round timestamps to the day when displaying date titles in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302748 (https://phabricator.wikimedia.org/T141915) 
[17:38:55] <mooeypoo>	 RoanKattouw, matt_flaschen stephanebisson I think this should do it, but I can't reproduce the conditions of the original bug, so I'm working blind here ^^
[17:40:04] <mooeypoo>	 Now i'm going to lie down in ice and work on LCA final tweaks. I'll be on hangouts if there's anything urgent.
[17:40:50] <stephanebisson>	 mooeypoo: does the bug show up when a notification group is more than 7 days UTC but less than 7 days local?
[17:41:32] <matt_flaschen>	 mooey|away, ice should come first, but can't you just fake the now timestamp and notification timestamp as needed, or is the exact cause still unclear?
[17:49:44] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016: [mobile] the dotdotdot menu layout improvements on Special:Notifications page - https://phabricator.wikimedia.org/T142013#2519866 (10Etonkovidova)
[17:51:06] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Secondary links overflow the width on mobile - https://phabricator.wikimedia.org/T131498#2168807 (10Etonkovidova) @SBisson and @Mooeypoo comments are in a separate task now - {T142013}.
[17:52:15] <RoanKattouw>	 sbisson|lunch: No, it's when you have a notification from the day that's 7 days ago today, but later in the day than the current time (all local time). So for today that would be 2016-06-27, and the latest notification on that day would have to be after 13:52 Eastern
[17:52:32] <RoanKattouw>	 Or at least that's my theory
[17:53:50] <RoanKattouw>	 Basically it has to be "not in the past week" on a per-day basis (because it was a week ago today), but less than 7*24 hours ago so that the timestamp difference measured in weeks rounds down to 0
[17:59:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix phpdoc in DiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302696 (owner: 10Addshore)
[18:00:09] <addshore>	 RoanKattouw: would you possibly be able to look at https://gerrit.wikimedia.org/r/#/c/295489/ today? :)
[18:00:20] <RoanKattouw>	 Sure
[18:02:03] <grrrit-wm>	 (03PS2) 10Addshore: Add test for EchoDiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302697 
[18:02:14] <RoanKattouw>	 BTW I love Gerrit's new in-browser editing feature
[18:02:25] <RoanKattouw>	 (Except for the part where grrrit-wm attributes the patchset to the wrong person)
[18:02:38] <RoanKattouw>	 "Hmm I think this test case should be made slightly more interesting... oh I'll just do it myself"
[18:02:56] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Remove unused generateUserIdsForValidUserMentions in test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302698 (owner: 10Addshore)
[18:03:26] <addshore>	 RoanKattouw: yup, its great
[18:03:33] <addshore>	 although it does make changing the commit message slower
[18:03:33] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add extra case to EchoDiscussionParserTest::testGetSectionCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302702 (owner: 10Addshore)
[18:04:13] <RoanKattouw>	 Yeah that is unfortunate
[18:04:18] <RoanKattouw>	 There's some rough edges
[18:04:29] <RoanKattouw>	 Like, after clicking "Save" I shouldn't have to click "Close"
[18:06:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix phpdoc in DiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302696 (owner: 10Addshore)
[18:06:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add test for EchoDiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302697 (owner: 10Addshore)
[18:08:03] <RoanKattouw>	 addshore: Adding the stripSignature() call to generateMentionEvents() is not directly related to self-mentions but fixes there rendering bug whereby the user's signature is rendered as part of the excerpt in the notification, is that right?
[18:08:12] <RoanKattouw>	 ( https://gerrit.wikimedia.org/r/#/c/295489/10/includes/DiscussionParser.php@149 )
[18:08:24] <RoanKattouw>	 *fixes the
[18:08:50] <addshore>	 RoanKattouw: it is! ;) (you said this in an earlier PS) if the sig is not striped then every comment results in a self mention in the case where a link is in the users sig
[18:09:25] <RoanKattouw>	 Hmm so I did mention this
[18:09:33] <RoanKattouw>	 I thought I had but Gerrit didn't show me any previous comments by me
[18:09:43] <addshore>	 mhhhm
[18:09:50] <RoanKattouw>	 Oooooooh
[18:10:00] <RoanKattouw>	 You need it to avoid self-mentions for every change, got it
[18:10:02] <addshore>	 https://gerrit.wikimedia.org/r/#/c/295489/3/includes/DiscussionParser.php@146
[18:10:03] <addshore>	 ;)
[18:10:43] <addshore>	 If I happened to be fixing a bug by adding that then, well, that is a happy coincidence :D
[18:12:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add test for EchoDiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302697 (owner: 10Addshore)
[18:12:28] <RoanKattouw>	 Hmm so the only thing I don't understand, and perhaps as the tech lead for Echo I should know the answer to this question, but... does notifyAgent=>true unconditionally notify the agent, or is it subject to filtering later?
[18:12:39] <matt_flaschen>	 RoanKattouw, neither I think.
[18:12:48] <RoanKattouw>	 lol that's even more confusing
[18:12:50] <RoanKattouw>	 So what does it do?
[18:12:50] <matt_flaschen>	 RoanKattouw, I think the default is "no matter what, do not notify the agent".
[18:12:54] <RoanKattouw>	 ooooh
[18:12:59] <RoanKattouw>	 So it allows the agent to be notified
[18:13:12] <RoanKattouw>	 if supplied by the GetNotifiedUsers hook or whatever it's called
[18:13:14] <matt_flaschen>	 With that I think it's, "actually, you can notify the agent if you want.  Whatever the locator says"
[18:13:21] <RoanKattouw>	 Right,
[18:13:23] <RoanKattouw>	 OK makes sense
[18:14:09] <addshore>	 RoanKattouw: indeed, it merely allows the agent to be notified :)
[18:15:05] <RoanKattouw>	 Cool
[18:17:23] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] "Re +2 to get over jenkins random failed test" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302697 (owner: 10Addshore)
[18:20:16] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] "Code LGTM, waiting for JoeM to take a look" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore)
[18:22:09] <grrrit-wm>	 (03PS3) 10WMDE-Fisch: Remove secondary link in bundled messages for mention status notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302730 
[18:22:27] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Remove secondary link in bundled messages for mention status notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302730 (owner: 10WMDE-Fisch)
[18:25:21] <addshore>	 thanks for all the review RoanKattouw ! :)
[18:25:26] <RoanKattouw>	 You're welcome!
[18:25:40] <RoanKattouw>	 It turned out jmatazzoni___ (who I don't think is on IRC right now) was not aware of the self-mention thing so he's looking at that now
[18:26:07] <RoanKattouw>	 It was forgotten because of all the mention failure/success notif stuff
[18:27:32] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Round timestamps to the day when displaying date titles in Special:Notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302748 (https://phabricator.wikimedia.org/T141915) (owner: 10Mooeypoo)
[18:28:10] <addshore>	 understandable :)
[18:31:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add test for EchoDiscussionParser::extractHeader [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302697 (owner: 10Addshore)
[18:32:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove secondary link in bundled messages for mention status notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302730 (owner: 10WMDE-Fisch)
[18:33:00] <grrrit-wm>	 (03PS1) 10Sbisson: Prevent duplicate thank-you-edit notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302759 (https://phabricator.wikimedia.org/T128249) 
[18:40:17] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 5 others: Also send notifications to self - https://phabricator.wikimedia.org/T138080#2520016 (10jmatazzoni) I'm sure there is a good reason why users need to mention themselves, but can someone please let me know what it...
[18:42:09] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Secondary links overflow the width on mobile - https://phabricator.wikimedia.org/T131498#2520022 (10Etonkovidova) Checked along with verifying the fix for {T141788}. Also checked hewiki in betalabs  - no specific issues for RTL for this case.
[18:42:16] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10Mention-Notification, 06TCB-Team, and 7 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2520026 (10jmatazzoni) @WMDE-Fisch writs:  > I filled the doc with the current status of our messages in regard of failure and su...
[18:46:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Prevent duplicate thank-you-edit notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302759 (https://phabricator.wikimedia.org/T128249) (owner: 10Sbisson)
[18:49:28] <grrrit-wm>	 (03PS2) 10Sbisson: Prevent duplicate thank-you-edit notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302759 (https://phabricator.wikimedia.org/T128249) 
[18:50:39] <grrrit-wm>	 (03PS1) 10Mattflaschen: Rename ApiEchoUnreadNotificationPages->getFromForeign [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302763 
[18:56:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Rename ApiEchoUnreadNotificationPages->getFromForeign [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302763 (owner: 10Mattflaschen)
[18:58:01] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 07Mobile: [mobile] the dotdotdot menu layout improvements on Special:Notifications page - https://phabricator.wikimedia.org/T142013#2520099 (10Aklapper)
[19:04:56] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Prevent duplicate thank-you-edit notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302759 (https://phabricator.wikimedia.org/T128249) (owner: 10Sbisson)
[19:06:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename ApiEchoUnreadNotificationPages->getFromForeign [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302763 (owner: 10Mattflaschen)
[19:20:04] <etonkovidova>	 stephanebisson: a silly question, sorry - we do not have bundling (for local msgs) on mobile? 
[19:20:26] <stephanebisson>	 etonkovidova: can you be more specific?
[19:21:04] <stephanebisson>	 which view?
[19:21:24] <etonkovidova>	 stephanebisson: I see bundling for new topics on desktop, but not in the echo overlay in mobile
[19:22:18] <stephanebisson>	 quite possible
[19:22:27] <etonkovidova>	 stephanebisson: flyout overlay does has bundling for foreign wiki, but not for local stuff
[19:22:39] <etonkovidova>	 stephanebisson: hmm... any reason for that?
[19:22:48] <stephanebisson>	 there's an api param that controls bundling, I don't remember if we ever talked about it for mobile
[19:26:29] <etonkovidova>	 stephanebisson: interesting, I did not even think that on mobile we may not have local bundling :)) 
[19:27:16] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: In mobile view, bundled notifications extend outside the screen limit - https://phabricator.wikimedia.org/T140523#2467520 (10Etonkovidova) Checked on iPhone9 (iOS 9.3.2), the original issue i.e. "In mobile view, bundled notifications extend outside t...
[19:27:25] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow: "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972#2520312 (10SBisson)
[19:27:27] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow: View and undo of board description diffs at testwiki:talk:sandbox throws InvalidDataException - https://phabricator.wikimedia.org/T119881#2520314 (10SBisson)
[19:43:32] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add a footer notice inviting users to visit the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302357 (https://phabricator.wikimedia.org/T141414) (owner: 10Mooeypoo)
[19:48:46] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2520383 (10daniel) @RobLa-WMF: I'm not sure what @tgr means by a view-interface in this context. I agree for UI design - it's very hard to do th...
[19:49:00] <stephanebisson>	 matt_flaschen: do you think I can help with Flow caching (multi-DC)? Or anything else to suggest? I'm looking for something to do.
[19:49:42] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Alerts and Notices icons are too large on 1.28-wmf.13 - https://phabricator.wikimedia.org/T141923#2520387 (10Nemo_bis)
[19:51:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a footer notice inviting users to visit the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302357 (https://phabricator.wikimedia.org/T141414) (owner: 10Mooeypoo)
[19:51:31] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2520391 (10Legoktm) >>! In T128351#2520383, @daniel wrote: > My point is: core code should not listen e.g. to the LinksUpdateAfterInsert, it sho...
[19:55:44] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2520397 (10daniel) >>! In T128351#2520391, @Legoktm wrote: > Well yes, no one is proposing to do that.  Excellent. Then let's discuss what to do...
[19:58:32] <matt_flaschen>	 stephanebisson, yeah, RoanKattouw suggested you could do that (of course with my help as needed), and I would do ptwikibooks.
[19:59:24] <grrrit-wm>	 (03CR) 10Luke081515: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302759 (https://phabricator.wikimedia.org/T128249) (owner: 10Sbisson)
[20:02:24] <matt_flaschen>	 James_F, RoanKattouw, there was some discussion at Scrum of Scrums about who owns CAPTCHAs/ConfirmEdit (not actually related to my ConfirmEdit work, but to work the security team is planning).  I mentioned that we own login and that CAPTCHAs are related to that, but didn't commit beyond that.
[20:05:14] <stephanebisson>	 matt_flaschen: where should I start with Flow caching?
[20:13:12] <matt_flaschen>	 stephanebisson, I'm trying to find one of the Etherpads about it.
[20:13:24] <stephanebisson>	 matt_flaschen: https://etherpad.wikimedia.org/p/Flow-performance-2015-12-01 ?
[20:15:14] <wikibugs>	 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: In mobile view, bundled notifications extend outside the screen limit - https://phabricator.wikimedia.org/T140523#2520502 (10jmatazzoni) I originally didn't think wrapping made sense, but the screenshot here looks pretty good. Maybe we should try it...
[20:15:33] <matt_flaschen>	 stephanebisson, ah, yeah, I see we continued using the same one.  I was misled by the title.  That's the basic idea.  Can we discuss further tomorrow or later, so I can finish prepping for the Echo in core meeting?
[20:15:45] <stephanebisson>	 sure
[20:16:38] <matt_flaschen>	 The tasks are T120008 and T120009 .
[20:16:38] <stashbot>	 T120008: Remove in-process Memcached wrapper or find an appropriate solution for cross-DC world - https://phabricator.wikimedia.org/T120008
[20:16:38] <stashbot>	 T120009: Flow: Use WAN cache delete() and slave populations to avoid merge() - https://phabricator.wikimedia.org/T120009
[20:20:41] <RoanKattouw>	 matt_flaschen: BTW there's also https://phabricator.wikimedia.org/T140588 which I'd like to put on your radar
[20:23:12] <matt_flaschen>	 RoanKattouw, can we follow up after the Echo meeting today?
[20:23:51] <RoanKattouw>	 Sure, sorry
[20:25:58] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2520540 (10daniel) Brief clarification from the ArchCom meeting (thanks, @Krinkle):  Merging Echo "as-is" still means getting rid of hooks, whic...
[20:39:27] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2520558 (10Mattflaschen-WMF) >>! In T128351#2504237, @Tgr wrote: > * use the `EchoGetDefaultNotifiedUsers` hook to return a list of users to not...
[20:44:01] <grrrit-wm>	 (03PS1) 10Sbisson: Mark all notifications in a foreign bundle as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302817 (https://phabricator.wikimedia.org/T140309) 
[20:45:24] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Mark all notifications in a foreign bundle as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302817 (https://phabricator.wikimedia.org/T140309) (owner: 10Sbisson)
[20:48:01] <matt_flaschen>	 etonkovidova, mooey|away, RoanKattouw, stephanebisson, so as of now, I still think if we want to do this (move some/all of Echo to core), the best approach is to merge it all in.
[20:48:40] <matt_flaschen>	 Obviously, this doesn't mean just dropping all of Echo into core without changing anything.  I agree it should stop using hooks.
[20:48:59] <matt_flaschen>	 But I haven't been convinced of the benefits of making a whole new abstraction layer.
[20:49:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Mark all notifications in a foreign bundle as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302817 (https://phabricator.wikimedia.org/T140309) (owner: 10Sbisson)
[20:50:32] <stephanebisson>	 how come my patch is failing with banana errors (like: Message "echo-popup-footer-special-page-invitation" lacks documentation.) ?
[20:51:25] <quiddity>	 🍌 🍌 🍌   (unicode banana, for anyone without the appropriate font)
[20:52:11] <matt_flaschen>	 stephanebisson, because those are missing docs.  Question is how it got in.
[20:52:53] <stephanebisson>	 introduced by I6d9f9db62ecb85e70f72a9eb5a09e8ea1c8eebc2, merged an hour ago
[20:53:24] <mooey|away>	 matt_flaschen, I actually think we should create a notifications interface in core and leave the more robust implementation in Echo. There are "base" things that MW should be able to do much better to provide an interface to notification creation and basic display, but I am not convinced that MW core should hold Echo's full feature set as it is right now, and possibly not more advanced features
[20:53:52] <matt_flaschen>	 stephanebisson, looks like it got confused because that was a rename.
[20:54:03] <matt_flaschen>	 911f9361aadf453a39f5bfa096e3a9fa73026319
[20:54:14] <mooeypoo>	 I renamed that one... did I screw something up?
[20:54:39] <mooeypoo>	 matt_flaschen, well "renamed"... I added a new one and deleted the old one, they're just super similar to qualify as "renaming"
[20:56:30] <matt_flaschen>	 (BTW, I'm fixing that qqq thing)
[20:56:47] <matt_flaschen>	 mooeypoo, no, it looks like you did https://www.mediawiki.org/wiki/Localisation#Changing_existing_messages right.
[20:56:55] <matt_flaschen>	 Including the part about changing the key when you should.
[20:57:25] <stephanebisson>	 is it a race condition between merging the footer notice and stuff happening on translatewiki?
[20:58:18] <mooeypoo>	 it might be, though I thought banana was only checking local repo
[20:59:02] <mooeypoo>	 stephanebisson, but even if it is, I'd understand a complaint about not having translations... if it's complaining about documentation, something's off in the qqq?
[20:59:23] <grrrit-wm>	 (03PS1) 10Mattflaschen: Fix qqq message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302821 
[20:59:37] <matt_flaschen>	 stephanebisson, yes, I think so.
[20:59:41] <matt_flaschen>	 I think it's an edit conflict in other words.
[20:59:57] <mooeypoo>	 oh! the translation bot overrode it!?
[21:00:14] <matt_flaschen>	 mooeypoo, banana only checks the repo, problem is translatewiki.net put the repo in an inconsistent state: https://gerrit.wikimedia.org/r/#/c/302798/
[21:00:21] <mooeypoo>	 Wait I thought translation bot doesn't override qqq!
[21:00:21] <matt_flaschen>	 mooeypoo, yes, and they bypass all CI.
[21:00:26] <RoanKattouw>	 What probably happened is TWN ate your homework
[21:00:29] <matt_flaschen>	 mooeypoo, no, it can be edited at TWN.
[21:00:36] <mooeypoo>	 I thought they only override the actual language files
[21:00:37] <matt_flaschen>	 (Everything except en I think)
[21:00:41] <RoanKattouw>	 Sometimes there's a race condition and the TWN script reverts recent i18n changes
[21:00:42] <mooeypoo>	 why would it touch the qqq file at all
[21:00:46] <RoanKattouw>	 When that happens I just revert the bot's commit
[21:00:58] <matt_flaschen>	 RoanKattouw, in this case they added a see also, so I "merged" it.
[21:01:06] <RoanKattouw>	 OK
[21:01:09] <RoanKattouw>	 Thanks for the manual cleanup
[21:01:19] <mooeypoo>	 oh, right, they can edit the qqq... meh
[21:01:19] <RoanKattouw>	 I'm usually much less patient with this bug because it's been broken for so long
[21:01:25] <RoanKattouw>	 So I just revert on sight
[21:03:04] <matt_flaschen>	 Echo RFC meeting about moving stuff to core starting now in #wikimedia-office.
[21:03:54] <matt_flaschen>	 ^ etonkovidova, mooeypoo, RoanKattouw, stephanebisson
[21:04:23] <mooeypoo>	 etonkovidova, the moving party is starting!
[21:04:41] <etonkovidova>	 mooeypoo: right :) 
[21:05:07] <matt_flaschen>	 Actually, mooeypoo removed the link in 75f6c1152478f3733f5e0a0a95fa52fc7e4d8f57 , so I don't know exactly what happened.
[21:05:25] <mooeypoo>	 matt_flaschen, It wasn't relevant anymore, I thought
[21:06:20] <matt_flaschen>	 I just put it back put pointing to the new message.
[21:06:24] <matt_flaschen>	 but
[21:07:22] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix qqq message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302821 (owner: 10Mattflaschen)
[21:07:22] <mooeypoo>	 yeah I saw, that is probably good. We had another link there though, to a whole separate message we weren't using for "preferences" text
[21:07:24] <mooeypoo>	 I removed that
[21:14:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix qqq message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302821 (owner: 10Mattflaschen)
[21:22:47] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520680 (10Catrope)
[21:28:02] <grrrit-wm>	 (03PS2) 10Sbisson: Mark all notifications in a foreign bundle as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302817 (https://phabricator.wikimedia.org/T140309) 
[21:43:04] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Mark all notifications in a foreign bundle as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302817 (https://phabricator.wikimedia.org/T140309) (owner: 10Sbisson)
[21:49:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Mark all notifications in a foreign bundle as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302817 (https://phabricator.wikimedia.org/T140309) (owner: 10Sbisson)
[21:51:42] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications: In some cases notifications that were marked read, reappear as unread again - https://phabricator.wikimedia.org/T140309#2520758 (10IKhitron) Thanks! Hope it's a problem indeed.
[21:52:43] <TarLocesilion>	 quick community feedback: new Echo icons are slightly too big
[21:54:45] <RoanKattouw>	 TarLocesilion: Thanks for the reminder; we already have https://phabricator.wikimedia.org/T141923 but so far we've only fixed a location bug in Monobook
[21:54:59] <quiddity>	 TarLocesilion, some discussion in https://phabricator.wikimedia.org/T141923 and... [beaten!]
[21:55:07] <RoanKattouw>	 TarLocesilion: Also let me point out that IE users have it worse :P https://phabricator.wikimedia.org/T142042
[21:56:52] <wikibugs>	 06Collaboration-Team-Triage, 10Flow: Board history page doesn't say Revision history of "Full:Board_Title"" - https://phabricator.wikimedia.org/T142004#2520763 (10Danny_B)
[21:59:01] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications: Alerts and Notices icons look terrible on IE - https://phabricator.wikimedia.org/T142045#2520765 (10Guycn2)
[21:59:15] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications: Alerts and Notices icons look terrible on IE - https://phabricator.wikimedia.org/T142045#2520778 (10Guycn2)
[22:00:47] <TarLocesilion>	 thx. I knew it. my first reaction to the feedback was "check this on phabricator. it's likely to be already reported". and, 2nd thoughts, "ok guys, I'll write 1 line on IRC about this" :)
[22:01:41] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520785 (10Catrope)
[22:01:43] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications: Alerts and Notices icons look terrible on IE - https://phabricator.wikimedia.org/T142045#2520787 (10Catrope)
[22:01:54] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications: Alerts and Notices icons look terrible on IE - https://phabricator.wikimedia.org/T142045#2520789 (10SBisson)
[22:01:56] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520788 (10SBisson)
[22:02:29] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520791 (10Catrope) According to {T142045} this is also broken in IE11 in RTL languages; it worked for me in IE11 in LTR though.
[22:03:00] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2520794 (10Mattflaschen-WMF) Minutes of RFC meeting: https://tools.wmflabs.org/meetbot/wikimedia-office/2016/wikimedia-office.2016-08-03-21.02.h...
[22:03:25] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2520796 (10Mattflaschen-WMF)
[22:06:25] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): In some cases notifications that were marked read, reappear as unread again - https://phabricator.wikimedia.org/T140309#2459846 (10SBisson) This was definitely a possible cause. I'll move this to QA so it can be closed....
[22:09:30] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520830 (10Guycn2) In addition, it doesn't only LOOK bad. It prevents users from clicking links that are hidden by these large icons (such as tabs on the top).
[22:09:47] <matt_flaschen>	 RoanKattouw, do you want to discuss kab wiki Flow now?
[22:09:54] <RoanKattouw>	 Sure
[22:10:07] * RoanKattouw is back in the good old "web standards vs Internet Explorer" battle
[22:10:08] <matt_flaschen>	 My recollection is we said we'll do it on small wikis, but only after explicitly notifying them that only user talk use cases get first class support?
[22:10:14] <RoanKattouw>	 Yes
[22:10:23] <matt_flaschen>	 Has that notification happened?
[22:10:34] <RoanKattouw>	 I think Benoît may have done that, but let me verify
[22:10:58] <RoanKattouw>	 There was more weirdness there, like they didn't do a test page, presumably because there are only 3 active community members who all know Flow from other wikis
[22:11:03] <RoanKattouw>	 Or they had the beta feature, or something
[22:11:31] <RoanKattouw>	 OK, I can find no record of that notification having happened
[22:12:10] <RoanKattouw>	 It's also not clear to me if it's all user talk pages or all talk namespaces
[22:12:17] <RoanKattouw>	 So those things are probably worth clarifying
[22:12:17] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): In some cases notifications that were marked read, reappear as unread again - https://phabricator.wikimedia.org/T140309#2520838 (10IKhitron) 05stalled>03Resolved a:03IKhitron Very well, I'll pay attention. Thank y...
[22:12:24] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520680 (10Etonkovidova) Checked in IE11 LTR  {F4334583} Monobook {F4334586}
[22:14:02] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520847 (10Catrope) p:05Triage>03Unbreak! >>! In T142042#2520830, @Guycn2 wrote: > In addition, it doesn't only LOOK bad. It prevents users from clicking l...
[22:14:45] <matt_flaschen>	 RoanKattouw, we were talking about a form for new notification types.  We should also do one for this, I think.
[22:14:58] <matt_flaschen>	 [ ] User talk Beta feature
[22:15:08] <matt_flaschen>	 [ ] All user talk (link to phab where user talk Beta feature was implemented)
[22:15:15] <matt_flaschen>	 [ ] All talk pages in all namespaces.
[22:15:16] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520851 (10Catrope) >>! In T142042#2520841, @Etonkovidova wrote: > Checked in IE11 LTR  Interesting, I can't reproduce in IE11 on Win10, in either LTR or RTL.
[22:15:53] <RoanKattouw>	 Right, yeah
[22:15:58] <RoanKattouw>	 I think there might be something vaguely like that somewhere
[22:16:06] <RoanKattouw>	 But let's assign Benoit to make a proper one
[22:16:52] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520859 (10Catrope) ...but I can in IE11 on Windows 8.
[22:17:09] <matt_flaschen>	 RoanKattouw, we should also require a sandbox.  It's helpful when you have to test stuff in production.
[22:17:17] <RoanKattouw>	 Yup
[22:17:41] <RoanKattouw>	 I think that's what we've been using, sandbox - beta feature - namespaces
[22:19:39] <grrrit-wm>	 (03PS1) 10Catrope: Prevent IE from rendering the badge SVGs ridiculously big [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302843 (https://phabricator.wikimedia.org/T142042) 
[22:24:48] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] Prevent IE from rendering the badge SVGs ridiculously big [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302843 (https://phabricator.wikimedia.org/T142042) (owner: 10Catrope)
[22:31:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent IE from rendering the badge SVGs ridiculously big [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302843 (https://phabricator.wikimedia.org/T142042) (owner: 10Catrope)
[22:32:02] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2520922 (10daniel) Quick brain dump after the IRC meeting:  * there is logic that is specific to each event type - in particular detecting the e...
[22:34:55] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016: [regression-pre-wmf.13] Cannot opt out of "Flow on user talk" - https://phabricator.wikimedia.org/T142049#2520929 (10Etonkovidova)
[22:41:08] <grrrit-wm>	 (03CR) 10Dereckson: [C: 032] Adjust notification badges for monobook [extensions/Echo] (wmf/1.28.0-wmf.13) - 10https://gerrit.wikimedia.org/r/302654 (https://phabricator.wikimedia.org/T141923) (owner: 10Catrope)
[22:41:13] <grrrit-wm>	 (03CR) 10Dereckson: "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.13) - 10https://gerrit.wikimedia.org/r/302654 (https://phabricator.wikimedia.org/T141923) (owner: 10Catrope)
[22:41:20] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016: [regression-pre-wmf.13] Cannot opt out of "Flow on user talk" - https://phabricator.wikimedia.org/T142049#2520967 (10Etonkovidova)
[22:43:18] <matt_flaschen>	 RoanKattouw, did you ping Trizek about the kab wiki thing?
[22:43:33] <RoanKattouw>	 No, I assumed he'd be asleep already
[22:43:39] <RoanKattouw>	 But I'll ping him so he'll see tomorrow
[22:44:24] <matt_flaschen>	 Yeah, I meant email or something.
[22:44:58] <matt_flaschen>	 Danny_B, are you able to make the meeting tomorrow?  You asked me to check now-ish if you hadn't RSVP'ed.
[22:45:11] <grrrit-wm>	 (03PS1) 10Catrope: Prevent IE from rendering the badge SVGs ridiculously big [extensions/Echo] (wmf/1.28.0-wmf.13) - 10https://gerrit.wikimedia.org/r/302845 (https://phabricator.wikimedia.org/T142042) 
[22:45:22] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520975 (10Etonkovidova) The fix works - checked  in IE11 Windows7. @Catrope, Monobook display issue is still there.
[22:45:41] <Danny_B>	 matt_flaschen: yup. you must be reading my mind, i just recalled i should confirm ;-)
[22:47:19] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520981 (10Catrope) >>! In T142042#2520975, @Etonkovidova wrote: > The fix works - checked  in IE11 Windows7. @Catrope, Monobook display issue is still there....
[22:48:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adjust notification badges for monobook [extensions/Echo] (wmf/1.28.0-wmf.13) - 10https://gerrit.wikimedia.org/r/302654 (https://phabricator.wikimedia.org/T141923) (owner: 10Catrope)
[22:51:46] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016: [regression-wmf.13] Cannot opt out of "Flow on user talk"  - https://phabricator.wikimedia.org/T142049#2521045 (10Etonkovidova)
[22:52:30] <etonkovidova>	 matt_flaschen: I see: Flow\Exception\InvalidInputException from line 128 of /srv/mediawiki/php-1.28.0-wmf.13/extensions/Flow/includes/WorkflowLoaderFactory.php: Flow workflow is for different page
[22:52:38] <grrrit-wm>	 (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.13) - 10https://gerrit.wikimedia.org/r/302845 (https://phabricator.wikimedia.org/T142042) (owner: 10Catrope)
[22:52:47] <etonkovidova>	 matt_flaschen: filed as https://phabricator.wikimedia.org/T142049. 
[22:53:56] <matt_flaschen>	 etonkovidova, yeah, I saw.  It looks bad.
[22:54:07] <etonkovidova>	 matt_flaschen: sigh 
[22:59:15] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2521066 (10Tgr) IMO it's more helpful to think of it in terms of event triggering instead of event detection. Echo has two parts: a generic even...
[23:00:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent IE from rendering the badge SVGs ridiculously big [extensions/Echo] (wmf/1.28.0-wmf.13) - 10https://gerrit.wikimedia.org/r/302845 (https://phabricator.wikimedia.org/T142042) (owner: 10Catrope)
[23:02:42] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Notification badges misaligned in Monobook in IE11 and below - https://phabricator.wikimedia.org/T142053#2521072 (10Catrope)
[23:04:24] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Notification badges are REALLY big in IE10 - https://phabricator.wikimedia.org/T142042#2520680 (10Catrope) I've split out the Monobook issue into {T142053} because it happens in more IE versions than thi...
[23:16:19] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow: [regression-wmf.13] Cannot opt out of "Flow on user talk" - https://phabricator.wikimedia.org/T142049#2521123 (10Mattflaschen-WMF) a:03Mattflaschen-WMF
[23:21:11] <matt_flaschen>	 etonkovidova, can't reproduce scenario #2 of T142049 ?  Can you still?
[23:21:11] <stashbot>	 T142049: [regression-wmf.13] Cannot opt out of "Flow on user talk"  - https://phabricator.wikimedia.org/T142049
[23:21:28] <matt_flaschen>	 etonkovidova, tested with https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Fresh_Flow_opt_in .  You can check out the pages.
[23:21:53] <matt_flaschen>	 Scenario #1 requires a user with it already set up, which I would have to find.
[23:21:56] <etonkovidova>	 matt_flaschen: ok, I will try.
[23:21:57] <matt_flaschen>	 (Unless you have one).
[23:22:09] <wikibugs>	 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10GlobalUserPage: Page curation toolbar should show blue links when there is a global user page - https://phabricator.wikimedia.org/T134073#2521168 (10Quiddity)
[23:24:33] <wikibugs>	 06Collaboration-Team-Triage, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2521175 (10Krinkle) >>! In T128351#2500149, @brion wrote: > Current state: >  > Me & Timo are in agreement that we need good enough interfaces i...
[23:25:01] <etonkovidova>	 matt_flaschen: scenraio #1 - you can try User:Joedemo. Sent you info in google chat
[23:26:26] <matt_flaschen>	 etonkovidova, can you reproduce #2?  If there is some trick to get that to fail, that's simpler to work on (since repeatable).
[23:26:54] <etonkovidova>	 matt_flaschen: scenario #2 - I reproduced in testwiki production too :( But I am trying to do it now 
[23:33:04] <etonkovidova>	 matt_flaschen: interesting... scenario #2 is not happening anymore. Could it be that I was enabling/disabling Flow during the actual deployment time? 
[23:33:21] <etonkovidova>	 matt_flaschen: I will keep trying though 
[23:37:15] <matt_flaschen>	 etonkovidova, eh, I probably shouldn't have merged https://gerrit.wikimedia.org/r/#/c/301069/ ("Simplify and cleanup SubmissionHandler transaction") the day before branch cut.  I don't know for sure that's it, though.
[23:41:34] <etonkovidova>	 matt_flaschen: ok, still interesting  :-)  all looks good now. Except the check box does not remain checked for users with enabled Flow user talk page.
[23:41:50] <etonkovidova>	 matt_flaschen: but it's much more minor 
[23:42:08] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow: [regression-wmf.13] Cannot opt out of "Flow on user talk" - https://phabricator.wikimedia.org/T142049#2521228 (10Mattflaschen-WMF) There is one backend-y thing recently, {1ed57f9f0bb2e05cd2177d0e82749dfd11ff01fc}.  I don't have evidence this is related, though.
[23:42:48] <matt_flaschen>	 etonkovidova, when you check it, save, go back into preferences it's unchecked?
[23:43:42] <etonkovidova>	 matt_flaschen: I am a user with enabled Flow on user talk page --> go to my Preferences-Beta features and I see my Flow option unchecked. 
[23:43:53] <matt_flaschen>	 etonkovidova, did you enable it via preferences, or some other way?
[23:44:02] <matt_flaschen>	 etonkovidova, also, Joedemo did have it checked.
[23:44:50] <etonkovidova>	 matt_flaschen: yes, I checked. I guess the box gets unchecked for "old" users :) 
[23:44:56] <matt_flaschen>	 etonkovidova, so I can't reproduce either of them.
[23:45:13] <matt_flaschen>	 etonkovidova, please reopen if you can reproduce again.
[23:45:41] <etonkovidova>	 matt_flaschen: hold on  - I give you a user with Enabled user talk and unchecked box
[23:46:07] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow: [regression-wmf.13] Cannot opt out of "Flow on user talk" - https://phabricator.wikimedia.org/T142049#2521262 (10Mattflaschen-WMF) 05Open>03Invalid Neither of us can reproduce scenario #2 (the more severe one).
[23:46:15] <wikibugs>	 03Collab-Team-Q1-July-Sep-2016, 10Flow: [regression-wmf.13] Cannot opt out of "Flow on user talk" - https://phabricator.wikimedia.org/T142049#2521264 (10Mattflaschen-WMF) 05Invalid>03Open
[23:47:00] <etonkovidova>	 matt_flaschen: check the user info in the chat 
[23:50:10] <matt_flaschen>	 etonkovidova, okay, confirmed the box is unchecked, let me check the DB.
[23:50:53] <etonkovidova>	 matt_flaschen: good!
[23:56:54] <matt_flaschen>	 etonkovidova, same in database.  Are you sure you enabled it with BetaFeatures, or is it possible you used Special:EnableFlow?