[00:00:00] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend: Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2497440 (10Quiddity) [00:00:38] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend: Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2497164 (10Quiddity) (updated title/description based on discussion thus far) [00:00:41] Thanks for gnoming that, quiddity [00:01:09] :-) [00:04:06] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend: Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2497467 (10kaldari) @Catrope: That would work for me. You might also want to consider changing the color of the badge from red to grey... [00:05:58] RoanKattouw: there are two bugs that I filed as betalabs regression https://phabricator.wikimedia.org/T140836 and https://phabricator.wikimedia.org/T140327 [00:06:19] RoanKattouw: now they are thriving in testwiki wmf.11 Sigh... [00:06:33] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend: Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2497475 (10Catrope) >>! In T141404#2497467, @kaldari wrote: > @Catrope: That would work for me. You might also want to consider changin... [00:06:49] RoanKattouw: they are so noticeable... [00:07:13] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MobileFrontend: Add "Mark all as read" button for Notification badge in mobile - https://phabricator.wikimedia.org/T141404#2497476 (10Catrope) [00:07:19] Looking [00:08:05] The empty cross-wiki bundle thing is strange, do you have reliable reproduction steps for that? [00:10:24] etonkovidova: And has the incorrect counts bug been observed in production yet? [00:10:52] RoanKattouw: hmm... not exaclty [00:11:33] RoanKattouw: Failed to fetch and just wiki titles exapnded without notifications [00:11:36] 10Notifications, 10Mention-Notification, 06TCB-Team, 06WMDE-Design, and 3 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2497516 (10Danny_B) [00:12:21] 10Notifications, 10Mention-Notification, 06TCB-Team: Notifications: Allow setting a link target for secondary links - https://phabricator.wikimedia.org/T139344#2497521 (10Danny_B) [00:12:32] RoanKattouw: the issue is kind of convoluted, unfortunately . But i am worried that its impact may be greater that we thought [00:12:51] RoanKattouw: I did not expect that it'd be so easy to see in wmf.11 testwiki [00:14:45] RoanKattouw: I attached a screen recording to https://phabricator.wikimedia.org/T140836 - that's how the issue typically looks [00:16:45] Hmm [00:17:02] Did you do anything to provoke the issue or was it just like that all of a sudden? [01:03:09] (03PS17) 10Mooeypoo: Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) [01:03:19] (03PS18) 10Catrope: Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [01:07:11] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabs] Special: Notifications - incorrect day format timestamp is displayed - https://phabricator.wikimedia.org/T141413#2497611 (10Etonkovidova) [01:18:48] Grepping through all of Wikimedia GitHub on getForm for https://github.com/wikimedia/mediawiki-extensions-ConfirmEdit/blob/master/SimpleCaptcha/Captcha.php#L89 . [01:18:52] :) [01:19:04] Not as bad as I thought, only 122. [01:31:44] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Invite users to try the new Notifications page (using the Notifications panel) - https://phabricator.wikimedia.org/T141414#2497647 (10jmatazzoni) [01:36:13] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Invite users to try the new Notifications page (using the Notifications panel) - https://phabricator.wikimedia.org/T141414#2497671 (10jmatazzoni) If the user clicks on the blue Read/Unread dot, the message should disappear and not come back. **Ques... [01:36:54] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Invite users to try the new Notifications page (using the Notifications panel) - https://phabricator.wikimedia.org/T141414#2497672 (10jmatazzoni) [01:40:50] (03PS9) 10Mattflaschen: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (https://phabricator.wikimedia.org/T141413) [02:14:24] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension): Clean up how ConfirmEdit tracks modules associated with CAPTCHA - https://phabricator.wikimedia.org/T141300#2497707 (10Mattflaschen-WMF) From reviewing https://github.com/search?q=org%3Awikimedia+getForm&type=Code , the only Gerrit-hosted exten... [02:22:12] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension), 10MediaWiki-extensions-WikiForum, 10Social-Tools: Stop using getForm for ConfirmEdit changes - https://phabricator.wikimedia.org/T141416#2497731 (10Mattflaschen-WMF) [02:22:31] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension), 10MediaWiki-extensions-WikiForum, 10Social-Tools: WikiForum: Stop using getForm for ConfirmEdit changes - https://phabricator.wikimedia.org/T141416#2497748 (10Mattflaschen-WMF) [02:24:32] (03CR) 10Catrope: [C: 04-1] "I've found another bug: the badge counts no longer use native digits (i.e. they always use 123... whereas in e.g. Bengali they should use " (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [02:24:39] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension), 10MediaWiki-extensions-WikiForum, 10Social-Tools: WikiForum: Stop using getForm due to ConfirmEdit changes - https://phabricator.wikimedia.org/T141416#2497756 (10Mattflaschen-WMF) [02:25:15] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension), 10MediaWiki-extensions-ContactPage: ContactPage: Stop using getForm due to ConfirmEdit changes - https://phabricator.wikimedia.org/T141417#2497758 (10Mattflaschen-WMF) [02:25:35] (03CR) 10Catrope: Redo the notification badges (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [02:25:56] (03PS10) 10Catrope: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (https://phabricator.wikimedia.org/T141413) (owner: 10Mattflaschen) [02:26:31] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension), 10MediaWiki-extensions-ContactPage: ContactPage: Stop using getForm due to ConfirmEdit changes - https://phabricator.wikimedia.org/T141417#2497758 (10Mattflaschen-WMF) [02:26:40] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension), 10MediaWiki-extensions-ConfirmAccount: ConfirmAccount: Stop using getForm due to ConfirmEdit changes - https://phabricator.wikimedia.org/T141418#2497787 (10Mattflaschen-WMF) [02:26:52] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension), 10MediaWiki-extensions-ConfirmAccount: ConfirmAccount: Stop using getForm due to ConfirmEdit changes - https://phabricator.wikimedia.org/T141418#2497787 (10Mattflaschen-WMF) a:05Florian>03Mattflaschen-WMF [02:28:42] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Flow: Update to stop using buildCssLinks and for related ConfirmEdit change - https://phabricator.wikimedia.org/T140472#2497808 (10Mattflaschen-WMF) [02:29:37] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Flow: Update to stop using buildCssLinks and for related ConfirmEdit change - https://phabricator.wikimedia.org/T140472#2465986 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [02:35:21] Heading out, have a good night, see you tomorrow. [02:36:09] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabs] Special: Notifications - incorrect day format timestamp is displayed - https://phabricator.wikimedia.org/T141413#2497611 (10Catrope) To be precise, this happens if: - Your timezone offset from UTC is negative (so that midnight UTC occurs b... [02:41:34] (03CR) 10Catrope: [C: 04-1] BREAKING CHANGE: More ISO 8601 for seen time (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (https://phabricator.wikimedia.org/T141413) (owner: 10Mattflaschen) [02:42:15] (03PS11) 10Mattflaschen: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (https://phabricator.wikimedia.org/T141413) [02:55:23] (03CR) 10Catrope: [C: 04-2] BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (https://phabricator.wikimedia.org/T141413) (owner: 10Mattflaschen) [03:08:43] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: Fade-out effect breaks sorting order when marking many notifs as read at the same time - https://phabricator.wikimedia.org/T141419#2497840 (10Catrope) [03:10:43] (03PS5) 10Mooeypoo: [wip] Update and fetch seenTime per source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 (https://phabricator.wikimedia.org/T134855) [03:11:00] (03CR) 10Catrope: [C: 031] "Looks good to me. Is there a reason this is still WIP?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [03:11:47] (03CR) 10Catrope: [C: 032] "I meant to +2, not -2, silly me" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (https://phabricator.wikimedia.org/T141413) (owner: 10Mattflaschen) [03:15:47] (03PS6) 10Catrope: [wip] Update and fetch seenTime per source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [03:21:33] (03Merged) 10jenkins-bot: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (https://phabricator.wikimedia.org/T141413) (owner: 10Mattflaschen) [03:22:53] (03CR) 10Catrope: [C: 031] [wip] Update and fetch seenTime per source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [03:28:48] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2497914 (10Catrope) >>! In T134855#2471979, @Catrope wrote: > We discussed this in our team discussion meeting and @Mattflaschen-WMF came up with the following... [03:29:26] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Use UTC and ISO 8601 everywhere - https://phabricator.wikimedia.org/T141164#2497915 (10Catrope) Did https://gerrit.wikimedia.org/r/300596 take care of all of this, or is there still something left to do? [03:43:50] (03CR) 10Mooeypoo: "> Looks good to me. Is there a reason this is still WIP?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [04:12:17] 10Notifications, 10Mention-Notification, 06TCB-Team, 06WMDE-Design, and 3 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2457076 (10Catrope) Messages extracted from the various patches currently in Gerrit: - Preference category label for mention failure notificat... [04:13:18] mooeypoo: where is your extension creator web page thing again? [04:13:48] legoktm: https://github.com/mooeypoo/MWStew [04:13:56] * RoanKattouw http://tools.wmflabs.org/mwstew/ [04:14:08] thank you :D [04:14:11] ... wtf IRCCloud, why did that get rendered as a /me [09:46:12] 10Notifications: The bell does not show me my notifs - https://phabricator.wikimedia.org/T139876#2498276 (10Aklapper) 05Open>03declined Unfortunately closing this report as no further information has been provided. @Nnemo: Please reopen this report (by changing its status) after you have provided the inform... [09:47:44] 10Flow, 06Multimedia, 10UploadWizard: JavaScript errors for Flow in UploadWizard - https://phabricator.wikimedia.org/T141427#2498280 (10Josve05a) [10:00:34] (03PS34) 10WMDE-Fisch: Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [10:37:39] 10Notifications, 07Documentation: Create a glossary about Notifications - https://phabricator.wikimedia.org/T141429#2498365 (10Trizek-WMF) [10:38:58] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation, 07Tracking: Update Help:Notifications (tracking) - https://phabricator.wikimedia.org/T119713#2498379 (10Trizek-WMF) [10:39:00] 10Notifications, 07Documentation: Create a glossary about Notifications - https://phabricator.wikimedia.org/T141429#2498365 (10Trizek-WMF) [10:39:13] 10Notifications, 07Documentation: Create a glossary about Notifications - https://phabricator.wikimedia.org/T141429#2498365 (10Trizek-WMF) [10:39:15] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2498381 (10Trizek-WMF) [10:52:45] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2498402 (10SBisson) >However, if I first notice it on A (the wiki it came from) and view it there, A's seentime will be updated but B's won't. If I then visit B... [11:01:06] (03PS35) 10WMDE-Fisch: Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [11:18:56] (03CR) 10Addshore: [C: 032] Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [11:27:58] (03Merged) 10jenkins-bot: Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [11:48:00] (03CR) 10Addshore: [C: 04-1] "Some of the comments I raise would probably be fixed with a rebase!" (039 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [11:56:22] (03CR) 10Addshore: [C: 04-1] Echo notifications for successful mentions (037 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) (owner: 10WMDE-Fisch) [11:59:35] (03CR) 10Matěj Suchánek: Add mention failure notification for multiple section edits (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [12:00:08] (03CR) 10Matěj Suchánek: Echo notifications for successful mentions (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) (owner: 10WMDE-Fisch) [12:11:21] (03CR) 10Matěj Suchánek: Allow self mentions (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore) [14:35:09] (03PS5) 10Addshore: Allow self mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) [14:59:54] (03PS1) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) [15:02:09] (03PS21) 10WMDE-Fisch: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) [15:02:51] (03CR) 10WMDE-Fisch: "Thanks for the review. In most cases I decided on having public methods to have them testable." (0312 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [15:03:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) (owner: 10Sbisson) [15:05:19] (03CR) 10jenkins-bot: [V: 04-1] Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [15:06:03] (03PS1) 10WMDE-Fisch: Rename mention-too-many failure notification. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301385 [15:11:35] (03CR) 10WMDE-Fisch: Add mention failure notification for multiple section edits (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [15:19:17] (03PS2) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) [15:29:06] 10Notifications, 10Mention-Notification, 06TCB-Team, 06WMDE-Design, and 3 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2499057 (10Charlie_WMDE) > > - Re. your comment about "an additional action to expand the message body." We have a misunderstanding, since... [15:45:47] (03PS5) 10WMDE-Fisch: Echo notifications for successful mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) [15:46:59] (03CR) 10WMDE-Fisch: Echo notifications for successful mentions (038 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) (owner: 10WMDE-Fisch) [15:54:03] (03CR) 10WMDE-Fisch: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [16:20:38] (03CR) 10Mattflaschen: "Also, per our discussion on IRC, since this involves cross-wiki, there are dependencies on API patches being on all wikis." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 (https://phabricator.wikimedia.org/T134855) (owner: 10Mooeypoo) [16:20:46] 10Notifications, 10Mention-Notification, 06TCB-Team, 06WMDE-Design, and 3 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2499213 (10Charlie_WMDE) >>! In T140224#2497943, @Catrope wrote: > Messages extracted from the various patches currently in Gerrit: > > - Pref... [16:22:03] (03PS3) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301382 (https://phabricator.wikimedia.org/T140327) [16:32:28] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2499263 (10Trizek-WMF) [16:35:13] 10Notifications, 10Mention-Notification, 06TCB-Team, 06WMDE-Design, and 3 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2499291 (10Charlie_WMDE) Just realised it's a bit silly of me to ask you when I can ask the developers working on the patches directly m) We'll... [16:41:27] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 05WMF-deploy-2016-08-02_(1.28.0-wmf.13): [betalabs] Special: Notifications - incorrect day format timestamp is displayed - https://phabricator.wikimedia.org/T141413#2499317 (10Etonkovidova) [16:41:56] (03PS2) 10WMDE-Fisch: Rename mention-too-many failure notification. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301385 [16:45:42] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Invite users to try the new Notifications page (using the Notifications panel) - https://phabricator.wikimedia.org/T141414#2499327 (10Trizek-WMF) >>! In T141414#2497671, @jmatazzoni wrote: > **Questions: ** > - Will this run on all wikis? (are ther... [16:46:23] (03CR) 10Addshore: [C: 032] Rename mention-too-many failure notification. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301385 (owner: 10WMDE-Fisch) [16:49:37] 10Notifications, 10Mention-Notification, 06TCB-Team, 06WMDE-Design, and 3 others: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2499335 (10Charlie_WMDE) bundled messages: {F4312578} {F4312576} Single failures: {F4312577} {F4312573} Bundled failures: {F4312572} Overa... [16:54:16] (03Merged) 10jenkins-bot: Rename mention-too-many failure notification. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301385 (owner: 10WMDE-Fisch) [17:01:00] google hangouts is being annoying, it's taking me a moment to connect [17:24:18] (03PS22) 10Addshore: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [17:27:15] (03PS23) 10Addshore: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [17:27:41] (03CR) 10Addshore: "PS22 was a manual rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [17:40:25] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07I18n, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Months in the notifications should be upper- or lowercase, as appropriate per each language - https://phabricator.wikimedia.org/T141092#2499533 (10jmatazzoni) 05Open>03Resolved a:03... [17:41:30] (03CR) 10Addshore: [C: 04-1] "So, this is meant to notify on a failed mention due to editing multiple sections?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [17:42:50] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2499537 (10jmatazzoni) [17:42:52] 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Notifications page: remove mw-echo-special-header-link - https://phabricator.wikimedia.org/T141141#2499536 (10jmatazzoni) 05Open>03Resolved [17:44:03] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): "You have new messages" (OBOD) no longer automatically disappears/reappears when user talk notifs marked as read/unread - https://phabricator.wikimedia.org/T141047#2499539 (10jmatazzoni) 05Open>... [17:44:34] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12), 07Wikimedia-log-errors: Array must contain at least one element in ApiEchoNotifications. php on line 341 - https://phabricator.wikimedia.org/T139529#2499541 (10jmatazzoni) 05Open>03Resolved [17:45:29] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Epic, 07Tracking: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2499543 (10jmatazzoni) [17:45:31] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2499542 (10jmatazzoni) 05Open>03Resolved [17:45:53] 10Notifications: Notification: bad localization when section name is a magicword - https://phabricator.wikimedia.org/T141460#2499545 (10Framawiki) [17:46:08] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Flow not warning me when I leave an edit page with unsaved changes - https://phabricator.wikimedia.org/T96531#2499561 (10jmatazzoni) 05Open>03Resolved [17:51:48] 06Collaboration-Team-Interested, 10Flow, 06Discovery, 10Kartographer, and 2 others: is not visible in Flow (blank frame) - https://phabricator.wikimedia.org/T140920#2499568 (10jmatazzoni) [17:54:12] 06Collaboration-Team-Interested, 10Flow: Cannot load an old Flow topic by clicking on its title in "Browse topics" - https://phabricator.wikimedia.org/T139299#2499572 (10jmatazzoni) [17:59:28] 06Collaboration-Team-Interested, 10Notifications: Remove Echo transition flags - https://phabricator.wikimedia.org/T140710#2499601 (10jmatazzoni) [18:00:49] 06Collaboration-Team-Interested, 10Flow, 07Technical-Debt: Flow should not manually forward metadata from ParserOutput - https://phabricator.wikimedia.org/T140665#2499608 (10jmatazzoni) [18:01:17] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 07Technical-Debt: Flow should not manually forward metadata from ParserOutput - https://phabricator.wikimedia.org/T140665#2471910 (10jmatazzoni) [18:02:35] I actually really quite like Flow now.... :D [18:03:48] mooeypoo: I see some broken pagination on Special:Notifications - first page 1-43, second page- 51- 73, third page - 101-130 [18:04:04] O.o [18:04:07] mooeypoo: it's in betalabs - any idea why it broke? [18:04:12] no.... [18:04:26] mooeypoo: hmm... [18:04:35] Not happening for me in master [18:06:33] mooeypoo: I especially like the unpredictability of pagination pattern - another user shows: 1-48, and 51-98 [18:07:07] mooeypoo: kind of making your pagination experience more surprising :) [18:12:57] what the ... [18:14:22] mooeypoo: yeah [18:20:46] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabs-Regression] Special:Notifications - the pagination does not follow default pattern of 50 messages per page - https://phabricator.wikimedia.org/T141463#2499629 (10Etonkovidova) [18:24:36] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabs-Regression] Special:Notifications - the pagination does not follow default pattern of 50 messages per page - https://phabricator.wikimedia.org/T141463#2499643 (10Etonkovidova) [18:28:48] (03CR) 10Mooeypoo: Redo the notification badges (0321 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [18:32:22] 06Collaboration-Team-Interested, 10Notifications: Notification: bad localization when section name is a magicword - https://phabricator.wikimedia.org/T141460#2499667 (10Quiddity) [18:34:38] etonkovidova, I'm currently dealing with fixing up the badges -- can you report the pagination bug? I'll do that as soon as I finish the badges [18:35:06] mooeypoo: I reported it - https://phabricator.wikimedia.org/T141463 [18:35:35] etonkovidova, thanks! [18:44:18] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Use UTC and ISO 8601 everywhere on frontend - https://phabricator.wikimedia.org/T141164#2499693 (10Mattflaschen-WMF) [18:47:31] (03PS1) 10Mattflaschen: Note removal of wgEchoInitialNotifCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301420 [18:47:51] (03CR) 10Mattflaschen: [C: 032] "Self-merge doc fix" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301420 (owner: 10Mattflaschen) [18:49:20] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [regression-betalabs] Mobile Special:Notifications page displays only weekday names - https://phabricator.wikimedia.org/T141466#2499706 (10Etonkovidova) [18:51:23] (03PS19) 10Mooeypoo: Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) [18:53:37] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [betalabas] Mobile Special:Notifications page displays only weekday names - https://phabricator.wikimedia.org/T141466#2499724 (10Etonkovidova) [18:53:58] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Make Notification page on mobile usable by suppressing the left, filtering nav (for now) - https://phabricator.wikimedia.org/T140687#2499729 (10Etonkovidova) {icon chec... [18:54:42] (03Merged) 10jenkins-bot: Note removal of wgEchoInitialNotifCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301420 (owner: 10Mattflaschen) [19:08:27] mooeypoo, T114270 is pretty bad (saw that when looking at how the local times work). [19:08:28] T114270: Date-time formats in MWTimestamp don't support timezone specifiers - https://phabricator.wikimedia.org/T114270 [19:08:50] P3587 [19:08:51] P3587 (An Untitled Masterwork) - https://phabricator.wikimedia.org/P3587 [19:09:27] It basically doesn't track zones at all. When you call offsetForUser, it just gives you a *different* time, and then it's your job to know the time zone. [19:09:38] And it just says it's in Z (Zulu time, UTC) even though it's actually not. [19:10:33] So it's good I didn't add iso8601 (the non-UTC version). [19:11:42] matt_flaschen, yikes [19:12:07] matt_flaschen, can we still trust moment() to recognize the timezone through .local() ??? [19:14:21] mooeypoo, it shouldn't be an issue, just don't use the non-UTC options from the server. [19:14:51] mooeypoo, I'm not sure how moment parses in local mode with a Z suffix (there is a bug, one sec), but we shouldn't be doing that, right (parsing in local mode)? [19:14:57] matt_flaschen, I **think** we're not anymore [19:15:14] no, moment somehow gets localized [19:16:21] I think I was thinking of the opposite bug, https://github.com/moment/moment/issues/275 , but there is also https://github.com/moment/moment/issues/272#issuecomment-5095486 . [19:16:35] mooeypoo, so you tested, and in local mode it still parses Z-suffix time as local time. [19:16:41] ? [19:19:30] Gee, I think so, but now i'm not sure :\ [19:21:57] mooeypoo, let me check. [19:27:14] mooeypoo, yeah, it's like you said (moment's behavior here is also questionable, but it is "local mode" and maybe they have to deal with a lot of software lying about it being UTC): [19:27:16] mw.loader.using( 'moment' ).done( function() { var input = '2016-07-28T04:06:34Z'; console.log( 'Input: ', input ); var ts = moment( input ); console.log( 'Right after parse: ', ts.format() ); ts.utc(); console.log( 'After .utc()', ts.format() ); } ); [19:28:10] mooeypoo, wait, sorry, I'm wrong. [19:28:36] mooeypoo, it parses it as UTC then outputs as local. [19:30:29] So moment does take the Z to mean what it says, which is a reason not to parse MW's local-time-but-it-has-Z in moment. [19:36:29] (03CR) 10Matěj Suchánek: Allow self mentions (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore) [19:39:59] (03CR) 10Matěj Suchánek: Echo notifications for successful mentions (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) (owner: 10WMDE-Fisch) [19:41:13] matt_flaschen, phew [19:41:54] mooeypoo, well, not phew if we were parsing MW local times. But we shouldn't be. [19:42:09] matt_flaschen, I think after the merged fix we aren't anymore [19:42:21] everything is utc 8601, only display format is localized [19:42:41] we should double check in QA that everything looks right, but I don't think we are taking any "local" anymore [19:42:45] Yeah, I'm finishing reviewing that now, but hopefully we caught everything. [19:43:04] only place we might be doing that is in the special page when we divide to groups [19:43:10] but i am fairly sure i was using moment there too [19:43:32] matt_flaschen, yeah localizedDate = moment.utc( newNotifData.timestamp ).local().format( 'YYYYMMDD' ); [19:46:28] meh etonkovidova I'm trying to reproduce your pagination bug, but my user in beta has only 35 notifications, so I'm addingmore, but now "anti abuse" filters are kicking in ;\ [19:47:04] mooeypoo: are you using stephanebisson's script? [19:47:12] etonkovidova, I can't in beta [19:47:16] I don't have access [19:47:34] etonkovidova, I can't reproduce this on master on my machine, so I'm trying to see if beta has something unique [19:47:51] mooeypoo: ah - yes. Well, it's strange that you triggered abuse filter [19:48:06] etonkovidova, well I was adding tons of topics to a flow page to trigger 'new topic' notification [19:48:16] so it's not that unexpected :\ [19:48:28] etonkovidova, can you run stephanebisson's script on beta [19:48:28] ? [19:48:36] if you can, can you generate notification son my username? [19:49:16] etonkovidova, User:Mooeypoo [19:49:44] mooeypoo: which pages do you watch? [19:50:16] mooeypoo, we're using that comparator (or comparators since one is based on name) like 10 times. If we have to change it again, we should make a utility. [19:51:34] matt_flaschen, what comparator? [19:52:02] etonkovidova, I think the script takes that into account for -u but if not, http://en.wikipedia.beta.wmflabs.org/wiki/Flow_test_talk:Foo and the talk page [19:52:12] http://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Mooeypoo [19:52:33] mooeypoo: got it [19:52:40] mooeypoo, the reverse sorting timestamp one. E.g. https://gerrit.wikimedia.org/r/#/c/300596/11/modules/ui/mw.echo.ui.NotificationsListWidget.js [19:53:04] matt_flaschen, that's what I told RoanKattouw [19:53:07] but he was against it [19:53:23] I wanted to make some helper/utility method that we just keep calling but he was all disgusted with me [19:53:32] What was his argument? [19:53:52] He said that we should translate them into string-comparable formats if we want to prevent this [19:54:06] like translate everything from the API into unix or something [19:54:09] which I was against [19:54:23] And he didn't like having a method that's not really "attached" to anything, I think [19:54:33] like, I was going to put something in the definition of echo.dm = { ... } [19:54:40] but we can solve that by making it a controller method [19:54:47] mooeypoo, it is string comparable. I guess he meant you can use subtract operator. [19:54:48] or a manager method [19:54:58] subtract, yes, sorry, that's what I meant [19:55:14] I don't think it's that much of a difference, except "looking nicer" [19:55:34] we will still have to repeat the diff = Number( blah ) -Number( blip ) [19:55:44] so it doesn't fix the same issues anyways [19:56:10] I get the idea that stuff should be organized, and it's sometimes awkward to have utilities, but most projects have a few. [19:56:24] I agree [19:56:35] Especially since I had to go over each of them to fix it [19:56:54] if we ever want to change the sorting, it's silly to go over the entire code for the iterations -- that's what methods are **for** [19:57:31] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 07Technical-Debt: Flow should not manually forward metadata from ParserOutput - https://phabricator.wikimedia.org/T140665#2471910 (10jmatazzoni) Triage meeting discussed this and suggests we do it but only if it's easy. So if you run into difficulty, make a note about... [19:58:12] matt_flaschen, are we outvoting RoanKattouw ? If we are, we may need to get consensus vote on-wiki and allow for a few days of {{support}} and {{oppose}} voting [19:58:14] :P [19:59:12] in all seriousness, though, I completely agree. I think it's a perfect example of having an organized utility method - if not in the general dm. namespace (which I can see can be a problem) we can put it elsewhere, or do what OOUI does with mixins and add our own sub-namespace [19:59:28] echo.dm.util.reverseSorting() or something [19:59:45] There are probably other cases of us repeating stuff we can use that namespace for [20:03:07] There's one I didn't catch, 'ts' in sources. [20:04:35] matt_flaschen, oops, where? [20:04:47] oh, from the API! ha [20:05:09] matt_flaschen, probably also from the one we get notifications from pages [20:05:20] the UI uses that to sort phillip [20:06:15] mooeypoo, doesn't look like we use 'ts'. [20:07:44] mooeypoo, oops, we do. [20:09:42] mooeypoo: you can check User:Mooeypoo - 51 msgs [20:10:22] mooeypoo: if the pagination is correct (and I ssuspect it would be) - I'll give you one of my users with broken pagination [20:11:19] mooeypoo, that's only used to sort within the cross-wiki bundle, right (where the bundle itself goes is based on timestamp?) [20:12:52] matt_flaschen, iirc, it's used in cross-wiki widget and in the sidebar [20:13:22] matt_flaschen, ironically, though, it's probably NOT used in cross wiki -- we give the xwiki thing a timestamp but "getTimestamp()" first checks if there are items and then gets the timestamp from the latest item [20:13:50] so really, this would only "screw up" the ordering of the xwiki source groups while it loads its sub items [20:13:56] but the sidebar is probably affected [20:14:15] mooeypoo, it looks like it uses the ts, unless there is only one item? [20:14:56] 06Collaboration-Team-Interested, 10Notifications, 10ArchCom-RfC, 10MediaWiki-Watchlist, 07RfC: RfC: Need to merge Notifications and Watchlist or lack thereof - https://phabricator.wikimedia.org/T128352#2500094 (10RobLa-WMF) p:05Triage>03Normal Priority set in E236 [20:15:02] mooeypoo, https://phabricator.wikimedia.org/diffusion/ECHO/browse/master/modules/model/mw.echo.dm.NotificationsList.js;debd9afffdb130c37f1c1d1f1899bf70c294fc9e$206 . [20:16:04] no, if there are any items, it takes the timestamp of the top item [20:16:13] because the DM also sorts by item timestamp [20:16:22] (semi here, cooking lunch) [20:17:19] Whoops, I read what I thought it was going to say, not what it actually says. [20:17:58] mooeypoo, when you say, "probably also from the one we get notifications from pages" do you mean 'ts' affects that, or that there is another API broken (unreadnotificationpages doesn't have any time output AFAICT). [20:18:49] matt_flaschen, oh, that's right, we sort those by number of pages, not timestamp -- I meant the API being broken, but you're right, I forgot it doesn't get the timestamp there at all [20:19:40] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Use UTC and ISO 8601 everywhere on frontend - https://phabricator.wikimedia.org/T141164#2500105 (10Mattflaschen-WMF) >>! In T141164#2497915, @Catrope wrote: > Did https://gerrit.wikimedia.org/r/300596 take care of all of this, or is there still something left to... [20:19:59] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Make Notification page on mobile usable by suppressing the left, filtering nav (for now) - https://phabricator.wikimedia.org/T140687#2500108 (10jmatazzoni) I'm seeing t... [20:25:51] 06Collaboration-Team-Interested, 10Notifications, 07Community-Wishlist-Survey: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#2500115 (10Nemo_bis) This report seems much wider (concerning any sort of event or thing on the wiki rather than a specific page) and at the sa... [20:51:53] 06Collaboration-Team-Interested, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2071444 (10daniel) To me it seems like we should at least have the interfaces (aka, the services) an a basic (or empty) implementation of a... [20:52:51] 06Collaboration-Team-Interested, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2500149 (10brion) Current state: Me & Timo are in agreement that we need good enough interfaces in core that other extensions don't have to... [21:00:47] (03PS1) 10Mattflaschen: BREAKING CHANGE: Use ISO 8601 for 'ts' in cross-wiki summary. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301489 (https://phabricator.wikimedia.org/T141164) [21:02:31] mooey|lunch, I did test https://gerrit.wikimedia.org/r/301489 , but would appreciate you doing so as well just in case I misunderstood. I'm not sure if it actually affects anything (since the < comparison should work either way), but it might if they were mismatched (some ISO, some MW) (but I don't think it can be if I understood you right) [21:03:32] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Use UTC and ISO 8601 everywhere on frontend - https://phabricator.wikimedia.org/T141164#2500188 (10Mattflaschen-WMF) I think that's it after that. [21:07:38] 10Notifications, 07Documentation: Create a glossary about Notifications - https://phabricator.wikimedia.org/T141429#2498365 (10Mattflaschen-WMF) Some of these are really terminology in other extensions (e.g. 'description' (Flow), 'volunteer' (Education Program)). To avoid maintaining two definitions for the s... [21:07:50] matt_flaschen, the dates should never be mismatched formats anymore [21:08:11] if they are, it's a bug now. We can safely use < comparison... [21:08:32] etonkovidova, as expected, I don't see the bug on my user in beta [21:08:39] do you have a user where this happens? [21:09:00] mooeypoo: yes. I am sending you a user info via google chat [21:10:31] etonkovidova, gotcha, I see it [21:10:31] wow [21:10:32] (03CR) 10Mattflaschen: "> Thanks for the review. In most cases I decided on having public methods to have them testable." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [21:11:34] mooeypoo: yup. All old users(at least whom I checked) with old messages have this problem [21:13:01] mooeypoo: new demo user with many new messages which I created for jmatazzoni___ is fine. Hopefully it won't break during tomorrow demo :) [21:13:25] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification: bad localization when section name is a magicword - https://phabricator.wikimedia.org/T141460#2500260 (10Mattflaschen-WMF) [21:14:23] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification: Dummy title used when section name is a magicword - https://phabricator.wikimedia.org/T141460#2499545 (10Mattflaschen-WMF) [21:14:24] what the hell [21:14:30] it's asking for 50, but it's only getting 47 [21:14:32] ... [21:15:03] Thanks, addshore. :) [21:15:19] [= [21:18:36] mooeypoo, you have access to run scripts on Beta. Also, I can make you an admin on Beta if you want (or you can do it yourself :) ). [21:18:58] 06Collaboration-Team-Interested, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2500283 (10daniel) @brion @Krinkle do you think you could propose strawman service interfaces to replace Echo hook handlers, for next week's... [21:19:13] (You already had Beta access). [21:21:54] matt_flaschen, really? hmm i need to know how at some point, then [21:22:20] I need to try and figure this bug out, though. I am at a loss. It's like the API just decides it doesn't want to serve the correct nu--- omg someone quack [21:22:34] ... I think I know why this is happening [21:23:18] matt_flaschen, ok you know a lot more about how the list API works... I know stephanebisson worked on hiding deleted notifications from the list -- could it be that they're hidden **after** they're counted from the DB? [21:24:05] as in, client asks for x notifs - API asks for x+1 (for 'continue' value) and then we delete moderated notifications, so now we have x-whatever, which is what is being served to the client [21:25:20] mooeypoo, I meant before the ts patch. Definitely shouldn't be afterwards, but not sure about before (but hopefully before they were both TS_MW). [21:25:21] etonkovidova, can we try something? Can you take the new user that you know this doesn't happen to, and have one of the notifications about some topic be moderated? [21:25:53] mooeypoo, etonkovidova, isn't this related to the moderation stuff stephanebisson is working on? [21:25:56] matt_flaschen, before they should've been also consistent in format unless something was written wrong [21:26:07] matt_flaschen, right, right, I thought that it might be but wasn't it merged? [21:26:15] wasn't it fixed? [21:26:19] I think it might be that. [21:26:32] mooeypoo, yes, just ping me anytime if you want to ssh into Beta. [21:26:39] * mooeypoo nods [21:26:44] awesome thanks [21:27:03] matt_flaschen: mooeypoo: moderation is another problem altogether - unfortunately [21:27:12] etonkovidova, I think it's the same issue [21:27:23] mooeypoo, I recall him saying something about "it works better but there are still some pagination issues", but I don't remember exactly. [21:27:35] (BTW, this whole thing reminds me of the same problem with Flow.) [21:28:44] mooeypoo: well, which one out of three? :) Thanks motifications are not purged after deletion, cross-wiki-notifications counter errors? Or Failed to fetch notifications false warning? :) [21:28:55] O.o [21:29:32] mooeypoo: but you gave me some idea... [21:29:40] etonkovidova, the bug I'm looking at with the pagination -- I have a feeling that if you take a user this doesn't happen to and then moderate some of the topics that relate to the notifications, that user will get the same error [21:30:54] mooeypoo: that's logical, yes - and I can check it from db for users with whom the issue is present [21:31:10] i think that the "missing" notifications in the pagination are the ones that are moderated [21:36:26] 03Collab-Team-2016-Apr-Jun-Q4, 03Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, and 2 others: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2500333 (10Etonkovidova) Checked in betalabs From UI - the 'Thank' notifications are no... [22:48:19] Internet is going down here for hopefully just 5-10 minutes (firmware update). [23:01:31] 06Collaboration-Team-Interested, 10Notifications, 10ArchCom-RfC, 10Librarization, and 2 others: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2500608 (10RobLa-WMF) >>! In T128351#2500149, @brion wrote: > We still have to discuss the 'line' of how much of Echo infrastructure needs t... [23:09:28] mooeypoo, I'm making the CAPTCHA logic a little more complex, so trying to increase code reuse. In dealing with the whole createEditorWidget in Initializer, I'm thinking of adding another widget (captchaWidget) to the hack at https://phabricator.wikimedia.org/rEFLWd3c622439cad191c05e7bdc108cceeed36128d1f . [23:09:39] Feel free to tell me "Really don't do that" and we can discuss alternatives. [23:11:24] Seems like this code is kind of In Theory Temporary and I don't think this makes it much worse. [23:11:52] And at least there will be a little more code reuse. Otherwise, I think we would add something like UndoEditorWidget. [23:13:01] Or I can create the CAPTCHA DM and widget dynamically in the save callbacks, but not sure that's better. [23:20:50] matt_flaschen: Am I missing smth here - how could it be that count(*) for the same user in echo_notification and echo_event can be different? [23:21:35] etonkovidova, can you post the queries? [23:21:43] echo_event does not have a user field. [23:22:21] matt_flaschen: select * from echo_event where event_agent_id=6915 and select * from echo_notification where notification_user=6915 [23:22:46] matt_flaschen: event_agetn_id is not a user who receives notfications? [23:23:40] etonkovidova, no, the agent is the user who sends it. E.g. for mention, the user that posts the comment. [23:25:37] matt_flaschen: so, only echo_notification keeps track of received notifications - ok [23:26:23] etonkovidova, right. There can be multiple recipients in echo_notification for the same event. [23:27:52] matt_flaschen: at least echo_event.event_id is the same as echo_notification.notifciation_event ? [23:29:16] etonkovidova, yes. [23:29:30] matt_flaschen: thx! [23:29:48] etonkovidova, you're welcome. [23:34:26] I have an alternate idea for createEditorWidget, don't know if it's better or worse. [23:41:22] matt_flaschen, sorry, was distracted -- don't we already have a CaptchaWidget? [23:41:41] mooeypoo, yes, I'm trying to use it in initializer. :) [23:42:39] oh [23:42:54] mooeypoo, I actually figured out how to get rid of your hack, fixed a bug, and increased code reuse even more. [23:43:06] mooeypoo, the trick I'm using is to pass an error-handler function to afterSaveContent. [23:43:09] ooh well that sounds like that worked [23:43:34] ooh you can do that? [23:43:48] mooeypoo, I can. I don't know if I may, that depends on code review. [23:47:45] haha [23:49:37] (03CR) 10Mooeypoo: [C: 032] BREAKING CHANGE: Use ISO 8601 for 'ts' in cross-wiki summary. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301489 (https://phabricator.wikimedia.org/T141164) (owner: 10Mattflaschen) [23:58:44] (03Merged) 10jenkins-bot: BREAKING CHANGE: Use ISO 8601 for 'ts' in cross-wiki summary. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301489 (https://phabricator.wikimedia.org/T141164) (owner: 10Mattflaschen)