[08:31:39] 10Notifications, 10Mention-Notification, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-07-14: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2491341 (10Charlie_WMDE) Thanks! I corrected the mistakes. [09:06:03] (03CR) 10WMDE-Fisch: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [11:49:57] (03PS1) 10WMDE-Fisch: Echo notifications for successful mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) [11:53:59] (03CR) 10WMDE-Fisch: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [13:32:34] 10Notifications, 07I18n: Echo's momentjs usage produces incorrect time format in ce - https://phabricator.wikimedia.org/T138363#2491884 (10Anomie) [14:16:16] (03CR) 10Sbisson: [C: 032] Italicize post excerpts inside bundles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/299916 (https://phabricator.wikimedia.org/T139960) (owner: 10Catrope) [14:16:23] (03CR) 10Sbisson: [C: 032] Use body color (gray) for s in bundle headers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300685 (https://phabricator.wikimedia.org/T139960) (owner: 10Catrope) [14:18:08] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: Adjust the styling of excerpts inside bundled notifications - https://phabricator.wikimedia.org/T139960#2492033 (10SBisson) Should the same formatting be applied to `flow[usertalk]-new-topic`? [14:23:14] (03Merged) 10jenkins-bot: Use body color (gray) for s in bundle headers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300685 (https://phabricator.wikimedia.org/T139960) (owner: 10Catrope) [14:24:16] (03Merged) 10jenkins-bot: Italicize post excerpts inside bundles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/299916 (https://phabricator.wikimedia.org/T139960) (owner: 10Catrope) [14:24:37] (03CR) 10Sbisson: [C: 032] Show a warning when leaving a page with unsaved text in an editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [14:32:33] (03Merged) 10jenkins-bot: Show a warning when leaving a page with unsaved text in an editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [14:40:29] (03CR) 10Sbisson: [C: 04-1] "Looks good but the "Preferences" and "Learn more" links don't work." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300687 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [15:21:17] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Make Notification page on mobile usable by suppressing the left, filtering nav (for now) - https://phabricator.wikimedia.org/T140687#2492161 (10jmatazzoni) Thanks @Mooe... [15:29:40] 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Notifications page: remove mw-echo-special-header-link - https://phabricator.wikimedia.org/T141141#2492192 (10jmatazzoni) Thanks for removing preferences. But now the space between the line under the page title and... [16:22:16] (03PS1) 10Sbisson: Special:Notifications (no-js): filter out deleted events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300897 [16:24:24] (03PS1) 10Sbisson: Delete 'flow-thank' on moderated topic/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/300898 (https://phabricator.wikimedia.org/T93673) [16:27:09] (03CR) 10jenkins-bot: [V: 04-1] Delete 'flow-thank' on moderated topic/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/300898 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [16:31:52] stephanebisson: just to let you know - I was testing on Fri https://phabricator.wikimedia.org/T140836 and looking, again, into https://phabricator.wikimedia.org/T140327 [16:32:49] stephanebisson: looks quite decent. The problems with ET11 are specific to the fact that the watched pages were deleted and recreated as Flow pages and vice versa [16:34:34] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/300898 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [16:35:23] stephanebisson: oops - I meant I was testing https://phabricator.wikimedia.org/T93673 - Moderate actions. When you have a min - pls read test results there. May be there should be some follow ups... [16:35:57] stephanebisson: sorry again - just saw your patch :) [16:36:00] etonkovidova: I read it. Will respond on the ticket [16:36:49] stephanebisson: thx! I did not see your Thank patch when I looked at the ticket in the morning :( Will do more testing today [16:37:18] etonkovidova: I pushed the flow-thank patch just now [16:37:36] stephanebisson: :) great! [16:37:39] etonkovidova: the other problems have the same cause as the problems with the counter going down 1 by 1 [16:39:19] stephanebisson: as I said, for users that had notifications from deleted pages etc, all seems much much milder. The user ET11 has a convoluted history of his watched pages - I was testing re-creating Flow pages with the same names as deleted wikipages and stuff like that [16:39:56] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Reconsider styling of excerpts within bundles in light of fact that they have no close quote - https://phabricator.wikimedia.org/T141034#2492567 (10jmatazzoni) Note that the gray italic message exc... [16:41:33] etonkovidova: the problem with deleted pages is a degenerative bug, it only gets worse over time [16:41:57] stephanebisson: hmm... interesting [16:42:03] etonkovidova: it breaks pagination in some cases, adds overhead that eventually affect performance [16:42:20] stephanebisson: wow [16:42:43] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07I18n, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Months in the notifications should be upper- or lowercase, as appropriate per each language - https://phabricator.wikimedia.org/T141092#2492572 (10jmatazzoni) [16:52:24] 03Collab-Team-2016-Apr-Jun-Q4, 03Collaboration-Team-Archive-2015-2016, 10Flow, 10Notifications, and 2 others: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#2492649 (10SBisson) Moderation of `flow-thank` notifications should be fixed by https://g... [17:12:07] (03Abandoned) 10Mooeypoo: Add QUnit test for marking 'read' and 'seen' notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242738 (owner: 10Mooeypoo) [17:15:26] 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2492822 (10Catrope) [17:15:28] 10Notifications, 10The-Wikipedia-Library: Quarry the number editors effect per month by 500 edits and 6 months notification - https://phabricator.wikimedia.org/T132088#2492820 (10Catrope) 05Open>03declined >>! In T132088#2489485, @Samwalton9 wrote: > @Catrope I guess this can this be marked as resolved the... [17:33:59] Hi everyone. The bell icon for notifications shows "4" but https://meta.wikimedia.org/wiki/Special:Notifications doesn't have any Unread notifications. I'm wondering what that 4 indicates. [17:38:18] Niharika: It's the global notification count. If you click the bell with JS enabled, you should see something like "4 alerts on other wikis" [17:38:39] That said you may have found a bug if there aren't any unread notifications on other wikis either [17:52:24] 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2492979 (10jmatazzoni) @Samwalton9, we should be able to prioritize this for this quarter. Could you get the ball rolling by answering the following... [17:52:57] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07I18n, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Months in the notifications should be upper- or lowercase, as appropriate per each language - https://phabricator.wikimedia.org/T141092#2492981 (10Etonkovidova) Checked in betalabs 1.28.... [17:53:07] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2492982 (10jmatazzoni) [18:04:08] RoanKattouw: I saw "10 alerts on other wikis", then I clicked the ellipsis and clicked "Mark all read" and it still says four. I see all of my other notifications in dark grey, so they are read, I assume. [18:04:15] Hmm [18:04:38] Marking as read cross-wiki sometimes doens't work, especially if you have Privacy Badger installed [18:04:58] If you reload the page, 1) does it still say 4 and 2) if you click that 4, do you still see "4 alerts on other wikis" ? [18:05:02] RoanKattouw: Wait, a refresh worked. [18:05:06] OK [18:05:11] Still weird/broken behavior [18:05:19] But only for a little bit [18:05:26] Yeah. [18:07:42] (03PS2) 10Mooeypoo: Adjust mobile view for the new settings cog menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300687 (https://phabricator.wikimedia.org/T115528) [18:12:42] (03CR) 10jenkins-bot: [V: 04-1] Adjust mobile view for the new settings cog menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300687 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [18:39:17] (03CR) 10Catrope: [C: 032] Delete 'flow-thank' on moderated topic/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/300898 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [18:45:58] (03PS11) 10Mooeypoo: Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) [18:47:25] (03Merged) 10jenkins-bot: Delete 'flow-thank' on moderated topic/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/300898 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [18:48:18] stephanebisson, I'm running into issues with selenium tests :\ they work locally but then fail on gerrit [18:48:37] mooeypoo: classic ;) [18:48:40] hm, I think I have one more idea up my sleeve before I call the big guns in the shape of a stephanebisson [18:49:05] youwant me to rubberduck the issue? [18:49:21] Let's see if I can ducktape it first [18:50:01] (03PS12) 10Mooeypoo: Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) [18:50:21] :\ failed again [18:51:02] stephanebisson, ok, here's the issue -- the new badges use a semi-dirty trick to appear. We have to have them in the format 11 from the nojs but then the css reorganizes them using ::before and ::after [18:51:34] ::before is the icon and the ::after is the number. BUT since we have the number in the 11 already, I went and cheated -- I made the link visibility:none; and the ::before and ::after visibility:visible [18:52:02] *visibility:hidden; [18:52:08] so we still get the number for whatever (print, external 3rd party themes, whatever) but it doesn't show on proper rendering of the screen [18:52:10] right, sorry, yes [18:52:21] anyways, so now selenium is trying to click the badge link, but says it's invisible [18:52:21] mooeypoo: I wonder if you couldn't cheat and make the text the same color as the background or something crazy like that [18:52:23] which is correct [18:52:37] Or... wait the background may be an image in this case :( [18:52:38] so I tried to replace the definition of the "badge" in the test from the link, to the ::before [18:52:45] ... and it still fails [18:53:05] I can't trust the ::after because when we have 0 notifications, ::after is also visibility: hidden [18:53:08] * mooeypoo sighs [18:53:30] RoanKattouw, problem with that is that then it's not clickable [18:53:39] (03CR) 10jenkins-bot: [V: 04-1] Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [18:53:46] the magic with ::before and ::after is that you can make them be actual elements, which are then clickable like the link [18:53:49] mooeypoo: so it failed to locate 'a::before'? [18:54:02] stephanebisson, it fails on "element is not visible" [18:54:11] https://integration.wikimedia.org/ci/job/mwext-mw-selenium/8463/console [18:54:30] stephanebisson, I changed the definition of the badge to link(:badge, css: '.mw-echo-notifications-badge::before') [18:54:44] mooeypoo: initially, there is no 'a::before' when the page loads, make sure you have the proper wait [18:54:52] oh [18:54:53] ooh [18:55:31] mooeypoo: after that, can it access pseudo-elements at all? I don't know [18:55:56] stephanebisson, it should :\ [18:59:03] stephanebisson, We have checks for not_visible, I'm not sure I remember how to wait for the element to be visible [18:59:35] "when_present" ? [18:59:59] mooeypoo: when_present should work [19:00:34] stephanebisson, now my tests are failing on Incorrect or missing CAPTCHA. (MediawikiApi::CreateAccountError) for "Given I am logged in" >.< [19:00:49] it was before, too, I think. Meh. What am I missing. [19:00:49] otherwise: page.wait_until { page.element.visible? } [19:01:08] mooeypoo: disable the 'confirmedit' role [19:02:26] stephanebisson, ok, reprovisioning now [19:23:57] (03CR) 10Catrope: [C: 032] Special:Notifications (no-js): filter out deleted events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300897 (owner: 10Sbisson) [19:24:32] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Figure out Flow's use of OutputPage::buildCssLinks() - https://phabricator.wikimedia.org/T140472#2493448 (10Mattflaschen-WMF) To reproduce the current state: 1. Set up Flow and ConfirmEdit, with ConfirmEdit configured to use FancyCaptcha (or you can do the "current stat... [19:27:34] (03PS3) 10Mattflaschen: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 [19:28:59] (03CR) 10Catrope: [C: 04-1] "-1 per Moriel's comment on PS2. Looks good otherwise. Not going to merge until after the cut because it's a BREAKING CHANGE." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (owner: 10Mattflaschen) [19:30:56] (03PS3) 10Mooeypoo: Adjust mobile view for the new settings cog menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300687 (https://phabricator.wikimedia.org/T115528) [19:31:41] (03Merged) 10jenkins-bot: Special:Notifications (no-js): filter out deleted events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300897 (owner: 10Sbisson) [19:53:14] (03PS1) 10Sbisson: Browser tests: update local url [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300941 [19:55:53] (03PS13) 10Mooeypoo: Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) [19:56:21] stephanebisson, still having issus with "Incorrect or missing CAPTCHA. (MediawikiApi::CreateAccountError)" even though I removed confirmedit role [19:56:30] but let's see if this passes jenkins' tests [19:57:03] mooeypoo: yeah, confirmedit is actually included in wikimediaflow, I had to comment it out to run the browser tests [19:57:25] * mooeypoo is staring at Zuul status page [19:57:48] why is it called Zuul? [19:57:56] It is not Dana. [19:58:04] bah, it failed again [19:58:48] stephanebisson, "unable to locate element, using {:css=>".mw-echo-notifications-badge::before", :tag_name=>"a"} (Watir::Exception::UnknownObjectException)" [19:58:49] :\ [19:59:12] https://integration.wikimedia.org/ci/job/mwext-mw-selenium/8469/console [19:59:21] stephanebisson, wait, why is it running "refresh_until" O.o [19:59:32] mooeypoo: you should remove confirmedit from wikimediaflow (puppet/modules/role/manifests/wikimediaflow.pp:10), otherwise the feedback loop is just too long to fix it [20:00:34] (03CR) 10jenkins-bot: [V: 04-1] Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [20:01:02] mooeypoo: badge_element.when_present [20:01:20] oh shoot, that's right [20:01:24] mooeypoo: if 'badge' is a button, calling 'badge' invokes its default action (click) [20:02:46] stephanebisson, yeah, no, good point, I forgot about _element [20:03:11] ok deleted from wikimediaflow... reprovision [20:03:57] (03PS1) 10Sbisson: Paginate even if some events are filtered out [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300951 [20:05:17] (03CR) 10Catrope: Redo the notification badges (0319 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [20:05:32] (03CR) 10Catrope: [C: 04-1] "Comments on PS12" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [20:06:38] (03CR) 10Catrope: [C: 032] Adjust mobile view for the new settings cog menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300687 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [20:07:49] stephanebisson: Do you believe https://phabricator.wikimedia.org/T139696 could be fixed by https://gerrit.wikimedia.org/r/300951 or is there more going on? [20:08:52] RoanKattouw: I think that's it [20:09:01] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Clean up how ConfirmEdit tracks modules associated with CAPTCHA - https://phabricator.wikimedia.org/T141300#2493645 (10Mattflaschen-WMF) [20:09:09] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension): Clean up how ConfirmEdit tracks modules associated with CAPTCHA - https://phabricator.wikimedia.org/T141300#2493661 (10Mattflaschen-WMF) [20:09:20] So if the 50th/100th/whatever notification can't render, it just stops paginating there? [20:09:22] RoanKattouw: but the patch is a quick fix and leave the numbers in pagination a bit weird [20:09:34] RoanKattouw: pretty much [20:11:20] With this patch, if the first page only has 10 visible notifications, it will show '10 notifications' but the second page will appear as 'notifications 51-100' [20:11:42] similar error in nojs [20:12:40] (03Merged) 10jenkins-bot: Adjust mobile view for the new settings cog menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300687 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [20:12:53] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Figure out Flow's use of OutputPage::buildCssLinks() - https://phabricator.wikimedia.org/T140472#2493674 (10Krinkle) As shown by @Mattflaschen-WMF, `SpamFilter::validate()` is used when saving content through the API. E.g. when creating a new topic. This is essentially... [20:13:13] stephanebisson, on Beta Cluster, I see both "Start a new topic" even after loading finishes, with JS enabled: http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow [20:14:00] Yup I see that too [20:14:13] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Flow not warning me when I leave an edit page with unsaved changes - https://phabricator.wikimedia.org/T96531#2493681 (10Etonkovidova) Checked in betalabs (1.28.0-alpha (a3f4508) the cases that were mentioned on the ticket A user types some text as a... [20:17:05] It was resolved and verified by Elena last Tuesday (T135619) [20:17:06] T135619: Flow board shows no-js "new topic" form while loading - https://phabricator.wikimedia.org/T135619 [20:17:11] how come it came back? [20:20:15] (03CR) 10Mattflaschen: [C: 04-1] "This is not ready to merge." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (owner: 10Mattflaschen) [20:21:15] stephanebisson, I don't know. It's different from before, though. Before it was only wrong while loading. [20:22:18] (03PS4) 10Mattflaschen: WIP: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 [20:22:36] mooeypoo, how urgent is the seen time stuff? It's not broken now (although https://gerrit.wikimedia.org/r/#/c/300596/ is not done), AFAICT. [20:22:56] mooeypoo, I ask because Krinkle really wants us (i.e. me) to work on T140472 and related stuff. [20:22:56] T140472: Figure out Flow's use of OutputPage::buildCssLinks() - https://phabricator.wikimedia.org/T140472 [20:22:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Flow not warning me when I leave an edit page with unsaved changes - https://phabricator.wikimedia.org/T96531#2493728 (10Catrope) >>! In T96531#2493681, @Etonkovidova wrote: > **Chrome only** (Version 50.0.2661.) displays reduced text. FF and Safari... [20:23:11] Hmm, I see that on beta but not locally [20:24:57] $('.flow-action-view') returns something locally but nothing on bet [20:25:02] I wonder if an MW core change broke that [20:25:08] matt_flaschen, not sure? RoanKattouw / jmatazzoni___ could say. I can also pick up where you left off if it's urgent and you have no time [20:26:34] matt_flaschen: Not urgent IMO except for one thing (cross-wiki seen time). But I'll do that myself, you work on unblocking Krinkle, that requires more expertise and focus and time [20:27:15] * mooeypoo roars [20:27:23] stephanebisson, so you know how "element not found" etc etc? [20:27:48] it would be nice if, when selenium looked for the element to click, it knew that #pt-notifications-message is actually now #pt-notifications-notice [20:28:05] RoanKattouw, mooeypoo, okay, I'll put up my WIP. [20:28:05] That may -- no promises, may -- have done that. [20:28:35] mooeypoo: yeah, it could have paid attention those last few days/weeks... it would know for sure [20:29:14] stephanebisson, I'm just wondering how it didn't **fail** before [20:29:28] also we have a ton of "if I add a talk page message it appears in message badge" tests which should be wrong now [20:30:01] mooeypoo: they must be disable, do they have @skip? [20:31:30] Obviously,the 'click on badge notices' is not skipped and should've failed i think [20:31:36] hang on, I'm trying to figure out where exactly it fails now [20:31:41] (03PS1) 10Catrope: Follow-up 782bbdf: don't show "are you sure you want to leave?" dialogs with "false" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/300993 (https://phabricator.wikimedia.org/T96531) [20:31:57] stephanebisson: Can I get a quick CR/merge? ---^^ [20:32:10] RoanKattouw: sure [20:33:25] (03PS5) 10Mattflaschen: WIP: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 [20:35:46] (03CR) 10Catrope: [C: 032] Paginate even if some events are filtered out [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300951 (owner: 10Sbisson) [20:36:39] (03CR) 10Sbisson: [C: 032] Follow-up 782bbdf: don't show "are you sure you want to leave?" dialogs with "false" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/300993 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [20:36:42] (03CR) 10jenkins-bot: [V: 04-1] WIP: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (owner: 10Mattflaschen) [20:36:47] meh, running tests again [20:38:37] Now the double "Start a new topic" is gone again?? [20:39:04] wtf [20:39:12] did someone collapsed the wave function by accident? [20:39:26] haha [20:39:33] I'll look at the MW core git history [20:39:45] For some reason flow-action-view wasn't added to the classes of flow-component [20:40:32] Hmm nothing stands out. Very strange [20:40:45] but nothing in Flow/.../View.php gives any clue [20:43:26] (03Merged) 10jenkins-bot: Paginate even if some events are filtered out [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300951 (owner: 10Sbisson) [20:44:55] (03Merged) 10jenkins-bot: Follow-up 782bbdf: don't show "are you sure you want to leave?" dialogs with "false" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/300993 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [20:45:06] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Special:Notifications not showing all my notifications in production - https://phabricator.wikimedia.org/T139696#2493793 (10SBisson) This should be [partially] fixed by https://gerrit.wikimedia.org/r/#/c/300951/ It should give access to all non-deleted notifica... [21:03:44] matt_flaschen, ping triage meeting :) [21:04:41] quiddity, thanks, sorry. [21:06:40] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 07Regression: [betalabs-Regression] FF only Special:Notifications: to match space between weekday label and date - https://phabricator.wikimedia.org/T141168#2493852 (10Quiddity) [21:17:53] stephanebisson, I am waving the white flag of shame [21:18:19] I have no idea what else to try; I renamed all 'message' to 'notice' and changed the expected badge from message to notice in 'when someone mentions me' [21:18:55] and it's STILL having issues with seeing elements [21:19:25] mooeypoo: I'll take a look (nd try to run) your badge patch a bit later, I have to go now [21:19:50] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: [betalabs-Regression] cross-wiki bundle displays only wiki names - no notifications - https://phabricator.wikimedia.org/T140836#2493900 (10Quiddity) [21:20:05] * mooeypoo nods [21:20:22] I'm still trying to wrangle it, hopefully I'll solve it but if not, I'll update the patch for your rubberducking and testing [21:23:54] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 07Regression: [betalabs-Regression] FF only Special:Notifications: to match space between weekday label and date - https://phabricator.wikimedia.org/T141168#2493912 (10Catrope) 05Open>03declined This is a browser bug in Firefox. The width of t... [21:24:46] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension): Clean up how ConfirmEdit tracks modules associated with CAPTCHA - https://phabricator.wikimedia.org/T141300#2493917 (10Florian) It's maybe a good idea to change the registration of modules, removing the OutputPage completely (or the context its... [21:25:29] (03PS14) 10Mooeypoo: Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) [21:29:30] matt_flaschen, you want me to pick up your work? So far I reviewed and it looks good, just missing a few things [21:29:34] doesn't seem to have a lot missing [21:30:23] (03CR) 10jenkins-bot: [V: 04-1] Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [21:30:36] mooeypoo, it still needs the special page stuff and auditiing to make sure the whole notification side is write, and rendering in local time. [21:30:58] 06Collaboration-Team-Interested, 10Notifications: False-positive mention notification sent - https://phabricator.wikimedia.org/T137755#2493927 (10Quiddity) One more example from Redrose64: > Inconsistency - one fail, one success, little difference > [[https://en.wikipedia.org/w/index.php?title=Template_talk:Di... [21:31:08] * mooeypoo nods [21:31:16] mooeypoo, I would say, pick it up if it's blocking RoanKattouw's cross-wiki seen. If we he wants to do that with current state (MW timestamps), then I can finish my part later. [21:31:28] * mooeypoo nods [21:31:31] s/is write/is right/ [21:31:49] I also don't want us to start getting too confused with seen time fixes [21:32:51] RoanKattouw, given the badges are failing browser tests I am at a loss with and stephane said he'd help me out when he gets back, is there anything I should do or should I pick up matt_flaschen's work on seen time in sources ? [21:34:06] Pick up Matt's work [21:34:25] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Make Notification page on mobile usable by suppressing the left, filtering nav (for now) - https://phabricator.wikimedia.org/T140687#2493937 (10Mooeypoo) Those were fix... [21:34:34] And if you have time, also do https://phabricator.wikimedia.org/T134855#2471979 [21:34:51] 06Collaboration-Team-Interested, 10Notifications: False-positive mention notifications and other anomalies - https://phabricator.wikimedia.org/T137755#2493939 (10Quiddity) [21:34:54] ( mooeypoo ) [21:34:57] RoanKattouw, oki doki [21:35:05] Okay [21:35:11] * mooeypoo has seen [21:35:15] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2493940 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03None [21:35:36] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Use UTC and ISO 8601 everywhere - https://phabricator.wikimedia.org/T141164#2493941 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03None [21:36:00] 06Collaboration-Team-Interested, 10Notifications: Mention notifications anomalies - https://phabricator.wikimedia.org/T137755#2377768 (10Quiddity) [21:36:05] mooeypoo, if you could add the Hewiki Mention-problem examples in this task: https://phabricator.wikimedia.org/T137755 [21:36:15] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 07Technical-Debt: Flow should not manually forward metadata from ParserOutput - https://phabricator.wikimedia.org/T140665#2493943 (10Mattflaschen-WMF) [21:41:29] quiddity, so far I got "the diff of my entire talk page" as an example :\ [21:42:25] quiddity, seems to be mention inside Flow, specifically [21:42:43] ahh, might be separate then [21:44:41] quiddity, added anyways [21:44:42] 06Collaboration-Team-Interested, 10Notifications: Mention notifications anomalies - https://phabricator.wikimedia.org/T137755#2493956 (10Mooeypoo) Got another complaint about mentions not working from hewiki. Specifically, in this Flow discussion, there were several mentions and none of them worked: https://he... [21:47:34] 10Flow: Flow: Put 'History' in title of Flow topic's history page - https://phabricator.wikimedia.org/T141012#2493961 (10Mattflaschen-WMF) [21:48:30] matt_flaschen, funnily enough,I'm fairly sure the widget already DID the utc conversion... it has moment.utc( timestampFromModel ) before it goes and does its "hacked" 2-character relative time [21:49:44] mooeypoo, that doesn't seem right, since it's not using utcmw. [21:49:51] matt_flaschen, I know.... [21:49:54] and yet.... [21:49:55] O.o [21:50:12] mooeypoo, some of the wikis do use UTC (which I believe also means the user timezone is also UTC by default). [21:50:15] mooeypoo, *some* of them. [21:50:22] :) [21:50:29] matt_flaschen, according to moment docs, this is the correct way to read a utc timestamp, and to convert it to local time, i should just say a = moment.utc( timestamp ); a.local() [21:50:43] matt_flaschen, I think we may be fixing a bug we didn't notice [21:51:12] We're going to just need to check this very rigorously to make sure the dates make sense [21:51:22] I was planning to check this at 5:01pm :P [21:51:35] If I start getting "tomorrow" then I am using the wrong localized date :D [21:52:27] mooeypoo: etonkovi_ showed me a screenshot of VERY weird behavior on Special:Notifications that only happens at 5pm (ask her to show you the screenshot) [21:52:43] RoanKattouw, ... that... might... explain... things [21:52:53] good news is that if it has anything to do with the timestamps - we're about to fix that [21:53:00] Like, instead of "Today" it shows something insane like 2016-07-25 00:00:00 [21:53:04] mooeypoo: every day at 5:00 I see it [21:53:10] you see what? [21:53:14] "Tomorrow" ? [21:53:41] mooeypoo: utc format for midnight [21:53:48] hm [21:54:06] ok we're sorting out all the timestamps, so hopefully this will fix the weird mismatching formats out there [21:54:10] and the bugs that they cause [21:54:16] mooeypoo, sorry, multi-tasking with triage meeting. [21:54:32] matt_flaschen, no worries, I'm amusing myself with the 'wtf, timestamp' thing [21:55:04] matt_flaschen, also, you're basically almost done with this fix... I fixed up the special page grouping, the item timestamp, and made sure the widget displays right [21:55:33] seems done to me -- now I just need to make sure we **update** and **fetch** seen time properly per source in the special page when we switch pages + in cross wiki in the popup [21:55:41] thinknig of doing that as a dependent commit, to make things simpler [21:57:27] mooeypoo, you did the fallback (the other place we generate a timestamp string client-side)? [21:58:27] dm.NotificationItem ? [22:00:53] matt_flaschen, I just replaced my MW-tmestamp fallback with date = new Date(); fallback = date.toISOString(); [22:01:37] seems to be the correct format [22:01:50] ( new Date() ).toISOString() -> "2016-07-25T22:00:22.079Z" [22:05:44] (03PS6) 10Mooeypoo: WIP: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (owner: 10Mattflaschen) [22:06:48] mooeypoo, no, I looked at that. [22:06:55] It doesn't match the server due to the milliseconds. [22:09:28] (03CR) 10jenkins-bot: [V: 04-1] WIP: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (owner: 10Mattflaschen) [22:13:41] (03CR) 10Mattflaschen: [C: 04-1] "See inline." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (owner: 10Mattflaschen) [22:14:25] (03CR) 10Addshore: [C: 04-1] "Some tiny things before merging" (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [22:18:18] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2494064 (10Samwalton9) @jmatazzoni Awesome! >>! In T132084#2492979, @jmatazzoni wrote: > - Who, exactly, gets t... [22:20:02] 10Flow: Flow transaction implicit transaction warnings - https://phabricator.wikimedia.org/T141172#2489323 (10Mattflaschen-WMF) So this means Flow opening the explicit transaction is implicitly committing the DBO_TRX transaction, right? I think this must be one of the wikis where the Flow tables are in the main... [22:21:38] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 06Discovery, 10Kartographer, and 2 others: is not visible in Flow (blank frame) - https://phabricator.wikimedia.org/T140920#2494081 (10Mattflaschen-WMF) [22:26:01] (03PS1) 10Catrope: Follow-up 782bbdf: unbind beforeunload handler on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301013 (https://phabricator.wikimedia.org/T96531) [22:26:12] mooeypoo: Quick review? ---^^ [22:26:53] addshore: Re https://gerrit.wikimedia.org/r/295351 and friends, please don't merge that right before the wmf branch cut; wait ~24h instead [22:27:16] (I know it's -1ed but you said "Some tiny things before merging", so just making sure you know for when it is ready) [22:27:28] RoanKattouw: will do! :) [22:27:40] well, won't do (merge before the branch cut) ;) [22:28:10] It is all disabled by default too :) [22:29:53] (03CR) 10Mooeypoo: [C: 032] Follow-up 782bbdf: unbind beforeunload handler on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301013 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [22:31:59] addshore, hey, you work on RevisionSlider too, right? I forget. I had a question to ask you guys, if you have a moment it'll save me an email [22:32:03] addshore: Yeah about that actually [22:32:11] mooeypoo: yes! [22:32:28] addshore: I'm commenting in CR but maybe you can shed light on the whole $wg-var-that-must-be-set-BEFORE-loading-the-extension thing. AFAIK that's generally an antipattern [22:32:31] addshore, first off, awesome work, it looks great, and I see the great feedback you're getting! [22:32:59] I was wondering, following up on the bug report you guys got on hewiki regarding the tooltip's location in RTL -- did you consider working with OOUI elements? [22:33:19] ooui popups especially, they're already doing all the clipping and positioning fixes for rtl/ltr and widths and such [22:33:51] I just realized that it could probably save you a lot of work and be consistent with the design in both mediawiki and Apex for UI standardization [22:34:04] RoanKattouw: yes, it's a bit annoying, due to the fact that the preferences for users are created in the main entry point of Echo, perhaps they could be deferred into a hook? [22:34:32] Wait, the prefs are *created* in the main entry point [22:34:33] ? [22:34:41] (Also, $wgHiddenPrefs exists) [22:35:18] mooeypoo: I don't think we looked into tooltips from OOUI! It might be worth filing a bug for it against RevisionSlider and then I am sure we will look at it, and I could mention it at the daily tommorrow [22:36:17] addshore, I'd love to help if you need it; I'll open a task [22:37:00] RoanKattouw: it looks like the only reason it is set before the extension is loaded is so 'mention-failure' is not added to $wgEchoNotificationCategories [22:37:30] Right, but that's only exposed on Special:DisplayNotificationsConfiguration AFAIK [22:37:34] and maybe used to generate preferences? [22:38:00] yeh, it's used to generate preferences I believe! [22:38:35] yes RoanKattouw I guess $wgHiddenPrefs could be used instead then! [22:38:49] Cool [22:39:06] The CR comments that I've already written but not yet published (still reviewing the rest of the change) suggest that too [22:39:07] if we don't mind too much about it appearing on Special:DisplayNotificationsConfiguration [22:39:35] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension): Clean up how ConfirmEdit tracks modules associated with CAPTCHA - https://phabricator.wikimedia.org/T141300#2494139 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [22:40:32] addshore, https://phabricator.wikimedia.org/T141316 <-- if you need any assistance or brainstorming, let me know. It's just a general idea, it seemed to me to have good option for the future to save you guys a lot of repetitive work that OOUI already nailed through lots and lots of repetition. [22:41:00] addshore: Yeah I think that'll be fine [22:41:08] mooeypoo: awesome! :) [22:41:19] addshore: Also out of curiosity what's your use case for disabling this on a wiki-wide basis? (Assuming it'll be opt-in even when enabled) [22:41:39] Practical considerations like "we can merge the code and have it not be perfect yet" or something deeper? [22:41:39] RoanKattouw: I'll let you save your comments and mention them in our daily tomorrow too :) [22:42:17] Yes, thats one consideration, wanting to be able to merge the failure & success notifications before turning it on at all [22:42:36] and also being able to turn it on for testwiki only for a period before rolling it out elsewhere [22:43:04] OK that makes sense [22:43:12] stephanebisson, not that I was waiting impatiently to jump on you for help or anything, but... help me, oh browser-test-guru (when you have time) https://gerrit.wikimedia.org/r/#/c/299910/ [22:43:57] 03Collab-Team-Q1-July-Sep-2016, 10ConfirmEdit (CAPTCHA extension): Clean up how ConfirmEdit tracks modules associated with CAPTCHA - https://phabricator.wikimedia.org/T141300#2494183 (10Mattflaschen-WMF) >>! In T141300#2493917, @Florian wrote: > So we should probably just change the return value of getForm to... [22:44:05] mooeypoo: I'm looking at it... [22:44:30] stephanebisson, and if it magically doesn't fail just because you looked at it, feel free to quack. [22:44:34] Though I doubt it will. [22:45:42] mooeypoo: https://gerrit.wikimedia.org/r/#/c/300941/ please [22:46:42] ooh [22:47:04] (03CR) 10Mooeypoo: [C: 032] Browser tests: update local url [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300941 (owner: 10Sbisson) [22:47:11] (03CR) 10Legoktm: [C: 032] Follow-up 782bbdf: unbind beforeunload handler on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301013 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [22:47:17] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis: [REQUEST] - https://phabricator.wikimedia.org/T141319#2494190 (10jmatazzoni) [22:47:28] (03CR) 10Catrope: [C: 04-1] "Some minor comments inline, code looks OK otherwise" (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [22:47:47] Thanks legoktm [22:48:20] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 06Editing-Analysis: [REQUEST] Which RecentChanges filters are used? - https://phabricator.wikimedia.org/T141319#2494205 (10Catrope) [22:48:42] RoanKattouw: I only re+2'd it because I had to restart zuul [22:49:00] Oh right I see [22:49:02] Thanks mooeypoo then :) [22:49:31] (03CR) 10Legoktm: [C: 032] Browser tests: update local url [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300941 (owner: 10Sbisson) [22:50:12] what? who? what? [22:50:44] Who am I saying "you're welcome" ? [22:54:32] (03CR) 10Catrope: Echo notifications for mention failures (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [22:55:03] (03Merged) 10jenkins-bot: Browser tests: update local url [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300941 (owner: 10Sbisson) [22:55:08] (03Merged) 10jenkins-bot: Follow-up 782bbdf: unbind beforeunload handler on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301013 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [22:59:27] mooeypoo: $('.mw-echo-unseen-notifications::after') doesn't return anything for me in Chrome [22:59:35] mooeypoo: does it for you? [22:59:58] stephanebisson, I'm in the middle of another fix, give me a second to fetch the badge on [22:59:58] one [23:02:35] stephanebisson: It won't, :before is a pseudo-element [23:03:32] (03PS17) 10WMDE-Fisch: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) [23:03:48] (03PS1) 10Mooeypoo: [wip] Update and fetch seenTime per source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 [23:04:37] RoanKattouw, css selects it this way! [23:04:46] Yes, because it's a pseudo-element [23:04:50] Like ::first-letter for example [23:04:56] RoanKattouw, stephanebisson well, if we can't select that pseudo-element, we're fairly screwed :\ [23:05:02] There's no sensible return value for $('.foobar::first-letter') [23:05:36] RoanKattouw, stephanebisson the only "quick" solution I can think of is to make the not visibility:hidden -- but that means NOT outputting the number to the and having an empty element, which we then fill with the ::after object [23:06:24] (03CR) 10jenkins-bot: [V: 04-1] Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [23:06:27] that would make the link clickable to browser tests, but it would mean we're outputting an empty link, which I don't really like for various reasons, among those is that we probably will encounter other issues with this behavior in CSS, and another is that it means that anyone using a 3rd party template will not see the outputted number [23:07:08] I don't think the "third party template" thing is an issue because the :before/:after code should be skin-independent [23:07:26] ... do you not care about printing? [23:07:26] My gut says there might be issues with not including the number in the but I don't know what they are [23:07:28] THE TREES [23:07:40] Think of all the ink you'll save not printing notificatoin numbers [23:07:47] mooeypoo: not sure we need to hack anything [23:07:47] Also hopefully :after still works in print mode [23:07:52] seriously, though, I am a lot meh about outputting that link as empty and letting CSS fill it, but we can if we have to [23:08:04] I am somewhat meh about it, but if it works let's do it [23:08:07] It also simplifies the CSS [23:08:10] (03CR) 10jenkins-bot: [V: 04-1] [wip] Update and fetch seenTime per source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 (owner: 10Mooeypoo) [23:08:27] stephanebisson, if you tell the test to click the link itself, selenium says it's hidden -- and correctly, because visibility:hidden... but then you can't seem to select the pseudo elements who ARE visible, then how can we click it at all? [23:08:28] The fact that we have an that's hidden with a :before and :after overridden to visible is pretty WTF [23:08:31] or see if the number is correct [23:08:40] RoanKattouw, alternative? [23:08:48] Empty as you said [23:08:52] Or... [23:08:57] font-size: 0? :D [23:09:02] empty is meh. a lot me--- nooooooo god. [23:09:04] really? [23:09:10] that's BETTER than a visibility:hidden ? [23:09:12] right,the is hidden [23:09:13] (I'm reminded of this because I saw that as a hack for a completely different problem today) [23:09:42] mooeypoo: Well it's easier to reason about IMO [23:09:42] my first idea was to do a::first-letter { visibility:hidden; } but the number can be 2 letters [23:09:46] browser tests are often highlighting issues that screenreaders also have [23:09:54] but we can try with ::first-line { .. } [23:10:02] and then the a itself is visible but the TEXT is hidden [23:10:04] muaha.. ha? [23:10:14] "What does it mean to have an :after that's not hidden on an element that is hidden" vs "this element has text but the text is in a 0px font so it's not rendered" [23:10:26] Also why bother with ::first-line [23:10:29] stephanebisson, good point on that. Empty (and invisible ) hurt screen readers. [23:10:40] If the font-size: 0 rule affects the before/after, you can override it there agani [23:10:44] if you can about blind people, find a way to output markup that makes sense [23:10:48] *care [23:10:54] Although that would be a bit meh because you have to know the correct font size in non-relative units [23:10:56] RoanKattouw, font-size: 0px will affect all em sizings [23:11:18] stephanebisson, "find a way to output markup that makes sense" tell that to personal tools :( :( [23:11:42] We only recently merged the fix that allows us to add data-* attributes to the SUPER simple that personal tools allows for [23:11:46] it's a nightmare :( [23:23:26] ok I'm using font-size: 0 [23:23:29] running tests again [23:24:06] THEY PASS [23:25:12] (03PS15) 10Mooeypoo: Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) [23:59:16] (03PS2) 10Mooeypoo: [wip] Update and fetch seenTime per source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021