[00:09:52] 10Notifications, 10MediaWiki-API, 10MediaWiki-extensions-OAuth, 10VisualEditor: With some accounts but not others, API throws badsession error on OAuth options update - https://phabricator.wikimedia.org/T140006#2449675 (10Mattflaschen-WMF) If this was caused by Echo, it should be resolved now by {8dce65d48... [00:14:38] 10Collab-Notifications-Page, 10UI-Standardization: [minor] Notification page - usage of bold font - https://phabricator.wikimedia.org/T140962#2482579 (10Etonkovidova) [00:17:30] 10Notifications: ForeignWikiRequest and getFromForeign will fail if OAuth is in use - https://phabricator.wikimedia.org/T140963#2482593 (10Mattflaschen-WMF) [00:17:55] 06Collaboration-Team-Interested, 10MediaWiki-extensions-CentralAuth: "Can only obtain a centralauthtoken when using CentralAuth sessions" during auto-creation - https://phabricator.wikimedia.org/T140127#2482606 (10Mattflaschen-WMF) >>! In T140127#2454269, @Anomie wrote: > You also can't use API action=centrala... [00:18:18] 10Notifications: ForeignWikiRequest and getFromForeign will fail if OAuth is in use - https://phabricator.wikimedia.org/T140963#2482593 (10Mattflaschen-WMF) We also need to be careful to avoid (if at all possible) triggering this from hooks, etc. in the future. [00:19:54] 10Notifications: ForeignWikiRequest and getFromForeign will fail if OAuth is in use - https://phabricator.wikimedia.org/T140963#2482609 (10Mattflaschen-WMF) [00:20:31] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Special:Notifications - make the pagination controls sticky - https://phabricator.wikimedia.org/T140964#2482612 (10Etonkovidova) [00:21:49] 10Notifications: ForeignWikiRequest and getFromForeign will fail if OAuth is in use - https://phabricator.wikimedia.org/T140963#2482593 (10Mattflaschen-WMF) [00:22:11] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2103478 (10Etonkovidova) Going for option 2 since the major work is done - Special:Notifications page has working pagination funct... [00:24:53] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 10UI-Standardization: [minor] Notification page - usage of bold font - https://phabricator.wikimedia.org/T140962#2482636 (10Etonkovidova) [00:25:52] (03PS27) 10Mooeypoo: Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [00:28:37] (03CR) 10Mooeypoo: "That's a good point; I added the same behavior to markAllRead and markLocalNotificationsRead. The cross-wiki model actions manage and disc" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [00:35:30] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 10UI-Standardization: [minor] Notification page - usage of bold font - https://phabricator.wikimedia.org/T140962#2482579 (10Volker_E) @Etonkovidova Thanks, good catch! All those tabs and buttons (”Mark as unread“) are normally set bold in our https... [00:41:30] 10Notifications, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, and 5 others: Could not find local user data for {Username}@{wiki} - https://phabricator.wikimedia.org/T119736#2482647 (10Tgr) >>! In T119736#2481988, @Anomie wrote: > I still see a fair... [00:48:09] 10Notifications: ForeignWikiRequest and getFromForeign will fail if OAuth is in use - https://phabricator.wikimedia.org/T140963#2482593 (10Tgr) Also when using bot passwords. [01:00:10] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-19_(1.28.0-wmf.11): Special:Notifications: the filtered 'Unread' page needs to be refreshed after messages were marked as read - https://phabricator.wikimedia.org/T136891#2482654 (10Etonkovidova) Checked in... [01:08:49] (03PS4) 10Catrope: Show a warning when leaving a page with unsaved text in an editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) [01:56:14] (03PS5) 10Catrope: Show a warning when leaving a page with unsaved text in an editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) [01:57:54] (03CR) 10Catrope: [C: 032] Allow requesting TS_ISO_8601 for ApiEchoMarkSeen, and deprecate TS_MW [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300176 (https://phabricator.wikimedia.org/T139993) (owner: 10Mattflaschen) [02:04:09] (03Merged) 10jenkins-bot: Allow requesting TS_ISO_8601 for ApiEchoMarkSeen, and deprecate TS_MW [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300176 (https://phabricator.wikimedia.org/T139993) (owner: 10Mattflaschen) [02:08:25] 10Notifications: ForeignWikiRequest and getFromForeign will fail if OAuth or bot passwords are in use - https://phabricator.wikimedia.org/T140963#2482691 (10Mattflaschen-WMF) [02:08:52] 10Notifications: ForeignWikiRequest and getFromForeign will fail if OAuth or bot passwords are in use - https://phabricator.wikimedia.org/T140963#2482593 (10Mattflaschen-WMF) >>! In T140963#2482650, @Tgr wrote: > Also when using bot passwords. Thanks, added. [02:09:08] (03CR) 10Catrope: "PS5 fixes the bugs Stephane reported and addresses Ed's comment" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [07:08:35] 06Collaboration-Team-Interested, 10Flow: Flow's usage of the page name magic words is different from wikitext talk pages - https://phabricator.wikimedia.org/T109373#1547394 (10Trizek-WMF) [[ https://zh.wikipedia.org/w/index.php?title=Topic:Sqn83udd3ibo0myt&topic_showPostId=t82qwkuv1j731fww#flow-post-t82qwkuv1j... [07:24:46] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2482893 (10Trizek-WMF) [07:25:46] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2471134 (10Trizek-WMF) [07:25:48] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, and 2 others: Change 'messages' to 'notices' internally (method names and such) - https://phabricator.wikimedia.org/T139682#2482894 (10Trizek-WMF) [07:31:42] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07User-notice: Change bubble speech icon to tray icon - https://phabricator.wikimedia.org/T140900#2482903 (10matej_suchanek) [07:49:34] 10Notifications, 10Mention-Notification, 06TCB-Team, 07German-Community-Wishlist, and 3 others: Send notification for easy-to-find failed mentions - https://phabricator.wikimedia.org/T136326#2330698 (10Trizek-WMF) What are the next plans for that task? Is it ready to announce? What will be the impact for u... [07:54:30] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07User-notice: Change bubble speech icon to tray icon - https://phabricator.wikimedia.org/T140900#2482921 (10Trizek-WMF) [08:07:03] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 07User-notice: Make Notification page on mobile usable by suppressing the left, filtering nav (for now) - https://phabricator.wikimedia.org/T140687#2482925 (10Trizek-WMF) [08:11:01] (03CR) 10WMDE-leszek: [V: 031] "Looks good to me now. Only question I'd like to be answered is the name of the "feature switch" global variable for failure notification." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [08:11:12] (03CR) 10WMDE-leszek: Echo notifications for mention failures (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [08:12:06] (03CR) 10WMDE-leszek: [C: 031] Add .idea/ folder to gitignore [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300060 (owner: 10WMDE-Fisch) [08:17:23] 10Notifications, 10Mention-Notification, 06TCB-Team, 07Epic, 07German-Community-Wishlist: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2482946 (10Charlie_WMDE) [09:03:12] (03CR) 10Matěj Suchánek: "I promise this is the last one, no more comments from me on this patch" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [09:26:27] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2483077 (10Trizek-WMF) [09:39:42] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, 07User-notice: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2483112 (10Trizek-WMF) [09:39:44] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name) - https://phabricator.wikimedia.org/T139520#2483108 (10Trizek-WMF) 05Resolved>03Open Apparently, the too... [09:45:55] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2483126 (10Trizek-WMF) [09:52:18] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2483134 (10Trizek-WMF) [10:19:03] (03PS26) 10WMDE-Fisch: Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [10:19:06] (03PS9) 10WMDE-Fisch: WIP Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) [10:20:28] (03CR) 10WMDE-Fisch: WIP Add mention failure notification for multiple section edits (0315 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [10:20:42] (03CR) 10WMDE-Fisch: WIP Add mention failure notification for multiple section edits (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [10:21:50] (03PS10) 10WMDE-Fisch: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) [10:23:01] (03CR) 10WMDE-Fisch: "PS9: Did forget to amend changes -.-" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [10:25:55] (03CR) 10jenkins-bot: [V: 04-1] Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [10:29:01] (03PS27) 10WMDE-Fisch: Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [10:29:35] (03CR) 10WMDE-Fisch: Echo notifications for mention failures (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [10:30:16] (03CR) 10WMDE-Fisch: "@Matěj no worries as long is the number of patches does not go over 9000 ;-)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [10:32:34] (03CR) 10jenkins-bot: [V: 04-1] Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [10:34:21] (03PS11) 10WMDE-Fisch: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) [10:34:57] (03CR) 10WMDE-leszek: Echo notifications for mention failures (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [10:43:36] (03PS28) 10WMDE-Fisch: Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [10:43:57] (03CR) 10WMDE-Fisch: Echo notifications for mention failures (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [10:48:49] (03CR) 10WMDE-leszek: [C: 031 V: 031] "Looks good to me now" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [11:27:16] (03PS12) 10WMDE-Fisch: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) [11:30:22] (03CR) 10WMDE-Fisch: "PS12 is a manual rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [13:53:48] (03PS1) 10Sbisson: Exclude deleted event from UnreadNotificationPages API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300273 [13:54:32] 10Flow, 10UI-Standardization, 07Design, 07RfC: Review unsubscribe/unwatch icon - https://phabricator.wikimedia.org/T134752#2483367 (10Volker_E) As laid out at https://phabricator.wikimedia.org/T132975#2433018 we > we can start by using the empty star icon for this action (the icon named "Star" in the rep... [13:54:45] (03CR) 10Sbisson: [C: 032] Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [13:55:11] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2483370 (10Volker_E) [13:55:13] 10Flow, 10UI-Standardization, 07Design, 07RfC: Review unsubscribe/unwatch icon - https://phabricator.wikimedia.org/T134752#2483369 (10Volker_E) 05Open>03Resolved [13:55:57] (03CR) 10Sbisson: [C: 032] Add .idea/ folder to gitignore [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300060 (owner: 10WMDE-Fisch) [13:56:43] 10Notifications, 10Mention-Notification, 06TCB-Team, 07Epic, 07German-Community-Wishlist: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2308308 (10Charlie_WMDE) {F4294520} [14:04:42] (03Merged) 10jenkins-bot: Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [14:04:45] (03Merged) 10jenkins-bot: Add .idea/ folder to gitignore [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300060 (owner: 10WMDE-Fisch) [14:10:41] (03PS2) 10Sbisson: Exclude deleted events from UnreadNotificationPages API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300273 [14:18:00] 10Notifications, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, and 5 others: Could not find local user data for {Username}@{wiki} - https://phabricator.wikimedia.org/T119736#2483416 (10Anomie) >>! In T119736#2482647, @Tgr wrote: >>>! In T119736#24819... [16:26:14] (03PS1) 10Sbisson: Documentation for EventPresentationModel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300305 [16:50:05] (03CR) 10Sbisson: [C: 032] "self+2: documentation only" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300305 (owner: 10Sbisson) [16:53:50] (03PS1) 10Sbisson: Cleanup old notification config [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/300312 (https://phabricator.wikimedia.org/T121612) [16:56:13] (03CR) 10jenkins-bot: [V: 04-1] Documentation for EventPresentationModel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300305 (owner: 10Sbisson) [16:57:10] (03CR) 10Sbisson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300305 (owner: 10Sbisson) [16:59:46] 06Collaboration-Team-Interested, 10Notifications, 07Community-Wishlist-Survey: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#2484058 (10Quiddity) [16:59:51] 06Collaboration-Team-Interested, 10Notifications, 07Community-Wishlist-Survey: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#1020255 (10Quiddity) [17:01:19] 06Collaboration-Team-Interested, 10Notifications, 07Community-Wishlist-Survey: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#1020255 (10Quiddity) (Apologies for merging older-into-newer. There are many more comments in this task, hence I went the non-standard route, b... [17:08:07] (03CR) 10jenkins-bot: [V: 04-1] Cleanup old notification config [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/300312 (https://phabricator.wikimedia.org/T121612) (owner: 10Sbisson) [17:17:09] 10Flow: Flow: Historic subject's page title - https://phabricator.wikimedia.org/T141012#2484265 (10Framawiki) [17:35:29] (03Merged) 10jenkins-bot: Documentation for EventPresentationModel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300305 (owner: 10Sbisson) [17:35:38] (03Merged) 10jenkins-bot: Cleanup old notification config [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/300312 (https://phabricator.wikimedia.org/T121612) (owner: 10Sbisson) [17:42:43] matt_flaschen, https://gerrit.wikimedia.org/r/#/c/300170/ [17:43:53] mooeypoo, will review today. That's cool, I didn't know/forgot you could do that. [17:43:59] (The attribute CSS thing) [17:44:24] matt_flaschen, I just spotted a typo in the documentation, so I'm fixing that -- but other than that, it is ready for review [17:44:35] yeah, it will make things at laest a little easier [17:45:14] honestly, I think we should allow for any tag in there - whoever's adding something to the toolbar is doing it from the back end anyways, and as RoanKattouw pointed out, you can do damage from there if you really want to without having that restriction in place [17:45:30] and this restriction is making things a huge pain :\ [17:45:37] but we can *start* with data attributes [17:45:40] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10MediaWiki-Redirects, 06Operations, and 2 others: Flow notification links on mobile point to desktop - https://phabricator.wikimedia.org/T107108#2484432 (10jmatazzoni) [17:48:00] matt_flaschen, updated. [17:48:34] matt_flaschen, also, the way I **use** those attributes is pretty nifty too. You can see in the new WIP for the badges -- I have a ::after element with content: attr( data-counter ) [17:49:16] https://gerrit.wikimedia.org/r/#/c/299910/4/modules/nojs/mw.echo.badge.less #52 [17:52:02] mooeypoo, yeah, that's the part I meant was cool. [17:54:30] matt_flaschen, there's also a thing in css where you can name strings (string-set: foo) and then call on them (content: string( foo, first ) ) [17:54:45] this would've been amazing, since it references the content of a node, so we wouldn't even need to use data attributes [17:54:57] ... but it's only used for pagination, which means it's only for **print** [17:55:01] :( [17:55:20] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Special:Notifications - make the pagination controls sticky - https://phabricator.wikimedia.org/T140964#2484504 (10jmatazzoni) [17:56:00] ok matt_flaschen when we changed 'message' to 'notice', am I dreaming here? Did we not change the name of the pt-notification-message to pt-notification-notice so that the auto-generated i18n message changes too? [17:56:10] 'cause if we did, it's not there now, and I'm super confused. [17:56:41] mooeypoo, you both changed it, and made a new message. [17:57:03] mooeypoo, https://gerrit.wikimedia.org/r/#/c/297932/ [17:57:45] I still see it there in i18n right. [17:58:01] wow i reverted it [17:58:05] i am so confused [17:58:15] https://gerrit.wikimedia.org/r/#/c/297932/ [17:58:56] meh not that... ok, this is confusing as hell. [17:59:07] we **really** need to change the entire code to conform so these things don't happen [18:10:19] mooeypoo, I'm confused on a couple things too: [18:10:25] 1. What email from Trizek are you talking about? [18:10:33] 2. Can you reproduce the bug yourself, where? [18:10:41] 3. It looks fine in the code (the same as you left it in 297932. [18:10:43] matt_flaschen, I can, and I think I know what happened [18:11:44] matt_flaschen, I originally changed the message by creating a new message, but then realized that changing the message in the back end will mean changing all CSS classes, which was a mess considering we had a really short time to do that, so I didn't -- I reverted the 'notice' message and added the 'message' message back with the "notice" key [18:12:09] that's why if you look through uselang=qqx you can see that the tooltip is using pt-tooltip-notifications-message [18:12:12] rather than -notice [18:12:19] mooeypoo, you added the message key back with notice text. [18:12:22] I'm changing it *now* including CSS and JS changes [18:12:44] matt_flaschen, yeah, but the I realized that if I actually change the key in personal tools, it would also change the ID which would affect all CSS and some JS [18:12:56] so I reverted to use the -message key but with the "Your notices" text [18:13:04] mooeypoo, yeah I understand that part. [18:13:07] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Epic, 07Tracking: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2484615 (10jmatazzoni) [18:13:09] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2484613 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [18:13:35] when I saw Trizek's bug report, I thought there was a bug, but it isn't a bug, it's just confusing as all hell [18:13:38] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): [production] minor: 'Mark as read' cross-wiki alerts displays blank flyout - https://phabricator.wikimedia.org/T132202#2484616 (10jmatazzoni) 05Open>03Resolved [18:13:48] I'm fixing things now, at least. Trying to get at least partial conformity in the code, even if not really everything [18:14:04] I'll start with changing the ID + css and JS from message to notice [18:14:38] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-19_(1.28.0-wmf.11): Special:Notifications: the filtered 'Unread' page needs to be refreshed after messages were marked as read - https://phabricator.wikimedia.org/T136891#2484618 (10jmatazzoni) 05Open>03... [18:14:49] mooeypoo, oh, I see. He thought it was wrong since it was the old key and he was looking at qqq. I thought he was looking at the en. [18:15:32] yup and then I got all confused [18:15:53] mooeypoo, sorry, I was confused on what he was confused about. [18:16:05] Because I didn't actually see the task yet, just heard about through the grapevine. :) [18:16:14] matt_flaschen, it's okay, I then dragged RoanKattouw to a rubberduck session and he was even confused'er [18:20:00] (03PS1) 10Mooeypoo: Change 'pt-notification-message' to 'pt-notification-notice' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300322 [18:20:01] matt_flaschen, ^^ [18:22:12] I want to complain about $msgLink, but technically that is a separate task (so don't worry about it). [18:22:36] matt_flaschen, ha, yeah, we should also change the fact we're **calling** them 'message' in the code + API [18:22:40] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name) - https://phabricator.wikimedia.org/T139520#2484675 (10Etonkovidova) Checked enwiki and mediawiki (and was c... [18:23:51] etonkovidova: I logged in to ca.wp.beta with ET11. I don't know if the counters as correct since I don't know how many notifications that user shoud have but I did see that it failed to load foreign notifications from enwiki. It says it has 28 but when we expand it's just empty. [18:25:00] stephanebisson: exactly - I did not mean to prove with ET11 incorrect count, but just general problems with displaying/fetching [18:25:49] stephanebisson: thx! For me it's quite reproducible with the "type" of users I described in the ticket - users who never visited some wikis [18:26:14] stephanebisson: not with a newly created user. Luckily, I cannot find anything bad in production [18:26:18] etonkovidova: also, everytime I call that url to retrieve foreign notifs from enwiki, the "count" in the response goes down, that's telling [18:26:35] stephanebisson: EXACTLY :( [18:27:01] (03PS5) 10Mooeypoo: [wip] Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) [18:28:02] stephanebisson: I got an impression that it's for # of msgs >25. Quite few manifestations of something - that's why I called it the Hydra [18:28:31] there must be something in the logs [18:28:47] Logs for Beta are at deployment-fluorine. stephanebisson, do you have access there? [18:29:03] let me check... [18:29:11] ssh deployment-fluorine.eqiad.wmflabs [18:30:03] stephanebisson, or https://logstash-beta.wmflabs.org/ [18:30:09] matt_flaschen: yes, I'm in! where should i look? [18:30:14] Though honestly sometimes I find logstash more complicated than just grep. [18:30:17] matt_flaschen: for what to look in there? [18:30:40] In /srv/mw-log/ [18:31:36] matt_flaschen: yes, grep is easier than logstash stuff [18:31:37] Particularly exception.log , hhvm.log , Echo.log (doesn't seem to exist, maybe no events since rotation?) [18:31:51] And the /srv/mw-log/archive equivalents. [18:31:59] (03CR) 10jenkins-bot: [V: 04-1] [wip] Redo the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [18:32:08] You can use zgrep to grep through the archive (zgrep also works for non-compressed, so you can use the same command for everything) [18:32:39] matt_flaschen: know that :) Just do not know what to grep ... [18:32:45] Was talking to stephanebisson too. [18:33:03] matt_flaschen: :) [18:34:49] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2484694 (10jmatazzoni) [18:34:51] stephanebisson, if you get an exception code (long alpha-numeric string I think in square brackets) from the response, you can grep for that in the exception.log [18:34:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2484692 (10jmatazzoni) 05Open>03Resolved OK, thanks Stephane. Closing this. But I will open a separate ticket to con... [18:36:13] (03CR) 10Mattflaschen: [C: 032] "-1. Should be notice-that-message-isn't-notice." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300322 (owner: 10Mooeypoo) [18:37:42] matt_flaschen, stephanebisson: Isn't it /a/mw-log instead of /srv/mw-log ? [18:38:34] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name) - https://phabricator.wikimedia.org/T139520#2484716 (10Mattflaschen-WMF) Related patch (in process of mergin... [18:38:50] RoanKattouw, not anymore. [18:39:19] Never mind, it still is in production, but not deployment-fluorine. [18:40:58] mattflaschen@deployment-fluorine:~$ ls /a/mw-log -lrthd [18:40:59] drwxr-xr-x 3 udp2log udp2log 4.0K Jul 21 17:54 /a/mw-log [18:41:01] mattflaschen@deployment-fluorine:~$ readlink -f /a/mw-log/ [18:41:02] /srv/mw-log [18:41:04] Okay, that's weird, but whatever. [18:42:58] (03Merged) 10jenkins-bot: Change 'pt-notification-message' to 'pt-notification-notice' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300322 (owner: 10Mooeypoo) [18:44:25] etonkovidova: it looks like ET11 can't get notifications from enwiki, not locally, not from foreign [18:46:13] stephanebisson: yes, it;s kind of worse today. But Alerts are fine [18:46:34] stephanebisson: Special:Notifications page also shows no notifications [18:47:10] etonkovidova: ET11 on en.beta/Special:Notifications, I can't get the messages [18:49:03] stephanebisson: I just checked couple of other users - seems to be ok; what possibly could be special about ET11 as a user? [18:49:30] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Reconsider styling of excerpts within bundles in light of fact that they have no close quote - https://phabricator.wikimedia.org/T141034#2484754 (10jmatazzoni) [18:50:07] etonkovidova: As a user, I don't know. But it is possibe that it had a bunch of notifications associated with pages that have been deleted? [18:50:54] stephanebisson: unlikely, but possible... It'd be interesting to check [18:51:09] stephanebisson, etonkovidova, Since the API request also fails, I think you can use a FauxRequest to debug through in mwrepl on deployment-tin. [18:51:10] stephanebisson: I am still looking into different users [18:52:15] matt_flaschen: what I would like to see is the data in mysql [18:52:46] stephanebisson: sigh, yes it happens to some other users - as it was for several days [18:53:10] stephanebisson: [18:53:11] sql enwiki [18:53:24] on deployment-tin.eqiad.wmflabs [18:53:49] thanks [18:55:28] No problem [18:57:15] echo_event.event_page_id refers to page.page_id ? [18:59:12] etonkovidova: 10 out of 12 notifications for ET11 on enwiki are about flow boards that do not exist [18:59:32] etonkovidova: it makes sense that none would be returned but the counter should also say 0 [19:00:14] stephanebisson: hmm... so select count(*) from echo_notification where notification_user=6710; returning 113 counts something different? [19:00:21] mooeypoo, yay. :) I could enable 'always scrollbars' on OS X without root, so the Safari debugger is actually usable now. [19:00:49] etonkovidova: where notification_read_timestamp IS NULL returns 12 [19:03:06] I think the code that marks the events that cannot be rendered as read can only process 1 per request [19:03:35] so the unread count for that user is slowly going down and showing inconsistent state in the meantime [19:06:49] stephanebisson: it's not a right behavior still :) And I do not think that it explains all phenomenon - cause I see it for other users (quite different) too [19:08:35] stephanebisson: e.g. I am logged as ET11 to enwiki - Notifications page shows "No notifications", the side bar shows 10 for enwiki [19:08:55] stephanebisson: clicking on individual pages in the side bar displays the messages [19:09:28] yep, those 2 other pages give you access to 1 'edit-user-talk' and 1 'flow-mention', right? [19:09:46] stephanebisson: yup [19:09:48] the other 8 events are flow-new-topic for a deleted page [19:10:02] we're down to 8 unread [19:10:11] stephanebisson: should not be counted then [19:10:43] stephanebisson: and yes, I will be checking messages handling for deleted pages (topics) [19:10:53] it's quite hard to not count them but they are supposed to be excluded from the counter the first time we try to fetch them [19:11:30] and that is not happening, or happening very slowly now [19:11:56] I'm trying to reproduce that very situation locally [19:12:07] I'll move to the next problem after that [19:14:54] I wonder if beta uses in-request job running instead of a real job queue? [19:14:57] ( matt_flaschen ) [19:15:46] Don't know [19:17:41] stephanebisson: thx for looking - will be checking other stuff now [19:18:31] if DeferredUpdates::addUpdate( $update ); causes $update to run immediately, that would explain it [19:19:02] the Echo code schedules the job but keeps adding stuff to it while it loops on the events to render [19:27:57] That's weird [19:28:19] I don't think DeferredUpdates run immediately, but adding stuff after scheduling it seems error-prone [19:36:46] stephanebisson: Wait, are these "job" jobs, or DeferredUpdates? [19:36:57] (that you're saying are happening too slowly) [19:37:20] DeferredUpdates, not jobs [19:37:52] Hah, weird [19:38:35] Perhaps you could talk to AaronSchulz about that (in #wikimedia-dev or #wikimedia-perf) [19:38:51] If you've actually found a bug in the deferred update mechanism he'll want to know [19:39:07] yeah, still trying to pinpoint the issue for sure [19:39:41] not happening when I debug so I'm adding logging [20:37:46] Heading out, see you later or tomorrow. [20:52:38] mooeypoo: Fun bug: automatically showing/hiding the "you have new messages" thing when user talk notifs are marked as read/unread is broken, probably because they moved from messages to alerts [20:55:59] * RoanKattouw files [20:56:55] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: "You have new messages" (OBOD) no longer automatically disappears/reappears when user talk notifs marked as read/unread - https://phabricator.wikimedia.org/T141047#2485235 (10Catrope) [20:58:35] (03CR) 10Catrope: [C: 032] "Works fine, but what bothers me is that (on my install at least) I start seeing horizontal scrollbars well before 768px. It seems that wit" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299868 (https://phabricator.wikimedia.org/T140687) (owner: 10Mooeypoo) [21:01:40] (03CR) 10Catrope: "Oh, I see, it's because datedSubGroupListWidget also has width: 700px, so the list panel is 700px wide, and the sidebar is an additional 2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299868 (https://phabricator.wikimedia.org/T140687) (owner: 10Mooeypoo) [21:07:59] (03Merged) 10jenkins-bot: Make Special:Notifications responsive [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299868 (https://phabricator.wikimedia.org/T140687) (owner: 10Mooeypoo) [21:26:32] 10Notifications: ForeignWikiRequest and getFromForeign will fail if OAuth or bot passwords are in use - https://phabricator.wikimedia.org/T140963#2485414 (10Tgr) The centralauthtoken API will record a token in the central session data and use that to authenticate requests. The only way to access the central sess... [21:49:51] 10Notifications, 10Mention-Notification, 06TCB-Team, 06WMDE-Analytics-Engineering, 03TCB-Team-Sprint-2016-07-14: Find out if mention notifications are used - https://phabricator.wikimedia.org/T140928#2481352 (10Addshore) For point 1 we will need a script to check record the number of users with the user... [22:15:42] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2485592 (10jmatazzoni) @Mooeypoo, on Beta I see the cog now but I still see the Preferences lin... [22:41:38] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2485692 (10Etonkovidova) Checked in betalabs. All functionality that the cog is supposed to do... [22:42:34] mooeypoo: if you have a sec, can you read my comment #3 on https://phabricator.wikimedia.org/T115528. I need your feedback on [22:43:10] mooeypoo: 1) whether it makes sense to do something about it 2) if we are going to do something and it should be a separate bug [22:43:33] mooeypoo: cause #3 comment is not related to the stuff in the ticket [22:43:55] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2485700 (10Mooeypoo) The design was visible in older mockups, and as we were talking about this... [22:47:43] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2485706 (10Mooeypoo) >>! In T115528#2485692, @Etonkovidova wrote: > {icon exclamation-triangle... [22:50:07] etonkovidova, just answered - I am not sure whether the desired future behavior is that the sidebar should be updated (maybe?) but if so, we should start a new ticket about it, and get it to pau and jmatazzoni___ for consideration. There's a bunch of potential UX challenges if we make the sidebar update itself as it is, so we can't "just" do it without product input. [22:51:12] etonkovidova, for instance, what happens if I go to page X [5] and mark 3 of those notifications as unread -- woudl the number change to 2? What if I marked them all -- would it be 0, or would it vanish? What if I mark as unread a notification that belongs to a page but that page isn't in the sidebar yet? Is it added in? etc etc etc. [22:51:15] mooeypoo: yeah, agree. It should be whole different thing. thx! [22:51:37] mooeypoo: right, right [22:52:15] I do agree it can be confusing, though. [22:52:45] mooeypoo: I am surprised that nobody screams about it yet ;)) [22:53:11] etonkovidova, how many people consistently use the notifications page, I wonder? [22:53:21] I think people aren't yet really using it? [22:53:28] mooeypoo: yup [22:54:08] 06Collaboration-Team-Interested, 06Parsing-Team, 07Epic: CSS and JS for Parsoid parity with PHP HTML - https://phabricator.wikimedia.org/T1216#2485713 (10ggellerman) [23:19:04] (03PS1) 10Mooeypoo: Check for local unread talk notifications in alert popup too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300445 (https://phabricator.wikimedia.org/T141047) [23:19:21] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review: "You have new messages" (OBOD) no longer automatically disappears/reappears when user talk notifs marked as read/unread - https://phabricator.wikimedia.org/T141047#2485849 (10Catrope) a:03Mooeypoo