[00:42:09] 10Flow, 10Wikimedia-Site-requests: Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2469667 (10Liuxinyu970226) Include IP users? [07:41:03] 03Collab-Team-2016-Apr-Jun-Q4, 03Collaboration-Team-Archive-2015-2016, 10Flow, 13Patch-For-Review: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#2469805 (10matthiasmullie) a:05matthiasmullie>03jcrespo [07:55:34] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 06Community-Liaisons (Jul-Sep-2016): Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2469826 (10Trizek-WMF) [08:20:46] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 06Community-Liaisons (Jul-Sep-2016): Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2469846 (10Issimo_15) Yes please, including IP users. [08:34:39] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 06Community-Liaisons (Jul-Sep-2016): Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2469939 (10Trizek-WMF) a:03Catrope Thank you for this request! I'll be ba... [11:28:12] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 06Community-Liaisons (Jul-Sep-2016): Enable Flow on all kab.wikipedia talk pages - https://phabricator.wikimedia.org/T140588#2470211 (10Issimo_15) [12:14:59] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2470328 (10MGChecker) This is really annoying, please fix it as fast as possible! [12:53:49] (03CR) 10Sbisson: [C: 032] Add a SeenTimeModel to handle seenTime in sources [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298105 (owner: 10Mooeypoo) [13:01:38] (03Merged) 10jenkins-bot: Add a SeenTimeModel to handle seenTime in sources [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298105 (owner: 10Mooeypoo) [14:12:05] 03Collab-Team-2016-Apr-Jun-Q4, 03Collaboration-Team-Archive-2015-2016, 10Flow, 10DBA, 13Patch-For-Review: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#2470798 (10jcrespo) [15:07:27] 10Notifications, 10Collaboration-Community-Engagement: Review is "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2471134 (10Trizek-WMF) [15:08:12] 10Notifications, 10Collaboration-Community-Engagement: Review is "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2471148 (10Trizek-WMF) [15:08:14] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name) - https://phabricator.wikimedia.org/T139520#2471147 (10Trizek-WMF) [15:23:57] (03CR) 10Sbisson: [C: 04-1] "Looks good! 2 minor questions inline." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298910 (https://phabricator.wikimedia.org/T136891) (owner: 10Mooeypoo) [15:46:51] 10Notifications, 10Collaboration-Community-Engagement: Review is "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki - https://phabricator.wikimedia.org/T140645#2471269 (10Trizek-WMF) Messages sent to translators. [15:59:31] 10Notifications, 10Mention-Notification, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-07-14: Bundle mention notifications per save - https://phabricator.wikimedia.org/T140224#2471340 (10Lea_WMDE) Warning: Charlie and I hopefully meet tomorrow to discuss further user research insights,... [16:42:18] 10Notifications: It should be like that? - https://phabricator.wikimedia.org/T140580#2469433 (10Etonkovidova) @IKhitron - no it should not. The cross-wiki bundle (when the bundle is not expanded) the timestamp should be the most recent one. Did you mark as read some of the notifications in the cross-wiki bund... [16:50:05] 10Notifications: It should be like that? - https://phabricator.wikimedia.org/T140580#2469433 (10Catrope) I wonder if this might be a bug in the transition flag code, but I'll wait to see if Elena can find reproduction steps for this. [17:13:00] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-19_(1.28.0-wmf.11): Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2471641 (10jmatazzoni) 05Open>03Resolved [17:23:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: In some cases notifications that were marked read, reappear as unread again - https://phabricator.wikimedia.org/T140309#2471717 (10Mooeypoo) 05Open>03stalled Unfortunately, @IKhitron , there's no way for me to trace these things without either reproducing the... [17:23:53] 10Notifications: Timestamp discrepancy for cross-wiki notifications - https://phabricator.wikimedia.org/T140580#2471724 (10Mattflaschen-WMF) [17:33:33] 10Notifications: Timestamp discrepancy for cross-wiki notifications - https://phabricator.wikimedia.org/T140580#2471784 (10IKhitron) I saw on my local wiki two cross-wiki notifications in bundle. Did not pay attention on timestamps. I clicked on the blue dot on one of them. it disappeared, and this is the result. [17:34:40] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: In some cases notifications that were marked read, reappear as unread again - https://phabricator.wikimedia.org/T140309#2471789 (10IKhitron) But, @Mooeypoo, why not? It seems very easy to me, using SQL. [18:03:29] 10Flow, 07Technical-Debt: Flow should not manually forward metadata from ParserOutput - https://phabricator.wikimedia.org/T140665#2471910 (10Krinkle) [18:05:19] 06Collaboration-Team-Interested, 10MediaWiki-extensions-CentralAuth: "Can only obtain a centralauthtoken when using CentralAuth sessions" during auto-creation - https://phabricator.wikimedia.org/T140127#2471922 (10Tgr) For OAuth this approach won't work in general as the client secret would be needed to sign t... [18:10:09] 10Flow, 10Wikimedia-Site-requests: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#2471930 (10MarcoAurelio) The RfC is closed now and the closure result has not been contested for some time. Flow has no use on Meta other than the test page linked above so there should be no major fuss in... [18:10:25] 10Flow, 10Wikimedia-Site-requests: Remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T63729#2471932 (10MarcoAurelio) p:05Triage>03Lowest Triaged. [18:32:24] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2471979 (10Catrope) We discussed this in our team discussion meeting and @Mattflaschen-WMF came up with the following idea: when the user opens the cross-wiki b... [18:40:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: ( ! ) Warning: Illegal string offset 'plaintext' in /vagrant/mediawiki/extensions/Flow/includes/Formatter/RevisionFormatter.php on line 343 - https://phabricator.wikimedia.org/T132990#2472006 (10jmatazzoni) 05Open>03Resolved [18:40:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Vagrant, 13Patch-For-Review: Split Flow role - https://phabricator.wikimedia.org/T133629#2472007 (10jmatazzoni) 05Open>03Resolved [19:01:42] mooeypoo, RoanKattouw, I should really know this by now, but do you have a reference on how the event bubbling order actually works? [19:01:50] I always thought it was based on DOM descendants. [19:02:19] is it not? :o [19:02:42] MatmaRex, yeah, I feel the same way. We just discussed in a meeting. Hopefully I just misunderstood... [19:53:54] Yeah I think I misspoke and it probably is DOM descendants [19:54:19] But I'm not sure [19:54:25] (for click events that is) [20:00:51] 10Notifications: Timestamp discrepancy for cross-wiki notifications - https://phabricator.wikimedia.org/T140580#2472528 (10Catrope) >>! In T140580#2471784, @IKhitron wrote: > I saw on my local wiki two cross-wiki notifications in bundle. Did not pay attention on timestamps. I clicked on the blue dot on one of th... [20:05:40] stephanebisson: again about the counters -- https://phabricator.wikimedia.org/T140327 :( I hoped that the bug would go away - now I clearly see it in production [20:06:36] stephanebisson: can you take a quick look - what do you think? Looks to me like "seenTime" is too aggressive for cross-wiki notificaitons. [20:06:50] 10Notifications: Timestamp discrepancy for cross-wiki notifications - https://phabricator.wikimedia.org/T140580#2472546 (10IKhitron) I have no idea. I closed it yesterday. [20:14:50] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: In some cases notifications that were marked read, reappear as unread again - https://phabricator.wikimedia.org/T140309#2472595 (10Mooeypoo) Unfortunately, there's no SQL query I can run that will show me what the problem is. The only query that I could do will f... [20:15:40] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: [betalabs-Regression] Incorrect count when only cross-wiki notifications are present - https://phabricator.wikimedia.org/T140327#2472596 (10Etonkovidova) [20:21:27] (03CR) 10Mooeypoo: Relate read-state filter and mark read/unread action (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298910 (https://phabricator.wikimedia.org/T136891) (owner: 10Mooeypoo) [20:21:58] (03PS5) 10Mooeypoo: Relate read-state filter and mark read/unread action [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298910 (https://phabricator.wikimedia.org/T136891) [20:22:19] (03CR) 10jenkins-bot: [V: 04-1] Relate read-state filter and mark read/unread action [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298910 (https://phabricator.wikimedia.org/T136891) (owner: 10Mooeypoo) [20:24:01] (03PS6) 10Mooeypoo: Relate read-state filter and mark read/unread action [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298910 (https://phabricator.wikimedia.org/T136891) [20:28:03] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name) - https://phabricator.wikimedia.org/T139520#2472655 (10Etonkovidova) The following instances of 'message' ha... [20:34:45] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Remove (redundant) 'mark as read' function from notifications dotdotdot menu - https://phabricator.wikimedia.org/T140517#2472696 (10Mattflaschen-WMF) >>! In T140517#2468269, @Danny_B wrote: > Seriously are 3-5 editors sample of the entire population? This is qu... [20:37:48] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: In some cases notifications that were marked read, reappear as unread again - https://phabricator.wikimedia.org/T140309#2472727 (10jmatazzoni) [20:44:26] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Notification Page doesn't display properly in mobile - https://phabricator.wikimedia.org/T139525#2472782 (10jmatazzoni) I'm splitting this ticket into two: one to stop the Notifications page on mobile from being unusable due to display of the left n... [20:44:57] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Remove (redundant) 'mark as read' function from notifications dotdotdot menu - https://phabricator.wikimedia.org/T140517#2472783 (10Danny_B) >>! In T140517#2472696, @Mattflaschen-WMF wrote: >> I can immediatelly provide a counter-research with the same number of... [20:45:21] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: In some cases notifications that were marked read, reappear as unread again - https://phabricator.wikimedia.org/T140309#2472785 (10IKhitron) You did not understand me, @Mooeypoo. I'm not talking about SQL query, I am talking about SQL tracing. You have a lot of... [20:46:17] 10Notifications: Timestamp discrepancy for cross-wiki notifications - https://phabricator.wikimedia.org/T140580#2472805 (10Etonkovidova) The steps to reproduce the issue are 1. When user A is logged in, user B sends user A a cross-wiki notice/alert. 2. User A without refreshing the page, opens the flyout. Sever... [20:48:00] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Make mobile-friendly version of the Notifications page left nav - https://phabricator.wikimedia.org/T139525#2472814 (10jmatazzoni) [20:51:09] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Make Notification page on mobile usable by suppressing the left, filtering nav (for now) - https://phabricator.wikimedia.org/T140687#2472841 (10jmatazzoni) [20:51:35] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Make Notification page on mobile usable by suppressing the left, filtering nav (for now) - https://phabricator.wikimedia.org/T140687#2472788 (10jmatazzoni) a:03Mooeypoo [21:08:13] https://phabricator.wikimedia.org/T140327 [21:09:57] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: [betalabs-Regression] Incorrect count when only cross-wiki notifications are present - https://phabricator.wikimedia.org/T140327#2472918 (10Quiddity) p:05Triage>03High [21:12:18] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07Regression: [betalabs-Regression] Incorrect count when only cross-wiki notifications are present - https://phabricator.wikimedia.org/T140327#2460353 (10jmatazzoni) a:03SBisson [21:24:48] 10Notifications, 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: "CAS update failed on gu_cas_token" thrown by CentralAuth autocreation jobs - https://phabricator.wikimedia.org/T140692#2472995 (10Catrope) [21:25:18] 10Notifications, 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: "CAS update failed on gu_cas_token" thrown by CentralAuth autocreation jobs - https://phabricator.wikimedia.org/T140692#2473007 (10Catrope) p:05Triage>03Unbreak! [21:25:37] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: "CAS update failed on gu_cas_token" thrown by CentralAuth autocreation jobs - https://phabricator.wikimedia.org/T140692#2473009 (10Catrope) [21:31:23] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: "CAS update failed on gu_cas_token" thrown by CentralAuth autocreation jobs - https://phabricator.wikimedia.org/T140692#2473057 (10Catrope) p:05Unbreak!>03High Looks like this is not an actual e... [21:41:23] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Horizontal scrollbar when bundled notification timestamp is longer than 2 characters - https://phabricator.wikimedia.org/T140349#2473084 (10Catrope) a:03Mooeypoo [21:52:24] (03PS1) 10Catrope: ForeignWikiRequest: Also check User::isSafeToLoad() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299673 (https://phabricator.wikimedia.org/T139665) [21:52:45] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: "User::loadFromSession called before the end of Setup.php" warning due to Echo - https://phabricator.wikimedia.org/T139665#2473107 (10Catrope) a:03Catrope [21:54:02] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: "User::loadFromSession called before the end of Setup.php" warning due to Echo - https://phabricator.wikimedia.org/T139665#2439332 (10Catrope) My patch avoids going into this code path at all if `$wgUser->isSafeToL... [21:57:09] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#2473124 (10jmatazzoni) a:03Mooeypoo [21:57:10] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Make Notification page on mobile usable by suppressing the left, filtering nav (for now) - https://phabricator.wikimedia.org/T140687#2473125 (10Catrope) p:05Triage>03High [21:57:45] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2473126 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [21:58:47] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Notifications: read-only mode for Notifications/Flow does not display user-friendly message - https://phabricator.wikimedia.org/T129925#2473129 (10Mattflaschen-WMF) [22:00:12] 06Collaboration-Team-Interested, 10Notifications: Scrolling on the Echo survey's popup/tooltip - https://phabricator.wikimedia.org/T132384#2473133 (10Catrope) [22:03:10] 06Collaboration-Team-Interested, 10Flow: Need a way to get from a topic page to the associated content page(s) and talkpage(s) - https://phabricator.wikimedia.org/T90280#2473149 (10Quiddity) [22:03:12] 10Flow: Add a link to the namespace associated with talk namespace on which the topic is embedded when being in the topic namespace itself - https://phabricator.wikimedia.org/T138936#2473151 (10Quiddity) [22:08:01] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 07Availability: Flow: Use WAN cache delete() and slave populations to avoid merge() - https://phabricator.wikimedia.org/T120009#2473184 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [22:16:04] 10Notifications: "Call to a member function getTimestamp() on a non-object" on backfillUnreadWikis for frwiktionary - https://phabricator.wikimedia.org/T140697#2473206 (10Mattflaschen-WMF) [22:19:47] 06Collaboration-Team-Interested, 10Flow: Need a way to get from a topic page to the associated content page(s) and talkpage(s) - https://phabricator.wikimedia.org/T90280#2473243 (10Kghbln) So my request was the third dupe. [22:22:12] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Make mobile-friendly version of the Notifications page left nav - https://phabricator.wikimedia.org/T139525#2473263 (10jmatazzoni) [22:23:30] 10Notifications: "Message" and "alert" notifications flipped - https://phabricator.wikimedia.org/T139677#2473274 (10Mattflaschen-WMF) 05Open>03Invalid Per @Quiddity . [22:25:45] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 07Technical-Debt: Flow should not manually forward metadata from ParserOutput - https://phabricator.wikimedia.org/T140665#2473288 (10Mattflaschen-WMF) [22:39:03] Grep side effects: [22:39:16] grep -n rswikimedia /home/matthew/Code/Wikimedia/operations/mediawiki-config/dblists/private.dblist [22:39:23] (Originally part of an xargs chain) [22:39:41] Comes up as noboard_chapterswikimedia [22:39:46] * matt_flaschen anchors his greps better. [22:55:49] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Timestamps in flyout can differ from Special:Notifications - https://phabricator.wikimedia.org/T131733#2473429 (10Etonkovidova) After the overhaul of Special:Notifications the issue is not reproducible anymore - tried in 1.28.0-alpha (b095791) and 1.... [22:57:06] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Timestamps in flyout can differ from Special:Notifications - https://phabricator.wikimedia.org/T131733#2473431 (10Etonkovidova) 05Open>03Resolved [23:03:10] 06Collaboration-Team-Interested, 10Flow, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Flow: Extension:MultimediaViewer doesn't work on files in Flow posts - https://phabricator.wikimedia.org/T62014#2473465 (10Tgr) [23:03:12] 06Collaboration-Team-Interested, 10Flow, 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog: Media Viewer doesn't trigger on Flow-enabled talk pages - https://phabricator.wikimedia.org/T64594#2473467 (10Tgr) [23:05:32] 06Collaboration-Team-Interested, 10Flow, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Flow: Extension:MultimediaViewer doesn't work on files in Flow posts - https://phabricator.wikimedia.org/T62014#2473478 (10Tgr) From T64594#673955: > * MultimediaViewerHooks::getModulesForArticle() - this checks if the image h... [23:08:12] RoanKattouw, is there a task about running the transition scripts? [23:08:32] RoanKattouw, it's basically done, except T140697. Just wondering if there's somewhere I should link it to. [23:08:33] T140697: "Call to a member function getTimestamp() on a non-object" on backfillUnreadWikis for frwiktionary - https://phabricator.wikimedia.org/T140697 [23:11:19] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Link inspector: 'Uncaught Type Error' if the link inspector Edit is not explicitly closed/dismissed - https://phabricator.wikimedia.org/T122910#2473485 (10Etonkovidova) Re-checked the scenarios (1) scenario displays: Uncaught TypeError: Cannot read property 'ownerDocum... [23:11:51] matt_flaschen: Don't think there is [23:12:14] RoanKattouw, stephanebisson, mooeypoo, etonkovidova, scripts are done. There is an error on frwiktionary. I cross-checked, and all of the other errors are expected and do not need to be fixed (fishbowl, private, and nonglobal (labswiki and labtestwiki) wikis without cross-wiki notifications, and legalwiki/loginwiki/votewiki/zerowiki which don't have Echo at all). [23:12:49] matt_flaschen: thx! [23:12:58] matt_flaschen: What's the frwiktionary error? [23:12:59] P3427 P3449 P3428 P3430 P3429 P3464 P3450 P3465 [23:13:00] P3465 Masterwork From Distant Lands - https://phabricator.wikimedia.org/P3465 [23:13:00] P3464 Masterwork From Distant Lands - https://phabricator.wikimedia.org/P3464 [23:13:00] P3428 Masterwork From Distant Lands - https://phabricator.wikimedia.org/P3428 [23:13:00] P3429 (An Untitled Masterwork) - https://phabricator.wikimedia.org/P3429 [23:13:00] P3449 Masterwork From Distant Lands - https://phabricator.wikimedia.org/P3449 [23:13:01] P3450 Masterwork From Distant Lands - https://phabricator.wikimedia.org/P3450 [23:13:01] P3430 (An Untitled Masterwork) - https://phabricator.wikimedia.org/P3430 [23:13:02] P3427 Masterwork From Distant Lands - https://phabricator.wikimedia.org/P3427 [23:13:09] Regardless of the answer though we should rerun on that wiki [23:13:27] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Link/Mention inspector: 'Uncaught Type Error' if the link inspector Edit is not explicitly closed/dismissed - https://phabricator.wikimedia.org/T122910#2473502 (10Etonkovidova) [23:13:36] RoanKattouw, it's quite weird, $alertTime was apparently null. [23:13:49] Or I guess false. [23:14:04] Oh, yeah we've had occasional errors due to that [23:14:29] RoanKattouw, it's weird. It's documented to be allowed to be a boolean, but that isn't checked. [23:14:32] I guess that's the first fix. [23:14:48] Yeah, although I did fix this somewhere recently I think [23:14:49] But maybe not in the script [23:14:53] It's probably not supposed to be false because that implies the count is null [23:14:55] RoanKattouw, yeah, I guess I'll just re-run it. I was thinking whether I should check the DB first, but I'm not going to unless someone objects. [23:15:16] (03PS1) 10Mooeypoo: Adjust the width of content in bundled item based on language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299685 (https://phabricator.wikimedia.org/T140349) [23:15:20] No, go for it [23:15:28] That rerun should be fast anyway, frwiktionary isn't that big [23:16:15] matt_flaschen, I'm taking bets, how long it takes RoanKattouw to get so disgusted by this fix that he fixes the browser itself or finds a workaround. https://gerrit.wikimedia.org/r/299685 [23:16:17] RoanKattouw, do you know what the bool means? https://phabricator.wikimedia.org/diffusion/ECHO/browse/master/includes/UnreadWikis.php;b39be63c4456e45eb6a4b262cf0c50d273903172$95 [23:16:28] mooeypoo: Today or tomorrow [23:16:49] matt_flaschen: timestamp=max(notifTimestamps), timestamp=FALSE implies that count(notifTimestamps)=0 [23:16:50] Wow, I was going to say within hours, I guess the code could've been a little more appalling. [23:16:53] I should work on that [23:17:00] I plead jetlag as a defense [23:17:14] Okay, I'll give you that. Bets should take that into account./ [23:19:43] mooeypoo, I'll put one stroopwafel on "different work around tomorrow, browser fix to Chrome next week, bug report filed against iOS 3 days from now and ignored for 5 years" [23:23:40] haha [23:24:02] Oh man I would love to write patches fixing browser bugs but I'm not familiar enough with browser internals [23:24:11] I would have to spend a ton of time learning how browsers actually work on the inside [23:24:31] Occasionally I want to but then I consider the massive learning curve [23:31:02] RoanKattouw, so I think it's probably a race condition where they mark a notification read right after getting the count (so the count is non-zero, but the time is null). [23:31:23] Aaah [23:31:27] That would explain so much! [23:32:09] https://phabricator.wikimedia.org/diffusion/ECHO/browse/master/maintenance/backfillUnreadWikis.php;b39be63c4456e45eb6a4b262cf0c50d273903172$47 [23:34:16] Hmm, although.... [23:34:18] RoanKattouw, so I think short of making it atomic, the right solution is to bail only in backfillUnreadWikis (since if the user did an operation the normal-flow updateCount should work fine. [23:34:24] I modified that script to allow using the cache [23:34:29] So it should be pretty rare [23:34:37] Yeah I was just thinking the same [23:35:20] If there's a race condition you're racing with a resetNotiifcationCount() call and that'll update [23:35:32] So basically, if there's an inconsistency, don't call updateCount at all (there is no need to call it for the other section either, since both are updated at once) [23:37:37] RoanKattouw, and resetNotificationCount is called basically everywhere, right? It seems if anything changes (including preferences) everything is recalculated. [23:38:02] Yu [23:38:03] p [23:38:18] But also I was arguing that the fact that there was a race condition at all means it's executing [23:40:06] RoanKattouw, means what's executing? [23:40:13] resetNotificationCount [23:40:35] RoanKattouw, right, I think it is being coincidentally updated in a web request. [23:40:39] RoanKattouw, patch coming. [23:47:10] (03CR) 10Mooeypoo: [C: 032] "WFM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/298722 (https://phabricator.wikimedia.org/T135619) (owner: 10Sbisson) [23:47:13] (03PS1) 10Mattflaschen: backfillUnreadWikis: Skip updateCount if race condition detected [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299692 [23:48:01] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Redirects, 06Operations, and 2 others: Flow notification links on mobile point to desktop - https://phabricator.wikimedia.org/T107108#2473577 (10Etonkovidova) Testing *production** for the scenarios described in the ticket: |** Notification** |**Mobile p... [23:48:16] RoanKattouw, I'm still just going to run it again, since I'd rather not request a special window, and I don't want to wait until noon tomorrow just to run the last script. And like you said it should be (and has been) very rare. [23:48:24] Yeah go for it [23:48:38] If it really is a race condition it probably won't happen again, especially on a small wiki [23:48:50] * James_F crosses Roan's fingers for him. [23:49:28] Also it's not the end of the world if we don't run this script for a few users, because any inconsistencies will be fixed the next time resetNotiifcationCount runs (i.e. next time they get a notification, or mark one as read/unread) [23:49:35] (03CR) 10Mooeypoo: [C: 032] "WFM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/298138 (https://phabricator.wikimedia.org/T140091) (owner: 10Esanders) [23:51:36] (03CR) 10jenkins-bot: [V: 04-1] backfillUnreadWikis: Skip updateCount if race condition detected [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299692 (owner: 10Mattflaschen) [23:52:06] RoanKattouw, yeah, usually when people complain about it, I just reply with a ping and then ask them to check again. [23:52:17] j/k [23:53:22] LOL [23:54:23] (03Merged) 10jenkins-bot: Don't show 'start a new topic' twice [extensions/Flow] - 10https://gerrit.wikimedia.org/r/298722 (https://phabricator.wikimedia.org/T135619) (owner: 10Sbisson) [23:54:24] But actually all users should be covered properly if we understand the cause of the inconsistence (the race above), since by definition that means it did get updated as you said. [23:55:56] (03PS23) 10Mooeypoo: Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [23:56:18] (03CR) 10jenkins-bot: [V: 04-1] Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [23:57:10] (03Merged) 10jenkins-bot: Remove unnecessary width:100% from header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/298138 (https://phabricator.wikimedia.org/T140091) (owner: 10Esanders) [23:59:21] (03CR) 10Mooeypoo: [C: 032] "wfm" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298730 (https://phabricator.wikimedia.org/T139644) (owner: 10Sbisson)