[00:01:44] matt_flaschen, meh, I'm going to have to return the echo-pt-tooltip-message key [00:02:05] it's built automatically by mw and uses the class name, which is still divided by sections, because back-end isn't adjusted yet :\ [00:02:47] it's going to be a nightmare to adjust the entire of the no-js backend for 'notice' instead of 'message' while still keeping the section names for seenTime and the rest of the split ... [00:06:24] mooeypoo, oops, I should have caught that. You don't want to use $insertUrls['notifications-notice'] for now? [00:07:33] mooeypoo, do you want to fix it for SWAT? They haven't deployed the main one, yet, so we could ask to put the followup in. [00:08:38] (03PS1) 10Mooeypoo: Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297932 (https://phabricator.wikimedia.org/T139520) [00:08:39] matt_flaschen, ^ [00:09:24] (03PS2) 10Mooeypoo: Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297932 (https://phabricator.wikimedia.org/T139520) [00:09:24] oops, minor qqq fix [00:09:25] there. [00:09:41] matt_flaschen, oh... hm [00:10:08] matt_flaschen, I wasn't sure if that would work [00:10:25] matt_flaschen, also, that would require a change in all of our CSS and some of our JS scripts [00:11:58] matt_flaschen, I'm testing your way out, see how much work it is (I think it actually might be ok) [00:12:07] do we still have time for the SWAT for that? [00:12:33] mooeypoo, it's already 12 minutes after the end of SWAT, let's just do the patch you have up, since there's going to need to be a big follow up anyway. [00:12:45] Sorry, I know I just suggested it, but. [00:12:51] * mooeypoo nods [00:12:53] I'm testing your patch now. [00:13:03] I'll finish up this one anyways so we have a *starting point* for the big change [00:13:16] but I'll really feel better if it'snot rushed anyways [00:24:49] (03Merged) 10jenkins-bot: Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297932 (https://phabricator.wikimedia.org/T139520) (owner: 10Mooeypoo) [00:25:08] (03PS1) 10Mooeypoo: Load notification badges with the new 'notice' instead of 'message' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297933 (https://phabricator.wikimedia.org/T139520) [00:25:28] (03CR) 10jenkins-bot: [V: 04-1] Load notification badges with the new 'notice' instead of 'message' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297933 (https://phabricator.wikimedia.org/T139520) (owner: 10Mooeypoo) [00:25:35] (03PS2) 10Mooeypoo: [wip] Load notification badges with the new 'notice' instead of 'message' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297933 (https://phabricator.wikimedia.org/T139520) [00:25:54] matt_flaschen, this is the more "proper" way of doing things, but I'm leaving it as WIP because it's missing undoing the patch you just merged + some more testing [00:26:02] (03CR) 10jenkins-bot: [V: 04-1] [wip] Load notification badges with the new 'notice' instead of 'message' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297933 (https://phabricator.wikimedia.org/T139520) (owner: 10Mooeypoo) [00:26:06] I'm going to quit while I'm ahead tonight, seeing as the urgent stuff are merged. [00:26:18] matt_flaschen, anything urgent left? I plan to start heading off... [00:26:57] mooeypoo, no, have a good night. [00:27:02] you too! [00:27:13] let me know in hangouts if anything happens post-SWAT or something [00:27:22] see you tomorrow! [00:28:00] mooeypoo, will do. [00:29:12] (03PS1) 10Mattflaschen: Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297934 (https://phabricator.wikimedia.org/T139520) [00:33:37] (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297919 (https://phabricator.wikimedia.org/T139520) (owner: 10Dereckson) [00:39:23] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2435307 (10Mattflaschen-WMF) @SBisson asked me to check all the tables for this field (this would only be an issu... [00:41:19] (03Merged) 10jenkins-bot: Change 'messages' to 'notices' throughout the interface [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297919 (https://phabricator.wikimedia.org/T139520) (owner: 10Dereckson) [00:49:50] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Special:Notifications not showing all my notifications in production - https://phabricator.wikimedia.org/T139696#2440091 (10Quiddity) See also {T129638} and {T123338} [00:50:29] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2435307 (10Krenair) >>! In T139536#2440347, @Mattflaschen-WMF wrote: > The ones not on extension1 are: > > * lab... [00:52:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, and 2 others: Bundled notifications: The counter for bundled notifications shows sum of notifications of Alerts and Messages. - https://phabricator.wikimedia.org/T139323#2440390 (10Liuxinyu970226) [00:56:40] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2440392 (10Mattflaschen-WMF) Also: 4. EventMapper->fetchByTypesAndPage (echo_event.*). 5. EventMapper->fetchUnrea... [00:59:28] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2440394 (10Mattflaschen-WMF) >>! In T139536#2440387, @Krenair wrote: > I think you just need to SSH to labtestweb... [01:03:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2440398 (10Krenair) >>! In T139536#2440394, @Mattflaschen-WMF wrote: >>>! In T139536#2440387, @Krenair wrote: >>... [01:06:02] (03PS2) 10Dereckson: Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297934 (https://phabricator.wikimedia.org/T139520) (owner: 10Mattflaschen) [01:06:19] (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297934 (https://phabricator.wikimedia.org/T139520) (owner: 10Mattflaschen) [01:08:22] 10Collab-Notifications-Page: Special:Notifications should allow for zooming and not create horizontal scrollbars - https://phabricator.wikimedia.org/T139708#2440401 (10Quiddity) [01:13:57] (03Merged) 10jenkins-bot: Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297934 (https://phabricator.wikimedia.org/T139520) (owner: 10Mattflaschen) [01:37:18] (03PS1) 10Mattflaschen: Fix E_NOTICE due to event_delete missing on foreign psuedo-notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297943 (https://phabricator.wikimedia.org/T139536) [01:40:13] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2440478 (10Mattflaschen-WMF) >>! In T139536#2440398, @Krenair wrote: > Are you sure your SSH config is correct to... [01:43:04] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2440479 (10Krenair) Ah, turns out this is my fault. Despite being in eqiad and codfw respectively, silver and lab... [01:51:12] (03PS2) 10Mattflaschen: Fix E_NOTICE due to event_deleted missing on foreign psuedo-notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297943 (https://phabricator.wikimedia.org/T139536) [01:51:51] (03CR) 10Mattflaschen: [C: 04-1] "If we need to do this, we should at least log it." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297831 (https://phabricator.wikimedia.org/T139536) (owner: 10Sbisson) [02:11:02] 10Notifications: Notifications header showing - https://phabricator.wikimedia.org/T139712#2440501 (10GorillaWarfare) [02:13:13] 10Notifications: Notifications header showing - https://phabricator.wikimedia.org/T139712#2440513 (10Legoktm) [02:13:42] 10Notifications: Notifications header showing - https://phabricator.wikimedia.org/T139712#2440515 (10Dereckson) a:03Dereckson Working on this. [02:18:56] 10Notifications: Notifications header showing - https://phabricator.wikimedia.org/T139712#2440517 (10Dereckson) The root cause is Terbium was out of disk during our last scap for an Echo deployment. [02:36:50] 10Notifications: Notifications header showing - https://phabricator.wikimedia.org/T139712#2440522 (10Dereckson) Fixed for en. [02:49:56] 10Collab-Notifications-Page: Special:Notifications: You should be able to see notifications on foreign wikis even if you have none on the current - https://phabricator.wikimedia.org/T139713#2440534 (10Mattflaschen-WMF) [02:52:46] 10Notifications: Notifications header showing - https://phabricator.wikimedia.org/T139712#2440537 (10Dereckson) 05Open>03Resolved That was solved at 02:37 refreshing the ResourceLoader caches through a [[ https://wikitech.wikimedia.org/wiki/LocalisationUpdate | l10nupdate... [03:47:05] mooeypoo: thx! I see now "Your alerts" and "Your notices" :) [06:26:53] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Notifications, 13Patch-For-Review, and 3 others: New notifications layout is underparsed - https://phabricator.wikimedia.org/T139602#2440642 (10Trizek-WMF) [07:00:35] 10Notifications: PHP Strict Standards: Declaration of ApiEchoUnreadNotificationPages::getFromForeign should be compatible - https://phabricator.wikimedia.org/T139720#2440694 (10mwjames) [07:08:04] 10Notifications: Echo "Recent activity" window shows an empty "grey" highlight - https://phabricator.wikimedia.org/T139721#2440710 (10mwjames) [07:15:52] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Help to define next steps concerning Flow development, based on Flow satisfaction survey - https://phabricator.wikimedia.org/T137796#2440749 (10Trizek-WMF) >>! In T137796#2439566, @Qgil wrote:... [10:52:05] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Special:Notifications not showing all my notifications in production - https://phabricator.wikimedia.org/T139696#2440091 (10SBisson) Have you checked if the no-js version shows the same data? [11:01:14] (03CR) 10Sbisson: "Matt: The cleanup of the old formatting system (start here: I639b9d9906d3ff37021cb9b5ed3cb401354b5bd9) should get rid of the unused code p" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297831 (https://phabricator.wikimedia.org/T139536) (owner: 10Sbisson) [11:01:30] (03Abandoned) 10Sbisson: Undefined property: stdClass::$event_deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297831 (https://phabricator.wikimedia.org/T139536) (owner: 10Sbisson) [13:05:25] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2441323 (10SBisson) >>! In T129363#2346043, @jmatazzoni wrote: > Sending back to Ready for Pickup for: > > - Style changes by i... [13:19:17] (03CR) 10Sbisson: [C: 032] Fix E_NOTICE due to event_deleted missing on foreign psuedo-notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297943 (https://phabricator.wikimedia.org/T139536) (owner: 10Mattflaschen) [13:20:04] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2441371 (10SBisson) a:05SBisson>03Mattflaschen-WMF [13:28:45] (03Merged) 10jenkins-bot: Fix E_NOTICE due to event_deleted missing on foreign psuedo-notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297943 (https://phabricator.wikimedia.org/T139536) (owner: 10Mattflaschen) [13:32:20] (03CR) 10Sbisson: [C: 032] Only fetch 'unreadfirst' for the Popup, not Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297924 (https://phabricator.wikimedia.org/T136885) (owner: 10Mooeypoo) [13:38:00] (03Merged) 10jenkins-bot: Only fetch 'unreadfirst' for the Popup, not Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297924 (https://phabricator.wikimedia.org/T136885) (owner: 10Mooeypoo) [14:08:20] (03CR) 10Sbisson: [C: 032] Properly aggregate the itemUpdate event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297694 (owner: 10Mooeypoo) [14:16:23] (03Merged) 10jenkins-bot: Properly aggregate the itemUpdate event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297694 (owner: 10Mooeypoo) [14:22:24] (03CR) 10Sbisson: [C: 032] "Thanks for doing this." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297862 (owner: 10Mooeypoo) [14:27:54] (03Merged) 10jenkins-bot: Store local source as 'local' rather than dbName [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297862 (owner: 10Mooeypoo) [14:59:21] (03CR) 10Sbisson: [C: 04-1] "See comments inline." (038 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [15:17:30] (03PS1) 10Jakob: WIP Send notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297997 (https://phabricator.wikimedia.org/T138938) [15:26:02] (03CR) 10jenkins-bot: [V: 04-1] WIP Send notification for mentions on changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297997 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [16:04:45] hello! just wanted to verify this is a bug: It appears the icons for notifications and messages have been swapped. E.g. the bell icon now shows my messages [16:10:06] musikanimal, Hi, the notifications have been re-sorted. I left an explanation with many links to the background, in the thread at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Notification_issue [16:10:39] the task with clearest details is https://phabricator.wikimedia.org/T123018 [16:11:15] thanks! I should have looked at VPT, figures it would have come up there [16:12:42] Oh VPT. I love that we have users who expect all features to be perfect and otherwise call them "rushed" [16:13:35] * bd808 wonders how often they complain to the rest of the interwebz [16:15:49] I'm currently writing an explanation of page-loading-order. yay! :) [16:28:36] 10Collab-Notifications-Page: Special:Notifications: You should be able to see notifications on foreign wikis even if you have none on the current - https://phabricator.wikimedia.org/T139713#2440523 (10Etonkovidova) Two issues were filed: {T139637} (split off {T129366} ) and {T139512} [17:10:30] hello, could I get the final review on https://gerrit.wikimedia.org/r/#/c/276159/ from some Echo maintainers? it has already been reviewed by some of you but now it should be the final one [17:16:51] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name) - https://phabricator.wikimedia.org/T139520#2442133 (10Mattflaschen... [17:35:39] 10Collab-Notifications-Page: Special:Notifications: You should be able to see notifications on foreign wikis even if you have none on the current - https://phabricator.wikimedia.org/T139713#2442200 (10SBisson) [17:35:41] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: When a user only has foreign notifications, the special page shows "You have no notifications." - https://phabricator.wikimedia.org/T139512#2442202 (10SBisson) [17:36:03] 03Collab-Team-2016-Apr-Jun-Q4, 06Design-Research-Backlog, 10Edit-Review-Improvements: Scheduling Huggle user interviews - https://phabricator.wikimedia.org/T135792#2442212 (10ggellerman) [17:48:56] (03PS15) 10Mooeypoo: Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [17:56:46] (03CR) 10Mooeypoo: Add a mark-all-read button and a settings menu to Special:Notifications (038 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [17:56:57] (03PS16) 10Mooeypoo: [wip] Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [18:03:55] mooeypoo: https://github.com/wikimedia/mediawiki-extensions-Echo/blob/master/modules/icons/apex/badgeicons.json :-((((( [18:04:26] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): [betalabs] Special:Notifications page has wrong sorting order after messages are 'Marked as unread' - https://phabricator.wikimedia.org/T136885#2442393 (10Etonkovidova) [18:05:00] lovely... [18:05:11] James_F, all hail cheating! [18:07:38] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): [betalabs] Special:Notifications page has wrong sorting order after messages are 'Marked as unread' - https://phabricator.wikimedia.org/T136885#2442412 (10Etonkovidova) Checked the fix... [18:10:14] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: When a user only has foreign notifications, the special page shows "You have no notifications." - https://phabricator.wikimedia.org/T139512#2442416 (10Mooeypoo) I can see in the code how this would happen, but I can't personally reproduce th... [18:12:28] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: When a user only has foreign notifications, the special page shows "You have no notifications." - https://phabricator.wikimedia.org/T139512#2442417 (10Mooeypoo) Okay, I just got it -- an entirely fresh new user completely without notificatio... [18:13:06] (03CR) 10Mooeypoo: [C: 032] Special:Notifications JS even when no local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297633 (https://phabricator.wikimedia.org/T139512) (owner: 10Sbisson) [18:14:02] (03PS17) 10Mooeypoo: [wip] Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [18:15:49] 10Notifications, 10OOjs-UI, 07Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779#2442418 (10Jdforrester-WMF) [18:17:15] mooeypoo: ^^^ :-) [18:19:52] (03Merged) 10jenkins-bot: Special:Notifications JS even when no local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297633 (https://phabricator.wikimedia.org/T139512) (owner: 10Sbisson) [18:20:22] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Notifications, 13Patch-For-Review, and 3 others: New notifications layout is underparsed - https://phabricator.wikimedia.org/T139602#2442458 (10jmatazzoni) 05Open>03Resolved [18:20:53] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): [betalabs] Special:Notifications page has wrong sorting order after messages are 'Marked as unread' - https://phabricator.wikimedia.org/T136885#2442459 (10jmatazzoni) 05Open>03Resolv... [18:21:56] 06Collaboration-Team-Interested, 10Notifications, 07Epic, 07Tracking, 07WorkType-NewFunctionality: Better organisation for the Notification System - https://phabricator.wikimedia.org/T114351#2442464 (10jmatazzoni) [18:21:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, and 2 others: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2442463 (10jmatazzoni) 05Open>03Resolved [18:23:16] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, and 2 others: Unread notifications are not always at the top of the flyout/popup - https://phabricator.wikimedia.org/T139521#2442465 (10jmatazzoni) 05Open>03Resolved [18:23:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, and 2 others: Bundled notifications: The counter for bundled notifications shows sum of notifications of Alerts and Messages. - https://phabricator.wikimedia.org/T139323#2442466 (10jmatazzoni) 05Open>03Resolved [18:32:18] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Bundled notifications: New lines preserved in text excerpts - https://phabricator.wikimedia.org/T139321#2442511 (10jmatazzoni) 05Open>03Resolved [18:33:19] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Design, 07Tracking: Design adjustments for the Notifications Page - https://phabricator.wikimedia.org/T136567#2442527 (10jmatazzoni) [18:33:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Status filter should not become disabled between status change in the Notification Page - https://phabricator.wikimedia.org/T136895#2442526 (10jmatazzoni) 05Open>03Resolved [18:40:12] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Epic, 07Tracking: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2442539 (10jmatazzoni) [18:40:15] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2442538 (10jmatazzoni) 05Open>03Resolved [19:06:42] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Notification page side panel: sorting order of pages is incorrect - https://phabricator.wikimedia.org/T139642#2442613 (10jmatazzoni) Elena writes: > According to the specs the side panel should sort > - pages alphabetically > - user/user talk page... [19:22:39] 06Collaboration-Team-Interested, 10MediaWiki-extensions-PageCuration, 13Patch-For-Review: Implement addition of un-redirected pages to Special:NewPages and Special:NewPagesFeed - https://phabricator.wikimedia.org/T92621#2442636 (10Swpb) It's been 15 months since this request started, with no apparent action... [19:22:53] 06Collaboration-Team-Interested, 10MediaWiki-extensions-PageCuration, 13Patch-For-Review: Implement addition of un-redirected pages to Special:NewPages and Special:NewPagesFeed - https://phabricator.wikimedia.org/T92621#2442637 (10Swpb) p:05Lowest>03Normal [19:25:13] 06Collaboration-Team-Interested, 10MediaWiki-extensions-PageCuration, 10MediaWiki-extensions-Disambiguator: Disambiguation pages should not be marked as "No citations" - https://phabricator.wikimedia.org/T76198#2442643 (10Swpb) p:05Low>03Normal [19:59:42] matt_flaschen: sorry to bother you - totally unimportant - why there is no event_deleted !=0 ? not in production and not in betalabs? [20:01:01] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10), 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2435307 (10Etonkovidova) - Selectively checked x1-analytics-slave for... [20:03:06] etonkovidova, T93673 has not been implemented yet, although there is supporting code. [20:03:06] T93673: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673 [20:03:28] matt_flaschen: kk [20:09:41] 10Notifications, 10MediaWiki-extensions-CentralAuth, 07TestMe: Echo / SUL: Notifications number displayed without style (in p-personal) on first time - https://phabricator.wikimedia.org/T55134#2442779 (10matej_suchanek) [20:11:01] 06Collaboration-Team-Interested, 10Flow, 07TestMe: Echo: [no page] name given for a visible topic - https://phabricator.wikimedia.org/T73483#2442784 (10matej_suchanek) [20:19:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2442807 (10Mattflaschen-WMF) >>! In T89398#2409081, @ArielGlenn wrote: > Another thing for the Flow extension folks to look at is the fa... [20:21:55] 10Flow, 10Dumps-Generation: Handle missing content when dumping - https://phabricator.wikimedia.org/T139791#2442811 (10Mattflaschen-WMF) [20:22:19] 10Flow, 10Dumps-Generation: Handle missing content when dumping - https://phabricator.wikimedia.org/T139791#2442826 (10Mattflaschen-WMF) [20:23:05] 10Flow, 10Dumps-Generation: Flow: Handle missing content when dumping - https://phabricator.wikimedia.org/T139791#2442811 (10Mattflaschen-WMF) [20:27:50] 10Notifications, 10MediaWiki-extensions-CentralAuth: Echo / SUL: Notifications number displayed without style (in p-personal) on first time - https://phabricator.wikimedia.org/T55134#2442863 (10Legoktm) -TestMe, I see this pretty often. [20:44:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [iOS] The dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393#2442932 (10Mattflaschen-WMF) [20:50:08] etonkovidova, what iPhone/version of iOS did you use when testing T132393 ? [20:50:09] T132393: [iOS] The dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393 [20:52:14] matt_flaschen: hmm... it was for iOS 9.1 or 9.2 iPhone 6 [20:52:24] matt_flaschen: you can not see the issue anymore? [20:52:26] etonkovidova, okay thanks. [20:52:40] etonkovidova, haven't tested on iPhone yet, starting now. [20:53:13] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [iOS] The dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393#2442938 (10Mattflaschen-WMF) [20:54:32] matt_flaschen: I got an impression that it's not reproducible anymore. I will try on iOS 8 [20:55:20] etonkovidova, did someone try, and couldn't reproduce it? [20:56:55] matt_flaschen: I am trying - not reproducible for me and mooeypoo COULD NOT DO IT ON THAT BROWSER SIMULATOR [20:57:16] mooeypoo, you tried on Sauce? [20:58:42] Sauce Labs is not loading for me, don't know if that counts as "not reproducible"... ;) [20:59:34] matt_flaschen: :) Well, it's reproducible on iOS 8 - which I do not think that we should be worry about [21:00:34] matt_flaschen: and besides, the whole Notifications UI is messed up on iOS 8 [21:01:28] etonkovidova, will ask. [21:03:17] Oh it finally loaded. It's just really slow. [21:05:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [iOS] The dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393#2442945 (10Etonkovidova) Not reproducible on iOS 9.3 ; it's reproducible on iOS 8.2 - but there are other issues as well, e.g. 'Notifications' do not take over the whole... [21:06:29] etonkovidova, yeah, it works for me on iOS 9.3 on iPhone 6 Plus on Sauce. [21:07:58] matt_flaschen: it might be that specifically 9.2. or 9.1 do not work ... [21:08:26] matt_flaschen: at this point I'd discard the bug. Unless we want to fix iOS 8 issues [21:10:41] etonkovidova, actually, I think I reproduced it now. [21:15:42] matt_flaschen: on which one? [21:16:11] etonkovidova, iOS 9.3, but the symptoms are more like T139553 . [21:16:12] T139553: On Android Firefox, dot dot dot menu items are sometimes hidden until reflow - https://phabricator.wikimedia.org/T139553 [21:16:34] matt_flaschen: ok [22:04:22] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2443059 (10Etonkovidova) Providing screenshots of each type of notifications(... [22:10:40] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): When a user only has foreign notifications, the special page shows "You have no notifications." - https://phabricator.wikimedia.org/T139512#2443078 (10Etonkovidova) @Mooeypoo >It was hard to reprod... [22:14:22] 10Notifications, 07Browser-Support-Firefox, 07Mobile: On Android Firefox and iOS 9.3, dot dot dot menu items are sometimes hidden until reflow - https://phabricator.wikimedia.org/T139553#2443113 (10Mattflaschen-WMF) [22:16:28] 10Notifications, 07Browser-Support-Firefox, 07Mobile: On Android Firefox and iOS 9.3, dot dot dot menu items are sometimes hidden until reflow - https://phabricator.wikimedia.org/T139553#2443120 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [22:22:17] 10Notifications, 07Browser-Support-Firefox, 07Mobile: On Android Firefox and iOS 9.3, dot dot dot menu items are sometimes hidden until reflow - https://phabricator.wikimedia.org/T139553#2443131 (10Mattflaschen-WMF) [22:32:38] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2443154 (10Etonkovidova) - The specific issue described in the ticket is resolved - the wiki names are a... [22:35:28] 10Flow: WikiToLearn: flow-new-post permissions does not seem to work - https://phabricator.wikimedia.org/T139627#2443188 (10Mattflaschen-WMF) [22:41:22] matt_flaschen, how horrible would it be to have the API response to sources (in xwiki item) also add in the local seen time values for alert/messages ? It already returns source 'definition' in the form of title, api entrypoint, and article entrypoint... that shouldn't be hard to add in the local seenTime value for the requesting user, no? [22:41:37] 10Flow: Feature request: text is auto-saved in flow - https://phabricator.wikimedia.org/T139804#2443203 (10egalvezwmf) [22:43:37] mooeypoo, seems reasonable. There is already timestamp data (ts). I think that is the latest notification time, let me check. [22:46:12] mooeypoo, yeah, ts is 'timestamp of most recent notification'. So that is user-specific notification related timestamp, seems natural to add per-section seen time as well. [22:48:55] * mooeypoo nods [22:49:15] that would help me avoid a redundant api request for each source's local seen time [22:49:32] it would also be good if we add it to the notunreadpages [22:49:36] for the special page [22:52:22] We randomly call getApiEndpoints as an instance method in ApiEchoUnreadNotificationPages even though it's static. [22:52:45] mooeypoo, yeah, we can put it in CrossWikiBase. They both descend from that. [22:53:43] 10Notifications: "Special:Notifications" has a display problem in some languages - https://phabricator.wikimedia.org/T139807#2443252 (10Guycn2) [22:55:03] matt_flaschen, awesomesauce [22:56:43] (03PS1) 10Mooeypoo: [wip^2] Add a SeenTimeModel to handle seenTime in sources [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298105 [23:01:28] (03PS1) 10Mooeypoo: Make sure sidebar titles are under one another in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298107 (https://phabricator.wikimedia.org/T139807) [23:02:31] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: "Special:Notifications" has a display problem in some languages - https://phabricator.wikimedia.org/T139807#2443280 (10Mooeypoo) a:05Amire80>03Mooeypoo Whoops, good find. Thanks for reporting! [23:03:17] mooeypoo, it looks a little more difficult than I thought. It is using db-replicated, which I think is per-wiki. That means we might not be able to do it (other than by doing an internal API request to the other wiki on the server) [23:03:33] mooeypoo, if we used wgMainStash, I think we could get it directly. [23:04:38] matt_flaschen, okay, so I'll start this as if we can't; which means I'll send a request for seenTime along with the request for notifications list.... and we can see if we can figure something out in the future, since that will be a bit of a waste [23:05:04] matt_flaschen, oh, hmmm seen time is not a module, sadly, so I can't request it alongside notifications like I do count [23:05:09] ... can we... change that? [23:05:44] (03CR) 10jenkins-bot: [V: 04-1] [wip^2] Add a SeenTimeModel to handle seenTime in sources [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298105 (owner: 10Mooeypoo) [23:06:16] would be great if I could do props: 'list|count|seentime' and get them all in one go [23:06:43] mooeypoo, oh, doesn't look like there's an API for it at all? [23:06:50] Except for setting it. [23:06:53] yeah actually I just saw there isn't one [23:06:56] meh! [23:07:03] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: "Special:Notifications" has a display problem in some languages - https://phabricator.wikimedia.org/T139807#2443289 (10Guycn2) Thank you for fixing it ;) [23:07:06] wow, uh... ok [23:07:27] matt_flaschen, okay, it is starting to look like making a "basic fix for special notifications" is no longer a small basic fix [23:07:54] ... in light fo that, should I stop work until roan comes back and we all discuss exactly the tech implications of the product decision? [23:08:06] Or maybe I could at least update **only** the local seen time [23:08:11] and not touch the remote ones [23:08:53] mooeypoo, yeah, and if I change it to use $wgMainStash, I have to migrate the existing data. Which is not that big of deal, but it will be a bit of wasted work if we completely change how this works. [23:09:00] (if we end up doing per-notif after all). [23:09:25] mooeypoo, I don't see any downside of updating the local one. It's consistent with what already happens with the popup. [23:12:36] mooeypoo, we can easily add it to ApiEchoNotifications if you want to go ahead and do that. [23:17:53] 10Flow, 10Wikimedia-Site-requests: Give Flow board creation rights automatically to admins on the Konkani Wikipedia - https://phabricator.wikimedia.org/T139226#2443309 (10MarcoAurelio) p:05Triage>03Low [[ https://wikitech.wikimedia.org/wiki/Wikimedia_site_requests | Triaged. ]] [23:19:33] 10Flow, 10Wikimedia-Site-requests: Give Flow board creation rights automatically to admins on the Konkani Wikipedia - https://phabricator.wikimedia.org/T139226#2443312 (10MarcoAurelio) Will this be secure? We've been reported problems at Meta with Flow boards which were stuck, unmovable, etc. [23:22:24] matt_flaschen, that can be good as a first step, I think [23:23:07] matt_flaschen, will that fetch it with the list? or with the source definitions? [23:23:39] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Wikimedia-Site-requests: Give Flow board creation rights automatically to admins on the Konkani Wikipedia - https://phabricator.wikimedia.org/T139226#2443315 (10Mattflaschen-WMF) >>! In T139226#2443312, @MarcoAurelio wrote: > Will this be secure? We've been reported... [23:25:09] mooeypoo, as a first step, I mean just for the local wiki, since that is simple to do performantly. [23:25:30] matt_flaschen, yeah, but that means that it will be in the same response as the list of notifications, right? [23:25:48] Isn't that what ApiEchoNotifications builds? [23:27:44] mooeypoo, actually, I think it would make more sense in the section. [23:27:47] (03PS1) 10Mooeypoo: Use 'uselang' when fetching unread page notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298113 (https://phabricator.wikimedia.org/T139807) [23:27:56] mooeypoo, query.notifications.alert.seentime [23:28:19] Since it already has query.notifications.alert.count if you have the relevant option. [23:28:32] matt_flaschen, awesome -- and if we query both sections, it should also appear, but outside the section, so query.notifications.seentime = { alert: .. , message: .. } [23:28:39] (we do this more often than the other ^^ ) [23:28:57] Actually I don't think we groupbysection anymore at all. When we query both types, we query without grouping [23:29:16] matt_flaschen, I think it is similar to 'count' and 'rawcount' [23:29:29] inside the section the context is the section, outside, it's total/general [23:29:58] mooeypoo, if you query both without grouping, you get: [23:30:00] https://en.wikipedia.org/w/api.php?action=query&format=jsonfm&meta=notifications¬sections=alert|message¬messageunreadfirst=1¬limit=25¬prop=count¬crosswikisummary=1&uselang=en&_=1468020393739 [23:30:11] (that is a manually created URL, but should hopefully be reflective) [23:30:12] I don't see: [23:30:23] query.notifications.count = { alert: .. , message: .. } [23:30:35] I see query.notifications.count = sumOfAlertAndMessage [23:30:40] yeah you get query.notifications = { list: [], rawcount: X, count: "X" } [23:30:43] Which is not relevant here (unless it's the max). [23:30:55] yep [23:31:02] I guess that makes sense for seentime too [23:31:15] if you queried both, you only care about both combined anyways [23:31:21] ... which raises a question btw [23:31:22] ha [23:31:24] omg [23:31:28] Oh, so you do want it max. [23:31:36] I have to go soon, BTW. [23:31:43] But go ahead. [23:31:59] okay, matt_flaschen, consider this horrible scenario: I was in main page and opened ONLY the alerts popup. My seenTime for alerts is *now* but notices it's for, say, three days ago [23:32:14] mooeypoo, the feature is working! [23:32:23] You are clearly understanding the greater urgency of alerts! [23:32:38] I go to Special:Notifications... I query *both* ... if we go with "max" it means all the notifs I didn't see in notices are considered old/seen even though the seentime is the alerts ones [23:32:43] haha [23:32:59] so special page will behave differently than if I went and opened notice popup [23:33:11] because if I didn't go to special page, those notices in popup WOULD be unseen [23:33:16] * mooeypoo 's brain explodes [23:33:43] so if we go with 'global' seen time -- is it global wiki-wide, or wiki-wide-and-type-wide [23:34:02] mooeypoo, yeah, treating all the notices as seen (when really only the old ones are) would be broken, but that is just a special case of the general brokenness. [23:34:16] and if the latter, what do we do in the special page? Update both, but mark the separately by the timestamp of **each** type separately? So in the above scenario, in special notifs page, I'd get only the notices marked as unseen but not the alerts? [23:34:29] matt_flaschen, and by "broken" you mean "by design" [23:35:50] mooeypoo, yeah, I thought about saying that... [23:36:18] mooeypoo, you mean only set the global time to the latest of each type that you see on Special:Notifications? [23:36:38] So if you go to the special page and see 3 notices and 2 alerts, set the global to the latest newly-seen alert and latest newly-seen notice. [23:36:57] And if there is no newly-seen notice, don't mark it? [23:38:00] I think we should still split them up [23:38:29] by type. So, if you go to special page, you will have all alerts already seen (correct) and the notices marked as unseen until you load the page (and then they update both) [23:38:49] so we can do that by continuing the split of the seenTime to alert and message [23:39:17] and in the construction of the data in the controller, when we ask for "getSeenTime" we will have to ask for the specific seen time of the notification type [23:39:19] mooeypoo, so no max, and you do see the highlight for notices, since they are first being seen now? [23:39:27] Yeah, that makes sense, except at that point why not just do it per-notif. [23:39:30] ... matt_flaschen ... I.... think... so [23:39:33] matt_flaschen, exactly [23:39:46] matt_flaschen, but.. yeah. IOkay, honestly at this point we're raising tons of problems for this [23:39:52] i think we should drop it and wait for a proper discussion [23:40:35] Yeah, I agree with you per-notif makes more sense, and RoanKattouw does/did too. I can go ahead and add the property easily to unblock you this weekend, but I don't think we should go too deep in the global path. [23:41:31] matt_flaschen, because, for instance, if we do go by that way (with notices seeming not unseen and alerts are) then we also go into problems with things like filters... if you directly go to a filter (which we will allow soon in the special page, to bookmark a filter) -- then should we continue the behavior there too? That you only see the ones you haven't seen? if so, it's per-notif. If not, then we're basically going with some we [23:41:32] ird behavior unless we consider both popups to have a SINGLE seen time regardless of which you opened first. [23:42:16] mooeypoo, you mean "seeming unseen/seeming newly-seen"? [23:42:26] yeah [23:42:28] unseen code-wise [23:42:36] matt_flaschen, the problem is that we are, right *now*, in the precipice of where to go. Whatever I do in the special page will affect the product direction. If that's the case -- let's just wait to properly discuss it again with all the issues and blockers? [23:42:51] How urgent is the seentime in special notifications? was it badly complained? [23:43:01] mooeypoo, I have no idea, sorry. [23:43:05] can we wait with it until roan gets back and we have a proper discussion with Pau to iron everything out? [23:43:07] I'll ask joe [23:43:21] quiddity, did anyone heavily complain about the seen time issue in special notifications? [23:43:26] mooeypoo, I think jmatazzoni___ considered it somewhat-high, since he sent out an email about it. How hard would it be to just update the local global ones for now? [23:43:47] matt_flaschen, it won't be, I guess [23:44:02] I can update both timestamps [23:44:04] 10Flow: Feature request: text is auto-saved in flow - https://phabricator.wikimedia.org/T139804#2443203 (10Quiddity) The main task is {T96531} (currently in code-review) but this is a separate feature-request idea that is worth keeping separate. (sidenote: as a user, it's best to not try to assign a task to a... [23:44:19] I already *get* the timestamps from the backend through wgEchoSeenTime [23:44:33] And the API already exists. [23:44:36] yeah [23:44:39] I guess I can do that [23:44:54] mooeypoo, if you are blocked on the API let me know (even over the weekend). Otherwise, I will assume not. [23:44:59] I still want to store them in the model, it simplifies a lot of work, but I can ignore whatever isn't local for now [23:45:04] mooeypoo, not that I've seen thus far. (ba dum, tsss.) [23:45:04] * mooeypoo nods [23:45:14] quiddity, my brain just exploded [23:45:17] ;) [23:45:42] I guess it's better than "unread alerts = red badge" debacle [23:45:51] mooeypoo, I missed that? [23:45:57] I had verbal brain ache for a month on that one [23:45:59] Oh, I get it. [23:46:15] every time I asked about read/red stuff, it was accompanied by a grunt [23:46:40] also, I wrote a couple of background-color: read I think... ask Roan. He was laughing. [23:46:52] lol [23:46:58] quiddity, have we got any more feedback since the Notices message change? [23:47:04] Or was it... unnoticed? [23:47:06] nope [23:47:10] >.< [23:47:25] you win, sir, you win. [23:47:30] I am not familiar with that emoticon, which is probably for the best. [23:47:49] >.< emoticon = wince (at least how I use it) [23:48:23] as in, squinting ones eyes in mock pain. [23:48:51] Actually, if we have to revert that due to Massive Outrage, we should just put Unnotice as the commit message. [23:48:53] gchat turns it into a terrible illustration though. [23:50:23] I am crying, guys. [23:51:09] mooeypoo, in amusement, or in mourning at the death of our sense of humor? [23:51:28] mooeypoo, I am still working on the mobile secondary menu bugs, but at least Sauce Labs is now cooperating. [23:51:30] matt_flaschen, I think it's tears of brain matter after my brain imploded. [23:51:39] i don't know what kind of tunnel it was creating before I properly specified my credentials... [23:51:50] Maybe there were old sauce credentials in a config file from before I had to change username. [23:52:03] Anyway, heading out, feel free to ping me especially if you are blocked on backend. [23:52:09] Have a good weekend, all. [23:56:01] 10Notifications: Echo "Recent activity" window shows an empty "grey" highlight - https://phabricator.wikimedia.org/T139721#2440710 (10Mooeypoo) Is this a 3rd party installation or a production wiki? I am not sure what is going on, but there's another issue of the wiki title not showing up in there -- which is a... [23:56:16] have a good weekend matt_flaschen !