[01:01:28] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2432254 (10jmatazzoni) @Trizek-WMF w... [01:17:10] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2432268 (10jmatazzoni) @Mooeypoo, I don't understand the problem. These are essentially titles--as you suggest. S... [01:46:33] (03PS8) 10Mooeypoo: [wip] Add a cog menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [03:49:10] Have a good night, all. [06:43:04] 10Thanks: Allow thanking a user not only for an edit but also for a log (like user right changes, deletions, etc.) - https://phabricator.wikimedia.org/T139443#2432465 (10Pokefan95) [06:43:12] 10Thanks: Allow thanking a user not only for an edit but also for a log (like user right changes, deletions, etc.) - https://phabricator.wikimedia.org/T139443#2432477 (10Pokefan95) p:05Triage>03Lowest [06:43:47] 10Thanks: Allow thanking a user not only for an edit but also for a log entry (like user right changes, deletions, etc.) - https://phabricator.wikimedia.org/T139443#2432465 (10Pokefan95) [06:48:03] 10Thanks, 10MediaWiki-extensions-LogEntry: Allow thanking a user not only for an edit but also for a log entry (like user right changes, deletions, etc.) - https://phabricator.wikimedia.org/T139443#2432482 (10Pokefan95) [07:14:32] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2432498 (10Trizek-WMF) Well, I know t... [08:02:29] 10Thanks, 10MediaWiki-extensions-LogEntry: Allow thanking a user not only for an edit but also for a log entry (like user right changes, deletions, etc.) - https://phabricator.wikimedia.org/T139443#2432538 (10Bugreporter) [08:02:33] 06Collaboration-Team-Interested, 10Thanks, 07User-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2432540 (10Bugreporter) [08:14:58] 06Collaboration-Team-Interested, 10Thanks, 07User-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2432552 (10Pokefan95) I don't think thanking a patrol log entry makes sense. [08:58:21] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#2432600 (10Trizek-WMF) [09:06:25] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation: Rethink how the different types of notifications are displayed on Help:Notifications - https://phabricator.wikimedia.org/T131604#2432609 (10Trizek-WMF) p:05Normal>03Low Lowering. ATM, I plan to... [09:10:42] 06Collaboration-Team-Interested, 10Notifications, 10Collaboration-Community-Engagement: Explore ways to avoid cross-wiki spam from welcome bots - https://phabricator.wikimedia.org/T129904#2432624 (10Trizek-WMF) [10:34:42] 10Flow, 10UI-Standardization, 07Design, 07RfC: Review unsubscribe/unwatch icon - https://phabricator.wikimedia.org/T134752#2432687 (10Pginer-WMF) > The star, in browser context often used as favorite action, in MediaWiki context redefined as “watch” action which is a hybrid of favorite/bookmark and watch s... [10:41:16] (03CR) 10Matthias Mullie: "Sbisson: maintenance/runJobs.php (but that just executes the job, you'll have to add it yourself)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [10:46:33] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Special-pages: Set a max-width for Special:Notifications page - https://phabricator.wikimedia.org/T137425#2432694 (10Trizek-WMF) (Juste to follow up) >>! In T138433#2431644, @jmatazzoni wrote: > As Moriel says, 700 px is a provisional... [10:53:07] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Notifications page: Notification bodies are not truncated - https://phabricator.wikimedia.org/T138433#2432702 (10Pginer-WMF) >>! In T138433#2431... [10:55:06] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Special-pages: Set a max-width for Special:Notifications page - https://phabricator.wikimedia.org/T137425#2432704 (10Pginer-WMF) >>! In T137425#2432694, @Trizek-WMF wrote: > (Juste to follow up) I made a proposal a couple coments above... [11:30:39] 06Collaboration-Team-Interested, 10Flow, 06Community-Liaisons (Jul-Sep-2016): Track Flow activation - https://phabricator.wikimedia.org/T115110#2432780 (10Qgil) [11:35:17] 06Collaboration-Team-Interested, 10Thanks, 07User-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2432782 (10Trizek-WMF) >>! In T60485#2432552, @Pokefan95 wrote: > I don't think thanking a patrol log entry makes sense. As a volunteer, I appreciate to thank someone who takes care... [11:45:20] 06Collaboration-Team-Interested, 10Notifications, 10Collaboration-Community-Engagement: Explore ways to avoid cross-wiki spam from welcome bots - https://phabricator.wikimedia.org/T129904#2432805 (10Qgil) [11:45:27] 10Notifications: Special:Notifications page wider than window when "Recent activity" box is present - https://phabricator.wikimedia.org/T139450#2432807 (10Thryduulf) [11:48:52] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2432822 (10Qgil) [11:48:54] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), and 2 others: Create a general public documentation for Flow (tracking) - https://phabricator.wikimedia.org/T111367#2432821 (10Qgil) [11:49:15] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, and 2 others: Create a general public documentation for Flow (tracking) - https://phabricator.wikimedia.org/T111367#1602419 (10Qgil) [11:57:59] 10Notifications: Special:Notifications page wider than window when "Recent activity" box is present - https://phabricator.wikimedia.org/T139450#2432829 (10SBisson) [11:58:01] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Notifications page: Notification bodies are not truncated - https://phabricator.wikimedia.org/T138433#2432831 (10SBisson) [12:22:06] (03CR) 10Addshore: [C: 04-1] Echo notifications for simple mention failures (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [12:24:25] 10Notifications: Notifications not updated across languages - https://phabricator.wikimedia.org/T139454#2432889 (10CFCF) [12:28:23] 10Notifications: Notifications not updated across languages - https://phabricator.wikimedia.org/T139454#2432901 (10CFCF) [12:29:33] 10Notifications: Notifications not updated across languages - https://phabricator.wikimedia.org/T139454#2432889 (10CFCF) [12:29:54] 10Notifications: Notifications not updated across languages - https://phabricator.wikimedia.org/T139454#2432889 (10CFCF) p:05Triage>03High [12:57:35] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2433018 (10Pginer-WMF) In order to avoid increasing the visual language, as discussed with @rho and @Volker_E we can start by us... [13:31:23] (03PS3) 10Sbisson: Keep bundled notification compact header on one line [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297431 (https://phabricator.wikimedia.org/T139321) [13:45:35] matt_flaschen: let me know when you're around [14:02:44] (03PS1) 10Sbisson: Followup Iae32cbf82cdb: Set width to Special:Notifications [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297594 (https://phabricator.wikimedia.org/T138433) [14:30:03] (03PS16) 10WMDE-Fisch: Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [14:30:57] (03CR) 10WMDE-Fisch: Echo notifications for simple mention failures (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [14:31:12] (03CR) 10WMDE-Fisch: Echo notifications for simple mention failures (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [14:38:14] (03CR) 10jenkins-bot: [V: 04-1] Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [14:43:03] (03PS17) 10WMDE-Fisch: Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [15:18:51] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Notifications page: Notification bodies are not truncated - https://phabricator.wikimedia.org/T138433#2433333 (10jmatazzoni) > I'm not sure if... [15:25:46] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297594 (https://phabricator.wikimedia.org/T138433) (owner: 10Sbisson) [15:29:30] stephanebisson: I cannot switch to your branch with /vagrant/mediawiki/extensions/Echo$ git review -d 297509 [15:29:47] etonkovidova: any error message? [15:30:53] stephanebisson: got: it_review.cmd.CannotQueryPatchSet: Cannot query patchset information [15:31:25] The following command failed with exit code 255 "ssh -xp29418 etonkovidova@gerrit.wikimedia.org gerrit query --format=JSON --current-patch-set change:297509" [15:31:53] etonkovidova: are you inside or outside the VM? [15:32:23] stephanebisson: inside... [15:32:32] try outside maybe? [15:33:08] btw, I saw the counter issue when I added "$wgEchoSectionTransition = $wgEchoBundleTransition = true;" [15:33:45] (03Merged) 10jenkins-bot: Followup Iae32cbf82cdb: Set width to Special:Notifications [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297594 (https://phabricator.wikimedia.org/T138433) (owner: 10Sbisson) [15:34:10] stephanebisson: from outside :fatal: Couldn't find remote ref refs/changes/09/297509/1 [15:46:43] etonkovidova: when outside, where are you in the directory structure? [15:48:48] stephanebisson: was thinking about it hold on - trying now from /Users/etonkovidova/Documents/gerrit/vagrant/mediawiki/extensions/Echo [15:49:13] worked! [15:50:03] stephanebisson: I am " On branch review/sbisson/dont-assume-all" [15:50:56] yes [15:52:07] and the counter is correct :) I will send more alerts/msgs to check - but all looks fine so far [15:56:07] stephanebisson: with the new msgs/alerts sent - the count is still correct - thx! [16:14:38] 10Notifications: Timestamps in cross-wiki notifications are different - https://phabricator.wikimedia.org/T139479#2433528 (10matej_suchanek) [16:17:20] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Notifications page: Notification bodies are not truncated - https://phabricator.wikimedia.org/T138433#2433540 (10Pginer-WMF) >>! In T138433#2433... [16:18:09] 10Notifications: Timestamps in cross-wiki notifications are different - https://phabricator.wikimedia.org/T139479#2433542 (10matej_suchanek) [16:49:14] (03PS1) 10Sbisson: Sort bundled notifications by read status AND timestamp [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297614 [17:10:19] (03PS9) 10Mooeypoo: [wip] Add a cog menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [17:11:58] 06Collaboration-Team-Interested, 10MobileFrontend, 10Parsoid, 06Reading-Web-Backlog: Mobile should not completely blank mediawiki.skinning.content.parsoid - https://phabricator.wikimedia.org/T93968#2433761 (10Jdlrobson) p:05Normal>03Low [17:22:29] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Bundled notifications: The counter for bundled notifications shows sum of notifications of Alerts and Messages. - https://phabricator.wikimedia.org/T139323#2433816 (10SBisson) p:05Triage>03High a:03SBisson [18:23:03] mooeypoo: https://gerrit.wikimedia.org/r/#/c/297431/ [18:23:14] matt_flaschen: https://gerrit.wikimedia.org/r/#/c/297509/ [18:27:58] stephanebisson, so now the top-level count is the total of what you specified, instead of total of ALL. Is there a recommended way for me to test? Anything need to be done before de-WIPing. [18:28:29] stephanebisson, what else should we discuss? As mentioned, I will run backfill scripts on group 1 after train rolls. [18:29:03] matt_flaschen: do run the scripts after the train, everything as planed there [18:30:51] matt_flaschen: about the top level count: it's true that there is a change of behavior, and that makes me uncomfortable. I'll try something else and ping you in a few minutes. etonkovidova has a simple scenario to test it [18:31:28] stephanebisson: I am ready :)) [18:31:39] etonkovidova: what [18:31:54] etonkovidova: what's your test scenario, in it's simplest form? [18:33:10] stephanebisson: one alert and one msg - post on flowusertalk and post on a watched page [18:36:56] 10Flow, 07Regression: [Regression] mw-plusminus text unstyled on Flow history pages - https://phabricator.wikimedia.org/T139503#2434200 (10Krinkle) [18:38:17] 10Flow, 07Regression: [Regression] mw-plusminus text unstyled on Flow history pages - https://phabricator.wikimedia.org/T139503#2434230 (10Krinkle) [18:43:54] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#2434276 (10jmatazzoni) [18:44:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Bundled notifications: The counter for bundled notifications shows sum of notifications of Alerts and Messages. - https://phabricator.wikimedia.org/T139323#2434280 (10SBisson) How to reproduce: # Create a new user # Write on the newly created user's talk pag... [18:44:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [mobile] The dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393#2434281 (10jmatazzoni) a:03Mattflaschen-WMF [18:45:12] etonkovidova, matt_flaschen there test case is here: https://phabricator.wikimedia.org/T139323#2434280 [18:45:50] 06Collaboration-Team-Interested, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2279822 (10Quiddity) See also: {T110731} and Related or duplicate? {T139454} [18:45:52] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Special:Notifications page has wrong sorting order after messages are 'Marked as unread' - https://phabricator.wikimedia.org/T136885#2434289 (10jmatazzoni) a:03Mooeypoo [18:46:09] stephanebisson: that's right [18:47:42] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2434293 (10jmatazzoni) [18:50:08] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2434298 (10Whatamidoing-WMF) This is half-fixed. Clicking on this blue dot at Meta: {F4245423} ta... [18:55:09] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2279822 (10jmatazzoni) **Update from Leads Meeting 7/6/16** We had a long discussion about this in the leads meeting. Some salient points from that discussion:... [18:56:46] (03PS2) 10Sbisson: Notification count: don't assume 'all' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297509 [18:57:16] stephanebisson, will be back in 15-20. Provisioning right now. I'll try to reproduce the brokenness first, then test the WIP. Let me know if you decide to de-WIP it or do another patch. [18:58:01] matt_flaschen: after looking at it some more I think it's correct: if you ask for section: 'alert' and groupbysection: 0, you just don't receive a structure like { alert: {}, message: {} } so youexpect the top level data to contain what you asked for [18:58:07] matt_flaschen: I have de-WIP [19:04:01] (03CR) 10Matěj Suchánek: Allow self mentions (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore) [19:13:55] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2434391 (10jmatazzoni) I'm still not seeing it. @Whatamidoing-WMF, would you mind trying this on the... [19:17:57] is meta in group 1? [19:23:27] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: When a user only has foreign notifications, the special page shows "You have no notifications." - https://phabricator.wikimedia.org/T139512#2434427 (10SBisson) [19:26:36] (03PS1) 10Sbisson: Special:Notifications JS even when no local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297633 (https://phabricator.wikimedia.org/T139512) [19:31:01] stephanebisson, yes. Everything is in group 1, except group 0 and most of the Wikipedias. [19:31:07] (A couple Wikipedias are in group 1). [19:31:38] See group1.dblist in operations/mediawiki-config [19:47:59] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Notifications page: Notification bodies are not truncated - https://phabricator.wikimedia.org/T138433#2434580 (10Etonkovidova) Checked in betala... [19:59:10] 03Collab-Team-Q1-July-Sep-2016, 10Notifications: Change tooltip 'Your messages' to 'Your notices' - https://phabricator.wikimedia.org/T139520#2434608 (10Etonkovidova) [20:01:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Unread notifications are not always at the top of the flyout/popup - https://phabricator.wikimedia.org/T139521#2434637 (10SBisson) [20:02:16] (03PS2) 10Sbisson: Sort bundled notifications by read status AND timestamp [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297614 (https://phabricator.wikimedia.org/T139521) [20:15:30] mooey|lunch: when you're back, can I ask you to review https://gerrit.wikimedia.org/r/#/c/297431/ ? I would like to have it merged and deployed tomorrow morning. thanks! [20:29:51] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Design, 07Tracking: Design adjustments for the Notifications Page - https://phabricator.wikimedia.org/T136567#2434774 (10jmatazzoni) [20:29:53] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 05WMF-deploy-2016-07-12_(1.28.0-wmf.10): Notifications page: Notification bodies are not truncated - https://phabricator.wikimedia.org/T138433#2434773 (10jmatazzoni) 05Open>03Resolved [20:36:10] stephanebisson, on it [20:42:41] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: Notification Page doesn't display properly in mobile - https://phabricator.wikimedia.org/T139525#2434810 (10jmatazzoni) [20:44:02] (03PS4) 10Mooeypoo: Keep bundled notification compact header on one line [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297431 (https://phabricator.wikimedia.org/T139321) (owner: 10Sbisson) [20:44:35] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Design, 07Tracking: Design adjustments for the Notifications Page - https://phabricator.wikimedia.org/T136567#2434834 (10jmatazzoni) [20:44:38] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Special-pages: Set a max-width for Special:Notifications page - https://phabricator.wikimedia.org/T137425#2434829 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni This ticket was dealt with in T138433, so I'm closing this. However,... [20:46:28] stephanebisson, mooeypoo, I can monitor SWAT for anything that is ready tonight (4 PM Pacific). [20:51:55] mooeypoo, not urgent, but I am waiting on your response on one of the GuidedTour patches: https://gerrit.wikimedia.org/r/#/c/280366/ . [20:54:52] (03CR) 10Mooeypoo: [C: 032] "The problem of table-layout ignoring the width of its parent(s) is annoying, but this patch works as intended. WFM." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297431 (https://phabricator.wikimedia.org/T139321) (owner: 10Sbisson) [20:54:58] stephanebisson, meh, I don't understand why setting the width on the group doesn't work here (like we do in special page) but it seems to not :\ [20:55:13] Stupid weird. It works in the special page, but not here. what the hell. [21:00:52] (03Merged) 10jenkins-bot: Keep bundled notification compact header on one line [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297431 (https://phabricator.wikimedia.org/T139321) (owner: 10Sbisson) [21:03:10] matt_flaschen, awesome, I think stephanebisson said he wants that in SWAT https://gerrit.wikimedia.org/r/#/c/297431/ [21:04:51] (03PS3) 10Mattflaschen: Notification count: don't assume 'all' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297509 (https://phabricator.wikimedia.org/T139323) (owner: 10Sbisson) [21:08:21] (03PS10) 10Mooeypoo: [wip] Add a cog menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [21:12:54] matt_flaschen, I have split my commit to two, but I want to change the order of them (so the one that's "on top" shoudl be below) -- I don't remember how to do that, though... that's git rebase -i right? [21:14:09] mooeypoo, yes: http://gitready.com/advanced/2009/03/20/reorder-commits-with-rebase.html [21:14:16] thanks! wasn't sure [21:14:41] (03PS11) 10Mooeypoo: [wip] Add a cog menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [21:14:44] (03PS1) 10Mooeypoo: Properly aggregate the itemUpdate event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297694 [21:14:58] mooeypoo, that commit only needs to be on the new branch (wmf9), right? [21:15:36] matt_flaschen, whatever is going out to production [21:15:40] I forget which one that is [21:16:00] mooeypoo, yeah, I mean the branch that started in production yesterday, and is rolling out further today. [21:16:06] yup [21:16:33] (03PS1) 10Mattflaschen: Keep bundled notification compact header on one line [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297695 (https://phabricator.wikimedia.org/T139321) [21:36:16] 10Notifications, 07Wikimedia-log-errors: Array must contain at least one element in ApiEchoNotifications. php on line 341 - https://phabricator.wikimedia.org/T139529#2434975 (10MaxSem) [21:39:27] etonkovidova, https://phabricator.wikimedia.org/T139526 might be the cause of the "thank for the first edit" exception you saw. [21:40:46] matt_flaschen: hmm... maybe. But https://phabricator.wikimedia.org/T139526 seems more major. [21:42:18] matt_flaschen: btw, I see many of DifferenceEngine->generateContentDiffBody(Flow\Content\BoardContent errors when I try to restore deleted pages [21:42:42] but I guess it's another story - will look into it tomorrow, maybe [21:44:18] etonkovidova, let's wait until T139526 is done, since that may be the cause of both. [21:44:19] T139526: Catchable fatal error: Argument 1 passed to DifferenceEngine::generateContentDiffBody() must implement interface Content, null given - https://phabricator.wikimedia.org/T139526 [21:44:37] matt_flaschen: yup, agree [21:45:09] etonkovidova, they're both major. The one you filed (https://phabricator.wikimedia.org/T139435#2432216) has "Our servers are currently experiencing a technical problem. This is probably temporary and should be fixed soon". You should never see that. [21:45:49] 10Notifications: edit-thank for new page creation results in a notification that redirects to the Error page. - https://phabricator.wikimedia.org/T139435#2432216 (10Mattflaschen-WMF) Hopefully caused by {T139526}. After that is fixed, re-test and merge duplicate if this is also fixed. [21:46:19] matt_flaschen: well, let's hope that https://phabricator.wikimedia.org/T139526 miraculously fixes that [21:46:46] I think it will at least fix the thanks one, maybe both. [21:47:31] matt_flaschen: I made a note to keep an eye on the fix and follow up [22:00:17] stephanebisson, I can't reproduce https://phabricator.wikimedia.org/T139323#2434280 : On 4d5e4505dffd906943ce97188c3978f98afeac81 it already works. [22:00:42] Will retry on latest master with a new user (I was having some unrelated issues due to out of date code in various extensions). [22:03:29] matt_flaschen: I still see it for old users too [22:05:05] matt_flaschen: forgot to mention, you need the transition variables set to true for the problem to happen [22:05:21] stephanebisson, ahg, darn, should have thought of that. [22:05:23] Thanks. [22:05:34] matt_flaschen: stephanebisson: events 'gettingstarted-continue-editing' and 'gettingstarted-start-editing' in echo_event - are they deprecated? [22:06:01] etonkovidova: no idea what that is [22:06:22] matt_flaschen: also, thanks for SWATing that UI change out (the one that Moriel merged) [22:06:30] No problem [22:06:48] stephanebisson: when you see distinct event_type in echo_event - those come up among other [22:07:48] etonkovidova: I see, but I don't know where they're coming from [22:08:03] etonkovidova, yes, I removed those notification types years ago. [22:08:19] matt_flaschen: kk [22:09:13] (They were in the GettingStarted extension.) [22:13:35] (03CR) 10Mattflaschen: [C: 032] Notification count: don't assume 'all' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297509 (https://phabricator.wikimedia.org/T139323) (owner: 10Sbisson) [22:16:46] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, and 2 others: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2435279 (10Etonkovidova) Checked the new categorization of notifications as part of genera... [22:20:47] (03Merged) 10jenkins-bot: Notification count: don't assume 'all' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297509 (https://phabricator.wikimedia.org/T139323) (owner: 10Sbisson) [22:20:52] (03PS12) 10Mooeypoo: Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [22:21:02] 10Notifications, 07Wikimedia-log-errors: Undefined property: stdClass::$event_deleted in Event.php - https://phabricator.wikimedia.org/T139536#2435307 (10MaxSem) [22:21:24] stephanebisson, ^^ I think this came out a little less clunky-code than I originally thought, but there were several things I did to the counter that I hope you don't cringe at... [22:21:48] (03PS8) 10Mooeypoo: Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) [22:22:27] (03PS1) 10Mattflaschen: Notification count: don't assume 'all' [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297707 (https://phabricator.wikimedia.org/T139323) [22:25:21] stephanebisson, scheduled the "don't assume 'all'" for evening SWAT today as well. [22:28:07] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Special:Notifications page has wrong sorting order after messages are 'Marked as unread' - https://phabricator.wikimedia.org/T136885#2435346 (10Mooeypoo) I can't reproduce this anymore... I tried over and over, and it doesn't happen for me... [22:28:09] etonkovidova, I can't reproduce this :\ [22:28:38] (03CR) 10jenkins-bot: [V: 04-1] Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [22:28:50] I tried everything. Over and over marking read and unread in multiple pages, at the end of the list, marking entire days as unread and then read... the chronological order remains properly organized. https://phabricator.wikimedia.org/T136885 [22:30:01] (03CR) 10Mooeypoo: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [22:33:16] (03PS13) 10Mooeypoo: Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [22:33:34] 10Flow, 10Pywikibot-Flow, 10MediaWiki-API: Broken topics on test wiki that the API doesnt believe exists - https://phabricator.wikimedia.org/T138306#2396549 (10Mattflaschen-WMF) They're working topics, but MW thinks the page does not exist? Maybe FlowUpdateWorkflowPageId.php needs to be run. [22:37:17] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2435411 (10Mooeypoo) >>! In T137634#2432268, @jmatazzoni wrote: > @Mooeypoo, I don't understand the problem. Thes... [22:42:09] I'm going to a dr's appointment, I'll be back to working on the rest of the pending stuff after I get back [22:45:15] stephanebisson, could you review https://gerrit.wikimedia.org/r/#/c/294174/ ? [22:46:31] 10Flow, 07Regression: Reloading Flow page shows two text fields for 'Start a new topic' - https://phabricator.wikimedia.org/T139429#2435474 (10Danny_B) [22:51:15] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2435482 (10jmatazzoni) @Amire80, can you please have a look at this? If we treat the day names in the screenshot... [22:54:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, and 2 others: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2435497 (10jmatazzoni) @Etonkovidova, did the "Messages" menu get re-labeled as "Notices"? [22:57:04] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, and 2 others: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2435512 (10Etonkovidova) @jmatazzoni I filed the re-labelling issues as {T139520} [23:17:26] (03CR) 10Legoktm: [C: 032] Keep bundled notification compact header on one line [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297695 (https://phabricator.wikimedia.org/T139321) (owner: 10Mattflaschen) [23:17:29] (03CR) 10Legoktm: [C: 032] Notification count: don't assume 'all' [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297707 (https://phabricator.wikimedia.org/T139323) (owner: 10Mattflaschen) [23:18:53] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, and 2 others: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2435591 (10jmatazzoni) > I filed the re-labelling issues as T139520: Change tooltip 'Your... [23:26:27] (03Merged) 10jenkins-bot: Keep bundled notification compact header on one line [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297695 (https://phabricator.wikimedia.org/T139321) (owner: 10Mattflaschen) [23:26:32] (03Merged) 10jenkins-bot: Notification count: don't assume 'all' [extensions/Echo] (wmf/1.28.0-wmf.9) - 10https://gerrit.wikimedia.org/r/297707 (https://phabricator.wikimedia.org/T139323) (owner: 10Mattflaschen) [23:29:35] (03CR) 10Mattflaschen: [C: 032] Replace symbolic link with partial [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295468 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [23:34:21] (03CR) 10Mattflaschen: [C: 032] Use VisualEditorSupportCheck [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295462 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [23:35:13] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): wikitext pages: Mention notifications prepend section title to text excerpts - https://phabricator.wikimedia.org/T134922#2435634 (10Etonkovidova) @SBisson 1) According to [[ https://docs.google.com... [23:35:55] (03Merged) 10jenkins-bot: Replace symbolic link with partial [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295468 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [23:49:35] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Status filter should not become disabled between status change in the Notification Page - https://phabricator.wikimedia.org/T136895#2351420 (10Etonkovidova) Checked the fix in betalabs - the selected...