[00:03:05] 10Collab-Notifications-Page: Special:Notifications page filter should load the "unread" filter when clicked - https://phabricator.wikimedia.org/T139134#2420503 (10Mooeypoo) [00:19:33] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2420544 (10Mooeypoo) There are some usability issues that arose when I added the 'mark all as read' button that we should discuss: - When... [00:21:01] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2420545 (10Mooeypoo) By the way - it may be that we'd like to separate this task (or commit, for that matter) to two pieces: - The cog men... [08:29:10] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work - https://phabricator.wikimedia.org/T139147#2420802 (10Trizek-WMF) [08:50:17] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2420828 (10Pginer-WMF) Thanks for your comments @Mooeypoo. Some ideas below: As mentioned in T115528#2404250, the main usecase we want to... [09:30:44] 10Collab-Notifications-Page: Special:Notifications page filter should load the "unread" filter when clicked - https://phabricator.wikimedia.org/T139134#2420866 (10Pginer-WMF) Changing the filters automatically for the user has the risk of generating confusion. We cannot always anticipate the user intent, so I th... [09:53:19] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2420913 (10Qgil) [09:53:57] (03CR) 10VolkerE: [C: 04-1] Clean up Special:Notifications output (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [09:56:00] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2420802 (10Qgil) It works for me on Chrome 49.0.2623.108. Maybe a screenshot would help. It sounds like the div or cli... [11:00:28] (03PS13) 10WMDE-Fisch: WIP Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [11:06:14] (03CR) 10WMDE-Fisch: "thanks again for the reviews" (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [11:35:18] 10Flow: Flow should warn me if new messages are posted when I'm replying - https://phabricator.wikimedia.org/T139155#2421093 (10Trizek-WMF) [11:56:26] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Display page-less notifications together with the user page - https://phabricator.wikimedia.org/T137502#2421179 (10Pginer-WMF) >>! In T137502#2409862, @Catrope wrote: > @Pginer-WMF @jmatazzoni How does this look? > > {F4206487}... [12:22:07] 10Notifications, 07JavaScript: Marking notification as read causes "TypeError: sourceModel is null" - https://phabricator.wikimedia.org/T139114#2421220 (10He7d3r) [12:23:31] 10Notifications, 07JavaScript: Marking notification as read causes "TypeError: sourceModel is null" - https://phabricator.wikimedia.org/T139114#2419894 (10He7d3r) [13:29:28] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07JavaScript: Marking notification as read causes "TypeError: sourceModel is null" - https://phabricator.wikimedia.org/T139114#2421281 (10Catrope) p:05Triage>03Unbreak! a:03Mooeypoo [13:30:50] 03Collab-Team-2016-Apr-Jun-Q4: [regression-betalabs] 'Failed to fetch notifications' - https://phabricator.wikimedia.org/T139112#2421290 (10Catrope) p:05Triage>03Unbreak! [13:43:12] (03CR) 10Catrope: [C: 032] Pad the content so it doesn't stretch beyond the markread button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296843 (https://phabricator.wikimedia.org/T136572) (owner: 10Mooeypoo) [13:51:02] (03Merged) 10jenkins-bot: Pad the content so it doesn't stretch beyond the markread button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296843 (https://phabricator.wikimedia.org/T136572) (owner: 10Mooeypoo) [13:51:11] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2420802 (10Catrope) If she uses Safari it's very plausible that this is a CSS issue / browser bug. If I get a chance la... [14:09:34] 10Notifications: Mark read revisions as read (alert popup) - https://phabricator.wikimedia.org/T139122#2421338 (10Trizek-WMF) [14:09:36] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2421340 (10Trizek-WMF) [14:10:27] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2420802 (10Trizek-WMF) >>! In T139122, @IKhitron wrote: > Hello. It's about a week that opening alert does not mark al... [14:12:13] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2421352 (10IKhitron) Hello, @Trizek-WMF? Why do you think this task has somethinh with T139122? This one is a bug. That... [14:44:35] 06Collaboration-Team-Interested, 10Notifications: Use accessible colors for the read status of the mark as read markers of notifications - https://phabricator.wikimedia.org/T139167#2421450 (10Pginer-WMF) [14:45:23] 06Collaboration-Team-Interested, 10Notifications: Use accessible colors for the read status of the mark as read markers of notifications - https://phabricator.wikimedia.org/T139167#2421468 (10Pginer-WMF) [14:45:25] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Design, 07Tracking: Design adjustments for the Notifications Page - https://phabricator.wikimedia.org/T136567#2421467 (10Pginer-WMF) [14:47:50] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2420802 (10CKoerner_WMF) Here is a short demo showing how the notification "unread" dot, when showing a notification fr... [14:56:47] (03CR) 10Matěj Suchánek: "If it's annoying to get long comments and read some concerns about things that can happen once in a live at most, please tell me, I don't " (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [15:00:58] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2421556 (10Trizek-WMF) >>! In T139147#2421352, @IKhitron wrote: > Hello, @Trizek-WMF? Why do you think this task has so... [15:01:32] 10Notifications: Mark read revisions as read (alert popup) - https://phabricator.wikimedia.org/T139122#2421558 (10Trizek-WMF) 05duplicate>03Open Repoening. I've misunderstood that task. [15:02:53] 10Notifications: Mark read revisions as read (alert popup) - https://phabricator.wikimedia.org/T139122#2421560 (10IKhitron) Thanks. [15:05:09] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2421563 (10Whatamidoing-WMF) I'm currently running Safari Version 9.1.1 (10601.6.17) on Mac OS 10.10.5 (14F1808). [15:19:51] 06Collaboration-Team-Interested, 10Notifications, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Revert notifications in Echo on Wikidata should display label as well as Q id - https://phabricator.wikimedia.org/T116762#1757478 (10Daniel_Mietchen) Yes, showing just the Q number is not very useful in... [15:48:01] 10Flow: Exceptions for flow api requests are not caught - https://phabricator.wikimedia.org/T139175#2421651 (10Mainframe98) [16:31:29] 03Collab-Team-Q1-July-Sep-2016, 10Notifications, 07JavaScript: Marking notification as read causes "TypeError: sourceModel is null" - https://phabricator.wikimedia.org/T139114#2419894 (10Etonkovidova) Stack trace in betalabs for clicking on 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2421949 (10Mooeypoo) Awesome, thanks @Pginer-WMF ! So I think this button goes as a sort of "in context mark-all-read" which means you ma... [17:53:44] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Apr-Jun-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2422225 (10Trizek-WMF) p:05Normal>... [17:56:59] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Apr-Jun-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2422261 (10Trizek-WMF) We have the fo... [17:57:24] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#2422262 (10Trizek-WMF) [18:15:03] 03Collab-Team-2016-Apr-Jun-Q4: [regression-betalabs] 'Failed to fetch notifications' - https://phabricator.wikimedia.org/T139112#2422285 (10Etonkovidova) [18:24:58] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): Make notification styling on the Notifications Page closer to the ones in the panel - https://phabricator.wikimedia.org/T136572#2422313 (10Etonkovidova) Checked in betalabs - the padding... [18:49:33] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested: Mark notifications as read/unread with blue dot does not work in some circumstances - https://phabricator.wikimedia.org/T139147#2420802 (10Capt_Swing) I believe I've experienced the same issue as @Ckoerner_WMF, although it happened fast and I have... [19:03:56] matt_flaschen: Hi Matt.. are you around? [19:04:17] RoanKattouw: Hi Roan.. are you around? [19:04:22] I'm here [19:04:39] Matt's on vacation today, but he'll be back on Tuesday. I'm going on vacation in about an hour :) [19:04:45] RoanKattouw: How're you doing? [19:04:45] How can we help you? [19:05:16] Good considering my flight was canceled :| but they rerouted me so I'm still gonna make it [19:05:18] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2422461 (10Danny_B) a:03Mooeypoo [19:05:46] I wanted to create a flow page on gomwiki in namespace MediaWiki but I received a message to the effet: User does not have permission to create flow boards in any location [19:05:49] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2373795 (10Danny_B) [19:05:49] I'm an admin [19:06:29] sorry [19:06:39] RoanKattouw: in namespace wikipedia [19:06:52] RoanKattouw: not mediawiki [19:07:21] Oh, right [19:07:28] For now I can create it for you [19:07:34] But we can probably just give that right to admins on gomwiki [19:08:14] giving the right would make sense.. considering you guys are going on vacation :D [19:08:37] So if you tell me the page name, I'll create it right now, and if you file a bug asking for admins to have flow creation rights, I'll write a patch for that too [19:08:55] You'll probably have to wait till Tuesday (because Monday is a US holiday) to get that patch deployed though [19:08:59] Matt will be back then [19:10:52] RoanKattouw: Please can you move gom.wikipedia.org/wiki/Wikipedia:समुदाईक_प्रवेस-द्वार to gom.wikipedia.org/wiki/Wikipedia:Tinto with associated talkpages and subpages [19:11:07] RoanKattouw: Reason: As per [[Topic:T5oynqrlbs8clg88]] [19:12:15] RoanKattouw: And please leave a redirect behind [19:12:46] The_Discoverer: Done. I didn't move the subpage but since that's wikitext you should be able to move it yourself [19:14:15] RoanKattouw: Thanks a lot.. as for the bug request, does it have to be gomwiki specific, or general? [19:14:28] gomwiki -specific for nwo [19:15:48] ok.. i'll file the bug tomorrow... considering that your vacation begins in an hour [19:16:23] RoanKattouw: Enjoy your vacation, mate.. you've earned it [19:17:13] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Too long line for secondary actions results in adding a horizontal scroll bar - https://phabricator.wikimedia.org/T126617#2422478 (10Etonkovidova) Checked (along with {T125949}) - no horizontal scroll bar is dis... [19:18:16] (03PS1) 10Catrope: ApiEchoNotifications: Don't add wikis with no timestamp [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296956 (https://phabricator.wikimedia.org/T139112) [19:18:23] The_Discoverer: Thanks man [19:19:03] RoanKattouw: Bye.. over and out [19:19:15] If nobody responds to your bug, remind Matt about it some time next week. He's back on the 5th but he'll probably be busy catching up from his vacation too [19:19:32] mooeypoo: Can I haz CR? https://gerrit.wikimedia.org/r/296956 [19:19:51] mooeypoo: (The patch is a bit unintuitive, I can explain it if you like) [19:21:18] RoanKattouw, oh hai! [19:21:22] aren't you on vacation? [19:21:26] Almost [19:21:27] * mooeypoo shall review after lunch [19:21:35] I'm at Frankfurt airport, my flight is in an hour [19:21:43] ... [19:21:58] I was supposed to go through Munich but my flight was canceled and I was rerouted [19:22:12] oops [19:22:18] Taking advantage of a long layover here to get some UBN bugs squared away :) [19:22:24] RoanKattouw, wait, I'm looking at the one-word patch and I'm confused [19:22:30] I thought you would be [19:22:43] The place where things actually break is line 372 [19:22:49] usort( $wikis, function ( $a, $b ) use ( $section, $timestampsByWiki ) { etc etc [19:22:54] It sorts $wikis by timetasmp [19:23:05] ah! it was "getTimestamp" not getTitle, hee [19:23:07] So it is important that there aren't any entries in $wikis that have no timestamp [19:23:16] I saw it on etonk_lunch computer, but only "getTi" and assumed it was titles [19:23:19] If $wikis = array_keys( $timestamps ); then this is guaranteed [19:23:29] The only way it was built, it could contain timestamples wikis [19:23:39] * mooeypoo nods [19:23:44] why would a wiki have no timestamp though? [19:24:27] RoanKattouw, I can't test this because i can't reproduce it. Sounds good and it looks like it should work, so I'm +2ing or do you want me to insist on testing somehow? [19:25:04] I also can't [19:25:23] But due to weirdness in the transition code it can happen [19:25:34] ok I'll +2 and let etonk_lunch test it [19:25:35] If you read the if transition block above, you can see a case [19:25:49] (03CR) 10Mooeypoo: [C: 032] ApiEchoNotifications: Don't add wikis with no timestamp [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296956 (https://phabricator.wikimedia.org/T139112) (owner: 10Catrope) [19:25:59] Yeah, I saw that. hm. [19:26:08] I'm trying to figure out how to solve some issues with the mark all read button [19:26:39] since it's disconnected completely from the inbox widget, I'm having an issue making it update based on mark read/unread of individual notifications and loading of the pages, so it can display when it should. [19:26:45] I'm going to have to come up with a new strategy :\ [19:27:14] RoanKattouw, though honestly, I still think it is better *behavior* if it was inside the widget rather than in a disconnected cog menu, but I defer to pau's judgment. [19:27:21] anyways, lunch [19:31:27] 06Collaboration-Team-Interested, 10Notifications, 10UI-Standardization, 07Accessibility, 03UI-Standardization-Kanban: Use accessible colors for the read status of the mark as read markers of notifications - https://phabricator.wikimedia.org/T139167#2422521 (10Volker_E) [19:32:26] (03Merged) 10jenkins-bot: ApiEchoNotifications: Don't add wikis with no timestamp [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296956 (https://phabricator.wikimedia.org/T139112) (owner: 10Catrope) [19:58:43] 10Notifications, 10MediaWiki-Vagrant: Echo Vagrant role should not include centralauth - https://phabricator.wikimedia.org/T139203#2422575 (10Tgr) T124707 seems related. [20:12:22] 06Collaboration-Team-Interested, 10Notifications, 10MediaWiki-Email: Send a notification when someone else edits your userpage - https://phabricator.wikimedia.org/T3876#2422592 (10Danny_B) [20:16:49] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): Accessibility of diff pages from Notifications - https://phabricator.wikimedia.org/T131631#2422606 (10Etonkovidova) Checked in betalabs - 'View changes' is added to the dotdotdot menu options for -... [21:00:34] 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07Regression, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): [regression-betalabs] 'Failed to fetch notifications' - https://phabricator.wikimedia.org/T139112#2422685 (10Danny_B) [21:20:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Easy, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): Use the pointer cursor when hovering the cross-wiki bundle element - https://phabricator.wikimedia.org/T138913#2413813 (10Etonkovidova) Checked the fix in betalabs. [22:12:46] (03PS4) 10Mooeypoo: [wip] Add a cog menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [22:13:43] (03CR) 10Mooeypoo: Clean up Special:Notifications output (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [22:13:50] (03CR) 10Mooeypoo: Clean up Special:Notifications output (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [22:17:42] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add a cog menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [22:17:45] (03PS7) 10Mooeypoo: Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) [23:56:38] 03Collab-Team-Q1-July-Sep-2016, 10Flow: Flow pages: better warning info/handling for edit conflicts - https://phabricator.wikimedia.org/T139219#2423118 (10Etonkovidova) [23:57:44] finished for today :)