[07:06:04] 10Flow, 10Analytics, 06Editing-Analysis, 06Editing-Department, 10MediaWiki-Page-editing: statistics about edit conflicts according to page type - https://phabricator.wikimedia.org/T139019#2416933 (10Amire80) [07:07:51] 06Collaboration-Team-Interested, 10Flow, 10Analytics, 06Community-Tech, and 3 others: statistics about edit conflicts according to page type - https://phabricator.wikimedia.org/T139019#2416945 (10Amire80) Tagging also Collaboration-Team and Community-Tech with the hope that it will interest them. Again, fe... [07:08:18] 06Collaboration-Team-Interested, 10Flow, 10Analytics, 06Community-Tech, and 3 others: statistics about edit conflicts according to page type - https://phabricator.wikimedia.org/T139019#2416947 (10Amire80) [07:09:23] 06Collaboration-Team-Interested, 10Flow, 10Analytics, 06Community-Tech, and 3 others: statistics about edit conflicts according to page type - https://phabricator.wikimedia.org/T139019#2416933 (10Amire80) [07:11:42] 06Collaboration-Team-Interested, 10Flow, 10Analytics, 06Community-Tech, and 6 others: statistics about edit conflicts according to page type - https://phabricator.wikimedia.org/T139019#2416949 (10Amire80) Finally, tagging TCB-Team, German-Community-Wishlist and Community-Wishlist-Survey, because this task... [09:49:11] 10Notifications, 06TCB-Team: User should not get a mention notification when linked to with a fragment - https://phabricator.wikimedia.org/T139025#2417162 (10WMDE-Fisch) [10:01:04] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Remove automatic mark-as-read (of alerts) when you open the popup - https://phabricator.wikimedia.org/T132525#2417228 (10IKhitron) Hello? Anyone? It's still a serious bug. [10:12:33] 06Collaboration-Team-Interested, 10Notifications: Echo's 'seen time' should be replaced with marking specific notifications as seen - https://phabricator.wikimedia.org/T110731#2417256 (10Pginer-WMF) The highlight provides a visual cue on which are the new notifications among those that are unread. When the bad... [10:21:44] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Remove automatic mark-as-read (of alerts) when you open the popup - https://phabricator.wikimedia.org/T132525#2201485 (10matej_suchanek) >>! In T132525#2417228, @IKhitron wrote: > He... [10:35:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Remove automatic mark-as-read (of alerts) when you open the popup - https://phabricator.wikimedia.org/T132525#2417346 (10IKhitron) Exactly, @matej_suchanek. But from this deployment... [11:53:00] (03CR) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [11:53:03] (03PS17) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [11:54:52] (03CR) 10jenkins-bot: [V: 04-1] Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [12:00:44] (03PS18) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [12:04:23] (03PS11) 10WMDE-Fisch: WIP Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [12:22:05] 10Notifications: Allow lists longer than 50 notifications on Special:Notifications - https://phabricator.wikimedia.org/T139037#2417626 (10Daniel_Mietchen) [12:27:36] 10Notifications: "Mark ALL notifications as read" button - https://phabricator.wikimedia.org/T139038#2417645 (10Daniel_Mietchen) [12:30:14] 10Notifications: Allow users to find out what precise number of notifications they have - https://phabricator.wikimedia.org/T139039#2417660 (10Daniel_Mietchen) [12:31:47] 10Notifications: "Mark group as read" should trigger removal of currently displayed notifications on Special:Notifications in "unread" mode - https://phabricator.wikimedia.org/T139041#2417688 (10Daniel_Mietchen) [13:31:18] (03PS2) 10Sbisson: Cleanup old notification formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296641 (https://phabricator.wikimedia.org/T121612) [13:35:41] (03CR) 10jenkins-bot: [V: 04-1] Cleanup old notification formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296641 (https://phabricator.wikimedia.org/T121612) (owner: 10Sbisson) [13:38:41] (03PS3) 10Sbisson: Cleanup old notification formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296641 (https://phabricator.wikimedia.org/T121612) [14:41:12] (03PS2) 10Addshore: Allow self mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) [14:42:37] (03CR) 10Addshore: "Okay, resubmitting for review to get some opinions on the i18n situation and if we do need new messages." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore) [14:46:01] (03PS4) 10Sbisson: Cleanup old notification formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296641 (https://phabricator.wikimedia.org/T121612) [14:53:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2418194 (10matthiasmullie) I've tried dumping `--full` on my machine (with enwiki dataset) and on tin, and consistently get around 70-80... [14:57:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2418197 (10ArielGlenn) Enwiki isn't a problem, mediawikiwiki is. Can you try that one? [15:05:30] (03CR) 10Sbisson: "Mentions have detailed messages to give a preview of the context and help the user evaluate the priority of dealing with the event that ca" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore) [15:07:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2418277 (10matthiasmullie) Oh god, I misread. Yes, I'll try that one! [15:09:48] (03CR) 10Addshore: "@Sbisson If 1 message will do then that is great news!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore) [15:09:59] (03CR) 10Sbisson: "Do you have a way to manually trigger the job for testing?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [15:16:49] (03CR) 10Sbisson: "@Addshore: I think 1 message is enough but it would be great to have other opinions on this. Maybe ask on the phab task?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore) [15:17:42] Who is Sbisson on IRC? :P [15:17:49] me [15:18:09] ahh :D [15:18:53] So I quickly looked at the presentation model classes and there doesn't appear to be a way to see if the agent and the receiver is the same person there, as there isn't a way to see who it is being sent to? or am I missing something? [15:19:08] let me check [15:19:15] Thats the reason I jumped for the formatter instead [15:23:05] I have to dash out for 30 mins to 1 hour but I will read the scrollback when I get back! [15:23:09] addshore: maybe create a "getUser()" to expose the private $user (or make it protected), then you can compare it with "$this->event->getAgent()" [15:23:17] sure, no prob [15:27:04] (03PS12) 10WMDE-Fisch: WIP Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [15:54:10] (03PS5) 10Sbisson: Cleanup old notification formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296641 (https://phabricator.wikimedia.org/T121612) [15:54:32] (03CR) 10Sbisson: "Yes, I removed the icons, thank you!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296641 (https://phabricator.wikimedia.org/T121612) (owner: 10Sbisson) [16:48:37] (03CR) 10Matěj Suchánek: WIP Echo notifications for simple mention failures (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [18:05:03] (03CR) 10Catrope: [C: 031] "You're deprecating the entry points, but do they even work now that you've deleted all the other files?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296641 (https://phabricator.wikimedia.org/T121612) (owner: 10Sbisson) [18:08:53] (03CR) 10Sbisson: "I have tried to remove files used by the Echo-specific notifications, not the formatting infrastructure, but I haven't tried to use the ol" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296641 (https://phabricator.wikimedia.org/T121612) (owner: 10Sbisson) [18:11:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Create a notification demo page - https://phabricator.wikimedia.org/T115551#2419138 (10Mooeypoo) 05Open>03Invalid Now that we have a proper Special:Notifications page with filters, this is no longer needed. [18:12:11] (03Abandoned) 10Mooeypoo: Add a demo special page to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [18:12:18] (03CR) 10Sbisson: [C: 04-1] "Some comments inline. Thanks for adding tests!" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [18:15:08] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07I18n, 13Patch-For-Review: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2419155 (10Mooeypoo) >>! In T137634#2390470, @Catrope wrote: > @Jdforrester-WMF suggests using CSS `tex... [18:28:30] (03PS3) 10Mooeypoo: Limit 2 secondary actions outside the menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275142 (https://phabricator.wikimedia.org/T126617) [18:29:27] stephanebisson, ^^ re-review, I rebased + added inline comments to deal with some of the other comments. It works, but seems to mostly be a "just in case" thing, since it seems now that most of our presentation models define less than 2 prioritized actions anyways [18:41:39] (03CR) 10Sbisson: [C: 04-1] "I am confused by the insideMenuItemCounter variable." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275142 (https://phabricator.wikimedia.org/T126617) (owner: 10Mooeypoo) [18:45:31] (03CR) 10Mooeypoo: Limit 2 secondary actions outside the menu (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275142 (https://phabricator.wikimedia.org/T126617) (owner: 10Mooeypoo) [18:45:38] (03PS4) 10Mooeypoo: Limit 2 secondary actions outside the menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275142 (https://phabricator.wikimedia.org/T126617) [18:45:53] stephanebisson, good catch, sorry, this was a complete brainfart variable naming. [18:46:19] mooeypoo: you can blame your bleeding eyes [18:46:43] Indeed. I'll do that. [18:47:09] other than naming, the counter should be incremented in the "outside" branch [18:51:30] (03CR) 10Sbisson: [C: 04-1] Limit 2 secondary actions outside the menu (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275142 (https://phabricator.wikimedia.org/T126617) (owner: 10Mooeypoo) [18:53:09] stephanebisson, oh ffs :\ okay, that's what happens when I work while listening to metrics. [18:53:31] also when you don't test ;) [18:55:28] stephanebisson, pfft, testing... details details [18:56:20] stephanebisson, another concept we should, at some point, clean up, is "this.bundle" in the widgets. I think we fixed up most of it for the DM (this.bundled means it's inside a bundle, and this.bundle means it IS a bundle with multiple IDs) [18:56:51] I thought I removed "this.bundle" [18:56:56] but i just saw that in the widget, it is this.bundle (which should be this.bundled, I think) [18:57:02] yeah i think we did that for DM but not for the widget [18:57:06] I just saw it in the widget code [18:59:46] (03PS5) 10Mooeypoo: Limit 2 secondary actions outside the menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275142 (https://phabricator.wikimedia.org/T126617) [18:59:56] Ok, lunch! bbiab. [19:13:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): Cross-wiki counter does not show correct number of unread messages - https://phabricator.wikimedia.org/T138888#2413215 (10Etonkovidova) The counter for cross-wiki bundles (beta-labsconsistently shows... [19:15:25] stephanebisson: hmm.. I am checking https://phabricator.wikimedia.org/T138888 and I still see some problems with cross-wiki counting. Added some screenshots to the ticket [19:16:10] etonkovidova: in the first screenshot, how many do you see when you expand the foreign notifications bundle? [19:16:31] stephanebisson: 7 [19:17:14] etonkovidova: is the other badge (alert) similarly wrong? It could be due to the re-categorization. [19:17:32] stephanebisson: 7 - one as a separate, and 6 as bundled [19:18:02] stephanebisson: re-categorization hmm... [19:18:03] the joy of dealing with 2 major changes that affect unread count! [19:18:30] ok. Will be looking more then [19:20:37] stephanebisson: deploying two confusing things at once - expandable bundle (but not for all msg types) and re-categorization and both are reflected in the counters ... :) [19:29:15] (03CR) 10Sbisson: [C: 032] Limit 2 secondary actions outside the menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275142 (https://phabricator.wikimedia.org/T126617) (owner: 10Mooeypoo) [19:39:02] (03Merged) 10jenkins-bot: Limit 2 secondary actions outside the menu [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275142 (https://phabricator.wikimedia.org/T126617) (owner: 10Mooeypoo) [20:07:41] stephanebisson: In betalabs, I see "Failed to fetch notifications" for several users (not all) - any idea what it might be? [20:08:26] noticed it yesterday - but today it's much more prevalent [20:41:11] 03Collab-Team-2016-Apr-Jun-Q4: [regression-betalabs] 'Failed to fetch notifications' - https://phabricator.wikimedia.org/T139112#2419799 (10Etonkovidova) [21:00:04] 10Notifications: Marking notification as read causes - https://phabricator.wikimedia.org/T139114#2419894 (10He7d3r) [21:00:28] 10Notifications: Marking notification as read causes "TypeError: sourceModel is null" - https://phabricator.wikimedia.org/T139114#2419920 (10He7d3r) [21:02:36] 03Collab-Team-2016-Apr-Jun-Q4: [regression-betalabs] 'Failed to fetch notifications' - https://phabricator.wikimedia.org/T139112#2419923 (10Etonkovidova) [21:19:37] 03Collab-Team-2016-Apr-Jun-Q4: [regression-betalabs] 'Failed to fetch notifications' - https://phabricator.wikimedia.org/T139112#2420049 (10Etonkovidova) [21:36:40] 10Notifications: Mark read revisions as read (alert popup) - https://phabricator.wikimedia.org/T139122#2420101 (10IKhitron) [22:39:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): Cross-wiki counter does not show correct number of unread messages - https://phabricator.wikimedia.org/T138888#2420262 (10Etonkovidova) Created a simpler example - User:ET91 has 5 events according to... [22:46:19] (03PS1) 10Mooeypoo: Pad the content so it doesn't stretch beyond the markread button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296843 (https://phabricator.wikimedia.org/T136572) [22:49:23] 06Collaboration-Team-Interested, 10Notifications, 10ArchCom-RfC, 10MediaWiki-Watchlist, 07RfC: RfC: Need to merge Notifications and Watchlist or lack thereof - https://phabricator.wikimedia.org/T128352#2420291 (10RobLa-WMF) #ArchCom spoke about this briefly at E223, noting the lack of assigned priority (... [22:56:13] 03Collab-Team-2016-Apr-Jun-Q4: [regression-betalabs] 'Failed to fetch notifications' - https://phabricator.wikimedia.org/T139112#2420319 (10Etonkovidova) [23:00:32] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): Add a subtle highlight on notification items on hover (on both panel and page) - https://phabricator.wikimedia.org/T138917#2413903 (10Etonkovidova) Checked the fix in Chrome, FF, and Safari - works a... [23:03:18] (03PS6) 10Mooeypoo: Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) [23:06:32] (03CR) 10Mooeypoo: "Rebased onto the current master, which solved most of the review comments, and fixed the remaining review comments in this patchset." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [23:14:08] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Browser-Support-Apple-Safari, 03Collab-Archive-2015-2016, 13Patch-For-Review: The messages panel cannot be closed anymore on iOS - https://phabricator.wikimedia.org/T113881#1679076 (10Mooeypoo) Pinging @Catrope re strategy on fixing this and prioritizatio... [23:14:31] (03PS2) 10Mooeypoo: [wip] Add a cog menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [23:22:42] (03PS3) 10Mooeypoo: [wip] Add a cog menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [23:58:14] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): For items with more than 2 actions, hide the rest under the "..." menu - https://phabricator.wikimedia.org/T125949#2420497 (10Etonkovidova) Checked in betalabs - all sec...