[06:16:32] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#2410874 (10Whatamidoing-WMF) `{{SITENAME}}` is not enough, and that appears to be the sole contents of `emailsender`. `{{... [07:27:39] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2410949 (10jayvdb) [08:07:38] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2410965 (10jayvdb) @polybuildr , I wont be debating the decision in public, as that is messy for... [09:11:48] 10Flow: Make it easy to filter for Flow topics created by yourself - https://phabricator.wikimedia.org/T138807#2411002 (10Sjoerddebruin) [09:51:23] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2411063 (10darthbhyrava) >>! In T138304#2410111, @01tonythomas wrote: >Its stated clearly that t... [10:04:13] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2411071 (10darthbhyrava) >>! In T138304#2410965, @jayvdb wrote: > @polybuildr , I wont be debati... [10:32:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1612363 (10Trizek-WMF) I don't know of {T113682} may have an impact about that task. [10:33:28] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 07User-notice: VE copy/paste issues - external links and formulas - https://phabricator.wikimedia.org/T137503#2411089 (10Trizek-WMF) [11:05:04] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#2411126 (10Catrope) >>! In T122229#2410874, @Whatamidoing-WMF wrote: > `{{SITENAME}}` is not enough, and that appears to b... [11:08:23] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#2411128 (10Catrope) >>! In T122229#2410874, @Whatamidoing-WMF wrote: > But sending me a message in a script that I can rea... [11:09:35] (03PS3) 10Catrope: Show a warning when leaving a page with unsaved text in an editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) [11:10:46] (03PS2) 10Catrope: Include parameters when performing &workflow= redirects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296343 [11:10:57] (03PS3) 10Catrope: Include parameters when performing &workflow= redirects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296343 [11:30:23] 10Notifications, 07Browser-Support-Apple-Safari: Special:Notifications broken on Safari 4 - https://phabricator.wikimedia.org/T138424#2399749 (10Catrope) I can't reproduce this using Safari 4 on Windows Vista via crossbrowsertesting.com. They don't have Mac OS 10.4 though. [11:31:07] 06Collaboration-Team-Interested, 10Notifications: Visiting the target page for any echo notification via site or email, should mark that notification as "read" - https://phabricator.wikimedia.org/T59684#2411138 (10Catrope) 05Open>03Resolved a:03Catrope This has long since been fixed. [11:32:00] 06Collaboration-Team-Interested, 10Notifications: 'Mark as read' in notifications needs a tooltip - https://phabricator.wikimedia.org/T126258#2411141 (10Catrope) 05Open>03Resolved a:03Catrope [11:41:47] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2411161 (10Qgil) @darthbhyrava, your two mentors are experts in their area, but most importantly... [12:18:47] (03PS9) 10WMDE-Fisch: Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [12:20:08] (03CR) 10WMDE-Fisch: "PS9 removes bundle related code. We decided on releasing this simple version first." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [12:23:30] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review, 03TCB-Team-Sprint-2016-06-16: Send notification for easy-to-find failed mentions - https://phabricator.wikimedia.org/T136326#2411194 (10WMDE-Fisch) As discussed in the daily I removed bundle related code. We decided on releasin... [12:39:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Email batch contained no useful information - https://phabricator.wikimedia.org/T137012#2411216 (10SBisson) >>! In T137012#2410093, @Catrope wrote: >>>! In T137012#2410001, @SBisson wrote: >> What needs to be done here? > > If possible, figure out why Matej rece... [12:40:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Email batch contained no useful information - https://phabricator.wikimedia.org/T137012#2411217 (10SBisson) a:03SBisson [13:19:58] (03PS1) 10Sbisson: Don't send empty emails [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296394 (https://phabricator.wikimedia.org/T137012) [13:22:30] (03CR) 10Catrope: [C: 032] Don't send empty emails [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296394 (https://phabricator.wikimedia.org/T137012) (owner: 10Sbisson) [13:31:12] (03Merged) 10jenkins-bot: Don't send empty emails [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296394 (https://phabricator.wikimedia.org/T137012) (owner: 10Sbisson) [13:35:20] (03CR) 10Catrope: [C: 032] "This makes the browser tests only work with MWV out of the box though :/ but I guess that was already the case given that it was using por" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296253 (owner: 10Sbisson) [13:38:34] (03CR) 10Sbisson: "Right." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296253 (owner: 10Sbisson) [13:42:09] (03CR) 10Catrope: "Generally speaking, we probably can't." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296253 (owner: 10Sbisson) [13:43:09] (03Merged) 10jenkins-bot: Browser tests: update local URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296253 (owner: 10Sbisson) [13:45:26] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: wikitext pages: Mention notifications prepend section title to text excerpts - https://phabricator.wikimedia.org/T134922#2411372 (10SBisson) a:03SBisson [13:49:44] 10Notifications, 10MediaWiki-API, 10Pywikibot-General: Determine source of notifications API change - https://phabricator.wikimedia.org/T138690#2411374 (10Catrope) Announcement sent: https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2016-June/000111.html [13:49:56] (03PS1) 10Sbisson: Mention notification: don't repeat the section title at the begining of the excerpt [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296397 (https://phabricator.wikimedia.org/T134922) [13:51:09] 10Flow: sessionfailure error when a diff for an hidden discussion is mark as patrolled - https://phabricator.wikimedia.org/T138359#2398006 (10Catrope) >>! In T138359#2398019, @Dereckson wrote: > I was able to reproduce the issue with X-Wikimedia-Debug set to mw1017 and log: > > https://logstash.wikimedia.org/#/... [13:56:17] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: When switching notification read status the blue "unseen" highlight should not be shown - https://phabricator.wikimedia.org/T138522#2411399 (10Catrope) [13:59:34] 10Flow: Hide username from a Flow board when that username has been masked on the history page - https://phabricator.wikimedia.org/T138599#2411422 (10Catrope) @Mattflaschen-WMF @Quiddity Is this related to one of the oversight-in-Flow tasks that we looked into a while ago? [14:22:55] (03CR) 10Matěj Suchánek: Echo notifications for simple mention failures (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [14:22:56] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Email batch contained no useful information - https://phabricator.wikimedia.org/T137012#2411459 (10Trizek-WMF) [14:42:13] (03PS10) 10WMDE-Fisch: Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [14:42:30] (03CR) 10WMDE-Fisch: Echo notifications for simple mention failures (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [15:06:16] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2411897 (10Catrope) >>! In T129366#2404249, @... [15:07:16] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Special-pages: Set a max-width for Special:Notifications page - https://phabricator.wikimedia.org/T137425#2411899 (10Catrope) [15:24:01] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Keep pagination consistent when switching status filters on the Notification Page - https://phabricator.wikimedia.org/T137863#2412009 (10Danny_B) [15:40:45] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Investigate case where no mention happens due to section mismatch - https://phabricator.wikimedia.org/T137897#2383048 (10WMDE-Fisch) a:03WMDE-Fisch [16:06:25] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Investigate case where no mention happens due to section mismatch - https://phabricator.wikimedia.org/T137897#2412225 (10WMDE-Fisch) As @Addshore stated in T136323#2398776 mentions will be only carried out by specific... [16:31:44] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 07User-notice: VE copy/paste issues - external links and formulas - https://phabricator.wikimedia.org/T137503#2370149 (10Jdforrester-WMF) The general copying of the `` tags when in MathML mode is {T136672} which is declared fixed, so marki... [16:33:18] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor: Copy/pasting links on Flow has multiple unexpected behaviors - https://phabricator.wikimedia.org/T135126#2412306 (10Jdforrester-WMF) [16:33:21] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki, 07Browser-Support-Firefox: Can't copy/paste external links in VE in Firefox - https://phabricator.wikimedia.org/T137503#2412300 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [17:03:39] (03CR) 10Matěj Suchánek: Echo notifications for simple mention failures (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [17:33:56] (03CR) 10Sbisson: [C: 032] Include parameters when performing &workflow= redirects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296343 (owner: 10Catrope) [17:41:21] (03Merged) 10jenkins-bot: Include parameters when performing &workflow= redirects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296343 (owner: 10Catrope) [17:55:37] * mooeypoo grumbles about seenTime [17:56:18] stephanebisson, RoanKattouw we've merged the schema change, iirc. Do we have plans on when to change the behavior? Because we have a few seen time bugs, and while we can fix them, ti'll be really good if we can fix the source issue. [17:57:11] mooeypoo: Matt said he would update that patch for the backend changes for that, and didn't end up having time for it [17:57:51] * mooeypoo nods [17:58:04] ok, I guess I"ll go and try to fix the symptoms then, until we fix the cause [18:15:49] (03PS1) 10Sbisson: Fix notice on flow history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296426 [18:17:02] (03CR) 10Catrope: [C: 032] Fix notice on flow history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296426 (owner: 10Sbisson) [18:18:16] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: When switching notification read status the blue "unseen" highlight should not be shown - https://phabricator.wikimedia.org/T138522#2412549 (10Mooeypoo) a:03Mooeypoo [18:21:45] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2412552 (10polybuildr) >>! In T138304#2410965, @jayvdb wrote: > @polybuildr , I wont be debating... [18:24:19] (03Merged) 10jenkins-bot: Fix notice on flow history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296426 (owner: 10Sbisson) [18:26:44] (03PS1) 10Mooeypoo: Remove initiallyUnseen before marking item read/unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296428 (https://phabricator.wikimedia.org/T138522) [18:27:11] (03CR) 10Sbisson: [C: 04-1] "Good job on using the preference." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [18:27:18] meh, seenTime doesn't seem to work at all in Special:Notifications :\ [18:28:03] ... hmm that would do it; we're not outputting it as a JS variable. [19:03:53] (03CR) 10Catrope: [C: 032] Remove initiallyUnseen before marking item read/unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296428 (https://phabricator.wikimedia.org/T138522) (owner: 10Mooeypoo) [19:05:31] (03CR) 10Catrope: [C: 032] Mention notification: don't repeat the section title at the begining of the excerpt [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296397 (https://phabricator.wikimedia.org/T134922) (owner: 10Sbisson) [19:11:09] (03CR) 10Catrope: "Re the 2 similar dialogs: the one on cancel is an OOUI dialog, the one on navigate-away is a native browser dialog whose contents we don't" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [19:12:14] (03Merged) 10jenkins-bot: Remove initiallyUnseen before marking item read/unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296428 (https://phabricator.wikimedia.org/T138522) (owner: 10Mooeypoo) [19:13:03] (03Merged) 10jenkins-bot: Mention notification: don't repeat the section title at the begining of the excerpt [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296397 (https://phabricator.wikimedia.org/T134922) (owner: 10Sbisson) [19:25:21] Alright, wmf.8 has been cut (at least for extensions it looks like), let's have a merge party [19:25:52] (03CR) 10Catrope: [C: 032] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [19:26:14] (03CR) 10Catrope: [C: 032] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:27:20] RoanKattouw: let's also do the transition-mode-and-backfill-script dance on beta [19:27:29] Yes [19:27:43] Transition mode is already enabled I think [19:27:47] First merging the bundling stuff [19:29:53] (03PS5) 10Catrope: Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:30:12] (03CR) 10Catrope: [C: 032] Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:30:37] (03CR) 10Catrope: [C: 032] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [19:31:21] (03CR) 10jenkins-bot: [V: 04-1] Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:32:29] damn, expandable bundles (Echo) can't merge [19:33:19] Ugh really? [19:33:27] I'll check what's up after dynamic bundle is merged [19:33:38] That might be a false alarm but we'll see [19:33:54] Zuul is working on dynamic bundle and showing something weird for expandable bundle [19:34:08] ( https://integration.wikimedia.org/zuul/ ) [19:34:20] I've been manually rebasing almost everyday due to a constant flow of small changes that cause conflicts [19:34:40] Yeah :/ [19:34:45] (03Merged) 10jenkins-bot: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [19:34:51] (03CR) 10jenkins-bot: [V: 04-1] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:34:54] (03CR) 10jenkins-bot: [V: 04-1] Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:34:57] (03CR) 10jenkins-bot: [V: 04-1] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [19:35:10] Yup, you were right, there's a conflict [19:35:46] Meanwhile I have a nice test case waiting on beta [19:36:04] I have three foreign wikis with unread messages, two of which are talk page related so they'll become alerts [19:36:29] I also just marked as unread a "2 replies on blah" message, so the bundling change will affect how that's counted [19:37:15] stephanebisson: Are you dealing with the rebase conflict for expandable bundle, or shall I? [19:37:22] I am [19:37:29] OK [19:38:01] (03PS25) 10Sbisson: Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [19:38:08] it was nothing [19:38:17] I'm disapointed at you, git [19:38:44] (03CR) 10Catrope: [C: 032] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:39:16] (03CR) 10Catrope: [C: 032] Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:39:22] (03CR) 10Catrope: [C: 032] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [19:39:37] Yeah I read the diff and didn't see anything that would conflict [19:39:54] Sometimes a local git rebase resolves automatically even in cases when Gerrit's rebase button doesn't work [19:40:35] OK this'll take a little while because our changes are behind two Wikibase changes and one of them is going to fail [19:40:42] which will cause the rest to be retested [19:41:24] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: [production] minor: 'Mark as read' cross-wiki alerts displays blank flyout - https://phabricator.wikimedia.org/T132202#2412726 (10SBisson) a:03SBisson [19:42:08] mooeypoo: https://gerrit.wikimedia.org/r/#/c/296437/1 [19:50:26] (03Merged) 10jenkins-bot: Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:50:29] (03Merged) 10jenkins-bot: Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [19:50:32] (03Merged) 10jenkins-bot: Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [20:16:03] works well for me on beta :) [20:18:46] Yup working for me too [20:19:03] It cached the wrong count for me initially but I think that was because I'd broken the other wikis because the schema change wasn't applied there yet [20:22:06] (03PS16) 10Sbisson: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [20:22:42] (03CR) 10Mooeypoo: [C: 04-1] "Tiny comment" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296437 (https://phabricator.wikimedia.org/T132202) (owner: 10Sbisson) [20:25:25] (03CR) 10Sbisson: Show placeholder widget when there is no notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296437 (https://phabricator.wikimedia.org/T132202) (owner: 10Sbisson) [20:25:32] (03PS2) 10Sbisson: Show placeholder widget when there is no notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296437 (https://phabricator.wikimedia.org/T132202) [20:26:39] (03CR) 10Catrope: [C: 032] Re-categorize notifications: [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293762 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:27:52] (03PS5) 10Catrope: Re-categorize notifications: [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293762 (https://phabricator.wikimedia.org/T123018) [20:28:51] (03CR) 10Catrope: [C: 032] Re-categorize notifications: [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293762 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:28:56] (03PS4) 10Catrope: Re-categorize notifications: [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293763 (https://phabricator.wikimedia.org/T123018) [20:29:11] (03CR) 10Catrope: [C: 032] Re-categorize notifications: [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293763 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:29:20] (03CR) 10Catrope: [C: 032] Re-categorize notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/293764 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:29:39] (03CR) 10jenkins-bot: [V: 04-1] Re-categorize notifications: [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293762 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:31:22] (03CR) 10Sbisson: [C: 032] Re-categorize notifications: [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293762 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:31:53] (03CR) 10Catrope: [C: 032] Re-categorize notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/293766 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:32:31] Forgive me Jenkins for I have sinned [20:32:41] I just merged 7 patches that I authored myself xD [20:33:03] that nobody even +1'd [20:33:15] Oh well, they're all just -'section' => 'alert', +'section' => 'message', so it probably falls within the exceptions to the no-self-+2 policy [20:33:21] (Exceptions that I am opposed to though) [20:39:24] (03CR) 10Sbisson: "Which dialog is affected by this change?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296263 (owner: 10Catrope) [20:41:12] (03Merged) 10jenkins-bot: Re-categorize notifications: [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293762 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:41:15] (03CR) 10Catrope: "CancelConfirmDialog, which is shown when the user presses "Cancel" while they have unsaved text in an editor." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296263 (owner: 10Catrope) [20:41:57] (03Merged) 10jenkins-bot: Re-categorize notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/293764 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:43:19] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2412927 (10jayvdb) >>! In T138304#2412552, @polybuildr wrote: >>>! In T138304#2410965, @jayvdb w... [20:43:56] (03CR) 10Sbisson: [C: 032] Fix font size for OOUI dialogs in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296263 (owner: 10Catrope) [20:47:34] (03Merged) 10jenkins-bot: Re-categorize notifications: [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293763 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:47:38] (03Merged) 10jenkins-bot: Re-categorize notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/293766 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [20:55:13] (03Merged) 10jenkins-bot: Fix font size for OOUI dialogs in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296263 (owner: 10Catrope) [20:57:53] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, 07User-notice: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2412976 (10SBisson) a:03Catrope [21:01:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1734509 (10SBisson) There is A LOT of discussion here (which is awesome). Would anyone be able to summarize the decisions in the task description so it can be execu... [21:16:50] Stepping out briefly, gonna test on beta when I come back [21:18:15] RoanKattouw: leaving for dinner soon, ping me on hangout if there's anything [21:18:47] OK [21:18:54] We'll have a week to sort out any issues anyway [21:19:11] Sorry for the delay, I got roped into a meeting and now I have to pick up relatives who got themselves stranded [21:44:09] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [mobile] The dotdotdot menu does not work properly - https://phabricator.wikimedia.org/T132393#2196832 (10Mooeypoo) I can't reproduce this in Chrome and Firefox mobile sites, including the device toolbar, and I couldn't reproduce this in Chrome in Android. Seem... [21:45:59] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Timestamps in flyout can differ from Special:Notifications - https://phabricator.wikimedia.org/T131733#2176438 (10Mooeypoo) Off hand, this sounds like a discrepency between MomentJS and MW dates. Could it be we're not completely synchronized between t... [21:47:49] Ugh [21:47:53] I forgot the double cache bump issue [21:47:58] I remembered it earlier today and then forgot it again [21:49:29] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Notifications page: Notification bodies are not truncated - https://phabricator.wikimedia.org/T138433#2413050 (10Mooeypoo) There is a technical issue with making the body of a table-layout div (css) actually adhere to its width. We can try and bypass... [21:50:01] (03PS1) 10Catrope: Bump the cache version a second time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296469 (https://phabricator.wikimedia.org/T123018) [21:50:17] (03CR) 10Catrope: [C: 032] Bump the cache version a second time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296469 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [21:56:22] (03Merged) 10jenkins-bot: Bump the cache version a second time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296469 (https://phabricator.wikimedia.org/T123018) (owner: 10Catrope) [21:59:36] RoanKattouw, holy crap, Special:Notifications JS page looks terrible in mobile frontend [21:59:47] Yeah :/ [21:59:50] I discovered that recently [21:59:59] we should fix this [22:00:25] At least show only the combined popup even? [22:03:24] Ideally we'd have a mobile version [22:03:31] A max-width would go a long way probably [22:03:39] Speaking of, Pau's decided on the max-width thing, see phab [22:09:36] RoanKattouw, max-width won't do because of the sidebar [22:09:44] we'll have to figure out how to sidebar it correctly for mobile [22:10:18] Hmm right [22:12:16] RoanKattouw, meh, how do I create a new message inside php ooui class? wfMessage? [22:16:42] Yeah I believe so [22:16:48] wfMessage( 'foobar' ) returns a Message object [22:17:06] * mooeypoo nods [22:45:22] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Cross-wiki counter does not show correct number of unread messages - https://phabricator.wikimedia.org/T138888#2413215 (10Catrope) [22:48:10] (03CR) 10Addshore: Echo notifications for simple mention failures (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [23:24:47] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2413316 (10Mooeypoo) The reason I ask is because the screenshot is for the no-js notifications page. Should we work on this for no-js, js-... [23:24:59] (03PS1) 10Mooeypoo: [wip] Add settings cog menu and mark all read button to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296485 (https://phabricator.wikimedia.org/T115528) [23:26:40] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add settings cog menu and mark all read button to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296485 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo)