[00:05:06] 03Collab-Team-2016-Apr-Jun-Q4: (FF only) Side bar displays nested 'Pages with unread notifications - https://phabricator.wikimedia.org/T138454#2400838 (10Etonkovidova) [07:52:56] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2401091 (10ArielGlenn) Now testing on mediawiki via manual run. [08:26:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Flow not warning me when I leave an edit page with unsaved changes - https://phabricator.wikimedia.org/T96531#2401142 (10Trizek-WMF) [[https://www.mediawiki.org/wiki/Topic:T6duwsw7x0fm4xj7|New request to have a confirmation when you leave the page]]. [08:31:35] Is it possible to fix that task? ↑ ↑ People are frustrated not to have a warning when they accidentally (or not) leave the page while a message is being written? [08:59:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2401221 (10ArielGlenn) SOofar it looks ok. I am now running flow history dumps across all wikis with flow enabled. [09:25:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, and 2 others: [minor] Order of wikis in collapsed cross-wiki notifications is different when the list is exapnded - https://phabricator.wikimedia.org/T138115#2401272 (10jmatazzoni) 05Open>03Resolved [10:32:51] (03CR) 10Sbisson: Add maintenance script to update page IDs of topic-resolved notifications (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) (owner: 10Catrope) [10:34:13] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 05Google-Summer-of-Code-2016, 13Patch-For-Review: Implement pywikibot support for adding thanks to normal revisions - https://phabricator.wikimedia.org/T135409#2401509 (10darthbhyrava) @jayvdb - an updated patch has been put up for this. It i... [10:58:38] (03CR) 10Sbisson: [C: 032] Use the actual total notification count in the special page sidebar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295561 (owner: 10Catrope) [11:05:17] (03Merged) 10jenkins-bot: Use the actual total notification count in the special page sidebar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295561 (owner: 10Catrope) [11:34:31] 03Collab-Team-2016-Apr-Jun-Q4, 07Browser-Support-Firefox: (FF only) Side bar displays nested 'Pages with unread notifications - https://phabricator.wikimedia.org/T138454#2401609 (10Trizek-WMF) [11:41:11] (03PS4) 10WMDE-Fisch: DRAFT Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 [11:44:47] (03CR) 10WMDE-Fisch: DRAFT Echo notifications for simple mention failures (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (owner: 10WMDE-Fisch) [12:12:25] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Send notification for easy-to-find failed mentions - https://phabricator.wikimedia.org/T136326#2401705 (10WMDE-Fisch) The related patch is almost done. A few questions remain: The simple checks for an "anonymous" user... [12:16:34] (03Abandoned) 10Addshore: DRAFT Echo notifications on mention success [extensions/Echo] - 10https://gerrit.wikimedia.org/r/290198 (https://phabricator.wikimedia.org/T135719) (owner: 10Addshore) [13:03:08] (03PS5) 10WMDE-Fisch: DRAFT Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 [13:14:52] (03PS14) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [13:22:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Browser-Support-Firefox: (FF only) Side bar displays nested 'Pages with unread notifications - https://phabricator.wikimedia.org/T138454#2402007 (10Catrope) [13:24:33] (03CR) 10Catrope: Add maintenance script to update page IDs of topic-resolved notifications (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) (owner: 10Catrope) [13:29:53] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2402017 (10Trizek-WMF) 05Open>03Resolved Request for trans... [13:29:55] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation, 07Tracking: Update Help:Notifications (tracking) - https://phabricator.wikimedia.org/T119713#2402019 (10Trizek-WMF) [13:32:39] (03PS2) 10Catrope: Add maintenance script to update page IDs of topic-resolved notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) [13:49:40] (03CR) 10Sbisson: [C: 04-1] "I'm very nitpicky today ;)" (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) (owner: 10Catrope) [13:50:54] 10Flow, 10VisualEditor: CRTL+M on VE mode has unexpected behavour on VE and on VE mode on Flow with an Azerty keyboard - https://phabricator.wikimedia.org/T134164#2402054 (10Trizek-WMF) 05stalled>03Open Reproduced on @EdouardHue's computer on Debian Stretsh + Cinnamon: * Chrome 49.0.2623.108 - X11 keyboar... [13:53:33] (03CR) 10Sbisson: "But it works well. Fix the comments and I'll merge it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) (owner: 10Catrope) [13:55:52] (03PS3) 10Catrope: Add maintenance script to update page IDs of topic-resolved notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) [13:55:58] (03CR) 10Catrope: Add maintenance script to update page IDs of topic-resolved notifications (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) (owner: 10Catrope) [13:56:42] 10Flow, 10VisualEditor: CRTL+M on VE mode has unexpected behavour on VE and on VE mode on Flow with an Azerty keyboard - https://phabricator.wikimedia.org/T134164#2402066 (10Trizek-WMF) a:05Trizek-WMF>03None [14:06:54] (03CR) 10Sbisson: [C: 032] Add maintenance script to update page IDs of topic-resolved notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) (owner: 10Catrope) [14:14:09] (03CR) 10Sbisson: [C: 031] "That's great!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295565 (https://phabricator.wikimedia.org/T136895) (owner: 10Mooeypoo) [14:15:02] (03PS15) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [14:16:16] (03Merged) 10jenkins-bot: Add maintenance script to update page IDs of topic-resolved notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) (owner: 10Catrope) [14:18:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2402114 (10SBisson) a:03Catrope [14:22:44] RoanKattouw: my time is highly fragmented today but I'll still be able to work most of the day. What do you think I should be working on? [14:25:10] Hmm it looks like there's only small stuff left [14:25:31] stephanebisson: You could work on the leave-without-saving warning in Flow if you like [14:26:05] And/or https://phabricator.wikimedia.org/T138454 [14:26:29] https://phabricator.wikimedia.org/T137862 is a bigger thing [14:27:05] Also https://phabricator.wikimedia.org/T122229 and https://phabricator.wikimedia.org/T71981 are smallish email-related enhancements [14:29:40] the first one (FF nested filters) is extremely weird, I'll take a look [14:30:27] the second one (deep linking) is complex, for this to work well, both js and no-js versions of this page must respond to the same parameters, it's not the case right now [14:30:48] the last 2 require Joe/Pau conversation, I'll start them [14:31:33] Right, we need to decide on wording and stuff [14:36:23] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#2402164 (10SBisson) @jmatazzoni , @Pginer-WMF We need to decide where we display the wiki name and what is the language... [14:41:45] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Easy: User rights change notification email does not specify in body which account was affected - https://phabricator.wikimedia.org/T71981#2402203 (10SBisson) @jmatazzoni , @Pginer-WMF Any preference for how to include the user account name in the user-rights... [14:50:36] (03CR) 10jenkins-bot: [V: 04-1] Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [15:03:19] (03PS2) 10Catrope: [WIP] Implement subject+talk and null+user page grouping in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) [15:03:22] (03PS1) 10Catrope: ApiUnreadNotificationPages: Output pages as an array rather than an object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295701 [15:11:37] 10Notifications, 06TCB-Team, 07German-Community-Wishlist: Make Echo notifications for users who caused edit conflicts - https://phabricator.wikimedia.org/T138502#2402313 (10Base) [15:40:11] (03CR) 10Matthias Mullie: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [16:16:37] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, and 2 others: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2402491 (10Pginer-WMF) I'd like to propose a small color adjustment on the unread mark... [16:26:51] (03PS3) 10Catrope: [WIP] Implement subject+talk and null+user page grouping in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) [16:26:54] (03PS1) 10Catrope: CrossWikiUnreadFilterWidget: Remove unused this.localSource [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295726 [17:01:42] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Flow not warning me when I leave an edit page with unsaved changes - https://phabricator.wikimedia.org/T96531#2402700 (10Trizek-WMF) Tried just at the moment, on xubuntu 14.04 / Chromium 50.0.2661.102, on MediaWiki wiki. on wikitext mode # added text # clicked on GFDL (... [17:13:48] (03CR) 10Mooeypoo: "Wait, I need to test this, but this is worrying if it was unused -- the purpose of this was to make sure that even if you have 0 notificat" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295726 (owner: 10Catrope) [17:25:26] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Tracking: When switching notification read status the blue "unseen" highlight should not be shown - https://phabricator.wikimedia.org/T138522#2402769 (10Pginer-WMF) [17:25:34] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: When switching notification read status the blue "unseen" highlight should not be shown - https://phabricator.wikimedia.org/T138522#2402769 (10Pginer-WMF) [17:35:51] (03CR) 10Catrope: "Yes, the API returns it." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295726 (owner: 10Catrope) [17:46:37] (03CR) 10Catrope: "Also, it was doing two weird things:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295726 (owner: 10Catrope) [17:56:17] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07Browser-Support-Firefox: (Firefox only) Side bar displays nested 'Pages with unread notifications - https://phabricator.wikimedia.org/T138454#2402834 (10Aklapper) [18:03:11] (03CR) 10Mattflaschen: [C: 032] Replace symbolic link with partial [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [18:07:44] (03CR) 10jenkins-bot: [V: 04-1] Replace symbolic link with partial [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [18:08:19] (03CR) 10Paladox: "@Mattflaschen could you re c+2 please." [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [18:08:41] (03CR) 10Paladox: "recheck" [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [18:10:54] (03CR) 10Paladox: "recheck" [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [18:13:17] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2402870 (10Mooeypoo) Just to make sure - this is for the "no-JS" version, correct? The JS version looks and behaves completely differently... [18:14:20] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2402871 (10Mooeypoo) a:03Mooeypoo [18:15:19] (03Abandoned) 10Mattflaschen: Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [18:20:24] (03CR) 10Mattflaschen: [C: 032] "Seems to be T116258. Backported https://gerrit.wikimedia.org/r/#/c/295742/ ." [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [18:24:48] (03Merged) 10jenkins-bot: Replace symbolic link with partial [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [18:41:38] (03CR) 10Paladox: "thanks." [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [18:43:07] (03CR) 10Paladox: "@Mattflaschen could you c+2 please." [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295468 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [18:43:22] (03CR) 10Paladox: "@Mattflaschen could you c+2 please." [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295462 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [19:27:53] (03CR) 10Sbisson: [C: 032] ApiUnreadNotificationPages: Output pages as an array rather than an object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295701 (owner: 10Catrope) [19:34:03] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Easy: User rights change notification email does not specify in body which account was affected - https://phabricator.wikimedia.org/T71981#2403015 (10matej_suchanek) [19:35:40] (03Merged) 10jenkins-bot: ApiUnreadNotificationPages: Output pages as an array rather than an object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295701 (owner: 10Catrope) [20:19:46] (03PS1) 10Sbisson: Fix position of page filters in firefox [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295752 (https://phabricator.wikimedia.org/T138454) [20:20:17] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07Browser-Support-Firefox, 13Patch-For-Review: (Firefox only) Side bar displays nested 'Pages with unread notifications - https://phabricator.wikimedia.org/T138454#2403158 (10SBisson) a:03SBisson [20:21:25] 10Notifications: "PHP Warning: Illegal string offset" and "PHP Notice: Uninitialized string offset" - https://phabricator.wikimedia.org/T138534#2403164 (10Kghbln) [20:28:25] (03CR) 10Sbisson: [C: 032] Clean up and fix updateEchoSchemaForSuppression.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293029 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [20:38:07] (03Merged) 10jenkins-bot: Clean up and fix updateEchoSchemaForSuppression.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293029 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [21:12:09] (03PS4) 10Mooeypoo: Add a PromisePrioritizer and use it for notifications fetching [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295565 (https://phabricator.wikimedia.org/T136895) [21:17:47] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2403304 (10Etonkovidova) Double-checking with... [21:30:41] stephanebisson, you're running mac, right? [21:30:49] not linux? [21:30:52] mooeypoo: yes [21:31:23] stephanebisson, I can't reproduce this bug on my machine in Firefox... can you check if you can see it ? https://phabricator.wikimedia.org/T138454 [21:31:44] mooeypoo: Presumably he can, because he's submitted a fix for it already [21:31:47] Everything looks perfect for me locally and in beta [21:31:49] ... oh [21:31:59] ... what the hell? I don't see it [21:32:04] what happened to phabricator! [21:32:07] * mooeypoo shakes fist [21:32:10] Refresh the task? The gerrit link is in the bottom omment [21:32:20] yes [21:32:28] I .. did... ok I see it now. [21:32:29] nevermind then [21:32:37] I'm running an old-ish firefox for testing [21:32:43] ... seriously? clear:both? ha [21:32:59] stephanebisson, well, I have a new one, but etonkovidova just saw it with latest Firefox on mac [21:33:23] so we were trying to figure out if it's mac-only [21:33:42] ok, I can't really test it, it doesn't reproduce for me, but the fix looks good. I'm blindly +2ing it [21:34:11] (03CR) 10Mooeypoo: [C: 032] Fix position of page filters in firefox [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295752 (https://phabricator.wikimedia.org/T138454) (owner: 10Sbisson) [21:34:12] mooeypoo: just make sure it doesn't break your browser :) [21:34:37] I didn't have the courage to test in IE [21:35:05] etonkovidova is testing now in Windows [21:41:43] (03Merged) 10jenkins-bot: Fix position of page filters in firefox [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295752 (https://phabricator.wikimedia.org/T138454) (owner: 10Sbisson) [21:53:14] stephanebisson: Windows is fine; it is only FF 46/47 [22:35:21] (03PS4) 10Catrope: Implement subject+talk and null+user page grouping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) [22:35:24] (03PS1) 10Catrope: Add support for querying notifications not associated with any page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295767 [22:36:20] mooeypoo: steph[TAB}: My sidebar code is now ready for review ---^^ [22:37:33] (03PS5) 10Catrope: Implement subject+talk and null+user page grouping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) [22:37:36] (03PS2) 10Catrope: Add support for querying notifications not associated with any page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295767 [22:45:42] RoanKattouw, I found a couple of bugs in your code, but I'm confused a bit about the code itself. Why are you adding pagesForTitle object rather than storing everything in the list of pages? We can just change "title:" to "titles:" as an array, since that's also what we then send to the API request , no? [22:46:13] RoanKattouw, so, whenever there are multiple titles, the API request has an empty array for nottitles for me. I suspect that this is partially why? [22:46:23] Huh? [22:46:27] It's working for me [22:46:38] want me to share screens? [22:46:47] nottitles:Talk:Main Page|Main Page [22:46:57] nottitles:[] [22:47:12] Did you select the user pagE? [22:47:18] Yep [22:47:27] Then that may be the string '[]' instead of an empty array? [22:47:33] Why? [22:47:40] Also I just realized there's a serious bug [22:47:52] I just don't quite understand why you have another object in the page filter [22:47:55] Suppose you have unread notifications for Talk:Main_Page but not for Main_Page [22:48:11] you need a single list of pages, all that changed is that instead of 1 page ID, we may have an array of page IDs [22:48:17] Then if you click Main_Page, it'll filter only for Talk:Main_Page and not for Main_Page [22:48:19] with 1 "main" ID for the title [22:48:26] s/IDs/titles/ [22:48:28] Sure [22:48:39] I think what I wanted to do was not have the data: entry of the OptionWidget be an array [22:48:42] But I think that might actually be fine [22:48:56] Yes, I think the code was half-ready for that [22:49:02] I was concerned that getItemFromData might not work with non-primitive types [22:49:06] there was a comment saying "when we have multiple pages, this should be an array" [22:49:18] well, we can also have it join( '|' ) [22:49:20] i.e. you can have [ 'foo', 'bar' ] !== [ 'foo', 'bar' ] if they're not the same object [22:49:22] f that's what you're concerned about [22:49:25] Right, fair enough [22:49:32] OK yeah I think you're right about that [22:49:42] I am not clear about what the new object gives us [22:49:52] is that information about the grouped pages? [22:50:06] Yeah it's "Main Page": ["Main Page", "Talk:Main Page"] basically [22:50:07] I'm looking at the API response for pagecount again [22:50:19] And "User:Catrope": ["User:Catrope", "User talk:Catrope", "[]" ] [22:50:26] Problem is, it excludes pages that have no unread notifs and it shouldn't [22:50:30] I'll fix that in the aPI [22:51:22] So in the filter data, we can use the same structure, the only difference is the call for current page title for the API [22:51:56] https://gerrit.wikimedia.org/r/#/c/295591/5/modules/model/mw.echo.dm.SourcePagesModel.js [22:52:42] title can be the same [22:53:12] but we can rework the pages: { } object to have { pageIDsSeparatedByPipe: [ page, page, page ... ] [22:53:26] 06Collaboration-Team-Interested, 10MediaWiki-Email, 07Upstream, 07Wikimedia-log-errors: Non-static method Mail_mimePart::_explodeQuotedString() should not be called statically, assuming $this from incompatible context - https://phabricator.wikimedia.org/T75484#2403663 (10MaxSem) 05Open>03Resolved a:03... [22:53:29] or even { titleToDisplay: [ page, page, page...] [22:54:35] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2403667 (10darthbhyrava) [22:55:00] RoanKattouw, btw, I see one issue from the API [22:55:36] (03PS6) 10Catrope: Implement subject+talk and null+user page grouping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) [22:56:02] The page definition for User_talk:Admin has pages array [ 'User_talk:Admin', null ] [22:56:13] ^^ that's intentional ? [22:56:40] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2403674 (10darthbhyrava) [22:56:46] (03CR) 10Catrope: "PS6: Make API output the full list of pages for each group, rather than just the ones that have unread notifications. This fixes a bug whe" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) (owner: 10Catrope) [22:57:12] mooeypoo: Yes. null is for notifications associated with no page, and we decided those should be grouped with the user page [22:57:25] With PS6 it'll be ['User:Admin', 'User talk:Admin', null] [22:57:41] ok, but this is confusing. The User_talk:Admin page has that and null, but the title is User:Admin [22:57:47] so it's not grouping User:Admin in the pages? [22:57:51] It is [22:57:52] oh, okay, yeah [22:58:49] Ooh clever solution re remapping the pages object [22:59:08] Although that takes it back to an object instead of an array [22:59:09] I just think it will be more logical? [22:59:14] Why? [22:59:33] Well, {titleToDisplay: [ page1, page2 ] } is what pagesForTitle is already [22:59:42] But why are we doubling this [22:59:44] The pages object also needs to have the count [23:00:10] It currently looks like [ {title:displaytitle, count:3}, {title:displaytitle2, count:1} ] [23:00:11] This makes it so that we have 2 objects containing information about our pages, and it seems somewhat arbitrary where the info is and why it's split [23:00:51] One is what you need for display and the other is what you need for querying, but I agree it's a bit arbitrary [23:00:53] RoanKattouw, yeh, so just have one object, [ { title: displaytitle, count: 3, groupedPages:Blah|Bloop }, ... ] [23:01:08] mooeypoo: Yes but then how do you quickly find groupedPages from a displayTitle? [23:01:19] That's what the map is for, to make that easy [23:01:23] oh, I see [23:01:30] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2403690 (10darthbhyrava) [23:01:48] Why do we need that "easy", though? We can just use it as the optionwidget's data value [23:01:49] (In actual fact, groupedPages *is* stored in the pages object was well, because the API puts it there and I was too lazy to remove it) [23:01:55] Hmm right [23:01:58] That would work, I think [23:02:04] and then on choose you just ask for that value [23:02:05] Is the data value used for anything else? [23:02:12] all we need on choose is the selected source and the grouped IDs [23:02:17] I guess this is exactly the kind of thing that data values are for after all [23:02:24] I think it's page name right now [23:02:31] source + page is what I need [23:02:38] so for the main wiki (no page) the page is null [23:02:58] so this.title widget has data: null [23:03:07] and right now, the rest of the page widgets, have data: sourcePages[ i ].title, [23:03:32] but we can switch it up to sourcePages[ i ].groupedPages.join( '|' ) or something, if you don't want an array [23:03:41] Hmm, the only thing that would break is the getItemFromData usage [23:04:05] The second thing we can do is add a getter to PageNotificationsOptionWidget [23:04:12] leave the data as-is for getItemFromData [23:04:24] but then have optionWidget.getGroupedTitles() [23:04:31] Also I see that I've already broken the initialSelection config option [23:04:34] and you get an array of the titles for the API [23:04:50] Or, no, I haven't, I only made its documentation false [23:05:09] OK, so allow the option widget to have two data things, essentially [23:05:29] RoanKattouw, in mw.echo.ui.CrossWikiUnreadFilterWidget.prototype.onPageFilterChoose we have this.emit( 'filter', source, page ) [23:05:43] we can switch it up for this.emit( 'filter', source, item.getTitleArray() ) [23:05:46] The display name as the "real" data that's used for getItemFromData etc, and then the list separately [23:05:50] Yeah, I agre [23:05:54] That would work [23:06:06] then we just need to make sure that for the title option widget, the "title array" is null [23:06:28] I guess the difference between that and what I'm doing is only that I'm storing that data centrally in a map, and you propose spreading it out over the OptionWidges [23:06:28] because that's what the controller expects when we want the complete result for the whole source. [23:06:36] hm [23:06:49] I guess there's not much difference, if you prefer your option, I'd just add a comment explaining the map [23:06:56] I was completely confused about why we're splitting the data [23:07:06] (Actually it needs to be an empty array, not null, at least in my current code) [23:07:11] OK, makes sense [23:07:21] I'm not trying to argue you out of it :) I'm just observing [23:07:44] if it needs to be an empty array, then we need to change this.title = ... to have data: [] in mw.echo.ui.PageFilterWidget [23:08:16] RoanKattouw, yeah no, I'm just trying to make sense of it. I personally prefered a structured data object, it made more sense to have source->pages->info object [23:08:25] but the map makes sense too for quickly calling the data by title [23:08:50] Yeah I'm just trying to store as little data in UI objects as possible [23:08:57] wait, wasn't I storing the page item as { pageTitle: data } ? or was it a previous iteration [23:09:06] No that was {pageId: data} [23:09:08] RoanKattouw, which is probably a better approach [23:09:11] yeah pageID [23:09:13] Because the API used to output that [23:09:19] but that meant the map was unnecessary [23:09:33] But I changed the API output from {pageId: data} to [data, data] because the concept of a page ID gets murky when you're talking about sets of pages [23:09:38] because it was already mapped. So either we fake that structure again in the filter (despite what the API returns) or we do the map [23:09:47] either way, we should explain in comment what is done [23:10:12] right, my original thought was that pageID: ... will turn into pageId1|pageId2: { ... } [23:10:15] Especially considering the fact that the "User:Yourname" group can consist only of the "page" null, if neither [[User:Yourname]] nor [[User talk:Yourname]] exist [23:10:18] but either way, it doesn't matter [23:10:46] (I mean, you could use -1 as a fake page ID, but it just seemed like a bad idea to keep trying to use page IDs in those kinds of scenarios) [23:11:02] Yeah. I guess so. We could store everything in the "map" though [23:11:08] Basically the problem is that strings can describe pages that don't exist, while IDs can't [23:11:20] Oh you're saying store everything in a map format [23:11:23] Yeah, I suppose you could [23:11:26] Yeah [23:11:36] { displayTitle: { count: 5, titles: [ foo, bar ] } } [23:11:41] yep [23:11:50] and that would make the getters work as intended too [23:11:54] That makes sense [23:12:46] I'm a bit hesitant to do that in the API response though because currently the API response is ordered by count, and you can only do that with an array, not with an object [23:13:12] we can then just use things like this.sources[ source ].totalCount and this.sources[ source ].pages[ title ].count [23:13:14] But we could remap the data in SourcePagesModel, as I kind of do already [23:13:15] consistently [23:13:18] Right [23:13:37] Yeah, I think it's better [23:13:40] Yeah I'm talking about source pages model [23:13:43] On the JS at least [23:13:45] *JS side [23:13:48] Yep [23:13:59] In there, we can replace the current pages: [] array with your new map [23:14:01] i.e. keep the API response as is but remap it to what you're saying for storage in SourcePagesModel [23:14:07] Yeah exactly [23:14:08] and just make sure the map includes all details. [23:14:16] yep [23:14:32] I think it could be more conceptually consistent and allow us to quickly fetch info for the UI and for the API [23:15:30] (03PS1) 10Catrope: Follow-up 6c4bf99da88: Fix incorrect comment [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295773 [23:15:31] Yup, I agree [23:16:38] is there any significant thing we'll be missing out on with the array? [23:16:47] order is the only thing I can think of, but the widget reorders itself anyways [23:17:19] Sigh I just wrote ve.getProp() in Echo [23:17:22] Old habits die hard huh [23:17:40] Yeah I want to keep the array for order in the API response, for other clients [23:17:42] hee [23:17:44] But in the widget it's fine [23:17:51] * mooeypoo nods [23:21:01] (03PS7) 10Catrope: Implement subject+talk and null+user page grouping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) [23:22:06] (03CR) 10Catrope: "PS7: Address IRC comments from Moriel (simplify storage of page data in SourcePagesModel)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) (owner: 10Catrope) [23:22:54] RoanKattouw, awesomesauce. Only question I have now is wording. "getCurrentPage()" brings something different than "getPagesForCurrentTitle" [23:22:56] mooeypoo: Haha, oops, can you tell what's wrong with this diff (already merged)? https://gerrit.wikimedia.org/r/#/c/295701/1/modules/ui/mw.echo.ui.PageFilterWidget.js [23:23:07] mooeypoo: Hint: why does jshint not complain that "title" is now an unused variable? [23:23:34] Ugh, yeah the terminology confusion of pages vs titles is annoying [23:23:52] RoanKattouw, it's not unused, you have a === condition :P [23:23:54] See also getProp ( ... , 'pages', title, 'pages' ) [23:24:00] mooeypoo: Yes :P comparing with undefined [23:24:01] yeah :\ [23:24:04] haha [23:24:30] To do that sensibly though requires renaming the first pages as opposed to the second one IMO [23:24:40] So I think I'll leave that for tomorrow [23:24:49] title page vs... titles.... or... somethign... [23:25:08] i think it'll also help figuring out what data to give the widgets, 'cause that's confusing too -- though I think it stays the same, code-wise [23:25:11] I didn't want to make the second one titles, because then you have { title: 'Foo', titles: [ 'Foo', 'Bar' ] } [23:25:13] title and titles [23:25:29] they use the "main" identifier page as identifier, and the filter spits out the array of all grouped pages [23:25:31] yeah [23:25:35] Before and after my patches the data in the widgets is just the title they display, and I think that's good [23:25:48] yep [23:25:51] no, it works and makes sense, it's just not clear naming-wise [23:25:57] title vs the grouped titles [23:26:00] ... i don't know [23:26:08] Yeah... [23:26:14] display title vs grouped pages ? [23:26:15] I'll think about that more tomorrow [23:26:20] +1 [23:26:21] Yes [23:26:28] It's 1:30 so I should go to bed [23:26:32] I know I also said that yesterday [23:26:35] go! good night :) [23:27:04] But it's 22C and 76% humidity *inside* and I've just had a laptop in my lap, so my legs are sweating already and I'm not even in bed yet [23:27:16] yikes [23:27:21] Tonight's gonna be one of those nights where I can't sleep because it's too warm+humid :( [23:27:25] that's warm. Also, you need a table [23:27:30] It was 28C this afternoon also with high humidity [23:27:36] No A/C ? [23:27:42] I wisely did not go outside today [23:27:58] (It also rained off and on, and we just had a thunderstorm. Also lots of thunderstorms last night) [23:28:03] No, nobody has A/C here [23:28:21] This kind of tropical weather is not very common. It does happen though [23:29:04] Those don't lower the humidity? [23:29:10] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2403709 (10Etonkovidova) Summary of what spec... [23:29:28] (03CR) 10Mooeypoo: [C: 04-1] "Looks good overall, just a minor naming point (reiterating a conversation on IRC)" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) (owner: 10Catrope) [23:29:36] ^^ this will be for reminding us both for tomorrow [23:29:46] One summer I walked around Paris in 38C with no issues (other than having to pay €1 for bottles of cold water over and over), and two weeks later I was in NL on the North Sea coast in 26C too slow to help set up the tent. Humidity makes all the difference [23:29:51] Yeah thanks for that, I was about to ask you to [23:29:58] Yes, A/C would be perfect in this weather [23:30:08] It just doesn't happen enough to justify it [23:30:27] We also have well-insulated houses so it's often colder inside than outside already [23:30:42] No fans? [23:31:05] My dad had one fan in this house in the master bedroom and he decided to get rid of it, I helped him take it down today [23:31:11] He may be regretting that now [23:31:15] ha [23:31:28] (it was a fan+lamp in one, he's replacing it with a different lamp that doesn't have a fan) [23:32:03] you need one of these https://www.amazon.com/Solaration-7001-White-Baseball-Golf/dp/B004C2AQJW [23:32:04] We use fans on super hot days, standalone ones, not ceiling-mounted ones [23:32:16] haha [23:32:24] It's not THAT hot [23:32:33] Yeah, see what you say when you try to sleep [23:32:45] I almost bought one of those in Israel, and we *do* have an A/C [23:33:03] actually, I turned on the A/C so much, I started getting cold [23:33:05] It's too hot for me too sleep, which is not the same as OMG I need a fan hot [23:33:28] (that that's not the case is a problem of its own) [23:33:34] RoanKattouw, the second thing you can do is put a wet towel on the window [23:33:48] But then I have to open the window [23:33:48] That's what we used to do when I was little and we had no A/C [23:33:51] no no [23:34:00] It's hopefully better upstairs than down here anyway [23:34:04] I may be OK [23:34:08] hehe [23:34:17] It is a normal temp in the house after all [23:34:19] well... I hope we don't get poached RoanKattouw tomorrow [23:34:20] Just high humidity [23:35:21] Hmm it's not going below 20C outside tonight, that is warm [23:35:32] Kind of crazy for nighttime temps actually [23:35:54] And supposedly it's 92% (!) humidity outside [23:36:05] yikes [23:36:28] Aaanyway [23:36:31] At this point, you can just call it a sauna [23:36:37] Yeah pretty much [23:36:44] Swim to bed, Roan [23:36:47] Yup [23:36:53] Have a good night ;) [23:36:57] I will be swimming in my sleep and dreaming of titles and pages [23:37:00] Night [23:37:06] haha [23:53:30] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07Browser-Support-Firefox, 13Patch-For-Review, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): (Firefox only) Side bar displays nested 'Pages with unread notifications - https://phabricator.wikimedia.org/T138454#2403717 (10Etonkovidova) Checked the fix...