[00:40:22] 10Notifications, 07I18n: Notifications - https://phabricator.wikimedia.org/T138363#2398099 (10Krenair) [00:40:30] 10Notifications, 07I18n: Notification time format - https://phabricator.wikimedia.org/T138363#2398088 (10Krenair) [08:12:38] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2398245 (10jmatazzoni) OK then, it sounds like we have a new plan. I think Roan's and Pau both agree that the foll... [08:14:17] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2398251 (10jmatazzoni) [08:17:26] 10Notifications, 07I18n: Notification time format - https://phabricator.wikimedia.org/T138363#2398263 (10Aklapper) Hi @Umar, thanks for taking the time to report this! Please describe here which time format you would expect / is the "right" one, and provide a link / URL to reproduce the problem (currently exc... [08:24:06] 10Notifications, 07I18n: Notification time format - https://phabricator.wikimedia.org/T138363#2398299 (10Umar) We have already set the time format (2016 ш. 22 июнь). http://pastenow.ru/Upload/Paste/QC7L.png [08:28:00] 10Notifications, 07I18n: Notification time format - https://phabricator.wikimedia.org/T138363#2398306 (10Umar) Use it https://translatewiki.net/wiki/MediaWiki:June/ce [08:37:16] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, and 2 others: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2398329 (10Trizek-WMF) [08:38:25] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements, 06Editing-Analysis: Find top 50 Twinkle Users - https://phabricator.wikimedia.org/T138025#2398331 (10jmatazzoni) @Neil_P._Quinn_WMF, when I click on the document linked above, 2016-06 top Twinkle users.ods, I go to a Phabricator page but don't see... [08:44:05] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2398333 (10Trizek-WMF) Is the incoming change... [08:49:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements, 06Editing-Analysis: Find top 50 Twinkle Users - https://phabricator.wikimedia.org/T138025#2398337 (10Trizek-WMF) @jmatazzoni, there is a link "download that file" on the right sidebar when you click on F4189856. I agree that's not obvious to find. [09:37:12] 10Notifications, 07I18n: Notification time format - https://phabricator.wikimedia.org/T138363#2398396 (10Umar) Error of Chechen Wikipedia. [09:46:26] (03PS1) 10Paladox: Add VE module check to #isSupported [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295459 (https://phabricator.wikimedia.org/T131055) [09:51:50] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (owner: 10WMDE-Fisch) [09:57:28] (03PS1) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295462 (https://phabricator.wikimedia.org/T135901) [09:57:56] (03PS1) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295463 (https://phabricator.wikimedia.org/T135901) [09:58:20] (03CR) 10jenkins-bot: [V: 04-1] Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295463 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [09:58:29] (03PS2) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295463 (https://phabricator.wikimedia.org/T135901) [09:58:51] (03Abandoned) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295463 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [10:07:00] (03PS2) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295462 (https://phabricator.wikimedia.org/T135901) [10:16:57] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2398558 (10Paladox) Openning it here https://www.mediawiki.org/wiki/Project:Support_desk and clicking edit on a comment returns this error Unable to get property 'model' of undefined or null reference Meaning c... [10:22:22] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2398581 (10Trizek-WMF) p:05High>03Normal Page has been rev... [10:26:11] (03PS1) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) [10:26:59] (03PS2) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) [10:30:38] (03CR) 10jenkins-bot: [V: 04-1] Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [10:48:16] 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 07WorkType-Maintenance: Migrate Flow content to new separate logical External Store in production - https://phabricator.wikimedia.org/T106363#2398658 (10jmatazzoni) [10:48:18] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Run External Store migration for real on Beta - https://phabricator.wikimedia.org/T119568#2398657 (10jmatazzoni) 05Open>03Resolved [10:48:56] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Run External Store migration for real on Beta - https://phabricator.wikimedia.org/T119568#1829848 (10jmatazzoni) [10:48:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 10DBA: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2398659 (10jmatazzoni) 05Open>03Resolved [10:50:31] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2398662 (10jmatazzoni) [10:50:32] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Add ability to filter notifications by title - https://phabricator.wikimedia.org/T137139#2398661 (10jmatazzoni) 05Open>03Resolved [10:51:01] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 10DBA: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2398664 (10jmatazzoni) [10:51:03] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): External Store dry run wrongly detects failed insert if $wgCompressRevisions is true - https://phabricator.wikimedia.org/T136887#2398663 (10jmatazzoni) 05Open>03Resolved [10:51:48] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 10DBA: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#1829837 (10jmatazzoni) [10:51:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 13Patch-For-Review: Set up Flow-specific External Store cluster on Beta (secondary to the main one) - https://phabricator.wikimedia.org/T128417#2398665 (10jmatazzoni) 05Open>03Resolved [10:53:40] 06Collaboration-Team-Interested, 10Flow, 10DBA, 06Operations, 07WorkType-Maintenance: Setup separate logical External Store for Flow in production - https://phabricator.wikimedia.org/T107610#2398667 (10jcrespo) I have not forgotten about this, it is on 'Next', blocked on me having proper time (there is n... [11:04:44] (03PS1) 10Paladox: Replace symbolic link with partial [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295468 (https://phabricator.wikimedia.org/T103702) [11:09:01] (03CR) 10jenkins-bot: [V: 04-1] Replace symbolic link with partial [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295468 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [11:12:04] (03PS1) 10Paladox: Replace symbolic link with partial [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) [11:15:17] (03CR) 10jenkins-bot: [V: 04-1] Replace symbolic link with partial [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [11:17:07] (03PS2) 10Paladox: Replace symbolic link with partial [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295468 (https://phabricator.wikimedia.org/T103702) [11:20:15] (03PS3) 10Paladox: Replace symbolic link with partial [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/295468 (https://phabricator.wikimedia.org/T103702) [11:22:25] (03PS1) 10Paladox: Remove composer.lock file [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295471 [11:23:50] (03CR) 10Paladox: "I fixed the composer errors in https://gerrit.wikimedia.org/r/#/c/295471/" [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [11:24:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [11:35:18] (03PS3) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) [11:38:29] (03CR) 10jenkins-bot: [V: 04-1] Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [11:45:25] (03PS4) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) [11:47:16] (03CR) 10Paladox: "Composer errors are unrelated." [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [11:48:30] (03CR) 10jenkins-bot: [V: 04-1] Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [11:49:46] (03PS2) 10Paladox: Replace symbolic link with partial [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) [11:50:34] (03CR) 10Paladox: "composer errors are unrelated and fixed in I6bb8103c9db0a03b5f74fa36b1174522b70c889d" [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [11:55:16] 10Notifications: echo email notifications don't use correct link when duplicate session names are used - https://phabricator.wikimedia.org/T138384#2398740 (10Isarra) [12:04:04] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Investigate cases where no mention happens due edit instead of addition - https://phabricator.wikimedia.org/T136323#2330640 (10Addshore) So mentions will only be carried out if the action has a type of 'add-comment' or... [12:04:35] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Investigate cases where no mention happens due edit instead of addition - https://phabricator.wikimedia.org/T136323#2398779 (10Addshore) [12:05:09] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Investigate cases where no mention happens due edit instead of addition - https://phabricator.wikimedia.org/T136323#2330640 (10Addshore) a:03Addshore [12:10:09] (03CR) 10Legoktm: [C: 032] Remove composer.lock file [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295471 (owner: 10Paladox) [12:13:12] (03Merged) 10jenkins-bot: Remove composer.lock file [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295471 (owner: 10Paladox) [12:28:19] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Also send notifications to self - https://phabricator.wikimedia.org/T138080#2388575 (10Addshore) Well, a link in the signiture will result in every comment by a user triggering a mention of themself, is this really some... [12:37:03] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Investigate signature problems and mention failure notifications - https://phabricator.wikimedia.org/T137896#2383017 (10Addshore) > signature was not the same as ~~~ or ~~~~ The code does not care about ~~~~ at all and... [12:37:49] (03PS1) 10Addshore: Fix type of beginning in phpdoc [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295479 [12:59:39] (03PS1) 10Sbisson: [WIP] Split flow-* and flowusertalk-* notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295484 (https://phabricator.wikimedia.org/T138220) [13:00:39] hey mlitn [13:00:53] hey stephanebisson [13:01:13] mlitn: could you give me your opinion on https://gerrit.wikimedia.org/r/#/c/295484/ before I go nuts and split all types? [13:02:16] (03PS2) 10Jforrester: docs: Fix typo of 'begining' instead of 'beginning' in phpdoc [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295479 (owner: 10Addshore) [13:02:26] (03CR) 10Jforrester: [C: 032] docs: Fix typo of 'begining' instead of 'beginning' in phpdoc [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295479 (owner: 10Addshore) [13:02:41] sure, I’ll take a look [13:04:04] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Also send notifications to self - https://phabricator.wikimedia.org/T138080#2398894 (10Lea_WMDE) Would it be possible (with a reasonable amount of work) to not consider links in signatures links when it comes to mention... [13:11:26] (03Merged) 10jenkins-bot: docs: Fix typo of 'begining' instead of 'beginning' in phpdoc [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295479 (owner: 10Addshore) [13:12:05] stephanebisson: I like that patch, +1 for doing it for all types! [13:13:47] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Also send notifications to self - https://phabricator.wikimedia.org/T138080#2398962 (10Addshore) >>! In T138080#2398894, @Lea_WMDE wrote: > Would it be possible (with a reasonable amount of work) to not consider links i... [13:17:15] (03PS1) 10Addshore: Allow self mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) [13:17:38] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review, 03TCB-Team-Sprint-2016-06-16: Also send notifications to self - https://phabricator.wikimedia.org/T138080#2388575 (10Addshore) a:03Addshore [13:27:26] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Investigate cases where no mention happens due edit instead of addition - https://phabricator.wikimedia.org/T136323#2399010 (10Lea_WMDE) > IMO this could result in many unexpected things, for example if I simply want to... [13:33:18] (03PS5) 10Paladox: Use VisualEditorSupportCheck [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) [13:33:32] (03CR) 10Paladox: "Rebased to fix composer errors." [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295466 (https://phabricator.wikimedia.org/T135901) (owner: 10Paladox) [13:33:44] (03PS3) 10Paladox: Replace symbolic link with partial [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) [13:33:53] (03CR) 10Paladox: "Rebased to fix composer errors." [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [13:37:17] (03CR) 10jenkins-bot: [V: 04-1] Replace symbolic link with partial [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [13:49:48] 10Collab-Notifications-Page, 07Documentation: Add a link from Special:Notifications on wikis to Special:Notifications help page - https://phabricator.wikimedia.org/T138395#2399087 (10Trizek-WMF) [14:01:39] 10Flow, 10Pywikibot-Flow, 10MediaWiki-API: Broken topics on test wiki that the API doesnt believe exists - https://phabricator.wikimedia.org/T138306#2399153 (10hashar) [14:15:21] 10Collab-Notifications-Page, 07Documentation: Change link to help page on Special:Notifications - https://phabricator.wikimedia.org/T138395#2399238 (10Trizek-WMF) a:03Mooeypoo [14:32:30] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2399342 (10Catrope) a:05jmatazzoni>03Catrope [14:33:56] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Display page-less notifications together with the user page - https://phabricator.wikimedia.org/T137502#2370031 (10Catrope) [14:39:37] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review, 03TCB-Team-Sprint-2016-06-16: Also send notifications to self - https://phabricator.wikimedia.org/T138080#2399406 (10Addshore) p:05Triage>03Normal [14:39:55] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Investigate cases where no mention happens due edit instead of addition - https://phabricator.wikimedia.org/T136323#2399409 (10Addshore) p:05Triage>03Normal [14:49:35] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2399422 (10Catrope) >>! In T129366#2398333, @... [14:51:51] 10Notifications: echo email notifications don't use correct link when duplicate session names are used - https://phabricator.wikimedia.org/T138384#2398740 (10Fomafix) Related to {T2111}. [14:51:53] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Create notifications page structured search - https://phabricator.wikimedia.org/T132805#2399425 (10Trizek-WMF) Shouldn't we add to the list: * a wiki (eo.wiktionary.org) * a language (i.e. searching for a notification from a Francophone wiki) [15:03:28] Can't login on Beta Wikipedia. As always. [15:25:11] Beta is legitimately non-SUL, FWIW [16:03:24] (03CR) 10Paladox: "recheck" [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/295469 (https://phabricator.wikimedia.org/T103702) (owner: 10Paladox) [16:19:36] 10Notifications, 07Browser-Support-Apple-Safari: Special:Notifications broken on Safari 4 - https://phabricator.wikimedia.org/T138424#2399749 (10TheDJ) [16:26:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, and 2 others: [minor] Order of wikis in collapsed cross-wiki notifications is different when the list is exapnded - https://phabricator.wikimedia.org/T138115#2399773 (10Etonkovidova) Checked in testwiki ( 1.28.0-wmf.7) - the... [16:28:40] (03PS2) 10WMDE-Fisch: DRAFT Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 [16:29:16] (03CR) 10WMDE-Fisch: DRAFT Echo notifications for simple mention failures (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (owner: 10WMDE-Fisch) [16:30:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Write an update about that is going on concerning ptwikibooks LqT-to-Flow conversion - https://phabricator.wikimedia.org/T136555#2399814 (10Trizek-WMF) [16:31:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Write an update about that is going on concerning ptwikibooks LqT-to-Flow conversion - https://phabricator.wikimedia.org/T136555#2338761 (10Trizek-WMF) a:05Trizek-WMF>03matthiasmullie Draft... [16:32:59] (03CR) 10jenkins-bot: [V: 04-1] DRAFT Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (owner: 10WMDE-Fisch) [16:40:37] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 2 others: Enable Flow as a Beta feature on Polish Wikipedia - https://phabricator.wikimedia.org/T130009#2399838 (10Trizek-WMF) a:05Trizek-WMF>03None I can't do more than I did. Please re-assign m... [16:47:35] (03PS2) 10Sbisson: [WIP] Split flow-* and flowusertalk-* notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295484 (https://phabricator.wikimedia.org/T138220) [16:47:50] (03PS3) 10Sbisson: Split flow-* and flowusertalk-* notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295484 (https://phabricator.wikimedia.org/T138220) [16:50:08] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Make user-talk-related Flow notifications their own types - https://phabricator.wikimedia.org/T138220#2399870 (10SBisson) a:03SBisson [16:51:13] 06Collaboration-Team-Interested, 10MobileFrontend, 06Reading-Web-Backlog, 07Design: Very long talk pages unreadable - https://phabricator.wikimedia.org/T116686#2399874 (10Jhernandez) @nirzar How do we want to solve this? Stop indenting after a certain depth? Reset indentation after a certain indentation?... [16:51:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 3 others: Enable Flow as a Beta feature on Polish Wikipedia - https://phabricator.wikimedia.org/T130009#2399879 (10Urbanecm) [16:54:19] (03PS1) 10Sbisson: Support for PlaceholderWidget with no link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295555 (https://phabricator.wikimedia.org/T137490) [17:14:31] (03PS3) 10WMDE-Fisch: DRAFT Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 [17:18:28] (03CR) 10jenkins-bot: [V: 04-1] DRAFT Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (owner: 10WMDE-Fisch) [18:01:53] (03CR) 10Catrope: [C: 032] Support for PlaceholderWidget with no link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295555 (https://phabricator.wikimedia.org/T137490) (owner: 10Sbisson) [18:09:13] (03Merged) 10jenkins-bot: Support for PlaceholderWidget with no link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295555 (https://phabricator.wikimedia.org/T137490) (owner: 10Sbisson) [18:15:08] (03CR) 10Catrope: [C: 04-1] Split flow-* and flowusertalk-* notifications (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295484 (https://phabricator.wikimedia.org/T138220) (owner: 10Sbisson) [18:16:47] (03PS1) 10Catrope: Use the actual total notification count in the special page sidebar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295561 [18:29:40] RoanKattouw, when I .abort() a request, does that trigger .reject() ? [18:30:10] * mooeypoo is super confused about the rejected promises in her prioritizer [18:33:11] mooeypoo: Yes, if they're jquery AJAX promises [18:33:21] mw.Api() count, I assume [18:33:24] okay that explains it [18:33:36] I'll have to abort the previous promise *after* I set the new one [18:33:48] However, JSONP requests may not do that, and generally people may give you promises with no-op abort() functions [18:34:05] I kept first rejecting the previous promise and then setting it to the new, and I kept getting "failed promise" console logs for all the promises that were supposed to be "silenced" [18:34:06] So you should assume that it *can* happen, not that it *will* [18:34:15] yeah I assume it can [18:34:18] I don't trust it [18:34:53] All I care about is the final promise, so I have setSuccess and setFailure for the promises, and these first check if they have the *final* promise before they resolve the main deferred object [18:35:28] except, I aborted the previous promise FIRST before setting the new, so essentially, the condition is true, my deferred object kept failing before setting the new promise to wait for [18:35:33] So that explains it [18:36:18] Also, it doesn't help that when I fail the deferred I set it back to null. bah. [18:37:07] (03CR) 10Sbisson: Split flow-* and flowusertalk-* notifications (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295484 (https://phabricator.wikimedia.org/T138220) (owner: 10Sbisson) [18:37:14] (03PS4) 10Sbisson: Split flow-* and flowusertalk-* notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295484 (https://phabricator.wikimedia.org/T138220) [18:47:24] (03PS1) 10Mooeypoo: Add a PromisePrioritizer and use it for notifications fetching [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295565 (https://phabricator.wikimedia.org/T136895) [18:47:48] RoanKattouw, ^^ [18:48:25] RoanKattouw, I didn't want to use events like the original "Prioritizer" used, so I tricked it a bit with promises. See if my trickses are okay and that I didn't miss anything? Slightly concerned with that. [18:51:54] (03CR) 10jenkins-bot: [V: 04-1] Add a PromisePrioritizer and use it for notifications fetching [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295565 (https://phabricator.wikimedia.org/T136895) (owner: 10Mooeypoo) [18:52:56] (03PS2) 10Mooeypoo: Add a PromisePrioritizer and use it for notifications fetching [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295565 (https://phabricator.wikimedia.org/T136895) [18:55:03] (03CR) 10Catrope: Add a PromisePrioritizer and use it for notifications fetching (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295565 (https://phabricator.wikimedia.org/T136895) (owner: 10Mooeypoo) [18:55:35] (03CR) 10Catrope: [C: 04-1] "Comments on PS1 (some were already addressed in PS2)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295565 (https://phabricator.wikimedia.org/T136895) (owner: 10Mooeypoo) [18:56:00] (03CR) 10Catrope: [C: 032] Split flow-* and flowusertalk-* notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295484 (https://phabricator.wikimedia.org/T138220) (owner: 10Sbisson) [19:04:01] (03Merged) 10jenkins-bot: Split flow-* and flowusertalk-* notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295484 (https://phabricator.wikimedia.org/T138220) (owner: 10Sbisson) [19:06:18] mooeypoo: It looks fine to me but I think you could avoid the double-then thing [19:26:19] RoanKattouw, how? [19:26:26] I was trying to, but I couldn't figure it out [19:26:43] oh, you wrote a comment [19:27:54] apply! of cours [19:28:00] e* [19:32:49] (03CR) 10Mooeypoo: Add a PromisePrioritizer and use it for notifications fetching (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295565 (https://phabricator.wikimedia.org/T136895) (owner: 10Mooeypoo) [19:33:35] (03PS3) 10Mooeypoo: Add a PromisePrioritizer and use it for notifications fetching [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295565 (https://phabricator.wikimedia.org/T136895) [19:33:44] RoanKattouw, ^^ thanks for that. I was playing around with nested resolving and such to avoid the wrapping of another promise but that solved it! [19:34:22] RoanKattouw, if you want to test it, it's pretty satisfying to watch the Network tab in chrome while quickly clicking the All/Read/Unread filter (including double-clicking the same button) [19:34:40] They all turn red except the last one [19:35:17] Hm, I should do the same for the sidebar [19:36:27] oh, i forgot i don't need to remove the disabled'ness of it, and fetching works with the prioritizer too. [19:37:35] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Status filter should not become disabled between status change in the Notification Page - https://phabricator.wikimedia.org/T136895#2400228 (10Mooeypoo) a:03Mooeypoo [19:39:00] (03PS1) 10Mooeypoo: Change link to help page on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295574 (https://phabricator.wikimedia.org/T138395) [19:39:28] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07Documentation, 13Patch-For-Review: Change link to help page on Special:Notifications - https://phabricator.wikimedia.org/T138395#2400235 (10Mooeypoo) [19:41:18] (03CR) 10Catrope: [C: 032] Change link to help page on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295574 (https://phabricator.wikimedia.org/T138395) (owner: 10Mooeypoo) [19:42:53] 03Collab-Team-2016-Apr-Jun-Q4: Notificaitons page: Titles and messages are not truncated - https://phabricator.wikimedia.org/T138433#2400250 (10Etonkovidova) [19:44:31] wow [19:44:49] also, wtf, truncation is done server-side, isn't it? [19:48:35] (03Merged) 10jenkins-bot: Change link to help page on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295574 (https://phabricator.wikimedia.org/T138395) (owner: 10Mooeypoo) [20:14:26] mooeypoo: not sure... stephanebisson was dealing with truncation [20:33:49] Some truncation does occur server-side but to pretty generous limits (150 or 200 chars or something) [20:34:01] The popup also truncates client-side [20:34:08] using CSS [20:34:28] 03Collab-Team-2016-Apr-Jun-Q4: Notifications page: Titles and messages are not truncated - https://phabricator.wikimedia.org/T138433#2400349 (10Quiddity) [20:34:56] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Notifications page: Titles and messages are not truncated - https://phabricator.wikimedia.org/T138433#2400250 (10Quiddity) [20:46:23] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2400383 (10ArielGlenn) Non-flow wikis now do not get dumped (see the current https://dumps.wikimedia.org/backup-index.html page). Wiki... [21:03:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2400507 (10ArielGlenn) I'll test the above changeset manually in the next couple of days and see if we get results that differ from dump... [21:12:15] RoanKattouw, yes, but we're using the same widgets for the special page, so I don't understand (a) how are they not truncated the same and (b) how are they not wrapped (!!!) [21:12:43] Well, they have white-space: nowrap; overflow: hidden; text-overflow: ellipsis; [21:12:57] But you need a fixed width for that to do things [21:13:04] (or a max-width) [21:13:22] The popup has a fixed width, the special page seems to not have a fixed/maximum width? [21:14:46] meh [21:14:56] good point. [21:15:23] I may have to add another wrapper *mutters*table layout*mutters* [21:59:11] RoanKattouw, eh. I'm not sure how to fix this properly unless I set max-width on the table or something. Tables seem to disrespect 'width: 100%' [22:00:10] even if they're **wrapped** by a block div that has 100% width for the content area. [22:00:13] it's really crappy. [22:10:39] Oh, right, yes, tables are weird about that [22:11:05] They stretch [22:11:18] Yes :\ [22:11:21] It's midnight so I've forgotten how to fix this [22:11:46] We may need to give it an actual limit of size in pixels [22:11:48] the wrapper [22:11:58] but that would mean it doesn't stretch through the width of the window [22:12:08] ok, go sleep! I'll work on something else, we cna revisit this tomorrow [22:16:18] (03PS1) 10Catrope: [WIP] Implement subject+talk and null+user page grouping in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295591 (https://phabricator.wikimedia.org/T137502) [22:16:31] mooeypoo: Yeah I'm going to bed, but before I go lemme throw two patches at you [22:17:19] mooeypoo: https://gerrit.wikimedia.org/r/#/c/295561 fixes a bug in the side bar. I wasn't too sure about the frontend side of it, and the functions adding up notification counts may be deletable now [22:17:33] * mooeypoo nods [22:17:51] mooeypoo: And https://gerrit.wikimedia.org/r/295591 is the backend part of the page grouping stuff [22:18:18] If you pass &unpgrouppages=1 it'll group subject and talk pages together, and group notifications with no title (title=null) with the user page [22:18:55] It also enables the API to return title=null entries in non-grouped mode, but I think we'll want to use grouped mode for the sidebar. Non-grouped mode is really only there for generic usefulness and living up to its name IMO [22:19:14] Also, this changes the output format (from an object keyed by pageid to an array), so it'll break the frontend completely [22:19:27] oi [22:19:31] ok [22:19:38] I can pick this back up tomorrow, but if you run out of stuff to do you could adjust the frontend code for that change [22:20:12] And regardless of whether you run out of stuff to do, please review the first patch :) [22:20:32] ok, so I'll put my front end stuff on top of the second commit [22:20:36] and I'll review the first one [22:20:39] Sounds good [22:21:24] I'll pick it back up in the morning, incorporating whatever you write in the next couple hours [22:21:35] * mooeypoo nods [22:22:02] If you don't get to it, that's fine, I'll do it tomorrow, but I figured you may be able to do this quicker than me and you seem to be picking away at smallish things right now [22:26:01] * mooeypoo nods [22:26:02] yeah [22:54:36] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2103549 (10Etonkovidova) @Catrope: is the fol... [23:07:22] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2400680 (10Catrope) >>! In T129366#2400648, @...