[00:33:43] (03PS1) 10Mooeypoo: [wip] Fade in/out elements that are moved in the notifications list [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295318 (https://phabricator.wikimedia.org/T126214) [00:36:27] (03PS4) 10Mooeypoo: Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) [00:37:51] (03CR) 10jenkins-bot: [V: 04-1] [wip] Fade in/out elements that are moved in the notifications list [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295318 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo) [06:39:06] 06Collaboration-Team-Interested, 10Flow, 10Notifications: Find a way to avoid Notifications spam when a new topic is created on a Flow page you watch - https://phabricator.wikimedia.org/T138204#2395740 (10Pginer-WMF) There is also a more general proposal to mute notifications of a type affecting a given page... [06:44:58] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2395747 (10Pginer-WMF) >>! In T126214#2388956, @jmatazzoni wrote: > @Pgine... [11:05:47] 10Pywikibot-Flow, 10Pywikibot-core: flow.topics doesn't support parameter sort_by='updated' with limit values set. - https://phabricator.wikimedia.org/T138215#2396049 (10jayvdb) [11:08:01] 10Pywikibot-Flow, 10Pywikibot-core: flow.topics doesn't support parameter sort_by='updated' with limit values set. - https://phabricator.wikimedia.org/T138215#2396051 (10jayvdb) In your first example, `limit=2` should only return two topics. I've confirmed that many topics are returned, seemingly unending, ex... [11:18:18] (03CR) 10Sbisson: [C: 032] Remove automatic mark-as-read-when-seen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293761 (https://phabricator.wikimedia.org/T132525) (owner: 10Catrope) [11:27:27] (03Merged) 10jenkins-bot: Remove automatic mark-as-read-when-seen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293761 (https://phabricator.wikimedia.org/T132525) (owner: 10Catrope) [11:28:41] 10Pywikibot-Flow, 10Pywikibot-core: flow.topics doesn't support parameter sort_by='updated' with limit values set. - https://phabricator.wikimedia.org/T138215#2396055 (10jayvdb) p:05Triage>03High Ok, there is definitely a bug in flow.py 's `Board.topics`, that it effectively ignores the limit argument, bec... [11:35:29] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2007634 (10Catrope) >>! In T126214#2395747, @Pginer-WMF wrote: > I don't r... [11:35:44] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2396064 (10Catrope) >>! In T126214#2395747, @Pginer-WMF wrote: > I don't r... [11:36:19] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2396065 (10Catrope) >>! In T126214#2395747, @Pginer-WMF wrote: > I don't r... [11:39:33] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2396068 (10Pginer-WMF) [11:43:07] (03CR) 10Sbisson: [C: 04-1] "It looks great." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo) [11:45:11] 10Notifications: UPO on "Special:Preferences" for cross wiki notifications should not show on stand alone wiki - https://phabricator.wikimedia.org/T138132#2396071 (10Kghbln) 05Open>03Resolved a:03Kghbln Ah there was a related issue at T135266. Just updated my wiki to 7d63196 of REL1_27 et voilà! Thank you... [11:45:26] 10Notifications: UPO on "Special:Preferences" for cross wiki notifications should not show on stand alone wiki - https://phabricator.wikimedia.org/T138132#2396076 (10Kghbln) a:05Kghbln>03Catrope [11:56:28] 06Collaboration-Team-Interested, 10Flow, 10Notifications: Find a way to avoid Notifications spam when a new topic is created on a Flow page you watch - https://phabricator.wikimedia.org/T138204#2396127 (10Trizek-WMF) Thanks Pau! That task is the one I was looking for. But I'm afraid that task about muting i... [12:01:20] (03PS1) 10Sbisson: Define global transition vars before using them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295335 (https://phabricator.wikimedia.org/T132954) [12:01:31] RoanKattouw: ^ [12:01:46] Oh for... [12:02:00] (03CR) 10Catrope: [C: 032] Define global transition vars before using them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295335 (https://phabricator.wikimedia.org/T132954) (owner: 10Sbisson) [12:02:01] Thanks for catching that [12:02:30] (03CR) 10Catrope: [C: 04-1] Change mark as read buttons to circles (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo) [12:02:36] RoanKattouw: notices just explode for me [12:02:58] Oh, did you change the error level for that? [12:03:01] Or does MWV ship that way? [12:03:22] I don't remember doing that, it must be part of mwv [12:10:08] (03Merged) 10jenkins-bot: Define global transition vars before using them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295335 (https://phabricator.wikimedia.org/T132954) (owner: 10Sbisson) [12:23:49] (03CR) 10Catrope: "I think your use of margins is what's causing all the problems:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo) [12:24:48] (03CR) 10Catrope: "(Sorry, margin-right: -1.4em is not pre-existing, that was changed from -0.4em in this commit)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo) [12:28:38] 10Flow, 10Notifications, 10MediaWiki-Watchlist: Open flow link from notification popup doesn't affect watchlist - https://phabricator.wikimedia.org/T138236#2394319 (10Catrope) When you say it's "not marked as read", do you mean it's not marked as read in the notification popup, or it's not marked as read in... [12:30:01] 10Flow, 10Notifications, 10MediaWiki-Watchlist: Open flow link from notification popup doesn't affect watchlist - https://phabricator.wikimedia.org/T138236#2396190 (10IKhitron) It stays in the watchlist as bold. [12:30:18] (03PS1) 10Sbisson: Improve client-side unread count estimation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295337 [12:31:05] Oooh that explains the bugs that I was seeing in testing yesterday [12:31:27] It worked correctly with a non-bundled notification so I figured it probably wasn't my transition code's fault, but I forgot to report it [12:32:40] (03CR) 10Catrope: [C: 032] Improve client-side unread count estimation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295337 (owner: 10Sbisson) [12:32:47] 10Pywikibot-Flow, 10Pywikibot-core: flow.topics continuation breaks when sort_by='updated' - https://phabricator.wikimedia.org/T138215#2396193 (10jayvdb) [12:33:57] RoanKattouw: I've been seeing counter weirdness for a while. I'm not sure this patch fixes everything but it's a start. [12:34:22] I am cutting the 1.28.0-wmf.7 branch [12:34:35] maybe you would need to backport that patch [12:34:57] hashar: Thanks for letting me know [12:35:00] Yeah I will, if needed [12:35:18] Also, thanks for cutting it this early, I have something I want to deliberately merge right after the cut [12:36:08] RoanKattouw: are we merging "dynamic bundle" this week or next? [12:37:14] Echo has been cut already I believe [12:37:18] stephanebisson: Next week. Same schedule as https://phabricator.wikimedia.org/T123018#2394112 [12:37:25] well you can tell if you see 1.28.0-wmf.7 :] [12:37:26] (I should copy that across to the bundling task) [12:37:36] hashar: Yup. I'll backport if needed [12:38:08] Yeah, wmf.7 exists already [12:39:06] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice: Change bundling system to allow individual treatment - https://phabricator.wikimedia.org/T120153#2396203 (10Catrope) This will be deployed according to the same schedule as T123018#2394112. [12:39:16] (03Merged) 10jenkins-bot: Improve client-side unread count estimation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295337 (owner: 10Sbisson) [12:40:05] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2396208 (10Catrope) This will be deployed at the same schedule as T123018#2394112 --> #user-notice [12:40:31] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Change bundling system to allow individual treatment - https://phabricator.wikimedia.org/T120153#2396212 (10Catrope) [12:50:37] (03PS1) 10Catrope: Improve client-side unread count estimation [extensions/Echo] (wmf/1.28.0-wmf.7) - 10https://gerrit.wikimedia.org/r/295338 [12:50:46] (03CR) 10Catrope: [C: 032] Improve client-side unread count estimation [extensions/Echo] (wmf/1.28.0-wmf.7) - 10https://gerrit.wikimedia.org/r/295338 (owner: 10Catrope) [12:58:52] (03Merged) 10jenkins-bot: Improve client-side unread count estimation [extensions/Echo] (wmf/1.28.0-wmf.7) - 10https://gerrit.wikimedia.org/r/295338 (owner: 10Catrope) [12:59:06] (03PS2) 10Catrope: Script to restore LQT topics to their pre-import state [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295217 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [12:59:59] magic [13:02:51] all set. tin has the Echo backport - 07ebf1f6f334586536dd33ece7d6bfed5c99101b ) [13:03:09] (03CR) 10jenkins-bot: [V: 04-1] Script to restore LQT topics to their pre-import state [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295217 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [13:08:38] (03CR) 10Catrope: [C: 032] Script to restore LQT topics to their pre-import state [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295217 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [13:08:53] Thanks hashar [13:09:40] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2396241 (10Catrope) [13:09:42] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 05MW-1.28-release-notes, 13Patch-For-Review, and 3 others: Dynamic bundle: non-bundle_base notifications need a read timestamp - https://phabricator.wikimedia.org/T136368#2396239 (10Catrope) 05Open>03Resolved >>! In T136368#2396234, @Stashbot wrote: > {na... [13:16:30] (03Merged) 10jenkins-bot: Script to restore LQT topics to their pre-import state [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295217 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [13:19:18] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Documentation, 07Tracking: Update Help:Notifications (tracking) - https://phabricator.wikimedia.org/T119713#2396252 (10Trizek-WMF) That page is going to change, due to incoming changes: *{T123018} *{T114356} *{... [13:25:56] (03PS1) 10Catrope: SubGroupListWidget: use timestamp from model. not from listWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295340 (https://phabricator.wikimedia.org/T138115) [13:26:14] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: [minor] Order of wikis in collapsed cross-wiki notifications is different when the list is exapnded - https://phabricator.wikimedia.org/T138115#2396277 (10Catrope) a:03Catrope [13:37:54] (03PS2) 10Catrope: SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295340 (https://phabricator.wikimedia.org/T138115) [13:41:43] (03CR) 10jenkins-bot: [V: 04-1] SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295340 (https://phabricator.wikimedia.org/T138115) (owner: 10Catrope) [13:41:47] (03PS3) 10Sbisson: SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295340 (https://phabricator.wikimedia.org/T138115) (owner: 10Catrope) [13:42:32] (03CR) 10Sbisson: [C: 032] SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295340 (https://phabricator.wikimedia.org/T138115) (owner: 10Catrope) [13:42:47] (03CR) 10Sbisson: SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295340 (https://phabricator.wikimedia.org/T138115) (owner: 10Catrope) [13:43:23] (03CR) 10Sbisson: [C: 032] SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295340 (https://phabricator.wikimedia.org/T138115) (owner: 10Catrope) [13:46:21] (03PS51) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [13:47:16] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138303#2396460 (10Sumit) [13:47:54] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2396478 (10Sumit) [13:49:34] (03Merged) 10jenkins-bot: SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295340 (https://phabricator.wikimedia.org/T138115) (owner: 10Catrope) [13:54:05] (03PS52) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [13:59:40] RoanKattouw, when that task is going to be alive? https://phabricator.wikimedia.org/T138115 [14:00:02] I'm asking, because it is a typical case of polishing people like. [14:00:33] Theoretically, next week (June 28-30), but it'd be easy to expedite [14:00:56] hashar: Have you already pulled wmf.7 onto tin? Is it OK if I cherry-pick another small Echo fix? [14:01:06] RoanKattouw: yeah I did [14:01:13] feel free to backport whatever you need [14:01:21] scap is running right now though [14:01:21] next week is fine to me, RoanKattouw [14:01:37] will let you know when it is done (or monitor -operations) [14:01:46] OK [14:01:52] If Trizek is happy to wait till next week then I won't bother [14:02:01] had the change been merged a few hours ago, it would have landed in the wmf branch [14:02:01] Everyone's at Wikimania this week anyway :P [14:02:05] so it is fine to backport it [14:02:10] OK [14:02:11] to me that sounds just like a timing issue :D [14:02:27] I guess you're not going to deploy wmf.7 anywhere for another 4 hours or so? [14:02:34] yeah [14:02:43] that would be Tyler at the usual scheduled time [14:02:49] 7pm UTC / 9pm CET iirc [14:02:49] I'm not happy to wait, RoanKattouw, I just want to know when I'm supposed to announce it! :þ [14:02:53] OK, then I will feel free to throw any old crap in there until then :P [14:03:15] Trizek: Alright then, I'll expedite it and it'll go out this week (June 21-23 train) [14:03:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice: [minor] Order of wikis in collapsed cross-wiki notifications is different when the list is exapnded - https://phabricator.wikimedia.org/T138115#2396515 (10Trizek-WMF) [14:05:00] Good. [14:05:10] (03PS1) 10Catrope: SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] (wmf/1.28.0-wmf.7) - 10https://gerrit.wikimedia.org/r/295347 (https://phabricator.wikimedia.org/T138115) [14:05:22] (03CR) 10Catrope: [C: 032] SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] (wmf/1.28.0-wmf.7) - 10https://gerrit.wikimedia.org/r/295347 (https://phabricator.wikimedia.org/T138115) (owner: 10Catrope) [14:07:09] Trizek: BTW I've been WP:BOLD and tweaked https://www.mediawiki.org/w/index.php?title=User%3ATrizek_%28WMF%29%2FSandbox%2FSpecial%3ANotifications&type=revision&diff=2169459&oldid=2165161 a bit [14:07:27] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138303#2396536 (10Sumit) [14:07:29] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2396537 (10Sumit) [14:08:16] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Midterm evaluation for "Pywikibot support for Thanks" - https://phabricator.wikimedia.org/T138304#2396478 (10Sumit) [14:11:21] Thank you very much, RoanKattouw. I always appreciate that kind of changes :) [14:13:40] (03Merged) 10jenkins-bot: SubGroupListWidget: use timestamp from model, not from listWidget [extensions/Echo] (wmf/1.28.0-wmf.7) - 10https://gerrit.wikimedia.org/r/295347 (https://phabricator.wikimedia.org/T138115) (owner: 10Catrope) [14:14:03] 10Flow, 10Pywikibot-Flow, 10Continuous-Integration-Infrastructure, 10MediaWiki-API: Broken topics on test wiki that the API doesnt believe exists - https://phabricator.wikimedia.org/T138306#2396549 (10jayvdb) [14:18:51] 10Pywikibot-Flow, 10Pywikibot-core: Board.topics does not respect limit argument - https://phabricator.wikimedia.org/T138307#2396567 (10jayvdb) [14:19:16] 10Pywikibot-Flow, 10Pywikibot-core: Board.topics does not respect limit argument - https://phabricator.wikimedia.org/T138307#2396583 (10jayvdb) [14:20:35] 10Pywikibot-Flow, 10Pywikibot-core: flow.topics continuation breaks when sort_by='updated' - https://phabricator.wikimedia.org/T138215#2393480 (10jayvdb) >>! In T138215#2396051, @jayvdb wrote: > In your first example, `limit=2` should only return two topics. I've confirmed that many topics are returned, seemi... [14:24:38] (03PS22) 10Sbisson: Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [14:26:43] 10Pywikibot-Flow, 10Pywikibot-core: flow.Board.topics continuation breaks when sort_by='updated' - https://phabricator.wikimedia.org/T138215#2396613 (10jayvdb) [14:29:44] 10Flow: Flow as a BEta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2396630 (10Trizek-WMF) [14:30:16] 10Flow: Flow as a Beta feature: enable, disable and reenable doesn't seem to work - https://phabricator.wikimedia.org/T138310#2396643 (10Trizek-WMF) [14:36:50] (03PS1) 10Matthias Mullie: Don't reimport existing headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295350 (https://phabricator.wikimedia.org/T119509) [14:37:45] 10Flow, 10Pywikibot-Flow, 10Continuous-Integration-Infrastructure, 10MediaWiki-API: Broken topics on test wiki that the API doesnt believe exists - https://phabricator.wikimedia.org/T138306#2396675 (10jayvdb) [14:39:31] what the .... [14:39:39] So it looks like Title::newMainPage() doesn't return a consistent value? [14:40:42] Oh that's because 'mainpage' is in $wgForceUIMsgAsContentMsg on commons [14:41:08] Which is why we have 16 different pages that user-rights notifs are associated with on Commons [14:45:58] (03PS1) 10WMDE-Fisch: DRAFT Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 [14:50:06] (03CR) 10jenkins-bot: [V: 04-1] DRAFT Echo notifications for simple mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (owner: 10WMDE-Fisch) [14:57:02] (03CR) 10Addshore: [C: 04-1] DRAFT Echo notifications for simple mention failures (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (owner: 10WMDE-Fisch) [15:40:27] (03CR) 10Catrope: [C: 04-1] Don't reimport existing headers (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295350 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [15:45:29] 10Pywikibot-Flow, 10Pywikibot-core: flow.Board.topics continuation breaks when sort_by='updated' - https://phabricator.wikimedia.org/T138215#2396793 (10jayvdb) [15:45:58] 10Pywikibot-Flow, 10Pywikibot-core: Board.topics does not respect limit argument - https://phabricator.wikimedia.org/T138307#2396794 (10jayvdb) [15:49:02] 10Flow: Can't install Flow on SQLite - https://phabricator.wikimedia.org/T138316#2396799 (10Dereckson) [16:02:39] 10Flow: Can't install Flow on SQLite - https://phabricator.wikimedia.org/T138316#2396861 (10Dereckson) [16:07:00] 10Flow: Can't install Flow on SQLite - https://phabricator.wikimedia.org/T138316#2396862 (10Dereckson) [16:08:07] 10Flow: ALTER TABLE ... CHANGE ... syntax blocks installation or update on SQLite - https://phabricator.wikimedia.org/T138316#2396799 (10Dereckson) [16:40:37] 10Pywikibot-Flow, 10Pywikibot-core: flow.Board.topics continuation breaks when sort_by='updated' - https://phabricator.wikimedia.org/T138215#2396937 (10jayvdb) [16:45:54] 10Pywikibot-Flow, 10Pywikibot-core: flow.Board.topics continuation breaks when reverse=True - https://phabricator.wikimedia.org/T138323#2396960 (10jayvdb) [17:00:58] (03CR) 10Matthias Mullie: Don't reimport existing headers (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295350 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [17:04:16] (03CR) 10Matthias Mullie: Don't reimport existing headers (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295350 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [17:12:52] 10Flow: ALTER TABLE ... CHANGE ... syntax blocks installation or update on SQLite - https://phabricator.wikimedia.org/T138316#2397164 (10Dereckson) SQLite doesn't have the ALTER CHANGE statement (or any other way to mutate a column type) What do we have as solutions? **1. Suggest a manual update** Provide man... [17:14:06] (03CR) 10Catrope: [C: 032] Don't reimport existing headers (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295350 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [17:22:05] (03Merged) 10jenkins-bot: Don't reimport existing headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295350 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [17:27:45] 10Pywikibot-Flow, 10Pywikibot-core: flow.Board.topics continuation breaks when sort_by='updated' - https://phabricator.wikimedia.org/T138215#2397231 (10darthbhyrava) >>! In T138215#2396051, @jayvdb wrote: > In your first example, `limit=2` should only return two topics. I've confirmed that many topics are ret... [18:20:01] (03PS5) 10Mooeypoo: Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) [18:40:10] (03CR) 10Catrope: [C: 04-1] "Looks good except for unaddressed inline comments on PS4" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo) [18:49:18] mooey|away: ---^^ and also the sidebar has 2 very minor -1s that if you address them I'll merge [18:54:05] (03PS6) 10Mooeypoo: Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) [18:57:32] (03CR) 10Catrope: [C: 032] Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo) [18:57:52] (03PS23) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [18:57:53] woot [19:04:59] (03CR) 10Catrope: [C: 04-1] Add a cross-wiki sidebar to the Special:Notifications page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [19:06:03] (03Merged) 10jenkins-bot: Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo) [19:25:03] (03PS1) 10Esanders: Wrap table-cell buttons in table-row [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295381 [19:26:32] 06Collaboration-Team-Interested, 10Notifications: Consider replacing echo_unread_wikis table with a cache - https://phabricator.wikimedia.org/T138341#2397417 (10Catrope) [19:28:24] 10Notifications: Inside of notification window collapses horizontally on narrow screen - https://phabricator.wikimedia.org/T138342#2397429 (10Esanders) [19:28:59] 10Notifications: Inside of notification window collapses horizontally on narrow screen - https://phabricator.wikimedia.org/T138342#2397441 (10Esanders) [19:44:33] (03CR) 10Catrope: [C: 032] Wrap table-cell buttons in table-row [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295381 (owner: 10Esanders) [19:46:51] 10Notifications: Inside of notification window collapses horizontally on narrow screen - https://phabricator.wikimedia.org/T138342#2397429 (10Catrope) This doesn't seem to be related to the `overflow-x: auto` rule on the popup body (workaround for T130153): if I remove that rule, the collapsing behavior is the s... [19:49:55] 06Collaboration-Team-Interested, 10Notifications: Consider replacing echo_unread_wikis table with a cache - https://phabricator.wikimedia.org/T138341#2397512 (10Catrope) [19:54:01] (03Merged) 10jenkins-bot: Wrap table-cell buttons in table-row [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295381 (owner: 10Esanders) [20:08:45] Hmm, so I'm looking at https://grafana.wikimedia.org/dashboard/db/echoflyout , which I haven't looked at in a while [20:09:19] The second graph shows two big increases, one on 5/26 and one on 6/2 [20:09:26] The 5/28 one coincides with the Echo MVC refactor [20:09:56] I don't see an obvious suspect for the 6/2 one but it's smaller [20:12:09] Hmm, maybe that just reflects that we were measuring it wrong before? [20:34:36] 06Collaboration-Team-Interested, 10Notifications: Inside of notification window collapses horizontally on narrow screen - https://phabricator.wikimedia.org/T138342#2397669 (10Catrope) [21:30:49] (03PS2) 10Mooeypoo: Fade in/out elements that are moved in the notifications list [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295318 (https://phabricator.wikimedia.org/T126214) [21:30:57] RoanKattouw, ^^ see if you like this trick [21:35:58] (03PS1) 10Catrope: Add maintenance script to update page IDs of topic-resolved notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295435 (https://phabricator.wikimedia.org/T137501) [21:41:31] mooeypoo: Yeah I saw that earlier and played with it a bit. The code looks alright to me, the behavior felt a bit janky but I couldn't quite put my finger on it [21:41:45] mooeypoo: Also, poke re https://gerrit.wikimedia.org/r/#/c/292600/ [21:42:39] RoanKattouw, I think part of the jankiness is that it is waiting to fade in after fadeout is done, because we're actually moving the item rather than creating a new one while the other one vanishes [21:43:48] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397842 (10Paladox) [21:45:34] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397842 (10Catrope) I can't reproduce this. Could you perhaps attach a screenshot or a video? [21:45:51] mooeypoo: It's only got 2 small comments, if you fix them I'll merge [21:46:00] (03CR) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [21:46:11] If you don't fix them, I'll probably merge before I go to bed anyway but then the docs will be Wrong and I will shed a tear [21:46:28] RoanKattouw, I see one comment, which I just answered [21:46:37] also, meh, I forgot to push my comments on the previous fix [21:46:37] Oh, sorry, yes, I'm thinking of the previous PS [21:47:04] but they're insubstantial [21:47:22] done's and a comment about moving the config to the parent - which you commented about and I just answered [21:47:24] mooeypoo: Basically my thought here is that you should either declare the config option in the base class and provide it for all handlers, or declare it in only one class and provide it only there [21:47:29] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397858 (10Paladox) @catrope hi, before I click the edit button here is what it looks like {F4189845} and after I click the edit button {F4189849} [21:47:39] RoanKattouw, it's provided in all classes [21:47:42] Oh? [21:47:43] it's just **used** in one class [21:47:53] It's in the base class. It's provided to them all [21:48:09] we just use it in foreign api handler specifically but it exists for all others... [21:48:19] Right, but the local one doesn't respecti t [21:48:27] also, the front-end API layer makes me twitch [21:48:41] it has nowhere to respect it, really, but I see your point [21:48:46] I don't mind. I can move it back to the foreign API [21:49:06] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements, 06Editing-Analysis: Find top 50 Twinkle Users - https://phabricator.wikimedia.org/T138025#2397860 (10Neil_P._Quinn_WMF) Good point, @Capt_Swing. The recent changes table distinguishes between edits to existing pages and edits that create a new page,... [21:49:21] OK [21:49:47] (03PS24) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [21:49:53] I now realize that I'm complaining about how well you've polished one specific deck chair on the Titanic, sorry [21:50:13] RoanKattouw, yeah, basically. We need this layer refactored asap [21:50:18] (03CR) 10Catrope: [C: 032] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [21:50:35] woohoo [21:57:51] (03Merged) 10jenkins-bot: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [22:38:05] 06Collaboration-Team-Interested, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6), 07WorkType-Maintenance: Remove orphaned echo_event rows - https://phabricator.wikimedia.org/T136425#2397951 (10Catrope) >>! In T136425#2396242, @Stashbot wrote: > {nav icon=file, name=Mentioned i... [22:38:18] 06Collaboration-Team-Interested, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6), 07WorkType-Maintenance: Remove orphaned echo_event rows - https://phabricator.wikimedia.org/T136425#2397952 (10Catrope) 05Open>03Resolved a:03Catrope [22:39:02] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10DBA, 07Blocked-on-schema-change, 07Schema-change: Schema changes for Echo moderation - https://phabricator.wikimedia.org/T135699#2397955 (10Catrope) >>! In T135699#2334730, @Catrope wrote: >> I've also found that there are lots of orphaned rows in `echo_e... [22:40:08] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397956 (10Catrope) Are there any errors in the JS console? [22:45:39] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2397967 (10Catrope) >>! In T137502#2393610, @Catrope wrote: > (and we'd probably want to clean up `user-rights` not... [22:51:48] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397971 (10Paladox) @catrope yes, XML5632: Only one root element is allowed. Line: 3, Column 2 Dosent allow me to view what the actual line is. SyntaxError load.php (118,398) 'rowspan','colspan'];xmlDoc=ne... [22:53:42] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397975 (10Paladox) Maybe it is a visualeditor error. [22:56:18] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397976 (10Catrope) Probably. Could you try with `?debug=true` and see if you get a more useful error? [22:58:22] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397977 (10Paladox) @Catrope doing that dosent show any error's but stop's js from working. [22:59:25] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397978 (10Catrope) Does this break in Firefox or Chrome, or just in IE? [23:01:26] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2397980 (10Paladox) @catrope seems to break in internet explorer only. Microsoft Edge works. [23:14:47] 10Flow: sessionfailure error when a diff for an hidden discussion is mark as patrolled - https://phabricator.wikimedia.org/T138359#2398006 (10Dereckson) [23:16:49] 10Flow: sessionfailure error when a diff for an hidden discussion is mark as patrolled - https://phabricator.wikimedia.org/T138359#2398019 (10Dereckson) I was able to reproduce the issue with X-Wikimedia-Debug set to mw1017 and log: https://logstash.wikimedia.org/#/dashboard/elasticsearch/request-id?id=V2nKggpA... [23:17:49] 10Flow: sessionfailure error when a diff for an hidden discussion is mark as patrolled - https://phabricator.wikimedia.org/T138359#2398020 (10Dereckson) [23:18:27] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2398021 (10Catrope) Does regular editing with VisualEditor work in IE11? [23:29:23] 10Flow: Editing comments in flow on mw.org does not work - https://phabricator.wikimedia.org/T138356#2398030 (10Paladox) @Catrope yes using regular editing with visualediting works. So maybe it is something in flow broken.