[06:48:38] 10Notifications, 10MediaWiki-General-or-Unknown: Notification e-mail about changed page, but unchanged in history - https://phabricator.wikimedia.org/T138195#2392870 (10Purodha) [08:54:25] 10Notifications, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Translate: Notification e-mail about changed page, but unchanged in history - https://phabricator.wikimedia.org/T138195#2393020 (10Peachey88) > 00:28, 20 June 2016 Base (talk | contribs) marked Tech/News/2016/25 for translation [09:32:33] 06Collaboration-Team-Interested, 10Flow, 10Notifications: Find a way to avoid Notifications spam when a new topic is created on a Flow page you watch - https://phabricator.wikimedia.org/T138204#2393098 (10Trizek-WMF) [09:37:56] 06Collaboration-Team-Interested, 10Notifications, 06TCB-Team, 07German-Community-Wishlist: Notification: Your file was used - https://phabricator.wikimedia.org/T77154#2393114 (10Lea_WMDE) [11:00:28] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Send notification for easy-to-find failed mentions - https://phabricator.wikimedia.org/T136326#2330698 (10WMDE-Fisch) a:03WMDE-Fisch [11:38:24] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: "Failed to fetch notifications." is displayed as a link - https://phabricator.wikimedia.org/T137490#2393356 (10SBisson) a:03SBisson [12:17:15] 10Notifications, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Translate: Notification e-mail about changed page, but unchanged in history - https://phabricator.wikimedia.org/T138195#2392870 (10Nikerabbit) Nothing can be done in Translate about this. [12:18:48] 10Notifications, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Translate: Notification e-mail about changed page, but unchanged in history - https://phabricator.wikimedia.org/T138195#2393458 (10Nikerabbit) [12:43:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements, 07User-notice: Publish Mediawiki page the Edit Review Improvements project - https://phabricator.wikimedia.org/T138125#2393476 (10Qgil) [12:47:11] (03PS9) 10Sbisson: Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [12:47:20] (03CR) 10Sbisson: Make thanks notifications expandable bundles (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [12:47:38] 10Pywikibot-Flow, 10Pywikibot-core: flow.topics doesn't support parameter sort_by='updated' - https://phabricator.wikimedia.org/T138215#2393480 (10darthbhyrava) [12:49:21] 06Collaboration-Team-Interested, 10Pywikibot-Flow, 10Thanks, 10Pywikibot-Thanks, and 2 others: Implement pywikibot support for adding thanks to comments on flow boards - https://phabricator.wikimedia.org/T135411#2393495 (10darthbhyrava) The requirement for reproducibility was to extract the most recently u... [12:49:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Publish Mediawiki page the Edit Review Improvements project - https://phabricator.wikimedia.org/T138125#2393497 (10Trizek-WMF) [12:51:48] (03CR) 10jenkins-bot: [V: 04-1] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [12:52:42] (03PS10) 10Sbisson: Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [12:54:55] 10Pywikibot-Flow, 10Pywikibot-core: flow.topics doesn't support parameter sort_by='updated' with limit values set. - https://phabricator.wikimedia.org/T138215#2393515 (10darthbhyrava) [12:58:59] (03CR) 10Sbisson: [C: 04-1] "I get this when I click on a badge:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [12:59:58] Hrmph I've seen that error before [13:00:04] But I couldn't reproduce it afterwards [13:00:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Publish Mediawiki page the Edit Review Improvements project - https://phabricator.wikimedia.org/T138125#2393517 (10Trizek-WMF) [13:00:41] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Post page describing Edit Review Improvements to Mediawiki - https://phabricator.wikimedia.org/T137741#2393519 (10Trizek-WMF) [13:01:01] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Post page describing Edit Review Improvements to Mediawiki - https://phabricator.wikimedia.org/T137741#2377319 (10Trizek-WMF) 05Open>03Resolved >>! In T138125#2391052, @jmatazzoni wrote: > Here’s the wiki page describing the Edit Review Improvement... [13:02:08] (03PS9) 10Catrope: Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) [13:02:09] Oh, wow, I'm an idiot [13:02:28] (03CR) 10Catrope: "I'm an idiot, forgot to re-test after renaming a variable :/" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [13:16:03] (03PS1) 10Matthias Mullie: After completing move, allow a new one to begin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295215 [13:16:06] (03PS1) 10Matthias Mullie: Fix DB source store for nested structures [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295216 (https://phabricator.wikimedia.org/T119509) [13:16:09] (03PS1) 10Matthias Mullie: Script to restore LQT topics to their pre-import state [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295217 (https://phabricator.wikimedia.org/T119509) [13:17:11] (03CR) 10Catrope: [C: 032] After completing move, allow a new one to begin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295215 (owner: 10Matthias Mullie) [13:24:25] (03CR) 10Catrope: [C: 032] Fix DB source store for nested structures [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295216 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [13:26:21] (03Merged) 10jenkins-bot: After completing move, allow a new one to begin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295215 (owner: 10Matthias Mullie) [13:27:58] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2393610 (10Catrope) >>! In T137502#2380495, @jmatazzoni wrote: > But what about @Catrope's observation that "this p... [13:31:11] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Make Notification page filters bookmarkable - https://phabricator.wikimedia.org/T137862#2393614 (10Catrope) [13:31:58] (03Merged) 10jenkins-bot: Fix DB source store for nested structures [extensions/Flow] - 10https://gerrit.wikimedia.org/r/295216 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [13:37:28] 10Flow, 10Notifications: No orange-bar-of-doom when a message is posted on a user talk page using Flow - https://phabricator.wikimedia.org/T137954#2384854 (10Catrope) >>! In T137954#2385547, @Trizek-WMF wrote: > Is it linked to {T58845}? No, this is not related. This has never worked, because the OBOD only ap... [13:41:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Make user-talk-related Flow notifications their own types - https://phabricator.wikimedia.org/T138220#2393621 (10Catrope) [13:41:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Make user-talk-related Flow notifications their own types - https://phabricator.wikimedia.org/T138220#2393634 (10Catrope) [13:41:53] 10Flow, 10Notifications: No orange-bar-of-doom when a message is posted on a user talk page using Flow - https://phabricator.wikimedia.org/T137954#2393633 (10Catrope) [13:42:02] RoanKattouw: I moved thanks to 'message' and set both transition variables. The counters are both wrong. What should I do now? [13:42:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Make user-talk-related Flow notifications their own types - https://phabricator.wikimedia.org/T138220#2393621 (10Catrope) [13:42:09] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, 07User-notice: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2393635 (10Catrope) [13:42:23] stephanebisson: Did you bump the cache version? [13:42:52] RoanKattouw: right, I thought it was in the commit already [13:43:10] It's in the main re-sort commit [13:43:27] But the dynamic bundles commit bumps it too, to the same value, so you probably have a polluted cache there already [13:43:37] I've just been setting it to 1.8b or 1.8c locally [13:44:52] Also, note that this transition stuff only affects the computation of the global notif counts and presenting cross-wiki notifications. Generally speaking, ignoring misinformation in the echo_unread_wikis table [13:45:08] So another way you could test it is by deliberately injecting misinformation into that table [13:45:50] (Hah, I just realized that "misinformation" is really just a fancy euphemism for "falsehoods") [13:47:47] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2393643 (10Pginer-WMF) > Then we could either add a "No page" item at the bottom of the list, or group all these no... [13:49:55] (03CR) 10Sbisson: "When I bump the cache version and reload, I get those:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [13:53:30] Damn, I need to enable the thing where PHP notices become giant red boxes in the output [13:53:47] yep [13:55:21] (03PS10) 10Catrope: Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) [14:15:40] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2393681 (10Catrope) Full list of notification types that are page-less: - `welcome` - `emailuser` - `user-rights` -... [14:15:45] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements, 07User-notice: Post page describing Edit Review Improvements to Mediawiki - https://phabricator.wikimedia.org/T137741#2393682 (10Qgil) Thank you for this page! @Johan imho this is food for Tech News. [14:48:32] RoanKattouw: I'm ready to merge the transition code, should I wait? [14:54:48] RoanKattouw: in transition mode, when I mark read/unread, it sets the counter wrong [14:57:47] 10Notifications: Revert notifications are not useful with autocomments - https://phabricator.wikimedia.org/T138224#2393773 (10matej_suchanek) [14:58:56] Hah [14:58:59] That's weird [14:59:07] Wrong how? [14:59:18] stephanebisson: Yeah merge at will, preferably today or early tomorrow [14:59:25] Provided you stop finding bugs of course :) [15:00:26] RoanKattouw: NotifUser::resetNotificationCount... does it consider the transition flags? [15:01:03] It should yes [15:01:15] But they only matter for cross-wiki notifs [15:02:02] NotifUser.php:524 [15:02:20] I have foreign 'edit-user-talk' that are now in 'alert' [15:02:55] Ugh, dammit [15:03:01] Looks like I missed that [15:03:05] when I mark a message as read, the count goes up by 2 as if those edit-user-talk were counted in message [15:03:08] I wonder if a previous patchset does do it right [15:03:44] Maybe I originally wrote this patch against code that didn't have that optimization yet [15:04:17] OK, I have an idea for how to fix this [15:15:14] (03PS11) 10Catrope: Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) [15:16:33] Ignore that patchset, submitted too early [15:17:48] (03PS1) 10Matěj Suchánek: Add missing parameter to a message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295232 [15:18:38] (03CR) 10jenkins-bot: [V: 04-1] Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [15:21:09] (03PS12) 10Catrope: Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) [15:22:08] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable Flow on fr Wikiquote as Beta Feature. - https://phabricator.wikimedia.org/T138064#2393866 (10Catrope) Deployed and working: https://fr.wikiquote.org/wiki/Discussion_utilisateur:Roan_Kattouw_(WMF) [15:25:09] RoanKattouw, your French is quite good :) https://fr.wikiquote.org/w/index.php?title=Wikiquote%3APrise_de_d%C3%A9cision%2FAjout_de_Flow_dans_les_fonctionnalit%C3%A9s_b%C3%AAta&type=revision&diff=240852&oldid=240804 [15:25:35] Trizek: I had to look up "already", I thought it was "toujours" but that didn't seem right [15:26:13] I do remember "toujours" being used for something other than "always", in the same position in the sentence where I used "déjà", but I don't remember what [15:26:31] (i.e. what would "J'ai toujours fait X" mean, if anything?) [15:27:09] (03CR) 10Catrope: [C: 032] Add missing parameter to a message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295232 (owner: 10Matěj Suchánek) [15:35:59] 06Collaboration-Team-Interested, 10Notifications: [minor] Order of wikis in collapsed cross-wiki notifications is different when the list is exapnded - https://phabricator.wikimedia.org/T138115#2390779 (10Catrope) Looks like a bug in the frontend (the expanded version). The expanded version is not sorted by ti... [15:41:11] (03Merged) 10jenkins-bot: Add missing parameter to a message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295232 (owner: 10Matěj Suchánek) [15:41:44] RoanKattouw: I'm not 100% convinced but I'm inclined to merge this, set the transition flags in beta, and continue the testing there. I'm pretty sure it's harmless when the flags are off. [15:42:14] Sounds good to me [15:42:43] Yeah I missed a few embarassing things, I'm now less confident, but if it's still broken Elena should be able to find out [15:42:48] (03CR) 10Sbisson: [C: 032] Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [15:42:53] And with flags off I'm pretty confident it'll keep the old behavior [15:43:34] RoanKattouw: can you set the flags in beta? [15:43:38] Yup will do [15:43:40] Thanks for reminding me [15:44:03] no prob, I wont be at standup, ping me on hangout if there's anything [15:47:34] No worries, and thanks for pointing out all my mistakes today :) [15:48:01] RoanKattouw: "Déjà" is basically "already". Using "toujours" in that case is possible but a little bit twisted. [15:48:13] OK, I must have seen it in some other context then [15:48:22] Sure. [15:49:09] Or I just brainfarted [15:49:51] I forgot to mention the only mistake: "converté" does not exists, it is "converti". But that's a not obvious at all exception on French conjugaisons. :) [15:50:29] hah, of course, because it's convertir not converter [15:50:53] Oh well, I had to make it clear that I'm not a fluent French speaker :) [15:51:21] (03Merged) 10jenkins-bot: Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [15:52:25] :) You made an effort and I'm sure people from that wiki will really appreciate it! [15:56:02] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [production] ptwikibooks displays old error message when Notifications cannot be fetched. - https://phabricator.wikimedia.org/T138114#2390762 (10Catrope) #1: Hmm, shouldn't this show "Please log in to view your notifications."? #2: That's due to an outdated trans... [15:58:03] (03CR) 10Catrope: "recheck" [extensions/Echo] (REL1_27) - 10https://gerrit.wikimedia.org/r/295113 (https://phabricator.wikimedia.org/T135266) (owner: 10Catrope) [15:58:07] (03CR) 10Catrope: "recheck" [extensions/Echo] (REL1_27) - 10https://gerrit.wikimedia.org/r/295112 (https://phabricator.wikimedia.org/T134533) (owner: 10Catrope) [16:01:55] (03PS1) 10WMDE-Fisch: Clarify mention error log comment [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295237 [16:06:11] 06Collaboration-Team-Interested, 10Notifications: Revert notifications are not useful with autocomments - https://phabricator.wikimedia.org/T138224#2394002 (10Catrope) [16:07:23] (03CR) 10Catrope: [C: 032] Clarify mention error log comment [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295237 (owner: 10WMDE-Fisch) [16:14:57] (03Merged) 10jenkins-bot: Clarify mention error log comment [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295237 (owner: 10WMDE-Fisch) [16:15:04] Just to confirm, is https://phabricator.wikimedia.org/T123018 going to be deployed with option #3? [16:15:04] Mon June 27: Tech News is published [16:15:04] Tue June 28: Merge change, deployed in beta labs [16:15:04] Fri July 1: Roan goes on vacation [16:15:04] Tue-Thu July 5-7: Change is deployed in production while Roan is out [16:16:54] I had very bad internet during Friday's standup but I think we decided on #3 right? [16:18:36] Me too. [16:18:49] But I remembered vaguely #3. [16:20:54] Yeah, pretty sure it's #3 [16:22:09] (03CR) 10Catrope: [C: 032 V: 032] Use global user ID in global cache keys [extensions/Echo] (REL1_27) - 10https://gerrit.wikimedia.org/r/295112 (https://phabricator.wikimedia.org/T134533) (owner: 10Catrope) [16:22:22] (03CR) 10Catrope: [C: 032 V: 032] Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications [extensions/Echo] (REL1_27) - 10https://gerrit.wikimedia.org/r/295113 (https://phabricator.wikimedia.org/T135266) (owner: 10Catrope) [16:28:42] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, 07User-notice: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2394112 (10Trizek-WMF) Deployment schedule as decided by the team: # Mon June 27: T... [17:04:36] got kicked out of hangouts & can’t get in [17:04:45] let me try again [17:11:02] 06Collaboration-Team-Interested, 10Flow, 10Notifications: Find a way to avoid Notifications spam when a new topic is created on a Flow page you watch - https://phabricator.wikimedia.org/T138204#2393098 (10Catrope) Solving this problem properly is hard, but one easy-ish thing we can do is making new topic not... [17:15:50] btw, RoanKattouw, I played around a bit this weekend with making notifications fadeIn/fadeOut when they're inserted/removed [17:16:06] I had an idea. It's a little convoluted, but I think it should work [17:16:17] * Trizek goes to his kitchen, brb [17:16:58] My apartment is so small, "going to the kitchen" means leaning over my computer desk. [17:17:23] I experienced that in my former apartment. [17:17:56] And now I'm going to move to a house. I will have to go downstairs to check on my food. [17:18:05] Which means I'll have stairs. [17:18:20] Which means I'm an adult. [17:18:56] Anyway, my dinner is fine: are we doing the predeployment meeting now? [17:31:58] Getting lunch. See you later at the predeployment. [17:33:08] I'll not be around, I think. [17:36:15] 06Collaboration-Team-Interested, 10Flow, 10Notifications: Find a way to avoid Notifications spam when a new topic is created on a Flow page you watch - https://phabricator.wikimedia.org/T138204#2394313 (10Trizek-WMF) Anything that can help users is fine. :) [17:39:26] 10Flow, 10Notifications, 10MediaWiki-Watchlist: Open flow link from notification popup doesn't affect watchlist - https://phabricator.wikimedia.org/T138236#2394319 (10IKhitron) [17:41:24] Trizek: Ugh sorry I forgot [17:41:43] I'll make a list now [17:43:11] https://gist.github.com/anonymous/fc5a6fa35691e0a2b557f8e86306247f [17:43:22] ( Trizek matt_flaschen ) [17:43:30] Highlights: [17:44:28] #3: previously, clicking the primary link in a web notification marked it as read but doing the same thing in an email did not. This fixes emails to also mark as read when following the link [17:44:40] #4: self-explanatory and was in tech news already IIRC [17:44:59] #5: it would be nice to not have user-rights notifications listed under "Main Page" once we have a sidebar on Special:Notifications [17:45:42] #7: we had nested cross-wiki notifications in production for a bit. Lego noticed it, and I fixed it last week. This fix was deployed last week already [17:46:39] #18: when trying to change topic-resolved/reopened notifications to notify topic watches instead of board watchers, I screwed up and it notified no one. This fixes that so it actually notifies topic watchers now [17:48:11] That's the most important stuff [17:48:29] The other Flow changes improve undeletion resilience and bugs Matthias found with his ptwikibooks work [17:48:42] The Echo changes are mostly prep for the re-sort / bundling stuff [17:49:34] I plan to review Phillip today and I'll probably decide to merge it, but I'll wait till tomorrow after the cut so it spends more than 18 hours in beta labs [17:49:38] Especially with Elena being on vacation today [17:49:52] , ping me if you have any questions [18:31:04] RoanKattouw, regarding this: https://phab.wmfusercontent.org/file/data/ljvkljqcff7dnal2df7n/PHID-FILE-zopqrlnbtatydq5lpuyi/dot-status.png [18:31:15] RoanKattouw, OOUI doesn't quite support this behavior yet [18:31:48] we could try the icon changing color to blue (constructive? whatever it is nowadays) but the mid-state options are not supported [18:32:08] should I give up on making this an OOUI icon or should we go with just the blue/grey one? I can play with opacity on hover [18:33:52] RoanKattouw, mlitn and I seem to be clashing on BoardMover. Will put up a quick fix. [18:38:07] RoanKattouw, actually, I was wrong. It's right. [18:38:17] (https://gerrit.wikimedia.org/r/#/c/295215/1). [18:52:03] mooeypoo: Why do you need an image? Can't you just fill the dot with CSS entirely? [18:52:27] ... I... guess so...? It's also mucking-up ooui stuff, since that is an OO.ui.ButtonWidget() [18:52:37] But I guess I can do that [18:53:10] I can do border-radius 50% trick [18:53:28] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Work up a stat to characterize accuracy of ORES's good- and bad-faith predictions - https://phabricator.wikimedia.org/T137850#2394784 (10Mattflaschen-WMF) [18:58:05] Hmm right [18:58:31] matt_flaschen: Yeah AIUI he was fixing what you broke [19:00:49] 06Collaboration-Team-Interested, 10Flow, 10Notifications: Find a way to avoid Notifications spam when a new topic is created on a Flow page you watch - https://phabricator.wikimedia.org/T138204#2394837 (10Catrope) >>! In T138204#2394243, @Catrope wrote: > Solving this problem properly is hard, but one easy-i... [19:02:57] RoanKattouw, it looks like it was always broken in this regard, but my patch may have exposed it differently. [19:04:48] (03CR) 10Catrope: [C: 032] Move only ES entries about the current wiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294947 (owner: 10Mattflaschen) [19:11:15] (03Merged) 10jenkins-bot: Move only ES entries about the current wiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294947 (owner: 10Mattflaschen) [19:17:04] Heading to the airport. [19:21:46] have fun, matt_flaschen !! [19:28:36] (03CR) 10Catrope: [C: 04-1] Add a cross-wiki sidebar to the Special:Notifications page (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [19:28:47] mooeypoo: Minor nitpicks, looks good otherwise [19:28:52] Haven't run the code locally yet [19:29:06] will do that next but I may have to go outside to placate / control children [19:29:15] matt_flaschen: Safe travels [19:59:50] RoanKattouw, we have circles. [20:00:00] * mooeypoo is going to lunch and will push a fix soon [20:00:58] Nice [20:00:59] Enjoy [20:01:13] (03PS1) 10Mooeypoo: [wip] Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) [20:01:30] ok, I lied, here it is ^^ [20:01:31] now lunch [21:39:23] (03PS2) 10Mooeypoo: [wip] Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) [21:43:30] (03CR) 10jenkins-bot: [V: 04-1] [wip] Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo) [23:40:43] (03PS3) 10Mooeypoo: Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) [23:41:39] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2395477 (10Mooeypoo) a:03Mooeypoo [23:45:02] (03CR) 10jenkins-bot: [V: 04-1] Change mark as read buttons to circles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295262 (https://phabricator.wikimedia.org/T126214) (owner: 10Mooeypoo)