[00:06:31] "leaves the database" as in the database remains, not as in exits the database. [00:16:29] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 10DBA: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#1829837 (10Etonkovidova) Looks fine in vagrant both for dry-run and real run. ``` vagrant@mediawiki-vagrant:~$ foreachwiki exte... [00:17:34] shouldn't that be "leaves out" the database? [00:18:41] matt_flaschen, when I first came to the US, I consistently said "throwing" instead of "throwing away", which made many people either extremely confused or very amused whenever I took the garbage out. "I am throwing the garbage" apparently has a different meaning than me actually throwing it away. [00:20:36] mooeypoo, no, as in "Matt leaves his keys in the apartment all the time" (not really since it doesn't lock behind you, so I need them when leaving ;)). [00:21:13] mooeypoo, i.e. after turning off CirrusSearch, Vagrant leaves the database in place/allows it remain/really just doesn't touch it. [00:22:16] mooeypoo, heh. I think I have heard the 'throwing' thing before from someone else, i can't remember from who though. [00:22:28] Ahhh [00:22:37] ... if only words had clear concise meanings! [00:23:08] Yeah, English is the worst. Okay, maybe like the fourth worst. [00:23:16] At least we only have one alphabet... [00:23:25] I can't say it's the worst. You guys at least have vowels. [00:23:28] ... and yes. [00:24:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): External Store dry run wrongly detects failed insert if $wgCompressRevisions is true - https://phabricator.wikimedia.org/T136887#2351032 (10Etonkovidova) No error was displayed in dry-run mode - see {T119567} [00:26:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 10DBA: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2387761 (10Mattflaschen-WMF) It's not doing anything in Vagrant because there is only one External Store configured, and the nam... [00:42:42] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2387774 (10Etonkovidova) Two last builds (#9235 and #9236) are successful. [00:53:17] Heading out. Have a good night. [00:55:42] You too! [06:45:15] 06Collaboration-Team-Interested, 10Flow, 10DBA, 06Operations, 07WorkType-Maintenance: Setup separate logical External Store for Flow in production - https://phabricator.wikimedia.org/T107610#2387980 (10jcrespo) Do do know when was flow enabled for the first time/what is the oldest content we will find? [07:27:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2388006 (10Pginer-WMF) I agree with @SBisson. For new topics, I think the most useful thing is to have a list of the topics (as a table of... [07:34:35] 06Collaboration-Team-Interested, 10Flow, 10DBA, 06Operations, 07WorkType-Maintenance: Setup separate logical External Store for Flow in production - https://phabricator.wikimedia.org/T107610#2388011 (10matthiasmullie) The very first Flow commit was Wed Jul 10 23:05:11 2013 +0100. It was enabled on labs o... [07:59:14] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2388027 (10hashar) 05Open>03Resolved >>! In T137615#2383275, @Catrope wrote: > That's very strange. update.php... [08:29:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests: Enable Flow on fr Wikiquote as Beta Feature. - https://phabricator.wikimedia.org/T138064#2388092 (10Archi38) [12:39:41] Trizek: If you approve of https://phabricator.wikimedia.org/T138064 , we can schedule it for Monday [12:40:18] Go for it. [12:40:38] You may have French WIkiversity to enable next week. [12:41:24] And the funniest part on these requests for French wikis is that I've done absolutely nothing to influence them. :) [12:41:35] So, Monday when, RoanKattouw ? [12:42:21] Haha [12:42:47] It would be at 5pm CEST [12:43:13] I'll probably do it myself, I should be around at that time [12:48:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable Flow on fr Wikiquote as Beta Feature. - https://phabricator.wikimedia.org/T138064#2388538 (10Trizek-WMF) a:05Archi38>03Catrope Scheduled for Monday June 20th at 5pm CEST. [12:50:03] Ok, cool :) [12:50:20] I've left a message to the community. [13:02:17] RoanKattouw: are you there? [13:03:13] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Send notification for easy-to-find failed mentions - https://phabricator.wikimedia.org/T136326#2388564 (10Lea_WMDE) [13:04:59] stephanebisson: Yup [13:05:08] Sorry, I forgot to remove /away [13:06:26] RoanKattouw: about backfillUnreadWikis, instead of running foreach wiki * user, can we assume that the counts that are wrong are the one actually present in echo_unread_wikis and only recompute those? [13:07:10] Hmm, probably, but how much less computation would that really be? [13:07:17] no idea [13:07:22] how many rows in euw? [13:07:32] The counts in euw are the # of unread alerts and the # of unread messages on that wiki, and that's what the cache refresh computes too [13:07:43] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Also send notifications to self - https://phabricator.wikimedia.org/T138080#2388575 (10Lea_WMDE) [13:08:37] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Investigate signature problems and mention failure notifications - https://phabricator.wikimedia.org/T137896#2388591 (10Lea_WMDE) [13:09:03] I guess the global count gets recomputed a bunch of times though [13:10:48] the global count is in cache, we could invalidate it and let it be repopulated on access. is it what we do already? [13:12:40] but I was thinking for each wiki, if we loop on the users present in euw and not bother with the users who have no unread notifications to start with but I don't know if we would really save time [13:13:52] Oooh! [13:13:53] That's a great idea [13:14:19] I guess that doesn't work for the original purpose of the script (populate the previously-empty table), but it works for what we need now [13:15:21] Also with the transition mode stuff I'm not sure we'd actually /need/ to invalidate caches anyway [13:16:33] could you do a user count per wiki from euw? or would that take an hour [13:16:44] No that's probably fine [13:16:55] I'll get a top 20 [13:16:56] just to get a sense if we'd actually save time [13:17:07] Oh believe me I'm pretty sure we will [13:17:16] But I'll get the numbers [13:19:17] Wow enwiki is #5 with 633k rows [13:19:26] Off the top of my head there are 20M users on enwiki [13:20:06] 28M [13:20:14] Even on metawiki there are 2M rows but 12M users [13:20:31] concluding that a user has 0 notifications is probably fast, but when you do it 19.5M times, it adds up! [13:20:42] Exactly1 [13:21:32] It falls off fast too [13:21:48] Only two wikis (meta and commons) are over a million, and #20 (plwiki) is 111k [13:23:51] could you check for { message: 0, alert: 0 } records in euw? [13:24:56] I know at some point they were allowed [13:25:20] !cd [13:25:23] oups [13:31:16] (03PS6) 10Sbisson: [WIP] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [13:32:40] AARGH [13:32:45] There is no index on euw_wiki [13:32:53] (because you don't need one for normal usage) [13:33:58] OK, checking [13:34:41] I guess I could still page through the euw table by ID and filter by wiki each time [13:34:53] 10Notifications, 06TCB-Team, 07Epic, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Add mention failure notifications - https://phabricator.wikimedia.org/T135717#2388631 (10matej_suchanek) [13:34:55] 06Collaboration-Team-Interested, 10Notifications, 07Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2388630 (10matej_suchanek) [13:35:29] But maybe I could do this on a per-user basis. In transition mode that would be easy enough [13:35:37] stephanebisson: 22k rows with (0,0) [13:36:54] RoanKattouw: we can probably delete those [13:36:58] Yup [13:43:25] (03PS1) 10Catrope: Revert "Implement backfillUnreadWikis.php in terms of resetNotificationCount()" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294915 [13:43:34] (03PS2) 10Catrope: Revert "Implement backfillUnreadWikis.php in terms of resetNotificationCount()" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294915 [14:04:58] How many notifications max are displayed on Special:Notifications? I've tried to count, but I didn't received enough of them :) [14:09:20] mooeypoo: Will Phillip be on the right side for LTR languages? [14:13:54] 50 max [14:13:58] Trizek: 50 per page [14:14:06] And Phillip will presumably be on the left for LTR and on the right for RTL [14:14:08] And total? [14:14:29] As many as you have [14:14:36] up to 2000 total (because we purge them after that) [14:14:56] Thanks stephanebisson [14:15:20] And thanks RoanKattouw [14:15:27] (03CR) 10Sbisson: [C: 032] Revert "Implement backfillUnreadWikis.php in terms of resetNotificationCount()" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294915 (owner: 10Catrope) [14:23:28] RoanKattouw: (if you're still around) Any idea how to get an edit excerpt from a revision id? [14:24:27] I can get the revision's text, but that's inlikely to contain the edit in the first few characters. [14:24:35] *unlikely [14:25:08] (03Merged) 10jenkins-bot: Revert "Implement backfillUnreadWikis.php in terms of resetNotificationCount()" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294915 (owner: 10Catrope) [14:27:57] stephanebisson: I don't know of a good way to do that [14:28:31] I do know DiscussionParser goes through the diff of the edit to extract mentions, so maybe something can be done there [14:33:21] I was hoping to avoid DiscussionParser but I'll give it a try [14:48:17] (03PS1) 10Catrope: backfillUnreadWikis.php: Add rebuild mode [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294925 [14:48:56] stephanebisson: There --^^ and thanks again for the idea. I also made it so that we use the cached notif counts when available, and realized we don't need to clear/invalidate any caches [14:49:47] I'm working on special:Notifications Help page. I've written a lot of contents and I'm happy of what I've done. And I've just noticed that 1/4 of these contents are in French. -_- [14:49:56] (03PS1) 10Catrope: NotifUser: rename preloadKeys() to getPreloadKeys() and make it tolerate uncomputable keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294926 [14:49:56] hahaha [14:50:00] Only 1/4? [14:50:00] * Trizek is tired today. [14:50:08] Fortunatly. [14:50:13] *fortunately [14:50:17] Yeah.. I woke up at noon today [14:50:48] And then I discovered scones had been made in the kitchen right below me. Supposedly there were very good, and had all been eaten by 9am [14:50:52] You snooze you lose [14:51:03] :D [14:51:16] Trizek: BTW, have you seen the IT Crowd episode where they go to the pub? [14:51:59] Of course. [14:52:18] RoanKattouw: you removed $wgEchoSharedTrackingCluster completely, isn't is where echo_unread_wiki is? [14:52:37] Yes, I used the DI-tastic MWEchoDbFactory [14:53:17] Trizek: You know how they show a shot of the sign with the name of the pub, "The Black Boy", as a joke about how names of British pubs are often silly and/or inappropriate? [14:53:51] I thought getEchoDb would get you the wiki-specific DB (with echo_event, etc) but echo_unread_wiki is somewhere else.. no? [14:54:04] I didn't noticed that. I think there is a lot of British references that I've missed. [14:54:13] Well tonight, I am going to have dinner in a pub that's literally called The Black Boy [14:54:14] https://www.black-boy-inn.com/dining/ [14:54:25] The IT Crowd fans in our group are excited [14:55:00] I'll have that seefood plater on the front page [14:55:05] sea [14:56:56] RoanKattouw: there's getSharedDb to get a connection to the shared cluster [14:57:32] Oh, right, crap [14:57:44] You're right, I did this wrong [14:57:48] Shared cluster != Echo cluster [14:57:59] (In prod it is, but not generally) [14:59:19] (03PS2) 10Catrope: backfillUnreadWikis.php: Add rebuild mode [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294925 [15:02:09] (03PS3) 10Catrope: backfillUnreadWikis.php: Add rebuild mode [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294925 [15:02:49] Trizek: Also we were watching TV earlier this week and Countdown was on (it's a real TV show apparently) [15:05:40] What is Countdown? A TV show? [15:05:47] About what? [15:06:12] If Countdown is on the IT crowd, I don't remember it. [15:16:41] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Also send notifications to self - https://phabricator.wikimedia.org/T138080#2388758 (10Jakob_WMDE) [15:20:16] (03PS1) 10Sbisson: Try to extract an excerpt from a revision [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294928 (https://phabricator.wikimedia.org/T120152) [15:21:10] Trizek: Do you remember the episode where Moss is really good on this game show on TV and gets admitted to this club/bar? It's one of the greatest episodes ever [15:21:16] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2388761 (10Trizek-WMF) Worked on that today. In order to save... [15:21:54] That an episode from the last season? I've seen them just once. [15:23:56] RoanKattouw: can you take a look at my comments in https://phabricator.wikimedia.org/T137139? Just to be sure that all is fine for echo_event table... [15:24:13] RoanKattouw, about https://phabricator.wikimedia.org/T137139, what will be the result on Special:Notifications? [15:24:29] Combo, etonkovidova! :D [15:24:33] (03CR) 10jenkins-bot: [V: 04-1] Try to extract an excerpt from a revision [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294928 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [15:25:09] Trizek: :) [15:25:14] Trizek: Maybe, I'm not sure which season it's from. It is one of the newer ones yes. It's called Countdown [15:26:01] The Final Countdown, s04e02 [15:26:05] (03PS2) 10Sbisson: Try to extract an excerpt from a revision [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294928 (https://phabricator.wikimedia.org/T120152) [15:26:14] Next on my watching list. [15:27:08] * Trizek afk [15:28:44] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Add ability to filter notifications by title - https://phabricator.wikimedia.org/T137139#2388775 (10Catrope) `event_page_namespace` and `event_page_title` are deprecated... [15:28:46] Aha! [15:28:52] Well I won't say any more then [15:29:03] Other than that you should definitely totally watch that episode [15:29:43] RoanKattouw: FWIW, backfillUnreadWikis consistently take 1.5s (119 users) vs 0.5s (rebuild 7 users) [15:30:08] etonkovidova: I've responded on the task. What I said there should be true for production (stat1003), not sure if it's true for beta too because I don't know if the same migrations were run there [15:30:43] stephanebisson: Hmm, that sounds a bit scary (in terms of sec/user) but I don't know if it's significant at that scale [15:31:06] Trizek: Re Special:Notifications: that task has no user-facing impact, but it will power the filter-by-page part of the sidebar [15:31:16] RoanKattouw: thx! I saw your comment. Was just double-checking with you... [15:31:29] the exact measures are dependent on too many things on my setup but the difference is interesting [15:31:52] but may not represent what we'll experience [15:32:27] we could do a test on betalab or something with and without --rebuild [15:32:48] (03CR) 10Sbisson: [C: 032] backfillUnreadWikis.php: Add rebuild mode [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294925 (owner: 10Catrope) [15:33:27] Yeah, good idea [15:33:49] From etonkovidova's figures that she just pasted into phab, it sounds like enwiki on beta has a decent number of notifications [15:34:00] Not millions like production but probably about 200k [15:34:09] 06Collaboration-Team-Interested, 10Flow, 10DBA, 06Operations, 07WorkType-Maintenance: Setup separate logical External Store for Flow in production - https://phabricator.wikimedia.org/T107610#2388783 (10Mattflaschen-WMF) By timestamp: Converted from UUID with: ``` Flow\Model\UUID::create( strtolower( ' ^ mlitn, I don't see any 2007, don't know why. [15:34:30] Back in an hour. [15:39:42] thanks RoanKattouw. [15:39:53] (03Merged) 10jenkins-bot: backfillUnreadWikis.php: Add rebuild mode [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294925 (owner: 10Catrope) [15:40:19] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Add ability to filter notifications by title - https://phabricator.wikimedia.org/T137139#2388787 (10Trizek-WMF) Removing user-notice tag after Catrope said "Special:Notifications: that ta... [15:41:26] (03Abandoned) 10Zfilipin: Log in via the API instead of via the web site [extensions/Flow] - 10https://gerrit.wikimedia.org/r/270968 (https://phabricator.wikimedia.org/T127042) (owner: 10Zfilipin) [15:45:01] matt_flaschen: I should’ve been more clear [15:45:07] 2007 was first LQT commit [15:45:19] there likely wasn’t any content for awhile :) [15:56:19] 06Collaboration-Team-Interested, 10Flow, 10DBA, 06Operations, 07WorkType-Maintenance: Setup separate logical External Store for Flow in production - https://phabricator.wikimedia.org/T107610#2388820 (10jcrespo) The question was because, unlike beta, the setup is a bit more complex: we have read-write and... [15:56:23] (03PS7) 10Sbisson: Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [16:00:00] (03PS8) 10Sbisson: Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [16:02:31] (03PS7) 10Catrope: Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) [16:02:52] (03CR) 10jenkins-bot: [V: 04-1] Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [16:03:33] beta enwiki with --rebuild: 9039 users in 2m51s [16:06:30] (03PS8) 10Catrope: Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) [16:07:39] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Add ability to filter notifications by title - https://phabricator.wikimedia.org/T137139#2358580 (10SBisson) >>! In T137139#2388775, @Catrope wrote: > For a few notification types, `event... [16:09:10] (03PS3) 10Catrope: Remove automatic mark-as-read-when-seen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293761 (https://phabricator.wikimedia.org/T132525) [16:09:32] (03PS4) 10Catrope: Remove automatic mark-as-read-when-seen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293761 (https://phabricator.wikimedia.org/T132525) [16:12:22] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements, 06Editing-Analysis: Find top 50 Twinkle Users - https://phabricator.wikimedia.org/T138025#2388849 (10Capt_Swing) It may also be helpful to identify the edit count of the person who is receiving a Twinkle message on their user talkpage, and concentrat... [16:16:23] RoanKattouw: are you also trying without --rebuild? [16:16:45] Yes [16:16:47] Oh it finished [16:16:53] 11508 users in 4m1s [16:17:16] so most users had notifications in this case [16:17:23] The ratio of 9k vs 11k is highly atypical though [16:17:23] Yeah [16:17:32] In the real world it's 600k vs 20M as we just discussed [16:17:43] A bit less skewed on some wikis, but still [16:17:50] but the improved performance is really good [16:17:58] Yes [16:18:54] but was the second run somewhat primed? [16:19:11] If it was, the first one was too [16:19:13] Because I ran it twice [16:19:23] The first time the connection died on me, so I tried again using screen [16:19:24] ok [16:20:54] Do you want to review phil? I'm OK merging it now but I want to make sure you have the opportunity to look at it if you want to. [16:22:56] Sure, I'll take a look [16:41:29] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2388956 (10jmatazzoni) @Pginer-WMF, I see you reclassified this from Notifications to Notificati... [16:41:41] (03CR) 10Sbisson: [C: 032] NotifUser: rename preloadKeys() to getPreloadKeys() and make it tolerate uncomputable keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294926 (owner: 10Catrope) [16:43:43] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2388958 (10jayvdb) [16:48:55] (03Merged) 10jenkins-bot: NotifUser: rename preloadKeys() to getPreloadKeys() and make it tolerate uncomputable keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294926 (owner: 10Catrope) [16:49:59] 06Collaboration-Team-Interested, 10Flow, 10DBA, 06Operations, 07WorkType-Maintenance: Setup separate logical External Store for Flow in production - https://phabricator.wikimedia.org/T107610#2388976 (10Mattflaschen-WMF) Yeah. I checked what the first use of External Store was just now: Seems it was use... [16:51:33] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2388977 (10SBisson) Do we want to backfill this or let new notifications be classified correctly and old ones fall off? The script wo... [16:55:39] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Also send notifications to self - https://phabricator.wikimedia.org/T138080#2388575 (10Mattflaschen-WMF) In addition to removing the "2. the user mentions themselves" block, you will need to add: ``` 'notifyAgent' => t... [16:56:59] 06Collaboration-Team-Interested, 10Flow, 10DBA, 06Operations, 07WorkType-Maintenance: Setup separate logical External Store for Flow in production - https://phabricator.wikimedia.org/T107610#2388983 (10jcrespo) That is good news, if I understand it correctly it means there is no revisions in cluster23 or... [17:03:18] RoanKattouw: are you joining standup? [17:07:36] 10Notifications, 07Regression: "There are no notifications." link confusingly leads no where - https://phabricator.wikimedia.org/T138096#2389018 (10Krinkle) [17:07:51] 10Notifications, 07Regression: "There are no notifications." link confusingly leads no where - https://phabricator.wikimedia.org/T138096#2389031 (10Krinkle) [17:09:09] 10Notifications, 07Regression: "There are no notifications." link confusingly leads no where - https://phabricator.wikimedia.org/T138096#2389032 (10Catrope) [17:09:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: "Failed to fetch notifications." is displayed as a link - https://phabricator.wikimedia.org/T137490#2389034 (10Catrope) [17:23:05] 06Collaboration-Team-Interested, 10Flow, 10DBA, 06Operations, 07WorkType-Maintenance: Setup separate logical External Store for Flow in production - https://phabricator.wikimedia.org/T107610#2389080 (10matthiasmullie) Indeed: ``` mysql:wikiadmin@10.64.16.18 [flowdb]> SELECT DISTINCT SUBSTR(rev_content,... [17:58:59] (03CR) 10Sbisson: "With this patch, we keep recomputing the same data over and over again." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [18:18:02] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07I18n, 13Patch-For-Review, and 2 others: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2390416 (10Mooeypoo) I could use a language expert's opinion here @Amire80 : The problem... [18:30:41] 06Collaboration-Team-Interested, 10Flow: Flow: Ability to aggregate topics on more than one board based on some criteria - https://phabricator.wikimedia.org/T94798#1172879 (10jeblad) If a user is mentioned it could be nice to get an entry on the users local board. Now I get an alert in the notification center,... [18:53:32] 06Collaboration-Team-Interested, 10Flow, 07Regression: [Regression 1.27.0-wmf1] Posting Flow topics / replies incredibly slow on testwiki - https://phabricator.wikimedia.org/T114174#2390468 (10jeblad) Sometimes, it seems like loading both loading the topics and edit interface on nowiki is awfully slow. I hav... [18:58:41] (03CR) 10Catrope: Gracefully handle outdated echo_unread_wikis rows (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [18:59:36] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07I18n, 13Patch-For-Review, and 2 others: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2390470 (10Catrope) @Jdforrester-WMF suggests using CSS `text-transform` to uppercase the... [19:00:41] (03CR) 10Catrope: "We do compute things repeatedly, but only when repopulating the cache, so I don't think that's too bad." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [19:08:06] (03CR) 10Catrope: [C: 04-1] Add a cross-wiki sidebar to the Special:Notifications page (0324 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [19:08:19] ... 24 comments?! [19:08:29] wow [19:09:13] etonkovidova, I still don't know why you're having a problem with Vagrant, but your question made me find a bug in the external store migration script. Thanks! [19:09:22] Luckily didn't affect Beta or Vagrant, but would have affected production. [19:09:53] matt_flaschen: happy to hear it :))) [19:10:49] matt_flaschen: on vagrant I got: mwscript extensions/Flow/maintenance/FlowExternalStoreMoveCluster.php --dry-run --wiki=wiki --from=cluster1 --to=flow_cluster1 [19:10:52] matt_flaschen: ERROR: wiki parameter given twice [19:11:18] etonkovidova, I think it has to be before dry-run. [19:11:31] matt_flaschen: ah - ok [19:11:44] etonkovidova, but it won't work anyway, unless you set up a separate external store. [19:11:57] etonkovidova, I'll show you how to do that if you want. [19:12:21] matt_flaschen: yes, I want it :) [19:13:45] Okay, one sec. [19:14:40] mooeypoo: All nitpiccks [19:14:52] Stephane asked me to take a look, so I did [19:14:57] Be careful what you wish for etc :P [19:16:40] I had a pretty good idea what would happen... someone has to check for that stuff [19:17:03] RoanKattouw, going over them now [19:17:40] if they're nit picks, do I pic(k|th)fork [19:18:06] pitch... nevermind. [19:18:27] picthfork still looks pretty reasonable compared to the place names around here [19:18:41] haha [19:18:48] I did find a few more serious things IIRC [19:18:53] 06Collaboration-Team-Interested, 10Flow, 07Regression: [Regression 1.27.0-wmf1] Posting Flow topics / replies incredibly slow on testwiki - https://phabricator.wikimedia.org/T114174#2390537 (10Etonkovidova) @jeblad Can you please give specific pages that load slow? Yesterday it was noticeably slower than usu... [19:18:58] Or things that looked like they could be actual mistakes in the code [19:20:07] Yeah, I'm going over everything [19:27:59] etonkovidova, okay, first copy https://phab.wmfusercontent.org/file/data/dhqiyfo3zpaxk4beqt6b/PHID-FILE-kky3bsds3ri4zme3tmmw/10-ExternalStore-Extra.php to your vagrant/settings.d directory. [19:28:49] matt_flaschen: ok - just a min... [19:30:45] etonkovidova, then checkout https://gerrit.wikimedia.org/r/294946 , then do vagrant provision. [19:30:58] Then you'll use: [19:32:01] mwscript extensions/Flow/maintenance/FlowExternalStoreMoveCluster.php --wiki=wiki --dry-run --from=external --to=external2 [19:34:08] matt_flaschen: thx! Switched to branch "review/mattflaschen/externalStoreTmp" -- running vagrant provision now... [19:36:00] (03PS1) 10Mattflaschen: Move only ES entries about the current wiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294947 [19:46:59] (03PS3) 10Catrope: Re-categorize notifications: [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293762 (https://phabricator.wikimedia.org/T123018) [20:15:38] (03CR) 10Catrope: "Our usual MO for this is to compute this once at notification time, and store section-title and section-text in the extra data." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294928 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [20:32:12] RoanKattouw, is ostriches still interim greg? [20:33:55] matt_flaschen: Not sure when Greg is back, but ostriches is certainly deputy Greg [20:59:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 10DBA: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2390709 (10Etonkovidova) Thx! I've set up External Store on vagrant. [21:01:45] matt_flaschen: hmm... running in vagrant mwscript extensions/Flow/maintenance/FlowExternalStoreMoveCluster.php --wiki='wiki' --dry-run --from=external --to=external2 [21:01:54] matt_flaschen: gives DB connection error: Unknown database 'external2' (127.0.0.1) [21:04:33] etonkovidova, did you get any provisioning errors? [21:04:52] matt_flaschen: yeah... [21:05:04] etonkovidova, start with that part. :) [21:05:34] matt_flaschen: sigh... you're smart :))) [21:06:32] matt_flaschen: I believe that I got some errors even for vagrant git-update ---- re-running it [21:07:02] etonkovidova, git-update probably doesn't matter. Do you have the provisioning errors? [21:09:26] (03PS21) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [21:09:31] matt_flaschen: well, now I am still looking at the git-update errors, then I will do provisioning [21:09:43] (03CR) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page (0322 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [21:09:57] RoanKattouw, most of the comments are "Done" but there are 2-3 that are explanations [21:10:13] etonkovidova, alright, I'm running the provisioning myself this time as well, so maybe I can catch it. [21:10:25] matt_flaschen: ok [21:11:49] Thanks mooey|lunch , I'm about to go to bed, I'll look at it later [21:12:24] Probably Monday because tomorrow is the wedding and Sunday is a cross-country train trip with 6 kids [21:12:44] No wait, only 3, but still [21:13:36] (03CR) 10jenkins-bot: [V: 04-1] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [21:16:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [production] ptwikibooks displays old error message when Notifications cannot be fetched. - https://phabricator.wikimedia.org/T138114#2390762 (10Etonkovidova) [21:24:46] matt_flaschen: no errors in vagrant provision [21:25:25] matt_flaschen: and it seems that the script works beautifully now [21:25:55] Old content: April 26 [21:25:55] flow_revision columns would become: [21:25:55] array ( [21:25:57] 'rev_content' => 'DB://external2/9', [21:25:59] 'rev_flags' => 'utf-8,external,topic-title-wikitext', [21:26:01] ) [21:26:03] New external store content matches old external store content [21:27:29] 06Collaboration-Team-Interested, 10Notifications: [minor] Order of wikis in collapsed cross-wiki notifications is different when the list is exapnded - https://phabricator.wikimedia.org/T138115#2390779 (10Etonkovidova) [21:28:57] etonkovidova, yes, that's how it's supposed to work. [21:28:59] (03PS22) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [21:29:14] matt_flaschen: hurray! [23:30:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 13Patch-For-Review: Set up Flow-specific External Store cluster on Beta (secondary to the main one) - https://phabricator.wikimedia.org/T128417#2073927 (10Etonkovidova) - Re-run the above query for most recent entries ``` MariaDB [enwiki... [23:31:48] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Run External Store migration for real on Beta - https://phabricator.wikimedia.org/T119568#1829848 (10Etonkovidova) Checked along with {T128417}.