[00:49:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2378089 (10Mattflaschen-WMF) {T119511} is also now a blocker for this, so they should be set to auto-recur before these two tasks are cl... [06:09:42] 10Notifications, 10MediaWiki-Maintenance-scripts, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2378350 (10jcrespo) [06:10:36] 10Notifications, 10MediaWiki-Maintenance-scripts, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2378365 (10jcrespo) [06:32:33] 06Collaboration-Team-Interested, 10Notifications, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Product-Backlog: There's no Echo (Notifications) system for us to check notices on Wikipedia Mobile Apps (Android & iOS). - https://phabricator.wikimedia.org/T123155#2378428 (10JMinor) p:05High>03Triage [06:32:47] 06Collaboration-Team-Interested, 10Notifications, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Product-Backlog: There's no Echo (Notifications) system for us to check notices on Wikipedia Mobile Apps (Android & iOS). - https://phabricator.wikimedia.org/T123155#1922509 (10JMinor) p:05High>03Triage [07:34:30] 06Collaboration-Team-Interested, 10Notifications: A gap appears between the header and first notification - https://phabricator.wikimedia.org/T137778#2378640 (10Pginer-WMF) [09:07:39] 10Notifications, 10MediaWiki-Maintenance-scripts, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2378350 (10Catrope) This has probabl... [09:15:13] 10Notifications, 10MediaWiki-Maintenance-scripts, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2378824 (10jcrespo) This is not a hu... [09:18:17] 10Notifications, 10MediaWiki-Maintenance-scripts, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2378350 (10Legoktm) >>! In T137771#2... [09:19:03] (03PS1) 10Catrope: processEchoEmailBatch.php: Don't exit with code 1 if Echo is not installed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294268 (https://phabricator.wikimedia.org/T137771) [09:32:13] 10Notifications, 10MediaWiki-Maintenance-scripts, 13Patch-For-Review, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2378865 (10jcre... [09:32:47] 10Notifications, 10MediaWiki-Maintenance-scripts, 13Patch-For-Review, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2378870 (10Catr... [09:33:37] 10Notifications, 10MediaWiki-Maintenance-scripts, 13Patch-For-Review, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2378874 (10Catr... [09:34:12] (03Abandoned) 10Catrope: processEchoEmailBatch.php: Don't exit with code 1 if Echo is not installed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294268 (https://phabricator.wikimedia.org/T137771) (owner: 10Catrope) [09:49:05] 10Notifications, 10MediaWiki-Maintenance-scripts, 13Patch-For-Review, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2378891 (10Catr... [10:15:40] (03PS1) 10Catrope: NotificationBadgeWidget: Fix header getting larger when "Mark all as read" present [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294279 (https://phabricator.wikimedia.org/T137778) [10:16:01] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: A gap appears between the header and first notification - https://phabricator.wikimedia.org/T137778#2379014 (10Catrope) a:03Catrope [10:16:09] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice: Remove automatic mark-as-read (of alerts) when you open the popup - https://phabricator.wikimedia.org/T132525#2379029 (10Trizek-WMF) To be deployed next week (week 24). [10:20:05] 10Flow, 07Design: Flow: "This comment was hidden..." is not very clear - https://phabricator.wikimedia.org/T137661#2379036 (10Trizek-WMF) Have a better way to show where was the hidden comment is a Design issue. [10:22:46] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), and 2 others: Create a general public documentation for Flow (tracking) - https://phabricator.wikimedia.org/T111367#2379042 (10Trizek-WMF) [10:22:48] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Create a page about known issues concerning Flow - https://phabricator.wikimedia.org/T137686#2379040 (10Trizek-WMF) 05Open>03Resolved Page published, due to requests fro... [10:32:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Datasets-Archiving, 10Dumps-Generation, 07Blocked-on-Operations: Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#2379060 (10ArielGlenn) Uh, this is done, insofar as they show up on dumps.wm.org as files to be... [10:33:27] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2379061 (10ArielGlenn) There's nothing needed for autorecurrence; the flow job is part of the regular dump runs. [10:46:53] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Help to define next steps concerning Flow development, based on Flow satisfaction survey - https://phabricator.wikimedia.org/T137796#2379110 (10Trizek-WMF) [10:47:15] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2379123 (10Trizek-WMF) [10:47:17] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Help to define next steps concerning Flow development, based on Flow satisfaction survey - https://phabricator.wikimedia.org/T137796#2379122 (10Trizek-WMF) [11:23:55] 10Notifications: Page linked notification: URL title parameter is not correct - https://phabricator.wikimedia.org/T137798#2379197 (10Trizek-WMF) [11:32:02] (03PS1) 10Catrope: PageLinkedPresentationModel: Use the correct title for the diff link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294287 (https://phabricator.wikimedia.org/T137798) [11:32:24] 10Notifications, 13Patch-For-Review: Page linked notification: URL title parameter is not correct - https://phabricator.wikimedia.org/T137798#2379236 (10Catrope) a:03Catrope [12:08:05] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2379337 (10Trizek-WMF) Collaboration team is currently drafting some key points, in order to b... [12:31:37] (03CR) 10Sbisson: [C: 032] NotificationBadgeWidget: Fix header getting larger when "Mark all as read" present [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294279 (https://phabricator.wikimedia.org/T137778) (owner: 10Catrope) [12:39:58] (03Merged) 10jenkins-bot: NotificationBadgeWidget: Fix header getting larger when "Mark all as read" present [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294279 (https://phabricator.wikimedia.org/T137778) (owner: 10Catrope) [12:49:34] (03PS2) 10Sbisson: Allow the primary link to set all bundled notifications as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294120 (https://phabricator.wikimedia.org/T136368) [12:52:49] (03PS1) 10Sbisson: Don't mark alerts as read when seen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294300 (https://phabricator.wikimedia.org/T132525) [13:04:19] (03CR) 10Sbisson: [C: 032] PageLinkedPresentationModel: Use the correct title for the diff link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294287 (https://phabricator.wikimedia.org/T137798) (owner: 10Catrope) [13:12:40] (03Merged) 10jenkins-bot: PageLinkedPresentationModel: Use the correct title for the diff link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294287 (https://phabricator.wikimedia.org/T137798) (owner: 10Catrope) [13:27:07] 10Notifications, 13Patch-For-Review: Page linked notification: URL title parameter is not correct - https://phabricator.wikimedia.org/T137798#2379197 (10SBisson) While testing this patch, I noticed that the links don't change for a bundle: * the primary link goes to the first (of many) pages that link to the... [13:27:31] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Page linked notification: URL title parameter is not correct - https://phabricator.wikimedia.org/T137798#2379506 (10SBisson) [13:44:31] Someone added this on Help:Notifications https://www.mediawiki.org/w/index.php?title=Help:Notifications&diff=prev&oldid=2162193 [13:44:53] If I understand correctly, it is a way to trigger a revert Notification. [13:46:29] Is it normal? [13:49:18] I don't fully understand... it references a ticket (filed and done) from 2013 [14:12:19] i like the new special:notifications :o [14:21:33] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2103549 (10SBisson) Notifications not associated with any page make these counts not add up. I understan... [14:39:55] (03PS1) 10Sbisson: Don't set title for user-rights notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294321 [15:11:55] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2379816 (10Pginer-WMF) >>! In T129366#2379651, @SBisson wrote: > Notifications not associated with any p... [15:15:17] (03CR) 10Catrope: [C: 032] Don't set title for user-rights notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294321 (owner: 10Sbisson) [15:15:47] Trizek: That text could be appropriate for Manual:Echo which IIRC is the more technical documentation page [15:17:36] (03CR) 10Sbisson: [C: 031] "I don't know about ApiPageSet but this LGTM." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) (owner: 10Catrope) [15:24:19] Thanks RoanKattouw . [15:24:34] (03Merged) 10jenkins-bot: Don't set title for user-rights notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294321 (owner: 10Sbisson) [15:25:12] (03CR) 10Catrope: [C: 032] Don't mark alerts as read when seen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294300 (https://phabricator.wikimedia.org/T132525) (owner: 10Sbisson) [15:34:14] (03Merged) 10jenkins-bot: Don't mark alerts as read when seen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294300 (https://phabricator.wikimedia.org/T132525) (owner: 10Sbisson) [15:35:01] (03CR) 10Catrope: [C: 032] Allow the primary link to set all bundled notifications as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294120 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [15:42:38] (03Merged) 10jenkins-bot: Allow the primary link to set all bundled notifications as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294120 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [15:47:45] (03PS1) 10Catrope: Allow the primary link to set all bundled notifications as read [extensions/Echo] (wmf/1.28.0-wmf.6) - 10https://gerrit.wikimedia.org/r/294339 (https://phabricator.wikimedia.org/T136368) [15:48:02] matt_flaschen: Could you supervise that --^^ in the evening SWAT? [15:50:10] RoanKattouw, yeah. [15:50:15] Cool, thanks [15:52:07] OK, added [15:52:54] The reason I wanted to SWAT that is that that'll (hopefully) allow us to clean up all the unread bundled notifs this week instead of next week [16:06:13] 10Notifications, 10MediaWiki-Maintenance-scripts, 13Patch-For-Review, 07Wikimedia-log-errors: "Echo isn't enabled on this wiki" from Cron /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null - https://phabricator.wikimedia.org/T137771#2379976 (10Catr... [16:39:48] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): Flow: "Edit resume" button add infinite text boxes - https://phabricator.wikimedia.org/T137459#2380199 (10Etonkovidova) Checked in betalabs - no additional summary editors are open when 'Summarize' is clicked... [16:58:26] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Measure New-User Retention - https://phabricator.wikimedia.org/T137824#2380243 (10jmatazzoni) [16:59:27] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements, 06Editing-Analysis: Measure New-User Retention - https://phabricator.wikimedia.org/T137824#2380258 (10jmatazzoni) [17:08:33] 03Collab-Team-2016-Apr-Jun-Q4, 06Design-Research, 10Edit-Review-Improvements: Scheduling Huggle user interviews - https://phabricator.wikimedia.org/T135792#2380273 (10jmatazzoni) [17:15:43] RoanKattouw or mooeypoo, can you point le out the Phab task related to Phillip's deployment? [17:15:46] *me [17:16:36] Trizek: https://phabricator.wikimedia.org/T129366 [17:17:00] ust found it by my side, but thanks a lot! [17:17:25] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2380334 (10Trizek-WMF) [17:17:29] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2380335 (10Catrope) Note that the counts will potentially not add up anyway, because we... [17:18:35] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Add ability to filter notifications by title - https://phabricator.wikimedia.org/T137139#2380337 (10Trizek-WMF) [17:20:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Post page describing Edit Review Improvements to Mediawiki - https://phabricator.wikimedia.org/T137741#2380342 (10Trizek-WMF) p:05Triage>03High IMO, that is a High priority task: it is important to have a page where people attending Wikimania can h... [17:20:56] 06Collaboration-Team-Interested, 10Notifications, 10Wikimedia-Extension-setup, 13Patch-For-Review: Enable Echo on all Wikimedia wikis - https://phabricator.wikimedia.org/T97760#2380353 (10Legoktm) [17:20:58] 06Collaboration-Team-Interested, 10Notifications, 10Wikimedia-Extension-setup, 13Patch-For-Review: remove echowikis to simplify configuration - https://phabricator.wikimedia.org/T59375#2380349 (10Legoktm) 05Resolved>03declined This was effectively reverted in {T137771}. [17:21:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Post page describing Edit Review Improvements to Mediawiki - https://phabricator.wikimedia.org/T137741#2380369 (10Trizek-WMF) [17:24:18] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2380379 (10Trizek-WMF) [17:46:47] stephanebisson: hmm... my email address added in vagrant gets Unable to execute /usr/lib/sendmail -t -i [17:47:01] stephanebisson: any ideas what to do? [17:47:48] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2380494 (10Trizek-WMF) >>! In T129366#2380335, @Catrope wrote: > Note that the counts w... [17:49:17] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2380495 (10jmatazzoni) It looks like we're closing in on a consensus solution, which is to associate the following... [17:50:22] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): Flow: "Edit resume" button add infinite text boxes - https://phabricator.wikimedia.org/T137459#2380497 (10jmatazzoni) 05Open>03Resolved [18:09:13] etonkovidova: I think I had to configure the emails manually in vagrant, let me see... [18:09:28] stephanebisson: ok... [18:17:12] RoanKattouw, mooeypoo, stephanebisson, mlitn, what should I mention in Scrum of Scrums? So far I've got: Phillip is almost ready to leave the box car, Expandable bundles almost done, working on Flow deletion improvements. [18:26:41] etonkovidova: I had to configure wgSMTP manually (see https://www.mediawiki.org/wiki/Manual:$wgSMTP). I've done that a while back, I don't know if it's still the way to go. [18:33:54] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Filter by read status on the Notification Page - https://phabricator.wikimedia.org/T129364#2380640 (10Etonkovidova) @jmatazzoni I think this task can be closed - all three specs that were listed as not implemented can be addressed in different ticket... [18:37:43] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2380648 (10Pginer-WMF) >>! In T129366#2380494, @Trizek-WMF wrote: >>>! In T129366#23803... [18:43:42] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2380663 (10darthbhyrava) [19:20:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): ?markasread=NNN not added to primary links in emails - https://phabricator.wikimedia.org/T137488#2369590 (10Etonkovidova) Checked in betalabs. 1. "View [page, post, comment, topic}"... [19:33:54] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2380823 (10Quiddity) If we use the editor's own userpage for some, I think we should do that for all of these? As P... [19:41:02] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2380842 (10Catrope) >>! In T129366#2380494, @Trizek-WMF wrote: >>>! In T129366#2380335,... [19:41:27] 06Collaboration-Team-Interested, 10Flow, 06Community-Liaisons (Apr-Jun-2016), 07User-notice: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2380843 (10Esanders) What about just expanding sideways, so a [>] button that reveals the extra toolbar groups? [19:57:09] (03PS3) 10Catrope: Add index on notification_event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294111 [19:58:02] (03PS45) 10Catrope: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [20:29:00] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2380959 (10greg) a:03Catrope >>! In T137615#2377370, @hashar wrote: > So essentially solved, pending for Roan cha... [20:29:11] (03CR) 10Sbisson: [C: 04-1] "Looks good. Minor stuff inline." (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [20:30:52] (03CR) 10Catrope: [C: 032] Add index on notification_event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294111 (owner: 10Catrope) [20:31:13] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): ?markasread=NNN not added to primary links in emails - https://phabricator.wikimedia.org/T137488#2369590 (10SBisson) >>! In T137488#2380799, @Etonkovidova wrote: > e.g. "http://en.wi... [20:32:27] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): ?markasread=NNN not added to primary links in emails - https://phabricator.wikimedia.org/T137488#2380976 (10Etonkovidova) @SBisson - the url is from an email. Something is not right? [20:35:20] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): ?markasread=NNN not added to primary links in emails - https://phabricator.wikimedia.org/T137488#2380985 (10SBisson) The `&` between query parameters are encoded as `&`. Did yo... [20:37:25] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): ?markasread=NNN not added to primary links in emails - https://phabricator.wikimedia.org/T137488#2380996 (10Etonkovidova) @SBisson - it's HTML source, not a email text. [20:37:39] (03Merged) 10jenkins-bot: Add index on notification_event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294111 (owner: 10Catrope) [20:42:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): ?markasread=NNN not added to primary links in emails - https://phabricator.wikimedia.org/T137488#2381023 (10SBisson) Ok, thanks. It looks weird but it seems to be working fine. [20:43:39] (03PS10) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [21:01:39] (03CR) 10Mooeypoo: "Preliminary review before testing" (0313 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [21:01:55] stephanebisson, review comments - we discussed many of those in general, I just added for more perspective [21:02:09] mooeypoo: ok, thanks [21:02:48] mooeypoo: I'm trying the other approach: attaching bundles to modelManager.notificationModels, so far so good [21:02:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Remove automatic mark-as-read (of alerts) when you open the popup - https://phabricator.wikimedia.org/T132525#2201485 (10Etonkovidova) Checked ihn betalabs - Alerts red badge when cl... [21:02:55] stephanebisson, the comments about where the model lives are not blockers -- but the use of notifList wrapping a subgroup list was weird to me, so I hope I didn't misunderstand behavior [21:03:05] * mooeypoo nods [21:03:18] I think it may also simplify some of the widget constructions you have in there, but i'm not sure [21:03:20] Heading out, will be back in a couple hours. [21:03:39] stephanebisson, also, i completely see what you meant with the parent hierarchy thing. We should generalize some of those widgets better later [21:03:52] mooeypoo: "notifList wrapping a subgroup" was weird for me too, I'll be happy to not do it if I can [21:04:00] stephanebisson, yo shouldn't have to [21:04:06] you should just add items into the notifList [21:04:34] you do need to construct them yourself, but they're straight-forward SingleNotificationItemWidget with config.bundle=true [21:04:39] ok, I'll finish what I do and go through your comments and try to unwrap that stuff [21:04:43] * mooeypoo nods [21:04:56] (03PS46) 10Catrope: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [21:09:37] stephanebisson: Hmm, so I'm doing some final poking at your dynamic bundles patch and I realized that this affects notification counts, which are cached [21:09:50] RoanKattouw: indeed [21:09:55] So at least we should bump the cache version. That's easy, I'll amend that into the patch [21:10:01] But for cross-wiki, I think the counts will be off for a while [21:10:20] We'll have to rebuild the echo_unread_wikis table [21:10:43] So... maybe we should combine this with the re-sort and the transition code I wrote [21:10:46] and that's very long, right? [21:10:53] The first time it took 3 weeks [21:11:09] The second time I hope it'll be faster, but who knows [21:11:32] The transition setting for the re-sort papers over most of the issues though [21:11:51] The only problem is that it assumes that if you're requesting ALL, then it has no fixing up to do; with this that's not true [21:13:02] we'll have to be extra sure that the script rebuilding euw is updated to ignore bundle_base [21:14:09] You merged a patch by me this week that changes that script to just be a call to resetNotificationCount(), so that'll be OK [21:14:52] omg my vagrant just crashed [21:15:00] MediaWiki internal error. [21:15:00] Original exception: [8667fdf57a8ca1b9404d230a] /wiki/Special:Notifications DBQueryError from line 934 of /vagrant/mediawiki/includes/db/Database.php: A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: [21:15:06] oh wait [21:15:10] probably update script? [21:15:21] err... I thought vagrant is supposed to do that [21:15:44] stephanebisson, do you remember how I tell vagrant to run the update scripts? or do I have to run vagrant git-update ? [21:16:25] stephanebisson: In any case, this suggests to me that we should deploy the "dynamic bundles" patch and the re-sort at the same time [21:16:27] mooeypoo: vagrant provision will do [21:17:05] what the hell, though :\ I do it in my init script [21:17:14] (03PS47) 10Catrope: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [21:17:15] RoanKattouw: as long as we time it so we're both available I have no objections [21:17:48] My bigger concern is giving notice to users [21:18:33] I'll write an email explaining all this and asking Joe, Benoît and Nick for their input [21:18:46] sounds good [21:20:08] vagrant provision [21:20:20] stephanebisson: any thoughts about setting email sending in my vagrant? :( [21:20:22] ... it may work if I am in the right window. [21:20:30] mooeypoo: in your shell, not here ;) [21:20:47] stephanebisson, that explains so much! [21:33:38] (03CR) 10Catrope: [C: 04-2] "Looks good, but we can't merge this yet. This change affects notification counts (which is why I amended this to bump the cache version), " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [21:36:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2373400 (10Etonkovidova) Two last builds - #9182 and #9183 failed (https://integration.wikimedia.org/ci/job/beta-u... [21:45:58] (03CR) 10jenkins-bot: [V: 04-1] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [22:24:32] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Work up a stat to characterize accuracyof ORES's good- and bad-faith predictions - https://phabricator.wikimedia.org/T137850#2381274 (10jmatazzoni) [22:27:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Work up a stat to characterize accuracyof ORES's good- and bad-faith predictions - https://phabricator.wikimedia.org/T137850#2381295 (10jmatazzoni) Another question about the good-faith stat that we have at present: > ORES can find 95% of good faith e... [22:35:33] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements, 07Design: Explore ideas for Review Feeds - https://phabricator.wikimedia.org/T137814#2381319 (10jmatazzoni) [22:49:29] 10Flow: Flow causes fatal exception on [[Special:EditWatchlist]] - https://phabricator.wikimedia.org/T137853#2381346 (10He7d3r) [22:55:10] 10Flow: Flow causes fatal exception on [[Special:EditWatchlist]] - https://phabricator.wikimedia.org/T137853#2381383 (10He7d3r) Other watchlist pages were working fine. In particular, I was able to access https://pt.wikibooks.org/wiki/Special:EditWatchlist/raw After I removed the 465 `Topic:****************` pag... [23:04:55] (03CR) 10Ori.livneh: [C: 032] Allow the primary link to set all bundled notifications as read [extensions/Echo] (wmf/1.28.0-wmf.6) - 10https://gerrit.wikimedia.org/r/294339 (https://phabricator.wikimedia.org/T136368) (owner: 10Catrope) [23:13:13] (03Merged) 10jenkins-bot: Allow the primary link to set all bundled notifications as read [extensions/Echo] (wmf/1.28.0-wmf.6) - 10https://gerrit.wikimedia.org/r/294339 (https://phabricator.wikimedia.org/T136368) (owner: 10Catrope) [23:44:35] (03PS17) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [23:51:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Page linked notification: URL title parameter is not correct - https://phabricator.wikimedia.org/T137798#2379197 (10Etonkovidova) Checked in betalabs (and testwiki, just in case, to spot more probl... [23:55:56] 06Collaboration-Team-Interested, 10Flow: Flow causes fatal exception on [[Special:EditWatchlist]] - https://phabricator.wikimedia.org/T137853#2381493 (10Quiddity)