[05:00:47] 10Flow: Flow: avoid to quit page and loose editing text - https://phabricator.wikimedia.org/T137659#2375261 (10Quiddity) [05:00:49] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Flow not warning me when I leave an edit page with unsaved changes - https://phabricator.wikimedia.org/T96531#2375263 (10Quiddity) [08:32:49] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2375405 (10hashar) ``` Deleted 497 records from 500 records Deleted 500 records from 500 records Deleted 500 record... [09:09:22] 06Collaboration-Team-Interested, 10Flow: Impossible to load "Browse topics" list and reach a topic on Flow - https://phabricator.wikimedia.org/T135708#2375464 (10Trizek-WMF) 05Open>03Resolved a:03Trizek-WMF Salix has unselected all gadgets ans clear all personal scripts from her account, saved, clear her... [09:13:36] 10Flow: Flow: "This comment was hidden..." is not very clear - https://phabricator.wikimedia.org/T137661#2375484 (10Trizek-WMF) The idea is not to mention the username? It may be useful to see the username: you will not take the same action if a comment has been hidden by a trusted community member or a Single-p... [09:22:29] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Create a page about known issues concerning Flow - https://phabricator.wikimedia.org/T137686#2375491 (10Trizek-WMF) [09:23:40] 06Collaboration-Team-Interested, 10Flow: Flow: compare-post-revisions page haven't link to full post page - https://phabricator.wikimedia.org/T137629#2375506 (10Trizek-WMF) [09:29:25] 10Collab-Notifications-Page, 07I18n: Day names are not in Czech - https://phabricator.wikimedia.org/T137634#2373795 (10Trizek-WMF) That not only for Czech: they are in English for everyone. {F4160303} [09:29:59] 10Collab-Notifications-Page, 07I18n: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2375511 (10Trizek-WMF) p:05Triage>03High [10:07:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Write an update about that is going on concerning ptwikibooks LqT-to-Flow conversion - https://phabricator.wikimedia.org/T136555#2375627 (10Trizek-WMF) p:05High>03Normal Lowering priority:... [10:08:07] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2375629 (10Trizek-WMF) p:05High>03Normal Lowering priority: I will not have time to work o... [10:10:34] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2375650 (10Trizek-WMF) p:05High>03Normal Lowering priority: aster a discussion with @... [10:19:39] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2375673 (10Qgil) [10:23:02] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jul-Sep-2016): Write an update about that is going on concerning ptwikibooks LqT-to-Flow conversion - https://phabricator.wikimedia.org/T136555#2375680 (10Qgil) [11:15:58] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07I18n: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2375812 (10Catrope) p:05High>03Unbreak! [11:19:00] (03CR) 10Catrope: "Agreed ApiCrossWikiBase.php is not that meaty any more. I'll see if I can make it a trait in a separate commit." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293420 (owner: 10Catrope) [11:38:48] (03CR) 10Sbisson: [C: 032] "Fair enough." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293420 (owner: 10Catrope) [11:43:37] (03CR) 10Sbisson: [C: 032] Add ?markasread=NNN to primary links in emails too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293632 (https://phabricator.wikimedia.org/T137488) (owner: 10Catrope) [11:45:11] (03PS1) 10Catrope: Use localized weekdays on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294048 (https://phabricator.wikimedia.org/T137634) [11:45:14] (03Merged) 10jenkins-bot: Factor out cross-wiki API request code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293420 (owner: 10Catrope) [11:52:06] (03Merged) 10jenkins-bot: Add ?markasread=NNN to primary links in emails too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293632 (https://phabricator.wikimedia.org/T137488) (owner: 10Catrope) [12:10:20] (03PS2) 10Catrope: Use localized weekdays on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294048 (https://phabricator.wikimedia.org/T137634) [12:11:07] stephanebisson: Could I get a quick code review on that one? ---^^ (UBN bug) [12:11:26] sure [12:11:39] Thanks [12:12:27] oh, I looked at it already this morning [12:12:44] real 482m33.171s [12:12:45] are you sure the first day of the week is always the same? [12:12:49] Real helpful output :| [12:13:15] Yeah, there's a different function that's for the localized day of week [12:13:25] And it's 1-indexed instead of 0-indexed too, because of course [12:13:35] (localized day of the week being, "1 is either Sunday or Monday depending") [12:14:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Dynamic bundle: non-bundle_base notifications need a read timestamp - https://phabricator.wikimedia.org/T136368#2375939 (10Catrope) I ran this on enwiki on Friday and it took about 8 hours. Going to s... [12:16:11] (03CR) 10Sbisson: [C: 032] Use localized weekdays on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294048 (https://phabricator.wikimedia.org/T137634) (owner: 10Catrope) [12:22:12] (03CR) 10Sbisson: [C: 032] Separate model's symbolic name and model's source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293451 (owner: 10Mooeypoo) [12:24:01] (03Merged) 10jenkins-bot: Use localized weekdays on Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294048 (https://phabricator.wikimedia.org/T137634) (owner: 10Catrope) [12:24:27] (03PS1) 10Catrope: Use localized weekdays on Special:Notifications [extensions/Echo] (wmf/1.28.0-wmf.5) - 10https://gerrit.wikimedia.org/r/294054 (https://phabricator.wikimedia.org/T137634) [12:26:59] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07I18n, 13Patch-For-Review: Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2373795 (10Catrope) Fix scheduled for the SWAT at 15:00 UTC. [12:30:19] (03Merged) 10jenkins-bot: Separate model's symbolic name and model's source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293451 (owner: 10Mooeypoo) [12:50:01] (03PS42) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [12:50:04] (03PS4) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [13:07:14] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): ?markasread=NNN not added to primary links in emails - https://phabricator.wikimedia.org/T137488#2376082 (10Trizek-WMF) [13:39:55] Oh, a user has created a gadget just to customize Flow! https://fr.wikipedia.org/wiki/Sujet:T5nu1r7bldxv5ngu [14:39:44] (03PS4) 10Sbisson: Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) [15:12:26] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.5) - 10https://gerrit.wikimedia.org/r/294054 (https://phabricator.wikimedia.org/T137634) (owner: 10Catrope) [15:24:51] (03Merged) 10jenkins-bot: Use localized weekdays on Special:Notifications [extensions/Echo] (wmf/1.28.0-wmf.5) - 10https://gerrit.wikimedia.org/r/294054 (https://phabricator.wikimedia.org/T137634) (owner: 10Catrope) [15:36:26] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07I18n, 13Patch-For-Review, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): Day names are in English and not translatables on Special:Notifications - https://phabricator.wikimedia.org/T137634#2376451 (10Jdforrester-WMF) I superintended deployment just n... [15:40:45] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2376488 (10Pginer-WMF) According to the examples it seems that the notifications not associated with a specific pag... [15:52:06] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2376524 (10ArielGlenn) I can close it after the current run completes, I push out a fix to get the right list of flow-enabled wikis, and... [16:01:05] 06Collaboration-Team-Interested, 06Community-Tech, 06Editing-Department, 06Language-Engineering, and 3 others: Parsing team: Q3 2015-16 goals planning dependency tracker task - https://phabricator.wikimedia.org/T119088#2376574 (10ssastry) 05Open>03Resolved a:03ssastry [17:01:35] stephanebisson: a quick question - email batch for Daily summary of notificaitons - were there any changes when you worked on Email formatter? [17:02:06] etonkovidova: yes, a few weeks ago we migrated to use the new formatter system [17:02:18] stephanebisson: ok - thx [17:08:01] (03PS6) 10Mooeypoo: ApiEchoNotificatons: Add nottitles parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) (owner: 10Catrope) [17:09:15] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2376711 (10greg) This is still happening as of 17:05 UTC. @Mattflaschen-WMF you added that collab team project, ar... [17:45:25] 10Flow: Flow: "This comment was hidden..." is not very clear - https://phabricator.wikimedia.org/T137661#2376924 (10Framawiki) If you want, but actually the message is short and clear, please keep this :) [17:50:39] RoanKattouw: did you see https://phabricator.wikimedia.org/T137615 ? [17:50:57] Yeah I did :/ [17:51:05] I hadn't thought of that [17:51:17] Antoine says he ran it [17:51:24] That it finished [17:51:30] And it's a logged update, right? [17:51:40] * RoanKattouw comments on the task [17:53:35] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2373400 (10Catrope) How is it possible that this is still happening? @hashar says he ran the script to completion,... [18:10:48] (03PS5) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [18:10:49] am i in the right channel? [18:10:58] jmatazzoni___: right [18:12:13] why am I "banned on #cvn-wp-en"? [18:13:12] jmatazzoni___, I see you in that channel. [18:13:31] RoanKattouw: are you there? [18:13:32] I just tried to change my nick and it said I can [18:13:38] Yup [18:13:41] can't while banned on that channel. ??? [18:13:51] Trying to git pull [18:13:57] RoanKattouw: ok [18:14:12] The internet is pretty slow here. We may go work at the university later in the week [18:14:40] * RoanKattouw is 15 mins away from https://en.wikipedia.org/wiki/Llanfairpwllgwyngyll [18:15:41] Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch! <3 [18:17:15] RoanKattouw: such a remarkable place :) [18:18:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [18:18:48] https://gist.github.com/anonymous/857b89eb65f164ebac4346f060ec013f [18:19:51] The main ones you care about are #6 and #8 [18:19:51] RoanKattouw:it's quite short [18:20:08] Yeah, we did a bunch of work but not much of it got merged this week [18:20:18] I'll go over unmerged stuff next [18:20:35] #6: clicking the primary link in an email does not currently mark the notification as read, now it will [18:20:51] sounds ok [18:20:54] #8 is already deployed and makes it so that the weekdays (Monday, Tuesday, etc) on Special:Notifications are actually localized [18:21:01] Rather than always being in English [18:21:02] yup [18:21:05] (oops) [18:21:40] #11 is edge-case-y, we'd apparently made a mistake earlier that caused Flow notifications to say "100 new topics" when it should be "99+ new topics" [18:21:57] Which is apparently uncommon enough that nobody noticed for quite a while until Stephane spotted it [18:22:06] yeah, I saw #1 in vagrant ... [18:22:24] RoanKattouw, it's not exactly an edge case, it happens for all values over 99, not just 100. Sorry, I made some changes to the right Flow i18n messages, but not *all* the right changes to those i18n messages [18:22:31] Still uncommon, though. [18:22:42] #5 is also worth knowing about: it makes user-rights notifications not show up under "Main Page" once we have the sidebar on the special page. It only applies to new notifs so we may want to clean up old ones too [18:23:03] matt_flaschen: Yeah, I know. I meant that values over 99 are themselves an edge case [18:23:15] Maybe not if you watch [[mw:Project:Support desk]] and then go on vacation or something [18:23:50] In terms of actionable patches that are unmerged: [18:23:56] https://gerrit.wikimedia.org/r/293759 fixes a minor-ish Flow bug [18:24:14] I'll review that today. [18:24:24] Thanks [18:24:38] #7? [18:25:07] etonkovidova: "Separate model's symbolic name..." is refactoring that shouldn't have user-visible effects [18:25:13] In preparation for the side bar I think [18:25:18] ah ok [18:25:22] Speaking of the sidebar, https://gerrit.wikimedia.org/r/#/c/293142/ is ready for re-review too [18:25:42] I will review https://gerrit.wikimedia.org/r/292600 (sidebar) today [18:25:54] mooeypoo: I'm guessing that --^^ only lists other wikis, not pages? Or both? [18:26:16] RoanKattouw, why did you decide not to use ApiPageSet? Since it could be confusing for a 'meta' to have it? [18:26:46] Yeah [18:26:56] I'd also be open to using ApiPageSet normally I suppose [18:27:03] That seems a bit strange for a meta [18:27:09] But that's a discussion I should have with Brad I guess [18:27:19] * RoanKattouw transfers that to a comment on Gerrit [18:27:30] RoanKattouw, also, I think it also accepts revids, which is problematic. [18:27:43] Other modules have that problem too [18:27:54] There are lots of action=query submodules that don't/can't operate on revids [18:28:21] And there are other top-level modules like action=purge that take revids even though that doesn't make sense [18:28:28] In both cases I believe it just resolves the title of each revid and uses that [18:28:44] In that case, we could go either way, so I'll review after you talk to Brad. [18:29:09] (03CR) 10Catrope: "We could still use ApiPageSet here, but that seems strange for a meta= module. @Anomie, thoughts on that?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) (owner: 10Catrope) [18:30:03] https://gerrit.wikimedia.org/r/291676 also needs review but that's for the re-sort so that's lower prio [18:31:25] Looks like that's all that's ready for review [18:31:42] etonkovidova: Any big problems we should be aware of? [18:31:43] RoanKattouw, there is also T137593 ; it's a security bug so patch is in the task. Probably something mlitn or you should review. [18:31:48] "we will disbelieve the alert/message counts " in https://gerrit.wikimedia.org/r/#/c/291676/ -- disbelieve is it a correct word? [18:32:00] Yeah [18:32:05] The word exists but I'm not sure if my usage there is correct [18:32:17] You could also say "won't believe". [18:32:23] ok - interesting [18:32:43] and about problems out there - nope [18:33:08] OK I'll review the patch on that task [18:33:14] especially after VE v2 was desabled [18:33:18] Thanks [18:35:10] thx [18:35:49] Alright, thanks for bearing with me everyone [18:38:38] (03CR) 10Anomie: "Yeah, that would be a bit strange. And you'd probably want to pass ApiPageSet::DISABLE_GENERATORS flag to the constructor, since I'm reall" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) (owner: 10Catrope) [18:40:22] (03PS6) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [18:42:59] RoanKattouw, jmatazzoni___, I thought we decided on umbrella, but my email says otherwise. [18:44:28] Oh, never mind, that's from yesterday, so presumably we're still at umbrella. [18:44:50] yes [18:45:52] jmatazzoni___, okay, it's created. Feel free to tweak the description at https://phabricator.wikimedia.org/project/manage/2040/ . Also, can someone link to the wiki page when that's created? [18:48:31] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2377149 (10greg) This being the aborted job, didn't look at logs [18:55:14] (03PS7) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [19:00:20] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2377189 (10hashar) The Echo removeInvalidTargetPage.php was me blindly attempting to cleanup the beta cluster enwi... [19:02:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2377204 (10Catrope) removeInvalidTargetPage.php is ancient, it was added in 2014. It's also not supposed to be run... [19:08:00] (03PS14) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [19:08:45] mooeypoo: What is the done-ness level of that commit? [19:08:57] stephanebisson, ^^ this is rebased and should be ready for review. I am running into caching issues, though, it seems to be coming from the 'unreadnotificationpages' query that gives me the wrong (seems to be cached??) result [19:09:04] RoanKattouw, and you too ^^ [19:09:15] How can that be [19:09:18] The api response is frustrating [19:09:26] I don't think that module caches anything? [19:09:34] I don't know, but I am getting mismatching information in the sidebar and then what the sidebar loads [19:09:48] if you go through "all" notifs, the notifications load correctly in terms of what page they belong to [19:09:58] but the numbers of how many are read and unread is completely false [19:10:22] I also have a mismatch in the numbers between the sidebar and the popup [19:10:25] "read and unread"? [19:10:28] so it seems to be the sidebar's fault [19:10:29] It queries unread only [19:10:50] the sidebar gives me 39 unread in local (divided between 2 pages) and then 19 in hewiki and 33 in french wiki [19:11:01] but the popup shows 10 unread alrets and 2 unread messages [19:11:08] Note that there are notifications that don't have a page [19:11:19] Oh I see it's giving you numbers that are too high? [19:11:21] So, when I click on the page in french wiki, I actually have 1 unread [19:11:24] not 33 [19:11:43] yeah wrong numbers + wrong pages, though. Some of the pages give back 0 unread [19:11:48] so they shouldn't appear in the sidebar at all [19:11:51] wtf [19:11:55] I know :\ [19:12:08] OK I'll see if I can reproduce that locally [19:12:17] And not only am I not caching it in the front end, it is also like this if I close the browser, reopen, or restart my computer [19:12:23] and clear cache from the browser [19:12:29] very very annoyingly weird [19:12:31] If you mark a notification as unread, do the results change ata ll? [19:12:44] The sidebar, for the moment, is not being updated as-you-go [19:12:47] (I think it's more likely that they're just wrong, than that they're cached) [19:13:09] No but I mean if you mark some more notifications as unread/read, then refresh, you /should/ see different numbers, right? [19:13:12] that's by spec for the MVC right now, since counting the notifications when we have read/unread is not as simple as just increasing/decreasing the number (that's why stephanebisson had the unreadCounter made) [19:13:14] BUT [19:13:33] if you mark stuff as read/unread or whatever, then when you reload the page it should update [19:13:37] IT doesn't seem to [19:13:48] OK so the numbers are completely stuck no matter what you do? [19:13:54] SEems so, yeah [19:13:56] Do they change if you log in as a different user? [19:13:58] that's why I thought cache [19:14:04] let me see [19:14:34] OK, I see, I have 12 alerts and 2 messages but 17 notifs according to the sidebar [19:14:40] :\ [19:15:09] Two pages with wrong counts [19:15:34] Also is the sidebar supposed to be sorted at all? [19:15:39] RoanKattouw, something might be wrong with the unreadnotificationpages in this case? I mean, all I do is display that response. It will be very weird if this is something in the front end, but at this point I'm not sure anymore [19:16:10] also, note to self: Before panicking about how a different user has no sidebar, how about making sure I'M ON THE RIGHT BRANCH [19:16:59] getFromLocal() doesn't seem to consider bundle_base... [19:17:07] AAAH [19:17:10] That's almost certainly it [19:17:10] RoanKattouw, numbers are different in the new user, let me see if they're updating [19:17:27] RoanKattouw, also, I think I spotted a potential faux-pas [19:17:28] that, hopefully, won't be relevant soon [19:17:29] mooeypoo: Also you're sorting the side bar by page_id right now which is probably not the most useful sorting criterion [19:17:55] stephanebisson: Thanks, that fixed it [19:17:57] oh, no, no faux-pas. [19:18:06] RoanKattouw, I did no sorting on there [19:18:29] OK; I'd suggest that perhaps we do want sorting? [19:18:30] Also, no sorting for the moment on the order of the wikis displayed [19:18:40] wasn't sure if we want it by date or number of unread [19:18:43] It's the top 10 by # of notifs so perhaps we should sort by # of notifs? [19:18:53] * mooeypoo nods [19:18:56] can do [19:19:44] (03PS7) 10Catrope: ApiEchoNotificatons: Add nottitles parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) [19:19:47] (03PS15) 10Catrope: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [19:19:50] (03PS1) 10Catrope: ApiEchoUnreadNotificationPages: Only count bundle bases [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294108 [19:19:59] mooeypoo: I just added a fix for the API module and rebased your stuff onto it [19:20:07] ... okay, question. I could do the sorting manually (every time we add a source/page to the filter) which will work now. However, it will be a bit more messy when/if we want the sidebar to respond to changes through the list, like decrease count when we mark as read, etc. [19:20:29] For stuff like that, I propose we don't change the order after initial load [19:20:37] * mooeypoo nods [19:20:46] Because by that same logic, pages should magically fall off the list and be replaced by other pages [19:21:08] Maybe we could change the API module to return an array instead of an object, so that it can be sorted by count [19:21:15] It already is coming from the DB anyway [19:21:38] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2377253 (10hashar) I guess update.php block on the same SQL as extensions/Echo/maintenance/removeOrphanedEvents.php... [19:22:06] RoanKattouw, no, pages shouldn't vanish from the list [19:23:31] Exactly, my point is that since we won't do that, we should just not re-sort at all [19:23:45] (Kind of a reductio ad absurdum argument) [19:27:47] (03CR) 10jenkins-bot: [V: 04-1] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [19:34:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2377293 (10Catrope) >>! In T137615#2377253, @hashar wrote: > Looks like the `echo_notification` table in beta lacks... [19:37:50] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2377295 (10hashar) On beta after INDEX echo_notification_event ON echo_notification (notification_event); | id... [19:38:13] RoanKattouw: about beta / echo sql etc ^^^ Beta was missing an index in the db [19:38:39] RoanKattouw: so one would want to adjust Echo sql schema + ship a patch to: CREATE INDEX echo_notification_event ON echo_notification (notification_event); [19:38:44] and it magically fixed it! [19:38:51] Yeah [19:38:57] I was about to do that actually [19:39:02] ohh [19:39:05] We have that index creation, it's just in a big unmerged patch right now [19:39:08] I have just seen your reply [19:39:21] and the patch got applied to prod before the patch landed right ? [19:39:26] Yes :) [19:39:39] ideally that maintenance script should depend on it hehe [19:39:39] That's why we were lazy about merging it into masetr [19:39:44] yup [19:39:49] "It's already in prod anyway so it doesn't matter" [19:39:54] and beta SQL schema are done automatically via update.php [19:39:56] not via a DBA [19:39:56] But yes I need it to be in update.php before the mainteance script [19:40:13] that part, I have no idea how you can ensure the ordering :( [19:40:38] (at least today I have learned MariaDB can show progress of ALTER commands in SHOW PROCESSLIST https://mariadb.com/kb/en/mariadb/progress-reporting/ ) [19:40:42] there is an extra column [19:40:48] Well update.php really really wants to run maintenance scripts late, not early, so that's not an issue [19:41:06] I had issues last week trying to get one to run /before/ a schema change [19:42:33] https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/9153/console is running [19:42:35] we will see [19:43:04] bork on eswiki [19:43:08] guess I want to mass update [19:43:13] foreachwiki [19:45:46] (03PS43) 10Catrope: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [19:45:49] (03PS1) 10Catrope: Add index on notification_event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294111 [19:45:50] Hold on I've got that patch coming [19:46:01] 10Flow: Flow: "This comment was hidden..." is not very clear - https://phabricator.wikimedia.org/T137661#2374754 (10Etonkovidova) Yes, the placement and wording of hidden comments make it unclear what exactly was hidden. It'd be much more informative to have full information displayed - the name of a user which... [19:46:13] Ugh, wait [19:46:35] RoanKattouw: tried a foreachwiki but I am rusty on that front :D [19:46:48] Give me a minute and I'll fix it by merging my patch :) [19:46:55] ! [19:46:55] 03Collab-Team-Q1-July-Sep-2016, 10Edit-Review-Improvements: Post page describing Edit Review Improvements to Mediawiki - https://phabricator.wikimedia.org/T137741#2377319 (10jmatazzoni) [19:46:55] I just forgot one part of the patch [19:47:01] RoanKattouw: take your time! [19:48:29] sorry, was distracted into an i18n conversation with amir (who's in the office!) [19:48:34] Oh! [19:48:53] nobody wants to miss an i18n chat with Amir [19:48:54] Oh I guess he mentioned this when we were at Yad Vashem, that he'd be coming to SF in the summer? [19:48:55] now brb, lunch. RoanKattouw stephanebisson I'll work on the resorting of the pages when I get back, and then on stephanebisson's commit [19:49:07] RoanKattouw: feel free to head to lunch [19:49:09] hashar, he also gave me more examples for my "bdi in the wild" collection [19:49:25] RoanKattouw: no blocker for me. I am happy to finally have found the root cause which is just the missing index apparently [19:49:29] anyways, lunch, bbiab [19:49:53] (03PS2) 10Catrope: Add index on notification_event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294111 [19:49:54] hashar: I'm in the UK this week so I will not be joining mooey|lunch [19:49:56] (03PS44) 10Catrope: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [19:52:01] (03PS8) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [19:52:37] (03CR) 10Catrope: [C: 032] Add index on notification_event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294111 (owner: 10Catrope) [19:52:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07WorkType-NewFunctionality: Change the icon for the cross-wiki notification bundle "dismiss" action, to distinguish it from "mark as read" - https://phabricator.wikimedia.org/T137742#2377342 (10Quiddity) [19:53:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements: Post page describing Edit Review Improvements to Mediawiki - https://phabricator.wikimedia.org/T137741#2377358 (10jmatazzoni) [19:53:28] hashar: Once that ---^^ goes through the whole pipeline, the index should be created and things should calm down [19:53:34] (03CR) 10Sbisson: [C: 032] ApiEchoUnreadNotificationPages: Only count bundle bases [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294108 (owner: 10Catrope) [19:54:15] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2377359 (10Catrope) >>! In T137615#2377293, @Catrope wrote: > I'll fix that by splitting off this index creation.... [19:55:27] RoanKattouw: I manually created the index on eswiki, but have left the other db untouched. Good news update.php completes! [19:56:23] RoanKattouw: I should have poked you during the day :D But I first wanted to find the root cause [19:56:24] Nice [19:56:28] No worries [19:56:43] I wasn't on line until about 20:00 your time anyway [19:57:05] and sorry about removeInvalidTargetPage confusion [19:57:24] We went away for a quick trip, but nothing is ever quick with 6 children especially if one is sick [19:57:26] I though it would be a good idea to blindly run a script that looks like it could well drop a ton of useless raws [19:57:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:58:12] haha [19:58:22] It probably is a good idea to run that script [19:58:26] Once we fix it so it's runnable [19:58:46] (03CR) 10jenkins-bot: [V: 04-1] Add index on notification_event [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294111 (owner: 10Catrope) [19:59:09] stephanebisson: Yay, the read bundle backfill script has now run on all wikis [19:59:19] good! [19:59:58] I just realized getPrimaryLinkWithMarkAsRead() is potentially creating data that would need to be migrated... [20:00:21] Hm? [20:00:26] it marks only the bundle_base as read [20:00:30] Ooooh [20:00:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Beta-Cluster-Infrastructure: beta-update-databases-eqiad being aborted at 45 minutes since June 9th - https://phabricator.wikimedia.org/T137615#2377370 (10hashar) So the issue was the introduction in Echo of a script/db update: RemoveOrphanedEvents . It depe... [20:00:39] Maybe that's why we still have some [20:00:47] I'll update it to send all ids for bundles [20:01:02] RoanKattouw: I have updated the task with a summary. [20:01:03] doing a re-run of the script would be quick, right? [20:01:07] I decided to rerun on one wiki (from the first group, so from last week) to verify it caught everything, and it still picked up a couple hundred [20:01:23] And yes, also validating the assumption that a rerun would be quick [20:01:48] Although, enwiki only took 8 hours and the others were much quicker, so I'll just do a foreachwiki once we get everything patched by [20:01:51] *patched up [20:02:16] working on the patch right now [20:02:22] Awesome [20:03:58] 2m29s to rerun mediawikiwiki, found 913 notifs to update [20:04:07] (03Merged) 10jenkins-bot: ApiEchoUnreadNotificationPages: Only count bundle bases [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294108 (owner: 10Catrope) [20:11:54] The second rerun took 2m8s and updated 0 notifications [20:12:11] So it looks like reruns are "fast" but not amazingly so [20:12:23] (03PS9) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [20:12:58] I'll do a rerun on Thursday/Friday then, once we have wmf.6 (which will contain your patch) deployed everywhere [20:50:32] Be back in a few minutes. [20:57:48] 06Collaboration-Team-Interested, 10Notifications: Cross-site notifications loads slowly - https://phabricator.wikimedia.org/T129787#2116356 (10Etonkovidova) Re-checked on nowiki - Notification flyout with cross-wiki messages expand in around a sec; Special:Notifications page loads in about one second time too. [20:58:04] 06Collaboration-Team-Interested, 10Notifications: Cross-site notifications loads slowly - https://phabricator.wikimedia.org/T129787#2377505 (10Etonkovidova) 05Open>03Resolved [21:08:34] RoanKattouw, regarding the "caching" issue -- when I changed user, it changed. Refresh = changed. I changed user back = changed numbers (properly) refreshed again = changed .... could it have been a weird issue with browser caching network response!? [21:09:58] mooeypoo: I'm pretty sure I already found it, and Stephane already merged my fix [21:10:16] And I rebased your code onto it [21:10:40] It seems like it was counting bundles when it shouldn't [21:10:54] * mooeypoo nods [21:10:56] okay that makes sense [21:11:04] I'm working on the reordering now [21:11:15] I'm using OO.SortedEmitterList for the widgets [21:11:32] That's the most straight-forward way without implementing a whole ordering logic [21:13:13] 06Collaboration-Team-Interested, 10Flow: VE copy/paste issues - external links and formulas - https://phabricator.wikimedia.org/T137503#2377556 (10jmatazzoni) [21:21:50] 03Collab-Team-Q1-July-Sep-2016, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Create a page about known issues concerning Flow - https://phabricator.wikimedia.org/T137686#2377563 (10Etonkovidova) [21:25:00] 06Collaboration-Team-Interested, 10Flow: Flow: compare-post-revisions page haven't link to full post page - https://phabricator.wikimedia.org/T137629#2377570 (10Quiddity) It is currently possible, via the page-tab (Sujet). Long-term, we need to work on {T90280} or similar. [21:37:26] RoanKattouw, meh, I don't understand why my ordering isn't working on the page-level [21:38:04] RoanKattouw, I'm using OO.binarySearch( ... ) to find the insertion index per item and then I this.addItems( [ item ], insertionIndex ) [21:38:09] but they're not ordered! :( [21:39:38] meh, it's not running the binary search at all. wtf. [21:40:07] Maybe you could pastebin (the relevant part of) your code? [21:40:31] OO.binarySearch() isn't the most intuitive thing to use (partly because binary search itself isn't), so you might be using it in a way that's subtly wrong [21:41:25] RoanKattouw, http://pastebin.com/V3etN5u4 [21:41:33] see 'setItems' and 'findInsertionIndex' [21:41:37] at the end [21:43:08] RoanKattouw, I have a debugger in the option widget ('item') getCount method, and it's never triggered [21:43:11] wtf [21:43:29] (03PS1) 10Mattflaschen: SECURITY: Fix topic title visibility [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294175 (https://phabricator.wikimedia.org/T137593) [21:44:03] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Flow: "Edit resume" button add infinite text boxes - https://phabricator.wikimedia.org/T137459#2377660 (10jmatazzoni) [21:45:28] (03PS2) 10Mattflaschen: SECURITY: Fix topic title visibility [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294175 (https://phabricator.wikimedia.org/T137593) [21:45:34] RoanKattouw, meh, I need to go to a meeting soon [21:45:44] But I figured it out, though it makes no sense [21:46:22] Ahm, is your callback to binarySearch supposed to return a function? [21:46:35] yes [21:46:48] 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016, 10MediaWiki-Special-pages: Consider to have a max-width for Special:Notifications page - https://phabricator.wikimedia.org/T137425#2377679 (10jmatazzoni) [21:46:49] Pretty sure it's not [21:46:57] I think you need an IIFE there [21:47:05] hang on, I solved it another way [21:47:24] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2377682 (10Quiddity) [21:47:26] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07WorkType-NewFunctionality: Change the icon for the cross-wiki notification bundle "dismiss" action, to distinguish it from "mark as read" - https://phabricator.wikimedia.org/T137742#2377680 (10Quiddity) 05Open>03Invalid I was incorrect/outofdate, and hadn... [21:48:06] (03PS16) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [21:48:10] 10Notifications: Notifications turn up again on other wikis - https://phabricator.wikimedia.org/T137752#2377687 (10Johan) [21:48:13] RoanKattouw, I have to go to a meeting -- but ^^ works [21:48:25] thee was something with an IIFE for sure - I solved it by taking the ordering method outside [21:48:33] i'll bbl [21:48:34] OK yeah that works as a fix [22:04:54] 06Collaboration-Team-Interested, 10Notifications: False-positive mention notification sent - https://phabricator.wikimedia.org/T137755#2377768 (10Quiddity) [22:10:00] 06Collaboration-Team-Interested, 10Notifications: False-positive mention notification sent - https://phabricator.wikimedia.org/T137755#2377768 (10Catrope) I think there's a clue in the diff. Because the "Could some admin from here..." paragraph contains ".sr", the diff algorithm thinks that paragraph was chang... [22:22:20] (03CR) 10Mattflaschen: [C: 032] Don't allow multiple summary editors to be opened for the same topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293759 (https://phabricator.wikimedia.org/T137459) (owner: 10Catrope) [22:29:55] (03Merged) 10jenkins-bot: Don't allow multiple summary editors to be opened for the same topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293759 (https://phabricator.wikimedia.org/T137459) (owner: 10Catrope)