[05:58:38] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests: Enable Flow on fr Wikibooks as Beta Feature - https://phabricator.wikimedia.org/T137396#2367089 (10Archi38) [08:43:05] 10Notifications: Incorrect URI fragment from echo when heading is a link - https://phabricator.wikimedia.org/T137390#2367245 (10Glaisher) [08:46:34] 10Notifications: Incorrect URI fragment from echo when heading is a link - https://phabricator.wikimedia.org/T137390#2367254 (10Catrope) [08:46:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Regression: [betalabs] Notification about Mention on wikitext pages does not link to the section where Mention occurred if links, templates etc are present in section titles - https://phabricator.wikimedia.org/T134216#2367256 (10Catrope) [09:05:09] 10Flow, 10MediaWiki-Revision-deletion, 07Security-General: Applying deletelogentry restrictions to flow deletion log entries does not work - https://phabricator.wikimedia.org/T137288#2367283 (10MarcoAurelio) >>! In T137288#2365240, @Mattflaschen-WMF wrote: > I'm not sure why deletelogentry is applying differ... [09:06:55] 10Notifications, 06Performance-Team, 06TCB-Team, 07Performance: Investigation: Can DeferredUpdates call in Echo Hooks for EchoDiscussionParser::generateEventsForRevision be removed? - https://phabricator.wikimedia.org/T136928#2367292 (10Catrope) >>! In T136928#2363518, @aaron wrote: > That seems kind of ha... [09:09:21] Wow, apparently 3 votes vs 2 with one of the pro voters saying "I'm not active on this project" constitutes consensus on frwikibooks... [09:13:28] 10Notifications: A bundle of more than 99 notifications shows as 100 - https://phabricator.wikimedia.org/T137296#2364125 (10Catrope) Which message key is this? (You can find out using `?uselang=qqx`.) The message I see in my local i18n file is correct: ``` "flow-notification-newtopic-bundle": "{{PLURAL:$1|One n... [09:16:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#2367305 (10Catrope) >>! In T122262#2365382, @Mattflaschen-WMF wrote: > I guess the question is whether we want to try to... [09:29:09] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Special:Notifications FOUC due to More Info | Preferences changing into icons in Vector/MonoBook skins - https://phabricator.wikimedia.org/T118342#2367329 (10Catrope) 05Open>03Resolved a:03Catrope [09:29:54] 06Collaboration-Team-Interested, 10Flow, 10Notifications, 07Tracking: Improve organization and control for Flow notifications (tracking + ideas) - https://phabricator.wikimedia.org/T100528#2367333 (10Catrope) [09:29:57] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Design: Special:Notifications does not mirror the read/unread statuses from the echo flyout - https://phabricator.wikimedia.org/T78363#2367331 (10Catrope) 05Open>03Resolved a:03Catrope [09:37:50] (03CR) 10Catrope: Separate model's symbolic name and model's source (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293451 (owner: 10Mooeypoo) [09:37:57] (03CR) 10Catrope: [C: 04-1] Separate model's symbolic name and model's source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293451 (owner: 10Mooeypoo) [12:27:09] 10Notifications: A bundle of more than 99 notifications shows as 100 - https://phabricator.wikimedia.org/T137296#2367609 (10SBisson) >>! In T137296#2367303, @Catrope wrote: > Which message key is this? (You can find out using `?uselang=qqx`.) The message I see in my local i18n file is correct: > > ``` > "flow-n... [12:30:18] 10Notifications: A bundle of more than 99 notifications shows as 100 - https://phabricator.wikimedia.org/T137296#2367617 (10Catrope) a:03Catrope Hah, looks like the 99+ changes changed the wrong messages then. Will fix. [12:32:36] (03PS1) 10Catrope: Update messages referring to topics and replies for 99+ changes in Echo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293496 (https://phabricator.wikimedia.org/T137296) [12:45:14] (03CR) 10Sbisson: [C: 032] Update messages referring to topics and replies for 99+ changes in Echo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293496 (https://phabricator.wikimedia.org/T137296) (owner: 10Catrope) [12:51:05] (03CR) 10jenkins-bot: [V: 04-1] Update messages referring to topics and replies for 99+ changes in Echo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293496 (https://phabricator.wikimedia.org/T137296) (owner: 10Catrope) [13:00:33] (03CR) 10Catrope: "12:46:33 stderr: 'fatal: unable to access 'https://gerrit.wikimedia.org/r/p/mediawiki/extensions/GuidedTour/': Could not resolve host: ger" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293496 (https://phabricator.wikimedia.org/T137296) (owner: 10Catrope) [13:00:41] (03CR) 10Catrope: [C: 032] "Per Stephane" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293496 (https://phabricator.wikimedia.org/T137296) (owner: 10Catrope) [13:01:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Dynamic bundle: non-bundle_base notifications need a read timestamp - https://phabricator.wikimedia.org/T136368#2367720 (10Catrope) >>! In T136368#2362442, @Catrope wrote: > inspecting the results doe... [13:11:10] (03CR) 10Paladox: "Oh Krinkle had that problem yesterday. May be related to the gallium failure." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293496 (https://phabricator.wikimedia.org/T137296) (owner: 10Catrope) [13:12:05] (03Merged) 10jenkins-bot: Update messages referring to topics and replies for 99+ changes in Echo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293496 (https://phabricator.wikimedia.org/T137296) (owner: 10Catrope) [13:47:54] 10Notifications, 13Patch-For-Review: A bundle of more than 99 notifications shows as 100 - https://phabricator.wikimedia.org/T137296#2367830 (10Catrope) 05Open>03Resolved [13:52:13] (03PS1) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [13:52:38] (03PS1) 10Sbisson: Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) [13:53:44] (03CR) 10jenkins-bot: [V: 04-1] Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [13:57:42] Ooh, shiny! [14:00:07] well... rough around the edges but still somewhat shiny ;) [14:04:39] :) [14:04:47] I just got the message->alert migration stuff working fully [14:05:08] And simulated moving edit-user-talk from messages to alerts locally [14:14:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests: Enable Flow on fr Wikibooks as Beta Feature - https://phabricator.wikimedia.org/T137396#2367860 (10Dereckson) « 3 votes contre deux, je lance la task phabricator » doesn't seem a consensus but more a 50/50 vote (or 60/40 if you like). Perhaps... [14:21:42] (03PS2) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [14:24:44] (03PS6) 10Catrope: Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) [14:27:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests: Enable Flow on fr Wikibooks as Beta Feature - https://phabricator.wikimedia.org/T137396#2367894 (10Dereckson) 05Open>03declined Former steward @DarkoNeko did a vote analysis: * one of the contributor in the approval section has only 1 con... [14:32:57] 06Collaboration-Team-Interested, 10Flow, 06Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review, and 3 others: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2367907 (10Trizek-WMF) [14:43:17] (03PS2) 10Sbisson: Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) [14:43:44] (03CR) 10jenkins-bot: [V: 04-1] Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [14:50:56] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07User-notice: Visiting Special:Notifications should not mark notifications as read - https://phabricator.wikimedia.org/T97057#2367978 (10Trizek-WMF) [14:54:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests: Enable Flow on fr Wikibooks as Beta Feature - https://phabricator.wikimedia.org/T137396#2367991 (10Dereckson) Furthermore, I see the project is currently discussing voting rules at https://fr.wikibooks.org/wiki/Wikilivres:Le_Bistro/2016#Wikili... [14:55:49] 10Flow: On Beta, Flow talk page manager does not move pre-existing sub-pages of archives - https://phabricator.wikimedia.org/T133835#2367996 (10Trizek-WMF) Full links didn't worked fine in that case. That's the purpose of that task. [14:58:33] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Minimal JS version of Special:Notifications - https://phabricator.wikimedia.org/T129176#2368009 (10Trizek-WMF) [15:04:05] (03PS3) 10Sbisson: [WIP] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [15:06:56] 10Collab-Notifications-Page: Special:Notifications should have a max-width - https://phabricator.wikimedia.org/T137425#2368032 (10Trizek-WMF) [15:09:13] 06Collaboration-Team-Interested, 10Flow, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Email notification about "someone edited the description on Flow board" should point to the diff, not the page - https://phabricator.wikimedia.org/T135136#2368053 (10Trizek-WMF) 05Open>... [15:13:02] (03PS3) 10Sbisson: Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) [15:13:30] (03CR) 10jenkins-bot: [V: 04-1] Make notifications expandable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/293505 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [15:13:48] 06Collaboration-Team-Interested, 10Flow, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Email notification about "someone edited the description on Flow board" should point to the diff, not the page - https://phabricator.wikimedia.org/T135136#2368061 (10Catrope) 05Resolved... [15:14:37] (03PS2) 10Catrope: ApiEchoNotificatons: Add nottitles parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) [15:15:46] (03PS1) 10Catrope: Don't set title to Main Page for user-rights notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293516 [15:16:12] In today's edition of legacy code WTFs: user-rights notifications are associated with the Main Page https://gerrit.wikimedia.org/r/293516 [15:16:50] (03CR) 10Catrope: ApiEchoNotificatons: Add nottitles parameter (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) (owner: 10Catrope) [15:17:05] interesting.... [15:17:17] (03PS3) 10Catrope: ApiEchoNotificatons: Add nottitles parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) [15:17:20] set title to what? [15:17:36] special:log? [15:17:37] (03PS4) 10Catrope: ApiEchoNotifications: Add nottitles parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) [15:17:44] userpage? [15:17:49] User page makes some sense [15:18:03] We might actually want to do that for both user-rights and welcome, so that they appear when you filter by your user page [15:18:11] My patch sets it to null for consistency with welcome [15:18:24] and... another type that's slipped my mind right now [15:18:42] emailuser [15:18:46] yep [15:19:09] I guess we could assoicate emailuser with the user page of the sender [15:19:29] also, we need to test the flow notifications to make sure they don't appear grouped by "topic:1234567890", that would be ugly [15:19:44] I'm pretty sure they won't be [15:19:55] But I'll look in the DB real quick [15:20:19] In any case we may want to write a migration script (again) to ensure the titles for these types are what we want them to be [15:20:43] Speaking of migration scripts, I've run backfillReadBundles.php on all group0 and group1 wikis [15:20:54] Only took about an hour or two (I didn't pay too much attention) [15:20:58] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07User-notice: Mark groups of notifications as read - https://phabricator.wikimedia.org/T132738#2368073 (10Trizek-WMF) [15:21:00] cool [15:21:01] wikidata took 11 minutes apparently and that's a big one [15:21:24] when do you plan to run for the remaining wikis? [15:21:33] Tonight [15:21:45] group2 doesn't get wmf5 until about lunchtime Pacific today [15:22:09] Come to think of it that'll be pretty late here, it might be at 10pm, so I'll probably do it tomorrow [15:30:31] stephanebisson: Ugh, you're right, flow-topic-resolved uses Topic:barf as its title [15:30:45] But flow-topic-renamed doesn't [15:30:47] Logic! [15:33:20] @RoanKattouw What time that change will happen? https://gerrit.wikimedia.org/r/#/c/292198/ [15:33:36] Trizek|away: I was gonna ask you that question [15:34:02] The next opportunities are tonight at 1am our time (Matt would have to do it in that case), or Monday at 5pm [15:34:13] My answer is "when you will notice me with enough time to post a message on fr's VP" [15:34:34] In that case, you have your pick of either 5pm or 1am on any Mon/Tue/Wed/Thu [15:34:42] (European time) [15:34:53] 1am if possible, because the deployment has been announced for today. [15:35:08] OK let's do that [15:35:13] I'm gonna get dinner now [15:35:14] cool [15:35:18] But I'll set it up when I come back [15:35:25] Super! [15:35:35] RoanKattouw: if you change event_page_id we'll have to update, or at least re-test, the notification links [15:35:38] I'm drafting the message right now. [15:36:24] 10Flow, 13Patch-For-Review: Deploy Flow as a Beta Feature on French Wikipedia - https://phabricator.wikimedia.org/T136684#2368138 (10Trizek-WMF) Will be scheduled for 23:00 UTC today. [15:36:27] Yes, uses of getTitle() generally but especially those [15:39:42] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#1838142 (10Trizek-WMF) p:05Normal>03High Let's start something. I will wo... [15:51:15] 06Collaboration-Team-Interested, 10Flow, 06Community-Liaisons (Apr-Jun-2016), 07User-notice: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2368207 (10Quiddity) [16:49:42] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Have a way to mark all notifications as read at once - https://phabricator.wikimedia.org/T136614#2368435 (10Quiddity) [16:49:44] 06Collaboration-Team-Interested, 10Notifications: I want to clear the indicator for messages - https://phabricator.wikimedia.org/T71732#2368437 (10Quiddity) [16:51:37] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: I want to clear the indicator for messages - https://phabricator.wikimedia.org/T71732#743835 (10Quiddity) Merged task description: > [[ https://fr.wikipedia.org/w/index.php?title=Discussion_Wikip%C3%A9dia:Notifications&diff=0&oldid=126656069#Supprim... [16:55:13] matt_flaschen: Would you be prepared to do a config SWAT (Flow beta feature on frwiki) in the evening SWAT (4pm Pacific) today? [16:55:32] I'd normally do it myself but it's at 1am for me now [16:58:18] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2368471 (10Nemo_bis) >>! In T89398#2366101, @ArielGlenn wrote: > Checking a couple of wikis where flow is in fact enabled, officewiki (p... [17:04:04] (03CR) 10Sbisson: [C: 032] "Works for me. I prefer to merge now." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) (owner: 10Catrope) [17:04:38] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Easy: Add a "Mark all as read" button at Special:Notifications for mobile and no-JS users - https://phabricator.wikimedia.org/T96061#2368495 (10Quiddity) [17:04:40] 06Collaboration-Team-Interested, 10Flow, 07Tracking: Mobile web - Flow issues (tracking) - https://phabricator.wikimedia.org/T93430#2368494 (10Quiddity) [17:05:06] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Easy: Add a "Mark all as read" button at Special:Notifications for mobile and no-JS users - https://phabricator.wikimedia.org/T96061#1207424 (10Quiddity) [17:05:38] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Easy: Add a "Mark all as read" button at Special:Notifications for mobile and no-JS users - https://phabricator.wikimedia.org/T96061#1207424 (10Quiddity) [17:06:52] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: I want to clear the indicator for messages - https://phabricator.wikimedia.org/T71732#743835 (10Quiddity) [17:07:26] RoanKattouw, sure, I can do the SWAT tonight. [17:07:38] (03CR) 10Catrope: "Sounds good. We may have to --force it then but that's fine." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) (owner: 10Catrope) [17:07:40] Thanks [17:08:39] (03CR) 10Legoktm: [C: 032] Don't set title to Main Page for user-rights notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293516 (owner: 10Catrope) [17:09:34] (03CR) 10Mooeypoo: "Answering comments." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293451 (owner: 10Mooeypoo) [17:09:59] (03Merged) 10jenkins-bot: Add script to remove orphaned event rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) (owner: 10Catrope) [17:14:25] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Gate cross-wiki preferences entirely (default off) - https://phabricator.wikimedia.org/T135266#2368559 (10jmatazzoni) 05Open>03Resolved [17:15:54] (03Merged) 10jenkins-bot: Don't set title to Main Page for user-rights notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293516 (owner: 10Catrope) [17:54:45] RoanKattouw, stephanebisson https://gerrit.wikimedia.org/r/293451 <-- majority of issues are more conceptual, so your input needed on the comments + answers [17:55:12] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07User-notice: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2368742 (10SBisson) a:03SBisson [17:56:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2368744 (10SBisson) a:03SBisson [17:56:20] mooeypoo: Yeah I'll reread those in a minute [17:56:28] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2368746 (10Trizek-WMF) //To check//: * how many notifications max are displa... [17:56:32] My initial response is something like "OK but then explain that in comments especially since there seem to be 2 subtly different concepts with almost the same name" [17:56:53] And re passing the name/source to the function, my views on those things tend to be that if the function can look up one from the other, it should. Also prevents you from doing silly things like passing in the wrong source [17:57:40] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2368761 (10Trizek-WMF) [18:09:13] RoanKattouw, but the items can't look up their container, they're "dumb" [18:09:39] they don't know where they're "hosted" in which list. They just retain their information. So when you click "mark read" the widget asks its model (item model) for the details it has, and the item has no reference for its list model. Should it? I thought meh. [18:22:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests: Enable Flow on fr Wikibooks as Beta Feature - https://phabricator.wikimedia.org/T137396#2368843 (10Archi38) I perfectly understand. It was my fault, I talked about this RFC on [[ https://fr.wikipedia.org/wiki/Wikipédia:Sondage/Flow_en_fonction... [18:32:32] 10Flow: Flow: "Edit resume" button add infinite text boxes - https://phabricator.wikimedia.org/T137459#2368888 (10Framawiki) [18:42:08] hello, I would like to attract your attention to https://gerrit.wikimedia.org/r/#/c/276159/ which is about to be merged, just needs some Echo eyes [18:47:44] RoanKattouw, ^^ [18:50:11] (03PS6) 10Mooeypoo: [wip] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 [18:58:18] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (owner: 10Mooeypoo) [19:33:54] mooeypoo: What I mean is, from the name of a model you can derive the source of the model, if I understand correctly [19:34:05] By asking the ModelManager [19:34:18] So I shouldn't have to give a function both a model name and a source [19:35:28] (Sorry for the delay in answering, my grandparents showed up for a quick visit) [19:38:47] Going to get lunch then go into the coworking space. [19:40:22] matej_suchanek: Looking [19:58:56] 10Collab-Notifications-Page: Special:Notifications should have a max-width - https://phabricator.wikimedia.org/T137425#2369318 (10Pginer-WMF) > @Pginer-WMF, thoughts regarding max-widths? We plan to set a max-width for notification items not become too stretched. However, T129366 involves adding a filtering pan... [20:00:13] 06Collaboration-Team-Interested: [production] On the first sign-up, cross-wiki notificaitons expands to blank placeholder - https://phabricator.wikimedia.org/T137476#2369321 (10Etonkovidova) [20:08:15] RoanKattouw: thanks, I will look into it tomorrow [20:09:19] about the email pr. models, do they have full support, or are they still being worked on? [20:25:10] I think everything is supposed to use presentation models now, including emails [20:25:28] In *theory* the old system (formatters) is no longer used, but in practice I think there are still some code paths that do run that code [20:25:43] Quite soon we want to port those and remove the old system [20:25:46] ( matej_suchanek ) [20:30:30] just about the bundling, it was intended to bundle all events to one because the user should not care about which pages that were but what happened (and what they can do next time) [20:35:21] 10Notifications: ?markasread=NNN not added to primary links in emails - https://phabricator.wikimedia.org/T137488#2369590 (10Catrope) [20:52:30] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2369684 (10Qgil) [21:06:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: "Failed to fetch notifications." is displayed as a link - https://phabricator.wikimedia.org/T137490#2369800 (10Catrope) No, that's a bug [21:16:45] (03PS7) 10Mooeypoo: [wip] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [21:17:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Revision-deletion, 07Security-General: Applying deletelogentry restrictions to flow deletion log entries does not work - https://phabricator.wikimedia.org/T137288#2369838 (10Quiddity) p:05Triage>03High [21:23:25] RoanKattouw, btw, are user pages considered titles ? [21:23:33] Yes, every page is a title [21:23:34] User:Mooeypoo and User_talk:Mooeypoo ...? [21:23:36] hm. [21:23:38] Exactly [21:23:51] However, some notif types don't behave in useful ways [21:23:54] Also Special:ThisPageDoesNotExist is a title. [21:23:58] I forgot to file tasks about this, so maybe you could [21:24:20] 1) flow-topic-resolved uses Topic:barf as its title instead of Talk:Something; the other flow-* types do work correctly [21:24:42] 2) until today, user-rights notifs always had Main_Page as their title [21:24:53] 3) welcome and emailuser have no title (null) [21:25:15] We may want user-rights and welcome to have the user's user page as the title, and emailuser the sender's user page [21:25:28] My patch that was merged today for #2 makes user-rights use null too [21:28:51] 10Flow: On Beta, Flow talk page manager does not move pre-existing sub-pages of archives - https://phabricator.wikimedia.org/T133835#2369917 (10Mattflaschen-WMF) >>! In T133835#2367996, @Trizek-WMF wrote: > Full links didn't worked fine in that case. That's the purpose of that task. Links (like [this case](http... [21:28:53] wait, it uses Topic:barf ? like, is that an example or is it literally using Topic:barf because it's some weird and unfortunate MW acronym [21:29:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: ?markasread=NNN not added to primary links in emails - https://phabricator.wikimedia.org/T137488#2369918 (10Catrope) [21:31:28] mooeypoo, no, it's not really using barf. :) [21:32:48] matt_flaschen, ... I can't decide if I'm relieved or disappointed. [21:34:07] RoanKattouw, so can I rebase Phillip on top of your nottitles so I can use it there, or should I release Phillip without pages, and create another patch on top of nottitles ? [21:34:40] mooeypoo: Topic:fd878sd7g98fdg7fd8g7sf [21:34:45] Or whatever [21:34:58] oh that kind of barf [21:35:03] Ahm, either is fine with me [21:35:06] that makes sense [21:35:09] (re rebase order) [21:35:15] RoanKattouw, if you think nottitles will block it too much, I won't. [21:35:25] Nah that should be good to go now [21:35:27] but it'll probably be more straight forward if I can use the page pull immediately [21:35:36] ok, I'll rebase [21:36:06] RoanKattouw, other than the pages, my patch is about to be ready. [21:36:20] it's a little big, though. I'm going to see if there are things I can take out of it like the separation of source/name [21:36:29] (which I'll fix soon too) [21:41:37] mooeypoo: You should trade reviews with stephanebisson for https://gerrit.wikimedia.org/r/#/c/293504/ [21:52:54] mooeypoo: Also, https://phabricator.wikimedia.org/T137490 looks like a boo-boo on your part? [21:53:34] meh [21:58:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2369994 (10Catrope) [21:59:01] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2369994 (10Catrope) (While doing this, take care that the primary/secondary link generation code and anything else using `$event->getTitle()` keeps working.) [22:08:48] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2370031 (10Catrope) [22:09:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Revision-deletion, 07Security-General: Applying deletelogentry restrictions to flow deletion log entries does not work - https://phabricator.wikimedia.org/T137288#2370050 (10Mattflaschen-WMF) a:03Mattflaschen-WMF >>! In T137288#2367283, @MarcoAurelio wro... [22:11:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2370062 (10Catrope) [22:11:44] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 07Security-General: Applying deletelogentry restrictions to flow deletion log entries does not work - https://phabricator.wikimedia.org/T137288#2370065 (10Mattflaschen-WMF) [22:13:22] 03Collab-Team-2016-Apr-Jun-Q4, 10MediaWiki-extensions-GuidedTour, 13Patch-For-Review, 05WMF-deploy-2016-06-14_(1.28.0-wmf.6): GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't) - https://phabricator.wikimedia.org/T132989#2216324 (10... [22:16:02] (03PS1) 10Catrope: Add ?markasread=NNN to primary links in emails too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293632 (https://phabricator.wikimedia.org/T137488) [22:16:40] RoanKattouw, okay, I now remember better why the modelSource and modelName were needed -- in the case of xwiki model, it contains subgroup models and THEY have sources. We need to get their sources, not the xwiki total model source. They are not stored individually, though, because they're part of the xwiki model, so if you do model = this.manager.getNotificationsModel( 'xwiki' ) and then model.getSource() you are getting the wrong [22:16:40] thing. [22:17:04] OK, but do they not have individual models as well? [22:17:07] Or is xwiki one model? [22:17:40] And in that case, is there a reason why markAsRead cares about the model? I can understand it needing the source because it needs to send an API request there, but why does it need the model name [22:20:35] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2370031 (10Platonides) Special:Emailuser/Catrope would be another option for emailuser, although probably more semantical than... [22:21:08] xwiki is a single model [22:21:15] it contains sub-models, per source [22:21:38] so to get their models, you call the xwiki model and then fetch from the list by source, because in that case source is unique identifier [22:23:08] OK [22:23:22] So, generally speaking, is a source always a unique identifier within a model? [22:23:39] Then passing (model, source) pairs would make some sense [22:23:55] But source also means something else, so I still think that's a bit confusing [22:24:10] source means where that model fetches from [22:24:18] Another big question is, how has Stephane dealt with this in his expandable bundle code. I haven't read that yet [22:24:23] name is the unique identifier of the model within model manager [22:24:27] or within a list [22:24:39] incidentally, xwiki sub-models have unique sources [22:24:51] Yes, that's more of a coincidence [22:24:59] I can also name them by their sources, to make it consistent [22:25:18] regardless, we will need their name -- which is the source of the item -- when we tell the controller to mark as read [22:25:27] Well, I was just thinking, since we have a model manager it would be nice to actually be able to use it to identify models [22:25:43] stephane and I talked about how it's completely confusing and we should separate the concepts of name and source [22:25:52] Having to pass in both the model and the source -- I understand why it's currently needed because name='xwiki' doesn't identify the specific model, but it's ugly IMO [22:25:58] Yes I completely agree [22:26:01] it does identify models, but their scope is different [22:26:07] Yes [22:26:25] if we put all models in model manager, we are missing another key behavior of it, which is encapsulation [22:26:41] the model manager has the "top" items, the ones that the list widget or view/UI displays. [22:27:29] We have one main model for all local items, they're displayed individually - but all other models are some sort of groupings. xwiki is a group for cross-wiki. Inside it, it also needs to store sources and items for those sources, and manage what happens when you mark an entire group as read, etc -- but it itself is one big item [22:27:49] local bundles, each, are another model, because they, too, are an item [22:28:56] if we bring out the xwiki inner models out to the manager, we lose the ability to use hierarchical events. Have the "big list" widget listen to the manager (for all notif models, because each represent SOME item in it) and the xwiki item widget to liste to the xwiki item, and each of the xwiki-subgroup-widget to listen to the xwiki-sub-model that's relevant to it [22:28:58] that makes sense? [22:29:32] RoanKattouw, I thnk part of the confusion is another issue. Originally, the mark as read was separated completely between xwiki and "regular" item [22:29:40] I thought the whole point of the ModelManager was to not *have* that kind of encapsulation and hierarchy [22:29:53] for regular items, we need their model names only. We can find everything from there [22:30:08] for xwiki bundled items, we just need the source, we don't need the model name (we know it, it's xwiki) [22:30:20] But I agree that conceptually, to the big list, there is a hierarchy [22:30:29] but we ended up combining that method to one master method that checks if the item is foreign call xwiki, and if not, call local [22:30:37] Really what you need is not a source but a sub-name [22:30:55] sure [22:31:00] I could do that [22:31:13] Also, I wonder if you couldn't have all cross-wiki models be top-level [22:31:25] And have the aggregation of them into a single cross-wiki bundle be a UI concern [22:31:47] Or maybe something that dm.CrossWikiNotificationItem does in a way that makes it still kind of like an item but no longer like a model [22:32:36] eh [22:32:52] Anyway, I'm fading and I need to catch a train in 11 hours [22:32:57] So I'm gonna call it a night [22:33:03] RoanKattouw, we could, but it would require a bit of a rewrite of several things. I personally thing it's the wrong conceptual way to go, but we can continue discussing [22:33:07] ok, have a good night! [22:33:09] enjoy the train [22:33:45] I may not be around too much tomorrow during the daytime your time [22:34:16] But do continue hashing this out with Stephane too :) [22:43:13] * mooeypoo nods [22:50:29] 03Collab-Team-2016-Apr-Jun-Q4: VE copy/paste issues - external links and formulas - https://phabricator.wikimedia.org/T137503#2370149 (10Etonkovidova) [23:06:24] 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Deploy Flow as a Beta Feature on French Wikipedia - https://phabricator.wikimedia.org/T136684#2370170 (10Dereckson) [23:08:10] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2370186 (10Quiddity) How practical/desirable (technically-speaking) would it be to just associate them with a non-p... [23:09:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: VE copy/paste issues - external links and formulas - https://phabricator.wikimedia.org/T137503#2370192 (10Quiddity) [23:18:06] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2370200 (10jmatazzoni) Filtering by page is a reflection of our belief that most users think primarily about conten... [23:31:05] (03PS2) 10Mooeypoo: Separate model's symbolic name and model's source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293451 [23:36:22] (03PS8) 10Mooeypoo: [wip] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [23:39:10] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Should welcome, emailuser and user-rights be associated with the user page or with no page? - https://phabricator.wikimedia.org/T137502#2370242 (10Quiddity) >But is it a flaw? That's to say, will users expect the page links to add up to a comprehensiv... [23:54:42] (03PS9) 10Mooeypoo: [wip] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [23:56:09] eh matt_flaschen if you have a minute, I could use API help. I rebased phillip on top of Roan's 'nottitles' commit ( https://gerrit.wikimedia.org/r/#/c/293142/4 ) -- and so, I see the 'nottitles' parameter in the /w/api.php documentation, but when I send a network request with nottitles:whatever it returns with a warning "Unrecognized parameter: 'nottitles'" [23:57:05] mooeypoo, sure, let's screen share. [23:57:13] sure