[08:53:51] 06Collaboration-Team-Interested, 10Notifications, 10MediaWiki-extensions-TranslationNotifications: Deliver notification using Echo where available - https://phabricator.wikimedia.org/T48310#2360211 (10Nikerabbit) [08:55:33] 06Collaboration-Team-Interested, 10Notifications, 10MediaWiki-extensions-TranslationNotifications: Deliver notification using Echo where available - https://phabricator.wikimedia.org/T48310#510985 (10Nikerabbit) It seems that now that cross wiki notifications are available, using them would allow us to remov... [10:41:31] 10Notifications, 06Performance-Team, 06TCB-Team, 07Performance: Investigation: Can DeferredUpdates call in Echo Hooks for EchoDiscussionParser::generateEventsForRevision be removed? - https://phabricator.wikimedia.org/T136928#2360401 (10Lea_WMDE) @Legoktm just as a clarification: We are not sure yet if thi... [10:59:37] 10Notifications, 06Performance-Team, 06TCB-Team, 07Performance: Investigation: Can DeferredUpdates call in Echo Hooks for EchoDiscussionParser::generateEventsForRevision be removed? - https://phabricator.wikimedia.org/T136928#2352541 (10Catrope) >>! In T136928#2360401, @Lea_WMDE wrote: > @Legoktm just as a... [11:13:05] 10Notifications, 10The-Wikipedia-Library: Quarry the number editors effect per month by 500 edits and 6 months notification - https://phabricator.wikimedia.org/T132088#2187886 (10Catrope) >>! In T132088#2358596, @Samwalton9 wrote: >>>! In T132088#2277554, @Sadads wrote: >> @Halfak suggested https://quarry.wmfl... [12:16:21] (03CR) 10Sbisson: [C: 032] backfillUnreadBundles.php: Use the correct database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292979 (owner: 10Catrope) [12:25:06] (03Merged) 10jenkins-bot: backfillUnreadBundles.php: Use the correct database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292979 (owner: 10Catrope) [12:46:39] (03PS2) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [12:50:09] (03CR) 10jenkins-bot: [V: 04-1] Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [12:59:45] (03PS3) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [13:23:27] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Add ability to filter notifications by title - https://phabricator.wikimedia.org/T137139#2360769 (10Catrope) Come to think of it I don't think we'll need an index on `event_page_id`. The query would get the notifications for the given user, join again... [13:23:36] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Add ability to filter notifications by title - https://phabricator.wikimedia.org/T137139#2360770 (10Catrope) a:03Catrope [13:27:10] 06Collaboration-Team-Interested, 10Notifications, 13Patch-For-Review, 07Schema-change: Add primary key to echo_notification table - https://phabricator.wikimedia.org/T136428#2360776 (10Catrope) SQL: https://gerrit.wikimedia.org/r/#/c/292966/1/db_patches/patch-notification-pk.sql [13:28:29] (03PS1) 10Sbisson: [WIP] Use usb-select to target rows to update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) [13:28:57] (03PS2) 10Sbisson: [WIP] Use sub-select to target rows to update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) [13:29:27] 06Collaboration-Team-Interested, 10Notifications, 13Patch-For-Review, 07Schema-change: Migrate event_page_namespace and event_page_title to event_page_id and remove them - https://phabricator.wikimedia.org/T136427#2360780 (10Catrope) Since the script has already been run in production, we can just drop the... [13:45:54] 10Notifications, 10The-Wikipedia-Library: Quarry the number editors effect per month by 500 edits and 6 months notification - https://phabricator.wikimedia.org/T132088#2360795 (10Sadads) @Catrope that would be awesome if you can give it a try. We are hoping to start work with Collaboration sometime early next... [13:52:50] (03CR) 10Catrope: [C: 04-1] [WIP] Use sub-select to target rows to update (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [13:57:20] (03CR) 10Catrope: [WIP] Use sub-select to target rows to update (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [13:58:19] (03PS3) 10Sbisson: [WIP] Use sub-select to target rows to update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) [14:01:34] (03PS4) 10Catrope: backfillReadBundles.php: Use sub-select to target rows to update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [14:02:28] (03CR) 10Catrope: [C: 032] backfillReadBundles.php: Use sub-select to target rows to update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [14:03:07] (03Abandoned) 10Catrope: Update only required rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292551 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [14:09:21] (03CR) 10jenkins-bot: [V: 04-1] backfillReadBundles.php: Use sub-select to target rows to update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [14:11:23] (03CR) 10Catrope: [C: 032] backfillReadBundles.php: Use sub-select to target rows to update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [14:19:00] (03Merged) 10jenkins-bot: backfillReadBundles.php: Use sub-select to target rows to update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293100 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [14:19:40] 06Collaboration-Team-Interested, 10Notifications, 06Mobile-Apps, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Product-Backlog: There's no Echo (Notifications) system for us to check notices on Wikipedia Mobile Apps (Android & iOS). - https://phabricator.wikimedia.org/T123155#2360917 (10Dbrant) [14:21:12] 10Thanks: "Thank"ing opens new page - https://phabricator.wikimedia.org/T137208#2360932 (10Ankit-Maity) [14:22:51] 10Notifications, 10DBA, 07Schema-change: Temporary index for Echo backfillReadBundles.php? - https://phabricator.wikimedia.org/T137100#2360947 (10Catrope) >>! In T137100#2357623, @jcrespo wrote: >> The current version of the script > > I will give it a look, then get back to here with suggestions if needed... [14:22:52] (03PS41) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [14:27:49] 10Notifications, 10The-Wikipedia-Library: Quarry the number editors effect per month by 500 edits and 6 months notification - https://phabricator.wikimedia.org/T132088#2360975 (10Catrope) >>! In T132088#2360795, @Sadads wrote: > @Catrope that would be awesome if you can give it a try. My attempts were https:/... [14:39:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Dynamic bundle: non-bundle_base notifications need a read timestamp - https://phabricator.wikimedia.org/T136368#2361011 (10SBisson) a:05SBisson>03Catrope Both patches have been merged. Next step... [16:45:43] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Email batch contained no useful information - https://phabricator.wikimedia.org/T137012#2355150 (10Etonkovidova) The message is a summary (the option "A daily summary of notifications" was selected in Preferences-Notificaitons. I will check the option and updat... [17:18:52] 06Collaboration-Team-Interested, 06Front-end-Standards-Group, 10MediaWiki-User-preferences, 07Easy, 13Patch-For-Review: Create a "Watching and notifications" tab in MediaWiki core - https://phabricator.wikimedia.org/T65577#2361575 (10Volker_E) [17:28:29] (03CR) 10Sbisson: [C: 04-1] "Using deprecated getDB and waitForSlave" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) (owner: 10Catrope) [17:37:15] RoanKattouw, what's the best way to document a viariadic method with 1 set parameter? [17:37:35] I have 'setFilter' method, it accepts a filter name + variadic parameters, depending on what filter you want [17:37:45] so @param {string} filter Filter name [17:38:00] and then.... @param {Mixed...} arguments Filter values [17:38:00] ? [17:56:30] 10Thanks: "Thank"ing opens new page - https://phabricator.wikimedia.org/T137208#2361716 (10Aklapper) Which URL does it open? Please provide steps to reproduce. Also see https://www.mediawiki.org/wiki/How_to_report_a_bug - thanks! [17:59:55] 10Thanks: "Thank"ing opens new page - https://phabricator.wikimedia.org/T137208#2361721 (10Ankit-Maity) Don't remember the URL. But it was Special:Thanks. I was on an userpage and thanked a certain user from the diff page, then a new page opened asking me for confirmation. To see if this was just a new thing, I... [18:02:34] mooeypoo: I think so... [18:02:50] I don't really know how to document variadic params either [18:03:01] I just find some docs Timo wrote years ago and cargo-cult those [18:49:38] (03PS1) 10Catrope: ApiEchoNotificatons: Add nottitles parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) [18:50:09] mooeypoo: ---^^ [18:50:29] * mooeypoo groans at the negative [18:50:44] RoanKattouw, so if one day we'll want everything except a title, we can use nottitles: !title [18:51:11] Good luck with that, because ! is a valid character in titles [18:51:23] RoanKattouw, EVEN BETTER [18:51:28] As you can see in the infamous https://en.wikipedia.org/w/api.php?action=query&list=allpages [18:51:33] nottitles:!woot! [18:51:55] (Someone once filed a bug about the output of that URL, and it ended up being resolved as NOTCENSORED essentially) [18:54:41] 10Thanks: "Thank"ing opens new page - https://phabricator.wikimedia.org/T137208#2360932 (10Etonkovidova) Usually Special:Thanks page appears when Javascript is disabled. > thanked a certain user from the diff page 'View history' for Flow pages display only changes or a revision of a post. Can you describe wha... [18:56:57] 10Thanks: "Thank"ing opens new page - https://phabricator.wikimedia.org/T137208#2361935 (10Ankit-Maity) * JS is not disabled. * Diff page means the difference page. [19:09:21] 10Thanks: "Thank"ing opens new page - https://phabricator.wikimedia.org/T137208#2361943 (10Etonkovidova) @Ankit-Maity - thx! Will move the ticket to our work board. [19:10:00] 06Collaboration-Team-Interested, 10Thanks: "Thank"ing opens new page - https://phabricator.wikimedia.org/T137208#2361956 (10Etonkovidova) [19:51:16] 06Collaboration-Team-Interested, 10Thanks: "Thank"ing opens new page - https://phabricator.wikimedia.org/T137208#2360932 (10Quiddity) Re: slow network, yeah, this is almost always due to "clicking before the page has fully loaded", which also happens frequently (for me and others) when adding pages to the watc... [20:04:14] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Vagrant: Split Flow role - https://phabricator.wikimedia.org/T133629#2362098 (10Mattflaschen-WMF) I'm going to do this now, since it's a quick fix and impacting people. [20:18:39] 03Collab-Team-2016-Apr-Jun-Q4, 10MediaWiki-extensions-GuidedTour: GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't) - https://phabricator.wikimedia.org/T132989#2362151 (10Mattflaschen-WMF) a:03Mattflaschen-WMF That's not the same te... [21:00:07] RoanKattouw, et al, what do we have for Scrum of Scrums? [21:00:44] https://gerrit.wikimedia.org/r/#/c/292483/ is merged, so I'm going to do the dry run and mention that. [21:17:00] matt_flaschen, not sure if that's relevant, but we're working on expanding our API to fetch notifications that are related to specific pages? [21:17:40] mooeypoo, yeah, we do both blocked/blocked by and updates, so I will list that as an update. Thanks. [21:18:33] matt_flaschen, I assume we already said about changing our schema for seen boolean? [21:19:17] mooeypoo, yep, (well, it was mentioned as all the schema changes together). [21:21:21] mooeypoo, also, could you take a look at my reply at https://gerrit.wikimedia.org/r/#/c/280366/ when you have a chance? [21:26:43] matt_flaschen: Oh also we decided not to do a temporary index creation after all [21:26:48] So we are not blocked on DBAs right now [21:27:08] Okay, good to know. [21:30:11] We have merged a maintenance script that we're going to start running tomorrow which backfills the read timestamps for bundled notifications [21:30:24] We originally thought that'd require a temp index but we're gonna try without [21:30:56] We do have some DB maintenance stuff (cleanup like removing fields, removing orphaned rows, etc) but my current plan is to batch that all together after we do the bundling migration [21:31:13] I haven't told anyone that yet, I'm planning to write that in Phab tomorrow som e time [21:35:00] (03PS8) 10Catrope: Add script to remove orphaned event rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) [21:40:46] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Special:Notifications does not contain wrapper linking to primary link - https://phabricator.wikimedia.org/T124481#1957434 (10Etonkovidova) Re-checked in betalabs (currently at 1.28.0-alpha (4d294bc)). According to [[ https://docs.google.com/... [21:44:33] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Special:Notifications does not contain wrapper linking to primary link - https://phabricator.wikimedia.org/T124481#2362398 (10Catrope) 05Open>03Resolved a:03Catrope [21:48:15] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Dynamic bundle: non-bundle_base notifications need a read timestamp - https://phabricator.wikimedia.org/T136368#2362419 (10Catrope) testwiki (14K notfiication rows) took <10s to update 2K rows. test2... [21:51:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Dynamic bundle: non-bundle_base notifications need a read timestamp - https://phabricator.wikimedia.org/T136368#2362442 (10Catrope) >>! In T136368#2362419, @Catrope wrote: > The bad news is that the... [22:22:46] etonkovidova, legoktm, mlitn, mooeypoo, anyone else using Flow vagrant role, after https://gerrit.wikimedia.org/r/293229 is merged, you should enable wikimediaflow. 'flow' is the minimal Flow install for ocassional contributors. [22:23:11] matt_flaschen: understood, thx! [22:23:54] However, we'll want the full one, and that's the one that has backwards compatibilty. (I made 'flow' the basic one, so people who just install quickly without reading docs will get the simpler one). [22:30:09] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Not all notifications displayed; oldest notification fluctuates - https://phabricator.wikimedia.org/T129638#2111439 (10Etonkovidova) With Special:Notifications page re-design (incl pagination) - it's difficult to investigate the issue. I checked d... [22:34:23] RoanKattouw, mooeypoo, HHVM mysteriously reverted my html_entity_decode commit with no explanation of why. [22:34:30] Bonus: I am listed as the author of the revert. [22:36:39] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Special:Notifications not showing "More..." at bottom at some wikis, erratically - https://phabricator.wikimedia.org/T123338#1926579 (10Etonkovidova) @Quiddity when you have a chance - can you re-check the pagination on Special:Notifications for wi... [22:37:42] wtf [22:39:41] https://reviews.facebook.net/rHHVM5386bcca4d3b [22:43:26] Communication problem. It was causing a couple of Facebook's private tests to fail. I knew that since they told me earlier (and actually mentioned it last time they pinged me), but this was lost in communication. So when they merged it I assumed they had fixed those internal tests, but actually no. [22:43:55] Whoops, I mean I mentioned it when I pinged them. [22:57:50] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Special:Notifications FOUC due to More Info | Preferences changing into icons in Vector/MonoBook skins - https://phabricator.wikimedia.org/T118342#1797813 (10Etonkovidova) Checked in betalabs for Monobook&Vector skins - looks smooth, no FOUC. "More... [23:44:44] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Check Special:Notifications logging for MobileFrontend - https://phabricator.wikimedia.org/T112789#1646088 (10Etonkovidova) Few issues (betalabs was checked) are listeed below - tested in iOS. 1) When logged in, click on the notification badge -...