[07:52:38] tomaluca95: Sorry, I was traveling this weekend so I didn't see your messages until now. Looking at your links now [07:57:16] tomaluca95: It looks like, somehow, db_patches/patch-remove_unique_ref_indices.sql was not run. If you run that, that will hopefully fix your schema [07:57:27] I don't understand why update.php doesn't run that one first though [07:57:50] Oh, I see, it thinks it doesn't need to [08:04:01] tomaluca95: Hmm strike that, patch-remove_unique_ref_indices.sql probably won't work. I don't know how your DB got into this broken state (it happened to our beta site too though), but you should be able to fix it with: DROP INDEX flow_ext_ref_idx_v2 ON flow_ext_ref; DROP INDEX flow_ext_ref_revision_v2 ON flow_ext_ref; ALTER TABLE flow_ext_ref CHANGE [08:04:01] ref_target ref_target BLOB NOT NULL; CREATE INDEX flow_ext_ref_idx_v2 ON flow_ext_ref (ref_src_wiki, ref_src_namespace, ref_src_title, ref_type, ref_target(255), ref_src_object_type, ref_src_object_id); CREATE INDEX flow_ext_ref_revision_v2 ON flow_ext_ref (ref_src_wiki, ref_src_namespace, ref_src_title, ref_src_object_type, ref_src_object_id, ref_type, [08:04:01] ref_target(255)); [09:23:38] tomaluca95: Re your issue with Echo, it looks like you've updated Echo without updating MediaWiki [11:02:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Email batch contained no useful information - https://phabricator.wikimedia.org/T137012#2357078 (10Catrope) [11:28:54] (03CR) 10Matthias Mullie: [C: 032] Dry run: Read content properly when doing consistency check [extensions/Flow] - 10https://gerrit.wikimedia.org/r/292483 (https://phabricator.wikimedia.org/T136887) (owner: 10Mattflaschen) [11:36:39] (03Merged) 10jenkins-bot: Dry run: Read content properly when doing consistency check [extensions/Flow] - 10https://gerrit.wikimedia.org/r/292483 (https://phabricator.wikimedia.org/T136887) (owner: 10Mattflaschen) [11:57:07] (03CR) 10Catrope: [C: 04-1] Update only required rows (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292551 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [12:03:29] (03CR) 10Catrope: Update only required rows (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292551 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [12:08:17] 10Notifications, 10DBA, 07Blocked-on-schema-change: Temporary index for Echo backfillReadBundles.php? - https://phabricator.wikimedia.org/T137100#2357217 (10Catrope) [12:09:40] (03CR) 10Catrope: Update only required rows (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292551 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [12:11:18] (03PS1) 10Catrope: Revert "Use the standard VE toolbar in Flow as much as possible" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/292912 [12:11:25] (03CR) 10Catrope: [C: 032] Revert "Use the standard VE toolbar in Flow as much as possible" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/292912 (owner: 10Catrope) [12:12:00] (03PS2) 10Catrope: Revert "Use the standard VE toolbar in Flow as much as possible" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/292912 (https://phabricator.wikimedia.org/T93243) [12:12:13] (03CR) 10Catrope: [C: 032] Revert "Use the standard VE toolbar in Flow as much as possible" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/292912 (https://phabricator.wikimedia.org/T93243) (owner: 10Catrope) [12:19:41] (03Merged) 10jenkins-bot: Revert "Use the standard VE toolbar in Flow as much as possible" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/292912 (https://phabricator.wikimedia.org/T93243) (owner: 10Catrope) [12:57:53] (03CR) 10Catrope: [C: 032] Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) (owner: 10Mooeypoo) [12:58:16] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: In cross-wiki notification bundle, "mark as read" secondary link doesn't do anything - https://phabricator.wikimedia.org/T136878#2350711 (10Catrope) [13:07:50] (03Merged) 10jenkins-bot: Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) (owner: 10Mooeypoo) [13:09:33] 10Notifications, 10DBA, 07Blocked-on-schema-change: Temporary index for Echo backfillReadBundles.php? - https://phabricator.wikimedia.org/T137100#2357379 (10jcrespo) > Is adding a temporary index for this kind of thing recommended / a thing we do? Is something we can do indeed, but please combine it with th... [13:11:07] 10Notifications, 10DBA, 07Schema-change: Temporary index for Echo backfillReadBundles.php? - https://phabricator.wikimedia.org/T137100#2357382 (10jcrespo) (this is not yet a proper DBA request -it is in planning phase-, please create a proposal of several actions to do and re-add the tag when ready) [15:14:46] 10Notifications, 10DBA, 07Schema-change: Temporary index for Echo backfillReadBundles.php? - https://phabricator.wikimedia.org/T137100#2357613 (10Catrope) >>! In T137100#2357379, @jcrespo wrote: >> Is adding a temporary index for this kind of thing recommended / a thing we do? > > So, please try to minimize... [15:17:16] 10Notifications, 10DBA, 07Schema-change: Temporary index for Echo backfillReadBundles.php? - https://phabricator.wikimedia.org/T137100#2357623 (10jcrespo) > I'll line up all the things we talked about in the previous task, but unfortunately we can't fix the over-indexing until after this migration is complet... [15:45:49] (03CR) 10Hashar: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) (owner: 10Mooeypoo) [16:05:23] 10Notifications: Cannot expand external messages after returning from a visited one - https://phabricator.wikimedia.org/T137118#2357812 (10petr.matas) [16:27:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Cannot expand external messages after returning from a visited one - https://phabricator.wikimedia.org/T137118#2357926 (10Catrope) [16:30:39] I have a "1" in the messages notification badge but when I click on it, it says there is no notification. Known bug? [16:31:01] It's there even after reloading the page. [16:31:27] That's weird [16:31:38] Glaisher: On which wiki? What's your username? [16:32:03] Glaisher on deployment beta [16:36:10] Hmm looks like a stale cache [16:36:13] Not sure how that could happen [16:36:33] It should have fixed itself now because I requested the messages count with caching off, which will have updated the cache [16:37:16] Yep, it's 0 now. [16:44:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: In cross-wiki notification bundle, "mark as read" secondary link doesn't do anything - https://phabricator.wikimedia.org/T136878#2358005 (10Etonkovidova) Checked the fix in betalabs - 'Mark as read' works as intended: other wikis Alerts/Mess... [17:10:09] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: In cross-wiki notification bundle, "mark as read" secondary link doesn't do anything - https://phabricator.wikimedia.org/T136878#2358115 (10jmatazzoni) 05Open>03Resolved [17:34:28] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Status filter should not become disabled between status change in the Notification Page - https://phabricator.wikimedia.org/T136895#2358173 (10Catrope) [17:40:12] 06Collaboration-Team-Interested, 10Flow: Improve warning to users who review deleted Flow pages via Special:Undelete - https://phabricator.wikimedia.org/T136983#2358192 (10Catrope) [17:57:42] (03PS1) 10Catrope: Add a primary key to the echo_notification table [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292966 (https://phabricator.wikimedia.org/T136428) [18:28:04] (03PS1) 10Catrope: Add script to remove orphaned event rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) [18:34:13] RoanKattouw, jmatazzoni___ are we doing the pre-deploy meeting? [18:34:22] Oh, shit [18:34:25] Yeah, we probably still should [18:34:27] * RoanKattouw makes the list [18:55:46] 03Collab-Team-2016-Apr-Jun-Q4, 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2358579 (10jayvdb) >>! In T51541#2340580, @Danny_B wrote: > I didn't write "an administrator", but "some user".... [18:55:58] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Add ability to filter notifications by title - https://phabricator.wikimedia.org/T137139#2358580 (10Catrope) [18:59:32] 10Notifications, 10The-Wikipedia-Library: Quarry the number editors effect per month by 500 edits and 6 months notification - https://phabricator.wikimedia.org/T132088#2187886 (10Samwalton9) >>! In T132088#2277554, @Sadads wrote: > @Halfak suggested https://quarry.wmflabs.org/query/9616 , and its running right... [18:59:39] (03PS2) 10Catrope: Add script to remove orphaned event rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) [19:00:38] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#1899800 (10Etonkovidova) I reviewed test scenarios in {T122261} and previously fixed {T104591}. It seems that we need cle... [19:02:07] (03PS3) 10Catrope: Add script to remove orphaned event rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) [19:05:09] (03PS4) 10Catrope: Add script to remove orphaned event rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) [19:11:40] (03PS1) 10Catrope: backfillUnreadBundles.php: Use the correct database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292979 [19:12:05] (03PS5) 10Catrope: Add script to remove orphaned event rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) [19:23:32] RoanKattouw: thanks, i'm going to try to make some test about. We are running the last version of MW REL1_27 [19:25:39] tomaluca95: And are you also running the REL1_27 version of Echo? Or are you running Echo from git? [19:25:58] (from master I mean) [19:26:27] (03PS1) 10Catrope: Add maintenance script to backfill event_page_id [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292983 (https://phabricator.wikimedia.org/T136427) [19:26:37] i'm using the last snapshot from https://extdist.wmflabs.org/dist/extensions/ (master) [19:27:02] and the mediawiki last snapshot from https://tools.wmflabs.org/snapshots/#!/mediawiki-core/REL1_27 [19:27:11] (03PS6) 10Catrope: Add script to remove orphaned event rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) [19:28:13] i'm going to try the master snspshot of mw [19:28:51] Right [19:29:18] Using the REL1_27 snapshot of Echo should probably work too. But Echo code in master often depends on master of MW [19:29:36] So as long as you use the same version of both, you should be fine [19:31:42] (03CR) 10jenkins-bot: [V: 04-1] Add maintenance script to backfill event_page_id [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292983 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [19:36:16] i have to check, but why there is not the snapshot of the extension for REL1_27 on https://extdist.wmflabs.org/dist/extensions/ ? [19:36:40] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Have a way to mark all notifications as read at once - https://phabricator.wikimedia.org/T136614#2358714 (10Quiddity) [19:37:37] (03Abandoned) 10Catrope: Add maintenance script to backfill event_page_id [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292983 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [19:39:59] tomaluca95: You can use https://www.mediawiki.org/wiki/Special:ExtensionDistributor/Echo I see the master there. [19:40:26] yes, master [19:40:33] but not REL1_27 [19:41:02] Ah. [19:41:25] i want use REL1_27 [19:41:38] but i can't find the extension snapshot [19:54:16] with the sql patch the update.php works for flow [19:54:32] now i have to make some test to upgrade the db with our automathed procedure [19:58:02] 10Notifications, 06Performance-Team, 06TCB-Team, 07Performance: Investigation: Can DeferredUpdates call in Echo Hooks for EchoDiscussionParser::generateEventsForRevision be removed? - https://phabricator.wikimedia.org/T136928#2358749 (10aaron) The wfDiff() calls in there were way too slow, so I don't think... [20:20:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#2358819 (10Etonkovidova) To summarize my previous comment - the scenarios I tested are the following from {T122261} >F... [20:40:34] tomaluca95: 1.27 hasn't been officially released yet, it's in RC (release candidate) status right now [20:43:25] (See https://lists.wikimedia.org/pipermail/wikitech-l/2016-June/085837.html for the announcement) [20:45:54] TFW you find out that most of the work you just did has already been done in 2013 and that code is just sitting around unused [20:59:37] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): New Error Message for "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2359144 (10Eton... [21:03:38] RoanKattouw: i have this hack https://github.com/WikiToLearn/WikiToLearnHome/commit/fb4635ecf476792a6dcd841e7b781a2e5cce7e44 to workouround the problem [21:04:00] now i have only to think how to update the production schema without breaking everything [21:04:28] thanks! [21:04:33] Now echo works well [21:05:17] Awesome [21:07:24] 06Collaboration-Team-Interested, 10Notifications, 13Patch-For-Review, 07Schema-change: Migrate event_page_namespace and event_page_title to event_page_id and remove them - https://phabricator.wikimedia.org/T136427#2359157 (10Catrope) Turns out we already have a migration script that was written as part of... [21:08:29] (03PS1) 10Catrope: Clean up and fix updateEchoSchemaForSuppression.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293029 (https://phabricator.wikimedia.org/T136427) [21:19:31] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2359168 (10jmatazzoni) [21:21:42] 10Notifications, 06Performance-Team, 06TCB-Team, 07Performance: Investigation: Can DeferredUpdates call in Echo Hooks for EchoDiscussionParser::generateEventsForRevision be removed? - https://phabricator.wikimedia.org/T136928#2352541 (10Legoktm) Also, the plan was to move this into the job queue: {T99573}. [21:25:27] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Blank or empty items in the Special:Notifications at ee-flow - https://phabricator.wikimedia.org/T78698#2359235 (10Quiddity) 05Open>03Invalid very old bug, no longer reproducible [21:29:11] 06Collaboration-Team-Interested, 10Flow, 07Tracking: No-JavaScript - Flow glitches (tracking) - https://phabricator.wikimedia.org/T60019#2359240 (10jmatazzoni) [21:29:13] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: [[Special:Notifications]] looks very different with JavaScript disabled - https://phabricator.wikimedia.org/T59720#2359238 (10jmatazzoni) 05Open>03Invalid The no-js page has been rewritten, so differences described here refer to the old page (wh... [21:34:48] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Easy: Add a "Mark all as read" button at Special:Notifications for mobile and no-JS users - https://phabricator.wikimedia.org/T96061#2359244 (10Quiddity) [21:39:54] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Special:Notifications page has wrong sorting order after messages are 'Marked as unread' - https://phabricator.wikimedia.org/T136885#2359257 (10Quiddity) [21:40:58] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Special:Notifications not showing "More..." at bottom at some wikis, erratically - https://phabricator.wikimedia.org/T123338#2359262 (10Quiddity) [21:41:25] 06Collaboration-Team-Interested, 10Flow: [betalabs] 'Uncaught TypeError: Cannot read property 'model' of undefined' for non-persistent Comments in Flow posts - https://phabricator.wikimedia.org/T136780#2359263 (10jmatazzoni) [21:42:12] 06Collaboration-Team-Interested, 10Flow: [betalabs] Creating empty replies should be prevented - https://phabricator.wikimedia.org/T136777#2359265 (10jmatazzoni) [21:43:05] 06Collaboration-Team-Interested, 10Flow: [betalabs] On Flow pages VE hangs when attempting to 'Save changes' after clearing links via Link inspector - https://phabricator.wikimedia.org/T136654#2359280 (10jmatazzoni) [21:45:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Vagrant: Split Flow role - https://phabricator.wikimedia.org/T133629#2237725 (10jmatazzoni) @Mattflaschen-WMF, do we have to fix this now? Or can it wait until next quarter? [22:00:11] (03PS2) 10Catrope: Clean up and fix updateEchoSchemaForSuppression.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293029 (https://phabricator.wikimedia.org/T136427) [22:00:14] (03PS1) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [22:07:16] (03CR) 10jenkins-bot: [V: 04-1] Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [22:07:40] (03PS7) 10Catrope: Add script to remove orphaned event rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292974 (https://phabricator.wikimedia.org/T136425) [22:32:00] 06Collaboration-Team-Interested, 10Notifications, 06Mobile-Apps, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Product-Backlog: There's no Echo (Notifications) system for us to check notices on Wikipedia Mobile Apps (Android & iOS). - https://phabricator.wikimedia.org/T123155#2359423 (10MBinder_WMF) [22:36:23] 06Collaboration-Team-Interested, 10Notifications, 13Patch-For-Review, 07Schema-change: Migrate event_page_namespace and event_page_title to event_page_id and remove them - https://phabricator.wikimedia.org/T136427#2359431 (10Catrope) >>! In T136427#2359157, @Catrope wrote: > Turns out we already have a mig... [23:51:53] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Cannot expand external messages after returning from a visited one - https://phabricator.wikimedia.org/T137118#2357812 (10Etonkovidova) Checked the exact steps in betalabas and srwiki (production) - in Chrome. **[betalabs]** #5 step behaves differently - after...