[00:31:50] I'm going to take a break. I'll probably be on a little bit later. [05:02:17] (03PS1) 10Aaron Schulz: Set doesWrites() for SpecialThanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/292523 [05:24:06] (03CR) 10Legoktm: [C: 032] Set doesWrites() for SpecialThanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/292523 (owner: 10Aaron Schulz) [05:31:29] (03Merged) 10jenkins-bot: Set doesWrites() for SpecialThanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/292523 (owner: 10Aaron Schulz) [07:29:13] with the new work done for Special:Notifications, how difficult would it be to embed notifications on the top of the watchlist? [07:53:44] legoktm: mooeypoo will be able to give you a more precise answer, but the list of notifications should be pretty easily embeddable [08:00:07] 06Collaboration-Team-Interested, 10Flow, 06Community-Liaisons, 13Patch-For-Review, and 2 others: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2352307 (10Qgil) [08:41:28] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: [betalabs] 'Uncaught TypeError: Cannot read property 'model' of undefined' for non-persistent Comments in Flow posts - https://phabricator.wikimedia.org/T136780#2352376 (10Catrope) [08:42:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: [betalabs] On Flow pages VE hangs when attempting to 'Save changes' after clearing links via Link inspector - https://phabricator.wikimedia.org/T136654#2352381 (10Catrope) [08:45:13] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Dynamic bundle: non-bundle_base notifications need a read timestamp - https://phabricator.wikimedia.org/T136368#2352382 (10Catrope) As discussed on IRC, the maintenance script needs some changes to w... [10:09:49] 10Notifications, 06Performance-Team, 06TCB-Team, 07Performance: Investigation: Can DeferredUpdates call in Echo Hooks for EchoDiscussionParser::generateEventsForRevision be removed? - https://phabricator.wikimedia.org/T136928#2352541 (10Addshore) [10:09:57] 10Notifications, 06Performance-Team, 06TCB-Team, 07Performance: Investigation: Can DeferredUpdates call in Echo Hooks for EchoDiscussionParser::generateEventsForRevision be removed? - https://phabricator.wikimedia.org/T136928#2352556 (10Addshore) p:05Triage>03Normal [11:16:47] 10Notifications, 06Performance-Team, 06TCB-Team, 07Performance: Investigation: Can DeferredUpdates call in Echo Hooks for EchoDiscussionParser::generateEventsForRevision be removed? - https://phabricator.wikimedia.org/T136928#2352541 (10Addshore) [11:16:50] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review, and 2 others: [GTWL] Investigate the technical requirements for mention failure notifications - https://phabricator.wikimedia.org/T135719#2352711 (10Addshore) [13:18:41] (03PS1) 10Sbisson: Update only required rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292551 (https://phabricator.wikimedia.org/T136368) [14:37:56] Hi, i have some problem with flow [14:38:07] Running Flow-master-4da3c39 update i get a error about a mysql key [14:38:08] Query: ALTER TABLE `flow_ext_ref` CHANGE ref_target ref_target BLOB NOT NULL [14:38:14] Error: 1170 BLOB/TEXT column 'ref_target' used in key specification without a key length (mysql) [14:38:20] with Flow-master-0409bae no problem at all [14:38:31] any idea about? [15:10:06] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2353153 (10jayvdb) [15:15:05] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2353194 (10jayvdb) "Doubts asked on #pywikibot" - could you please mention the topics you discussed on... [15:16:35] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2353200 (10jayvdb) [15:27:47] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2353229 (10darthbhyrava) >>! In T133667#2353194, @jayvdb wrote: > "Doubts asked on #pywikibot" - could... [15:41:48] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Community bonding evaluation for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133666#2353301 (10jayvdb) >>! In T133666#2318419, @darthbhyrava wrote: >>>! In T133666#2318204,... [15:42:51] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Community bonding evaluation for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133666#2353305 (10jayvdb) [15:43:13] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2353308 (10jayvdb) [15:43:15] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Community bonding evaluation for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133666#2238880 (10jayvdb) 05Open>03Resolved [16:08:09] 06Collaboration-Team-Interested, 10UI-Standardization, 07Design: Use consistent help icon in VE, Echo, and elsewhere - https://phabricator.wikimedia.org/T90414#2353342 (10matej_suchanek) [16:08:20] 06Collaboration-Team-Interested, 10Flow, 10xTools-on-Labs: Add Flow contributions to Xtools - https://phabricator.wikimedia.org/T136950#2353344 (10Matthewrbowker) [16:09:10] 06Collaboration-Team-Interested, 10UI-Standardization, 07Design: Use consistent help icon in VE, Echo, and elsewhere - https://phabricator.wikimedia.org/T90414#1058267 (10matej_suchanek) [16:56:25] tomaluca95: Strange. Could you pastebin the output of SHOW CREATE TABLE flow_ext_ref; ? [17:20:24] 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Mark a Topic as resolved shouldn't send a notifications to people who follow the Board but not the Topic itself - https://phabricator.wikimedia.org/T136060#2353668 (10Quiddity) [17:30:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Dynamic bundle: non-bundle_base notifications need a read timestamp - https://phabricator.wikimedia.org/T136368#2353687 (10SBisson) a:03SBisson [17:44:45] (03CR) 10Mattflaschen: [WIP] Pretty topic urls (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/290365 (https://phabricator.wikimedia.org/T59154) (owner: 10Matthias Mullie) [18:07:21] 06Collaboration-Team-Interested, 10Notifications: In cross-wiki notification bundle, "mark as read" secondary link doesn't do anything - https://phabricator.wikimedia.org/T136878#2350711 (10Etonkovidova) The same in betalabs - oo-ui-iconElement-icon oo-ui-icon-ellipsis button does not work. [18:07:36] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 03Collab-Archive-2015-2016, 07User-notice: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2353821 (10jmatazzoni) [18:07:38] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Mark groups of notifications as read - https://phabricator.wikimedia.org/T132738#2353819 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [18:08:42] mooeypoo: https://phabricator.wikimedia.org/T136878 [18:22:30] (03PS1) 10Mooeypoo: [wip] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 [18:25:37] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Filter by read status on the Notification Page - https://phabricator.wikimedia.org/T129364#2353887 (10jmatazzoni) > Please let me know if #1 and #2 require additional tickets to be filed. Thanks @Etonkovidova. The answers are: - 1) that's not ea... [18:25:55] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Filter by read status on the Notification Page - https://phabricator.wikimedia.org/T129364#2353889 (10jmatazzoni) a:03Mooeypoo [18:33:50] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2353899 (10jmatazzoni) [18:34:56] 10Notifications, 06Performance-Team, 06TCB-Team, 07Performance: Investigation: Can DeferredUpdates call in Echo Hooks for EchoDiscussionParser::generateEventsForRevision be removed? - https://phabricator.wikimedia.org/T136928#2353903 (10Krinkle) [18:35:45] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Epic, 07Tracking: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2353908 (10jmatazzoni) [18:35:47] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 03Collab-Archive-2015-2016, 07User-notice: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2353904 (10jmatazzoni) 05Open>03Resolved Elena writes: > Turn the cog icon into a menu to pr... [18:38:23] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07Regression, and 2 others: hewiki.echo_notification does not exist - https://phabricator.wikimedia.org/T136759#2353911 (10jmatazzoni) 05Open>03Resolved [18:47:55] (03PS1) 10Mooeypoo: Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) [18:48:55] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications, 13Patch-For-Review: In cross-wiki notification bundle, "mark as read" secondary link doesn't do anything - https://phabricator.wikimedia.org/T136878#2353942 (10Mooeypoo) a:03Mooeypoo [18:49:44] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications: Status filter should not become disabled between status change in the Notification Page - https://phabricator.wikimedia.org/T136895#2353945 (10Pginer-WMF) [18:49:59] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications: Mark as seen notifications from the Notifications Page - https://phabricator.wikimedia.org/T136576#2353946 (10Pginer-WMF) [18:57:07] (03CR) 10Catrope: [C: 04-1] Listen to 'mark as read' secondary link in xwiki bundles (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) (owner: 10Mooeypoo) [18:58:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2043253 (10Etonkovidova) Checked in betalabs - below is the description of the current behavior (the te... [19:07:52] stephanebisson: Ugh, now I'm reading BatchRowIterator and my fingers are itching [19:08:32] What is it that you want to rewrite? [19:09:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): flow_post.partial.handlebars appears after posting a message - https://phabricator.wikimedia.org/T103702#1396907 (10Etonkovidova) Checked the fix in betalabs as part of general regression testing. [19:10:36] buildGreaterThanCondition() for example; I'm pretty sure we have other code that does the same thing more elegantly [19:10:55] And the implode() with ASC to build $this->orderBy, *shudder* [19:11:03] ASC is the default so it's not even needed [19:11:06] (03PS2) 10Mooeypoo: Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) [19:11:25] (03PS3) 10Mooeypoo: Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) [19:13:22] (03PS4) 10Mooeypoo: Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) [19:21:55] (03CR) 10jenkins-bot: [V: 04-1] Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) (owner: 10Mooeypoo) [19:24:58] (03PS5) 10Mooeypoo: Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) [19:29:31] (03CR) 10jenkins-bot: [V: 04-1] Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) (owner: 10Mooeypoo) [19:37:23] (03PS6) 10Mooeypoo: Listen to 'mark as read' secondary link in xwiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292602 (https://phabricator.wikimedia.org/T136878) [19:37:29] * mooeypoo stares at jenkins [20:27:11] 06Collaboration-Team-Interested: Improve warning to users who review deleted Flow pages via Special:Undelete - https://phabricator.wikimedia.org/T136983#2354322 (10Etonkovidova) [20:28:26] 06Collaboration-Team-Interested, 10Notifications, 07Design, 07Tracking: Design adjustments for the Notifications Page - https://phabricator.wikimedia.org/T136567#2354338 (10jmatazzoni) [20:28:30] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07Design, 13Patch-For-Review: Hide pagination controls from the Notification Page when there is only one page - https://phabricator.wikimedia.org/T136574#2354336 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [20:33:09] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): flow_post.partial.handlebars appears after posting a message - https://phabricator.wikimedia.org/T103702#2354358 (10jmatazzoni) 05Open>03Resolved [20:52:32] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Vagrant: Split Flow role - https://phabricator.wikimedia.org/T133629#2354394 (10Mattflaschen-WMF) I'll do this this weekend, since it's impacting people. E.g. {T136969} [21:46:22] 06Collaboration-Team-Interested, 10Flow, 06Community-Liaisons, 13Patch-For-Review, and 2 others: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2354640 (10Esanders) Special character is a separate tool because it is a toggle button for the panel, mostly because we couldn't find a place for... [22:24:39] 03Collab-Team-2016-Apr-Jun-Q4, 10MediaWiki-extensions-GuidedTour: GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't) - https://phabricator.wikimedia.org/T132989#2354761 (10Krinkle) VisualEditor uses MediaWiki core's `edit` and `create`... [22:25:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Mark as seen notifications from the Notifications Page - https://phabricator.wikimedia.org/T136576#2354762 (10jmatazzoni) [22:32:24] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2354769 (10jmatazzoni) Elena writes: > Viewing Special:Notifications does not mark alerts/messages autom... [22:33:23] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Turn the cog icon into a menu - https://phabricator.wikimedia.org/T115528#2354774 (10jmatazzoni) [22:33:25] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2354773 (10jmatazzoni) [22:35:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Mark as seen notifications from the Notifications Page - https://phabricator.wikimedia.org/T136576#2354775 (10jmatazzoni) It's likely this task will also fix T127419. @Etonkovidova please check that when this is resolved. [22:41:22] 06Collaboration-Team-Interested, 10MediaWiki-extensions-LiquidThreads, 07Wikimedia-log-errors: Notice: Undefined index: title in /srv/mediawiki/php-1.28.0-wmf.4/extensions/LiquidThreads/classes/Hooks.php on line 949 - https://phabricator.wikimedia.org/T136837#2354780 (10Quiddity) [22:42:35] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Mark as seen notifications from the Notifications Page - https://phabricator.wikimedia.org/T136576#2354783 (10Pginer-WMF) [22:42:37] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2354782 (10Pginer-WMF) [23:18:12] Heading out, have a great weekend. [23:46:16] (03PS2) 10Mooeypoo: [wip] Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600