[00:18:30] 06Collaboration-Team-Interested, 10Flow, 07Browser-Support-Apple-Safari: [betalabs] Safari displays a blue line when editors switched - https://phabricator.wikimedia.org/T116689#2347764 (10Danny_B) [01:01:36] 06Collaboration-Team-Interested, 10Flow, 07Browser-Support-Google-Chrome: Cannot scroll up to top of page when replying in Chrome and when window width >1150px - https://phabricator.wikimedia.org/T114991#2347856 (10Danny_B) [01:22:10] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2347891 (10Catrope) @Pginer-WMF , @Mooeypoo and myself had an IRL conversation about this and clarified a few things. Pau wan... [13:47:06] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2349141 (10Trizek-WMF) How it will look: {F4103592} [14:16:07] (03PS1) 10Sbisson: Mark bundled notifications as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292359 (https://phabricator.wikimedia.org/T136368) [14:17:58] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review, and 3 others: [GTWL] Investigate the technical requirements for mention failure notifications - https://phabricator.wikimedia.org/T135719#2349191 (10Tobi_WMDE_SW) [14:45:43] (03PS1) 10Sbisson: Maintenance: Backfill read timestamp on bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292365 (https://phabricator.wikimedia.org/T136368) [14:46:41] (03PS2) 10Sbisson: Maintenance: Backfill read timestamp on bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292365 (https://phabricator.wikimedia.org/T136368) [14:54:08] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Dynamic bundle: non-bundle_base notifications need a read timestamp - https://phabricator.wikimedia.org/T136368#2349343 (10SBisson) > 1. Change the current code to set the read timestamp on all elements of a bundle when marking as read (so w... [15:52:20] 06Collaboration-Team-Interested, 10Flow, 07Design: Wikitext editing toolbar for Flow - https://phabricator.wikimedia.org/T78346#2349505 (10Quiddity) [15:53:25] 06Collaboration-Team-Interested, 10Flow, 07Design: Wikitext editing toolbar for Flow - https://phabricator.wikimedia.org/T78346#1005788 (10Quiddity) I'm retitling this task, due to the recent work on the VE toolbar in {T93243} [16:54:56] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#1132950 (10Pginer-WMF) >>! In T93243#2349141, @Trizek-WMF wrote: > How it will look: > {F4103592} I'd propose to try to make... [16:59:41] (03PS40) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [17:14:11] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Filter by read status on the Notification Page - https://phabricator.wikimedia.org/T129364#2349808 (10Catrope) Done in {e5e19dd0f1fd6a07b52431c771a3da2f521b3f78} [17:19:58] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2349869 (10Catrope) >>! In T93243#2349681, @Pginer-WMF wrote: > I'd propose to try to make the toolbar a bit more compact in... [17:23:26] 06Collaboration-Team-Interested, 10Flow, 10Notifications, 07Tracking: Improve organization and control for Flow notifications (tracking + ideas) - https://phabricator.wikimedia.org/T100528#2349888 (10Mattflaschen-WMF) [17:23:28] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Flow: Flow should allow hiding read messages from [[Special:Notifications]] - https://phabricator.wikimedia.org/T94689#2349886 (10Mattflaschen-WMF) 05Open>03Resolved [17:27:57] 06Collaboration-Team-Interested, 10Flow, 10Notifications, 07Tracking: Improve organization and control for Flow notifications (tracking + ideas) - https://phabricator.wikimedia.org/T100528#2349915 (10Mattflaschen-WMF) [17:27:59] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Visiting Special:Notifications should not mark notifications as read - https://phabricator.wikimedia.org/T97057#2349912 (10Mattflaschen-WMF) 05Open>03Resolved a:03Mooeypoo [17:32:10] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Flow: Flow should allow hiding read messages from [[Special:Notifications]] - https://phabricator.wikimedia.org/T94689#2349940 (10Kghbln) Cool. Thanks a lot! [17:39:45] (03CR) 10Catrope: [C: 04-1] "One minor comment inline, looks good to merge otherwise" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292365 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [17:40:10] (03PS2) 10Catrope: Mark bundled notifications as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292359 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [17:42:15] (03PS3) 10Sbisson: Maintenance: Backfill read timestamp on bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292365 (https://phabricator.wikimedia.org/T136368) [17:42:52] (03CR) 10Sbisson: Maintenance: Backfill read timestamp on bundled notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292365 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [17:44:03] (03CR) 10Catrope: [C: 04-1] "This looks fine (one minor nitpick inline), but I wonder why you chose to do this in the frontend rather than the backend. It seems simple" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292359 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [17:45:40] (03CR) 10Catrope: [C: 032] Maintenance: Backfill read timestamp on bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292365 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [17:46:00] (03CR) 10Sbisson: "This is much closer to what it will be with dynamic/expandable bundles." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292359 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [17:47:16] (03CR) 10Catrope: "Right, good point" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292359 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [17:48:41] (03PS3) 10Sbisson: Mark bundled notifications as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292359 (https://phabricator.wikimedia.org/T136368) [17:49:31] RoanKattouw: any intuition about how long the maintenance script might take to run? [17:49:54] stephanebisson: Lemme count how many affected rows there are [17:50:42] RoanKattouw: how are you gonna do that? [17:50:50] Unscientifically at first [17:51:04] > select count(*) from echo_notification where notification_bundle_base=0 and notification_read_timestamp is null; [17:51:08] 2197818 [17:51:11] (enwiki) [17:51:24] I know not all of those are affected because their base may also be unread [17:51:25] ok, that includes base=0 for unread notifications [17:51:30] but close enough [17:52:16] > select count(distinct notification_bundle_display_hash) from echo_notification where notification_bundle_base=1 and notification_read_timestamp is not null; [17:52:24] 3618250 [17:52:32] I guess most notifs aren't bundled [17:54:01] so the script is going to issue a bunch of no-op updates [17:54:20] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Flow should allow hiding read messages from [[Special:Notifications]] - https://phabricator.wikimedia.org/T94689#2350103 (10Catrope) [17:54:30] it could be optimized to query the bundle base that actually have bundled notifs [17:54:39] (03Merged) 10jenkins-bot: Maintenance: Backfill read timestamp on bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292365 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [17:54:44] Oh, I see, it's gonna issue UPDATE queries that affect 0rows [17:54:59] * RoanKattouw is currently running select count(*) from echo_notification where notification_bundle_base=0 and notification_read_timestamp is null and notification_bundle_display_hash in (select notification_bundle_display_hash from echo_notification where notification_bundle_base=1 and notification_read_timestamp is not null); [17:56:39] 1439532 [17:56:47] That only took 2 minutes, not too bad [17:57:00] So 1.4M is the number of rows we'll need to update [17:57:01] on enwiki? [17:57:05] Yeah [17:57:15] 3.6M is the number of update queries we'll issue, I think [17:58:11] do you think we should change the initial SELECT to be more targeted or issue all those 3.6M UPDATES? [17:58:31] Hmm, looking [17:58:57] the good thing about being more targeted is that is can resume if it breaks in the middle... [17:59:07] Actually you know what [17:59:15] You should do the targeting for other reasons too [17:59:22] The WHERE of your UPDATE query is unindexed [17:59:49] If you do it in a more targeted way, you can have a SELECT grab the eventID+userID pairs (which together uniquely identify a row) that you need to update [17:59:58] Then the UPDATE will be able to find the rows it needs to change much faster [18:00:09] right [18:00:11] As written I think we'll have to scan the entire table for each update [18:00:28] Sorry, I didn't think to verify indexedness until now, I would have -1ed for that otherwise [18:00:42] I'll patch on top [18:01:00] working on that now [18:08:33] 06Collaboration-Team-Interested, 10MediaWiki-Vagrant: echo role may not work unless centralauth role is explicitly enabled - https://phabricator.wikimedia.org/T124707#1963394 (10Krinkle) My issue may've been the same as well: T135872. [18:13:52] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1891883 (10Wbm1058) https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Wikidata_alert_is_sticky [18:27:12] RoanKattouw, BEST. CHROME BUG. EVER. [18:28:06] RoanKattouw, etonkovidova found it. It's awesome. I can't figure out **why** it happened but I at least managed to figure out it happened because chrome was auto-translating catalan to English (without really doing anything) and then adding blah in the

heading in Flow boards [18:28:27] that made the heading behave so weirdly... "blahfoo 1" would appear as "1 blahfoo" as if it's RTL [18:29:04] but "blahfoo 1 2" would be "blahfoo 1 2" not "rtl".... but catalan isn't rtl at all. Also, didn't have a dir set on it, and the general dir attribute on the page is LTR [18:29:34] RoanKattouw: SELECT notification_bundle_display_hash, notification_read_timestamp, COUNT(*) AS bundleSize FROM echo_notification where notification_bundle_base = 1 AND notification_bundle_display_hash <> '' AND notification_read_timestamp IS NOT NULL GROUP BY notification_bundle_hash, notification_read_timestamp HAVING bundleSize > 1; [18:29:47] RoanKattouw: ^ how bad do you think that is? [18:31:52] HAVING is usually a bad sign :P [18:32:26] I think the problem with that one is that it'll scan the entire table [18:32:47] yeah, and it still doesn't give me the bundled notif ids [18:32:48] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2350363 (10Pginer-WMF) >>! In T93243#2349869, @Catrope wrote: >>>! In T93243#2349681, @Pginer-WMF wrote: >> I'd propose to tr... [18:33:20] OTOH there is no useful index you could possibly be using here anyeway [18:33:25] the other way with the sub select gives the ids of the notifications that need to be updated but not the read_timestamp of the base [18:33:36] this is awesome [18:34:06] RoanKattouw, apparently, Chrome thinks that English to Catalan "Foo40 1" --> "1 Foo40" [18:34:21] stephanebisson: Also I think that query is broken. It only fetches unread rows, so it ignores read rows with base=1 [18:34:30] Sorry, the other way around [18:34:33] I don't even know if I should consider this an RTL weirdness or just a random chrome-wtf [18:34:42] It only fetches read rows, so unread base=0 rows don't count towards the bundle size [18:34:44] RoanKattouw, in other words, is this for browser.wtf or rtl.wtf [18:34:52] right [18:34:53] :D [18:35:05] Even worse, there's a base=1 condition so bundle size counting doesn't work at all [18:35:24] mooeypoo: googletranslate.wtf [18:35:34] RoanKattouw, srsly [18:35:58] etonkovidova was all confused why the number in all of her test Flow boards was moving to the beginning of the name [18:36:34] stephanebisson: Sorry, I'm in a meeting till 1pm Pacific, I'll be able to use my brain for real after that [18:36:50] no worries [18:37:15] 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Creating empty replies should be prevented - https://phabricator.wikimedia.org/T136777#2350382 (10Quiddity) [18:37:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: [betalabs] Creating empty replies should be prevented - https://phabricator.wikimedia.org/T136777#2347552 (10Quiddity) [18:37:55] (03CR) 10Sbisson: Mark bundled notifications as read (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292359 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [18:41:29] Do we still use lightncandy anywhere? wondering if i can remove #flow and #-interested from https://phabricator.wikimedia.org/T121947 [18:42:20] quiddity, yeah, we are using it to compile handlebars templates in Flow [18:42:24] kk [18:42:44] Not sure if we'd want/need to in the far future, but for now we are [19:10:32] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2350530 (10Pginer-WMF) I illustrated how some of the ideas above would look in context: **Initial state.** {F4104521} **Tex... [19:12:27] 06Collaboration-Team-Interested, 10Notifications: Enable cross-wiki users to set preferences for what wikis they see where - https://phabricator.wikimedia.org/T114917#2350541 (10Quiddity) [19:15:23] 06Collaboration-Team-Interested, 10Notifications, 07Design, 07WorkType-NewFunctionality: Let cross-wiki users set preferences for what types of notifications they see where - https://phabricator.wikimedia.org/T117670#2350548 (10Quiddity) [19:18:29] 06Collaboration-Team-Interested, 10Notifications: Enable cross-wiki users to set preferences for what wikis they see where - https://phabricator.wikimedia.org/T114917#2350574 (10Quiddity) Note: One more editor requesting "Filter by origin" - a per-wiki opt-out, at https://www.mediawiki.org/wiki/Topic:T54qf2o9i... [19:24:04] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Discussion page stuck loading only on first load; "TypeError: $.throttle is not a function" - https://phabricator.wikimedia.org/T134984#2284524 (10Etonkovidova) 1) Tested in cawiki in Flow_test_talk namespace. - for creating Flow test talk pages fir... [19:25:51] matt_flaschen: that Add missing dependency on jquery.throttle-debounce - https://gerrit.wikimedia.org/r/#/c/288223/? [19:26:02] matt_flaschen: I still see the issue in en.wikilearn [19:26:50] matt_flaschen: sorry, did not type the whole thing - was it deployed? [19:34:21] Hmm it looks like ?markasread=NNN is not added to primary links in emaisl [19:35:08] (03CR) 10Catrope: [C: 032] Mark bundled notifications as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292359 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [19:35:44] etonkovidova: wikilearn is not one of our web sites [19:35:56] We don't run it, so I don't know if the fix was deployed there or not [19:36:43] RoanKattouw: well, it's good to know :) I was just verifying the fixed bug that was reported there https://phabricator.wikimedia.org/T134984 [19:44:49] (03Merged) 10jenkins-bot: Mark bundled notifications as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292359 (https://phabricator.wikimedia.org/T136368) (owner: 10Sbisson) [19:55:03] 06Collaboration-Team-Interested, 10Notifications: In cross-wiki notification bundle, "mark as read" secondary link doesn't do anything - https://phabricator.wikimedia.org/T136878#2350711 (10Quiddity) [20:25:50] 06Collaboration-Team-Interested, 10Flow: Loss of data when click on link - https://phabricator.wikimedia.org/T118075#2350813 (10Quiddity) [20:25:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Flow not warning me when I leave an edit page with unsaved changes - https://phabricator.wikimedia.org/T96531#2350815 (10Quiddity) [20:26:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Flow not warning me when I leave an edit page with unsaved changes - https://phabricator.wikimedia.org/T96531#1219067 (10Quiddity) [20:32:44] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Minimal JS version of Special:Notifications - https://phabricator.wikimedia.org/T129176#2097219 (10Etonkovidova) Verified in betalabs. [20:43:11] 10Flow: On Beta, Flow talk page manager does not move pre-existing sub-pages of archives - https://phabricator.wikimedia.org/T133835#2350878 (10Mattflaschen-WMF) I don't think it actually makes sense to move them. The original bug says: "Discussion_utilisateur:Yann/archives_2014 should have been moved to Discu... [20:44:44] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Discussion page stuck loading only on first load; "TypeError: $.throttle is not a function" - https://phabricator.wikimedia.org/T134984#2284524 (10jmatazzoni) > The issue is still present in en.wikilearn - e.g. https://en.wikitolearn.org/Talk:Vodka d... [20:46:45] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Minimal JS version of Special:Notifications - https://phabricator.wikimedia.org/T129176#2350885 (10jmatazzoni) 05Open>03Resolved [20:46:47] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Epic, 07Tracking: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2350886 (10jmatazzoni) [20:51:48] mooeypoo, question about my GuidedTour patch when you have a second. [20:53:20] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Discussion page stuck loading only on first load; "TypeError: $.throttle is not a function" - https://phabricator.wikimedia.org/T134984#2350892 (10Mattflaschen-WMF) 05Open>03Resolved >>! In T134984#2350881, @jmatazzoni wrote: > @Catrope, is this... [21:08:36] 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Special:Notificaitons page has wrong sorting order after messages are 'Marked as unread' - https://phabricator.wikimedia.org/T136885#2350991 (10Etonkovidova) [21:11:04] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: Add dry-run mode to Flow External Store migration script - https://phabricator.wikimedia.org/T119566#2351024 (10Mattflaschen-WMF) Good catch, this is actually a bug. It wrongly says the content doesn't match, because th... [21:14:59] 10Flow: External Store dry run wrongly detects failed insert if $wgCompressRevisions is true - https://phabricator.wikimedia.org/T136887#2351032 (10Mattflaschen-WMF) [21:15:22] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: External Store dry run wrongly detects failed insert if $wgCompressRevisions is true - https://phabricator.wikimedia.org/T136887#2351045 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [21:27:23] (03PS1) 10Mattflaschen: Dry run: Read content properly when doing consistency check [extensions/Flow] - 10https://gerrit.wikimedia.org/r/292483 (https://phabricator.wikimedia.org/T136887) [21:29:00] (03PS2) 10Mattflaschen: Dry run: Read content properly when doing consistency check [extensions/Flow] - 10https://gerrit.wikimedia.org/r/292483 (https://phabricator.wikimedia.org/T136887) [21:29:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: External Store dry run wrongly detects failed insert if $wgCompressRevisions is true - https://phabricator.wikimedia.org/T136887#2351105 (10Mattflaschen-WMF) [21:29:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 10DBA: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2351104 (10Mattflaschen-WMF) [21:37:13] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Mark groups of notifications as read - https://phabricator.wikimedia.org/T132738#2208839 (10Etonkovidova) Checked in betalabs - all specs are in place with small deviation from >When the user is filtering results to view only Unread, clicking the Mar... [21:52:05] bd808 or anyone else able to review https://gerrit.wikimedia.org/r/#/c/287015/ ? [21:52:14] Vagrant change: "Have Flow depend on memcached to match production" [21:52:39] 03Collab-Team-2016-Apr-Jun-Q4: Special:Notifications: the filtered 'Unread' page needs to be refreshed after messages were marked as read - https://phabricator.wikimedia.org/T136891#2351171 (10Etonkovidova) [21:52:55] 03Collab-Team-2016-Apr-Jun-Q4: Special:Notifications: the filtered 'Unread' page needs to be refreshed after messages were marked as read - https://phabricator.wikimedia.org/T136891#2351185 (10Etonkovidova) [21:53:48] matt_flaschen: +2'd. that role may as well just load all the others at this point. ;) [21:57:25] bd808, except buggy. :) [21:57:41] that role is awesome. [21:57:51] bd808, I never looked into what it actually does. Do you know? [21:58:11] it adds some special pages to trigger various internal errors [21:58:24] Oh, okay. [21:58:39] The description is fun and very non-specific (maybe it's testing a documentation bug) [21:58:41] "Buggy extension - an extension that generates bugs." [21:58:56] tgr wrote it to help with testing logging and error handling stuff [22:00:49] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07Design, 13Patch-For-Review: Hide pagination controls from the Notification Page when there is only one page - https://phabricator.wikimedia.org/T136574#2339439 (10Etonkovidova) Checked in betalabs. One read message {F4105019} One un-read messag... [22:01:24] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2351211 (10darthbhyrava) [22:05:27] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: WikiToLearn: Problem while converting from LiquidThreads to Flow - https://phabricator.wikimedia.org/T128949#2351239 (10Mattflaschen-WMF) 05Open>03Resolved Sorry to hear you were not able to solve the migration problems, but glad to hear you got it working. (For othe... [22:18:05] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2351299 (10darthbhyrava) [22:18:22] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Special:Notifications: the filtered 'Unread' page needs to be refreshed after messages were marked as read - https://phabricator.wikimedia.org/T136891#2351303 (10Danny_B) [22:20:46] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 05Google-Summer-of-Code-2016: Community bonding evaluation for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133666#2351307 (10darthbhyrava) @jayvdb - could you let me know if there is anything else that... [22:21:24] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Special:Notificaitons page has wrong sorting order after messages are 'Marked as unread' - https://phabricator.wikimedia.org/T136885#2351309 (10Danny_B) [23:04:01] 06Collaboration-Team-Interested, 10Notifications, 07Tracking: Status filter should not become disabled between status change in the Notification Page - https://phabricator.wikimedia.org/T136895#2351420 (10Pginer-WMF) [23:04:14] 06Collaboration-Team-Interested, 10Notifications: Status filter should not become disabled between status change in the Notification Page - https://phabricator.wikimedia.org/T136895#2351420 (10Pginer-WMF) [23:04:44] RoanKattouw, I know the schema change is done in production, but https://gerrit.wikimedia.org/r/#/c/289583/ ("Add notification_seen column to mark whether user saw that notification") still needs to be reviewed when you have a chance. [23:05:07] matt_flaschen: Oh, sorry, I thought you were going to add backend code to that still [23:05:50] I'm happy to merge just the field addition, but for some reason I thought you were going to amend that patch to flesh it out and add code that uses it etc [23:06:07] If that "some reason" was just my imagination, then I have no problem merging :) [23:06:10] RoanKattouw, I was considering doing that, but not in the same patch. I can though. [23:06:17] OK, up to you [23:06:48] 06Collaboration-Team-Interested, 10Notifications: Echo's 'seen time' should be replaced with marking specific notifications as seen - https://phabricator.wikimedia.org/T110731#2351435 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [23:07:08] (03CR) 10Mattflaschen: [C: 04-1] "Will amend with the backend support, per discussion on IRC." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289583 (https://phabricator.wikimedia.org/T135661) (owner: 10Mattflaschen) [23:08:06] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Filter by read status on the Notification Page - https://phabricator.wikimedia.org/T129364#2103509 (10Etonkovidova) Special:Notifications page currently has 'All', 'Read', and 'Unread' filters (no cross-wiki). The functionality was checked as part of... [23:29:00] 06Collaboration-Team-Interested, 10Flow, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Email notification about "someone edited the description on Flow board" should point to the diff, not the page - https://phabricator.wikimedia.org/T135136#2351600 (10Mattflaschen-WMF) The... [23:34:11] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07Regression, and 2 others: hewiki.echo_notification does not exist - https://phabricator.wikimedia.org/T136759#2346708 (10Etonkovidova) Checked on he.wikipedia.org/wiki - viewing/posting/receiving notifications seem to be wit... [23:37:22] (03PS2) 10Awight: Clean up the pagination in Special:Notifications [extensions/Echo] (wmf/1.28.0-wmf.4) - 10https://gerrit.wikimedia.org/r/292265 (owner: 10Catrope) [23:37:31] (03CR) 10Awight: [C: 032] "SWAT deployment" [extensions/Echo] (wmf/1.28.0-wmf.4) - 10https://gerrit.wikimedia.org/r/292265 (owner: 10Catrope) [23:37:47] (03PS2) 10Awight: Display a message if there are no notifications in Special:Notifications [extensions/Echo] (wmf/1.28.0-wmf.4) - 10https://gerrit.wikimedia.org/r/292270 (https://phabricator.wikimedia.org/T136586) (owner: 10Catrope) [23:37:56] (03CR) 10Awight: [C: 032] "SWAT deployment" [extensions/Echo] (wmf/1.28.0-wmf.4) - 10https://gerrit.wikimedia.org/r/292270 (https://phabricator.wikimedia.org/T136586) (owner: 10Catrope) [23:44:05] (03Merged) 10jenkins-bot: Clean up the pagination in Special:Notifications [extensions/Echo] (wmf/1.28.0-wmf.4) - 10https://gerrit.wikimedia.org/r/292265 (owner: 10Catrope) [23:46:11] (03Merged) 10jenkins-bot: Display a message if there are no notifications in Special:Notifications [extensions/Echo] (wmf/1.28.0-wmf.4) - 10https://gerrit.wikimedia.org/r/292270 (https://phabricator.wikimedia.org/T136586) (owner: 10Catrope) [23:54:19] RoanKattouw, my core deletion fix patch also needs review: https://gerrit.wikimedia.org/r/#/c/290293/ . [23:54:44] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 03Collab-Archive-2015-2016, 07User-notice: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2351642 (10Etonkovidova) {icon check-square-o color=green} Visually distinguish read and unrea... [23:55:01] matt_flaschen: I'll look at that some other time when I'm not drowning in performance review work [23:55:06] In other words: YOU also need review :P [23:57:00] RoanKattouw, ah yeah, forgot about that. :) [23:57:08] * matt_flaschen needs to finish his annual goals tonight