[00:14:17] (03PS1) 10Mooeypoo: Display a message if there are no notifications in Special:Page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) [00:14:47] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: [betalabs] Special:Notifications page - 1-0 message count displayed when there are no messages on a page - https://phabricator.wikimedia.org/T136586#2340020 (10Mooeypoo) a:03Mooeypoo [00:25:07] (03PS1) 10Mooeypoo: Make the notifications list the pending element [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291852 (https://phabricator.wikimedia.org/T136581) [00:25:12] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Adjust the loading indicator to affect only the list of items in the Notification Page - https://phabricator.wikimedia.org/T136581#2340025 (10Mooeypoo) a:03Mooeypoo [00:25:39] (03CR) 10Catrope: [C: 032] Make the notifications list the pending element [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291852 (https://phabricator.wikimedia.org/T136581) (owner: 10Mooeypoo) [00:26:45] mooeypoo: https://phabricator.wikimedia.org/T136568 [00:32:28] (03Merged) 10jenkins-bot: Make the notifications list the pending element [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291852 (https://phabricator.wikimedia.org/T136581) (owner: 10Mooeypoo) [00:38:27] (03PS1) 10Mooeypoo: Styling changes to Special:Notifications headers and toolbar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291854 (https://phabricator.wikimedia.org/T136580) [00:38:45] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Remove section title lines on the Notification Page - https://phabricator.wikimedia.org/T136568#2340041 (10Mooeypoo) a:03Mooeypoo [00:39:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Adjust notification page separation between groups - https://phabricator.wikimedia.org/T136580#2340043 (10Mooeypoo) a:03Mooeypoo [00:40:11] (03PS2) 10Mooeypoo: Styling changes to Special:Notifications headers and toolbar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291854 (https://phabricator.wikimedia.org/T136580) [00:40:20] ... ignore that first commit message [00:40:22] ... [00:40:24] ........ [00:40:31] (03CR) 10Catrope: [C: 032] Styling changes to Special:Notifications headers and toolbar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291854 (https://phabricator.wikimedia.org/T136580) (owner: 10Mooeypoo) [00:48:18] (03Merged) 10jenkins-bot: Styling changes to Special:Notifications headers and toolbar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291854 (https://phabricator.wikimedia.org/T136580) (owner: 10Mooeypoo) [00:57:58] * quiddity denies seeing anything [01:09:26] (03PS1) 10Mooeypoo: Adjust styling for Special:Notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291855 (https://phabricator.wikimedia.org/T136572) [01:09:40] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Make notification styling on the Notifications Page closer to the ones in the panel - https://phabricator.wikimedia.org/T136572#2340069 (10Mooeypoo) a:03Mooeypoo [01:11:18] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 03Collab-Archive-2015-2016, 07User-notice: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2340071 (10Mooeypoo) a:03Mooeypoo This is resolved with the new JS special page. [01:12:30] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Display notifications from a single day in groups - https://phabricator.wikimedia.org/T132739#2340074 (10Mooeypoo) a:03Mooeypoo This is resolved (at least an MVP version) with the new special page JS commit that was merged. [01:25:56] 03Collab-Team-2016-Apr-Jun-Q4, 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2340082 (10Danny_B) >>! In T51541#2251090, @Dvorapa wrote: > @Danny_B e.g. based on the summary: > `RFC closed`... [01:41:58] 06Collaboration-Team-Interested, 10Flow: Flow: Parsoid HTML for videos doesn't work - https://phabricator.wikimedia.org/T63769#2340083 (10Mattflaschen-WMF) [01:46:06] (03CR) 10Catrope: [C: 04-1] Adjust styling for Special:Notification items (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291855 (https://phabricator.wikimedia.org/T136572) (owner: 10Mooeypoo) [02:00:25] (03CR) 10Mattflaschen: [C: 04-1] "Initial review. Only one simple thing." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) (owner: 10Catrope) [04:01:59] (03PS2) 10Catrope: [WIP] Gracefully handle outdated echo_unread_wikis rows [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291676 (https://phabricator.wikimedia.org/T132954) [06:24:16] 03Collab-Team-2016-Apr-Jun-Q4, 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2340256 (10Dvorapa) @Danny_B I don't see a reason, why an administrator should add nonsense with `RFC closed` su... [06:26:53] 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Write an update about that is going on concerning ptwikibooks LqT-to-Flow conversion - https://phabricator.wikimedia.org/T136555#2338761 (10Qgil) High priority, I am assuming this task aims to be addressed in June. [06:27:17] 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Write an update about that is going on concerning ptwikibooks LqT-to-Flow conversion - https://phabricator.wikimedia.org/T136555#2340259 (10Qgil) [06:41:57] 10Collab-Notifications-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#1838142 (10Qgil) @Trizek-WMF, are you planning to work on this task during June, or in the next quarter? [09:14:58] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review, 03TCB-Team-Sprint-2016-05-19: [GTWL] Investigate the technical requirements for mention failure notifications - https://phabricator.wikimedia.org/T135719#2340530 (10Lea_WMDE) Summarizing last Thursday's meeting: @Addshore will... [09:19:03] 10Notifications: Provide an option to automatically mark-as-read messages when they are seen on Notifications pannel - https://phabricator.wikimedia.org/T136601#2340545 (10Trizek-WMF) [09:20:37] 10Collab-Notifications-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2340564 (10Trizek-WMF) Some changes will happen in June, that may need to draft something. At least, mark-as-r... [09:31:23] 03Collab-Team-2016-Apr-Jun-Q4, 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2340580 (10Danny_B) I didn't write "an administrator", but "some user". Neither I was talking about RFC page. S... [09:50:29] 03Collab-Team-2016-Apr-Jun-Q4, 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2340629 (10Dvorapa) @Danny_B But I talk about these. According to the summary to an administrator I usualy thank... [10:03:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2340655 (10Danny_B) No, they are not pointless at all. They actually guarantee that nobody will thank blindly wi... [10:09:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2340660 (10Danny_B) >>! In T51541#544594, @MZMcBride wrote: > The larger issue is interface clutter. Correct. I... [12:05:59] 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Write an update about that is going on concerning ptwikibooks LqT-to-Flow conversion - https://phabricator.wikimedia.org/T136555#2340855 (10Trizek-WMF) >>! In T136555#2340257, @Qgil wrote: > High priority, I am assuming this t... [13:34:04] 10Collab-Notifications-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2340956 (10Trizek-WMF) [14:44:50] 10Flow, 13Patch-For-Review, 07User-notice: Mark a Topic as resolved shouldn't send a notifications to people who follow the Board but not the Topic itself - https://phabricator.wikimedia.org/T136060#2341054 (10Trizek-WMF) [[ https://fr.wikipedia.org/w/index.php?title=Sujet:T4fyespdjqx808we&topic_showPostId=t... [14:59:39] 10Collab-Notifications-Page: Have a way to mark all notifications as read at once - https://phabricator.wikimedia.org/T136614#2341095 (10Trizek-WMF) [15:11:07] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 07User-notice: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2341143 (10Trizek-WMF) @Catrope, can you add that toolbar on a test wiki? Thanks. [15:32:38] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: [betalabs] Flow: clicking 'Cancel' for moderation actions results in "Unknown dependency: schema.Undefined" error - https://phabricator.wikimedia.org/T135185#2341276 (10jmatazzoni) 05Open>03Resolved [15:33:40] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Regression: Empty flyout is missing a text placeholder - https://phabricator.wikimedia.org/T136467#2341279 (10jmatazzoni) 05Open>03Resolved [15:34:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki, 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): New Error Message for "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2341286 (10jmat... [15:34:10] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07Epic, and 3 others: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2341287 (10jmatazzoni) [15:36:09] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Change current no-JS Special:Notifications to use core Pager - https://phabricator.wikimedia.org/T129169#2341299 (10jmatazzoni) 05Open>03Resolved [15:36:10] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Epic, 07Tracking: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2341300 (10jmatazzoni) [15:44:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Use 'modules' and 'moduleStyles' keys in FlowActions to stop loading javascript on pages that are supposed to be no-javascript only - https://phabricator.wikimedia.org/T95468#2341350 (10jmatazzoni) 05Open>03Resolved > It's possible to right-click... [15:46:34] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 07JavaScript, 13Patch-For-Review, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): Flow: JavaScript errors and wrong result from post moderation actions performed in new window - https://phabricator.wikimedia.org/T73220#2341373 (10jmatazzoni) 05Open>03Resolved [15:48:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): On protected Flow pages, remove/replace action links, and/or inform users without sufficient rights to use them - https://phabricator.wikimedia.org/T127774#2341374 (10jmatazzoni)... [16:14:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2341489 (10jmatazzoni) @Pginer-WMF, do we need to add anything to clarify how this works on the Notification... [16:35:20] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review, 03TCB-Team-Sprint-2016-05-19: [GTWL] Investigate the technical requirements for mention failure notifications - https://phabricator.wikimedia.org/T135719#2341558 (10Lea_WMDE) @Catrope could you help us out with answers to a few... [16:47:20] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 07User-notice: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#2341595 (10Catrope) >>! In T93243#2341143, @Trizek-WMF wrote: > @Catrope, can you add that toolbar on a test wiki? Thanks. I'll ask someone to merge it today after th... [16:51:34] hi Collaboration team, https://gerrit.wikimedia.org/r/#/c/291280/ makes some small changes to what data is logged by the Campaigns extension (ServerSideAccountCreation schema) [16:52:05] please speak up against it now or forever hold your peace :) [16:52:12] RoanKattouw: ^ [16:54:03] tgr: I should see if someone in Reading wants to take that over, it seems to have ended up with us by accident [16:54:29] Anomie tried asking if anyone still used it, do you know if anything came of that? [16:55:25] RoanKattouw: Nemo mentioned WMIT using it on occasion, but nothing apart from that [16:55:29] Changes sound fine to me based on the commit message [16:55:45] some of the fields are broken since 2013 so I doubt anyone is using it heavily [16:55:57] ok, thanks [16:56:28] Hah, yeah [17:10:15] 06Collaboration-Team-Interested, 10Flow: Add an help-icon to give access to Help from all Flow board and Topics - https://phabricator.wikimedia.org/T136565#2341661 (10Trizek-WMF) [17:10:17] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), and 2 others: Create a general public documentation for Flow (tracking) - https://phabricator.wikimedia.org/T111367#2341660 (10Trizek-WMF) [17:10:17] (03CR) 10Catrope: Unread pages API (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291351 (owner: 10Matthias Mullie) [17:14:04] RoanKattouw: https://phabricator.wikimedia.org/T136571 - about ButtonGroupWidget border [17:14:16] matt_flaschen: Could you review https://gerrit.wikimedia.org/r/#/c/291364/2 today? [17:14:59] etonkovidova: Oh, it's an OOUI patch. Those have a weird schedule. The weekly OOUI release is later today so it should be in beta then [17:15:15] RoanKattouw: ok then [17:19:53] 10Flow, 13Patch-For-Review, 07User-notice: Mark a Topic as resolved shouldn't send a notifications to people who follow the Board but not the Topic itself - https://phabricator.wikimedia.org/T136060#2341690 (10Catrope) >>! In T136060#2341054, @Trizek-WMF wrote: > [[ https://fr.wikipedia.org/w/index.php?title... [17:30:25] 10Flow, 13Patch-For-Review, 07User-notice: Mark a Topic as resolved shouldn't send a notifications to people who follow the Board but not the Topic itself - https://phabricator.wikimedia.org/T136060#2341730 (10Trizek-WMF) Thanks! [17:31:52] RoanKattouw, yep. [18:09:30] (03PS2) 10Mooeypoo: Adjust styling for Special:Notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291855 (https://phabricator.wikimedia.org/T136572) [18:11:21] mooeypoo: https://phabricator.wikimedia.org/T136567 [18:11:29] mooeypoo: https://phabricator.wikimedia.org/T130578 [18:15:39] (03CR) 10Catrope: [C: 04-1] Adjust styling for Special:Notification items (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291855 (https://phabricator.wikimedia.org/T136572) (owner: 10Mooeypoo) [18:16:30] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review, 03TCB-Team-Sprint-2016-05-19: [GTWL] Investigate the technical requirements for mention failure notifications - https://phabricator.wikimedia.org/T135719#2341944 (10Catrope) >>! In T135719#2341558, @Lea_WMDE wrote: > @Catrope c... [18:19:55] (03CR) 10Catrope: [C: 032] Unread pages API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291351 (owner: 10Matthias Mullie) [18:29:10] (03Merged) 10jenkins-bot: Unread pages API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291351 (owner: 10Matthias Mullie) [18:30:42] (03PS3) 10Catrope: Adjust styling for Special:Notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291855 (https://phabricator.wikimedia.org/T136572) (owner: 10Mooeypoo) [18:31:14] (03CR) 10Catrope: [C: 032] Adjust styling for Special:Notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291855 (https://phabricator.wikimedia.org/T136572) (owner: 10Mooeypoo) [18:37:16] (03CR) 10Catrope: [C: 04-1] "Moriel says she's still working on this" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) (owner: 10Mooeypoo) [18:39:09] (03Merged) 10jenkins-bot: Adjust styling for Special:Notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291855 (https://phabricator.wikimedia.org/T136572) (owner: 10Mooeypoo) [18:47:44] (03PS1) 10Catrope: Adjust styling for Special:Notification items [extensions/Echo] (wmf/1.28.0-wmf.4) - 10https://gerrit.wikimedia.org/r/291962 (https://phabricator.wikimedia.org/T136572) [18:51:33] (03PS2) 10Mooeypoo: Display a message if there are no notifications in Special:Page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) [18:51:54] (03CR) 10jenkins-bot: [V: 04-1] Display a message if there are no notifications in Special:Page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) (owner: 10Mooeypoo) [18:53:03] (03PS6) 10Mooeypoo: Clean up the pagination in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 [18:53:33] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications, 07Easy: Echo notification emails are sanitized strangely - https://phabricator.wikimedia.org/T68630#2342064 (10jmatazzoni) Are we OK with the anomalies described? They all sound pretty edge-case. Can I leave this closed? [18:54:23] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications, 07Easy: Echo notification emails are sanitized strangely - https://phabricator.wikimedia.org/T68630#2342066 (10Catrope) >>! In T68630#2342064, @jmatazzoni wrote: > Are we OK with the anomalies described? They all sound pretty... [18:56:51] (03PS3) 10Mooeypoo: Display a message if there are no notifications in Special:Page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) [18:57:06] (03PS4) 10Mooeypoo: Display a message if there are no notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) [19:04:37] (03CR) 10jenkins-bot: [V: 04-1] Display a message if there are no notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) (owner: 10Mooeypoo) [19:15:08] 10Flow, 10Collaboration-Community-Engagement, 10VisualEditor: Allow people to add customized buttons to VE toolbar by an easy way - https://phabricator.wikimedia.org/T136152#2342239 (10Jdforrester-WMF) [19:15:25] 10Flow, 10Collaboration-Community-Engagement, 10VisualEditor: Allow people to add customized buttons to VE toolbar by an easy way - https://phabricator.wikimedia.org/T136152#2325070 (10Jdforrester-WMF) [19:16:30] 10Flow, 10Collaboration-Community-Engagement, 10VisualEditor: Allow people to add customized buttons to OOUI/VE toolbar in an easy way - https://phabricator.wikimedia.org/T136152#2325070 (10Jdforrester-WMF) p:05Triage>03Low [19:19:19] (03CR) 10Catrope: Clean up the pagination in Special:Notifications (0310 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 (owner: 10Mooeypoo) [19:19:34] (03CR) 10Catrope: [C: 04-1] "Comments on PS5" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 (owner: 10Mooeypoo) [19:26:06] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications, 07I18n, 07RTL: Incorrect order of elements in email subject when username is RTL - https://phabricator.wikimedia.org/T130578#2342293 (10Catrope) Looks like the email does contain LRE/RLE characters in the subject line, so th... [19:31:46] (03CR) 10Catrope: [C: 04-1] Display a message if there are no notifications in Special:Notifications (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) (owner: 10Mooeypoo) [20:12:31] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2342514 (10Volker_E) @Pginer-WMF @jmatazzoni On a minor note, we need to make sure that the clickable area i... [20:16:31] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07Regression: Special page: Requested notifications are in wrong order - https://phabricator.wikimedia.org/T135307#2342518 (10Etonkovidova) Re-checked - seems that the pagination sorting order is correct now. [20:28:27] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 07Regression: Special page: Requested notifications are in wrong order - https://phabricator.wikimedia.org/T135307#2342545 (10Etonkovidova) 05Open>03Resolved [20:29:11] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Display notifications from a single day in groups - https://phabricator.wikimedia.org/T132739#2208852 (10Etonkovidova) per @Pginer-WMF The date label is too faded (some usability concerns). .mw-echo-ui-datedSubGroupListWidget-title-secondary { fo... [20:44:49] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2342600 (10jmatazzoni) > On a minor note, we need to make sure that the clickable area is big enough. What'... [20:59:46] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Have a way to mark all notifications as read at once - https://phabricator.wikimedia.org/T136614#2342673 (10jmatazzoni) [21:01:00] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Remove section title lines on the Notification Page - https://phabricator.wikimedia.org/T136568#2339309 (10Etonkovidova) Checked in betalabs - section underline is removed. {F4095839} [21:06:37] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: Display notifications from a single day in groups - https://phabricator.wikimedia.org/T132739#2342700 (10Catrope) >>! In T132739#2342548, @Etonkovidova wrote: > per @Pginer-WMF > The date label is too faded (some usability concerns). > ``` > .mw-echo... [21:23:08] 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] flow-menu-js-drop cannot be dismissed if a menu item was right-clicked - https://phabricator.wikimedia.org/T136153#2342746 (10Etonkovidova) [21:25:46] 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] flow-menu-js-drop cannot be dismissed if a menu item was right-clicked - https://phabricator.wikimedia.org/T136153#2342754 (10Mattflaschen-WMF) [21:26:38] (03PS1) 10Mooeypoo: Darken the dates in the Special:Notifications groups [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292033 (https://phabricator.wikimedia.org/T132739) [21:27:41] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 03Collab-Archive-2015-2016, 07Documentation: Document new Echo formatting system - https://phabricator.wikimedia.org/T116612#2342771 (10Quiddity) a:05Legoktm>03None Unassigning as Legoktm is busy with other tasks now, and to make it clear this is ready fo... [21:27:50] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Notifications: [betalabs] Deleting text/section on wikitext triggers message "a user left a message on your talk page" - https://phabricator.wikimedia.org/T136376#2342774 (10Etonkovidova) [21:29:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [betalabs] Deleting text/section on wikitext triggers message "a user left a message on your talk page" - https://phabricator.wikimedia.org/T136376#2342778 (10Quiddity) [21:32:51] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications, 07Easy: Echo notification emails are sanitized strangely - https://phabricator.wikimedia.org/T68630#2342803 (10MZMcBride) 05Resolved>03Open Huh? Unless this issue has been fixed, please leave it open. [21:33:03] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [betalabs] Deleting text/section on wikitext triggers message "a user left a message on your talk page" - https://phabricator.wikimedia.org/T136376#2332633 (10Mattflaschen-WMF) I think we can use hasSection for this (to detect more straightforward cases vs. unkno... [21:34:18] 10Flow: Flow: add message bar is enable when topic is closed - https://phabricator.wikimedia.org/T136215#2342812 (10Quiddity) [21:34:21] 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Reply text area is present on Resolved topics but replies cannot be saved - https://phabricator.wikimedia.org/T135848#2342814 (10Quiddity) [21:34:21] RoanKattouw: Saying "this is an edge case" and closing a task isn't really appropriate. [21:34:48] If it weren't an edge case, someone probably wouldn't've taken time out of their life to file a bug saying "fix your software." [21:35:05] Oh, sorry, I didn't notice that was all that the bug was about [21:35:41] I thought it was a larger task and that the question was "everything is fine except this edge case, can we close the bug" [21:35:54] But instead the bug was just about the small thing, so yes it should stay open [21:35:56] I think the bug is "input doesn't match output". [21:36:17] Like someone specifies a heading for a section and somehow it gets mangled on the way to becoming an HTML e-mail. [21:36:25] We should be able to safely ingest and output our own data. [21:36:52] I think Flow re-implemented its own parser, 'cause the half-dozen we already have were insufficient(???). [21:37:03] No, that's not what's going on [21:37:14] First off, Flow isn't involved here at all, it's Echo [21:37:21] And it's making a quite understandable mistake [21:37:26] It's taking the section title and parsing it as wikitext [21:37:38] If you write == :| == then the section title is ":|" [21:37:40] Oh, Echo. [21:38:15] And if you then parse that, in isolation, the ":" becomes magical because it's now at the start of a line (but originally wasn't), so now it means indentation and you get an indented pipe [21:38:53] Right, we can escape wikitext. [21:39:04] Or just parse it in the correct context. [21:39:14] Maybe [21:39:22] Instead of in a vacuum. [21:39:24] There isn't really a good way to do this in MW core right now [21:39:29] Parse section headings? [21:39:46] I think we do it on most page renders. [21:41:13] I wonder if we can use the thing that generates the section links in edit summaries [21:41:22] /* :| */ hopefully does wor [21:41:36] The edit summary parser is one of the half-dozen I was referencing above. [21:41:45] It has its own bugs. [21:42:03] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Mark as seen notifications from the Notifications Page - https://phabricator.wikimedia.org/T136576#2339490 (10Mattflaschen-WMF) This could be done by either: 1. Waiting for per-notifications seen time. 2. Simplifying and updating the per-user seen time when they... [21:42:08] Anyway, I'm sure some kind volunteer will fix that issue one day. [21:42:12] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Notifications, 07Easy: Echo notification emails are sanitized strangely - https://phabricator.wikimedia.org/T68630#2342878 (10Catrope) >>! In T68630#2342803, @MZMcBride wrote: > Huh? Unless this issue has been fixed, please leave it open. S... [21:42:39] 06Collaboration-Team-Interested, 10Notifications, 07Easy: Echo notification emails are sanitized strangely - https://phabricator.wikimedia.org/T68630#2342879 (10Catrope) [21:42:44] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Write email formatter that uses presentation models - https://phabricator.wikimedia.org/T121067#2342881 (10Catrope) [21:42:46] 06Collaboration-Team-Interested, 10Notifications, 07Easy: Echo notification emails are sanitized strangely - https://phabricator.wikimedia.org/T68630#687411 (10Catrope) [21:42:46] Yeah [21:42:51] I've commented on the bug and cleaned up its state [21:42:55] Cool, thanks. [21:44:05] What happened was it contained the word "email" in the title, so it got vacuumed up in the reverification effort of email-related bugs after the new email formatter code was merged [21:44:21] But this was one of the few that should not have been expected to have been fixed by the new formatter [21:47:58] 06Collaboration-Team-Interested, 10Notifications, 07Design, 07Tracking: Design adjustments for the Notifications Page - https://phabricator.wikimedia.org/T136567#2342888 (10Quiddity) [21:49:51] 06Collaboration-Team-Interested, 10Flow: Add a help icon to give access to Help from all Flow board and Topics - https://phabricator.wikimedia.org/T136565#2342889 (10Mattflaschen-WMF) [21:51:15] 06Collaboration-Team-Interested, 10Flow: Add a help icon to give access to Help from all Flow board and Topics - https://phabricator.wikimedia.org/T136565#2339206 (10Catrope) Customization of non-special page help links is not currently possible in MW core :( . This already causes the problem that the Watchlis... [21:54:25] 10Notifications: Global alert "your user rights changed" from wikimedia commons shown as new in every wiki i log in - https://phabricator.wikimedia.org/T136516#2337449 (10Catrope) It should go away if you click on the "X" next to the notification. If that doesn't happen for you, that would be T121930. If what yo... [22:04:47] I thought we had an "every 4 hours" for emails. Not sure if I imagined that, or we got rid of it. [22:06:33] 10Notifications, 10MediaWiki-Email: global notification mails to avoid double notification - https://phabricator.wikimedia.org/T136491#2336866 (10Mattflaschen-WMF) >>! In T136491#2336884, @Danny_B wrote: > Emails are being sent only once until you visit the page again. If you visit it, the email is being sent... [22:07:05] (03PS7) 10Mooeypoo: Clean up the pagination in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 [22:07:52] 10Notifications: When mentioning other users, indicate mention notifications in the "your edit was saved" message - https://phabricator.wikimedia.org/T68078#2342956 (10jmatazzoni) [22:08:40] 06Collaboration-Team-Interested: [betalabs] Reply text area is present on Resolved topics but replies cannot be saved - https://phabricator.wikimedia.org/T135848#2342958 (10jmatazzoni) [22:09:17] 06Collaboration-Team-Interested: [betalabs] Text excerpts are not shown in Mention messages from wikitext user talk pages - https://phabricator.wikimedia.org/T135879#2342959 (10jmatazzoni) [22:10:37] (03PS5) 10Mooeypoo: Display a message if there are no notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) [22:13:27] (03CR) 10Mooeypoo: Display a message if there are no notifications in Special:Notifications (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) (owner: 10Mooeypoo) [22:13:37] (03PS6) 10Mooeypoo: Display a message if there are no notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) [22:18:41] matt_flaschen: Reminder re https://gerrit.wikimedia.org/r/#/c/291364/2 [22:18:42] 06Collaboration-Team-Interested: [betalabs] flow-menu-js-drop cannot be dismissed if a menu item was right-clicked - https://phabricator.wikimedia.org/T136153#2343010 (10jmatazzoni) [22:19:13] 06Collaboration-Team-Interested, 10Notifications: [betalabs] Deleting text/section on wikitext triggers message "a user left a message on your talk page" - https://phabricator.wikimedia.org/T136376#2343013 (10jmatazzoni) [22:20:10] (03Merged) 10jenkins-bot: Darken the dates in the Special:Notifications groups [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292033 (https://phabricator.wikimedia.org/T132739) (owner: 10Mooeypoo) [22:22:09] RoanKattouw, I'll get it done today. [22:23:44] (03CR) 10Catrope: [C: 04-1] Clean up the pagination in Special:Notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 (owner: 10Mooeypoo) [22:24:24] Thanks [22:25:43] RoanKattouw, a widget that contains a sidebar of filters and the NotificationsInboxWidget will be called...............? [22:26:07] I thought something like FilteredNotificationsInboxWidget but (a) that's way long, and (b) that implies it extends NotificationsInboxWidget and that's not true [22:26:19] MorielIHaveMinusOnesForYouWidget ;) [22:26:33] I would like to separate this into its own encompassing widget rather than adding a sidebar to the inbox [22:26:38] ... wait, I dealt with the -1s! [22:26:42] did you -1 again? [22:26:51] pfft damnit [22:26:54] Yes, 3 minutes ago [22:27:04] You're forgiven for not having noticed :P [22:27:08] ... okay, I'll plus your minuses while you think of a name. [22:27:18] But more seriously, yeah that's a difficult thing to name [22:27:41] The InboxWidget is a [22:27:42] SpecialPageWidget is too specific, but we might want to just call it that [22:27:49] DatedSubGroupList plus... what? [22:27:51] IT *is* the special page widget [22:27:53] Pagination and stuff right? [22:28:08] Why not add the sidebar to the InboxWidget [22:28:20] the inbox widget has the dated list (which contains sub group widgets) + pagination + state (read/unread/all) [22:28:23] And maybe make it disableable in config if you care about being able to have a sidebarless inbox [22:28:26] + maybe in the future a search bar [22:29:13] RoanKattouw, I could, but (a) it would make that widget super complex, especially LESS-wise and dom structure (table layout ftwtf) and it also doesn't really NEED this. Theoretically and conceptually, thy're two different things [22:30:07] the sidebar is cross-wiki display thing. If it doesn't exist, for instance, the layout will likely change, and there is little connection between them if I did things right; that is, both speak to the controller, but they are updated not through one another but through the model event [22:37:46] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): VE won't recognise tags on paste - https://phabricator.wikimedia.org/T135620#2304760 (10Etonkovidova) Checked in betalabs (just in case) - copying username from Flow - e.g. [[User:ET80|ET80]] [22:40:43] (03PS8) 10Mooeypoo: Clean up the pagination in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 [22:42:50] (03PS7) 10Mooeypoo: Display a message if there are no notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) [22:45:03] (03CR) 10jenkins-bot: [V: 04-1] Clean up the pagination in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 (owner: 10Mooeypoo) [22:46:31] I thought we had an "every 4 hours" for emails. Not sure if I imagined that, or we got rid of it. <---- Yes, we do (or did). I found these lines in /operations-mediawiki-config/master/wmf-config/InitialiseSettings.php [22:46:33] / The time interval in seconds between each bundle-able email notification [22:46:33] / Set to 0 to disable email bundling [22:46:33] 'wmgEchoBundleEmailInterval' => [ [22:46:33] 'default' => 14400, [22:46:33] 'test2wiki' => 300, [22:46:35] 'officewiki' => 0, [22:46:37] ], [22:47:24] and a brief explanation in https://www.mediawiki.org/wiki/Extension:Echo [22:47:57] (03CR) 10jenkins-bot: [V: 04-1] Display a message if there are no notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) (owner: 10Mooeypoo) [22:48:28] quiddity, oh, okay, so the 4 hours is the gap thing RoanKattouw and sbisson were talking about, not the preference-based bundling. [22:48:40] No, that's different [22:48:44] (Will explain in aminute) [22:49:13] batching and bundling buffalos. [22:49:39] (if only he was sbison...) [22:52:54] haha [22:53:11] So the thing I was talking about that Stephane found was for the following case, and the following case only: [22:53:44] Suppose your email interval is 0, so you have not enabled email bundling by time period, the setting says "receive emails immediately" or something) [22:54:28] Right [22:54:30] Then three events happen that could all be bundled together (e.g. three topics are created on the same Flow board that you watch). Call them A, B and C. [22:54:54] A happens at time T, B at T+60, and C at T+120 (i.e. there's a minute between each) [22:55:05] And for good measure let's add D at T+600 [22:55:59] What happened with the old system was this: [22:56:09] * You receive an email about A at time T (so immediately) [22:56:22] * When B happens at T+60, you do not receive an email immediately [22:56:31] * When C happens at T+120 you also do not receive an email immediately [22:56:53] * At T+300 (or T+360, it's unclear), you receive an email about A+B+C ("3 new topics created on Talk:Blah") [22:57:02] * When D happens at T+600 you receive an email immediately [22:57:04] about just D [22:57:36] RoanKattouw, how long does it wait after B before deciding, "Okay, no C is forthcoming, time to send it"? [22:57:44] 4 minutes IIRC [22:58:04] From what I understand, it sends A immediately but then starts a 4-minute clock [22:58:16] RoanKattouw, and that's not related to wgEchoBundleEmailInterval? [22:58:52] (Which is now totally unused, BTW) [22:58:53] I think that might be it yes [22:59:12] Oh, that's what I was saying before. [22:59:19] So yeah after A it sends a 4-minute clock, and if B arrives within that 4-minute interval it starts a new 4-minute clock, until it runs out, then sends everything it's accumulated [22:59:30] Including A, which is weird, because it's already told you about A [22:59:46] But that's 4 *minutes*, not 4 *hours*, AIUI [23:00:10] Then again I have like second- or third-hand knowledge about this so I may well have that wrong [23:00:33] Well, 14400 seconds is 4 hours. In Echo.php wgEchoBundleEmailInterval is just 0 (disabled). [23:04:31] Wow, 4 hours [23:04:37] That's a long time to not send an email notification [23:06:11] (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.4) - 10https://gerrit.wikimedia.org/r/291962 (https://phabricator.wikimedia.org/T136572) (owner: 10Catrope) [23:09:06] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor: Copy/pasting a link to a page (except user page) on Flow sometimes can't be pasted (invalid/blacklisted HTML?) - https://phabricator.wikimedia.org/T135621#2343185 (10Catrope) >>! In T135621#2306321, @Catrope wrote: > On the main bug this was split out... [23:11:55] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2343187 (10Mooeypoo) a:03Mooeypoo [23:12:56] (03PS9) 10Catrope: Clean up the pagination in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 (owner: 10Mooeypoo) [23:13:25] (03Merged) 10jenkins-bot: Adjust styling for Special:Notification items [extensions/Echo] (wmf/1.28.0-wmf.4) - 10https://gerrit.wikimedia.org/r/291962 (https://phabricator.wikimedia.org/T136572) (owner: 10Catrope) [23:13:42] (03CR) 10Catrope: [C: 032] Clean up the pagination in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 (owner: 10Mooeypoo) [23:13:51] (03PS8) 10Catrope: Display a message if there are no notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) (owner: 10Mooeypoo) [23:13:56] (03CR) 10Catrope: [C: 032] Display a message if there are no notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) (owner: 10Mooeypoo) [23:18:11] 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] On Flow pages VE hangs when attempting to 'Save changes' after clearing links via Link inspector - https://phabricator.wikimedia.org/T136654#2343204 (10Etonkovidova) [23:18:55] (03CR) 10Matthias Mullie: Unread pages API (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291351 (owner: 10Matthias Mullie) [23:20:46] (03CR) 10Catrope: Unread pages API (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291351 (owner: 10Matthias Mullie) [23:22:42] (03Merged) 10jenkins-bot: Clean up the pagination in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291348 (owner: 10Mooeypoo) [23:22:45] (03Merged) 10jenkins-bot: Display a message if there are no notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/291851 (https://phabricator.wikimedia.org/T136586) (owner: 10Mooeypoo) [23:24:12] (I'm out for a bit to do errands, bbl) [23:40:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2343267 (10Pginer-WMF) [23:41:29] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07WorkType-NewFunctionality: Improve notification read/unread controls and make status indication more clear - https://phabricator.wikimedia.org/T126214#2007634 (10Pginer-WMF) I provided some more details in the ticket description about the size, color, states,... [23:47:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Adjust notification page separation between groups - https://phabricator.wikimedia.org/T136580#2339629 (10Etonkovidova) Presently Notifications page has tiny misalignment between buttons - will be adjusted later when other improvements to th... [23:55:28] RoanKattouw, mooeypoo, hhvm merged my html_entity_decode fix. :) [23:57:58] ooh! [23:58:25] Yay! [23:58:33] That only took how many months? [23:59:52] ok we're going to head off... see you tomorrow!