[00:03:51] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [00:20:16] RoanKattouw, is there already a schema change patch I should amend/consolidate my change into, or should I make a new one? [00:21:14] There is one but I do think you should make a new one [00:21:43] So that in terms of Gerrit patches, each schema change is grouped together with the code it's logically connected to [00:22:35] I'm halfway through writing the DBA ticket in which I already need to link to half a dozen diffs [00:31:07] (03PS33) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [00:35:03] (03CR) 10jenkins-bot: [V: 04-1] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [00:45:59] (03PS1) 10Mooeypoo: Make sure to log notification impressions when badge opens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289580 [00:49:09] (03PS2) 10Mooeypoo: Make sure to log notification impressions when badge opens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289580 [01:28:16] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: Deleted wikitext Talk page cannot be restored after EnableFlow creates the same page - https://phabricator.wikimedia.org/T104591#2307634 (10Mattflaschen) @matthiasmullie and I think that this should be allowed (but hand... [01:28:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: Deleted wikitext Talk page cannot be restored after EnableFlow creates the same page - https://phabricator.wikimedia.org/T104591#2307635 (10Mattflaschen) The restriction put in place was also causing false positives. [01:33:55] matt_flaschen: Could you upload a WIP version of your seentime patch, or anything really that contains a .sql file with the ALTER TABLE for that change? (If you have it lying around already) [01:34:05] Cause then I can submit the phab task for the schema changes [01:34:28] RoanKattouw, yeah. [01:42:12] (03CR) 10Catrope: [V: 031] "Works fine in testing, but I did notice that the front-end doesn't deal all that well with bundles splitting up when they're marked read. " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [01:45:47] (03PS1) 10Mattflaschen: Add notification_seen column to mark whether user saw that notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289583 (https://phabricator.wikimedia.org/T135661) [01:46:02] ^ RoanKattouw [01:46:11] Thanks [01:47:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Schema change for per-notification seen-ness - https://phabricator.wikimedia.org/T135661#2307649 (10Mattflaschen) @Catrope said we should wait until the schema change is deployed to merge it. [01:47:58] 03Collab-Team-2016-Apr-Jun-Q4, 10DBA, 07Blocked-on-schema-change: Schema changes for Echo moderation - https://phabricator.wikimedia.org/T135699#2307651 (10Catrope) [01:48:43] Taking a break [02:16:05] (03CR) 10jenkins-bot: [V: 04-1] Add notification_seen column to mark whether user saw that notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289583 (https://phabricator.wikimedia.org/T135661) (owner: 10Mattflaschen) [02:34:13] (03CR) 10Mattflaschen: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289583 (https://phabricator.wikimedia.org/T135661) (owner: 10Mattflaschen) [03:47:15] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2307723 (10eranroz) 1. In hewiki that sidebar still appears as bold in Special:Notifications in my account ("User:ערן" ) 2. I wanted to gr... [05:01:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests: Enable Flow on fr Wikivoyage in Beta Feature - https://phabricator.wikimedia.org/T135702#2307753 (10Archi38) [07:32:49] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor: Copy/pasting a link to a page (except user page) on Flow has an unexpected behavior - https://phabricator.wikimedia.org/T135621#2307931 (10Trizek-WMF) I've tried with: # links already included on some topics (quoting) -> Works # on a Topic, with the... [07:40:07] 10Flow: Impossible to load "Browse topics" list and reach a topic on Flow - https://phabricator.wikimedia.org/T135708#2307935 (10Trizek-WMF) [07:55:51] 10Flow: Mark a discussion as resolved shouldn't impact the "recent activities" list on a Flow board - https://phabricator.wikimedia.org/T135709#2307956 (10Trizek-WMF) [08:52:10] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to psuedo-column being queried - https://phabricator.wikimedia.org/T121644#2308056 (10jcrespo) ``` { "_index": "logstash-2016.05.19", "_type": "mediawiki", "_id": "AVTIL9cMDxp7yus2XfK0", "_... [09:28:55] 03Collab-Team-2016-Apr-Jun-Q4, 10DBA, 07Blocked-on-schema-change, 07Schema-change: Schema changes for Echo moderation - https://phabricator.wikimedia.org/T135699#2308135 (10Danny_B) [09:29:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10DBA, 07Blocked-on-schema-change, 07Schema-change: Schema changes for Echo moderation - https://phabricator.wikimedia.org/T135699#2307651 (10Danny_B) [09:58:01] 03Collab-Team-2016-Apr-Jun-Q4, 06Collaboration-Team-Interested, 10Flow, 10Wikimedia-Site-requests: Enable Flow on fr Wikivoyage as a Beta Feature - https://phabricator.wikimedia.org/T135702#2308194 (10Trizek-WMF) [10:19:44] (03PS2) 10Sbisson: Build lego message for HTML email footer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289552 [10:28:46] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor: Copy/pasting links on Flow has multiple unexpected behaviors - https://phabricator.wikimedia.org/T135126#2308271 (10Jdforrester-WMF) [10:28:48] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): VE won't recognise tags on paste - https://phabricator.wikimedia.org/T135620#2304760 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [10:31:34] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor, 13Patch-For-Review: Clear links created by copy/pasting on Flow have an unexpected behavior - https://phabricator.wikimedia.org/T135622#2304795 (10Jdforrester-WMF) a:03Esanders [10:36:59] (03PS5) 10Sbisson: Pagination on no-js Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289063 (https://phabricator.wikimedia.org/T129169) [10:37:26] (03CR) 10Sbisson: Pagination on no-js Special:Notifications (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289063 (https://phabricator.wikimedia.org/T129169) (owner: 10Sbisson) [10:38:12] (03CR) 10Sbisson: Build lego message for HTML email footer (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289552 (owner: 10Sbisson) [10:40:29] (03CR) 10jenkins-bot: [V: 04-1] Pagination on no-js Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289063 (https://phabricator.wikimedia.org/T129169) (owner: 10Sbisson) [10:46:18] (03PS6) 10Sbisson: Pagination on no-js Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289063 (https://phabricator.wikimedia.org/T129169) [11:11:32] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#2308414 (10Elitre) [11:36:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#2308432 (10jcrespo) Sorry, I think my comment got lost, and I only lost the error. I meant that I saw a small, but noticea... [12:03:52] (03PS1) 10Matthias Mullie: Fix class name in PHPDoc [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289641 [12:04:37] (03CR) 10Matthias Mullie: [C: 032] Fix class name in PHPDoc [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289641 (owner: 10Matthias Mullie) [12:21:20] (03CR) 10Sbisson: Dynamic bundles (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [12:40:48] (03Merged) 10jenkins-bot: Fix class name in PHPDoc [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289641 (owner: 10Matthias Mullie) [12:54:18] 06Collaboration-Team-Interested, 10Notifications: EchoDiscussionParserTest fails sometimes when run with proposed new DB test infrastructure. - https://phabricator.wikimedia.org/T131178#2308696 (10daniel) Another occurrance: ``` 18:03:38 1) ApiEchoMarkReadTest::testMarkReadWithList 18:03:38 MWException: CAS u... [13:07:00] (03PS1) 10Daniel Kinzler: Disable CAS check when saving User settings in tests. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289651 (https://phabricator.wikimedia.org/T131178) [13:12:31] (03CR) 10jenkins-bot: [V: 04-1] Disable CAS check when saving User settings in tests. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289651 (https://phabricator.wikimedia.org/T131178) (owner: 10Daniel Kinzler) [13:29:54] (03CR) 10Daniel Kinzler: "Hm... this patch was supposed to avoid the CAS failures, but it seems to trigger them always? What gives??" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289651 (https://phabricator.wikimedia.org/T131178) (owner: 10Daniel Kinzler) [13:33:00] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor, 13Patch-For-Review, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): Clear links created by copy/pasting on Flow have an unexpected behavior - https://phabricator.wikimedia.org/T135622#2308906 (10Jdforrester-WMF) [13:33:20] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor: Copy/pasting links on Flow has multiple unexpected behaviors - https://phabricator.wikimedia.org/T135126#2308910 (10Jdforrester-WMF) [13:33:22] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor, 13Patch-For-Review, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): Clear links created by copy/pasting on Flow have an unexpected behavior - https://phabricator.wikimedia.org/T135622#2304795 (10Jdforrester-WMF) 05Open>03Resolved [13:59:20] 10Flow, 10Parsoid: #tag:syntaxhighlight is not interpreted in Flow - https://phabricator.wikimedia.org/T135735#2309027 (10Trizek-WMF) [14:15:20] (03PS30) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [14:46:58] (03PS1) 10Matthias Mullie: More reliable post sorting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289663 (https://phabricator.wikimedia.org/T119509) [15:23:09] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2309431 (10Trizek-WMF) That task has been slowed down due to an important workflow on my... [15:23:29] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2309432 (10Trizek-WMF) That task has been slowed down due to an important workflow on my side.... [16:42:24] matt_flaschen, you might have thoughts on the GettingStarted item in https://lists.wikimedia.org/pipermail/engineering/2016-May/000197.html [16:44:29] quiddity, I'm not sure why I was removed. I am listed at https://phabricator.wikimedia.org/T128190 . [16:59:48] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Add excerpt to edit-user-talk messages - https://phabricator.wikimedia.org/T135049#2286835 (10SBisson) >>! In T135049#2299590, @jmatazzoni wrote: > The **thing we should fix** is this: > - the edit-user-talk message should have an excerpt. Sometimes it does,... [17:44:27] (03PS34) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [17:44:39] (03PS35) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [17:48:41] (03CR) 10jenkins-bot: [V: 04-1] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [18:01:06] (03PS36) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [18:01:10] mooeypoo: let me know when ^ is ready for review [18:03:36] stephanebisson, it is, I just rebased and cleaned up stuff. I think it's ready -- I was tentatively planning to split it up, though.... there are a couple of fixes inside that commit that can go out to their own thing. For instance, I added "discard" event instead of "remove" (for when we get rid of notifications from a list, for instance on "read" for xwiki) because "remove" is also used in "move" events, so it's not trustworthy [18:03:38] (03CR) 10Catrope: [C: 032] More reliable post sorting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289663 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [18:03:49] but that change is not *specifically* for the special page, so I can split it out [18:04:51] stephanebisson, if I change anything, it'll be to split stuff, so if you want to start looking at this before I do the split, it's ready. Otherwise, I'll let you know after. [18:23:12] (03CR) 10Catrope: Dynamic bundles (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [18:34:35] (03CR) 10jenkins-bot: [V: 04-1] More reliable post sorting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289663 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [18:38:02] (03PS37) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [18:46:05] (03CR) 10Catrope: [C: 04-1] "With the pagination controls on top, there's now a large gap between the pagination controls and the rest of the page, because of two 30px" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289063 (https://phabricator.wikimedia.org/T129169) (owner: 10Sbisson) [18:47:07] (03CR) 10Catrope: [C: 032] Build lego message for HTML email footer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289552 (owner: 10Sbisson) [18:49:25] 03Collab-Team-2016-Apr-Jun-Q4, 10MediaWiki-General-or-Unknown: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2310162 (10Mattflaschen) [18:49:57] 03Collab-Team-2016-Apr-Jun-Q4, 10MediaWiki-General-or-Unknown: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#1931581 (10Mattflaschen) [18:50:00] 06Collaboration-Team-Interested, 10Flow, 10MediaWiki-extensions-PageCuration: PageTriage does not support Flow - https://phabricator.wikimedia.org/T85030#2310163 (10Mattflaschen) [18:51:52] 06Collaboration-Team-Interested, 10Flow, 10SyntaxHighlight: Flow: syntax highlighting tags (GeSHi) don't get styled - https://phabricator.wikimedia.org/T59159#2310168 (10Mattflaschen) [18:54:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Add excerpt to edit-user-talk messages - https://phabricator.wikimedia.org/T135049#2310170 (10jmatazzoni) @Etonkovidova, can you help Stephane here: > I would like to know what was the edit for the first screenshot and what we would expect as the excerpt. [19:00:27] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2310189 (10jmatazzoni) @Catrope, this was resolved on the 15th and @eranroz reported it again on the 18th. Is this because the fix wasn't... [19:06:25] (03Merged) 10jenkins-bot: Build lego message for HTML email footer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289552 (owner: 10Sbisson) [19:07:11] (03PS31) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [19:13:38] RoanKattouw, is it normal for MediaWiki to reuse page IDs for unconnected pages, after you delete the old one using it? [19:14:29] (03PS7) 10Sbisson: Pagination on no-js Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289063 (https://phabricator.wikimedia.org/T129169) [19:22:03] (03PS8) 10Sbisson: Pagination on no-js Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289063 (https://phabricator.wikimedia.org/T129169) [19:22:16] RoanKattouw, I guess so. I thought auto_increment would give you the next int that had never been used, but apparently on server restart it only checks the current max, and doesn't remember the history: http://dev.mysql.com/doc/refman/5.7/en/innodb-auto-increment-handling.html#innodb-auto-increment-initialization [19:24:50] (03CR) 10Sbisson: "I've tried to normalize at about 20px around the nav bar." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289063 (https://phabricator.wikimedia.org/T129169) (owner: 10Sbisson) [19:27:14] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Change current no-JS Special:Notifications to use core Pager - https://phabricator.wikimedia.org/T129169#2310244 (10SBisson) @Pginer-WMF What do you think of the general position of the pagination controls? Btw, these are from co... [19:36:24] (03CR) 10Sbisson: [C: 04-1] "I always get" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289580 (owner: 10Mooeypoo) [19:55:29] (03PS38) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [20:02:07] 10Flow: Flow ignores oldid parameter - https://phabricator.wikimedia.org/T135765#2310352 (10Mattflaschen) [20:02:16] 10Flow: Flow ignores oldid parameter - https://phabricator.wikimedia.org/T135765#2310364 (10Mattflaschen) p:05Triage>03Low [20:09:05] (03PS3) 10Mooeypoo: Make sure to log notification impressions when badge opens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289580 [20:09:09] stephanebisson, oops, fixed ^^ [20:09:31] thanks [20:25:11] (03PS39) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [20:27:00] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Parsoid, 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): [betalabs] "Request to parsoid for 'wikitext' to 'html' conversion failed" for for any edits - https://phabricator.wikimedia.org/T135268#2310426 (10Etonkovidova) No parsoid errors in betalabs. @... [20:34:39] RoanKattouw, I am so confused every time... when I do "git reset HEAD^ -p file" and I get chunks... when I look at a snippet, and I need it to be in the new sub-commit that I'm making, do I answer "y" or "n" to split it out? [20:34:41] it's so confusing [20:34:50] I remember one is straight forward "y" and the other isn't, I think reset is backwards [20:43:13] mooeypoo, you say 'n', since you don't want to go back to that old commit's version. [20:43:48] At least that's how it works on my git (2.1.4). It says, "Apply this hunk to index", which you don't want to do if the hunk is removing your new change. [20:44:01] (03PS1) 10Mooeypoo: Add style to the NotificationsWrapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289732 [20:44:23] (03PS40) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [20:44:36] mooeypoo, if you mean the snippet is something you wrote that's not in the old commit. [20:44:54] matt_flaschen, yeah, I meant split out that snippet -- apparently that's a "y" [20:50:48] (03PS41) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [20:50:51] (03PS1) 10Mooeypoo: Allow for overriding parameters in fetch notifications API request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289733 [20:52:14] (03CR) 10Sbisson: "The error is gone but I don't see any outgoing calls about notifications impression or anything other than the usual (fetch, get count, ma" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289580 (owner: 10Mooeypoo) [20:57:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Add excerpt to edit-user-talk messages - https://phabricator.wikimedia.org/T135049#2310587 (10Etonkovidova) @jmatazzoni - I created this ticket to summarize the discrepancies which are not exactly bugs. @SBisson - yes, it looks trickier than I thought. >The... [20:57:21] matt_flaschen: Interesting! I didn't think page ID reuse could happen [20:57:40] And I thought that the auto_increment ID was part of the table since it appears when you export the table or use SHOW CREATE TABLE [20:58:12] (03PS42) 10Mooeypoo: Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [20:58:15] (03PS1) 10Mooeypoo: Generalize the SubGroupListWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289738 [21:00:24] RoanKattouw, yeah, it almost makes UUIDs appealing. *Almost*. The CREATE TABLE statement does specify where it starts, but it isn't remembered on disk. [21:00:32] matt_flaschen, I split the commit and it seems successful.. does that mean it has splat successfully? [21:00:39] %#$^%@#$% UUIDs [21:00:41] matt_flaschen, for the record, if that word doesn't exist in that context, it SHOULD [21:01:24] (03CR) 10Catrope: [C: 032] Actually use old revision on header diffs, if specified [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289111 (https://phabricator.wikimedia.org/T135136) (owner: 10Mattflaschen) [21:01:33] mooeypoo, it sounds suitably old-english. [21:01:50] mooeypoo, I'm not sure, since I normally don't use that approach (I tend to use stash and checkout -p, rebase --onto, mostly), and I was wrong before, so either our git is different or I misunderstood what you were trying to do. [21:01:51] matt_flaschen, same with "that shirt fat yesterday." [21:01:53] English. [21:02:09] mooeypoo, says the person whose language has vowels optional. ;) [21:02:13] * RoanKattouw mooeypoo: https://gerrit.wikimedia.org/r/288940 [21:02:21] sit sat, fit fat. [21:02:35] Did you see the one about the 12 ways to pronounce ough? [21:02:42] matt_flaschen, at least Hebrew consistently confusing. [21:03:08] ... nough ? [21:04:13] cough, tough, though, and many more! http://www.dictionary.com/slideshows/ough Last one of those I saw one was kinda bogus but there are 10 or so real ones. [21:04:37] matt_flaschen, oy vey [21:07:24] RoanKattouw, jdlrobson https://gerrit.wikimedia.org/r/#/c/286259/ <-- adjusting MobileFrontend to the new Echo MVC... this should be merged before next week's train [21:07:27] sorry for the rush [21:08:41] (03Merged) 10jenkins-bot: Actually use old revision on header diffs, if specified [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289111 (https://phabricator.wikimedia.org/T135136) (owner: 10Mattflaschen) [21:11:52] 03Collab-Team-2016-Apr-Jun-Q4, 10MediaWiki-Change-tagging, 10MediaWiki-Revision-deletion, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined property in revision delete for archived rows - https://phabricator.wikimedia.org/T128980#2310697 (10Mattflaschen) [21:38:01] (03PS3) 10Mattflaschen: Use ArticleRevisionUndeleted instead of ArticleUndelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289239 (https://phabricator.wikimedia.org/T122262) [21:42:18] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#2310857 (10Mattflaschen) This is ready for review now. I tested the test plans listed at T122261, plus some other stuff I thought of along the way. --- The onl... [21:43:31] (03CR) 10Mattflaschen: "This is ready for review now. See T122262." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289239 (https://phabricator.wikimedia.org/T122262) (owner: 10Mattflaschen) [21:47:25] 10Flow: Impossible to load "Browse topics" list and reach a topic on Flow - https://phabricator.wikimedia.org/T135708#2307935 (10Mattflaschen) Can not reproduce. Is it happening for anyone else? For me, it took a few seconds, but worked, logged in or out. [21:47:34] 06Collaboration-Team-Interested, 10Flow: Impossible to load "Browse topics" list and reach a topic on Flow - https://phabricator.wikimedia.org/T135708#2310891 (10Mattflaschen) [21:50:29] 06Collaboration-Team-Interested, 10Flow: Mark a discussion as resolved shouldn't impact the "recent activities" list on a Flow board - https://phabricator.wikimedia.org/T135709#2310930 (10Mattflaschen) If changing this, need to check if it impacts internal uses of the update field, e.g. {T119509} or something... [21:52:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#2310965 (10Mattflaschen) Probably will be fixed as part of {T120009} [21:56:06] matt_flaschen, if I have rules to load an extension in vagrant/settings.d/99-LocalSettings.php does that affect all wikis? [21:56:55] (03CR) 10Mattflaschen: "I thought about it a bit, and decided to default it to 0, because I think it should eventually be non-nullable, it seemed better not to ha" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289583 (https://phabricator.wikimedia.org/T135661) (owner: 10Mattflaschen) [22:00:14] 10Flow, 10Parsoid: #tag:syntaxhighlight is not interpreted in Flow - https://phabricator.wikimedia.org/T135735#2309027 (10Mattflaschen) You used #tag:syntaxhighlight rather than ? I think it's the same either way. It is interpreted, but needs to be styled. [22:00:29] 10Flow, 10Parsoid: #tag:syntaxhighlight is not interpreted in Flow - https://phabricator.wikimedia.org/T135735#2310977 (10Mattflaschen) [22:01:31] (03CR) 10Mattflaschen: [C: 032] "Per Catrope" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289663 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [22:04:38] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2155245 (10Mattflaschen) It was merged April 13, and he reported it Wednesday (May 18), so it's not just deployment train lag. [22:05:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Add excerpt to edit-user-talk messages - https://phabricator.wikimedia.org/T135049#2311008 (10jmatazzoni) We're talking about an edit-user-talk message here, right? I thought all the excerpts simply gave the beginning of the relevant post? (Rather than trying t... [22:06:02] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Parsoid, 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): [betalabs] "Request to parsoid for 'wikitext' to 'html' conversion failed" for for any edits - https://phabricator.wikimedia.org/T135268#2311026 (10Mattflaschen) Please file separately. It is no... [22:07:27] mooeypoo, yes. If you want it only for one wiki, you can do that with settings.d/wikis/whichwikiiwant [22:09:29] matt_flaschen, hm.... so, I added an extension, with wfLoadExtension( ... ) and it works on dev but not on hewiki [22:10:02] (03Merged) 10jenkins-bot: More reliable post sorting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289663 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [22:10:30] mooeypoo, that's weird. I will double-check but that is definitely how it should work. [22:11:36] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2311049 (10jmatazzoni) 05Resolved>03Open Matt says: > so it's not just deployment train lag. I'll move this to QA to see if @Etonkov... [22:13:23] mooeypoo, I confirmed that's how it works for me (moved 10-ParserFunctions.php from puppet-managed to the manual settings.d folder you mentioned, and it works on hewiki). [22:13:39] yeah i just saw it in my Special:Versions [22:13:52] the extension doesn't load in hebrew for me, but it hink it might be the extension itself [22:27:41] (03PS1) 10Mattflaschen: NewTopicWidget: Show page title with spaces, not underscores. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289783 [23:40:50] matt_flaschen, mooeypoo, also http://www.amazon.com/Tough-Coughs-Ploughs-Dough-Writings/dp/0688065481/ [23:42:24] Heading out, have a good night. [23:54:24] quiddity, .. that is so unhelpful for an ESL person :\ [23:55:29] it's a good book, though! ("though, through thorough thought, [...]", is my personal favourite. I try to slip it in various places)