[00:12:25] 10Flow, 03Collab-Archive-2015-2016: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#2299624 (10Mattflaschen) a:05matthiasmullie>03Mattflaschen [00:50:23] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core: Community bonding evaluation for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133666#2299656 (10jayvdb) [00:56:05] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 03Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2299661 (10jayvdb) >>! In T130585#2268954, @Mattflaschen wrote: >> Each time a user is thanked, a record... [01:01:10] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Thanks: Bundle "Thanks" notifications - https://phabricator.wikimedia.org/T120152#2299680 (10jmatazzoni) **GRANULARITY: ** After some discussion, the decision is to a) make thanks bundling expandable and b) bundle at the level of individual edits. (I.e., inst... [01:10:20] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [01:10:56] (03CR) 10jenkins-bot: [V: 04-1] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [01:14:00] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 03Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2299692 (10jayvdb) For the Mid-term evaluation... > Have the MVP of the project ready on a Labs instance... [01:40:51] Have a good night, all [02:18:43] 10Flow: Timestamps are in English on nowiki - https://phabricator.wikimedia.org/T135462#2299733 (10jeblad) [02:38:20] ^ is that a CLDR problem, or something at our end? (https://phabricator.wikimedia.org/T135462) [02:38:34] 10Flow, 07I18n: Timestamps are in English on nowiki - https://phabricator.wikimedia.org/T135462#2299753 (10Quiddity) [02:39:48] quiddity: it's probably Moment.js [02:40:07] ah, that's the one I always forget about. [02:42:23] arg, what a lot of options! https://www.mediawiki.org/wiki/Globalize [02:44:44] hmm [02:45:17] quiddity: i think RoanKattouw broke it with https://gerrit.wikimedia.org/r/#/c/281198/ :( [02:45:54] moment.locale() not only defines the locale, it also sets it. so the moment.locale( 'en', … ) at the top sets the locale to English regardless of everything else [03:33:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07I18n, 13Patch-For-Review, and 2 others: Unsubstituted message footer in mail notification of thanks - https://phabricator.wikimedia.org/T135446#2299796 (10jayvdb) [04:07:43] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07I18n, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1), 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Unsubstituted message footer in mail notification of thanks - https://phabricator.wikimedia.org/T135446#2299821 (10TerraCodes) [04:36:16] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Analytics, 06Editing-Analysis: Numerous Notification Tracking Graphs Stopped Working at End of 2015 - https://phabricator.wikimedia.org/T132116#2299871 (10Nuria) Actually from what I can see ( @milimetric please correct me if I am wrong) these metrics are... [04:39:53] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 05WMF-deploy-2016-05-03_(1.27.0-wmf.23): Add topic button disabled - https://phabricator.wikimedia.org/T134060#2299874 (10TerraCodes) [06:08:49] (03PS6) 10Amire80: WIP: Move apihelp to a separate file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289064 [06:11:05] (03PS7) 10Amire80: Move apihelp to a separate file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289064 (https://phabricator.wikimedia.org/T93162) [08:57:12] 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 07Wikimedia-log-errors: Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable given - https://phabricator.wikimedia.org/T135477#2300334 (10Florian) p:05Triage>03High a:03Florian [09:02:19] (03PS1) 10Florianschmidtwelzow: Fix Flow for AuthManager-changes in ConfirmEdit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289155 (https://phabricator.wikimedia.org/T135477) [09:02:39] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Notifications page - the cog and 'more info' icons disappeared - https://phabricator.wikimedia.org/T135192#2300378 (10Pginer-WMF) >>! In T135192#2299102, @jmatazzoni wrote: > @Pginer-WMF , this functionality is all accounted for in your new... [09:32:35] (03CR) 10Gergő Tisza: [C: 032] "Thanks Florian!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289155 (https://phabricator.wikimedia.org/T135477) (owner: 10Florianschmidtwelzow) [09:33:37] 06Collaboration-Team-Interested, 10Flow: Fix cause of duplicate "has been archived" messages - https://phabricator.wikimedia.org/T119592#2300531 (10matthiasmullie) The duplicate messages can no longer occur since https://gerrit.wikimedia.org/r/#q,I6b9326f41a77032a9baf57e7ba673b7534a4fe7e,n,z [09:41:45] (03Merged) 10jenkins-bot: Fix Flow for AuthManager-changes in ConfirmEdit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289155 (https://phabricator.wikimedia.org/T135477) (owner: 10Florianschmidtwelzow) [09:51:02] (03PS1) 10Gergő Tisza: Fix Flow for AuthManager-changes in ConfirmEdit [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/289159 (https://phabricator.wikimedia.org/T135477) [09:52:02] 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 13Patch-For-Review, 07Wikimedia-log-errors: Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable given - https://phabricator.wikimedia.org/T135477#2300561 (10Tgr) 05Open>03Resolved Tried... [10:51:20] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2300738 (10Pginer-WMF) >>! In T132975#2298757, @jmatazzoni wrote: > **#1, LANGUAGE** -- I have a few clarifications and comment... [11:04:33] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2300766 (10Pginer-WMF) >>! In T132975#2298961, @jmatazzoni wrote: > **#2, WHAT MESSAGES GET WHICH OPTION?** The list of actions... [11:08:18] (03CR) 10Gergő Tisza: [C: 032] Fix Flow for AuthManager-changes in ConfirmEdit [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/289159 (https://phabricator.wikimedia.org/T135477) (owner: 10Gergő Tisza) [11:25:07] (03Merged) 10jenkins-bot: Fix Flow for AuthManager-changes in ConfirmEdit [extensions/Flow] (REL1_27) - 10https://gerrit.wikimedia.org/r/289159 (https://phabricator.wikimedia.org/T135477) (owner: 10Gergő Tisza) [11:51:27] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2300850 (10Pginer-WMF) >>! In T132975#2298971, @jmatazzoni wrote: > **#3, CONFIRMATION MESSAGE STYLE** > @Pginer-WMF suggests us... [14:37:56] (03PS1) 10Sbisson: Bring back messages used by old email formatter system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289217 (https://phabricator.wikimedia.org/T135446) [14:41:13] mlitn, I'm looking at switching from ArticleUndelete to ArticleRevisionUndeleted for Flow. Have a couple minutes to discuss? [14:41:30] matt_flaschen: sure [14:42:23] I haven't tested all the scenarios yet, but I think this will better handle undeleting multiple revisions at a time. [14:43:19] E.g. if the page is currently wikitext, then you undelete both a Flow and a wikitext revision. I think right now it would go through fine (since both "before content model" and "end content model" are wikitext), but then the Flow revision would get the new page ID only in the revision table (but not workflow), and be in inconsistent state. [14:43:53] (03PS1) 10Sbisson: HTML email footer shows raw HTML [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289219 [14:44:00] I haven't tested that one yet, but I found a different bug with "create wikitext"->"delete wikitext"->"create Flow"->"delete Flow"->"undelete wikitext"->"undelete Flow". [14:44:08] mlitn, so I was wondering two things: [14:44:21] * Do you know if anyone looked at ArticleRevisionUndeleted? [14:44:53] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07I18n, 13Patch-For-Review, and 2 others: Unsubstituted message footer in mail notification of thanks - https://phabricator.wikimedia.org/T135446#2301260 (10SBisson) There's a code path that still uses the old formatter system. This patch brings back the me... [14:45:00] * Do you think we really need the " Block undeleting an article over an existing Flow board" (which is now triggering false positives for me) or can we just allow anything as long as it does the right thing? [14:46:36] I don’t think anyone looked at ArticleRevisionUndeleted [14:46:53] If we use ArticleRevisionUndeleted, I guess we can just block undeleting any wikitext revision if the title is Flow (the title content model doesn't get updated until the end). [14:47:11] or rather: I don’t think anyone but me looked at undeletion in that much detail, and I can’t remember any reason for not using that particular hook [14:47:27] except for maybe not having done $dbw->delete( 'archive' ) yet - IDK if we need that [14:48:33] Though it would be better to hide the revisions up front and show a message something, if we need that "no wikitext on top of Flow" restriction at all. [14:49:08] I don’t think we need the “block undeleting over existing flow board” [14:49:15] I don't think we care if it's in the archive table, as long as we know the old page ID and new page ID, which we have by then. [14:49:22] that was just a quick way of avoiding corruption [14:49:31] where both a wikitext & flow board would have the same page [14:49:42] mlitn, okay, cool. I'll put this up, then we can all try to break it. [14:49:44] so as long as we implement that correctly, we shouldn’t have to block it [14:49:50] sounds good [14:50:06] IIRC, you once posted a lot of scenarios to test [14:51:27] mlitn, oh yeah: https://phabricator.wikimedia.org/T122261 [14:52:30] 10Flow, 03Collab-Archive-2015-2016: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#2301298 (10Mattflaschen) [14:55:43] mlitn, currently the scenario I just added to T122261 fails with an inconsistent state (e.g. uneditable board header), since it doesn't recognize you undeleted a Flow revision, since previously it was wikitext and getContentModel doesn't return the right value. [14:55:44] T122261: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261 [14:56:44] With https://gerrit.wikimedia.org/r/#/c/289221/ (which I think we should do anyway) and using GAID_FOR_UPDATE, it then fails with the ID mismatch triggering the “block undeleting over existing flow board”. [14:56:53] Should be moot with the ArticleRevisionUndeleted. [15:00:32] (03PS29) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [15:15:08] (03CR) 10Paladox: "Ive now tested and this works. +1." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288874 (https://phabricator.wikimedia.org/T103702) (owner: 10Mattflaschen) [15:15:49] (03CR) 10Paladox: "Could this be merged without the dependant patch or is it required. And can we backport this to mediawiki 1.27 and 1.26. and possibly 1.23" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288874 (https://phabricator.wikimedia.org/T103702) (owner: 10Mattflaschen) [16:30:02] (03CR) 10Catrope: [C: 032] Bring back messages used by old email formatter system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289217 (https://phabricator.wikimedia.org/T135446) (owner: 10Sbisson) [16:36:51] (03Merged) 10jenkins-bot: Bring back messages used by old email formatter system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289217 (https://phabricator.wikimedia.org/T135446) (owner: 10Sbisson) [16:37:37] (03CR) 10Mattflaschen: "The dependent patch is only for testing. It doesn't have to be backported necessarily." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288874 (https://phabricator.wikimedia.org/T103702) (owner: 10Mattflaschen) [16:43:11] (03PS1) 10Mattflaschen: WIP: Use ArticleRevisionUndeleted instead of ArticleUndelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289239 (https://phabricator.wikimedia.org/T122262) [16:49:08] 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2), 07Wikimedia-log-errors: Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable gi... - https://phabricator.wikimedia.org/T135477#2301615 [16:59:04] matt_flaschen: I would like to set $wgEchoBundleEmailInterval with the Echo role in mw-vagrant. Where do you think it should go? [17:00:43] puppet/modules/role/manifests/echo.pp [17:26:08] 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2), 07Wikimedia-log-errors: Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable gi... - https://phabricator.wikimedia.org/T135477#2301845 [17:37:07] stephanebisson: FWIW I was able to reproduce in prod with just a talk page notification (unbundled) [17:37:17] I'll forward you the email I got [17:38:28] RoanKattouw: I was also able to reproduce with edit-user-talk after hacking my local config [17:39:20] RoanKattouw: do you think email bundling (not to be confused with digest) would be missed? [17:39:41] What is email bundling exactly? [17:40:48] if you are setup to received individual emails, when 2 events happen close together, they could be bundled (i.e. 2 new messages on your talk page) [17:41:25] OK so when an event happens, there is some sort of backoff (or natural delay caused by the job queue?) before the email is actually sent, and if another event occurs it gets bundled in? [17:41:46] If otherwise-bundleable events happen an hour apart, does anything magical happen? [17:41:51] it's broken, but yes, it's the idea [17:42:08] it's set to 4 minutes in prod [17:42:31] Hmm, that's kind of odd and arbitrary. [17:42:34] "it's broken" why am I not surprised [17:42:51] OK but that means notif emails are always sent 4 mins late? [17:43:22] AFAICT, you'll receive 1 email (Someone wrote on your talk page) and then another email 4 minutes later (2 new messages on your talk page) [17:43:22] And does it like check to see if the user has already read the notification on the web in that 4-minute time span? [17:43:37] Wait, what [17:43:59] So the first email is sent immediately, but then if a second event happens there's a 4-minute wait to see if perhaps a third event will happen too? [17:44:15] that looks like it [17:44:33] but then the second email, some 4 minutes later, contains both events [17:44:43] Of course it does [17:44:50] maybe that's just that part of is broken [17:44:53] And what if the second event is an hour later instead? Does it still contain both/ [17:45:19] haven't tested [17:45:29] but I don't see how it wouldn't [17:46:46] And what causes the bundle to be reset/broken? The user marking the notification as read? [17:47:26] when it is emailed, it resets [17:48:12] it is controlled by the echo_email_batch table [17:48:12] OK [17:48:20] just like digest emails [17:48:31] it's like mini-digest emails [17:48:45] So if A happens, then B shortly after, then C an hour later, then I will get an email about A at t+0, an email about A&B at t+4, and an email about just C at t+60? [17:48:57] yes [17:49:08] That makes no freaking sense [17:50:00] With that kind of behavior I find it unlikely that this "feature" will be missed [17:50:44] other crazy think is that some email types (like thanks) could be bundled without even supporting bundles [17:51:02] like the one in the bug [17:52:00] it's technically a bundled email. It reads like an individual email. I don't know how else it could be given that there's no logic or working to bundle thanks. [17:52:16] *wording [17:53:25] I talked to legoktm (who's sitting behind me today) and he says he didn't even know about this feature [17:53:43] If *he* is surprised to learn about this, I am totally comfortable killing it [17:54:13] He also said that any feature that makes notifications slower is probably a bad idea [18:12:44] (03PS2) 10Mattflaschen: WIP: Use ArticleRevisionUndeleted instead of ArticleUndelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/289239 (https://phabricator.wikimedia.org/T122262) [18:17:51] 10Flow, 03Collab-Archive-2015-2016: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#2302043 (10Mattflaschen) [18:20:14] RoanKattouw, going to do my workaround for the Flow deletion issue in production now. [18:24:11] OK [18:27:26] hm, anyone knows what the format of the 'notcontinue' means in Echo API? I get this 1463174740|660 -- that looks like a date piped with a notif ID, but I am not sure I understand how that works - is this the notif ID of the last notification, or the first in the next batch ? [18:27:56] oh, I found it [18:28:06] $nextContinue = $lastItem['timestamp']['utcunix'] . '|' . $lastItem['id']; [18:28:17] ... why do we need the last item ID O.o [18:32:58] 06Collaboration-Team-Interested, 10MobileFrontend, 10Parsoid, 10Reading-Web-Backlog: Mobile should not completely blank mediawiki.skinning.content.parsoid - https://phabricator.wikimedia.org/T93968#2302228 (10MBinder_WMF) [18:33:00] 06Collaboration-Team-Interested, 10Flow, 10MobileFrontend, 10Reading-Web-Backlog: The "All" and "Other" tabs on MobileFrontend watchlist show Flow gibberish topic ID links instead of topic titles - https://phabricator.wikimedia.org/T93565#2302229 (10MBinder_WMF) [18:33:53] mooeypoo: because timestamps aren't unique? [18:34:52] 06Collaboration-Team-Interested, 10MobileFrontend, 10Reading-Web-Backlog: Very long talk pages unreadable - https://phabricator.wikimedia.org/T116686#2302303 (10MBinder_WMF) [18:36:42] 06Collaboration-Team-Interested, 10Flow, 10MobileFrontend, 10Reading-Web-Backlog, 07I18n: wgRevisionId is 0 for Flow pages - https://phabricator.wikimedia.org/T92296#2302357 (10MBinder_WMF) [18:37:37] 06Collaboration-Team-Interested, 10Flow, 10MediaWiki-extensions-MultimediaViewer, 10Reading-Web-Backlog: Media Viewer doesn't trigger on Flow-enabled talk pages - https://phabricator.wikimedia.org/T64594#2302392 (10MBinder_WMF) [18:37:55] 06Collaboration-Team-Interested, 10Flow, 10Hovercards, 10Reading-Web-Backlog, 10TextExtracts: Good Flow experience with HoverCards and TextExtracts - https://phabricator.wikimedia.org/T107200#2302400 (10MBinder_WMF) [18:38:59] 06Collaboration-Team-Interested, 10MobileFrontend, 10Reading-Web-Backlog: mobile redirect only works on canonical URLs - https://phabricator.wikimedia.org/T72312#2302433 (10MBinder_WMF) [18:39:08] mooeypoo: pagination on the no-js page uses onky the eventId as offset, no timestamp [18:39:14] only [18:39:26] 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#2302445 (10Mattflaschen) Ran: ``` UPDATE flow_workflow SET workflow_page_id = 581614 WHERE workflow_wiki = 'mediawikiwiki' AND workflow_page_id=438062 ``` to worka... [18:39:31] stephanebisson, this is built in the special page, and is used for the "read more" button [18:39:37] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Notifications page - the cog and 'more info' icons disappeared - https://phabricator.wikimedia.org/T135192#2302459 (10jmatazzoni) [18:39:39] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 03Collab-Archive-2015-2016, 07User-notice: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2302461 (10jmatazzoni) [18:39:40] so I assume that's what we need for the API notcontinue param [18:39:42] mooeypoo: not anymore [18:40:40] stephanebisson, well, I am reading mw.config.get( 'wgEchoNextContinue' ) and I will use that value for notcontinue [18:40:55] stephanebisson, will that remain safe regardless of the value? 'cause I technically don't care what the value is, as long as it works [18:46:18] RoanKattouw, quiddity, workaround-ed in production (hopefully for the last time). [18:46:46] much thanks, matt_flaschen [18:47:15] Will test the heck out of my patch today (it's already up for you all to do the same) and hopefully we (including Elena when she gets back) can either find the bugs ahead of time or this actually fixes it this time. [18:51:32] quiddity, off the top of your head (I already searched), is there a tracking bug for Flow redirects? [18:51:42] not that i know of [18:52:36] 10Flow, 07Tracking: Flow board redirects - https://phabricator.wikimedia.org/T135538#2302509 (10Mattflaschen) [18:54:17] 06Collaboration-Team-Interested, 10Flow: Enable the checkbox to leave a redirect behind when moving a Flow Board - https://phabricator.wikimedia.org/T96631#2302539 (10Mattflaschen) [18:54:19] 06Collaboration-Team-Interested, 10Flow: Add redirect capability to Flow - https://phabricator.wikimedia.org/T102300#2302538 (10Mattflaschen) [18:54:21] 06Collaboration-Team-Interested, 10Flow: Flow: no "Redirected from" on Flow pages. - https://phabricator.wikimedia.org/T60763#2302540 (10Mattflaschen) [18:54:26] 10Flow, 07Tracking: Flow board redirects - https://phabricator.wikimedia.org/T135538#2302537 (10Mattflaschen) [18:55:29] 06Collaboration-Team-Interested, 10Flow: Flow: no "Redirected from" and mediawiki.action.view.redirect on Flow pages. - https://phabricator.wikimedia.org/T60763#645177 (10Mattflaschen) [19:18:44] 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2), 07Wikimedia-log-errors: Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable gi... - https://phabricator.wikimedia.org/T135477#2302658 [19:19:02] 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2), 07Wikimedia-log-errors: Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable gi... - https://phabricator.wikimedia.org/T135477#2302659 [19:46:40] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2302748 (10jmatazzoni) Regarding language for stop watching this page, Pau notes that > we may want to be more specific in adv... [19:50:35] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2302752 (10jmatazzoni) [19:58:41] (03PS1) 10Sbisson: Get rid of email bundling [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289266 (https://phabricator.wikimedia.org/T135446) [20:00:36] (03PS2) 10Catrope: HTML email footer shows raw HTML [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289219 (owner: 10Sbisson) [20:00:53] (03CR) 10Catrope: [C: 032] HTML email footer shows raw HTML [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289219 (owner: 10Sbisson) [20:01:08] can we get rid of the raw HTML message? [20:01:17] (03PS1) 10Catrope: Bring back messages used by old email formatter system [extensions/Echo] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289268 (https://phabricator.wikimedia.org/T135446) [20:02:04] (03CR) 10jenkins-bot: [V: 04-1] Get rid of email bundling [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289266 (https://phabricator.wikimedia.org/T135446) (owner: 10Sbisson) [20:02:05] legoktm: That would be a nice thing to do I think [20:02:06] * quiddity looks for the link about HTML email being fundamentally evil. plaintext4eva! [20:02:07] "echo-email-html-footer": "To control which emails we send you, check your preferences.
\n$1", [20:02:20] :S [20:02:27] translators should not really have to deal with that markup [20:02:29] We could split that into two messages and build the HTML in code [20:02:32] Yeah [20:02:40] 2 messages? [20:03:03] "To control which emails we send you, $1" [20:03:15] Where $1 is the link, and the other message is "check your preferences" [20:03:23] I don't think we can do this any other way, can we? [20:03:59] Also I don't really understand what $1 is doing there in the original message (it turns out to be the address of the org sending the email) [20:04:15] That should probably just be added separately in code [20:04:21] that's a little lego, but yeah, I don't see a better way to do it [20:04:28] and agreed about the address [20:04:40] Yeah the link caption stuff is lego but I don't see a better way [20:04:57] We can't make it "To control which emails we send you, [$2 check your preferences]" [20:05:17] Unless the style attributes are things we can do without [20:06:15] We probably can move the style to a style tag [20:06:25] Do those work in emails? [20:06:25] Well....I would say yes but I'm not a designer :P [20:06:28] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2302781 (10jmatazzoni) [20:07:09] A lot of stuff doesn't work in HTML email and the last time I messed with this stuff was 2008, so I've forgotten everything [20:08:09] (03Merged) 10jenkins-bot: HTML email footer shows raw HTML [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289219 (owner: 10Sbisson) [20:08:16] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2215939 (10jmatazzoni) [20:14:03] (03PS1) 10Catrope: HTML email footer shows raw HTML [extensions/Echo] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289270 [20:14:12] (03PS66) 10Catrope: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [20:14:43] I'll be back in a few minutes. [20:14:53] legoktm: ooooh you're undeploying Gather today? [20:15:01] yes! [20:17:20] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1): Mark not-yet-loaded foreign notifications as read fails - https://phabricator.wikimedia.org/T134579#2270002 (10jmatazzoni) @Etonkovidova and @SBisson, I'm not clear on the status of this ticket. Is... [20:22:25] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1): Mark not-yet-loaded foreign notifications as read fails - https://phabricator.wikimedia.org/T134579#2302859 (10SBisson) Those observations are not really related with this ticket. Here's how to test... [20:24:43] (03PS2) 10Sbisson: Get rid of email bundling [extensions/Echo] - 10https://gerrit.wikimedia.org/r/289266 (https://phabricator.wikimedia.org/T135446) [20:29:40] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1): Mark not-yet-loaded foreign notifications as read fails - https://phabricator.wikimedia.org/T134579#2302910 (10jmatazzoni) @Etonkovidova, please report the issues above in a new ticket (if you feel w... [20:29:47] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1): Mark not-yet-loaded foreign notifications as read fails - https://phabricator.wikimedia.org/T134579#2302912 (10jmatazzoni) 05Open>03Resolved [20:36:40] 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2), 07Wikimedia-log-errors: Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable gi... - https://phabricator.wikimedia.org/T135477#2300255 [20:40:39] 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2), 07Wikimedia-log-errors: Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable gi... - https://phabricator.wikimedia.org/T135477#2303005 [20:45:09] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2303028 (10jmatazzoni) Pau wrote: > Since "bubble notifications" are the standard MediaWiki component for lightweight notifica... [20:47:05] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2303034 (10jmatazzoni) [20:55:54] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 03Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2303083 (10kaldari) @jayvdb, @darthbhyrava: Thanks are linked to revisions. The revision associated with... [20:58:49] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2303087 (10Catrope) I spoke to the Privacy Badger developer and he said he's working on code to fix this general problem (not recognizing that e.g. wikipedia.org and wi... [21:01:56] 10Flow, 03Collab-Archive-2015-2016: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#2303090 (10Mattflaschen) [21:04:02] 10Flow, 03Collab-Archive-2015-2016: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#2303091 (10Mattflaschen) [21:24:37] 10Flow, 03Collab-Archive-2015-2016: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#2303144 (10Mattflaschen) Thanks, @matthiasmullie . Added variants of those scenarios to the description. [21:27:19] 10Flow, 03Collab-Archive-2015-2016: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#2303152 (10Mattflaschen) [21:32:54] (03CR) 10Catrope: [C: 04-1] Refactoring Echo's front end for MVC (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [21:38:15] (03PS67) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [21:46:57] RoanKattouw, i don't recall any Flow issues with RevDel specifically. Do you? [21:47:37] Not sure if that is because not many people tried, or it doesn't really affect it (e.g. you can't RevDel the most recent revision, which reduces impact surface). [21:48:12] There is nothing in the intersection: https://phabricator.wikimedia.org/maniphest/query/BErNRh46S70I/#R [21:48:47] quiddity, have you heard of any such bug (RevDel is "Change visibility of selected revisions")? [21:49:16] I will add a test case or two for it, but not more if we don't think it's a problem. [21:51:12] matt_flaschen, https://phabricator.wikimedia.org/T116301 ? [21:58:22] Sorry, phone call. [21:59:13] quiddity, yeah, I know about the feature requests in that area (conceptually the same thing but implemented separately within Flow). I meant bad interactions with the existing core feature. [22:01:25] 06Collaboration-Team-Interested, 10Flow: Allow revision deletion for Flow edits - https://phabricator.wikimedia.org/T116301#2303243 (10Mattflaschen) [22:01:43] 06Collaboration-Team-Interested, 10Flow: Allow revision deletion for Flow edits - https://phabricator.wikimedia.org/T116301#1745994 (10Mattflaschen) [22:01:52] 06Collaboration-Team-Interested, 10Flow: Allow revision deletion for Flow edits - https://phabricator.wikimedia.org/T116301#1745994 (10Mattflaschen) [22:06:03] 06Collaboration-Team-Interested, 10Notifications, 06Design-Research: Evaluate the designs for the Notification Page - https://phabricator.wikimedia.org/T124416#2303272 (10Capt_Swing) [22:09:38] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Epic, 07Tracking: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2303297 (10Capt_Swing) [22:23:21] 10Flow, 03Collab-Archive-2015-2016: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#2303359 (10Mattflaschen) [22:26:16] (03CR) 10Catrope: [C: 04-1] "- mw.echo.Controller#markEntireCrossWikiItemAsRead causes N+1 counter updates: each markCrossWikiItemsRead call causes a counter update, a" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [22:27:06] Heading out. See you tomorrow. [22:30:49] (03CR) 10Catrope: "- When you have an unseen notification, you have to open the popup twice before the badge stops being highlighted. While loading, the badg" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [23:10:17] (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289270 (owner: 10Catrope) [23:18:45] (03Merged) 10jenkins-bot: HTML email footer shows raw HTML [extensions/Echo] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289270 (owner: 10Catrope) [23:49:00] (03PS2) 10Dereckson: Bring back messages used by old email formatter system [extensions/Echo] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289268 (https://phabricator.wikimedia.org/T135446) (owner: 10Catrope) [23:49:08] (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Echo] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289268 (https://phabricator.wikimedia.org/T135446) (owner: 10Catrope) [23:55:42] (03Merged) 10jenkins-bot: Bring back messages used by old email formatter system [extensions/Echo] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289268 (https://phabricator.wikimedia.org/T135446) (owner: 10Catrope)