[00:00:39] (03PS1) 10Mooeypoo: [wip] Fetch notifications by read state in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288733 [00:02:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1), 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2294435 (10Catrope) This should be... [00:04:02] (03CR) 10jenkins-bot: [V: 04-1] [wip] Fetch notifications by read state in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288733 (owner: 10Mooeypoo) [00:04:05] (03PS23) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [00:05:34] WTF: [00:05:35] 2016-05-14 00:01:11 [b3c1dd29d81e5d53425ccab7] terbium cawiki 1.28.0-wmf.1 Echo ERROR: Error formatting notification {"id":"2922878","eventType":"cx-first-translation","format":"email","type":"emaildigest","user":"Lluisdetaradell","exceptionName":"MWException","exceptionMessage":"Agent is required for bundling notification!"} [00:07:27] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [00:13:27] uh, not all events have agents? [00:16:44] Oh this is coming from the old formatter system [00:16:54] So I guess once the email formatter stuff is fully done it won't be a problem [00:17:43] (03PS24) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [00:19:21] mooeypoo: Now we can do https://phabricator.wikimedia.org/T127419 :) [00:20:08] (03PS2) 10Mooeypoo: [wip] Fetch notifications by read state in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288733 [00:21:23] (03CR) 10Catrope: [C: 032] HTML email formatter using presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287078 (https://phabricator.wikimedia.org/T121067) (owner: 10Sbisson) [00:21:53] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [00:23:26] (03CR) 10jenkins-bot: [V: 04-1] [wip] Fetch notifications by read state in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288733 (owner: 10Mooeypoo) [00:23:34] Heading out. Have a good weekend. [00:24:53] you too! [00:29:33] (03Merged) 10jenkins-bot: HTML email formatter using presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287078 (https://phabricator.wikimedia.org/T121067) (owner: 10Sbisson) [00:31:32] (03CR) 10Catrope: [C: 032] Avoid exceptions when event_extra can't be unserialized [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288730 (https://phabricator.wikimedia.org/T73489) (owner: 10Legoktm) [00:36:29] (03PS1) 10Mooeypoo: Link project labels in xwiki bundle to their Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288738 (https://phabricator.wikimedia.org/T127419) [00:36:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2294480 (10Mooeypoo) a:03Mooeypoo [00:40:43] (03CR) 10Catrope: [C: 032] "This doesn't catch all cases, but it works well." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288730 (https://phabricator.wikimedia.org/T73489) (owner: 10Legoktm) [00:44:07] moving a page w/ associated flow board doesn't leave a talk page redirect behind? [00:44:55] No :( [00:45:00] Bug in ContentHandler code in core [00:45:21] The flow-board content type doesn't support redirects (i.e. you can't have a page that is of type flow-board that is a redirect) [00:45:38] Therefore, when moving a page of type flow-board, the "leave a redirect" check box is greyed out [00:45:55] Therefore, when moving the subject page, the talk page is moved without leaving a redirect [00:46:00] (03Merged) 10jenkins-bot: Avoid exceptions when event_extra can't be unserialized [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288730 (https://phabricator.wikimedia.org/T73489) (owner: 10Legoktm) [00:46:15] The first "therefore" is a fallacy, but that's how the ContentHandler code thinks about redirects right now [00:46:37] hrm [00:46:40] is there a ticket for this? [00:46:46] I think so [00:46:54] Matt would know but he left [00:47:03] * RoanKattouw looks [00:48:26] T96631 [00:48:26] T96631: Enable the checkbox to leave a redirect behind when moving a Flow Board - https://phabricator.wikimedia.org/T96631 [00:48:45] "I believe this is due to how ContentHandler handles 'ContentHandler->supportsRedirects'. A Flow board can not be a redirect, but it's fine to redirect to a Flow board. ContentHandler doesn't understand this." [00:49:20] There's also T102300 [00:49:20] T102300: Add redirect capability to Flow - https://phabricator.wikimedia.org/T102300 [00:49:39] (i.e. allow redirects from one talk page to another to be created when Flow is the default content type for that namespace) [00:49:43] 06Collaboration-Team-Interested, 10Flow: Examine the use of Elapsed vs Exact timestamps in Flow - https://phabricator.wikimedia.org/T94648#2294505 (10Quiddity) [00:49:52] Right now the workaround for this is to create the redirect as a wikitext page in a different namespace, then move it to the desired place [00:50:14] 06Collaboration-Team-Interested, 10Notifications: Switch from relative to absolute timestamps after a relevant period - https://phabricator.wikimedia.org/T129610#2294506 (10Quiddity) [00:50:16] 06Collaboration-Team-Interested, 10Flow: Examine the use of Elapsed vs Exact timestamps in Flow - https://phabricator.wikimedia.org/T94648#2294509 (10Quiddity) [00:51:13] 06Collaboration-Team-Interested, 10Flow: Examine the use of Elapsed vs Exact timestamps in Flow - https://phabricator.wikimedia.org/T94648#2294511 (10Quiddity) Copy from merged task: >>! In T129610#2111230, @Pginer-WMF wrote: > Some considerations (some I mentioned when discussing it for Flow in T111596#180418... [00:54:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Cross-wiki notifications are loading without any result - https://phabricator.wikimedia.org/T135252#2293248 (10Catrope) This could possibly be a different bug, caused by a JS error. Do any errors appear in the developer console when you clic... [00:55:33] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review, and 3 others: Wrong notification counts being shown due to cache pollution coming from non-SUL wikis - https://phabricator.wikimedia.org/T135246#2294532 (10Etonkovidova) Checking before the fix {F4008... [01:03:24] or to use special:changecontentmodel [01:04:49] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2294536 (10Catrope) I can reproduce this now: I have a notification on ptwikibooks that I can't mark as read. For some reason ptwikibooks is rejecting my CORS request f... [01:08:11] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2294538 (10Catrope) Looks like it's PrivacyBadger. [01:09:01] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2294540 (10Etonkovidova) Related to my comments on {T135292} ? [01:09:49] Alright, I think we've got all the bugs under control. The only remaining one is "Cross-wiki mark as read doesn't work" which I'm now convinced is caused by PrivacyBadger/AdBlock [01:12:22] To fix that we'd have to proxy mark-as-read through the local API as well [01:12:35] I thought we wouldn't have to, but it makes sense that PB blocks POSTs to foreign domains [01:13:13] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2294560 (10Catrope) >>! In T121930#2294540, @Etonkovidova wrote: > Related to my comments on {T135292} ? Yeah, they're probably the same bug. [01:15:19] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2294561 (10Catrope) [08:03:25] (03CR) 10Gergő Tisza: Improve talk page manager user creation (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288644 (owner: 10Anomie) [11:55:16] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2294801 (10MGChecker) In the second picture, the r of your is missing. Apart from that, I like the concept. [15:18:16] 10Notifications: Requested notifications are in wrong order - https://phabricator.wikimedia.org/T135307#2294890 (10matej_suchanek) [15:18:32] 10Notifications, 07Regression: Requested notifications are in wrong order - https://phabricator.wikimedia.org/T135307#2294903 (10matej_suchanek)