[00:00:44] 10Notifications: Echo (cross-wiki): First of multiple notifications not shown. - https://phabricator.wikimedia.org/T135196#2291443 (10Krinkle) [00:02:13] 10Notifications: Echo (cross-wiki): First of multiple alerts not shown. - https://phabricator.wikimedia.org/T135196#2291460 (10Krinkle) [00:03:16] 10Notifications: Echo cross-wiki messages fail to load (Access to the remote domain was denied) - https://phabricator.wikimedia.org/T135197#2291472 (10Krinkle) [00:05:48] 10Notifications: Echo cross-wiki messages fail to load (Access to the remote domain was denied) - https://phabricator.wikimedia.org/T135197#2291486 (10Krinkle) [00:07:44] 10Notifications: Echo cross-wiki messages fail to load (Access to the remote domain was denied) - https://phabricator.wikimedia.org/T135197#2291472 (10Catrope) Probably related: ``` 242 array_merge() expects parameter 1 to be array, null given in /srv/mediawiki/php-1.27.0-wmf.23/extensions/Echo/includes/api/... [00:10:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 07JavaScript: Flow: JavaScript errors and wrong result from post moderation actions performed in new window - https://phabricator.wikimedia.org/T73220#2291492 (10Mattflaschen) I hit this while testing {T103702}. [00:13:36] ebernhardson, wow, I didn't realize the infrastructure for conditional modules was already there. I was lucky to stumble across https://phabricator.wikimedia.org/T95468 just now. [00:13:56] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: Use 'modules' and 'moduleStyles' keys in FlowActions to stop loading javascript on pages that are supposed to be no-javascript only - https://phabricator.wikimedia.org/T95468#2291497 (10Mattflaschen) a:03Mattflaschen [00:14:44] matt_flaschen: interesting [00:15:28] good to see the backlog getting some love :) [00:15:51] ebernhardson, while you're here..., do you know what the deal is with create-header? [00:16:09] It's defined as an action, but doesn't seem to work. Maybe it only works if the board exists? [00:17:47] I guess it's a pseudo-action. [00:19:18] Yeah, I forgot it's based on handler-class. [00:23:48] matt_flaschen: hmm, i dont remember looking [00:26:55] matt_flaschen: yea it looks like a pseudo action, doing the first edit (according to ApiFlowEditHeaderTest::testEditHeader) to a header makes a create-header action [00:27:02] tbh i'm not sure if thats very useful [00:56:35] (03PS1) 10Catrope: Protect against some errors that apparently happen in production [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288558 (https://phabricator.wikimedia.org/T135196) [01:36:43] (03PS1) 10Mattflaschen: Don't serve JS except on 'view' or 'history' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288564 (https://phabricator.wikimedia.org/T95468) [01:37:53] (03CR) 10Mattflaschen: [C: 04-1] "This is ready for review, but should be discussed a bit before merging. I want to see what people think." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288564 (https://phabricator.wikimedia.org/T95468) (owner: 10Mattflaschen) [01:38:58] Have a good night, everyone. [07:33:06] hmm, i can't edit an old version of a flow board header ? [07:34:06] 06Collaboration-Team-Interested, 10Notifications, 07Design: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264#2291859 (10Pginer-WMF) [07:35:36] reverse order undo sequence then i guess... [07:36:22] 06Collaboration-Team-Interested, 10Notifications, 07Design: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264#2291864 (10Pginer-WMF) I copied the proposal from T115264#2248740 to the ticket to capture it as the current proposed solution. There is still research to be... [07:38:46] 06Collaboration-Team-Interested, 10Notifications, 07Design: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264#2291866 (10Pginer-WMF) An example of related issues was provided [[ https://www.mediawiki.org/w/index.php?title=Topic:T394nbfaen1c56qv&topic_showPostId=t3fte... [08:07:30] 06Collaboration-Team-Interested, 10Notifications, 07Persona-Active-Editor: Adjust notification badge prominence for cross-wiki notifications - https://phabricator.wikimedia.org/T130363#2291897 (10Pginer-WMF) >>! In T130363#2290808, @jmatazzoni wrote: > In reading this over, I think this is something we can s... [09:14:28] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Add "mark as read" buttons for each day on the no-JS Special:Notifications page - https://phabricator.wikimedia.org/T134204#2291981 (10Pginer-WMF) >>! In T134204#2290256,... [09:24:28] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07Epic, and 3 others: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2292004 (10Trizek-WMF) [09:24:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07User-notice: Prepare and review announcements concerning Cross-wiki Notifications as a by-default feature on all wikis - https://phabricator.wikimedia.org/T129643#2292002 (10Trizek-... [09:24:32] 06Collaboration-Team-Interested, 10Notifications, 07Epic, 07User-notice, 07WorkType-NewFunctionality: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#2292005 (10Trizek-WMF) [09:25:32] 06Collaboration-Team-Interested, 10Notifications, 07Epic, 07User-notice, 07WorkType-NewFunctionality: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1794367 (10Trizek-WMF) [09:25:34] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, and 2 others: Cross-wiki notifications - announcements planning - https://phabricator.wikimedia.org/T123570#2292007 (10Trizek-WMF) 05Open>03Resolved Release done, blog post [[ http:/... [09:52:50] 06Collaboration-Team-Interested, 10Notifications, 07Epic, 07User-notice, 07WorkType-NewFunctionality: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#2292033 (10Pginer-WMF) [10:00:31] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Design research: How will expandable bundles behave inside cross-wiki bundles? - https://phabricator.wikimedia.org/T135183#2292038 (10Pginer-WMF) > Pau, you may already have an answer in mind for this. If the answer is that bundles inside x-wiki bundles should co... [10:05:42] 06Collaboration-Team-Interested, 10Flow: Copy/pasting links on Flow has multiple unexpected behaviors - https://phabricator.wikimedia.org/T135126#2292045 (10Trizek-WMF) Should I split that task in sub-tasks? [10:55:09] (03CR) 10Sbisson: [C: 032] Hide editor switcher button on VE when switching is disabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288515 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [10:58:53] (03CR) 10Sbisson: [C: 032] Protect against some errors that apparently happen in production [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288558 (https://phabricator.wikimedia.org/T135196) (owner: 10Catrope) [11:04:15] (03CR) 10Sbisson: [C: 032] "This is embarrassing" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288537 (https://phabricator.wikimedia.org/T134854) (owner: 10Catrope) [11:05:04] (03Merged) 10jenkins-bot: Hide editor switcher button on VE when switching is disabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288515 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [11:13:18] (03Merged) 10jenkins-bot: Protect against some errors that apparently happen in production [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288558 (https://phabricator.wikimedia.org/T135196) (owner: 10Catrope) [11:21:40] (03Merged) 10jenkins-bot: Correctly update locally cached seenTime [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288537 (https://phabricator.wikimedia.org/T134854) (owner: 10Catrope) [11:54:14] 06Collaboration-Team-Interested, 10Notifications: Enable Cross-wiki Notifications on all wikis at once - https://phabricator.wikimedia.org/T131831#2292247 (10Trizek-WMF) 05Open>03Resolved a:03Trizek-WMF Resolved per deployment. [11:55:14] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2292250 (10Pginer-WMF) >>! In T129366#2290528, @jmatazzoni wrote: > @Pginer-WMF , I have two comments/requests about this desi... [11:55:53] 06Collaboration-Team-Interested, 10Notifications: Allow "article-linked" notifications for pages in a user defined list - https://phabricator.wikimedia.org/T66090#2292252 (10matej_suchanek) [12:19:42] 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2292278 (10Trizek-WMF) 05Resolved>03Open I'm reopening the task due to [[ https://commons.wikimedia.org/w/index.php?title=Commons%3AVillage_pump&type=revision&... [12:24:19] 06Collaboration-Team-Interested, 10Flow, 10Parsoid: Flow: Score vorbis content doesn't roundtrip (html/wikitext) properly - https://phabricator.wikimedia.org/T74912#2292287 (10TheDJ) [12:32:00] 10Notifications, 03Collab-Archive-2015-2016: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2292295 (10matej_suchanek) [12:47:43] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Use 'modules' and 'moduleStyles' keys in FlowActions to stop loading javascript on pages that are supposed to be no-javascript only - https://phabricator.wikimedia.org/T95468#1191539 (10SBisson) I disagree that those pages are **//supposed//** to be... [13:01:20] 10Flow, 13Patch-For-Review: Discussion page stuck loading only on first load; "TypeError: $.throttle is not a function" - https://phabricator.wikimedia.org/T134984#2292345 (10SBisson) >>! In T134984#2285675, @gerritbot wrote: > Change 288223 had a related patch set uploaded (by Catrope): > Add missing dependen... [13:02:14] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2292347 (10Trizek-WMF) [14:18:44] (03CR) 10Mattflaschen: "Maybe we should add undo as well, since that is part of the normal flow." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288564 (https://phabricator.wikimedia.org/T95468) (owner: 10Mattflaschen) [14:25:48] 06Collaboration-Team-Interested, 10Flow: Allow editing old version of Flow description - https://phabricator.wikimedia.org/T135237#2292681 (10Mattflaschen) [14:35:39] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation, 07Tracking: [Tracking] Update Help:Notifications - https://phabricator.wikimedia.org/T119713#2292724 (10Trizek-WMF) [14:35:41] 10Collab-Notifications-Page, 10Collaboration-Community-Engagement, 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2292722 (10Trizek-WMF) 05stalled>03Open p:05Low>03Normal [14:38:43] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1): Cross-wiki notifications: Make cross-wiki API requests server-side - https://phabricator.wikimedia.org/T130636#2292727 (10Johan) [14:42:55] 10Flow, 13Patch-For-Review: Discussion page stuck loading only on first load; "TypeError: $.throttle is not a function" - https://phabricator.wikimedia.org/T134984#2284524 (10Mattflaschen) >>! In T134984#2292345, @SBisson wrote: >>>! In T134984#2285675, @gerritbot wrote: >> Change 288223 had a related patch se... [14:43:58] (03CR) 10Mattflaschen: [C: 032] Add missing dependency on jquery.throttle-debounce [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288223 (https://phabricator.wikimedia.org/T134984) (owner: 10Catrope) [14:44:47] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: Discussion page stuck loading only on first load; "TypeError: $.throttle is not a function" - https://phabricator.wikimedia.org/T134984#2292742 (10Mattflaschen) a:03Catrope [14:46:01] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 07JavaScript, 13Patch-For-Review: Flow: JavaScript errors and wrong result from post moderation actions performed in new window - https://phabricator.wikimedia.org/T73220#2292744 (10Mattflaschen) a:03Mattflaschen [14:50:35] (03Merged) 10jenkins-bot: Add missing dependency on jquery.throttle-debounce [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288223 (https://phabricator.wikimedia.org/T134984) (owner: 10Catrope) [15:21:47] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2292828 (10Trizek-WMF) [16:29:11] Bonjour Mooeypoo, have you seen this: https://phabricator.wikimedia.org/T121930 ? :) [16:32:19] 06Collaboration-Team-Interested, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 07Regression: Possible regressions on notifications on wikimediafoundation wiki and office wiki due to last Notifications release - https://phabricator.wikimedia.org/T135246#2293000 (10Trizek-WMF) [16:32:50] 06Collaboration-Team-Interested, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 07Regression: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2293000 (10Trizek-WMF) [16:49:45] (03PS29) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [17:09:16] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2293101 (10Trizek-WMF) Some feedback [[ https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Cross-wiki_notifications_-_how_to_clear.3F | from en.wp ]] too,... [17:21:01] mooeypoo: what do you want me to look at? [17:21:43] mooeypoo, patch to stop serving JS on the secondary (aka no-JS) pages (edit-header, moderate-post, etc.). https://gerrit.wikimedia.org/r/288564 [17:21:43] etonkovidova: would you have time to test the "dynamic bundles" today or is it gonna be after you're back from vacation? [17:22:08] matt_flaschen, didn't I do that in my original patch? I removed ->addModules() [17:22:11] etonkovidova: this is the patch: https://gerrit.wikimedia.org/r/#/c/275049/ [17:23:12] matt_flaschen, oh, that's Flow, sorry, hehe [17:23:42] Yeah [17:23:49] stephanebisson, https://gerrit.wikimedia.org/r/#/c/287630/1 and https://gerrit.wikimedia.org/r/#/c/287631/ [17:24:03] I have to go do spring cleaning at my coworking place (and one other quick thing). I'll be back in a while. [17:24:15] ^^ those two are both good as far as I'm concerned, I want you to verify I'm not missing anything. If we merge, I'll need to adjust theMVC commit slightly, but it's fine [17:24:22] the commit that's on top is what I'm a bit meh about [17:24:36] stephanebisson, this one: https://gerrit.wikimedia.org/r/#/c/287632/ <-- a little meh [17:25:21] mooeypoo: I'm on it [17:26:53] mooeypoo: should I go ahead and merge them? [17:28:22] (03CR) 10Mooeypoo: [C: 04-1] "I am not sure I like the idea of splitting the fetch notification groups into separate promises again. They're all locally fetching now, s" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287632 (owner: 10Matthias Mullie) [17:28:42] stephanebisson, if you agree they're good, yes. I wanted to make sure I didn't miss anything. I am more concerned about the top one, I just posted my comment on it [17:29:02] mooeypoo: the first is trivial, I'll merge [17:29:07] yeah the first is trivial [17:29:30] mooeypoo: the second I'm not sure about the tests... I'll verify and merge if it's ok [17:29:57] stephanebisson, yeah the second I think misses something [17:29:58] (03PS2) 10Sbisson: Make sure APIHandler has this.api [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287630 (owner: 10Matthias Mullie) [17:30:10] although I don't get why jenkins hasn't run on them... [17:30:14] we set the APIs in other places I tihnk [17:30:16] yeah me neithre [17:30:18] maybe the rebase will help [17:30:21] recheck [17:30:29] probably a temporary fluke [17:31:27] stephanebisson, I'm going to push my WIP commit about the special page in a minute so I can refactor the MVC, feel free to take a look there too. I think the direction I went with is good, but I got stuck with the API handlers -- which, actually, the fixes to the 'set' may save [17:32:05] yeah, set( name, handler ) is more logical [17:32:31] yep [17:32:35] and we can then decide to share handlers [17:32:39] which i need for the special page [17:33:06] stephanebisson, so, for the JS of the special page, I am pulling the local notifications and then the controller, instead of splitting them by source/wiki, splits them by day [17:33:11] and creates models per day [17:33:30] so it acts like a cross-wiki notification widget (with each sub group showing with its title) but instead of each group being a wiki, each group is a day [17:34:04] do you have a new model for the Group (day) or is it the same group used for xwiki? [17:34:07] tat works great now -- but we will need the same API handler (or a local one) per each of those sources [17:34:36] "those sources" ? [17:34:51] stephanebisson, there's no need for another model; the xwiki item needed a model because it also holds item-related data (icon, header messages, etc) [17:35:03] ok, want me to screen-share and show? or wait until I push? [17:35:28] let me know when it's pushed, I'll read first [17:35:33] no rush [17:35:47] (03CR) 10Sbisson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287630 (owner: 10Matthias Mullie) [17:36:19] stephanebisson, I'm concentrating first on creating everything, so the first push will have some redundant code - I was planning on splitting the redundancies later [17:37:11] stephanebisson: thx! [17:37:20] mooeypoo: no prob. just let me know when I can help [17:37:56] stephanebisson, this is mainly a great experiment to make sure the MVC works right [17:38:12] so far, so good. I think conceptually things are working as we planned [17:40:35] (03PS17) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [17:40:46] stephanebisson, ^^ (take into account the api handlers aren't set up yet, so mark as read, etc, won't work) [17:40:58] I worked mainly on the models and the widget [17:41:09] also, it's not formatted/designed yet [17:41:15] oh oh and moment gave me a laugh yesterday [17:42:31] stephanebisson, matt_flaschen you'll enjoy this bug... so moment has its own way of showing things and its own translations, but those are for things moment thinks are standard. Turns out, "Today" and "Yesterday" and "Last Wednesday" and such aren't standard, so I needed to create a way to display them with mw.msg() so we can translate. I did the same thing we do with the short-hand timestamps, basically, overriding the formatting [17:42:31] with our own mw.msg [17:42:36] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [17:43:25] So I defined calendar: { sameDay: mw.msg( 'notification-timestamp-today' ), lastDay: mw.msg( 'notification-timestamp-yesterday' ) ... } [17:43:39] and then moment can take moment( date ).calendar(); and display whatever it is. [17:44:28] BUT, and here comes the great fun part -- mw.msg() runs first. So it produces an output. I didn't translate yet, so it just had in there. But then moment looked at it, knew it is the format, and treated it as a format........ [17:44:46] which means it replaced 'm' with actual minutes, 'p' with 'am' and 's' with seconds, etc [17:45:30] so I ended up having labels saying [17:45:42] ... and it took me a moment to realize what happened [17:47:29] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2293168 (10Quiddity) p:05Triage>03High [17:47:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2293156 (10Quiddity) [17:48:24] (03PS18) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [17:48:42] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [17:53:06] (03PS61) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [17:53:25] (03PS19) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [17:53:36] (03CR) 10jenkins-bot: [V: 04-1] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [17:54:42] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [17:55:49] (03PS62) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [17:56:12] (03PS20) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [17:56:43] (03CR) 10Sbisson: [C: 032] Make sure APIHandler has this.api [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287630 (owner: 10Matthias Mullie) [17:59:51] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [18:03:07] (03Merged) 10jenkins-bot: Make sure APIHandler has this.api [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287630 (owner: 10Matthias Mullie) [18:04:09] (03PS3) 10Sbisson: Get rid of addApiHandler factory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287631 (owner: 10Matthias Mullie) [18:06:41] 06Collaboration-Team-Interested, 10Notifications: Cross-wiki notifications are loading without any result - https://phabricator.wikimedia.org/T135252#2293248 (10Trizek-WMF) [18:08:37] (03CR) 10jenkins-bot: [V: 04-1] Get rid of addApiHandler factory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287631 (owner: 10Matthias Mullie) [18:10:43] ^ that's what I thought, unit tests are not quite right [18:11:49] (03PS4) 10Sbisson: Get rid of addApiHandler factory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287631 (owner: 10Matthias Mullie) [18:18:57] 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Echo cross-wiki messages fail to load (Access to the remote domain was denied) - https://phabricator.wikimedia.org/T135197#2293291 (10Quiddity) [18:19:43] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Investigate cross-wiki notifications release blockers - https://phabricator.wikimedia.org/T135239#2292814 (10Quiddity) [18:25:12] (03CR) 10Sbisson: [C: 032] Get rid of addApiHandler factory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287631 (owner: 10Matthias Mullie) [18:31:35] (03Merged) 10jenkins-bot: Get rid of addApiHandler factory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287631 (owner: 10Matthias Mullie) [18:33:57] RoanKattouw et al, these probably need to be the priority for today, before the weekend: https://phabricator.wikimedia.org/T135239 [18:36:40] Yes, we need to look at those [18:36:41] Thanks for gathering them [18:37:01] Two of them I'm pretty sure I fixed last night, but I'll look at the rest once I'm at my desk [18:37:09] (In 2 hours probably) [18:37:50] Others (cc mooeypoo stephanebisson): help with those would be much appreciated [18:38:14] I can do something about T135252 [18:38:15] T135252: Cross-wiki notifications are loading without any result - https://phabricator.wikimedia.org/T135252 [18:38:25] The first three sound to me to be the same cause [18:38:50] But it's worrying that the error message isn't shown [18:38:51] and T135250 is essentially the same thing [18:38:51] T135250: Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250 [18:39:31] the last 2 I can't reproduce atm [18:39:37] stephanebisson, are you taking this on? [18:39:51] yes, T135252 and T135250 [18:39:52] T135250: Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250 [18:39:52] T135252: Cross-wiki notifications are loading without any result - https://phabricator.wikimedia.org/T135252 [18:40:09] It seems they're mostly the same issue, some cross-domain issues + not showing an error [18:40:52] I think I know what's T135246 [18:40:53] T135246: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246 [18:41:23] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2293382 (10SBisson) a:03SBisson [18:42:15] RoanKattouw, yesterday, Neil showed us a similar issue with the counter on office wiki. .. it seems the counter counted cross-wiki, but officewiki (and I think foundation wiki is the same) didn't show cross-wiki from other production wikis. When neil disabled x-wiki beta, it went away [18:42:33] RoanKattouw, we thought it was the caching error, but it sounds like this might be fishbowl wikis issue? [18:43:17] Oooob [18:43:41] officewiki doesn't get XWN [18:43:42] I can't reproduce it for me [18:43:45] Because it's not in SUL [18:43:58] But I also have a different username in officewiki/foundation and production wikis [18:43:59] If it is seeing global notification counts that would be an issue [18:44:14] But I doubt it? [18:44:14] yeah it looked like it does. Could it be trying to fetch count with the xwiki? [18:44:31] Oh yeah I think the config for XWN might be on there? [18:44:39] It shouldn't be [18:44:41] Good point [18:44:44] RoanKattouw, neil's problem just came back [18:44:48] so it seems to be fishbowl [18:45:17] OK [18:45:43] I need to get off IRC to get ready so I can actually make it into the office [18:45:57] I have a meeting till 1:30 and I'll check in with people after [18:48:00] 06Collaboration-Team-Interested, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 07Regression: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2293401 (10Mooeypoo) This seems to be a fishbowl wik... [18:48:37] (03PS1) 10Anomie: Improve talk page manager user creation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288644 [18:49:28] mooeypoo: stephanebisson: I see in betalabs Uncaught Error: mw.ForeignApi() requires a `url` parameter and cross-wiki notifications do not open [18:49:52] mooeypoo: stephanebisson and it's really a recent thing - was not like that in the morning [18:49:55] etonkovidova, crap, something wasn't updated [18:50:03] yeah we just merged the api change, i'm checking now [18:50:12] etonkovidova, do you have a filename by any chance in that error? [18:50:38] mooeypoo: checking... [18:51:17] etonkovidova, got it [18:51:20] etonkovidova: I merged something bad by accident [18:51:27] fix coming... [18:51:30] mooeypoo: ah, ok [18:51:46] stephanebisson, oh, ok i was going to tackle that [18:52:19] oh I see what it is, it's giving in the sources without an explicit URL [18:53:24] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Cross-wiki notifications post-release issues (tracking) - https://phabricator.wikimedia.org/T135239#2293419 (10Mattflaschen) [18:55:12] (03PS1) 10Sbisson: Pass source url when creating API handler [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288645 [18:55:32] ^ mooeypoo [18:56:07] (03CR) 10Mooeypoo: [C: 032] Pass source url when creating API handler [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288645 (owner: 10Sbisson) [18:57:34] once in a hundred times I merge code that looks trivial without testing it... and BOOM [18:59:40] :D [19:00:25] Luckily, we have etonkovidova [19:00:51] mooeypoo: thanks! :))) [19:02:07] (03Merged) 10jenkins-bot: Pass source url when creating API handler [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288645 (owner: 10Sbisson) [19:05:32] mooeypoo: it's a little consolation since I am looking now at the production count update for foreign notifications and it does not make sense at all :((( [19:08:19] What I suspect is happening with non-SUL wikis is that they don't access the echo_unread_wikis table but they still write to global cache keys [19:08:38] And when they use the API for global user IDs, they probably get local user IDs back because they don't know about the global system [19:08:57] I didn't think of this so there's no $wg var to turn off all XWN-related code altogether [19:09:17] We should introduce one and set it to false on non-SUL wikis (i.e. wikis where $wmgUseCentralAuth is false) [19:09:36] If nothing else, users are probably seeing the XWN toggle in their preferences on fishbowl/private wikis right now [19:10:00] * RoanKattouw heads in [19:11:23] RoanKattouw, you don't need a new $wg. Just use the preference, set the default to false on fishbowl/private, and set it to hidden on those wikis. [19:11:45] RoanKattouw, hidden preferences are forced to the default value unconditionally unless you opt out of that. [19:14:17] Good idea [19:14:19] Let's do that [19:14:56] But that doesn't fix the cache pollution issue, we may need a wg for that still [19:20:00] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Cross-wiki notifications post-release high-priority issues (tracking) - https://phabricator.wikimedia.org/T135239#2293455 (10Mattflaschen) [19:20:37] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 3 others: Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2293460 (10jeblad) [19:20:40] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 07I18n: Missing localization of Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134862#2293457 (10jeblad) 05Open>03Resolved a:03jeblad It is fixed now, thanks! :D [19:22:25] RoanKattouw, alright, I'm working on that/https://phabricator.wikimedia.org/T135246 [19:24:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 3 others: Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2293481 (10jeblad) It is st... [19:25:56] 06Collaboration-Team-Interested, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 07Regression: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2293000 (10Mattflaschen) Private and fishbowl are no... [19:26:07] 06Collaboration-Team-Interested, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 07Regression: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2293488 (10Mattflaschen) a:03Mattflaschen [19:26:37] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 07Regression: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2293000 (10Mattflaschen) [19:31:47] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Cancel button for moderation broken, only locally - https://phabricator.wikimedia.org/T132414#2293511 (10jmatazzoni) 05Open>03Resolved [19:35:44] (03PS1) 10Sbisson: Handle empty foreign notification sources [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288649 (https://phabricator.wikimedia.org/T135252) [19:36:35] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2293520 (10Etonkovidova) It does not seem to be reproducible straightforwardly, but I did see several problems. 1. The most obvious one is with Arabic wikipeida - htt... [19:42:09] (03CR) 10jenkins-bot: [V: 04-1] Handle empty foreign notification sources [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288649 (https://phabricator.wikimedia.org/T135252) (owner: 10Sbisson) [19:43:07] (03PS2) 10Sbisson: Handle empty foreign notification sources [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288649 (https://phabricator.wikimedia.org/T135252) [19:48:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Cross-wiki notifications are loading without any result - https://phabricator.wikimedia.org/T135252#2293578 (10SBisson) a:03SBisson [19:48:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Cross-wiki notifications are loading without any result - https://phabricator.wikimedia.org/T135252#2293248 (10SBisson) [19:48:56] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2293583 (10SBisson) [19:49:07] RoanKattouw, should I request a out-of-window deploy for the non-SUL wikis fix (to force the preference off)? https://gerrit.wikimedia.org/r/#/c/288651/ [19:49:43] matt_flaschen: Yes please [19:50:18] RoanKattouw, mooeypoo, stephanebisson, can one of you review https://gerrit.wikimedia.org/r/#/c/288651/? [19:50:25] (03CR) 10Mooeypoo: [C: 032] Handle empty foreign notification sources [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288649 (https://phabricator.wikimedia.org/T135252) (owner: 10Sbisson) [19:50:28] RoanKattouw, do you know who the greg-g-on-duty is? [19:50:49] matt_flaschen: ostriches is interim Greg [19:52:18] Thanks [19:54:23] matt_flaschen: Also, not relevant just yet, but once we do fix the global cache key pollution problems (if they are real), we'll also want to bump the cache version [19:56:02] Also yes that issue is real: [19:56:11] RoanKattouw, yeah, I was just checking something about that. [19:56:12] > echo $u->getId(); [19:56:12] 345 [19:56:21] > echo CentralIdLookup::factory()->centralIdFromLocalUser($u, CentralIdLookup::AUDIENCE_RAW); [19:56:21] 345 [19:56:25] (on foundatonwiki) [19:56:47] Cache version is in $wgEchoConfig['version'] IIRC, I bumped it recently [19:57:27] Yeah, same on officewiki. [19:57:33] RoanKattouw, I'll do that now as well. [19:57:38] Thanks [19:59:23] (03PS1) 10Mattflaschen: Bump cache version for cache pollution (cross-wiki on non-SUL wikis) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288654 (https://phabricator.wikimedia.org/T135246) [19:59:46] 06Collaboration-Team-Interested, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#2293617 (10Arlolra) [20:01:00] (03Merged) 10jenkins-bot: Handle empty foreign notification sources [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288649 (https://phabricator.wikimedia.org/T135252) (owner: 10Sbisson) [20:02:29] 10Collab-Notifications-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2293629 (10Qgil) [20:09:09] stephanebisson: in case it's not known already - betalabs on each attempt to save any edit : Request to parsoid for 'wikitext' to 'html' conversion of content connected to title "Topic:T3w8q4u89ietyvl7" failed: 406 [20:10:30] etonkovidova: not known by me at least, can you file a bug? [20:10:55] RoanKattouw, no rush, but you're actually right we should gate it too. If for no other reason than it's useless and confusing on a single-wiki third-party install. [20:11:40] stephanebisson: yes - sigh I hoped it's just a residue from some recent merges ... corss-wiki notificaitons are displayed fine now, btw' [20:11:53] good [20:13:51] etonkovidova: works fine locally, maybe something going on with parsoid? [20:14:14] stephanebisson: oh - could be... [20:14:20] matt_flaschen: Yeah exactly [20:14:42] RoanKattouw, filing as followup. [20:14:52] matt_flaschen: We still have to put the wg in though [20:14:59] Because of how CentralIdLookup works [20:15:08] I'm back now so I can do that if you like [20:15:24] stephanebisson: yes - it's called EMERGENCY in logstash :( [20:16:17] Even if the pref is off the cache pollution will still happen [20:16:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Gate cross-wiki preferences entirely (default off) - https://phabricator.wikimedia.org/T135266#2293688 (10Mattflaschen) [20:16:46] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review, 07Regression: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2293704 (10Mattflaschen) Follow... [20:17:34] RoanKattouw, oh, is it caching at notification-send-time? [20:17:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Gate cross-wiki preferences entirely (default off) - https://phabricator.wikimedia.org/T135266#2293706 (10Catrope) a:03Catrope [20:17:38] Yes [20:17:41] :( [20:17:49] And it caches the global count separately so that's updated regardless of prefs [20:17:49] Okay, I thought it was at read time so the bump and disable would solve it. [20:18:03] No :( [20:18:06] I'll write that patch now [20:18:17] 03Collab-Team-2016-Apr-Jun-Q4, 10Parsoid: [betalabs] "Request to parsoid for 'wikitext' to 'html' conversion failed" for for any edits - https://phabricator.wikimedia.org/T135268#2293722 (10Etonkovidova) [20:18:31] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review, 07Regression: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2293737 (10Mattflaschen) Never m... [20:19:25] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review, 07Regression: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2293753 (10Mattflaschen) Config... [20:20:12] should I use "wfLogWarning" to log errors when we fail to fetch foreign notifications server-side? [20:20:30] right now we just ignore them [20:21:40] stephanebisson, seems fine per docs. Also not deprecated unlike some of the 'old' functions. [20:22:32] matt_flaschen: just wfLogWarning( '' )? is there a convention for specifying source (Echo) ? [20:24:07] stephanebisson, if you want to use the Echo source, use wfDebugLog. I don't know know why wfLogWarning doesn't use log groups. [20:24:55] I guess that's better. Put 'Echo' as the first parameter like in NotificationMapper.php. [20:27:23] With wfDebugLog it will go into /a/mw-log/Echo.log on fluorine (I think also logstash). [20:27:36] stephanebisson, can you merge https://gerrit.wikimedia.org/r/#/c/288654/ ? [20:28:03] (03CR) 10Sbisson: [C: 032] Bump cache version for cache pollution (cross-wiki on non-SUL wikis) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288654 (https://phabricator.wikimedia.org/T135246) (owner: 10Mattflaschen) [20:30:02] (03CR) 10Mattflaschen: "Roan's changes to gate the variable need to be deployed first, or this prefix will get polluted too." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288654 (https://phabricator.wikimedia.org/T135246) (owner: 10Mattflaschen) [20:30:05] stephanebisson, matt_flaschen: Use the new logging system [20:30:25] See how the logging for thank-you-edit works (in Hooks.php) [20:30:34] That goes to Echo.lho [20:30:35] *.log [20:31:50] Okay, noted for next time. [20:32:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Parsoid: [betalabs] "Request to parsoid for 'wikitext' to 'html' conversion failed" for for any edits - https://phabricator.wikimedia.org/T135268#2293835 (10Mattflaschen) [20:33:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Parsoid: [betalabs] "Request to parsoid for 'wikitext' to 'html' conversion failed" for for any edits - https://phabricator.wikimedia.org/T135268#2293722 (10Mattflaschen) a:03Mattflaschen [20:34:15] (03PS1) 10Sbisson: New error message for failed to fetch notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288692 (https://phabricator.wikimedia.org/T129764) [20:35:11] (03PS2) 10Sbisson: New error message for failed to fetch notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288692 (https://phabricator.wikimedia.org/T129764) [20:35:35] grabbing lunch, back soon. [20:36:07] (03Merged) 10jenkins-bot: Bump cache version for cache pollution (cross-wiki on non-SUL wikis) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288654 (https://phabricator.wikimedia.org/T135246) (owner: 10Mattflaschen) [20:36:26] (03PS1) 10Sbisson: Log warning on failure to fetch foreign notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288694 [20:36:46] ^ using the new logging system [20:37:11] (03CR) 10Catrope: [C: 032] Log warning on failure to fetch foreign notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288694 (owner: 10Sbisson) [20:37:21] * RoanKattouw removes +2 again [20:37:46] stephanebisson, why did you remove displaying the error message from https://gerrit.wikimedia.org/r/#/c/288692/2 [20:37:50] stephanebisson: Actually you can put structured data in (see the thank-you-edit example again) so I think it'd be helpful to put in the response text [20:38:37] stephanebisson, I mean, we should probably make the messages more clear, but why remove the specific explanation from the bigger message? (the $1 param) ? [20:39:52] (03CR) 10jenkins-bot: [V: 04-1] Log warning on failure to fetch foreign notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288694 (owner: 10Sbisson) [20:42:01] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2293899 (10Quiddity) Note, this is an accidental duplicate of {T135196} - I'm not sure which direction to merge, becaus... [20:42:20] (03PS2) 10Sbisson: Log warning on failure to fetch foreign notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288694 [20:43:08] mooeypoo: I thought it was the intent of the ticket [20:47:49] oh, I am misunderstanding [20:48:16] I thought the ticket was reporting that the cross-wiki items weren't fetched (So, the cause of the error, not the error itself) ? [20:48:43] (03PS1) 10Catrope: Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288697 (https://phabricator.wikimedia.org/T135266) [20:48:44] I agree simplifying that error message is good, I just don't know if we want to remove the API-reason (or the rewrite we do for cross-domain stuff) [20:48:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2293948 (10SBisson) >>! In T135250#2293899, @Quiddity wrote: > Note, this is an accidental duplicate of {T135196} - I'm... [20:52:59] (03PS2) 10Catrope: Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288697 (https://phabricator.wikimedia.org/T135266) [20:55:39] mooeypoo: initially yes, but it was sent back to dev to change the error message, and I thought we didn't want to show the underlying technical issue to the users [20:56:10] but I can add it back, you merge, and we see what happen? [20:56:23] matt_flaschen: OK my patches are ready. https://gerrit.wikimedia.org/r/288697 for the wg, https://gerrit.wikimedia.org/r/288701 to be deployed before it so that the wg is true where it needs to be, https://gerrit.wikimedia.org/r/288702 to clean up afterwards [20:58:08] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2293974 (10Catrope) Incorrect counts are {T135246} [21:00:39] (03PS1) 10Catrope: Protect against some errors that apparently happen in production [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288704 (https://phabricator.wikimedia.org/T135196) [21:01:25] (03PS1) 10Catrope: Handle empty foreign notification sources [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288705 (https://phabricator.wikimedia.org/T135252) [21:02:47] Whoa WTF: [21:02:52] 2016-05-13 18:42:17 [VzYgCQpAID0AAFFelAIAAADX] mw1191 mediawikiwiki 1.28.0-wmf.1 exception ERROR: [VzYgCQpAID0AAFFelAIAAADX] /w/api.php?action=query&format=json&meta=notifications¬sections=message¬format=model¬limit=25¬unreadfirst=1¬prop=list%7Ccount&uselang=en¬crosswikisummary=1&_=1463164933350 Exception from line 235 of [21:02:52] /srv/mediawiki/php-1.28.0-wmf.1/extensions/Echo/includes/model/Event.php: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) {"exception_id":"VzYgCQpAID0AAFFelAIAAADX"} [21:02:52] [Exception Exception] (/srv/mediawiki/php-1.28.0-wmf.1/extensions/Echo/includes/model/Event.php:235) DateTimeZone::__construct(): Unknown or bad timezone (+00:00) [21:02:52] #0 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Echo/includes/model/Event.php(235): DateTime->__wakeup() [21:02:52] #1 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Echo/includes/model/Event.php(295): EchoEvent->loadFromRow(stdClass) [21:02:52] #2 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Echo/includes/model/Notification.php(210): EchoEvent::newFromRow(stdClass) [21:03:26] Also, wat: [Exception Flow\Exception\FlowException] (/srv/mediawiki/php-1.28.0-wmf.1/extensions/Flow/includes/Notifications/Formatter.php:109) Expected UUID but received Flow\Notif [21:03:31] icationFormatter [21:03:37] Ug [21:03:45] That first one is the issue quiddity ran into a while ago. [21:03:49] Yeah [21:03:53] Anyway, sorry, let's focus [21:04:00] Yeah, I'm reviewing your patch. [21:04:06] I was looking at the logs to discover causes of notification requests erroring out [21:04:14] Let's first get the fixes we have now deployed [21:04:26] matt_flaschen: How about I deploy that config change you just merged, while you review my main patch? [21:05:05] and I cherry-pick the fixes that are merged already [21:05:06] I saw the second one this week locally but I started digging it stopped happening [21:05:28] stephanebisson: Oooh it's from the old email system [21:05:49] The UUID vs Formatter one that is [21:06:07] the "but received Flow\NotificationFormatter" part is false, it received null so it print the type of $this [21:06:32] lolwut [21:06:44] that's exactly what I said [21:06:53] (03PS63) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [21:07:18] (03CR) 10Catrope: [C: 032] Protect against some errors that apparently happen in production [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288704 (https://phabricator.wikimedia.org/T135196) (owner: 10Catrope) [21:07:26] (03CR) 10Catrope: [C: 032] Handle empty foreign notification sources [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288705 (https://phabricator.wikimedia.org/T135252) (owner: 10Catrope) [21:08:01] OK, so I think we have fixes for everything except "cross-wiki mark as read doesn't work" which I can't reproduce [21:08:23] But it seems to be conflated with the count cache pollution issue so maybe we need to get that fix out first [21:08:46] I'll poke at the timezone bug [21:08:56] I also can't but I often see unreadCount out of sync [21:09:10] Yeah the patch I asked matt_flaschen to review fixes that [21:09:40] RoanKattouw, yeah, you can go ahead and deploy the config. [21:09:58] RoanKattouw, but make sure you don't deploy the cache one until that's fixed, or it will re-pollute. [21:10:06] Basically, on non-SUL wikis the API for "give me the global user ID" returns the local user ID, but those wikis pollute the global cache [21:10:13] matt_flaschen: Yup [21:10:38] I'll look into the timezone error until matt_flaschen gives me the green light to deploy my cache pollution / hard disable patch [21:10:57] (03PS21) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [21:11:00] Meanwhile, stephanebisson could you poke at that Flow / old email system error? [21:11:11] I can give you a full stack trace from the logs if you like [21:11:17] RoanKattouw, it looks like $this->getMemcKey( 'echo-notification-count' ) is now in the wrong place. [21:11:19] Still reviewing. [21:11:42] (03CR) 10Sbisson: [C: 031] "Can't find any trace of xwiki during my testing with the default config." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288697 (https://phabricator.wikimedia.org/T135266) (owner: 10Catrope) [21:11:57] RoanKattouw: please do [21:12:32] https://www.irccloud.com/pastebin/QA1B6jC7/ [21:12:56] RoanKattouw: is this bad enough to deploy in a hurry on friday? [21:13:14] Hmm, not sure [21:13:18] On the one hand, it's a PHP fatal [21:13:35] On the other hand, it's while sending emails so it doesn't cause a blank response to a web request [21:13:54] On the other other hand, if the fix is simple then I think we should do it [21:14:25] RoanKattouw: I'm talking about the hard-disabe [21:14:27] disable [21:14:28] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [21:14:32] Oh, yes I think so [21:14:38] It's polluting count caches like crazy [21:14:54] ok [21:14:58] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 3 others: Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2294021 (10Quiddity) 05Ope... [21:15:25] Hmm the timezone thing is from unserializing event_extra [21:16:07] rings a bell [21:16:45] (03CR) 10Mattflaschen: [C: 04-1] Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288697 (https://phabricator.wikimedia.org/T135266) (owner: 10Catrope) [21:16:49] & RoanKattouw [21:18:21] (03Merged) 10jenkins-bot: Protect against some errors that apparently happen in production [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288704 (https://phabricator.wikimedia.org/T135196) (owner: 10Catrope) [21:18:25] (03Merged) 10jenkins-bot: Handle empty foreign notification sources [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288705 (https://phabricator.wikimedia.org/T135252) (owner: 10Catrope) [21:19:18] stephanebisson, I don't understand what you mean about it printing $this for https://phabricator.wikimedia.org/diffusion/EFLW/browse/master/includes/Notifications/Formatter.php;0f297d962c3e4c976a219820cca757fedb83db19$109 . [21:20:30] Oh I see, it's PHP being lame. [21:20:46] matt_flaschen: get_class( null ) = get_class() "prints current class name" [21:20:53] (03CR) 10Catrope: Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288697 (https://phabricator.wikimedia.org/T135266) (owner: 10Catrope) [21:22:20] matt_flaschen: --^^ [21:23:50] RoanKattouw, yeah, I saw. Did anyone test it with it enabled? [21:24:02] I haven't so far, but I can. [21:24:13] I have three wikis and I tested with the setting disabled on one and enabled on two [21:24:18] if that's what you mean [21:24:24] RoanKattouw, yeah. [21:24:28] (i.e. wiki3 did not have XWN and wiki and wiki2 did) [21:24:47] (03CR) 10Mattflaschen: [C: 032] Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288697 (https://phabricator.wikimedia.org/T135266) (owner: 10Catrope) [21:24:50] Marked some things as unread/read and verified the notification counts weren't influenced by each other [21:24:52] Yaay [21:24:59] OK I'll cherry-pick + deploy once Jenkins is done [21:25:00] Thanks matt_flaschen [21:27:57] OK so it looks there are some old rows in the database where flow-post-reply stored a DateTime in event_extra [21:28:01] It doesn't seem to do that any more [21:29:12] stephanebisson, do you know a short version of get_class that doesn't suck? You can check for null explicitly, but that's tedious, and gettype is unhelpful. [21:29:14] We use: [21:29:15] is_object( $id ) ? get_class( $id ) : gettype( $id ) [21:29:23] one place which should work. [21:30:25] mooeypoo: idk [21:31:22] I can't reproduce the email issue [21:31:36] ? hm? what? I missed something [21:32:32] April 2014 [21:33:33] mooeypoo: i think stephanebisson meant to ping me about get_class, not sure though. [21:33:38] Now I missed something though re April 2014. [21:33:40] yes [21:33:42] (03Merged) 10jenkins-bot: Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288697 (https://phabricator.wikimedia.org/T135266) (owner: 10Catrope) [21:34:00] (03CR) 10Legoktm: [C: 032] Log warning on failure to fetch foreign notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288694 (owner: 10Sbisson) [21:34:13] (03PS1) 10Catrope: Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288707 (https://phabricator.wikimedia.org/T135266) [21:34:20] (03CR) 10Catrope: [C: 032] Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288707 (https://phabricator.wikimedia.org/T135266) (owner: 10Catrope) [21:34:21] It would be nice if we could clear really old notifications (like years) by time, but that conflicts with the inbox metaphor. [21:34:35] Yeah [21:34:42] I'm trying to find the commit that changed this now [21:35:37] In any case, we'd need to reencode old echo_event blobs that don't unserialize any more [21:35:43] But first I'll deploy our fixes for today [21:38:07] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Wikimedia-log-errors: Echo: Special:Notifications Exception from line of : DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T73489#761691 (10Catrope) It looks like `flow-post-reply` events used to... [21:38:33] * RoanKattouw wonders which wikis Flow was even deployed on in April 2014 [21:39:21] RoanKattouw, any thoughts on https://phabricator.wikimedia.org/T135197 ? [21:42:24] (03Merged) 10jenkins-bot: Log warning on failure to fetch foreign notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288694 (owner: 10Sbisson) [21:43:24] (03CR) 10Legoktm: [C: 032] Add CONTRIBUTING doc to help new contributors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288532 (owner: 10Mattflaschen) [21:44:56] matt_flaschen: I'm guessing that the remaining instances of that are due to the DateTimeZone bug [21:46:20] which is triggered more now because it'll show up in the XWN of people who are inactive on mw.org except when they used Flow in 2014 [21:46:24] (03PS1) 10Sbisson: Go to first unread post if no post specified [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288709 [21:47:00] RoanKattouw: I can't reproduce the email issue but I can offer the following workaround ^ [21:47:29] this is happening in the old email formatting system, it'll go away when my HTML email formatter patch is merged [21:47:43] oooh, interesting and it's also due to deficient event_extra data? [21:48:01] Like, do newly generated events have post-id while some old ones may not? [21:49:01] I can't find the situation where they don't AND they try to generate a 'post-permalink' parameter [21:49:20] notification config can change over time [21:49:25] (03Merged) 10jenkins-bot: Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288707 (https://phabricator.wikimedia.org/T135266) (owner: 10Catrope) [21:49:38] (03Merged) 10jenkins-bot: Add CONTRIBUTING doc to help new contributors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288532 (owner: 10Mattflaschen) [21:49:48] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Wikimedia-log-errors: Echo: Special:Notifications Exception from line of : DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T73489#2294131 (10Catrope) Wikis that had Flow enabled in April 2014: -... [21:52:15] Hah, I guess it may be related to Matt's relatively new permalink code from one or two weeks ago? [21:52:26] Anyway that workaround look sgood to me [21:52:33] (03CR) 10Catrope: [C: 032] Go to first unread post if no post specified [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288709 (owner: 10Sbisson) [21:53:59] (03PS1) 10Catrope: Bump cache version for cache pollution (cross-wiki on non-SUL wikis) [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288710 (https://phabricator.wikimedia.org/T135246) [21:54:47] (03CR) 10Catrope: [C: 032] Bump cache version for cache pollution (cross-wiki on non-SUL wikis) [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288710 (https://phabricator.wikimedia.org/T135246) (owner: 10Catrope) [21:56:00] Hmm 51 Invalid parameter for message "notification-body-edit-user-talk-with-section": a:1:{s:9:"plaintext";N;} in /srv/mediawiki/php-1.28.0-wmf.1/includes/Message.php on line 1103 [21:56:59] * legoktm waves [21:57:16] Heya [21:57:21] Hey legoktm [21:57:31] As you can see we're having some fun with the fallout from yesterday :) [21:58:49] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2294156 (10Catrope) >>! In T135250#2294032, @gerritbot wrote: > Change 288705... [21:58:57] (03Merged) 10jenkins-bot: Go to first unread post if no post specified [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288709 (owner: 10Sbisson) [21:59:07] I don't think it's related to topmost. I didn't change the old formatter at all, nor did I change what was included when the event was emitted. [21:59:29] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review, and 2 others: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2294170 (10Catrope) The cache poll... [22:00:06] I'm going to go back to the Flow Parsoid bug, but feel free to ping me about Echo stuff. [22:00:13] The thing on Beta [22:00:15] I was just about to ask if there was anything I could do to help with that, except my sister just called so I need to pick her up (bbl in 30). But yeah, if you want me to look at a bug or patch, just send me a link :) [22:00:41] legoktm: I have something I'll rope you in for when you're back [22:02:16] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2294196 (10Catrope) It looks like notifications were in fact marked as read, but the counts weren't updating. So I'm gonna dupe this to {T135246}. Please reopen if you... [22:02:28] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2294197 (10Catrope) [22:02:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review, and 2 others: Bugs on notifications on wikimediafoundation wiki and office wiki, possibly due to last Notifications release - https://phabricator.wikimedia.org/T135246#2294199 (10Catrope) [22:02:46] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 06Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review, and 2 others: Wrong notification counts being shown due to cache pollution coming from non-SUL wikis - https://phabricator.wikimedia.org/T135246#2293000 (10Catrope) [22:03:18] (03Merged) 10jenkins-bot: Bump cache version for cache pollution (cross-wiki on non-SUL wikis) [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288710 (https://phabricator.wikimedia.org/T135246) (owner: 10Catrope) [22:03:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1), 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2294210 (10Catrope) You may still s... [22:04:30] 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1), 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Echo cross-wiki messages fail to load (Access to the remote domain was denied) - https://phabricator.wikimedia.org/T135197#2294213 (10Catrope) I believe any remaining issues of this sort are... [22:05:48] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1), 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2294219 (10Quiddity) >>! In T135250... [22:06:03] RoanKattouw, ^ [22:08:23] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1), 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2294220 (10Catrope) Yes, the patch... [22:11:36] quiddity: Can you give me the event ID of the svwiki notification you marked as unread? Hover the notification and tell me the value of &markasread=NNN in the URL it points to [22:13:03] RoanKattouw, 21232551 [22:13:10] Thanks [22:14:09] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review, and 2 others: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#2294239 (10Etonkovidova) Re-checked in betalabs - the editor switch is not displayed anymore. [22:14:45] Hmm nothing weird about that one [22:15:10] quiddity: Are you still not seeing that notif on mw.org? [22:17:38] RoanKattouw, I can at mw.org but not at Frwiki. For an example that I cannot see at mw.org, but can see at commonswiki: 17613 [22:17:42] I see nothing weird about those notifs on svwiki and nothing in the logs [22:17:44] (from testwiki) [22:17:47] K [22:17:52] And you just tried to view these? [22:18:04] * RoanKattouw is trying to capture whatever's happening in the logs [22:18:12] no, I'm leaving them unclicked. [22:18:23] oh, view in the flyout, yes [22:18:25] Yes [22:18:29] after hard-refresh [22:21:09] the still unread notif from Gomwiki, which isn't displaying anywhere except at Gomwiki, is 8709 [22:22:13] Weird that it's displaying on gomwiki itself though [22:22:18] I'll just have to put in Stephane's logging thing then [22:22:54] (03PS1) 10Catrope: Log warning on failure to fetch foreign notifications [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288713 [22:23:02] (03CR) 10Catrope: [C: 032] Log warning on failure to fetch foreign notifications [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288713 (owner: 10Catrope) [22:23:11] let me know if you want a screenshare, or more screenshots, or anything :) [22:23:20] (03PS1) 10Catrope: Go to first unread post if no post specified [extensions/Flow] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288714 [22:23:27] (03CR) 10Catrope: [C: 032] Go to first unread post if no post specified [extensions/Flow] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288714 (owner: 10Catrope) [22:23:58] quiddity: No, I'm good. I was just trying to correlate with logs but there doesn't seem to be anything there. This logging patch should help [22:25:38] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Cross-wiki notifications post-release high-priority issues (tracking) - https://phabricator.wikimedia.org/T135239#2294282 (10Catrope) [22:25:40] 10Notifications, 03Collab-Archive-2015-2016, 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#2294280 (10Catrope) 05duplicate>03Open Reading the enwiki report more closely, it's not about stale counts, it actually is about not being able to mark as read acro... [22:26:29] Also if you're able to see the notif on gomwiki, then this error is not of the type I thought it was [22:27:49] I just found the Gomwiki notif visible in the flyout at Pawiki, too. [22:28:13] Interesting [22:28:20] So the gomwiki notif is intermittently not visible [22:28:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review, and 2 others: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#2294299 (10jmatazzoni) 05Open>03Resolved [22:29:08] yup, and ditto for most of the others. I'm opening all the wikis I can, and selectively marking notifs as unread, to try to detect a pattern. [22:29:17] (03Merged) 10jenkins-bot: Log warning on failure to fetch foreign notifications [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288713 (owner: 10Catrope) [22:29:39] (Today is the day I'm grateful for talkpage welcome bot spam!) [22:29:48] RoanKattouw: https://phabricator.wikimedia.org/T135246 is in production? [22:30:02] etonkovidova: Yes [22:30:16] RoanKattouw: I still see wrong count on Arabic wiki :( [22:30:31] Strange :( if you mark a notification as read/unread, does it fix itself? [22:31:44] (03Merged) 10jenkins-bot: Go to first unread post if no post specified [extensions/Flow] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288714 (owner: 10Catrope) [22:32:10] RoanKattouw: well, it works - but before I Mark as read - the counter was stuck at 3 - when in fact there was only two notifications [22:32:26] Hmm OK [22:32:37] That... shouldn't happen aFAIK [22:32:43] But hopefully it'll stop happening now [22:32:50] RoanKattouw: happens quite consistently on Arabic wiki - hmm... will do it again [22:33:01] etonkovidova: Have you tried hard-refreshing? [22:33:16] Or visiting an arwiki article that you've never visited before? (e.g. Special:Random) [22:33:54] I cannot detect a pattern. It affects all notification types (flow and wikitext), and differently at all wikis, seemingly at random. [22:33:58] RoanKattouw: refresh -yes, navigating away - no, log out/log in - yes [22:34:06] quiddity: Very strange [22:34:29] etonkovidova: Hmm then I think it's the browser cache [22:35:33] quiddity: RoanKattouw This is a hardest thing today - to detect a pattern in the reported cases. I see the reported bugs in 2 cases out of, say, 7 [22:36:11] Logging is in place, now waiting for entries to appear [22:36:53] RoanKattouw, want me to leave usertalkpage messages for you at 15 different wikis? [22:36:59] Sure :) [22:38:19] RoanKattouw: what's up? [22:38:29] OK, so [22:38:43] There's a mysterious error that we don't know more about just yet, waiting for logging data on that one [22:38:48] But there is one I do know more about [22:39:02] https://phabricator.wikimedia.org/T73489 [22:40:29] It would be nice to have a good way to deal with unserialize failures for event_extra in general [22:40:46] But it seems that in this particular case, it only affects very old (2014) Flow notifications [22:40:57] And probably only on mw.org in practice, according to the logs [22:41:24] So maybe we need to find these in the DB and rebuild the event_extra data for them? [22:41:43] Or find a way to make Event objects with no event_extra be able to exist but fail canRender()? [22:47:12] quiddity: OK that worked, half of those are not showing [22:47:19] But no entries in the Echo debug log :( [22:47:34] how many unserializable event_extra rows do you think there are? [22:47:57] * quiddity takes a quick break, back in 15. [22:49:57] RoanKattouw: ok, I have an idea [22:50:08] legoktm: I haven't looked yet [22:50:29] But the presence of DateTimeZone in event_extra is a good indication [22:50:48] Aha, I found the cause [22:50:52] Of the fetch failures [22:50:54] centralauthtoken not valid [22:53:19] (03PS1) 10Catrope: Follow-up f5e9d4e: log parsing failures and API errors too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288717 [22:55:03] legoktm: What's your idea? [22:58:19] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1), 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Some cross-wiki notifications are blank in the flyout, but only at some wikis - https://phabricator.wikimedia.org/T135250#2294371 (10Catrope) It looks like t... [22:59:05] legoktm: If you know things about CentralAuth and why I'd be getting token validation failures on some wikis but not others, that would also be very helpful ---^^ [22:59:39] RoanKattouw: I was going to have EchoEvent::newFromRow() and related return false if it fails to unserialize [22:59:58] Aha [23:00:15] and have that go up the chain [23:00:18] OK [23:00:43] the token expires pretty quickly, but hrm [23:00:47] it's all server-side now right? [23:01:53] Yes [23:02:09] So Nick sent me like 12 talk page messages on different wikis [23:02:18] And when I try to view those, only half of them load [23:02:31] It's server-side using MultiHttpClient [23:03:26] uh [23:03:34] half of them work? :p [23:03:42] the token is supposed to be one use only [23:05:58] Whoa, OK [23:06:01] I did not know that [23:06:21] Is there some way a token is invalidated after use? [23:06:39] CentralAuthTokenSessionProvider::onApiCheckCanExecute() [23:06:57] $token = $module->getMain()->getVal( 'centralauthtoken' ); # Mark used [23:06:57] $key = CentralAuthUtils::memcKey( 'api-token', $token ); [23:06:57] CentralAuthUtils::getSessionCache()->delete( $key ); [23:07:11] so if it works multiple times, that's probably an accidental race condition? [23:07:16] Ugh OK [23:07:28] So I have to get N tokens instead of just one? [23:08:27] yeah... [23:08:30] Great [23:08:32] OK, well, I can do that [23:08:34] * legoktm wonders if there's a better way to do this than CA tokens [23:09:11] RoanKattouw: didn't parsoid do some forward cookie thing for private wikis? [23:09:18] Yes [23:09:27] I suppose we could try that [23:09:41] does say an enwiki cookie work on dewiktionary? [23:09:42] Gonna try the N token approach first though [23:09:48] ok, that's probably easiest for now [23:09:50] Ahm, maybe? [23:09:54] I'm not actually sure if it does [23:10:07] We could probably find the centralauth cookie and pass that along [23:10:22] (03PS22) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [23:13:37] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [23:13:53] (03PS1) 10Catrope: Don't reuse CentralAuth tokens for multiple requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288722 (https://phabricator.wikimedia.org/T135250) [23:13:54] legoktm: ---^^ [23:15:19] lgtm, pinged anomie to verify [23:19:35] (03PS1) 10Mattflaschen: Update Parsoid version string [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288725 (https://phabricator.wikimedia.org/T135268) [23:20:06] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Parsoid, 13Patch-For-Review: [betalabs] "Request to parsoid for 'wikitext' to 'html' conversion failed" for for any edits - https://phabricator.wikimedia.org/T135268#2294389 (10Mattflaschen) It turns out Parsoid changed their version string. They are going to tempo... [23:22:08] > $params['format'] = 'php'; [23:22:09] :<< [23:22:13] why not JSON? [23:24:23] I don't know, I guess we could have done that too [23:24:28] * RoanKattouw didn't write that code :P [23:24:48] If there's a reason we should use JSON we can change it [23:25:29] unserialize over the network is bad? :P https://phabricator.wikimedia.org/T118538 [23:25:41] Aha, OK, yes, good point [23:25:56] I'll write a patch for that too [23:28:55] (03PS1) 10Catrope: Use JSON instead of PHP-serialized for internal cross-wiki API requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288726 [23:30:59] legoktm: Any objections to me live-hacking that centralauthtoken patch while we wait for anomie? It's Friday evening for him so he may not respond until Monday [23:31:51] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Wikimedia-log-errors: Echo: Special:Notifications Exception from line of : DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T73489#2294400 (10Legoktm) a:03Legoktm [23:33:14] oh, right it's friday [23:33:17] (03CR) 10Legoktm: [C: 032] Don't reuse CentralAuth tokens for multiple requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288722 (https://phabricator.wikimedia.org/T135250) (owner: 10Catrope) [23:33:32] RoanKattouw: no objections [23:34:33] (03CR) 10Legoktm: [C: 032] Use JSON instead of PHP-serialized for internal cross-wiki API requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288726 (owner: 10Catrope) [23:38:06] (03PS1) 10Catrope: Handle section-text being null [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288728 [23:38:07] Thanks [23:39:15] (03Merged) 10jenkins-bot: Don't reuse CentralAuth tokens for multiple requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288722 (https://phabricator.wikimedia.org/T135250) (owner: 10Catrope) [23:40:10] (03PS2) 10Catrope: Handle section-text being null [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288728 [23:40:23] (03PS1) 10Catrope: Don't reuse CentralAuth tokens for multiple requests [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288729 (https://phabricator.wikimedia.org/T135250) [23:40:26] (03PS1) 10Legoktm: Avoid exceptions when event_extra can't be unserialized [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288730 (https://phabricator.wikimedia.org/T73489) [23:40:34] (03CR) 10Catrope: [C: 032] Don't reuse CentralAuth tokens for multiple requests [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288729 (https://phabricator.wikimedia.org/T135250) (owner: 10Catrope) [23:40:39] RoanKattouw: ^ I don't have echo set up anymore to test that [23:40:44] I do [23:41:08] (03CR) 10MaxSem: [C: 032] Handle section-text being null [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288728 (owner: 10Catrope) [23:41:09] legoktm: The errors are not as frequent as I first thought so I'll let that one ride the train [23:41:13] (03Merged) 10jenkins-bot: Use JSON instead of PHP-serialized for internal cross-wiki API requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288726 (owner: 10Catrope) [23:41:30] ok [23:41:41] (03CR) 10Legoktm: [C: 032] Handle section-text being null [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288728 (owner: 10Catrope) [23:44:07] (03CR) 10Catrope: [C: 031] Avoid exceptions when event_extra can't be unserialized [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288730 (https://phabricator.wikimedia.org/T73489) (owner: 10Legoktm) [23:47:01] (this was a very nice break from parser-land) [23:47:18] Dude thanks for drive-by fixing half my problems :D [23:47:42] (03Merged) 10jenkins-bot: Don't reuse CentralAuth tokens for multiple requests [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288729 (https://phabricator.wikimedia.org/T135250) (owner: 10Catrope) [23:47:56] haha anytime [23:48:17] And! I will be in the office on Tuesday, for reals this time. [23:49:25] Yay! [23:49:31] I have a sticker for you actually [23:49:44] That I brought back from Boston, dropped in R33, and was then found by Dan a month later [23:50:43] https://usercontent.irccloud-cdn.com/file/1ZNgjVUT/IMG_20160513_165005.jpg [23:52:04] inside!!!! [23:53:09] 03Collab-Team-2016-Apr-Jun-Q4: [production] Expandable cross-wiki bundle notification count does not get updated after some messages were marked as read - https://phabricator.wikimedia.org/T135292#2294413 (10Etonkovidova) [23:53:56] :D [23:57:43] (03Merged) 10jenkins-bot: Handle section-text being null [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288728 (owner: 10Catrope)