[00:06:44] (03CR) 10Aaron Schulz: [C: 031] Don't cache pages with outdated global notification counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288136 (owner: 10Catrope) [00:50:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1): [minor] mouse-hover over 'Mark as read/unread' displays grey background only partially - https://phabricator.wikimedia.org/T130677#2283649 (10Etonkovidova) Fixed ub betalabs - the screenshots are wi... [01:03:48] (03PS54) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [01:04:32] (03CR) 10Mooeypoo: "Answers to PS51" (0393 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [01:04:55] (03CR) 10jenkins-bot: [V: 04-1] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [01:06:26] (03PS55) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [01:09:55] (03CR) 10jenkins-bot: [V: 04-1] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [01:19:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure: Set up second External Store cluster on Beta - https://phabricator.wikimedia.org/T128417#2283665 (10Mattflaschen) a:03Mattflaschen [01:27:39] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2283673 (10Neil_P._Quinn_WMF) @jmatazzoni, we have the results for enwiki from @Krenair. Following @Petrb's suggestion, I ran the numbers for dewiki and frwiki as well. There are some str... [01:39:09] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure: Set up second External Store cluster on Beta - https://phabricator.wikimedia.org/T128417#2283675 (10Mattflaschen) [01:42:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure: Set up second External Store cluster on Beta - https://phabricator.wikimedia.org/T128417#2283677 (10Mattflaschen) Created second one (I used a less clear name the first time so I had to fix and re-run): ``` export MEDIAWIKI_STAGING_DIR; .... [01:47:20] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure: Set up Flow-specific External Store cluster on Beta (secondary to the main one) - https://phabricator.wikimedia.org/T128417#2283680 (10Mattflaschen) [02:08:02] 06Collaboration-Team-Interested, 10Notifications: "Mute" button on Echo items that you don't want to hear about anymore (was: Allow excluding pages from the link notifications) - https://phabricator.wikimedia.org/T46787#2283682 (10Mattflaschen) >>! In T46787#2231560, @Quiddity wrote: > I vaguely recall discuss... [02:09:29] Heading out, have a good night. [03:28:19] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 07I18n: Missing localization of Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134862#2283760 (10Danny_B) [04:07:13] (03PS1) 10Catrope: Use new OutputPage parameter in OutputPageCheckLastModified hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288144 [04:10:23] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 07I18n: Missing localization of Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134862#2283801 (10Catrope) >>! In T134862#2282143, @Dereckson wrote: > It could perhaps be important to get it right from the start.... [04:12:16] (03CR) 10jenkins-bot: [V: 04-1] Use new OutputPage parameter in OutputPageCheckLastModified hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288144 (owner: 10Catrope) [08:15:35] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2284124 (10Pginer-WMF) >>! In T127813#2282171, @SBisson wrote: > @jmatazzoni, is it possible that primary link going to diff for Flow post-edited, summary-edit... [08:42:28] 10Thanks, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1): Make ApiRevThankIntegrationTest->newRevId non-flaky - https://phabricator.wikimedia.org/T134582#2284171 (10Addshore) 05Open>03Resolved [09:09:59] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2284225 (10Pginer-WMF) One thing to consider is the different [[ https://stats.wikimedia.org/EN/ReportCardTopWikis.htm | volume of activity on each wiki ]]. In terms of new articles, Engl... [09:51:10] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Patrolling: Flow "mark as patrolled" links don't work (claims "Session failure") - https://phabricator.wikimedia.org/T133341#2284268 (10jeblad) Thanks for merging in the duplicates, could not find the correct task but suspected there must be one. :) [10:10:58] 06Collaboration-Team-Interested, 10Flow: Flow posts are not indexed in builtin search - https://phabricator.wikimedia.org/T62493#677888 (10Qgil) High priority, assigned to none? One of the arguments is probably wrong. :) [10:11:31] 06Collaboration-Team-Interested, 10Flow, 06Community-Liaisons: Flow posts are not indexed in builtin search - https://phabricator.wikimedia.org/T62493#2284340 (10Qgil) [10:39:02] 10Flow, 07I18n: [[MediaWiki:Flow-importer-lqt-different-author-signature-template/nb]] i18n issue - https://phabricator.wikimedia.org/T132343#2284378 (10jeblad) 05stalled>03Invalid Not sure what this was about, closing [10:43:28] 06Collaboration-Team-Interested, 10Flow: Flow pages lacks help link - https://phabricator.wikimedia.org/T131038#2284380 (10jeblad) [10:43:29] 10Flow: Flow boards and topic space should have help links - https://phabricator.wikimedia.org/T134947#2284382 (10jeblad) [11:24:31] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement: Flow posts are not indexed in builtin search - https://phabricator.wikimedia.org/T62493#2284407 (10Trizek-WMF) [11:43:24] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: WikiToLearn: Problem while converting from LiquidThreads to Flow - https://phabricator.wikimedia.org/T128949#2284437 (10cristianbaldi) Hey guys, sorry for not replying earlier. I had some other issues to take care of. In the end to make everything work (well, sort of wo... [12:14:53] 10Flow: Discussion page stuck loading only on first load. (WikiToLearn) - https://phabricator.wikimedia.org/T134984#2284524 (10cristianbaldi) [12:41:56] (03PS22) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [12:44:29] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review: FlowReplies is not firing in production - https://phabricator.wikimedia.org/T96620#2284800 (10SBisson) a:03Mattflaschen [13:32:05] (03PS23) 10Sbisson: [WIP] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [13:42:50] 10Flow: "TypeError: surface is null" on Flow page - https://phabricator.wikimedia.org/T134992#2285094 (10He7d3r) [15:35:15] (03PS24) 10Sbisson: [WIP] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [15:39:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [15:42:26] (03PS25) 10Sbisson: [WIP] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [15:42:52] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Make "mark as read" an explicit action on current no-JS version of Special:Notifications - https://phabricator.wikimedia.org/T115528#2285487 (10Pginer-WMF) >>! In T115528#2281108, @SBisson wrote: > I'm ready to m... [16:04:46] (03PS3) 10Legoktm: Reset TitleParser service after modifying $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286797 [16:05:11] (03CR) 10Legoktm: "No, that would be too magic I think." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286797 (owner: 10Legoktm) [16:07:37] (03CR) 10Daniel Kinzler: [C: 031] Reset TitleParser service after modifying $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286797 (owner: 10Legoktm) [16:09:29] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Enable Flow on Wikispecies in Beta Feature - https://phabricator.wikimedia.org/T134898#2285562 (10Trizek-WMF) a:05Archi38>03Catrope [16:09:31] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2285564 (10Catrope) >>! In T127813#2282171, @SBisson wrote: > @jmatazzoni, is it possible that primary link going to diff for Flow post-edited, summary-edited,... [16:16:28] (03CR) 10Sbisson: [C: 04-1] "I want to merge but Pau asked for small changes." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [16:23:16] (03CR) 10Addshore: [C: 032] Reset TitleParser service after modifying $wgContLang (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286797 (owner: 10Legoktm) [16:24:37] 10Flow: Discussion page stuck loading only on first load; "TypeError: $.throttle is not a function" - https://phabricator.wikimedia.org/T134984#2285627 (10Aklapper) [16:30:54] (03PS1) 10Catrope: Add missing dependency on jquery.throttle-debounce [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288223 (https://phabricator.wikimedia.org/T134984) [16:35:31] (03Merged) 10jenkins-bot: Reset TitleParser service after modifying $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286797 (owner: 10Legoktm) [16:45:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable Flow on Wikispecies in Beta Feature - https://phabricator.wikimedia.org/T134898#2285741 (10Catrope) Scheduled for deployment at 23:00 UTC today (May 11). [16:51:23] stephanebisson, what browser are you using when you took the screenshot of the NO-JS special page? [16:51:38] mooeypoo: chrome [16:51:46] and you're on a mac? [16:51:49] yep [16:52:02] hm. I think I saw something different on mine, but it makes no sense. I'm double checking now [16:52:20] I saw pau's response, I"ll fix it up [16:52:48] I can go back and make sure there's no caching involved if things don't seem to make sense [16:52:49] stephanebisson, also, I went over RoanKattouw's comments yesterday in the MVC commit - I got rid of a couple of methods that weren't used [16:52:56] fantastic [16:53:01] stephanebisson, no, I think I haven't looked at it in a while [16:53:10] yeah I'll also make a TODO list for things we should fix in the future [16:53:31] we can then see if we split them into tech debt for later or things we shuld deal with immediately [16:53:43] sure [16:53:59] stephanebisson, I hate to say it, but RoanKattouw had a point. Don't tell him I said that, he'll never know. [16:54:33] Moriel: "You're going to hate this." "No, I'm going to say I told you so" [16:54:44] *Roan: "No, I'm.... [16:54:45] ... I don't know what you're talking about. [16:55:23] Seriously, though - the problems were mostly documentation confusion, but it does expose a few issues we may have to deal with when we work with local bundles [16:55:35] not super urgent we fix it now, but good to keep in mind when we work on the bundles [16:55:49] and/or filtering [16:57:23] Filtering is primarily a server-side business. If it's a pain to integrate with our client-side code, we've done something wrong. [16:59:03] stephanebisson, yeah that shouldn't be a problem, the bundles are the bigger thing [16:59:21] I thought about that after writing. Still thinking of js filtering, but that makes no sense as we discussed [17:17:14] mooeypoo: https://gerrit.wikimedia.org/r/288223 [17:18:32] (03PS1) 10Legoktm: Reset the TitleParser service without messing up the database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288234 [17:21:57] mooeypoo: mw.echo.Controller.prototype.markSingleItemRead , this.getModel is undefined [17:22:18] * mooeypoo groans [17:22:20] thanks [17:23:22] stephanebisson: Wanna do a screenshare to poke at the caching problem? [17:23:37] I have ~30 mins until my next meeting [17:23:47] RoanKattouw: yep, in 5 minutes? [17:23:51] Sure [17:24:26] Just rejoin the meeting hangout (the one you just left) whenever you're ready [17:32:47] (03CR) 10Addshore: [C: 032] Reset the TitleParser service without messing up the database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288234 (owner: 10Legoktm) [17:34:42] (03PS23) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [17:37:10] matt_flaschen: what's the varnish port on mw-vagrant? [17:38:59] stephanebisson, 6081. [17:40:29] thanks [17:41:38] (03PS24) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [17:47:04] (03Merged) 10jenkins-bot: Reset the TitleParser service without messing up the database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288234 (owner: 10Legoktm) [17:53:24] (03PS2) 10Catrope: Don't cache pages with outdated global notification counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288136 [17:57:09] matt_flaschen: For the caching of unread count from various wikis to work correctly on my setup, we had to 1) enable the memcached role, 2) add "$wgMemCachedServers = array( '127.0.0.1:11211' );" and "$wgMainStash = CACHE_MEMCACHED;" to the config. [17:58:34] (03CR) 10Sbisson: [C: 032] Don't cache pages with outdated global notification counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288136 (owner: 10Catrope) [17:58:46] (03PS2) 10Sbisson: Use new OutputPage parameter in OutputPageCheckLastModified hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288144 (owner: 10Catrope) [17:59:08] matt_flaschen: Background: $wgMainStash defaults to 'db-replicated', but that doesn't allow for a shared cache between wikis. It doesn't have to be memcached per se (prod+beta use redis), but it has to be something with a global key space, and 'db-replicated' is effectively sharded by wiki [18:02:11] stephanebisson, RoanKattouw, okay (that's confusing how they have different sharding properties). I already have a patch up to have flow depend on memcached, I can put wgMemCachedServers in the memcached role. [18:02:19] I guess I will put wgMainStash in memcached as well, unless you think it belongs in Flow or somewhere else. [18:02:54] mooeypoo: Could you review https://gerrit.wikimedia.org/r/#/c/287632/ and its dependencies? [18:03:15] matt_flaschen: Yeah AIUI the memcached role installs memcached but doesn't actually configure MW to use it? [18:03:25] That role will probably want to set $wgMainCacheType as wel [18:04:03] RoanKattouw, it already sets wgMainCacheType and $wgObjectCaches['memcached-pecl']. [18:04:14] Oh OK [18:04:29] and maybe have Echo depend on memcached? [18:04:34] Then you can have it set $wgMainStash = 'memcached-pecl'; instead I suppose [18:04:56] Unless there's a redis role that we could use to be more like prod [18:05:26] there isn't [18:05:36] Redis is the default on Vagrant. [18:05:55] You mean redis is the default $wgMainCacheType? [18:06:03] In that case $wgMainStash should point to redis too [18:06:03] Yes [18:06:11] stephanebisson, yeah, you're right (re Echo). [18:06:34] RoanKattouw, Flow supposedly has/had problems with Redis (though I had it like that for a while and am not sure that is still the case). [18:07:05] I can drop the Flow depending on memcached for now. We're going to rewrite the caching anyway, and I'm not sure it actually has problems with memcached. [18:07:21] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2286168 (10Neil_P._Quinn_WMF) I ran the frwiki query directly rather than through Huggle, and it gave me more sensible results. ``` SELECT COUNT(*), rev_user, GROUP_CONCAT(DISTINCT rev_us... [18:08:50] (03CR) 10Catrope: [C: 04-1] Refactoring Echo's front end for MVC (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [18:08:56] (03Merged) 10jenkins-bot: Don't cache pages with outdated global notification counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288136 (owner: 10Catrope) [18:11:44] RoanKattouw, in production, $wgMemc is memcached-pecl, and $wgMainStash is 'redis_local'. So that's what I'll do. [18:12:32] OK [18:12:44] And the latter need not depend on the memc role [18:13:36] Right [18:13:52] And then Echo will work without the memc role, right? [18:15:00] RoanKattouw, Echo won't depend on memcached, but Flow will (if we want it like production), so if you're running both Flow and Echo, wgMemc will be memcached. [18:16:25] OK [18:30:25] (03CR) 10Sbisson: [C: 032] Use new OutputPage parameter in OutputPageCheckLastModified hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288144 (owner: 10Catrope) [18:36:24] (03Merged) 10jenkins-bot: Use new OutputPage parameter in OutputPageCheckLastModified hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288144 (owner: 10Catrope) [18:37:05] (03CR) 10Sbisson: [C: 032] Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [18:42:49] (03Merged) 10jenkins-bot: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [18:53:01] (03PS56) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [18:54:35] RoanKattouw, where do I add files to jsduck? [18:54:46] jsduck.json or something [18:54:52] yeah I can't see any [18:55:31] I don't think we have it [18:55:40] Ugh yeah we don't [18:55:54] So I guess we don't check or generate Echo JS documentation [18:55:57] RoanKattouw, but I did get comments from jsduck in the new files - just not ALL comments,for some reason [18:56:04] We only have jshint checking basic things like {[type]} [18:56:18] oh, that was where I got those, yeah [18:56:24] we should install jsduck [18:57:15] Yeah [18:57:56] (03CR) 10jenkins-bot: [V: 04-1] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [19:17:58] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2286410 (10Neil_P._Quinn_WMF) [19:18:10] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2268891 (10Neil_P._Quinn_WMF) [19:19:15] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2268891 (10Neil_P._Quinn_WMF) 05Open>03Resolved I think the results in the description answer the question! Thanks everybody for the help! [19:32:29] (03PS26) 10Sbisson: [WIP] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [19:37:32] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [19:41:43] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2286500 (10Krenair) >>! In T134540#2286168, @Neil_P._Quinn_WMF wrote: > I ran the frwiki query directly rather than through Huggle, and it gave me more sensible results. Against labsdb10... [19:48:42] (03PS57) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [19:50:16] (03PS27) 10Sbisson: [WIP] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [19:58:13] (03CR) 10Catrope: Refactoring Echo's front end for MVC (039 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [19:58:30] (03CR) 10Catrope: Refactoring Echo's front end for MVC (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [19:59:05] (03PS28) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [20:00:27] (03PS16) 10Sbisson: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [20:02:29] (03CR) 10Mooeypoo: "One comment in modules/controller/mw.echo.Controller.js#114" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [20:08:45] (03PS58) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [20:12:22] mooeypoo: Re the 'http' error message; what is the default error message you're referring to (approximately)? [20:13:14] mooeypoo, you can copy the jsduck setup from Flow. Let me know if there are issues. [20:14:53] (03CR) 10Sbisson: [C: 032] Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [20:16:49] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 03Collab-Archive-2015-2016, 07User-notice: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2106308 (10SBisson) [20:17:15] (03PS1) 10Catrope: Don't cache pages with outdated global notification counts [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288263 [20:17:34] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 03Collab-Archive-2015-2016, 07User-notice: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2106308 (10SBisson) Putting this back in RFP (and removed the patch tag) since the patch that wa... [20:22:41] (03CR) 10Catrope: [C: 04-1] Refactoring Echo's front end for MVC (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [20:26:41] (03Merged) 10jenkins-bot: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [20:33:35] (03PS1) 10Mooeypoo: Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 [20:33:50] RoanKattouw, matt_flaschen I copied from Flow, and fixed the errors in master ^^ [20:34:00] when it's merged, I'll run it against the MVC commit [20:35:38] (03CR) 10Catrope: [C: 04-1] Add JSDuck support and fix errors (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [20:38:26] (03PS2) 10Mooeypoo: Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 [20:38:44] (03CR) 10Mooeypoo: Add JSDuck support and fix errors (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [20:38:52] (03CR) 10Mattflaschen: [C: 04-1] "Don't need Handlebars either. Otherwise, looks good. After this is merged, do we need to request it be enabled for Jenkins?" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [20:41:53] (03CR) 10jenkins-bot: [V: 04-1] Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [20:42:07] matt_flaschen, I just fixed the handlebars thing [20:42:17] wait, what [20:42:28] ... jenkins just failed this on a file I directly copied from Flow [20:42:32] how is it not failing there [20:43:34] mooeypoo, maybe a different version of JSDuck is configured? [20:43:46] Seems to be rubocop [20:44:22] but rubocop passes for me locally [20:44:32] mooeypoo, there's too things, the rubocop are trivial, but it's also not recognizing the custom tags. [20:44:39] The npm-node ones. [20:44:40] (03CR) 10Catrope: [C: 04-1] HTML email formatter using presentation model (038 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287078 (https://phabricator.wikimedia.org/T121067) (owner: 10Sbisson) [20:44:47] :\ [20:45:58] (03PS3) 10Mooeypoo: Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 [20:46:51] matt_flaschen, no idea why this is happening... [20:47:02] (03PS4) 10Mooeypoo: Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 [20:47:08] mooeypoo, figured it out. Tt's because we disable jsdoc verification for jscs in Flow. [20:47:10] matt_flaschen, with this^^ I fixed the obvious errors [20:47:28] where? [20:47:33] .jscsrc [20:47:38] 06Collaboration-Team-Interested, 10Notifications, 10MediaWiki-Authentication-and-authorization, 06Reading-Infrastructure-Team: Update Echo to use AuthManager - https://phabricator.wikimedia.org/T110285#2286788 (10Anomie) [20:47:39] got it [20:47:43] For Echo, it asks jscs to verify jsduck 5, but it doesn't know about the custom tags. For Flow, we disable that entirely. [20:47:58] mooeypoo, let me check if we can tell jscs about the custom tags. [20:48:05] yeah I was going to look that up too [20:50:34] (03CR) 10jenkins-bot: [V: 04-1] Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [20:50:37] mooeypoo, I think you just add them to extra, where mixin is. value true means don't check the values. [20:51:12] matt_flaschen, where? [20:51:28] oh i see it [20:51:31] http://jscs.info/rule/jsDoc#checkannotations [20:51:48] And false means the tag should not have a value. [20:52:44] (03PS5) 10Mooeypoo: Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 [20:52:45] Unrelated: "The word "cache" has two main dictionary meanings, and both are used in this factory class." [20:52:54] matt_flaschen, not sure we need them all, but I added what I saw in the ruby file [20:53:06] ha [20:55:14] mooeypoo, at least some of those take arguments, and need to be true: [20:55:42] E.g.: [20:55:44] @source [20:55:45] oh the argument is whether it takes arguments... [20:55:48] gotcha [20:55:54] I thought whether or not to validate it [20:56:41] 03Collab-Team-2016-Apr-Jun-Q4: User talk pages: Mention notifications discrepancies - https://phabricator.wikimedia.org/T135049#2286835 (10Etonkovidova) [20:56:58] matt_flaschen, wait, so all of those are true [20:57:43] source ; todo ; until ; see ; this [20:57:45] right? [20:58:03] mooeypoo, yeah, I was checking, and turns out they all do. [20:58:27] (03CR) 10jenkins-bot: [V: 04-1] Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [20:58:39] (03PS6) 10Mooeypoo: Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 [20:59:02] * mooeypoo awaits jenkins' judgment [21:00:44] (03CR) 10Mattflaschen: [C: 032] Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [21:00:53] Big money! [21:00:55] * matt_flaschen rolls [21:01:20] Yeah, looks good. [21:02:12] woohoo [21:03:05] (03CR) 10jenkins-bot: [V: 04-1] Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [21:03:06] meh [21:03:08] I missed one [21:03:47] (03CR) 10Krinkle: [C: 04-1] Add JSDuck support and fix errors (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [21:04:52] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2286914 (10Neil_P._Quinn_WMF) @Krenair, against analytics-store.eqiad.wmnet (=dbstore1002). I'd guess that with such an intensive query, the labs db can't fully complete the grouping and... [21:05:43] yeah krinkle is making a good point. I'm removing 'until'. Do we use 'this' at all? [21:05:48] @this ? [21:06:59] we do in Flow, we don't in Echo [21:07:01] I'm removing that too [21:07:18] (03PS7) 10Mooeypoo: Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 [21:07:20] * mooeypoo stares at jenkins [21:07:53] (03CR) 10Mooeypoo: "Removed 'this' and 'until'" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [21:17:38] 10MediaWiki-extensions-PageCuration, 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-General-or-Unknown, 06Reading-Infrastructure-Team, 07Easy: Update PageTriage for AuthManager - https://phabricator.wikimedia.org/T135060#2287047 (10Anomie) [21:24:48] RoanKattouw, stephanebisson, Redis main stash: https://gerrit.wikimedia.org/r/#/c/288316/ [21:25:00] It's 'redis' rather than 'redis_local' because 'redis_local' doesn't exist in MWV. [21:27:35] 10Thanks, 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-General-or-Unknown, 06Reading-Infrastructure-Team, 07Easy: Update Thanks for AuthManager - https://phabricator.wikimedia.org/T135065#2287155 (10Anomie) [21:29:36] matt_flaschen: +2ed [21:29:43] (03CR) 10Mattflaschen: [C: 032] "@todo and @see are also not used by Echo JS, but they are in Flow, and seem reasonably useful and likely to be used here." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [21:38:20] (03Merged) 10jenkins-bot: Add JSDuck support and fix errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288305 (owner: 10Mooeypoo) [21:53:33] (03PS59) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [21:53:52] RoanKattouw, I just rebased the MVC patch, I'm running jsduck against it and will fix the errors [21:54:24] Thanks [21:54:27] hm we seem to need @cfg [21:54:35] or did I misname this [21:54:37] wtf surely that's in Flow? [21:54:53] oh oh [21:54:57] ok I see the issue [21:55:00] I forgot @class and @constructor [21:55:04] so jsduck is saying it's "global" [21:57:08] Heading out early today. Feel free to ping me if anything comes up. [21:57:29] meh. @inheritdoc doesn't work on external libraries like OO.SortedEmitterList [21:57:31] [21:58:55] which will be solved, btw, mostly, when the OOUI upstream version of GroupWidget is merged [22:02:23] (03PS60) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [22:02:48] RoanKattouw, were you working on the simplifying special notifications output patch? [22:05:01] (03PS5) 10Catrope: Clean up Special:Notifications output [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [22:05:05] (03Abandoned) 10Mooeypoo: [EXPERIMENTAL] Push notifications for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239766 (owner: 10Mooeypoo) [22:05:25] (03Abandoned) 10Mooeypoo: [EXPERIMENTAL-WIP] Create a basic v.0 search widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/222489 (https://phabricator.wikimedia.org/T104382) (owner: 10Mooeypoo) [22:05:55] (03Abandoned) 10Mooeypoo: [wip] Toggle the save button when there are changes to the content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235646 (owner: 10Mooeypoo) [22:05:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review, 07WorkType-NewFunctionality: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#2287337 (10Etonkovidova) Checked in betalabs. There are two paths - for logged in users and a... [22:06:02] (03CR) 10jenkins-bot: [V: 04-1] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [22:06:50] (03Abandoned) 10Mooeypoo: [wip] Adjust and clean up styles and behavior for mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237510 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [22:07:20] (03Abandoned) 10Mooeypoo: [proof of concept] Selectively disable nojs pieces when loading Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243037 (https://phabricator.wikimedia.org/T108313) (owner: 10Mooeypoo) [22:07:52] (03CR) 10Krinkle: Clean up Special:Notifications output (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [22:08:19] (03Abandoned) 10Mooeypoo: [wip] Work with table layout for the Flow sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/244755 (owner: 10Mooeypoo) [22:15:59] (03PS16) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [22:22:52] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [22:25:57] 03Collab-Team-2016-Apr-Jun-Q4, 06Team-Practices, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Collab recently closed Phlogiston report has 1000s of invalid items - https://phabricator.wikimedia.org/T133172#2287456 (10jmatazzoni) Joel writes; > Recently Closed shows the count of tasks that are marked... [22:33:30] (03CR) 10VolkerE: [C: 04-1] Clean up Special:Notifications output (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279071 (https://phabricator.wikimedia.org/T129172) (owner: 10Mooeypoo) [22:39:26] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2287531 (10jmatazzoni) @SBisson reminds me that turning each bundled notification type into an expandable bundle is a job of work that requires thinking and te... [22:51:41] (03Abandoned) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.5.1 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262883 (owner: 10Paladox) [22:53:46] 03Collab-Team-2016-Apr-Jun-Q4, 06Team-Practices, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Collab recently closed Phlogiston report has 1000s of invalid items - https://phabricator.wikimedia.org/T133172#2287614 (10JAufrecht) Recently Closed shows everything that is in the database as "resolved" now... [23:00:38] (03CR) 10Catrope: [C: 032] Don't cache pages with outdated global notification counts [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288263 (owner: 10Catrope) [23:00:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2287618 (10jmatazzoni) **PROPOSED LANGUAGE CHANGES FOR EXPANDABLE BUNDLES** Here are the more concise language formulations for messages in expandable bundles.... [23:07:02] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable Flow on Wikispecies in Beta Feature - https://phabricator.wikimedia.org/T134898#2287643 (10Catrope) 05Open>03Resolved Deployed and working: https://species.wikimedia.org/... [23:10:42] (03Merged) 10jenkins-bot: Don't cache pages with outdated global notification counts [extensions/Echo] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288263 (owner: 10Catrope) [23:22:49] (03CR) 10Catrope: [C: 04-1] Refactoring Echo's front end for MVC (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [23:37:02] 06Collaboration-Team-Interested, 10Notifications: Sort out Notification categories to make them more logical for Preferences - https://phabricator.wikimedia.org/T133220#2287710 (10jmatazzoni) [23:37:02] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 13Patch-For-Review, and 2 others: Revise Sorting of Notifications on the Fly-Out Menus - https://phabricator.wikimedia.org/T123018#2287711 (10jmatazzoni) [23:38:14] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2054765 (10jmatazzoni) a:05jmatazzoni>03None