[00:08:35] (03CR) 10Jforrester: [C: 04-2] "Per Roan, not before he merges a bunch of stuff tomorrow that'll clash with this please." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287836 (owner: 10Legoktm) [00:17:18] (03CR) 10Jforrester: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.7.1 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287858 (owner: 10Legoktm) [00:25:23] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2279152 (10jmatazzoni) NOTE: regarding the messaging text in the [[ https://docs.google.com/document/d/1KcQkOcCsoomKQGZAhe1GhB2gzSvzMr9bdiIdv178uKU/edit | Goog... [00:31:22] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.7.1 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287858 (owner: 10Legoktm) [00:41:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review, 07WorkType-NewFunctionality: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#2279188 (10Mattflaschen) I got it to work by having JS render the disabled form, while hiding... [01:22:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2279282 (10jmatazzoni) I'm sorry to be tuning into this ticket only now. Did anyone in Design approve the inter... [01:25:56] (03PS8) 10Mattflaschen: Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) [01:27:26] (03CR) 10Mattflaschen: "The last patch set changes a fair amount of stuff. It makes the permissions checking more consistent, and stops returning the write actio" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [01:56:02] (03CR) 10Legoktm: [C: 032] Make revisions in setUp for ApiRevThankIntTest [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 (https://phabricator.wikimedia.org/T134582) (owner: 10Addshore) [01:59:38] Heading out. Have a good night. [02:06:42] (03Merged) 10jenkins-bot: Make revisions in setUp for ApiRevThankIntTest [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 (https://phabricator.wikimedia.org/T134582) (owner: 10Addshore) [02:18:04] (03CR) 10Catrope: Refactoring Echo's front end for MVC (0397 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [02:18:25] (03CR) 10Catrope: [C: 04-1] "Comments on PS51 (PS52 appears to be a rebase? it only changed i18n files)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [09:16:10] 06Collaboration-Team-Interested, 10Notifications: Cross-wiki notifications get highlighted even when they have been already seen - https://phabricator.wikimedia.org/T134854#2279800 (10Pginer-WMF) [09:25:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 3 others: Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2279817 (10Trizek-WMF) >>!... [09:27:58] 06Collaboration-Team-Interested, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2279822 (10Pginer-WMF) [09:29:03] 06Collaboration-Team-Interested, 10Notifications: Make the notification highlights work better across wikis - https://phabricator.wikimedia.org/T134855#2279837 (10Pginer-WMF) [10:28:13] 10Flow, 10UI-Standardization, 07Design, 07RfC: Review unsubscribe/unwatch icon - https://phabricator.wikimedia.org/T134752#2279990 (10Pginer-WMF) [10:33:44] 10Flow, 10UI-Standardization, 07Design, 07RfC: Review unsubscribe/unwatch icon - https://phabricator.wikimedia.org/T134752#2280002 (10Pginer-WMF) [10:34:49] 10Flow, 10UI-Standardization, 07Design, 07RfC: Review unsubscribe/unwatch icon - https://phabricator.wikimedia.org/T134752#2275790 (10Pginer-WMF) >>! In T134752#2277463, @Volker_E wrote: > Hey @Pginer-WMF – as small side-note: We're in discussion about [[ https://phabricator.wikimedia.org/T133076 | direct... [12:41:22] 06Collaboration-Team-Interested, 10Flow, 10VisualEditor, 10VisualEditor-EditingTools: "Insert a link" popup is too slow after typing [[ in visual mode - https://phabricator.wikimedia.org/T107793#2280407 (10Esanders) 05Open>03declined '[[' is a helper shortcut to open the link dialog, you still need to... [13:11:15] 06Collaboration-Team-Interested, 10Flow, 10UI-Standardization, 10VisualEditor, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749049 (10Thomas_Shafee) Copied from a sh... [14:05:26] (03CR) 10Sbisson: [C: 032] Don't apply margin to dotdotdot menu items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287768 (https://phabricator.wikimedia.org/T130677) (owner: 10Catrope) [14:20:12] 10Notifications: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2280824 (10czar) [14:20:14] (03CR) 10Sbisson: [C: 04-1] "Is it possible that you created a handlebar template called "flow_header_edit_restrictions" but didn't add it to the commit?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [14:23:06] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 3 others: Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2280844 (10Trizek-WMF) 05R... [14:23:18] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 3 others: Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2280848 (10Trizek-WMF) [14:23:52] (03Merged) 10jenkins-bot: Don't apply margin to dotdotdot menu items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287768 (https://phabricator.wikimedia.org/T130677) (owner: 10Catrope) [14:24:04] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Missing localization of Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134862#2280019 (10Trizek-WMF) "Topic" is not translated in URLs too: https://no.wikipedia.org/wiki/Topic:T3nvqnmdj... [14:24:38] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Can't search in Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134865#2280855 (10Trizek-WMF) [14:24:54] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Can't search in Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134865#2280155 (10Trizek-WMF) [14:24:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 3 others: Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2207009 (10Trizek-WMF) [15:20:23] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Make "mark as read" an explicit action on current no-JS version of Special:Notifications - https://phabricator.wikimedia.org/T115528#2281079 (10SBisson) I'm ready to merge this. @Pginer-WMF can you OK the design... [15:25:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2281104 (10SBisson) [15:25:38] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Epic, 07Tracking: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2281105 (10SBisson) [15:25:41] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Make "mark as read" an explicit action on current no-JS version of Special:Notifications - https://phabricator.wikimedia.org/T115528#2281102 (10SBisson) 05duplicate>03Open Reopening: this task is about markin... [15:25:51] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice: Make "mark as read" an explicit action on current no-JS version of Special:Notifications - https://phabricator.wikimedia.org/T115528#2281108 (10SBisson) I'm ready to merge this. @Pginer-WMF can you OK the design... [16:01:12] 06Collaboration-Team-Interested, 10MediaWiki-General-or-Unknown, 10MobileFrontend, 10Reading-Web-Backlog, 07Regression: Regression: Oojs ui icons replace mw-ui-icons when Echo used - https://phabricator.wikimedia.org/T131931#2281286 (10Jdlrobson) [16:03:31] 10Flow, 10Wikimedia-Site-requests: Enable Flow on Wikispecies in Beta Feature - https://phabricator.wikimedia.org/T134898#2281297 (10Archi38) [16:14:45] 10Notifications: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2280824 (10Catrope) This hasn't always been a feature, it's relatively new. What has always been a feature is sending you emails when you receive a notification (as opposed to sending you a... [16:21:02] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Missing localization of Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134862#2280019 (10Catrope) Patch 286874 hasn't been deployed to nowiki yet. It's scheduled to be deployed there on... [16:21:44] quiddity: Verify I'm not crazy: https://phabricator.wikimedia.org/T134865 should be duped to a general "search in Flow doesn't work" task, rigt? [16:22:15] RoanKattouw, correct [16:22:39] And could you, oh finder of Phabricator tasks, find that task and dupe it? [16:22:49] (one or more already exists. I'll look after my current team meeting is over) [16:22:52] nod . :) [16:24:01] OK cool, yeah no rush [16:28:07] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Regression: [betalabs] Notification about Mention on wikitext pages does not link to the section where Mention occurred if links, templates etc are present in section titles - https://phabricator.wikimedia.org/T134216#2281458 (10Etonkovidova) [16:30:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Regression: [betalabs] Notification about Mention on wikitext pages does not link to the section where Mention occurred if links, templates etc are present in section titles - https://phabricator.wikimedia.org/T134216#2281480 (10Etonkovidova) [16:59:08] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Can't search in Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134865#2281628 (10Mattflaschen) [16:59:09] 06Collaboration-Team-Interested, 10Flow: Flow posts are not indexed in builtin search - https://phabricator.wikimedia.org/T62493#2281630 (10Mattflaschen) [17:00:52] 10Notifications: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2281651 (10Catrope) Strange. I can confirm that the emailuser notification you're talking about exists in the database. You should be able to see the name of the user who sent the email (a... [17:24:37] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Cross-wiki notifications get highlighted even when they have been already seen - https://phabricator.wikimedia.org/T134854#2281773 (10Catrope) [17:39:49] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Missing localization of Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134862#2281812 (10jeblad) We can wait, there is no hurry! =) [17:40:20] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Missing localization of Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134862#2281813 (10Catrope) Alright, then I'd prefer to let it ride the train, because SWATting localization-relate... [17:44:39] (03CR) 10Catrope: "Cross-wiki mark-as-read doesn't work, because clicking the X button on a cross-wiki notification follows the primary link." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [17:45:41] 10Notifications, 10MediaWiki-Email: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2281841 (10Mattflaschen) [17:48:26] (03PS9) 10Mattflaschen: Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) [17:49:03] (03CR) 10Mattflaschen: "Whoops, sorry, now uploaded." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [17:53:56] quiddity, I dup'ed the search bug. [17:54:07] etonkovidova, do you want to take a quick look at your Vagrant memory? [17:54:12] ah, ty (so many meetings) [17:54:42] matt_flaschen: after reload or halt - all looks fine. Or there might be something else? [18:02:35] 10Notifications, 10MediaWiki-Email: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2281940 (10czar) Are you sure it's not an issue on the side of sending the email? Because I'm using a Gmail account and I still have no record of receiving it (all mail... [18:02:40] (03CR) 10Sbisson: [C: 04-1] "Changing the sort order on a protected board brings back the "edit description" link." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [18:05:05] 10Notifications, 10MediaWiki-Email: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2280824 (1001tonythomas) There is a considerable chance that the mail would've got bounced back in between. If that is the case, logs would be found out via https://wik... [18:07:35] (03CR) 10Sbisson: [C: 032] Avoid invalid API response when server-side cross-wiki requests fail [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287672 (owner: 10Catrope) [18:17:27] 10Notifications, 10MediaWiki-Email: Emails not getting through with echo notifications - https://phabricator.wikimedia.org/T134913#2282025 (10Catrope) [18:18:13] etonkovidova, just about that out of memory you saw. Not urgent. [18:18:14] 10Notifications, 10MediaWiki-Email: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2282030 (10Catrope) >>! In T134886#2281940, @czar wrote: > Are you sure it's not an issue on the side of sending the email? Because I'm using a Gmail account and I stil... [18:18:27] 10Notifications, 10MediaWiki-Email: Emails not getting through with echo notifications - https://phabricator.wikimedia.org/T134913#2282005 (10Catrope) [18:19:13] (03Merged) 10jenkins-bot: Avoid invalid API response when server-side cross-wiki requests fail [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287672 (owner: 10Catrope) [18:23:02] (03PS4) 10Mattflaschen: Make FlowReplies slightly work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) [18:24:27] (03PS10) 10Mattflaschen: Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) [18:27:15] matt_flaschen: hmm... I am looking at Memory usage in Activity monitor for VBoxHeadless and df -H - of course, vagrant stuff is enormous [18:27:41] matt_flaschen: that's why I do vagrant halt almost every evening after workday [18:29:01] etonkovidova, yeah, I do vagrant suspend at the end of every day too. [18:29:23] etonkovidova, you can tweak how much memory it uses. If you use more, you'll have less risk of OOM, but it might impact other stuff on your machine. [18:29:29] What do you get from: [18:29:31] vagrant config --get vagrant_ram [18:29:32] free -m [18:30:05] matt_flaschen: 1536 [18:30:37] etonkovidova, how about: [18:30:39] free -m [18:30:40] matt_flaschen: free -m --- bash command not found. I usually use df -H [18:30:40] ? [18:31:17] 10Notifications, 10MediaWiki-Email: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2282110 (10Catrope) @01tonythomas was right, we recorded three bounces for @czar's email, and one of them was today: ``` mysql:research@x1-analytics-slave [wikishared]... [18:31:37] etonkovidova, do you know how much RAM you have on your laptop? https://support.apple.com/en-us/HT201464#memory can find it. [18:32:12] 1536 might be low to give to Vagrant (I have 3000, but mine is probably a little high, because of CirrusSearch), but it depends how much you have total.l [18:32:29] It's under Physical Memory. [18:33:30] matt_flaschen: Physical Memory: 8 Gb, Memory used 6.67 GB [18:34:50] etonkovidova, you could give Vagrant more RAM if you want. If you run: [18:34:51] vagrant config vagrant_ram auto [18:34:57] it will give it a quarter of your RAM, 2000. [18:36:56] 10Notifications, 10MediaWiki-Email: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2282135 (1001tonythomas) Great. I'm just curious what would ever happen a Gmail account to bounce emails from wiki@wikimedia.org ! over-quota ? [18:38:00] matt_flaschen: thx! I'll see how it will be behaving - I'll add it if I run into problems [18:38:33] (03PS53) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [18:39:03] (03CR) 10jenkins-bot: [V: 04-1] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [18:39:41] 10Notifications, 10MediaWiki-Email: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2282138 (10Catrope) >>! In T134886#2282135, @01tonythomas wrote: > Great. I'm just curious what would ever make a Gmail account to bounce emails from wiki@wikimedia.org... [18:40:57] Ran into a bug with the toggle methods. I've never really been a fan of how they can either toggle or set depending on varargs. [18:41:25] Hit a case where it being omitted triggers the toggle behavior, when really it means "missing is falsy so set to false". [18:41:43] 10Notifications, 10MediaWiki-Email: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2282142 (1001tonythomas) Ah. We are logging the full email, only once the target become unsubscribed :( https://gerrit.wikimedia.org/r/#/c/253172/ No luck there! [18:41:48] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests: Missing localization of Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134862#2280019 (10Dereckson) It could perhaps be important to get it right from the start. If not, there is a risk... [18:43:32] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement: Missing localization of Topic-namespace at nowiki - https://phabricator.wikimedia.org/T134862#2282146 (10Dereckson) [18:45:29] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-core: Community bonding evaluation for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133666#2282164 (1001tonythomas) [18:45:32] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-core: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2282163 (1001tonythomas) [18:45:47] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2282171 (10SBisson) @jmatazzoni, is it possible that primary link going to diff for Flow post-edited, summary-edited, description-edited is actually better and... [18:46:37] (03PS11) 10Mattflaschen: Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) [18:46:59] (03CR) 10Mattflaschen: "Thanks, fixed (toggle finally got its revenge)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [18:51:22] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: On protected Flow pages, remove/replace action links, and/or inform users without sufficient rights to use them - https://phabricator.wikimedia.org/T127774#2053561 (10SBisson) We typically hide the content of the sidebar... [18:51:51] (03CR) 10Sbisson: [C: 04-1] "Oups" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [18:54:17] 06Collaboration-Team-Interested, 10Flow, 10UI-Standardization, 10VisualEditor, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2282253 (10Quiddity) Here's an idea (rough... [19:02:04] matt_flaschen: About the protected Flow board, topic pages (for topics on the board) do not prevent editing the same way. I don't know if you want to do something about it... [19:03:25] They still prevent editing by responding with a message (This page has been protected to prevent editing or other actions.) but they don't disable the controls with the yellow banner like the board page does. [19:03:27] stephanebisson, I have a meeting right now. Not sure if it should be a blocker or a follow up task. [19:12:49] 10Flow, 10VisualEditor: "TypeError: cur is null" when pasting a string of text on a Flow page with VE enabled - https://phabricator.wikimedia.org/T134679#2282341 (10Jdforrester-WMF) 05Open>03stalled [19:13:12] 10Flow, 10VisualEditor: CRTL+M on VE mode has unexpected behavour on VE and on VE mode on Flow with an Azerty keyboard - https://phabricator.wikimedia.org/T134164#2282343 (10Jdforrester-WMF) 05Open>03stalled [19:19:16] 10Notifications, 10MediaWiki-Email: Received email notification on-wiki, but did not receive email - https://phabricator.wikimedia.org/T134886#2282363 (10Catrope) Looks like bounces from gmail aren't very common nor are they a particularly large percentage of our bounces, but we do get about a dozen per day: `... [19:19:42] 10Notifications, 10MediaWiki-Email: Special:EmailUser emails sometimes not delivered due to bounce - https://phabricator.wikimedia.org/T134886#2282369 (10Catrope) [19:24:56] 10Flow, 10MediaWiki-Patrolling, 10MediaWiki-Sites: Patrolling of Flow-contributions fail - https://phabricator.wikimedia.org/T134921#2282378 (10jeblad) [19:36:23] 03Collab-Team-2016-Apr-Jun-Q4: wikitext pages: Mention notifications prepend section title to text excerpts - https://phabricator.wikimedia.org/T134922#2282431 (10Etonkovidova) [19:41:26] 10Flow, 10MediaWiki-Patrolling, 10MediaWiki-Sites: Patrolling of Flow-contributions fail - https://phabricator.wikimedia.org/T134921#2282378 (10Stigmj) See T133606 [19:57:58] (03CR) 10Sbisson: "Other than the rendering issue mentioned above, the only other thing I could find was the reply box being enabled on the topic page for a " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [20:17:10] 10Flow, 10MediaWiki-Patrolling: Patrolling of topics from Flow gives "Session failure" - https://phabricator.wikimedia.org/T133606#2282590 (10jeblad) The usecase is described on T134921 [20:18:02] 10Flow, 10MediaWiki-Patrolling, 10MediaWiki-Sites: Patrolling of Flow-contributions fail - https://phabricator.wikimedia.org/T134921#2282378 (10jeblad) Some technical details on T133606 [20:26:41] (03CR) 10Sbisson: "You can add 'flow-board-description-restricted' to the classes at modules/styles/common.less:188 to hide the message when the sidebar is c" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [20:35:00] 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Community-Engagement, 06Design-Research, 05Design Research and product team collaboration, 07Surveys: Use of Notifications survey - https://phabricator.wikimedia.org/T127257#2037345 (10Capt_Swing) Findings summarized here: https://commons.wikimedia.org/wiki/... [20:38:01] 10Flow: Disable edit areas/submit buttons when editing is blocked (e.g. protected board) on topic pages too - https://phabricator.wikimedia.org/T134927#2282683 (10Mattflaschen) [20:38:10] 06Collaboration-Team-Interested, 10Flow: Disable edit areas/submit buttons when editing is blocked (e.g. protected board) on topic pages too - https://phabricator.wikimedia.org/T134927#2282695 (10Mattflaschen) [20:40:43] (03CR) 10Mattflaschen: "> Let me know if you have a quick fix in mind for this. Otherwise I think we can merge and let the follow-up be (de-)prioritized later." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [20:55:52] (03PS12) 10Mattflaschen: Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) [20:58:11] (03CR) 10Mattflaschen: "Fixed CSS. (Also changed the class name and i18n message name to be consistent with the conventions)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [21:12:57] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1): Mark not-yet-loaded foreign notifications as read fails - https://phabricator.wikimedia.org/T134579#2270002 (10Etonkovidova) Checked in betalabs - it was one of the cases that were observed 28 mess... [21:35:40] (03CR) 10Sbisson: [C: 032] Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [21:36:26] 10Flow, 10MediaWiki-Patrolling, 10MediaWiki-Sites: Patrolling of Flow-contributions fail - https://phabricator.wikimedia.org/T134921#2282916 (10Mattflaschen) [21:36:29] 10Flow, 10MediaWiki-Patrolling: Patrolling of topics from Flow gives "Session failure" - https://phabricator.wikimedia.org/T133606#2282918 (10Mattflaschen) [21:37:28] RoanKattouw, do you remember why we dropped the "phase out caching for Flow" approach (https://gerrit.wikimedia.org/r/#/c/247575/)? [21:37:42] I recall there being performance problems, but I'm having trouble finding the details. [21:39:18] RoanKattouw, found https://phabricator.wikimedia.org/T114550#1830388 [21:59:39] matt_flaschen: Yeah you'd get ~1000 SQL queries for loading a typical page without caching [22:00:02] Of course the conclusion from that isn't so much "we need to turn caching back on" as "WTF why so many queries" [22:00:07] And many of the queries turned out to be duplicates [22:00:08] RoanKattouw, it's still not backfilling, though. I thought it got reverted, but no. [22:00:16] Matthias did a patch to better reuse in-process data. [22:00:23] At the time Matthias and I solved the worst problems and called it a day [22:00:25] So it only populates on write. [22:00:34] But AFAIK it's still bad [22:00:52] Especially because a bunch of the data structures really want to be memc-backed, and behave inefficiently if they aren't [22:01:06] This can all be fine if we use a delete-on-purge, backfill-on-miss approach I think [22:01:31] Yes, I think we still need caching, and we have a pretty good understanding from last time how to do it. [22:01:32] But also some of this stuff is probably just implemented inefficiently [22:16:10] 06Collaboration-Team-Interested, 10Flow: TalkPageManager::getTalkpageManager can create user - https://phabricator.wikimedia.org/T101889#2283114 (10Catrope) [22:19:02] 06Collaboration-Team-Interested, 10Flow: TalkPageManager::getTalkpageManager can create user - https://phabricator.wikimedia.org/T101889#2283136 (10Mattflaschen) [22:19:05] 06Collaboration-Team-Interested, 10Flow: Flow issues write queries on GET (read) requests - https://phabricator.wikimedia.org/T101887#2283135 (10Mattflaschen) [22:19:41] 06Collaboration-Team-Interested, 10Flow: TalkPageManager::getTalkpageManager can create user - https://phabricator.wikimedia.org/T101889#1350529 (10Mattflaschen) Per 2016-05-10 meeting, we don't think this currently can occur on a GET request, but it's too easy to do wrong. [22:20:20] 06Collaboration-Team-Interested, 10Flow, 07Availability, 03Collab-Archive-2015-2016, 13Patch-For-Review: DB master connections requested by Flow on GET/HEAD requests - https://phabricator.wikimedia.org/T94028#2283153 (10Mattflaschen) [22:20:22] 06Collaboration-Team-Interested, 10Flow: Flow issues write queries on GET (read) requests - https://phabricator.wikimedia.org/T101887#1350486 (10Mattflaschen) 05Open>03Resolved a:03Mattflaschen [22:20:29] 06Collaboration-Team-Interested, 10Flow: Flow issues write queries on GET (read) requests - https://phabricator.wikimedia.org/T101887#1350486 (10Mattflaschen) a:05Mattflaschen>03None [22:27:12] (03CR) 10Catrope: [C: 04-1] Make FlowReplies slightly work (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) (owner: 10Mattflaschen) [22:28:30] (03PS1) 10Aaron Schulz: Set doesWrites() for EditAction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288107 [22:37:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Wikimedia-Site-requests: Enable Flow on Wikispecies in Beta Feature - https://phabricator.wikimedia.org/T134898#2283219 (10Quiddity) [22:41:44] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Regression: [production] Regression: 'Welcome to Wikipedia' notification message has W icon misaligned - https://phabricator.wikimedia.org/T132198#2283229 (10Etonkovidova) Re-checked in betalbs - 'W' icon is placed lower than it's supposed to be on Notificati... [22:49:03] (03CR) 10Catrope: [C: 032] Set doesWrites() for EditAction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288107 (owner: 10Aaron Schulz) [22:52:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 07I18n, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1): [[MediaWiki:Notification-header-flow-topic-renamed-user-talk/nb]] i18n issue - https://phabricator.wikimedia.org/T132252#2192692 (10Etonkovidova) Checked at https://translatewiki.net/w/i.php?title=S... [22:53:07] 06Collaboration-Team-Interested, 10Flow: Investigate write mode flag cleanup for Flow API modules - https://phabricator.wikimedia.org/T120543#1856116 (10Catrope) The way ApiFlow.php executes submodules is strange and duplicates code from ApiMain.php. We should refactor this to use things from ApiMain instead,... [22:53:19] RoanKattouw: or anybody knows why we do not have all beta features enabled on all betalabs wikis? For example, ruwiki does not have User flow pages [22:53:26] (03CR) 10Mattflaschen: [C: 04-1] "I removed the default from the $rigor parameter I added to getPermissionErrors, to make it more fool-proof to keep the "no master DB conne" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [22:54:27] 10Flow: Flow boards and topic space should have help links - https://phabricator.wikimedia.org/T134947#2283256 (10jeblad) [22:59:07] (03Merged) 10jenkins-bot: Set doesWrites() for EditAction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/288107 (owner: 10Aaron Schulz) [23:02:03] RoanKattouw, oh, I see. I should have checked if ext.eventLogging.subscriber was added by EL itself. [23:04:11] etonkovidova: It mirrors the production config [23:04:33] etonkovidova: Usually ruwiki beta will only have what ruwiki has in production, unless we manually make it different [23:07:12] RoanKattouw: that what I thought - actually, yeah, makes sense... ok [23:10:30] (03PS5) 10Mattflaschen: Make FlowReplies slightly work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) [23:13:44] 10Flow, 10MediaWiki-Patrolling: Patrolling of topics from Flow gives "Session failure" - https://phabricator.wikimedia.org/T133606#2283350 (10Catrope) [23:13:47] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Patrolling: Flow "mark as patrolled" links don't work (claims "Session failure") - https://phabricator.wikimedia.org/T133341#2283352 (10Catrope) [23:14:18] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10MediaWiki-Patrolling: Flow "mark as patrolled" links don't work (claims "Session failure") - https://phabricator.wikimedia.org/T133341#2228761 (10Catrope) For reproduction details see T133606 and T134921. [23:16:49] (03PS13) 10Mattflaschen: Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) [23:17:23] (03PS14) 10Mattflaschen: Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) [23:22:01] (03CR) 10Catrope: [C: 032] Make FlowReplies slightly work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) (owner: 10Mattflaschen) [23:23:00] (03CR) 10Catrope: [C: 032] "PS12 was +2ed by Stephane, and the difference between PS12 and PS14 is trivial" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [23:29:43] RoanKattouw, anything for Scrum of Scrums. So far I have: Blocking: Work continues on External Store. Blocked: Nothing (Flow dumps should be published in June if I understand correctly), Updates: cross-wiki notifications coming tomorrow! (i.e. 5/12), plaintext email formatter done, HTML email formatter in progress, MVC in-progress [23:30:10] Oh, I'll add the meeting we just had (data centers), and that we still need to do that. [23:30:10] (03Merged) 10jenkins-bot: Make FlowReplies slightly work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) (owner: 10Mattflaschen) [23:34:30] matt_flaschen: https://phabricator.wikimedia.org/T134886 might be of interest [23:35:03] TLDR: we enabled emailuser notifs by default everywhere, and now people are noticing that Special:EmailUser emails bounce occasionally (<100 per day total) [23:35:30] I talked to Chase briefly but he basically told me to collect more data [23:35:48] A man with one watch always knows what time it is. A man with two watches is never sure. [23:35:54] Yep, will do. [23:36:40] Which I agree with, we should figure out what those bounce messages look like, especially for the seemingly random ones for otherwise-working gmail addresses [23:36:56] But I was hoping that perhaps somebody in ops who knows things about email would have some pearls of wisdom [23:37:48] (03Merged) 10jenkins-bot: Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [23:40:29] out for a bit, picking up my car from the mechanics. bbl. [23:43:52] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: View and undo of board description diffs at testwiki:talk:sandbox throws InvalidDataException - https://phabricator.wikimedia.org/T119881#1838333 (10Etonkovidova) While re-checking, I clicked on 'Edit description' on https://test.wikipedia.org/wiki/Talk:Sandbox and recei... [23:55:28] 03Collab-Team-2016-Apr-Jun-Q4, 06Team-Practices, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Collab recently closed Phlogiston report has 1000s of invalid items - https://phabricator.wikimedia.org/T133172#2283514 (10JAufrecht) This is because Recently Closed shows the count of tasks that are marked re... [23:56:25] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow: View and undo of board description diffs at testwiki:talk:sandbox throws InvalidDataException - https://phabricator.wikimedia.org/T119881#2283517 (10Etonkovidova) Correction to the previous comment: `Uncaught TypeError: Cannot read property 'model' of undefined ` is disp... [23:58:08] (03PS1) 10Catrope: Don't cache pages with outdated global notification counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/288136