[00:03:32] (03CR) 10Aaron Schulz: [C: 031] Revert "Make InvalidInputException loggable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/287152 (owner: 10Catrope) [00:09:14] 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Regression: asynchronous update for cross-wiki notifications - https://phabricator.wikimedia.org/T134533#2268581 (10Catrope) This is not a security issue, I see no reason this task shouldn't be made public. [00:09:16] 03Collab-Team-2016-Apr-Jun-Q4: [betalabs] Regression: asynchronous update for cross-wiki notifications - https://phabricator.wikimedia.org/T134533#2268877 (10Catrope) [00:09:46] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: [betalabs] Regression: asynchronous update for cross-wiki notifications - https://phabricator.wikimedia.org/T134533#2268581 (10Catrope) a:03Catrope [00:10:15] (03PS1) 10Catrope: Use global user ID in global cache keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287153 (https://phabricator.wikimedia.org/T134533) [00:13:29] (03CR) 10jenkins-bot: [V: 04-1] Use global user ID in global cache keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287153 (https://phabricator.wikimedia.org/T134533) (owner: 10Catrope) [00:14:22] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2268891 (10jmatazzoni) [00:14:42] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2268904 (10jmatazzoni) [00:21:41] (03PS2) 10Catrope: Use global user ID in global cache keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287153 (https://phabricator.wikimedia.org/T134533) [00:26:21] 10Thanks, 07JavaScript, 07Technical-Debt: Thanks should not use deprecated "apitoken_edit" - https://phabricator.wikimedia.org/T134532#2268912 (10Danny_B) [00:37:23] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2268951 (10Neil_P._Quinn_WMF) [00:37:42] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2268891 (10Neil_P._Quinn_WMF) p:05Triage>03Normal [00:37:53] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10pywikibot-core, 03Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2268954 (10Mattflaschen) > Each time a user is thanked, a record of the action is added as a log entry at... [00:41:00] 10Notifications, 07Technical-Debt: Echo: Update usage of deprecated "apitoken_edit" - https://phabricator.wikimedia.org/T133802#2268958 (10Danny_B) [01:00:16] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2268891 (10Krenair) This went through my inbox and I was interested so had a go on enwiki_p: ```MariaDB [enwiki_p]> select count(*), rev_user, group_concat(distinct rev_user_text) from re... [02:06:16] 06Collaboration-Team-Interested, 10Flow: Separate user input errors from other InvalidInputException, then make re-loggable - https://phabricator.wikimedia.org/T134545#2269038 (10Mattflaschen) [02:06:50] 06Collaboration-Team-Interested, 10Flow: Separate user input errors from other InvalidInputException, then make re-loggable - https://phabricator.wikimedia.org/T134545#2269052 (10Mattflaschen) [02:07:39] (03CR) 10Mattflaschen: [C: 032] "It would be better to separate the cases that could be caused by invalid input (e.g. Topic:BogusName), vs. actual inconsistent state like " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/287152 (owner: 10Catrope) [02:11:14] Have a good night, everyone. [02:18:19] (03Merged) 10jenkins-bot: Revert "Make InvalidInputException loggable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/287152 (owner: 10Catrope) [06:47:51] (03CR) 10Fomafix: "Wrong image." (031 comment) [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/272128 (https://phabricator.wikimedia.org/T127608) (owner: 10Ori.livneh) [06:53:18] (03PS1) 10Gerrit Patch Uploader: Revert zopflipng for type-sad-dull.png [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/287173 [06:53:20] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/287173 (owner: 10Gerrit Patch Uploader) [07:38:34] (03CR) 10Fomafix: "Wrong image reverted in https://gerrit.wikimedia.org/r/287173" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/272128 (https://phabricator.wikimedia.org/T127608) (owner: 10Ori.livneh) [08:34:12] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2269340 (10Pginer-WMF) >>! In T127813#2268724, @jmatazzoni wrote: > I've taken a stab at rewriting the notifications for display in expandable-bundles. The me... [10:17:52] 10Flow, 10VisualEditor, 10VisualEditor-ContentEditable, 13Patch-For-Review: Cursor ends up inside template in Flow mention inspector (and possibly other inline templates) - https://phabricator.wikimedia.org/T133608#2269479 (10Esanders) See also T134468 [10:57:25] (03PS23) 10Zfilipin: Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [10:57:58] (03CR) 10Zfilipin: "The commit is tested here, and it ran fine for three times in a row:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [13:07:42] (03PS24) 10Zfilipin: Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [13:17:19] (03CR) 10Sbisson: [C: 032] Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [13:27:30] (03Merged) 10jenkins-bot: Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [13:59:09] Kind of jarring to see a GNU man page link to YouTube for documentation (https://www.gnu.org/software/parallel/man.html) [14:05:00] (03CR) 10Mattflaschen: [C: 032] Revert zopflipng for type-sad-dull.png [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/287173 (owner: 10Gerrit Patch Uploader) [14:06:45] (03Merged) 10jenkins-bot: Revert zopflipng for type-sad-dull.png [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/287173 (owner: 10Gerrit Patch Uploader) [14:13:13] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Mark not-yet-loaded foreign notifications as read fails - https://phabricator.wikimedia.org/T134579#2270002 (10SBisson) [14:14:12] matt_flaschen: no one reads books anymore, it has to be on tv [14:15:46] stephanebisson, yeah, it's also weird to see them linking to a site with proprietary software and codecs. [14:16:03] There are some other unique aspects, like: [14:16:17] "Your bug report should always include: [...] Whether you have watched the intro videos (http://www.youtube.com/playlist?list=PL284C9FF2488BC6D1), walked through the tutorial (man parallel_tutorial), and read the EXAMPLE section in the man page (man parallel - search for EXAMPLE:)." [14:16:39] "When using GNU parallel for a publication please cite: [citation info] This helps funding further development; and it won't cost you a cent. If you pay 10000 EUR you should feel free to use GNU Parallel without citing." [14:20:48] (03PS1) 10Addshore: Rename ApiRevThankTest to reflect file name [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287217 [14:22:56] (03CR) 10Mattflaschen: [C: 04-1] "You accidentally renamed it to have two Integration in the name." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287217 (owner: 10Addshore) [14:23:35] (03PS2) 10Addshore: Rename ApiRevThankTest to reflect file name [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287217 [14:24:42] (03CR) 10Mattflaschen: [C: 032] Rename ApiRevThankTest to reflect file name [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287217 (owner: 10Addshore) [14:28:09] (03PS1) 10Addshore: ApiRevThankIntTest try newRevId twice [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 [14:28:38] matt_flaschen: ^^ how would you feel about that? [14:31:25] (03CR) 10jenkins-bot: [V: 04-1] ApiRevThankIntTest try newRevId twice [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 (owner: 10Addshore) [14:32:18] (03PS2) 10Addshore: ApiRevThankIntTest try newRevId twice [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 [14:32:23] addshore, you're trying it three times. Why is it failing to begin with? [14:32:40] (03Merged) 10jenkins-bot: Rename ApiRevThankTest to reflect file name [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287217 (owner: 10Addshore) [14:33:38] (03PS3) 10Addshore: ApiRevThankIntTest try newRevId twice [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 [14:33:57] matt_flaschen: not sure :/ it seems to have been doing fine for years :p [14:34:57] but as the thanks tests get run with core get submit this is getting annoying :/ [14:35:52] addshore, how often does it fail? If it's frequent, I'd rather using skippedTest then do that workaround, and file a followup to fix it. It shouldn't need to use random page names, maybe that is related. [14:36:46] I have seen it 3 or so times in the past week [14:38:07] infact, maybe I'll give it a quick rewrite [14:40:11] (03PS1) 10Zfilipin: Skip Summarize feature when running Selenium tests daily [extensions/Flow] - 10https://gerrit.wikimedia.org/r/287222 (https://phabricator.wikimedia.org/T94150) [14:41:20] addshore, okay, I'll file a task and assign you. If you don't have time, you can just unassign yourself. [14:41:30] (03CR) 10Sbisson: [C: 032] Skip Summarize feature when running Selenium tests daily [extensions/Flow] - 10https://gerrit.wikimedia.org/r/287222 (https://phabricator.wikimedia.org/T94150) (owner: 10Zfilipin) [14:45:26] (03PS4) 10Addshore: Make revisions in addDBDataOnce for ApiRevThankIntTest [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 [14:48:36] (03CR) 10jenkins-bot: [V: 04-1] Make revisions in addDBDataOnce for ApiRevThankIntTest [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 (owner: 10Addshore) [14:50:43] (03Merged) 10jenkins-bot: Skip Summarize feature when running Selenium tests daily [extensions/Flow] - 10https://gerrit.wikimedia.org/r/287222 (https://phabricator.wikimedia.org/T94150) (owner: 10Zfilipin) [14:51:06] 10Thanks: Make ApiRevThankIntegrationTest->newRevId non-flaky - https://phabricator.wikimedia.org/T134582#2270114 (10Mattflaschen) [14:52:26] 10Thanks: Make ApiRevThankIntegrationTest->newRevId non-flaky - https://phabricator.wikimedia.org/T134582#2270127 (10Mattflaschen) [14:59:10] (03PS5) 10Addshore: Make revisions in setUp for ApiRevThankIntTest [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 [14:59:34] (03PS6) 10Addshore: Make revisions in setUp for ApiRevThankIntTest [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 (https://phabricator.wikimedia.org/T134582) [15:08:08] 10Flow, 10VisualEditor, 10VisualEditor-ContentEditable, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Cursor ends up inside template in Flow mention inspector (and possibly other inline templates) - https://phabricator.wikimedia.org/T133608#2270177 (10Jdforrester-WMF) 05Open>03Resolved a:03dchan [15:19:00] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Mark not-yet-loaded foreign notifications as read fails - https://phabricator.wikimedia.org/T134579#2270204 (10SBisson) a:03SBisson [15:22:19] (03CR) 10Sbisson: [C: 032] Use global user ID in global cache keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287153 (https://phabricator.wikimedia.org/T134533) (owner: 10Catrope) [15:22:40] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: [betalabs] Regression: asynchronous update for cross-wiki notifications - https://phabricator.wikimedia.org/T134533#2270228 (10SBisson) [15:22:53] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Mark not-yet-loaded foreign notifications as read fails - https://phabricator.wikimedia.org/T134579#2270229 (10SBisson) [15:24:54] (03PS1) 10Sbisson: Fetch foreign notifications before marking them as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287232 (https://phabricator.wikimedia.org/T134579) [15:27:43] (03PS2) 10Sbisson: Fetch foreign notifications before marking them as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287232 (https://phabricator.wikimedia.org/T134579) [15:28:47] (03CR) 10jenkins-bot: [V: 04-1] Use global user ID in global cache keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287153 (https://phabricator.wikimedia.org/T134533) (owner: 10Catrope) [15:31:26] (03CR) 10Sbisson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287153 (https://phabricator.wikimedia.org/T134533) (owner: 10Catrope) [15:32:45] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Mark not-yet-loaded foreign notifications as read fails - https://phabricator.wikimedia.org/T134579#2270244 (10SBisson) [15:37:58] (03CR) 10Sbisson: [C: 032] Use global user ID in global cache keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287153 (https://phabricator.wikimedia.org/T134533) (owner: 10Catrope) [15:45:22] (03Merged) 10jenkins-bot: Use global user ID in global cache keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287153 (https://phabricator.wikimedia.org/T134533) (owner: 10Catrope) [16:10:50] 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 06Community-Liaisons (Apr-Jun-2016), and 2 others: Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2270326 (10Trizek-WMF... [16:39:01] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07Epic, and 3 others: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2270410 (10jmatazzoni) [16:39:03] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki: Change "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2270423 (10jmatazzoni) [16:39:10] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Cross-wiki notifications: Make cross-wiki API requests server-side - https://phabricator.wikimedia.org/T130636#2270408 (10jmatazzoni) 05Open>03Resolved [17:20:23] Getting lunch [17:28:19] RoanKattouw: so the 2 cases that are problematic with the cache are actually the same thing: actions on a foreign wiki do not update the count locally [17:29:34] (03PS3) 10Sbisson: Fetch foreign notifications before marking them as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287232 (https://phabricator.wikimedia.org/T134579) [17:36:32] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Invite Users to Take Notifications Survey (Using Notifications Panel) - https://phabricator.wikimedia.org/T128937#2270581 (10ggellerman) [17:43:00] stephanebisson: Hmm, strange. What's $wgMainStash set to on your wiki? [17:47:49] If it's set to 'db-replicated', try setting it to CACHE_MEMCACHED instead [17:50:04] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2270628 (10jmatazzoni) Thanks Krenair! I'd like to get perspective from at least one foreign wiki. Do you know what other wikis this is popular on? German, I think... [17:54:33] stephanebisson: Looking deeper it looks like $wgMainStash defaults to 'db-replicated', but is set to 'redis_local' in both labs and production. 'redis_local', despite the name, is a shared key space across all wikis whereas 'db-replicated' is not [17:54:45] That's unhelpful, so I'll talk to Aaron [18:02:22] 06Collaboration-Team-Interested, 10Flow: Flow: Parsoid HTML for videos doesn't work - https://phabricator.wikimedia.org/T63769#668909 (10QuimGil) > The "thumb" works ok Not really. A thumbnail is created, but clicking it doesn't play the video, it leads to the File page. Reported at [[ https://ca.wikipedia.o... [18:19:08] RoanKattouw: it was set to 'db-replicated'. Setting it to either 'CACHE_MEMCACHED' or 'redis_local' errors out with: Invalid object cache type "[...]" requested. [18:19:23] Try CACHE_MEMCACHED without the quotes? [18:19:33] (It's a constant, set to 2) [18:20:30] RoanKattouw: now I get: Fatal error: Unsupported operand types in /vagrant/mediawiki/extensions/Echo/includes/NotifUser.php on line 530 [18:20:32] I suggested to Aaron that perhaps we should use getMainWANInstace() instead of getMainStashInstance() but he hasn't responded to my questions so far [18:20:46] referring to $this->cached += array_fill_keys( $keys, false ); [18:20:47] $this->cached += array_fill_keys( $keys, false ); [18:20:54] OK so one of those is not an array [18:21:05] I'm gonna go out on a limb and say array_fill_keys( ... ) is definitely an array [18:21:19] So getMulti() returned a non-array? [18:21:56] if it's the getMulti from BagOStuff.php, it's unlikely [18:22:30] of is it swapping the implementation based on the config above? [18:22:33] Yes [18:22:40] I found one code path that returns false [18:22:59] MemcachedPhpBagOStuff::getMulti() delegates to MemcachedClient::get_multi() [18:23:10] Which has if ( !$this->_active ) { return false; } [18:23:31] Hmm I guess you may not have $wgMemcachedServers set? [18:24:05] $wgMemCachedServers = array( '127.0.0.1:11211' ); , assuming you have memc running (not sure if that's a separate Vagrant role) [18:24:16] I've enabled the memcached mw-vagrant role, I was hoping that would do it [18:24:43] (03PS2) 10Legoktm: Reset TitleParser service after modifying $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286797 [18:24:48] Strange [18:25:02] I guess you could var_dump($wgMemCachedServers); in eval.php to see what it's set to [18:25:10] In any case I'll patch the return false I found [18:25:51] ok, setting $wgMemCachedServers works [18:26:09] I'll retest the scenarios I had troubles with [18:26:11] the role apparently sets $wgMainCacheType [18:26:29] and creates a $wgObjectCaches entry [18:36:21] Oh I see [18:36:42] bd808: BTW https://gerrit.wikimedia.org/r/#/c/287256/ is my fix for the return false issue [18:37:29] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 (https://phabricator.wikimedia.org/T134582) (owner: 10Addshore) [18:39:46] Maybe we should just use WANCache instead of MainStash [18:40:14] Since that defaults to $wgMainCacheType unless otherwise configured, and CentralAuth already uses it for global stuff [18:47:48] (03PS1) 10Catrope: Follow-up e520e764c4: use MainWANInstance instead of MainStashInstance in NotifUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287263 [18:49:23] 06Collaboration-Team-Interested, 10Thanks, 07user-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2270744 (10Quiddity) We need to be exact about "which" and "where". ---- **Re: "Where"** - @MGChecker Where within the pages, would you want/expect to find the Thank links? **E.g.... [18:50:39] (03CR) 10jenkins-bot: [V: 04-1] Follow-up e520e764c4: use MainWANInstance instead of MainStashInstance in NotifUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287263 (owner: 10Catrope) [18:51:06] Graah [18:51:54] OH COME ON [18:52:10] There's no interface / abstract class for "BagOStuff or WANCache, I don't care which"? [18:52:22] I guess there may be a good reason for that? [18:52:45] RoanKattouw: heh. I take it you skipped this week's rfc meeting [18:52:57] Oh right that was about PSR6 caching stuff [18:53:09] Was this issue raised there? [18:53:25] yeah, it was [18:53:32] PSR6 is crap [18:53:45] we aren't going to use it until forced [18:54:04] OK [18:54:06] I argued that swapping cache implementations is not a trivial thing [18:54:27] I had glimpsed Adam saying "the PSR6 interface is definitely not approved" but I didn't realize people thought it was crap [18:54:29] in general there are material differences in cache backends [18:54:41] That said I know nothing about PSR6. Perhaps if it wasn't annual review week I would have read up on it and attended [18:54:50] *nod* [18:55:10] (03PS2) 10Catrope: Follow-up e520e764c4: use MainWANInstance instead of MainStashInstance in NotifUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287263 [18:55:14] psr6 is the best worst compromise of a group that seems to never agree on anything [18:55:30] So, BagOStuff vs WANObjectCache incompatiblity: bug or feature? [18:55:45] see PSR7 for the next horror they want to unleash on PHP: immutable HTTP request and response objects [18:55:49] I understand that WANObjectCache has some methods and capabilities that BagOStuff doesn't have, but is the reverse also true? [18:56:24] that I'm not fully certain about, I really haven't looked closely at wancache [18:56:50] but my argument about cache swapping is that memcache, apc, redis, mysql all work very differently [18:56:56] Right [18:57:23] and the dev should know which they are choosing and why [18:57:27] In my case I am switching cache backends because the default implementation of MainStash in MW core doesn't support global keys (cross-wiki) whereas MainWAN does [18:57:32] (in prod and beta both support global keys) [18:57:54] They also behave differently wrt how likely your data is to survive, but for this application we don't care [18:58:07] swapping one bagostuff for another has caused prod problems (HHVM OOM via APC with no expiration) [18:58:25] Oh, wait, crap [18:58:51] I think with MainWAN you're not supposed to do overwriting sets, you're supposed to delete and let each DC repopulate separatley [18:58:56] That would scuttle my thing [18:59:07] (03CR) 10jenkins-bot: [V: 04-1] Follow-up e520e764c4: use MainWANInstance instead of MainStashInstance in NotifUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287263 (owner: 10Catrope) [18:59:55] (03CR) 10Catrope: [C: 04-2] "Don't merge unless Aaron says it's OK. I suspect this is not OK, because I vaguely remember being told that overwriting set()s should not " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287263 (owner: 10Catrope) [19:00:21] lol it fails tests too for reasons I don't understand [19:13:49] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2270760 (10Neil_P._Quinn_WMF) @Krenair: Thanks for doing that! Out of curiosity, why did you add the `group_concat(distinct rev_user_text)`? In case the user was renamed during the 3 months? [19:18:29] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2270764 (10Quiddity) Awesome, thanks Krenair. I've turned that into a Quarry query: https://quarry.wmflabs.org/query/9559 * (I see you've generated that using the tag_summary, i.e. "hugg... [19:21:06] 06Collaboration-Team-Interested, 10Thanks, 07user-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2270766 (10SBisson) >>! In T60485#2270744, @Quiddity wrote: > @SBisson Are there technical constraints or preferences for this? > I.e. Does each Log-type need to be coded separatel... [19:23:50] mooeypoo: RoanKattouw Should I stay on review/mooeypoo/echo-mvcis or everything is on master now? [19:24:01] echo-mvc is not in master yet [19:25:41] 03Collab-Team-2016-Apr-Jun-Q4, 10Thanks, 10MediaWiki-Special-pages, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2270771 (10Danny_B) [19:29:15] 10MediaWiki-extensions-PageCuration, 10MediaWiki-Codesniffer, 07Easy: Switch PageTriage extension to use phpcs.xml - https://phabricator.wikimedia.org/T134602#2270781 (10Legoktm) [19:35:11] ok, basic question here, I really should know that [19:35:37] I need to log from a few places to a log file, a new log file preferably [19:36:12] what's the easiest way to do that? [19:36:27] EchoHooks::onArticleSaved() has an example of debug logging [19:36:35] Though that logs to the main Echo log file [19:37:08] I guess I could add something unique to my log lines and grep... [19:37:25] A separate file should be easy to set up too [19:37:40] You replace the string 'Echo' with something else, and then you map it to a file using a $wg var I forget [19:37:42] nothing like: Logger( 'debug_001' )->log( 'blah' ); [19:37:42] * RoanKattouw looks up docs [19:38:26] Hmm there's https://www.mediawiki.org/wiki/Manual:How_to_debug#Logging which describes the "old" logging system, which is still fine to use [19:38:46] New code should use https://www.mediawiki.org/wiki/Manual:Structured_logging , but that doc page doesn't describe how to route a channel to a file [19:40:35] RoanKattouw: hmm... git branch *master ; git review -d 282677 -- fatal: Couldn't find remote ref refs/changes/77/282677/48 [19:41:42] etonkovidova: Usually that means that you are in the wrong repo [19:42:08] 282677 is in Echo, so check that you are in extensions/Echo or one of its subdirectories [19:42:08] RoanKattouw: yes ... [19:43:35] RoanKattouw: you're smart! I was just in a wrong dir :( [19:43:52] Yeah, happens to me all the time [19:44:12] Especially in VE, we had two repos, VE-MW and VE-core, and it was very easy to git review -d in the wrong directory [19:44:16] Happened at least once a week [19:46:38] bd808: Could you update https://www.mediawiki.org/wiki/Manual:Structured_logging to add how a developer running a local instance can view and route structured logs? This is clear in the docs for the old system at https://www.mediawiki.org/wiki/Manual:How_to_debug#Logging but not at all clear to me for the new system [19:47:08] s/you/you or someone who knows/ but IIRC you were the champion of the structured logging system back in the day [19:54:33] (03PS1) 10Paladox: Test [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287275 [19:55:49] (03CR) 10jenkins-bot: [V: 04-1] Make revisions in setUp for ApiRevThankIntTest [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 (https://phabricator.wikimedia.org/T134582) (owner: 10Addshore) [19:55:49] RoanKattouw: (I used the standard debug log with grep and all that) I found something disturbing... [19:55:52] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287275 (owner: 10Paladox) [19:57:04] RoanKattouw: NotifUser::resetNotificationCount, even if I remove the DeferredUpdate at the end, creates corrupted data in the db, at least on my setup [19:57:38] Oh? [19:57:41] (03CR) 10Addshore: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/287220 (https://phabricator.wikimedia.org/T134582) (owner: 10Addshore) [19:57:46] What's wrong with the data that it sets? [19:57:46] (03PS2) 10Paladox: Test [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287275 [19:57:48] RoanKattouw: if you don't install and configure Monolog then it's all the same as it ever was. There is still really no great docs on using monolog to do things. The best "docs" are the prod config but that is getting pretty complicated. [19:57:57] OK [19:58:07] So $wgDebugLogGroups still works for mapping log groups to files? [19:58:16] yes [19:58:24] Oh nice [19:58:26] I didn't realize that [20:00:00] I'm going to spend some time thinking about logging again soon-ish and propose an RfC to drop the legacy logger for Monolog as the default logging system [20:00:35] that still needs some thought though on how to make it not too hard to do the normal things people would want [20:00:48] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287275 (owner: 10Paladox) [20:01:29] Monolog opens up a wide range of options but most wikis won't want or need a very complex system [20:04:31] (03PS1) 10Addshore: Remove use of deprecated TestUser properties [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287276 [20:05:18] (03PS3) 10Paladox: Move phpcs script into phpcs.xml [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287275 (https://phabricator.wikimedia.org/T134602) [20:06:40] (03CR) 10jenkins-bot: [V: 04-1] Remove use of deprecated TestUser properties [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287276 (owner: 10Addshore) [20:08:04] (03PS2) 10Addshore: Remove use of deprecated TestUser properties [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287276 [20:10:29] 06Collaboration-Team-Interested, 10Notifications, 10UI-Standardization, 07Design, 13Patch-For-Review: Use consistent preferences icon in Echo - https://phabricator.wikimedia.org/T76513#2270976 (10Danny_B) [20:10:55] 06Collaboration-Team-Interested, 10Notifications, 10UI-Standardization, 07Design: Use consistent help icon in VE, Echo, and elsewhere - https://phabricator.wikimedia.org/T90414#2270979 (10Danny_B) [20:47:52] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2271023 (10Krenair) >>! In T134540#2270760, @Neil_P._Quinn_WMF wrote: > @Krenair: Thanks for doing that! Out of curiosity, why did you add the `group_concat(distinct rev_user_text)`? In c... [21:09:02] 06Collaboration-Team-Interested, 10Thanks, 07User-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2271111 (10MGChecker) Maybe it can lead to strange situations too, if users are allowed to thank for newusers/create and newusers/autocreate log entries, because in the first case th... [21:09:53] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2271112 (10Krenair) >>! In T134540#2270764, @Quiddity wrote: > I see you've generated that using the tag_summary, i.e. "huggle" at enwiki https://en.wikipedia.org/wiki/Special:Tags but de... [21:20:50] 06Collaboration-Team-Interested, 10Thanks, 07User-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2271126 (10Quiddity) [21:22:42] 06Collaboration-Team-Interested, 10Thanks, 07User-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#611781 (10Quiddity) >>! In T60485#2271111, @MGChecker wrote: > Maybe it can lead to strange situations too, if users are allowed to thank for newusers/create and newusers/autocreate... [21:24:39] (03PS49) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [21:29:32] (03CR) 10Aaron Schulz: "Wasn't this just a bug in some method using local user IDs? The stash can have global keys as long as nothing adds a wiki-specific part to" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287263 (owner: 10Catrope) [21:29:53] (03PS50) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [21:31:16] (03PS51) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [21:31:27] etonkovidova, I just updated the MVC commit after finding a bug in it (oops) [21:31:34] (03CR) 10Catrope: "Originally, it was, yes. I believe my code now works on beta, and will work in production, but it doesn't work locally out of the box unle" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287263 (owner: 10Catrope) [21:31:54] mooeypoo: ok. running update [21:32:01] etonkovidova, can you do 'git review -d 282677' in Echo folder? [21:32:03] not git update [21:32:10] you need to re-pull the specific patch [21:32:19] mooeypoo: ah [21:32:38] mooeypoo: commit id ? [21:32:46] from "outside" vagrant (not in SSH) go to the mediawiki/extensions/Echo folder and run git review -d 282677 [21:33:11] mooeypoo: ok - just like before [21:33:14] yup [21:33:21] (03CR) 10Legoktm: [C: 032] Move phpcs script into phpcs.xml [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287275 (https://phabricator.wikimedia.org/T134602) (owner: 10Paladox) [21:33:34] 10MediaWiki-extensions-PageCuration, 10MediaWiki-Codesniffer, 07Easy, 13Patch-For-Review: Switch PageTriage extension to use phpcs.xml - https://phabricator.wikimedia.org/T134602#2271140 (10Legoktm) 05Open>03Resolved a:03Paladox [21:50:59] 06Collaboration-Team-Interested, 10Thanks, 07User-notice: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#2271145 (10MGChecker) Please note that it depends on log_action if a newusers log thanks makes sense: * create2: A logged-in user creates another account. Maybe it's for certain tes... [21:56:44] mooeypoo: after re-pull - when opening cross-wiki notifications: load.php?debug=false&lang=en&modules=ext.centralauth.ForeignApi|ext.echo.api%2Cinit|ext.eventLoggin…:5 Uncaught TypeError: Cannot read property 'length' of undefined [21:56:50] mooeypoo: and: TypeError: items is undefined [21:59:20] She just walked away from her esk [22:04:30] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Write a FAQ about Flow - https://phabricator.wikimedia.org/T134244#2271175 (10Danny_B) [22:07:50] (03Merged) 10jenkins-bot: Move phpcs script into phpcs.xml [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/287275 (https://phabricator.wikimedia.org/T134602) (owner: 10Paladox) [22:11:54] oops [22:12:03] etonkovidova, fixing now [22:12:14] 06Collaboration-Team-Interested, 10Flow, 07Documentation: Flow: API needs documentation - https://phabricator.wikimedia.org/T60361#2271203 (10Danny_B) [22:12:40] (03CR) 10Mooeypoo: [C: 032] "WFM" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287232 (https://phabricator.wikimedia.org/T134579) (owner: 10Sbisson) [22:13:09] etonkovidova, do you have a script to run the notification generation multiple times? [22:13:13] I just made one if you want it [22:13:24] (with the help of RoanKattouw the bashgnificent) [22:14:07] 06Collaboration-Team-Interested, 10Flow, 07Documentation: Document Flow database schema - https://phabricator.wikimedia.org/T90056#2271206 (10Danny_B) [22:14:56] 06Collaboration-Team-Interested, 10Flow, 07Documentation: Diagram of Flow data types (board, topic, header, summary, etc.) - https://phabricator.wikimedia.org/T87801#2271208 (10Danny_B) [22:16:40] 10Flow: Fatal on Special:RecentChanges after installing flow - https://phabricator.wikimedia.org/T134607#2271211 (10Oschonrock) [22:17:29] 06Collaboration-Team-Interested, 10Flow, 07Documentation: Document view-topiclist reponse structure on-wiki - https://phabricator.wikimedia.org/T100246#2271223 (10Danny_B) [22:18:34] (03Merged) 10jenkins-bot: Fetch foreign notifications before marking them as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287232 (https://phabricator.wikimedia.org/T134579) (owner: 10Sbisson) [22:21:13] mooeypoo: I have stephane's script [22:21:23] mooeypoo: works well [22:28:42] stephane's script works once, though, no? or does he have a loop [22:29:36] etonkovidova, I am not seeing the bug you just told me about with the 'length of undefined' [22:30:41] mooeypoo: hmm... so for you cross-wiki notifications open fine? [22:30:46] yeah [22:31:47] etonkovidova, try 'git checkout master' then 'git pull' then 'git review -d 282677' [22:32:11] mooeypoo: understood [22:32:28] ?! That shouldn't matter [22:35:05] it shouldn't be verifying [22:37:36] etonkovidova, can you also type in Echo folder, 'git rev-parse HEAD' and tell me what the string you're getting is [22:38:32] mooeypoo: git rev-parse HEAD a40d8d408004bad9d54d3f0186e24c2b6d88fd59 [22:38:55] etonkovidova, yeah, we're on the same patchset [22:38:59] ... I am not getting that error [22:39:07] etonkovidova, all xwiki works great for me [22:42:27] mooeypoo: ok. sigh... Guess it's time to do vagrant git-update [22:43:48] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2271310 (10Petrb) Please note that older versions of Huggle do not support tagging of edits. Also in order for it to work, MediaWiki needs to know this tag. I added it myself on enwiki so... [22:44:55] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2271311 (10Petrb) Given how much broken Huggle is on other projects, it wouldn't surprise me if there were barely 20 editors on German wiki though (in last 3 months). I wanted to focus on... [22:58:44] etonkovidova, maybe check the API response, but unless that is wrong, I don't think git-update will fix a JS error. [22:59:27] Going to get dinner then continue at home. [22:59:34] matt_flaschen: git-update worked magically before :) [23:03:35] (03PS12) 10Mooeypoo: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) [23:03:38] (03PS20) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [23:07:39] (03PS13) 10Mooeypoo: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) [23:10:34] (03PS21) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [23:10:55] (03PS14) 10Mooeypoo: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) [23:17:04] 03Collab-Team-2016-Apr-Jun-Q4, 06Editing-Analysis: Identify top users of Huggle - https://phabricator.wikimedia.org/T134540#2271331 (10Krenair) >>! In T134540#2271311, @Petrb wrote: > Given how much broken Huggle is on other projects, it wouldn't surprise me if there were barely 20 editors on German wiki thoug...