[00:00:05] RoanKattouw, somewhatish ? [00:00:17] RoanKattouw, it is nicer, but we should handle the API layer [00:00:20] i didn't touch that [00:00:38] Right, that's one of the parts I didn't like in that change [00:00:47] The doubly nested object structure in the API class [00:00:48] Yeah, we need to change that [00:00:49] yeah [00:00:52] agreed [00:01:00] but I don't want to make it a blocker on the already humongous MVC [00:01:17] I did change the way the error message is displayed in xwiki though [00:01:29] there's no reason to make the message appear in each source separately now that we pull them all from local [00:01:38] if there's an error, the lists of sources are replaced by the error [00:01:43] (03CR) 10Catrope: [C: 04-1] Refactoring Echo's front end for MVC (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [00:01:49] ... wait, already? [00:01:56] Just one [00:02:02] Because Jenkins V-1ed and I pointed out why [00:02:29] oh [00:02:32] what the [00:03:33] (03PS48) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [00:06:05] I haven't actually read any of the other files :) [00:06:11] mooeypoo: So how ready is that patch now? [00:06:17] I notice the conspicuous absence of [WIP] [00:07:36] RoanKattouw, I think it's ready for reviw and testing [00:08:40] Alright [00:08:49] Let's get etonkovidova set up with it tomorrow? [00:11:33] RoanKattouw: let's do it! :) [00:11:41] Cool :) [00:11:52] Also, all blockers for cross-wiki by default are now either resolved or in QA review [00:12:01] I'm enabling cross-wiki notifications by default on labs now [00:12:39] Cool [00:12:41] yay [00:13:18] RoanKattouw, also, we just need to make sure that all features that were improved/updated/whatever since the MVC started were implemented. I think Stephane followed up on all of them, but let's make sure [00:15:10] mooeypoo: Yeah. One way to do that is go through the git log for the past few weeks and check that everything's still ther [00:17:42] Yeah [00:17:53] I think we should be okay, but I'll verify tomorrow [00:17:57] I need to do review stuff :\ [00:20:11] Yeah me too :/ [00:21:52] RoanKattouw: what happened to phabricator? Our servers are currently under maintenance or experiencing a technical problem. [00:21:59] Yeah... [00:22:04] Yeah, Mukunda is doing maintenance [00:22:05] I was just trying to check some mockups. [00:22:18] Phabricator maintenance is almost always scheduled at 5pm Pacific [00:22:39] RoanKattouw: really? never seen such error before [00:23:03] etonkovidova: Because you have healthier working hours than the rest of us ;) [00:23:17] Also maybe because Phabricator likes to give weird errors when you're upgrading it. :) [00:24:33] RoanKattouw: there were many days when I worked past 5pm - and never such message came. Besides it states that it's Varnish error [00:24:42] Oh, hah [00:24:47] Yeah people are reporting Varnish erros [00:26:08] RoanKattouw: and (sarcastically) work smarter not harder! There is a Coursera course for that - hehe [00:27:50] * RoanKattouw thanks etonkovidova for using sarcarsm markers in chat [00:27:55] *sarcasm [00:28:23] RoanKattouw: some light humor at the and of a day ... [00:28:42] RoanKattouw: phabricator is back, btw [00:29:16] 10Notifications, 10Collaboration-Community-Engagement, 03Collab-Team-2016-Apr-Jun-Q4, 07Epic, and 3 others: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2266214 (10Catrope) >>! In T130655#2266194, @gerritbot wrote: > Change 287034 had a related patch set uploaded (... [01:52:48] 10Flow, 03Collab-Archive-2015-2016, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#2266307 (10Mattflaschen) >>! In T108762#2265813, @Mattflaschen wrote: >>>! In T108762#2265797... [01:57:59] 10Flow, 03Collab-Archive-2015-2016, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#2266310 (10Mattflaschen) I might be mistaken about #2, still looking at it. [01:58:42] That patch became a rabbit hole. Will continue tomorrow. [02:01:35] (after annual reviews) [03:25:46] legoktm: I just found https://gerrit.wikimedia.org/r/#/c/286926 (through reading the email bug from this morning) and I hope that will fix the CA bug we talked about today [03:26:10] (Where freshly-attached users look like they're unattached during the request the attached them) [10:12:30] 10Flow: Pencil icon missing in Flow comment textarea - https://phabricator.wikimedia.org/T134477#2266828 (10QuimGil) [10:15:06] (03PS22) 10Zfilipin: Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [12:52:42] 10Notifications, 07I18n, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): The notifications drop down menu displays numbers using the wrong numeral system on Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T123845#2266963 (10Jdforrester-WMF) [13:04:25] (03Abandoned) 10Sbisson: [WIP] HTML email formatter using presentation models [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285720 (https://phabricator.wikimedia.org/T121067) (owner: 10Sbisson) [13:05:29] (03PS1) 10Sbisson: HTML email formatter using presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287078 (https://phabricator.wikimedia.org/T121067) [13:27:52] (03PS2) 10Sbisson: HTML email formatter using presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287078 (https://phabricator.wikimedia.org/T121067) [15:37:59] (03PS3) 10Sbisson: HTML email formatter using presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287078 (https://phabricator.wikimedia.org/T121067) [15:42:12] (03CR) 10jenkins-bot: [V: 04-1] HTML email formatter using presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287078 (https://phabricator.wikimedia.org/T121067) (owner: 10Sbisson) [15:44:59] (03PS4) 10Sbisson: HTML email formatter using presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287078 (https://phabricator.wikimedia.org/T121067) [15:45:10] 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, 03Collab-Team-2016-Apr-Jun-Q4, and 4 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2267416 (10ArielGlenn) This has been tested in a production environment and is ready to go. It will be deployed before the next run. I... [15:45:36] 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, 03Collab-Team-2016-Apr-Jun-Q4, and 4 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2267418 (10ArielGlenn) [15:48:27] 10Flow, 10Datasets-Archiving, 10Dumps-Generation, 07Blocked-on-Operations, 03Collab-Team-2016-Apr-Jun-Q4: Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#2267424 (10ArielGlenn) [16:09:16] 10Notifications, 03Collab-Archive-2015-2016, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Write email formatter that uses presentation models - https://phabricator.wikimedia.org/T121067#2267495 (10matej_suchanek) [16:09:18] 06Collaboration-Team-Interested, 10Notifications, 07Easy: Echo notification emails are sanitized strangely - https://phabricator.wikimedia.org/T68630#2267494 (10matej_suchanek) [16:13:05] 10Flow: Pencil icon missing in Flow comment textarea - https://phabricator.wikimedia.org/T134477#2267506 (10Catrope) [16:13:09] 06Collaboration-Team-Interested, 10Flow, 10UI-Standardization, 10VisualEditor, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2267505 (10Catrope) [16:14:40] stephanebisson: morning! which role you have enabled in your vagrant? cause I suspect that that weird stuff with 'VE not found' due to some of roles [16:56:45] etonkovidova: antispam, betafeatures, centralauth, checkuser, cldr, contenttranslation, doublewiki, echo, education, flow, mobilefrontend, monobook, pagetriage, parsoid, varnish, visualeditor, wikieditor, wikimediamaintenance, wikimediamessages, zend [17:38:35] 10Notifications, 03Collab-Archive-2015-2016, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Write email formatter that uses presentation models - https://phabricator.wikimedia.org/T121067#2267747 (10SBisson) [17:38:58] Breaking for lunch [18:33:06] (03Abandoned) 10Catrope: Tweak wording of cross-wiki notification beta feature description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263892 (https://phabricator.wikimedia.org/T114237) (owner: 10Catrope) [18:35:56] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), and 3 others: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2268039 (10Trizek-WMF) [18:35:58] 10Notifications, 10Collaboration-Community-Engagement, 03Collab-Team-2016-Apr-Jun-Q4, 07Epic, and 3 others: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2268040 (10Trizek-WMF) [18:55:01] matt_flaschen: vagrant git-update gives me Could not update dependencies of restbase [18:55:20] matt_flaschen: and GIT PULL failed in /vagrant/srv/zotero/translation-server for branch 'master' and GIT PULL failed in /vagrant/srv/zotero/translators for branch 'master' [18:55:51] matt_flaschen: which I do not care about much; but in my vagrant I got Error: Unknown dependency: ext.visualEditor.core [19:08:18] etonkovidova, did you provision after enabling the visualeditor role? [19:08:38] matt_flaschen: yes, of course [19:09:02] I know that the only answer is to run several times vagrant git-update :( [19:09:46] matt_flaschen: so you do not think it's something specific? [19:09:46] etonkovidova, let me check something. [19:11:30] etonkovidova, do you want to do a Hangout? [19:12:13] matt_flaschen: a sec, provision just finished running Checking again... [19:12:51] You should have a settings.d/puppet-managed/05-VisualEditor.php file. [19:13:57] matt_flaschen: nope. the same. We can do hangout [19:15:04] etonkovidova, I'll join in a second. Need to move my computer. [19:15:13] matt_flaschen: ok [19:22:42] Sorry, had to take care of something. Calling now. [19:40:12] matt_flaschen: I figured out the problem with my audio - when I connect to HDMI, it becomes default sound output although there is no speakers. Then I need to manually switch to Headphones output in my system preferences [19:41:27] Makes sense. [19:47:07] matt_flaschen: Are you usually commuting/eating/otherwise not working at 3pm Pacific? [19:47:22] RoanKattouw, no, I'm usually working then. [19:47:26] OK cool [19:47:34] Then I can invite you to this meeting [19:50:05] At first I read that as "Active Blockers for Flow", which would be a very different meeting. [19:50:12] haha [19:50:17] Yeah I was confused a bit too [19:50:32] We should just rename it to "Active Blockers for Flow Active-Active. Active" [19:50:51] Active Active/Active Blockers [19:51:09] Active Active/Active Alpha Beta Blockers [19:51:53] Cutting ahead to what this conversation is going to lead to: Jack, where John had had "had", had had "had had". "Had had" had been accepted. [19:52:29] buffalo buffalo buffalo buffalo buffalo buffalo buffalo [19:52:53] That one is my favorite. (buffalo )+ is gramatically correct. [19:59:25] RoanKattouw, Timo has thoughts on this as well. We have had meetings about this, we just haven't prioritized it aggressively. Now that we're in the home stretch on other back-end tech debt projects (Flow dumps is probably 100% done on our side, ES needs a little more work, but mostly just rollouts, not new code), it should be easier to fit it in. [19:59:40] (03PS1) 10Catrope: Follow-up 73ec3a331: fix fatal when no cross-wiki results are found [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287140 [19:59:43] Yeah, I agree [20:00:01] matt_flaschen: BTW could you merge that? ---^^ [20:00:06] Yep [20:00:55] (03CR) 10Mattflaschen: [C: 032] Follow-up 73ec3a331: fix fatal when no cross-wiki results are found [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287140 (owner: 10Catrope) [20:01:10] Interesting, we can no longer V+1. That makes sense. [20:05:42] 06Collaboration-Team-Interested, 10Collaboration-Team-Sprint-D-2015-06-30, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, and 3 others: Turn Flow on for Catalan's Viquipèdia talk namespace (quarterly goal, tracking) - https://phabricator.wikimedia.org/T99117#2268318 (10Danny_B) [20:10:04] 06Collaboration-Team-Interested, 10Flow, 07Tracking: Flow TOC first release (tracking) - https://phabricator.wikimedia.org/T78568#2268335 (10Danny_B) [20:12:07] (03Merged) 10jenkins-bot: Follow-up 73ec3a331: fix fatal when no cross-wiki results are found [extensions/Echo] - 10https://gerrit.wikimedia.org/r/287140 (owner: 10Catrope) [20:12:20] 10Flow, 07Tracking: Flow non-JavaScript issues (tracking) - https://phabricator.wikimedia.org/T85967#2268350 (10Danny_B) [20:12:42] 06Collaboration-Team-Interested, 10Flow, 10MediaWiki-Vagrant: Split Flow role - https://phabricator.wikimedia.org/T133629#2268353 (10Mattflaschen) [20:15:57] (03CR) 10Sbisson: [C: 032] Add {{GENDER}} to topic-renamed message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286999 (https://phabricator.wikimedia.org/T132252) (owner: 10Catrope) [20:16:21] 10Flow, 03Collab-Team-2016-Apr-Jun-Q4, 07I18n, 13Patch-For-Review: [[MediaWiki:Notification-header-flow-topic-renamed-user-talk/nb]] i18n issue - https://phabricator.wikimedia.org/T132252#2268366 (10SBisson) [20:18:26] 10Collaboration-Team-Sprint-P-2015-02-11/q3, 07Tracking: Update extensions maintained by Collaboration team for jQuery 1.9 changes (tracking) - https://phabricator.wikimedia.org/T85506#2268369 (10Danny_B) [20:23:15] (03Merged) 10jenkins-bot: Add {{GENDER}} to topic-renamed message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286999 (https://phabricator.wikimedia.org/T132252) (owner: 10Catrope) [20:29:31] I'll be back in a few minutes. [20:45:04] Yeah I changed the Gerrit ACL so that humans can no longer V+2 or submit in our repos [20:45:30] I suppose it would be harmless to allow V+1, but the common config in most repos with reliable CI is to forbid human V+1 [20:45:37] TBH I don't completely see why [20:46:07] human V+1 seems fine... [20:48:49] OK, I've changed it in Echo and Flow [20:48:54] Humans can now V+1 again in those repos [21:17:49] 10Thanks, 07JavaScript: Thanks should not use deprecated "apitoken_edit" - https://phabricator.wikimedia.org/T134532#2268526 (10He7d3r) [21:17:59] 10Thanks, 07JavaScript, 07Technical-Debt: Thanks should not use deprecated "apitoken_edit" - https://phabricator.wikimedia.org/T134532#2268538 (10He7d3r) [21:20:04] matt_flaschen, you touched it last, so I'll ask you... Please update L37 to say "Collab-Team(-.*)?" at https://git.wikimedia.org/blob/labs%2Ftools%2Fwikibugs2/HEAD/channels.yaml#L37 [21:23:10] RoanKattouw, I don't see why we *should* be able to V+1, but I don't really care. [21:24:18] RoanKattouw, I'm a little worried about blocking force-submits, though. We never do them, except when we really need to do them (Jenkins is mal-functioning, and something has to go to production). [21:24:27] But to be fair, that hasn't happened in a long time. [21:26:12] Yeah and in that case, somebody can edit the ACL to temporarily let you do it [21:28:16] quiddity, https://gerrit.wikimedia.org/r/287146 [21:29:23] ty :) [21:35:48] matt_flaschen: Collab(oration)?-Team(-.*)? ;-) [21:39:57] legoktm, what about Collab-Notifications-Page? ;) [21:40:19] l.?g(?:ok)?tm [21:40:34] heh [22:06:46] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Cross-wiki notifications: Make cross-wiki API requests server-side - https://phabricator.wikimedia.org/T130636#2268611 (10Etonkovidova) [22:21:06] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki: Change "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2115268 (10Etonkovidova) Checked in betalabs - cross-wiki notifications are displayed without... [22:21:42] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki: Change "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2268668 (10Etonkovidova) [22:23:18] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Cross-wiki notifications: Make cross-wiki API requests server-side - https://phabricator.wikimedia.org/T130636#2268673 (10Etonkovidova) [22:23:59] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review, 07Performance, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Cache foreign notification count in memcached - https://phabricator.wikimedia.org/T133623#2268676 (10Etonkovidova) [22:33:55] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Cross-wiki notifications: Make cross-wiki API requests server-side - https://phabricator.wikimedia.org/T130636#2141290 (10Etonkovidova) Checked in betalabs along with {T129764}. [22:35:45] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 07Crosswiki, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Cross-wiki notifications: Make cross-wiki API requests server-side - https://phabricator.wikimedia.org/T130636#2268694 (10Etonkovidova) [23:12:54] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2268724 (10jmatazzoni) I've taken a stab at rewriting the notifications for display in expandable-bundles. The messages covered are all the notification types... [23:20:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2268730 (10jmatazzoni) Question for @Pginer-WMF: what are the truncation rules for the "sub-notifications" (inside the bundle)? Are the limits different from... [23:33:26] 10Notifications, 10MediaWiki-Vagrant: Enabling the Echo Vagrant role doesn't work - https://phabricator.wikimedia.org/T133451#2232275 (10Etonkovidova) Re-checked - enabling echo roles in vagrant without centralauth role seems to be working -no errors displayed and overall everything works as usual. [23:49:44] (03PS1) 10Catrope: Revert "Make InvalidInputException loggable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/287152