[00:08:58] (03CR) 10Catrope: [C: 032] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [00:09:03] mooeypoo: your vagrant is ok? I see Error: Unknown dependency: ext.visualEditor.core -- and cannot add a topic or edit... [00:09:15] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [00:09:19] etonkovidova, mine works ... [00:09:24] did you try vagrant git-update ? [00:09:37] mooeypoo: try to edit smth with VE [00:10:29] mooeypoo: wikitext works. Do you have visualeditor role enabled? [00:11:01] mooeypoo: and yes, I need to run vagrant git-update. Will do that [00:11:21] hang on let me try and edit [00:11:25] (03PS13) 10Catrope: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [00:11:48] (03CR) 10Catrope: [C: 032] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [00:12:05] etonkovidova, I have no problems editing and saving [00:12:32] mooeypoo: good. Running vagrant git-update. Thx! [00:15:00] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [00:45:54] (03PS14) 10Catrope: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [00:47:48] (03PS1) 10Catrope: Use MultiHttpClient for server-side cross-wiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286781 [00:51:21] (03PS1) 10Mooeypoo: [wip] Adjust to local x-wiki call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 [00:51:38] (03CR) 10jenkins-bot: [V: 04-1] [wip] Adjust to local x-wiki call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (owner: 10Mooeypoo) [00:51:55] RoanKattouw, I forget. Is it supposed to show all unread alerts before read ones, regardless of timestamp? [00:52:10] matt_flaschen: What is "it"? [00:52:45] RoanKattouw, the alerts popup. [00:53:14] Yes [00:58:45] Never mind, I figured it out (just weirdness due to having a massive amount of unread alerts locally, but it's doing the right thing) [01:03:46] (03CR) 10Mattflaschen: [C: 032] Replace mark-as-read-on-click with ?markasread= URL parameter (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) (owner: 10Catrope) [01:05:38] Heading out. Have a good night. [01:08:00] 10Flow, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), 05WMF-deploy-2016-05-01_(1.27.0-wmf.23): Add topic button disabled - https://phabricator.wikimedia.org/T134060#2253685 (10Etonkovidova) Checked on m.mediawiki.org on Chrome 50/android {F3964287} [01:09:31] (03Merged) 10jenkins-bot: Replace mark-as-read-on-click with ?markasread= URL parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) (owner: 10Catrope) [01:09:47] 10Flow, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), 05WMF-deploy-2016-05-01_(1.27.0-wmf.23): Add topic button disabled - https://phabricator.wikimedia.org/T134060#2262289 (10Etonkovidova) [08:07:48] 06Collaboration-Team-Interested, 10Flow: flow_post.partial.handlebars appears after posting a message - https://phabricator.wikimedia.org/T103702#1396907 (10Pastakhov)  The problem is damaged file content in downloaded version. In downloaded version file Flow/handlebars/flow_post.handlebars contains line: ```... [08:13:20] 06Collaboration-Team-Interested, 10Flow, 10MediaWiki-extensions-ExtensionDistributor: flow_post.partial.handlebars appears after posting a message - https://phabricator.wikimedia.org/T103702#2262715 (10Pastakhov) [08:40:54] 10Flow: Embedding / Transclusion not working - Feature Request. - https://phabricator.wikimedia.org/T134347#2262768 (10Renepick) [08:46:22] (03PS1) 10Legoktm: Reset MediaWikiTitleCodec service after modifying $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286797 [08:56:56] (03CR) 10Legoktm: [C: 04-1] Reset MediaWikiTitleCodec service after modifying $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286797 (owner: 10Legoktm) [10:23:24] (03CR) 10Matthias Mullie: [C: 032] "Oh god. I had been searching for this. Why was it not near HttpFunctions.php :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286781 (owner: 10Catrope) [11:02:05] 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 06Community-Liaisons (Apr-Jun-2016): Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2263346 (10Trizek-WMF) 05stalled>... [11:02:16] 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 06Community-Liaisons (Apr-Jun-2016): Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2263350 (10Trizek-WMF) p:05Low>0... [11:24:53] 10Flow: Allow transcluding a talk page inside a wiki page (current error: "Discussions cannot be embedded yet.") - https://phabricator.wikimedia.org/T134347#2263402 (10Aklapper) [11:31:35] (03PS15) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [11:33:54] 06Collaboration-Team-Interested, 10MediaWiki-extensions-PageCuration: Page curation toolbar should show redlinks for non-existent user pages - https://phabricator.wikimedia.org/T131374#2263415 (10Aklapper) p:05Triage>03Lowest [11:51:46] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07Performance: Cache foreign notification count in memcached - https://phabricator.wikimedia.org/T133623#2263467 (10SBisson) [11:52:05] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: When opening a notification it disappears before navigating away - https://phabricator.wikimedia.org/T133975#2263468 (10SBisson) [11:53:56] (03CR) 10Sbisson: [C: 032] Clarify beta feature description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286538 (https://phabricator.wikimedia.org/T134014) (owner: 10Catrope) [11:54:06] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Clarify Notifications beta feature language on Preferences page - https://phabricator.wikimedia.org/T134014#2263470 (10SBisson) [11:57:47] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Rethink how the different types of notifications are displayed on Help:Notifications - https://phabricator.wikimedia.org/T131604#2263516 (10Qgil) [11:58:08] 10Notifications, 10Collaboration-Community-Engagement, 03Collab-Team-2016-Apr-Jun-Q4, 06Community-Liaisons (Apr-Jun-2016), 07user-notice: Prepare and review announcements concerning Cross-wiki Notifications as a by-default feature on all wikis - https://phabricator.wikimedia.org/T129643#2263519 (10Qgil) [11:58:28] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2263524 (10Qgil) [11:58:50] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation, 07Tracking: [Tracking] Update Help:Notifications - https://phabricator.wikimedia.org/T119713#2263532 (10Qgil) [11:59:16] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#2263537 (10Qgil) [12:00:14] (03Merged) 10jenkins-bot: Clarify beta feature description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286538 (https://phabricator.wikimedia.org/T134014) (owner: 10Catrope) [12:55:36] 10Flow: Allow RSS feeds to Flow history - https://phabricator.wikimedia.org/T134377#2263724 (10Trizek-WMF) [13:07:03] (03PS16) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [13:12:49] 10Flow: Allow RSS feeds to Flow history - https://phabricator.wikimedia.org/T134377#2263812 (10Trizek-WMF) [13:17:39] 10Flow: Flow shortcuts panel is not up-to-date - https://phabricator.wikimedia.org/T134380#2263817 (10Trizek-WMF) [13:21:41] 06Collaboration-Team-Interested, 10Flow, 07Tracking: Flow's keyboard-shortcuts / access-keys / hotkeys (tracking) - https://phabricator.wikimedia.org/T108739#2263848 (10Trizek-WMF) [13:21:43] 10Flow: Flow shortcuts panel is not up-to-date - https://phabricator.wikimedia.org/T134380#2263849 (10Trizek-WMF) [13:27:05] (03PS17) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [13:30:53] (03PS18) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [13:33:48] (03PS19) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [14:01:46] (03PS20) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [15:01:17] 06Collaboration-Team-Interested, 10Flow, 10MediaWiki-extensions-ExtensionDistributor: flow_post.partial.handlebars appears after posting a message - https://phabricator.wikimedia.org/T103702#2264166 (10Mattflaschen) [15:02:05] 10Flow, 10VisualEditor: CRTL+M on VE mode has unexpected behavour on VE and on VE mode on Flow with an Azerty keyboard - https://phabricator.wikimedia.org/T134164#2256404 (10Esanders) I can't reproduce by just changing by keyboard layout (Ubuntu). Can you reproduce on a clean machine? [15:04:22] 10Flow, 10VisualEditor: CRTL+M on VE mode has unexpected behavour on VE and on VE mode on Flow with an Azerty keyboard - https://phabricator.wikimedia.org/T134164#2264196 (10Trizek-WMF) a:03Trizek-WMF I'll try as soon as I can (next week). [15:16:39] 06Collaboration-Team-Interested, 10Flow, 10MediaWiki-extensions-ExtensionDistributor: flow_post.partial.handlebars appears after posting a message - https://phabricator.wikimedia.org/T103702#1396907 (10Mattflaschen) I added a workaround to the Extension:Flow page. [15:19:18] 06Collaboration-Team-Interested, 10Flow: Allow transcluding a talk page inside a wiki page (current error: "Discussions cannot be embedded yet.") - https://phabricator.wikimedia.org/T134347#2264272 (10Mattflaschen) [15:20:45] (03CR) 10Mattflaschen: "Should this be in setMwGlobals, or is that too magic?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286797 (owner: 10Legoktm) [15:30:39] (03PS21) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [15:38:31] (03PS1) 10Mattflaschen: Add Topic alias (Sak) for Norwegian Bokmål [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286874 (https://phabricator.wikimedia.org/T132693) [16:26:58] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Clarify Notifications beta feature language on Preferences page - https://phabricator.wikimedia.org/T134014#2264638 (10Etonkovidova) Checked in betalabs. {F3966649} [16:34:30] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Clarify Notifications beta feature language on Preferences page - https://phabricator.wikimedia.org/T134014#2264648 (10Etonkovidova) [16:35:03] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Clarify Notifications beta feature language on Preferences page - https://phabricator.wikimedia.org/T134014#2264649 (10jmatazzoni) 05Open>03Resolved [16:36:14] (03CR) 10Matthias Mullie: Let frontend always query local for foreign sources, instead of those foreign APIs (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [16:48:23] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): When opening a notification it disappears before navigating away - https://phabricator.wikimedia.org/T133975#2250870 (10Etonkovidova) Checked in betalabs - when Notification is clicked, the open flyo... [16:48:33] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): When opening a notification it disappears before navigating away - https://phabricator.wikimedia.org/T133975#2264692 (10Etonkovidova) [17:06:05] (03CR) 10Catrope: Let frontend always query local for foreign sources, instead of those foreign APIs (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [17:06:50] mlitn: FYI, mooeypoo started https://gerrit.wikimedia.org/r/#/c/286782/ last night [17:07:24] (03CR) 10Catrope: [C: 032] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [17:08:20] (03CR) 10Catrope: "I know :/ . Also, apparently you can either have a nice API that returns Status objects and has an easy getContent function (MWHttpRequest" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286781 (owner: 10Catrope) [17:13:26] (03Merged) 10jenkins-bot: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [17:15:32] (03Merged) 10jenkins-bot: Use MultiHttpClient for server-side cross-wiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286781 (owner: 10Catrope) [17:18:51] (03CR) 10Catrope: [C: 032] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [17:22:21] RoanKattouw: \o/ [17:26:43] (03CR) 10jenkins-bot: [V: 04-1] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [17:35:43] (03PS22) 10Sbisson: Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [17:35:58] ^ manual rebase [18:01:37] 06Collaboration-Team-Interested, 10Notifications, 10Security-Reviews, 06Security-Team: Security review for cross-wiki aspects of Echo notifications - https://phabricator.wikimedia.org/T112792#2265047 (10Catrope) 05Open>03Resolved a:03Catrope We've just merged it, and it'll go in next week's train. Th... [18:06:17] (03Draft1) 10Addshore: Stop using deprecated WatchedItem methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286921 [18:08:33] (03CR) 10Catrope: [C: 032] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [18:12:07] (03CR) 10Catrope: [C: 032] Stop using deprecated WatchedItem methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286921 (owner: 10Addshore) [18:17:47] (03Merged) 10jenkins-bot: Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [18:19:08] Getting lunch [18:21:48] (03Merged) 10jenkins-bot: Stop using deprecated WatchedItem methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286921 (owner: 10Addshore) [18:28:42] 06Collaboration-Team-Interested, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2265129 (10jmatazzoni) [18:28:44] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): When opening a notification it disappears before navigating away - https://phabricator.wikimedia.org/T133975#2265128 (10jmatazzoni) 05Open>03Resolved [19:10:57] hm i'm getting API errors [19:11:17] only when I try to reach remote wiki with fetch and notwikis params... I get "Argument 1 passed to ApiResult::setIndexedTagName() must be an instance of array, null given" [19:11:27] Do I need to rebase onto something different? [19:12:41] (03PS2) 10Mooeypoo: [wip] Adjust to local x-wiki call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 [19:12:57] (03CR) 10jenkins-bot: [V: 04-1] [wip] Adjust to local x-wiki call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (owner: 10Mooeypoo) [19:13:16] RoanKattouw, can you remind me how I rebase onto master away from the current patchset I'm rebased onto? [19:13:29] git rebase --onto master HEAD^ ? [19:13:32] Yes [19:13:54] * mooeypoo attempts [19:14:14] That means "rebase this and only this change directly onto master, do not attempt to carry over any other changes this is based on even if you think they aren't in master" [19:14:43] (Because a normal "git rebase master" will find all changes below that aren't in master and take those along for the ride too) [19:15:00] (03PS3) 10Mooeypoo: [wip] Adjust to local x-wiki call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 [19:15:15] Right, that's what I remembered, but I wasn't sure about the --onto master [19:16:10] still getting this error. [19:16:45] Hmm [19:16:49] Looking [19:17:44] mooeypoo: Is there a line number in that error message? What were the request parameters you (or your code) sent to api.php to get that error? [19:18:13] But that also exposed another issue of error handling [19:18:17] I'm fixing that first [19:18:22] (03CR) 10jenkins-bot: [V: 04-1] [wip] Adjust to local x-wiki call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (owner: 10Mooeypoo) [19:18:44] What the ... [19:18:45] [Wed May 04 12:18:24.179710 2016] [:error] [pid 4887] [client 127.0.0.1:38164] PHP Fatal error: Cannot override final method EchoEventPresentationModel::getType() in /home/catrope/git/mediawiki/extensions/Flow/includes/Notifications/MentionPresentationModel.php on line 0 [19:18:47] ... wait, it stopped happening [19:18:49] wtf [19:19:07] * RoanKattouw shakes fist at stephanebisson [19:19:12] It's probably the email formatter patch [19:19:31] ok there we go [19:19:32] who? me? [19:19:39] it is intermittently happening [19:20:27] stephanebisson: I found it, fixing [19:20:40] yeah, I see [19:20:44] The flow-mention presentation model class has a getType() method that we'll have to rename out of the way [19:21:36] RoanKattouw: you'll be doing this code a favour by giving this function a meaningful name [19:21:56] Which one, the Flow one or the Echo one [19:22:06] the Flow one [19:22:12] (03PS1) 10Catrope: Rename MentionPresentationModel::getType() to avoid conflict with I4eceaf521315 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286943 [19:22:28] I renamed it to getMentionType() in PS1, happy to use another name [19:22:34] 'type', while very generic, has a well defined meaning in the context of echo events [19:22:45] I guess it's more like post type? [19:22:54] It returns 'post' or 'post-summary' [19:22:55] but for Flow, we're really talking about revisionType [19:23:00] or post-type [19:23:06] Oh, revision-type [19:23:08] in the code of the function [19:23:10] I'll use that [19:23:12] but 'type' doesn't hint at it at all [19:23:36] (03PS2) 10Catrope: Rename MentionPresentationModel::getType() to avoid conflict with I4eceaf521315 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286943 [19:24:15] ^ did you test it? [19:24:18] Yes [19:24:34] (03CR) 10Sbisson: [C: 032] Rename MentionPresentationModel::getType() to avoid conflict with I4eceaf521315 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286943 (owner: 10Catrope) [19:24:34] To the extent of "updating Echo caused 500s from the API, with this patch I get 200s from the API" [19:24:43] stephanebisson, 'type' has meaning in the UI that is different than the API. Also, 'category' in the API. fml. [19:25:45] mooeypoo: yeah.... [19:26:15] mooeypoo: so alert/message/all is what in the API, category? [19:27:17] nope [19:27:25] well, yes and no [19:27:35] No, section [19:27:47] great [19:27:47] Not to be confused with wikitext sections of course [19:28:22] so in the API, alert/message/all are sections [19:28:23] Whatever we end up working on next quarter, we will have consistent naming so help me $DEITY [19:28:44] and then in notification data, 'type' is a notification type (like 'user-edit-talk' or something) [19:28:49] which seems to be the same as category [19:28:55] No, not the same as category [19:29:00] not quite [19:29:07] What's the difference? [19:29:10] Categories contain multiple types, but some categories contain only one type and have the same name as that type [19:29:19] ahha [19:29:24] what do we do with those categories? [19:29:24] edit-user-talk is one of those I think [19:29:31] But 'flow' is also a category [19:29:43] but it sounds like renaming 'type' (alert, message) to 'section' in the Echo front-end would already be better [19:29:46] The grid of checkboxes on the preferences page is controlled by categories [19:30:11] There are also notify types (email/web), since that terminology was already used and I couldn't think of anything better. [19:30:27] matt_flaschen: distributionType in the code [19:30:31] mostly ;) [19:30:38] In your code, not his code ;) [19:30:43] (03Merged) 10jenkins-bot: Rename MentionPresentationModel::getType() to avoid conflict with I4eceaf521315 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286943 (owner: 10Catrope) [19:30:45] But other than that on the backend type is always individual types like flow-new-topic. [19:31:12] stephanebisson, is that a suggestion, or is that actually used somewhere? I like how it sounds less like notification type. [19:31:22] (Stephane's code being the email formatter as associated infrastructure, Matt's being the preferences+settings interpretation code) [19:31:27] *and associated [19:31:31] matt_flaschen: it's there [19:31:39] matt_flaschen: It's used, though in fairness half the code using it only landed an hour ago [19:31:50] https://gerrit.wikimedia.org/r/249885 [19:31:57] It's not quite the same thing, though. [19:32:12] Since there are multiple kinds of email, e.g. emaildigest and emailsubject. [19:32:19] This is just 'web' or 'email', period. [19:32:31] Yeah but I don't think those result in different $distributionType values, do they? [19:32:48] Yes [19:32:54] git grep distributionType includes/formatters/ [19:33:11] You need 'web' or 'email' alone, since that's what's in preferences. [19:33:44] jmatazzoni___, RoanKattouw, jmatazzoni___, unrelated question while we're here, should I remove all the POST actions from the topic menu if the board is protected? [19:34:00] For some of them currently (e.g. 'edit topic title', it just shows the message when you open the editor), but that's not possible for 'Mark as resolved' [19:34:11] Sounds good to me [19:34:19] We already remove them if you are an anon, rihgt? [19:34:33] RoanKattouw, I think anons are allowed to do them. [19:34:53] I mean, we remove actions anons aren't allowed to do [19:35:04] The dropdowns are a lot shorter when I'm an anon [19:35:32] RoanKattouw, right, the admin actions are only for admin. [19:35:51] matt_flaschen: For jmatazzoni___ 's benefit: context is https://phabricator.wikimedia.org/T127774 right? [19:36:02] RoanKattouw, yes. [19:36:33] Can you gray them out instead of removing them? [19:36:45] That might provide clearer feedback about what is happening [19:37:12] But if that's inconsistent with how we usually roll, then probably not good to introduce. [19:37:25] In theory, yes, but I'm pretty sure we don't do that currently in the front-end, so it will take longer. [19:37:32] For the hover menu, I mean, we do elsewhere. [19:38:07] So we currently hide admin actions for non-admin users, but we don't hide write actions for non-admins on protected pages? [19:38:53] RoanKattouw, correct, I think it's a bug. I see where it tries to. [19:38:54] ("non-admins" because admins are generally immune to protection) [19:39:02] I thought of this when stephanebisson raised 'mark as resolved'. [19:39:15] Right, which when you click it just does nothing, right? [19:39:28] Except keep the text but not the icon in the :active state or something silly-looking like that [19:40:25] (03PS4) 10Mooeypoo: Adjust to local x-wiki call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 [19:40:27] ok, it's ready for review ^^ [19:42:14] RoanKattouw, yeah. [19:43:08] https://www.mediawiki.org/wiki/User_talk:Mattflaschen/Protected if anyone wants to test (I don't know why it says creation protection when you try to edit the title). [19:43:39] RoanKattouw, okay, I'll do the remove for now. [19:44:30] 10Notifications: Call to a member function getUnreadCounts() on a non-object (boolean) - https://phabricator.wikimedia.org/T134428#2265382 (10hashar) [19:46:07] Ugh, I'll take that bug --^^ [19:47:30] (03PS1) 10Catrope: Avoid fatal when EchoUnreadWikis::newFromUser() returns false [extensions/Echo] (wmf/1.27.0-wmf.23) - 10https://gerrit.wikimedia.org/r/286951 (https://phabricator.wikimedia.org/T134428) [19:47:44] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Call to a member function getUnreadCounts() on a non-object (boolean) - https://phabricator.wikimedia.org/T134428#2265408 (10Catrope) p:05Triage>03Unbreak! [19:47:50] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Call to a member function getUnreadCounts() on a non-object (boolean) - https://phabricator.wikimedia.org/T134428#2265411 (10Catrope) a:03Catrope [19:49:30] legoktm: Under what cirumstances could $id = $lookup->centralIdFromLocalUser( $user, CentralIdLookup::AUDIENCE_RAW ); fail? [19:49:43] With SUL finalization I thought that wouldn't be possible, at least in theory [19:57:10] (03CR) 10Catrope: [C: 04-1] "Minor things inline, looks OK otherwise. It would be nice to clean this up in the future though, perhaps after the MVC refactor is done." (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (owner: 10Mooeypoo) [20:12:32] (03PS5) 10Catrope: Use server-side cross-wiki requests in the frontend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (owner: 10Mooeypoo) [20:12:46] (03PS6) 10Catrope: Use server-side cross-wiki requests in the frontend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (https://phabricator.wikimedia.org/T130636) (owner: 10Mooeypoo) [20:17:23] (03CR) 10Catrope: [C: 032] Avoid fatal when EchoUnreadWikis::newFromUser() returns false [extensions/Echo] (wmf/1.27.0-wmf.23) - 10https://gerrit.wikimedia.org/r/286951 (https://phabricator.wikimedia.org/T134428) (owner: 10Catrope) [20:25:09] (03Merged) 10jenkins-bot: Avoid fatal when EchoUnreadWikis::newFromUser() returns false [extensions/Echo] (wmf/1.27.0-wmf.23) - 10https://gerrit.wikimedia.org/r/286951 (https://phabricator.wikimedia.org/T134428) (owner: 10Catrope) [20:31:25] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Call to a member function getUnreadCounts() on a non-object (boolean) - https://phabricator.wikimedia.org/T134428#2265551 (10hashar) [20:33:36] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Call to a member function getUnreadCounts() on a non-object (boolean) - https://phabricator.wikimedia.org/T134428#2265561 (10Catrope) 05Open>03Resolved [20:35:06] (03CR) 10Catrope: [C: 032] Add Topic alias (Sak) for Norwegian Bokmål [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286874 (https://phabricator.wikimedia.org/T132693) (owner: 10Mattflaschen) [20:36:32] (03PS1) 10Catrope: Avoid fatal when EchoUnreadWikis::newFromUser() returns false [extensions/Echo] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286994 (https://phabricator.wikimedia.org/T134428) [20:36:41] (03CR) 10Catrope: [C: 032] Avoid fatal when EchoUnreadWikis::newFromUser() returns false [extensions/Echo] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286994 (https://phabricator.wikimedia.org/T134428) (owner: 10Catrope) [20:41:17] (03Merged) 10jenkins-bot: Add Topic alias (Sak) for Norwegian Bokmål [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286874 (https://phabricator.wikimedia.org/T132693) (owner: 10Mattflaschen) [20:45:00] (03Merged) 10jenkins-bot: Avoid fatal when EchoUnreadWikis::newFromUser() returns false [extensions/Echo] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286994 (https://phabricator.wikimedia.org/T134428) (owner: 10Catrope) [20:45:10] 10Notifications: Missing notification(s) for post on Flow user talk page - https://phabricator.wikimedia.org/T131827#2265632 (10Catrope) [20:45:12] 10Flow, 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Not receiving notifications for new topics on talk pages - https://phabricator.wikimedia.org/T131879#2265633 (10Catrope) [20:45:14] RoanKattouw: system accounts, users who are in the middle of a global rename, umm [20:45:40] I was seeing about one request per minute for users doing page views that fataled because of that [20:45:59] (Now deploying checks so that it doesn't fatal, but wondering why this happens because XWN would be broken for those users) [20:48:07] The error logs don't have identifying info about the users involved, so I don't have an example of a user [20:48:15] I suppose I could put in a debug log thing [20:53:54] 06Collaboration-Team-Interested, 10Notifications: Enable Cross-wiki Notifications on all wikis at once - https://phabricator.wikimedia.org/T131831#2179935 (10Catrope) Cross-wiki notifications will be enabled by default on May 12th, but after that we'll just have the reverse problem: there's no way to disable t... [20:57:16] 06Collaboration-Team-Interested, 10Flow: Consider including a little more info in the Recent Changes and User Contributions entries when a user creates a new Flow topic or comments on a Flow topic - https://phabricator.wikimedia.org/T132027#2265666 (10Catrope) [21:09:38] (03PS1) 10Catrope: Add {{GENDER}} to topic-renamed message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286999 (https://phabricator.wikimedia.org/T132252) [21:11:10] 10Flow, 03Collab-Team-2016-Apr-Jun-Q4, 07I18n, 13Patch-For-Review: [[MediaWiki:Notification-header-flow-topic-renamed-user-talk/nb]] i18n issue - https://phabricator.wikimedia.org/T132252#2265709 (10Catrope) a:03Catrope [21:11:20] 10Flow, 03Collab-Team-2016-Apr-Jun-Q4, 07I18n, 13Patch-For-Review: [[MediaWiki:Notification-header-flow-topic-renamed-user-talk/nb]] i18n issue - https://phabricator.wikimedia.org/T132252#2192692 (10Catrope) [21:11:35] OMG the new version of Phabricator lets me move tasks between columns from the task! [21:11:39] It's amazing! [21:12:41] 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Clicking a marked-as-unread notification should mark it as read - https://phabricator.wikimedia.org/T129898#2265712 (10Catrope) 05Open>03Resolved [21:20:58] (03PS7) 10Mooeypoo: Use server-side cross-wiki requests in the frontend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (https://phabricator.wikimedia.org/T130636) [21:21:10] (03PS8) 10Mooeypoo: Use server-side cross-wiki requests in the frontend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (https://phabricator.wikimedia.org/T130636) [21:21:43] RoanKattouw, oh, sweet. [21:24:23] (03PS45) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [21:27:15] RoanKattouw, oh, the small things that make you happy... [21:27:31] RoanKattouw, phabricator tweaks and browser bugs. [21:27:49] legoktm: OK, so I found two unattached users on shwiki (of the wikis I saw in the logs, it was the one with the lowest number of users) [21:27:54] One of them is Flow talk page manager [21:27:58] But the other one seems to be a real user [21:28:02] If there's a heaven, it's one big browser testing suite managed by a great version of phabricator board [21:28:20] RoanKattouw: user name? [21:28:27] legoktm: https://meta.wikimedia.org/wiki/Special:CentralAuth/Calvinius [21:28:37] Has accounts on a couple dozen wikis, but all unattached [21:28:43] o.O [21:30:07] But perhaps this isn't the cause [21:30:21] Because my query finds no unattached users on slwiki, yet I have an error from there in the logs [21:30:32] mysql:research@s3-analytics-slave [slwiki]> select user_id, user_name from user left join centralauth.localuser on lu_wiki='slwiki' and lu_name=user_name where lu_attached_timestamp is null; [21:30:32] Empty set (0.24 sec) [21:31:24] And on hrwiki, it's only Flow talk page manager, and I also have page views there that failed to create an UnreadWikis object [21:31:26] Special:CentralAuth should be accurate [21:31:29] I'll put debug logging in [21:31:37] Yeah, that user really is unattached [21:31:50] But I also see these log errors coming from wikis where there aren't any unattached users [21:31:59] non-system unattached users that is [21:32:37] hrm. [21:35:16] 10Flow, 03Collab-Archive-2015-2016, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#2265797 (10Mattflaschen) I've removed all the write actions (when they don't have rights to u... [21:37:16] WTF, it seems like it's intermittent [21:38:12] I have $unreadWikis = EchoUnreadWikis::newFromUser( $user ); if ( $unreadWikis ) { do stuff } else { debug log } [21:39:02] So I get a hit in the logs [21:39:39] But Special:CentralAuth says that user is attached, and if I go to eval.php on tin and do EchoUnreadWikis::newFromUser( User::newFromName( 'their name' ) ); , I get an object just fine [21:40:44] Ditto for the second log entry [21:41:06] 10Flow, 03Collab-Archive-2015-2016, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#2265813 (10Mattflaschen) >>! In T108762#2265797, @Mattflaschen wrote: > However, that also re... [21:41:10] (On fluorine, run grep Unattached /a/mw-log/Echo.log) [22:15:38] 10Flow, 03Collab-Archive-2015-2016, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07WorkType-NewFunctionality: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#2266026 (10Mattflaschen) >>! In T108762#2213899, @Pginer-WMF wrote: >>>! In T108762#2170950,... [22:19:27] (03PS46) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [22:22:32] RoanKattouw: I see in LocalSettings.php that both $wgMainCacheType and $wgSessionCacheType set to 'redis'. Is it ok or I need to run git pull again? [22:22:49] I don't know. matt_flaschen ? [22:23:35] RoanKattouw: hmm... how then memcached works then? :) [22:24:25] I guess it's using redis instead of memcached then [22:24:30] I don't know if that's intended or not [22:24:55] If you're planning to use memcached, you probably want $wgMainCacheType = CACHE_MEMCACHED; , that's what I have locally [22:24:58] But I'm not a Vagrant user [22:27:13] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [22:27:29] etonkovidova, context? [22:27:41] We use memcached for Flow. I'll check my values of those. [22:28:37] Those are set to 'redis' for me too. [22:30:39] etonkovidova, RoanKattouw, turns out I am using Redis locally for $wgMemc, which is what Flow uses. I do remember at one point there were issues, but I haven't run into anything recent I think is related. It would be better to be consistent with production, though. [22:31:33] There is a role for it. I will add it as a dependency. [22:31:44] matt_flaschen: right :) thx [22:33:59] https://gerrit.wikimedia.org/r/287015 Not tested, since I don't want to wait for it to provision. But I'm sure I'll hear if it doesn't work. :) [22:34:25] Plus I used to use memcached locally and we still do in production. [22:35:25] I'll test it later. [22:41:05] legoktm: I found it [22:41:14] Well, I found something [22:41:17] 2016-05-04 22:23:42 [Vyp2bgpAIDoAAF6ajs4AAAAT] mw1188 hrwiki 1.27.0-wmf.22 Echo DEBUG: Unattached user? {"id":161408,"name":"Koszik"} [22:41:27] 2016-05-04 22:23:42 [Vyp2bgpAIDoAAF6ajs4AAAAT] mw1188 hrwiki 1.27.0-wmf.22 CentralAuth INFO: Attaching local user Koszik@hrwiki by 'login' [22:42:12] It looks like it was the user's first login on that wiki, and we read CA stuff from a slave, so if the current request is the request that attached them we won't see that data on the slave yet [22:42:35] ahhhh [22:48:06] That sounds like a bug in CentralAuth to me actually [22:48:36] centralIdFromLocalUser just uses CentralAuthUser::getInstance() [22:50:53] OMG wow [22:50:59] Reading the code in CentralAuthUser it's pretty obvious [22:51:18] attach() calls resetState(), then invalidateCache() [22:51:32] resetState() clears all the state fields, expecting them to be loaded again by loadState later [22:51:55] invalidateCache() calls loadStateNoCache() [22:52:09] Which then reloads the state from the slave DB [22:54:04] So now you have a CentralAuthUser object with information that's definitely out of date, and it gets stuck in the instance cache for the rest of the request [22:55:24] Do we really need to clear all state when doing a simple attach? Couldn't we just do $this->mAttachedArray[]= wfWikiId(); or something? [22:56:45] Anyway -- it's not that big a deal if cross-wiki notifications don't work on your first request to a wiki [23:07:19] RoanKattouw, OOUI PHP has a feature to derived colored images, right? Do you have an example of that? [23:07:34] To specify the color and get a variant in that color. [23:07:48] ResourceLoaderImageModule is where that happens I believe [23:08:13] Yup, RLIM is what you want [23:08:32] Its actual usage is through ResourceLoaderOOUIImageModule or whatever it's called, which is fairly complicated [23:08:44] But the docs of RLIM itself should be relatively straightforward [23:10:03] It might help to know that the output of such a module will be something like .prefix-iconName-variant { background-image: url(data:image/svg,...); background-image: url(/w/load.php?blah) !ie; } [23:10:09] Not actually that but hopefully you get the idea [23:10:10] RoanKattouw, I'm trying to use it through OOUI, for the gray lock button at https://phabricator.wikimedia.org/T108762 . [23:10:23] Oh, in that case you need to add a variant to OOUI [23:10:49] Also, you said you need grey? [23:11:06] Since the base icons are full black, can you achieve the desired effect with opacity in CSS? [23:11:58] Thanks, that should work. It looks like the variants are only generated for the standard colors (constructive, progressive, etc.) currently, which makes sense. [23:12:15] Yes, you'd have to add a new standard color, and that tends to encounter inertia [23:12:30] The OOUI folks try to keep the number of standard colors small [23:13:11] I thought you were asking because of the gmail SVG thing; which I now have more of an idea how to fix :) [23:14:04] Yeah, doing even a few shades of each color would start adding up really quickly. [23:14:27] Yeah, I saw MatmaRex's suggestion to use RLIM. [23:21:19] (03CR) 10Catrope: [C: 032] Use server-side cross-wiki requests in the frontend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (https://phabricator.wikimedia.org/T130636) (owner: 10Mooeypoo) [23:21:41] mooeypoo: Once the MVC stuff is done we should really clean up the counter situation, if that change doesn't do that already [23:22:06] Right now we make separate requests for the counts a lot, even in cases where that should be unnecessary [23:22:22] Like, it should be possible for the request that lists all the notifs to also include counts [23:22:43] There's a bug where if you open, close then re-open the popup, the second opening sends two counter requests [23:23:08] And we're now in a position where we can have the response to the markasread POST requests return correct counter information [23:26:19] * mooeypoo nods [23:26:30] some of it is fixed in the MVC, some is waiting for followup commits [23:27:28] (03Merged) 10jenkins-bot: Use server-side cross-wiki requests in the frontend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286782 (https://phabricator.wikimedia.org/T130636) (owner: 10Mooeypoo) [23:34:17] (03Abandoned) 10Catrope: Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [23:35:01] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 07Crosswiki, 13Patch-For-Review, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): Cross-wiki notifications: Make cross-wiki API requests server-side - https://phabricator.wikimedia.org/T130636#2266159 (10Catrope) [23:36:00] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 07Crosswiki: Change "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2266164 (10Catrope) This should be moot now that T130636 is fixed. [23:36:11] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 07Crosswiki: Change "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2266165 (10Catrope) [23:37:39] All blocker tasks for XWN by default are now in QA Review :) [23:38:35] 10Notifications, 10Collaboration-Community-Engagement, 03Collab-Team-2016-Apr-Jun-Q4, 07Epic, and 2 others: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2266171 (10Catrope) >>! In T130655#2258675, @Catrope wrote: > We plan on doing this on May 12th at 23:00 UTC. We... [23:53:57] (03PS47) 10Mooeypoo: Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [23:55:46] woot. Okay, I made the mvc handle the xwiki local call [23:57:32] In a nicer way than master? [23:57:52] (03CR) 10jenkins-bot: [V: 04-1] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo)