[00:25:00] (03PS40) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [00:28:43] 03Collab-Team-2016-Q4: [betalabs] Regression: Mention notification from wikitext pages does not link to the section where Mention occurred - https://phabricator.wikimedia.org/T134216#2258342 (10Etonkovidova) [00:38:24] 03Collab-Team-2016-Q4: [betalabs] Regression: Mention notification from wikitext pages does not link to the section where Mention occurred - https://phabricator.wikimedia.org/T134216#2258360 (10Etonkovidova) Check {T67032} and {T62396} after the fix. [00:48:00] (03PS41) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [01:26:48] RoanKattouw, Can I just boldly rename our Q4 board from "Collab-Team-2016-Q4" - to - "Collab-Team-2016-Apr-Jun" , or does it need a brief team discussion? [01:27:37] Brief discussion will be best [01:27:41] *would [01:27:43] (there's a related discussion about eliminating the "Qx" naming scheme in phab boards, and I want to use our board as an example of how easy it is [01:27:45] ) [01:27:46] ok. [01:28:10] I for one would be confused if Q4 suddenly stopped autocompleting [01:29:07] RoanKattouw, it wouldn't, because it keeps the old names as aliases. [01:29:17] it will still autocomplete, if we add it as "additional hashtag" (checked and confirmed( [01:29:53] e.g. try to search for 'zanzu'. >.> [01:31:18] I've explained here https://phabricator.wikimedia.org/T134134#2258471 and will bring it up briefly in standup tomorrow. [01:35:50] quiddity, it automatically adds the old names as additional hashtags. [01:36:00] ah, good to know, will clarify [01:38:19] OK, cool [01:38:24] Yeah bring it up tomorrow [01:38:47] I'm not saying it needs a lot of discussion, but I'd also prefer to not catch everyone off guard with this [01:57:58] (03PS1) 10Catrope: Replace mark-as-read-on-click with ?markasread= URL parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) [02:02:20] 10MediaWiki-extensions-PageCuration, 10GlobalUserPage: Page curation toolbar should show blue links when there is a global user page - https://phabricator.wikimedia.org/T134073#2253968 (10Legoktm) PageCuration should be using `Title::isKnown()` instead of `Title::exists()`. [02:06:10] (03CR) 10Legoktm: "Can there be some window.pushState() magic to drop the query parameter?" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) (owner: 10Catrope) [02:08:00] legoktm: Jinx, I'm about to upload a patchset that adds a comment explaining why using wfAppendQuery() broke [02:08:06] (hash fragments in URLs for some notif types) [02:08:18] Ooh pushState magic is a good idea [02:08:29] (03PS2) 10Catrope: Replace mark-as-read-on-click with ?markasread= URL parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) [02:09:26] RoanKattouw: fix wfAppendQuery? ;) [02:09:50] (03CR) 10Catrope: Replace mark-as-read-on-click with ?markasread= URL parameter (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) (owner: 10Catrope) [02:10:02] Yeah, I will [02:10:12] I could make it simpler than that parseUrl stuff too [02:10:22] Just find the first # [02:20:23] (03PS3) 10Catrope: Replace mark-as-read-on-click with ?markasread= URL parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) [02:21:21] hah, while testing that I got notification ID 555 [02:25:52] 03Collab-Team-2016-Q4, 10Notifications: Create a blog post about cross-wiki notifications feature release - https://phabricator.wikimedia.org/T131112#2258637 (10Catrope) a:05jmatazzoni>03Catrope [02:26:25] 03Collab-Team-2016-Q4, 10Notifications: Create a blog post about cross-wiki notifications feature release - https://phabricator.wikimedia.org/T131112#2156375 (10Catrope) I've been working on this with @EdErhart-WMF [02:38:43] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), and 2 others: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2258648 (10Catrope) This is now live, with some [[https://translatewiki.net/w/i.php?tit... [02:40:48] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), and 2 others: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2258649 (10Catrope) (And now I feel silly for having written the one translation that's... [02:42:25] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, and 2 others: Cross-wiki notifications - announcements planning - https://phabricator.wikimedia.org/T123570#2258650 (10Catrope) [02:43:53] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07user-notice: Prepare and review announcements concerning Cross-wiki Notifications as a by-default feature on all wikis - https://phabricator.wikimedia.org/T129643#2258653 (10Catrope) We've set a date: May 12th at 23:00 UTC. We... [02:44:13] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, and 2 others: Cross-wiki notifications - announcements planning - https://phabricator.wikimedia.org/T123570#1932842 (10Catrope) Edited description to add deployment date: May 12th at 23:00 UTC. [03:08:04] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07Epic, 07Tracking: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2258675 (10Catrope) We plan on doing this on May 12th at 23:00 UTC. We have patches in review for the two unfixed blocke... [03:09:59] 06Collaboration-Team-Interested, 10Notifications, 10Security-Reviews, 06Security-Team: Security review for cross-wiki aspects of Echo notifications - https://phabricator.wikimedia.org/T112792#2258678 (10Catrope) >>! In T112792#2257513, @Catrope wrote: >>>! In T112792#2245862, @csteipp wrote: >> @dpatrick,... [03:12:02] (03CR) 10Catrope: Replace mark-as-read-on-click with ?markasread= URL parameter (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) (owner: 10Catrope) [03:12:36] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: When opening a notification it disappears before navigating away - https://phabricator.wikimedia.org/T133975#2258679 (10Catrope) [05:44:46] (03CR) 10Mooeypoo: "Potential problem here is the original reason that the "mark read on click" was created -- if the user clicks "back", the javascript is no" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) (owner: 10Catrope) [06:28:00] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07user-notice: Prepare and review announcements concerning Cross-wiki Notifications as a by-default feature on all wikis - https://phabricator.wikimedia.org/T129643#2258822 (10Qgil) [06:43:09] (03CR) 10Catrope: "Doesn't the popup fully reload every time it's opened nowadays?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) (owner: 10Catrope) [06:45:13] (03CR) 10Catrope: "(Also AIUI, the original reason we introduced mark-as-read-on-click was because visiting the associated page only marks the notification a" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) (owner: 10Catrope) [07:20:12] (03PS4) 10Catrope: Replace mark-as-read-on-click with ?markasread= URL parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286577 (https://phabricator.wikimedia.org/T133975) [07:45:23] 03Collab-Team-2016-Q4, 10Notifications, 07Design: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2258880 (10Pginer-WMF) >>! In T132975#2258413, @jmatazzoni wrote: > This approach looks sound. Thanks Pau. I have some questions, just t... [09:28:51] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07user-notice: Prepare and review announcements concerning Cross-wiki Notifications as a by-default feature on all wikis - https://phabricator.wikimedia.org/T129643#2111549 (10Qgil) Looks li... [09:29:30] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07user-notice: Prepare and review announcements concerning Cross-wiki Notifications as a by-default feature on all wikis - https://phabricator.wikimedia.org/T129643#2259183 (10Qgil) [09:29:32] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 06Community-Liaisons: Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2259185 (10Qgil) [09:33:28] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation: Rethink how the different types of notifications are displayed on Help:Notifications - https://phabricator.wikimedia.org/T131604#2259200 (10Qgil) [09:33:37] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons: Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#2259204 (10Qgil) [09:45:03] 10Flow, 10Wikidata: Templates calling Wikidata elements don't display the result in the user language on Flow - https://phabricator.wikimedia.org/T134158#2259233 (10Lydia_Pintscher) [09:48:58] 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Documentation, 07Tracking: [Tracking] Update Help:Notifications - https://phabricator.wikimedia.org/T119713#2259250 (10Qgil) [09:50:42] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2259260 (10Qgil) [09:51:42] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Write a FAQ about Flow - https://phabricator.wikimedia.org/T134244#2259269 (10Trizek-WMF) [09:52:06] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Write a FAQ about Flow - https://phabricator.wikimedia.org/T134244#2259288 (10Trizek-WMF) p:05Triage>03Low [09:53:17] 10Flow, 10Collaboration-Community-Engagement, 06Community-Advocacy: Give to WMF staff with global-flow-create the right to rename pages globally - https://phabricator.wikimedia.org/T133901#2259296 (10Trizek-WMF) [09:55:30] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2259314 (10Trizek-WMF) p:05Triage>03High a:03Trizek-WMF We agreed on writing a blog post... [09:55:40] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2259320 (10Trizek-WMF) [09:55:43] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, and 2 others: Cross-wiki notifications - announcements planning - https://phabricator.wikimedia.org/T123570#2259321 (10Trizek-WMF) [09:55:49] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Write a FAQ about Flow - https://phabricator.wikimedia.org/T134244#2259322 (10Qgil) [10:02:09] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), and 3 others: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2259348 (10Trizek-WMF) [10:02:22] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), and 3 others: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1784064 (10Trizek-WMF) [10:05:03] 03Collab-Team-2016-Q4, 10Notifications, 07Documentation, 13Patch-For-Review, and 2 others: Display documentation for notification types configuration on Wikimedia - https://phabricator.wikimedia.org/T132127#2259373 (10Trizek-WMF) [10:07:13] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07Epic, and 2 others: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2259388 (10Trizek-WMF) [10:07:51] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07user-notice: Prepare and review announcements concerning Cross-wiki Notifications as a by-default feature on all wikis - https://phabricator.wikimedia.org/T129643#2259391 (10Trizek-WMF) p:05Triage>03H... [10:08:22] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07Epic, and 2 others: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2142184 (10Trizek-WMF) [10:09:17] 06Collaboration-Team-Interested, 10Flow, 10BlueSpice, 06Editing-Department, and 17 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2259394 (10Lydia_Pintscher) [10:09:55] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, and 2 others: Cross-wiki notifications - announcements planning - https://phabricator.wikimedia.org/T123570#2259399 (10Trizek-WMF) p:05Normal>03High We now have to tackle the blog post! [10:10:58] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2259403 (10Trizek-WMF) [10:11:01] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons, 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2259402 (10Trizek-WMF) [11:53:33] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Documentation: Write a FAQ about Flow - https://phabricator.wikimedia.org/T134244#2259686 (10Danny_B) [13:00:55] 06Collaboration-Team-Interested, 10Notifications, 10Security-Reviews, 06Security-Team: Security review for cross-wiki aspects of Echo notifications - https://phabricator.wikimedia.org/T112792#2259870 (10csteipp) @Catrope, really sorry this is late. I've looked through https://gerrit.wikimedia.org/r/#/c/284... [13:30:02] (03CR) 10Matthias Mullie: NotifUser: Refactor getNotificationCount() and friends, add caching for global counts (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285598 (https://phabricator.wikimedia.org/T133623) (owner: 10Catrope) [13:30:10] (03CR) 10Matthias Mullie: [C: 032] NotifUser: Refactor getNotificationCount() and friends, add caching for global counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285598 (https://phabricator.wikimedia.org/T133623) (owner: 10Catrope) [13:37:05] (03CR) 10Matthias Mullie: "I'm definitely in favor of refactoring some of this code here. But I'd suggest we wait until we no longer make it an opt-in thing." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 (owner: 10Catrope) [13:37:12] (03CR) 10Matthias Mullie: [C: 032] NotifUser: Reduce queries in resetNotificationCount() by hackily computing some values from others [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 (owner: 10Catrope) [13:39:07] (03Merged) 10jenkins-bot: NotifUser: Refactor getNotificationCount() and friends, add caching for global counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285598 (https://phabricator.wikimedia.org/T133623) (owner: 10Catrope) [13:43:45] (03Merged) 10jenkins-bot: NotifUser: Reduce queries in resetNotificationCount() by hackily computing some values from others [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 (owner: 10Catrope) [14:34:16] (03PS42) 10Sbisson: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [14:37:49] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [14:52:15] (03PS43) 10Sbisson: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [14:55:49] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [14:58:56] (03PS44) 10Sbisson: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [16:03:16] (03CR) 10Catrope: "Thanks for merging!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 (owner: 10Catrope) [16:09:58] 06Collaboration-Team-Interested, 10Flow, 10BlueSpice, 06Editing-Department, and 17 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2260610 (10Harej) [16:43:09] 06Collaboration-Team-Interested, 10Notifications, 10Security-Reviews, 06Security-Team: Security review for cross-wiki aspects of Echo notifications - https://phabricator.wikimedia.org/T112792#2260749 (10Catrope) >>! In T112792#2259870, @csteipp wrote: > @Catrope, really sorry this is late. I've looked thro... [16:45:33] 06Collaboration-Team-Interested, 10Notifications, 10Security-Reviews, 06Security-Team: Security review for cross-wiki aspects of Echo notifications - https://phabricator.wikimedia.org/T112792#2260753 (10dpatrick) I'm sorry I dropped the ball on this guys. I got really behind on stuff last week. [16:47:44] (03PS12) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [17:00:29] i'll be late to standup, need a brief mid-meeting break [17:07:09] (03CR) 10Catrope: [C: 032] Add dry-run option to removeoldtopics script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279938 (owner: 10Matthias Mullie) [17:15:05] (03Merged) 10jenkins-bot: Add dry-run option to removeoldtopics script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279938 (owner: 10Matthias Mullie) [17:16:02] mooeypoo: https://gerrit.wikimedia.org/r/#/c/284682/9 is the patch I was talking about in the standup [17:31:41] RoanKattouw, mooeypoo: ^ this is limited to the API layer and shouldn't be a problem with the MVC work [17:43:23] (03CR) 10Mooeypoo: [C: 04-1] "This is overall good, but I have small comments regarding the foreign API handler." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [17:50:25] (03PS13) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [17:50:42] stephanebisson, yeah less worried about the impact on the MVC, a bit more concerned about the way it changes the logic of things -- I think we may have an issue with the specific wiki-related actions like mark-as-read for remote wikis. I don't think we can do that locally (?) and that means the remote api handlers won't have a way to send the request remotely to the remote wiki (not remoteAPI/URL in there) [17:52:52] (03Abandoned) 10Dereckson: L10n: set "Mesele" as Topic namespace translation in diq [extensions/Flow] - 10https://gerrit.wikimedia.org/r/286281 (owner: 10Dereckson) [17:53:09] mooeypoo: The goal is to go local for everything. Is it not the case with this patch and related patches? [17:55:06] (03PS14) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [17:55:11] stephanebisson, I may have missed something, but I didn't see the mark-as-read locally in the underlying patch [17:55:25] it was either missed (we should implement) or I misread, I only skimmed it. [17:55:34] I also can't find it [17:55:38] either way, I agree we should do things locally, I'm just making the point that we should make sure mark as read is implemented [17:55:59] but I think it should be there, otherwise we're not helping the CORS situation [17:56:05] * mooeypoo nods [17:56:11] ok, we should add that to the underlying commit [17:56:16] you want to add that comment or should I? [17:56:31] I'll do it [17:56:38] I already added to the top one, we just need to make sure whatever actions we have in front of the foreign API are implemented locally [17:56:42] i think it's only mark as read [17:56:47] ... do we have anything else? [17:57:06] we're not marking seen time remotely, so I don't think there's anything else [17:59:51] (03CR) 10Sbisson: "Should it also relay "mark as read" and "update seen time" to foreign wikis? If not, we still have the CORS situation for those actions." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [18:00:18] right [18:01:43] If not, we don't just have a CORS issue, we also need to implement the foreign API handlers differently to allow some actions locally and some remotely [18:02:21] anywyas, this shouldn't interfere with the mvc commit, at least, whichever one of them is merged first [18:04:59] well, I should test these commits because it's not clear how they work [18:21:20] mooeypoo: Oooh, good point, I did not test cross-wiki mark-as-read and offhand I'm not sure that would still work [18:22:35] RoanKattouw, yeah stephanebisson added a comment to that effect on the underlying commit [18:22:44] we should probably add it to the local option or something [18:22:50] btw, how will this work for 3rd parties? [18:22:54] We can still send CORS requests for that without issues [18:23:07] Because CORS issues are about reading the responses, not sending the requests [18:23:12] that would mean reimplementing ForeignAPI handlers, though. Doable, but we should beware of that fact [18:23:19] But the code as written drops the URL config etc so it's probably broken right now [18:23:25] yep [18:23:58] "CORS issues are about reading the responses, not sending the requests" really? [18:24:30] Yup [18:25:10] ... when you're sending a request, the destination reads it.... no? [18:25:12] You can $.post() to random domains, the browser just won't let you read the response unless there's an Access-Control-Allow-Origin header [18:25:13] (Deep.) [18:25:20] Yes, the destination being a server [18:25:40] That server than responds with something that either does or doesn't have an ACAO header allowing the client to read the response [18:26:19] But yes, you can do fire-and-forget POSTs from anywhere to anywhere, that's how CSRF vulnerabilities happen [18:27:33] We can decide that we're doing that way (post through url but fetch notifs locally) but that would mean redesigning the way that the API layer works with both those options. [18:27:39] the UI's API layer, I mean [18:29:42] stephanebisson, also, this can wait but in general if we're doing everything local, then we can probably do away with foreignAPIHandlers and use **one** api handler for everything (with sources being the wikis, as they're going to be a parameter anyways) [18:29:50] but yeah, that can be a tech debt TODO for later. [18:30:51] yep [18:32:41] I'm not convinced that we should proxy mark as read etc through the local wiki [18:33:00] But it would probably be simpler [18:33:42] so we can fire the request but we won't know if it's successful [18:33:59] not that we would do anything with this information ;) [18:36:51] Well, there is one thing [18:37:13] With my patch that was merged today, the markasread API module now returns the correct new read count [18:37:17] (Rather than the local-only one) [18:37:37] Well, -ish. It's only correct if on that wiki you also have XWN enabled :/ but we could fix that easily [18:38:18] 06Collaboration-Team-Interested, 10Flow: flow_post.partial.handlebars appears after posting a message - https://phabricator.wikimedia.org/T103702#1396907 (10PrometheusAla) Any recommendations? Also see this issue on my resources http://prntscr.com/azv7gr [18:38:19] Anyway -- my argument for using CORS for mark as read/seen is that there's no real reason to proxy it, but perhaps we should proxy it anyway for consistency with the rest [18:39:07] We'll either have complexity in the API (proxying for multiple things) or in the frontend (knowing when to use CORS and when to proxy) [19:00:36] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-05-01_(1.27.0-wmf.23): Enable by default "Email from other user" notification on all wikis - https://phabricator.wikimedia.org/T133927#2261329 (10jmatazzoni) 05Open>03Resolved [19:08:07] RoanKattouw: I still do not see the dot in- Krijg hier ook meldingen van andere wiki's Probeer de betafunctie voor "Uitgebreide meldingen" uit. [19:08:37] RoanKattouw: all langs I checked, have it :) [19:16:37] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), and 3 others: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2261376 (10Etonkovidova) Checked in production - the 'x' is aligned now. enwik... [19:16:59] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), and 3 others: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2261377 (10Etonkovidova) [20:03:21] etonkovidova: Yeah that's because I made a mistake while translating that message. I fixed it on TranslateWiki, but it'll be a few days before that translation is live [20:04:13] RoanKattouw: yes, I saw it's fixed on translatewiki but I thought it'd be faster in nlwiki [20:04:40] RoanKattouw, I'm prepping for Scrum of Scrums. Are we still planning to go for cross-wiki by default on May 12th. Other than that, I have External Store, dumps, further change to special page, and MVC. Anything else? [20:04:57] Yes, still May 12th [20:05:23] There are two issues we'll have to figure out with the server-side cross-wiki stuff but I think we should be able to do that [20:05:39] The security team is no longer blocking us as of this morning, which is good [20:06:00] Oh also the email formatter [20:06:22] I said I'd merge Stephane's plaintext email formatter patch after the cut, and he's working on a patch for the HTML one [20:07:03] Which means we'll likely start dismantling the old formatter system soon. Not that anything outside of Echo should be using it at this point anyway. [20:07:22] Re special page, dev work there is stalled waiting for MVC AIUI [20:09:29] RoanKattouw, I actually meant DisplayNotifcationsConfiguration, but I don't really need to mention that. [20:14:54] Oh, that special page [21:15:42] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2261752 (10jmatazzoni) [21:15:46] 06Collaboration-Team-Interested, 10Notifications, 07Epic, 07WorkType-NewFunctionality, 07user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#2261753 (10jmatazzoni) [21:15:50] 10Notifications, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), and 3 others: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2261750 (10jmatazzoni) 05Open>03Resolved