[00:00:00] 03Collab-Team-2016-Q4, 10Notifications: Enable by default "Email from other user" notification on all wikis - https://phabricator.wikimedia.org/T133927#2250335 (10jmatazzoni) [00:00:10] 03Collab-Team-2016-Q4, 10Notifications: Enable by default "Email from other user" notification on all wikis - https://phabricator.wikimedia.org/T133927#2249265 (10jmatazzoni) [00:00:46] 03Collab-Team-2016-Q4, 10Notifications: Enable by default "Email from other user" notification on all wikis - https://phabricator.wikimedia.org/T133927#2249265 (10jmatazzoni) a:03Catrope [00:01:46] (03PS1) 10Catrope: Enable emailuser notifications by default [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286102 (https://phabricator.wikimedia.org/T133927) [00:09:06] (03PS16) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [00:09:37] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Enable by default "Email from other user" notification on all wikis - https://phabricator.wikimedia.org/T133927#2250366 (10Catrope) >>! In T133927#2250351, @gerritbot wrote: > Change 286105 had a related patch set uploaded (by Catrope): > Remove ema... [00:09:58] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Enable by default "Email from other user" notification on all wikis - https://phabricator.wikimedia.org/T133927#2250367 (10Catrope) [00:10:01] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-01_(1.27.0-wmf.23), 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2250368 (10Catrope) [00:10:15] 03Collab-Team-2016-Q4, 10Notifications, 07Crosswiki, 13Patch-For-Review: Cross-wiki notifications: Make cross-wiki API requests server-side - https://phabricator.wikimedia.org/T130636#2250369 (10Catrope) [00:10:40] (03CR) 10jenkins-bot: [V: 04-1] Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) (owner: 10Paladox) [00:13:50] (03PS17) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [00:14:30] (03PS18) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [00:15:37] (03CR) 10jenkins-bot: [V: 04-1] Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) (owner: 10Paladox) [00:15:42] (03PS19) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [00:17:28] (03PS20) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [00:18:36] (03PS21) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [00:18:49] (03CR) 10jenkins-bot: [V: 04-1] Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) (owner: 10Paladox) [00:19:53] (03CR) 10jenkins-bot: [V: 04-1] Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) (owner: 10Paladox) [00:20:56] (03PS22) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [00:26:18] (03PS23) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [00:27:06] (03PS24) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [00:27:30] 06Collaboration-Team-Interested, 10Flow: Session failure when you want to "mark as patrolled" a diff on Flow. - https://phabricator.wikimedia.org/T128379#2072268 (10He7d3r) Same problem here: https://pt.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Contato/Fale_com_a_Wikip%C3%A9dia&action=compare-header-revis... [00:27:59] 06Collaboration-Team-Interested, 10Flow, 10Notifications: [betalabs] Links in Flow text excerpts displayed incorrectly - https://phabricator.wikimedia.org/T133435#2250380 (10jmatazzoni) [00:31:39] 06Collaboration-Team-Interested, 10Flow: [mobile] Clicking on 'Mark as resolved' forces the dotdotdot menu to move down - https://phabricator.wikimedia.org/T133365#2250381 (10jmatazzoni) [00:31:55] 06Collaboration-Team-Interested, 10Flow, 10Notifications: Combine "Resolved" and "Summarized" notifications when both actions happen on Flow - https://phabricator.wikimedia.org/T131722#2250382 (10jmatazzoni) [00:32:33] 03Collab-Team-2016-Q4, 10Notifications, 07Easy: User rights change notification email does not specify in body which account was affected - https://phabricator.wikimedia.org/T71981#2250383 (10jmatazzoni) [00:33:19] 03Collab-Team-2016-Q4, 10Flow, 10MediaWiki-Patrolling: Flow "mark as patrolled" links don't work (claims "Session failure") - https://phabricator.wikimedia.org/T133341#2250384 (10jmatazzoni) [00:33:56] 03Collab-Team-2016-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#2250389 (10jmatazzoni) [00:34:23] 03Collab-Team-2016-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 2 others: Enable Flow in id.wikipedia for testing - https://phabricator.wikimedia.org/T133254#2250391 (10jmatazzoni) [00:38:10] 03Collab-Team-2016-Q4, 10Flow, 10Notifications: Email notifications sent both by Echo for core edits and by Flow for replys/mentions/etc should include as much context as is feasible so i can just read my email and not visit the website. - https://phabricator.wikimedia.org/T90067#2250408 (10jmatazzoni) [00:38:39] 03Collab-Team-2016-Q4, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Collab recently closed Phlogiston report has 1000s of invalid items - https://phabricator.wikimedia.org/T133172#2250425 (10jmatazzoni) [00:40:21] 06Collaboration-Team-Interested, 10Flow: Add redirect capability to Flow - https://phabricator.wikimedia.org/T102300#2250428 (10jmatazzoni) [00:40:53] 03Collab-Team-2016-Q4, 10Flow: ( ! ) Warning: Illegal string offset 'plaintext' in /vagrant/mediawiki/extensions/Flow/includes/Formatter/RevisionFormatter.php on line 343 - https://phabricator.wikimedia.org/T132990#2250429 (10jmatazzoni) [00:41:16] 03Collab-Team-2016-Q4, 10MediaWiki-extensions-GuidedTour: GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't) - https://phabricator.wikimedia.org/T132989#2250430 (10jmatazzoni) [00:42:46] 03Collab-Team-2016-Q4, 10Notifications: [production] minor: 'Mark as read' cross-wiki alerts displays blank flyout - https://phabricator.wikimedia.org/T132202#2250431 (10jmatazzoni) [00:43:18] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4: Change current no-JS Special:Notifications to use core Pager - https://phabricator.wikimedia.org/T129169#2250432 (10jmatazzoni) [00:43:46] 03Collab-Team-2016-Q4, 10Notifications: Measure how often the "mark all as read" action is used in the Notification Panel - https://phabricator.wikimedia.org/T127955#2250433 (10jmatazzoni) [00:44:55] 06Collaboration-Team-Interested, 10Flow: Add option to semi/fully-protect Flow board descriptions - https://phabricator.wikimedia.org/T113902#2250434 (10jmatazzoni) [00:46:00] 03Collab-Team-2016-Q4, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 07WorkType-Maintenance: Migrate Flow content to new separate logical External Store in production - https://phabricator.wikimedia.org/T106363#2250435 (10jmatazzoni) [00:46:27] 03Collab-Team-2016-Q4, 10Notifications: Document technical aspects of cross-wiki notifications (for non MediaWiki-Vagrant users) - https://phabricator.wikimedia.org/T125728#2250452 (10jmatazzoni) [00:48:03] 03Collab-Team-2016-Q4, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Collab Phlogiston velocity chart doesn't match recently closed list - https://phabricator.wikimedia.org/T133173#2250456 (10jmatazzoni) [01:49:39] (03CR) 10Mattflaschen: [C: 032] Enable emailuser notifications by default [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286102 (https://phabricator.wikimedia.org/T133927) (owner: 10Catrope) [01:59:22] (03Merged) 10jenkins-bot: Enable emailuser notifications by default [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286102 (https://phabricator.wikimedia.org/T133927) (owner: 10Catrope) [06:20:12] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-01_(1.27.0-wmf.23), 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2250654 (10Pginer-WMF) >>! In T117669#2249182, @Catrope wrote: >>>! In... [07:08:10] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-01_(1.27.0-wmf.23), 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2250693 (10Catrope) >>! In T117669#2250654, @Pginer-WMF wrote: > - For... [07:40:50] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2250699 (10Trizek-WMF) [08:04:39] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2250702 (10Trizek-WMF) **List of wikis that use Flow atm:** mediawiki.org wikidata.org a... [08:41:40] 06Collaboration-Team-Interested, 10MoodBar, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, and 3 others: De-deploy MoodBar from WMF wikis - https://phabricator.wikimedia.org/T131340#2250725 (10Danny_B) [08:57:28] 06Collaboration-Team-Interested, 10Flow, 07Community-consensus-needed, 07Design: preference to ignore comments from specific users ("killfile") - https://phabricator.wikimedia.org/T71404#2250786 (10Danny_B) [09:13:15] (03CR) 10Raimond Spekking: "Looks like the job queue of translatewiki.net isn't running and therefore the i18n changes are not processed before the export runs." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/286088 (owner: 10Catrope) [09:42:30] 06Collaboration-Team-Interested, 10Notifications: When opening a notification it disappears before navigating away - https://phabricator.wikimedia.org/T133975#2250870 (10Pginer-WMF) [09:44:08] 06Collaboration-Team-Interested, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#1944966 (10Pginer-WMF) [11:23:44] 03Collab-Team-2016-Q4, 10Thanks, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#544529 (10Danny_B) What is the purpose of adding the //blind// thank you link? Without seeing the diff you never know what you're actually thanking f... [11:33:26] 03Collab-Team-2016-Q4, 10Thanks, 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2251090 (10Dvorapa) @Danny_B e.g. based on the summary: ``` RFC closed ``` => thank ``` page moved from [[Europe continent]] to [[Europe]] ``` => t... [12:02:20] 03Collab-Team-2016-Q4, 10Notifications, 07Documentation, 13Patch-For-Review, and 2 others: Display documentation for notification types configuration on Wikimedia - https://phabricator.wikimedia.org/T132127#2251107 (10Liuxinyu970226) [12:02:35] 03Collab-Team-2016-Q4, 10Notifications, 07Documentation, 13Patch-For-Review, and 2 others: Display documentation for notification types configuration on Wikimedia - https://phabricator.wikimedia.org/T132127#2189114 (10Liuxinyu970226) [13:10:34] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4: Build interface for notifications search with autocomplete - https://phabricator.wikimedia.org/T132804#2251259 (10Pginer-WMF) >>! In T132804#2211050, @jmatazzoni wrote: > @Pginer-WMF, here are some questions to help nail down this interface: > > - If the... [15:32:49] (03PS29) 10Sbisson: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [15:38:17] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [15:40:14] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Build interface for notifications search with autocomplete - https://phabricator.wikimedia.org/T132804#2251542 (10jmatazzoni) [15:41:22] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Build interface for notifications search with autocomplete - https://phabricator.wikimedia.org/T132804#2210701 (10jmatazzoni) [16:24:31] 06Collaboration-Team-Interested, 10Notifications, 10ArticlePlaceholder, 10Wikidata, 13Patch-For-Review: Echo phpunit tests fail together with other extensions - https://phabricator.wikimedia.org/T133774#2251609 (10JanZerebecki) [16:26:18] 06Collaboration-Team-Interested, 10Notifications, 10ArticlePlaceholder, 10Wikidata, 13Patch-For-Review: Echo phpunit tests fail together with other extensions - https://phabricator.wikimedia.org/T133774#2242704 (10JanZerebecki) [16:26:21] 06Collaboration-Team-Interested, 10Notifications, 10Wikidata, 07Need-volunteer, and 2 others: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2251615 (10JanZerebecki) [16:27:09] matt_flaschen: names of clusters, like --from=cluster24,cluster25 in FlowExternalStoreMoveCluster.php - are these DB://cluster1/3710 or something different? [16:29:37] stephanebisson, in the case of api errors during fetch, the model manager doesn't get a chance to add the local model. I am adding sanity checks to places where we automatically assume local model exists, but is this a symptom of a bigger issue ? as in, should we *always* have a local model? even on errors? [16:31:27] I propose yes. It might be empty but if it exist at least, other objects don't have to check for null all the time [16:32:20] stephanebisson, okay, so the 'setModels' for the manager may need to change (the point was to add them all together) ... hm, wait, orrrrr... I can add the local model on error before proceeding. [16:32:22] hm [16:35:23] 03Collab-Team-2016-Q4, 10Notifications, 07Documentation, 13Patch-For-Review, and 2 others: Display documentation for notification types configuration on Wikimedia - https://phabricator.wikimedia.org/T132127#2251621 (10jmatazzoni) 05Open>03Resolved [16:35:51] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2251622 (10Trizek-WMF) @catrope, do you have a way to find all Flow boards on these wiki... [16:36:04] 03Collab-Team-2016-Q4, 10Flow, 10Beta-Cluster-Infrastructure: Set up second External Store cluster on Beta - https://phabricator.wikimedia.org/T128417#2251625 (10jmatazzoni) [16:36:06] 03Collab-Team-2016-Q4, 10Flow, 10Beta-Cluster-Infrastructure: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2251626 (10jmatazzoni) [16:36:09] 03Collab-Team-2016-Q4, 10Beta-Cluster-Infrastructure, 10DBA, 03Collab-Archive-2015-2016, 13Patch-For-Review: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2251624 (10jmatazzoni) 05Open>03Resolved [16:36:41] 03Collab-Team-2016-Q4, 10Notifications, 07Documentation, 13Patch-For-Review, and 2 others: Display documentation for notification types configuration on Wikimedia - https://phabricator.wikimedia.org/T132127#2189114 (10jmatazzoni) [16:36:43] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): Rationalize wgEchoDefaultNotificationTypes - https://phabricator.wikimedia.org/T132820#2251627 (10jmatazzoni) 05Open>03Resolved [16:37:19] 03Collab-Team-2016-Q4, 10Collaboration-Team-Sprint-D-2015-06-30, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, and 4 others: E10. Have Flow use ExternalStore on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T95870#2251631 (10jmatazzoni) 05Open>03Resolved [16:45:21] 03Collab-Team-2016-Q4, 10MediaWiki-Vagrant, 10MediaWiki-extensions-TorBlock, 03Collab-Archive-2015-2016, 13Patch-For-Review: TorBlock role for MediaWiki-Vagrant - https://phabricator.wikimedia.org/T130876#2251635 (10jmatazzoni) 05Open>03Resolved [16:45:23] 03Collab-Team-2016-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: [betalabs] Blocked user creating a new topic gets malformed error message - https://phabricator.wikimedia.org/T121137#2251636 (10jmatazzoni) [16:45:50] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 13Patch-For-Review, and 2 others: Exception in getDeepestCommonRoot() when viewing certain post-reply notifications - https://phabricator.wikimedia.org/T133731#2251637 (10jmatazzoni) 05Open>03Resolved [16:52:16] 03Collab-Team-2016-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 2 others: Enable Flow in id.wikipedia for testing - https://phabricator.wikimedia.org/T133254#2251657 (10Kenrick95) Any updates on this? To my knowledge id.wikipedia is now running on MediaWiki 1.27.0-wmf.22 [17:03:59] quiddity: Standup? [17:04:38] RoanKattouw, Missing standup: Today I need to look at the blog post again, and continue on CommTech work. [17:05:43] OK [17:07:52] 10Flow, 10BlueSpice, 06Editing-Department, 10MassMessage, and 14 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251705 (10Danny_B) Per IRC discussion with @Jdforrester-WMF add... [17:08:15] 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Clicking a marked-as-unread notification should mark it as read - https://phabricator.wikimedia.org/T129898#2251709 (10Catrope) >>! In T129898#2229476, @Catrope wrote: > 2) the notification jumping around as it becomes read is jarring. This ha... [17:08:35] 10Flow, 10BlueSpice, 06Editing-Department, 10MassMessage, and 14 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251728 (10Danny_B) [17:09:51] 06Collaboration-Team-Interested, 10Notifications: When opening a notification it disappears before navigating away - https://phabricator.wikimedia.org/T133975#2250870 (10Catrope) I noticed this too and commented about it on T129898, but forgot to create a separate bug for it. At T129898#2229476 I suggested th... [17:10:01] 03Collab-Team-2016-Q4, 10Notifications: When opening a notification it disappears before navigating away - https://phabricator.wikimedia.org/T133975#2251736 (10Catrope) [17:11:57] (03PS30) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [17:14:45] Trizek: https://quarry.wmflabs.org/query/9346 lists Flow boards on frwiki. You can use the Fork button to make your own query and change "frwiki" to any other wiki you need. If you need help determining wiki names or interpreting namespace numbers, let me know [17:14:59] Thanks RoanKattouw [17:19:02] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [17:19:08] 10Flow, 10BlueSpice, 06Editing-Department, 10MassMessage, and 15 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251741 (10Danny_B) [17:25:23] Getting lunch [17:34:04] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Create notifications page structured search - https://phabricator.wikimedia.org/T132805#2251769 (10jmatazzoni) [17:35:00] (03CR) 10Sbisson: Add plain text email formatter (0310 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [17:35:07] (03PS20) 10Sbisson: Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [17:48:05] (03PS21) 10Sbisson: Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [17:55:39] 03Collab-Team-2016-Q4: [betalabs] minor: When topic is Reopened, the drop-down menu displayed overlapped by a topic title below - https://phabricator.wikimedia.org/T133996#2251793 (10Etonkovidova) [18:07:05] 03Collab-Team-2016-Q4, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, and 2 others: Enable Flow in id.wikipedia for testing - https://phabricator.wikimedia.org/T133254#2251825 (10Catrope) 05Open>03Resolved >>! In T133254#2251657, @Kenrick95 wrote: > Any updates on this? To my... [18:14:42] etonkovidova, yes, the cluster ID (cluster1 or cluster24, etc.) means the same in both cases. [18:16:03] (03PS31) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [18:17:51] matt_flaschen: ok - thx. So, the names of clusters are documented somewhere, or everybody knows them ? :) [18:18:17] matt_flaschen: or there are only two of them? [18:21:05] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [18:25:42] etonkovidova, on Beta there is only one currently, cluster1 [18:25:54] etonkovidova, on production there are a bunch. I'll get links to where they're defined. [18:26:06] matt_flaschen: understood! that's easy :) [18:26:39] etonkovidova, but we're going to add another one to Beta to test migrating Flow content from one to the other. [18:28:27] etonkovidova: Production: https://phabricator.wikimedia.org/diffusion/OMWC/browse/master/wmf-config/db-eqiad.php;8f03dde5004d7de788d008c3eb534d998bce8bed$554 . Labs: https://phabricator.wikimedia.org/diffusion/OMWC/browse/master/wmf-config/db-labs.php;8f03dde5004d7de788d008c3eb534d998bce8bed$47 . [18:29:18] matt_flaschen: thx - it's helpful [18:33:55] stephanebisson, the fetching code calls for the counter.update() which then calls for a promise that resolves and calls setCount() on the counter, which then emits countChange. Guess what listens to countChange? The badge... updateBadge method then is triggered and calls modelManager.hasLocalUnread -- but the local model is not YET set in the manager. [18:34:15] stephanebisson, I am thinking of adding a "if !localmanager return;" to hasLocalUnread method [18:34:44] either that, or we will need to break apart setModels in the manager to allow for individually-setting models ? [18:35:12] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#1993170 (10Mattflaschen) >>! In T125632#2250702, @Trizek-WMF wrote: > **List of wikis th... [18:38:01] (03PS32) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [18:38:22] stephanebisson, on a good note, I fixed seenTime [18:43:02] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [18:44:28] 06Collaboration-Team-Interested, 10Flow, 10BlueSpice, 06Editing-Department, and 17 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251921 (10Mattflaschen) Flow does not provide... [18:45:37] (03PS33) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [18:45:53] mooeypoo: fantastic! [18:46:59] And I fixed all the grunt errors... [18:47:02] * mooeypoo stares at jenkins [18:48:55] mooeypoo: wait, maybe updateBadge is too coarse. A change in the counter should only update the number on the badge, that's all it knows for sure. [18:49:14] stephanebisson, yes, but it checks the local unread notifications [18:49:23] which makes sense -- if the local model exists [18:49:54] mooeypoo: fetching provides the information required to update the "mark as read btn" and maybe the "seen" business [18:51:50] stephanebisson, what do you mean? [18:53:15] model.onCountChange -> updateBadgeCount [18:53:35] model.onUpdate -> updateMarkAllReadBtn [18:53:52] model.onSeenUpdate -> updateBadgeColor [18:54:37] not sure about this [18:55:02] another option is to bundle the events, send model.onUpdate only after both the badge and fetch are finished [18:56:10] it makes it more transactional, we don't risk updating the UI based on data that is not there yet [19:07:12] stephanebisson, mh, makes sense, I'll take a look at that [19:07:27] Not sure, though. [19:07:40] mooeypoo: btw: $.when( p1, p2, ... ) [19:08:00] yeah, but when resolves when either of the promises is resolved **or** rejected [19:08:11] so most times it's less helpful [19:08:19] oh [19:08:55] that's why we added in waitForAllPromises [19:09:06] there's no $.any() [19:09:07] :\ [19:09:16] or $.all() [19:09:28] (okay, going to get my lunch salad, brb) [19:11:54] strange, I used it in EchoApi.fetchNotificationGroups [19:12:53] 06Collaboration-Team-Interested, 10Flow, 10BlueSpice, 06Editing-Department, and 17 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2213480 (10jayvdb) Ideally I can use different... [19:12:55] it shouldn't work [19:22:39] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2251991 (10Verdy_p) Note that the existing Chinese translation does not specify if it is... [19:32:09] Correction: $.when() resolves when all promises are resolved or any promise is rejected [19:32:13] So it's the equivalent of && [19:32:32] I mean, it resolves if all promises resolve, and rejects if any promise rejects [19:33:13] And this happens as soon as the outcome is known, so if you do p = $.when( p1, p2, p3 ); then if p2 rejects, p will immediately reject too, regardless of whether p1 and p3 are still pending [19:42:46] (03PS25) 10Paladox: Make VisualEditor support truly optional [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) [19:46:04] RoanKattouw, stephanebisson, are either of you able to review https://gerrit.wikimedia.org/r/#/c/271431/ ? We're already using the output of this script (wikimediaprojectnames in WikimediaMessages, for cross-wiki), and we should get it in version-control. [19:46:21] sure [19:49:53] matt_flaschen: if it's been used already I think it should be merged as-is [19:50:22] stephanebisson, well, if there's something wrong with it, we can re-run and update the output after it's merged. But we should get it in regardless. [19:50:37] RoanKattouw, stephanebisson yes, sorry, I mischaracterized $.when, but the problem still remains thta it resolves when 1 promise is rejected, not waiting fr the others to resolve or reject, which is usually not useful for our purposes [19:51:58] Moriel's waitForAll function is logically equivalent to mapping each pN -> pN' such that pN resolves when pN's either resolves or rejects (i.e. pN' = pN.then( null, function () { return $.Deferred().resolve(); } ); ) , and then $.when()ing the pN' [19:56:03] ... omg, did you just math our code? [19:56:13] Mathematicians... [19:57:40] My version is better: "Given a spherical promise in a vacuum, the overall promise resolves only when all given promises have resolved with either success or rejection". [19:57:42] ALWAYS [19:59:22] (03CR) 10Mattflaschen: [C: 032] Do not run failing Cucumber scenarios daily [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285925 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [19:59:36] only if you ASSUME optiomal conditions, no air resistance, etc [19:59:48] stephanebisson, "assume" is the realm of Mathematicians. [19:59:52] (03Abandoned) 10Mattflaschen: Followup 9eaa667: Use @skip instead so it's more obvious and greppable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/277261 (https://phabricator.wikimedia.org/T94153) (owner: 10Mattflaschen) [20:06:07] (03CR) 10Mattflaschen: "Are you referring to ext.eventLogging.subscriber." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) (owner: 10Mattflaschen) [20:07:12] mooeypoo, given a spherical promise in a vacuum, all promises always resolve, and we don't have to write error-handling. [20:07:22] Also need a Faraday cage for cosmic rays. [20:09:40] ^ RoanKattouw, not sure if we should switch to mw.track or not. On the plus side, only need one conditional dependency (not for every schema if we added more), downside is I'm not thrilled with https://phabricator.wikimedia.org/diffusion/EEVL/browse/master/modules/ext.eventLogging.subscriber.js;eb601dbe64c0912f1ae41981a01b332277c31eb9$32 (I think it calls using every time an event is received, which seems suboptimal, but [20:09:42] maybe I'm overthinking it). [20:10:33] stephanebisson, RoanKattouw, mooeypoo, does https://gerrit.wikimedia.org/r/#/c/283565/ seem useful to any of you? [20:11:27] Calling using repeatedly should be fien [20:11:43] Okay [20:11:43] It just falls through if the module is already loaded [20:12:30] (03CR) 10Catrope: "I think I meant mw.track() because that doesn't introduce a hard dependency on EventLogging." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) (owner: 10Mattflaschen) [20:13:39] (03CR) 10Mattflaschen: "Okay, will change it over to that, per IRC." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) (owner: 10Mattflaschen) [20:13:48] (03CR) 10Mattflaschen: [C: 04-1] WIP: Make FlowReplies slightly work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) (owner: 10Mattflaschen) [20:14:30] (03Merged) 10jenkins-bot: Do not run failing Cucumber scenarios daily [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285925 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [20:14:35] bd808, could you review https://gerrit.wikimedia.org/r/#/c/284092/ ? [20:15:33] 06Collaboration-Team-Interested, 10Flow, 10BlueSpice, 06Editing-Department, and 17 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2252081 (10Blahma) The original feature reques... [20:19:30] matt_flaschen: +2'd [20:42:20] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-01_(1.27.0-wmf.23), 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1781222 (10Etonkovidova) Checked in betalabs - the invitation function... [20:42:57] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-01_(1.27.0-wmf.23), 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2252159 (10Etonkovidova) [20:52:16] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2252194 (10jmatazzoni) [20:52:19] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-01_(1.27.0-wmf.23), 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2252192 (10jmatazzoni) 05Open>03Resolved [20:52:22] 06Collaboration-Team-Interested, 10Notifications, 07Epic, 07WorkType-NewFunctionality, 07user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#2252195 (10jmatazzoni) [21:00:05] matt_flaschen: anything special I need to know to run the "createHumanReadable.." script? [21:00:42] matt_flaschen: it currently fails near the end with "Notice: Undefined offset: 293 in /vagrant/mediawiki/extensions/WikimediaMaintenance/createHumanReadableProjectNameFiles.php on line 143" [21:01:13] matt_flaschen: it still generates en.json and qqq.json [21:01:36] Thanks, bd808. [21:01:45] en.json most lines look like "project-localized-name-jawiki": "Japanese ", [21:03:00] I was expecting to resolve to "Wikipedia" [21:03:06] what am I missing? [21:04:26] stephanebisson, for that you probably just need to install wikimediamessages Vagrant role. [21:04:39] I remember some kind of index error like that, not sure if we fixed it. [21:04:49] I'm looking at that now. [21:12:17] stephanebisson, it's because of the non-numeric keys ('special', 'closed'). I raised it before, but it got lost in the shuffle. Fixing now. [21:14:25] Sorry, 'special' and 'count'. [21:15:05] matt_flaschen: while you're at it, Skip projects marked as "closed" is commented out... [21:15:20] I don't know if it's on purpose or not [21:18:10] stephanebisson, yeah, that's on purpose. Well, the not skipping part (originally it skipped closed, private, and fishbowl, I suggested to Moriel we just do them all in case some other project needed them), but it shouldn't be left in as a comment. [21:21:57] matt_flaschen: is there any reason why Teste die Betafunktion „{{int:echo-pref-beta-feature-cross-wiki-message}}“ is not displayed fully translated? [21:22:14] matt_flaschen: I mean only „{{int:echo-pref-beta-feature-cross-wiki-message}}“ part is translated [21:25:00] 03Collab-Team-2016-Q4, 10Notifications: Clarify Notifications betafeature language on Preferences page - https://phabricator.wikimedia.org/T134014#2252402 (10jmatazzoni) [21:27:24] etonkovi_, which language are you testing in? [21:28:45] German? [21:28:54] matt_flaschen: yes [21:29:33] etonkovidova, how does it display for you? [21:29:59] matt_flaschen: I decided to take a look at German to see if the invitaiton is exceptionally long and I saw that the invitation is only partially translated [21:30:22] Okay, I'm testing now. [21:30:23] matt_flaschen: Get notifications from other wikis here. Try the "Erweiterte Benachrichtigungen" beta feature. [21:31:01] 03Collab-Team-2016-Q4, 10Notifications: Clarify Notifications betafeature language on Preferences page - https://phabricator.wikimedia.org/T134014#2252433 (10jmatazzoni) The current language says: > **Enhanced Notifications** > View and organize notifications more easily. Includes cross-wiki notifications, wh... [21:31:22] matt_flaschen: just to remind - it's in betalabs [21:31:32] 03Collab-Team-2016-Q4, 10Notifications: Clarify Notifications beta feature language on Preferences page - https://phabricator.wikimedia.org/T134014#2252402 (10jmatazzoni) [21:31:58] 03Collab-Team-2016-Q4, 10Notifications: Clarify Notifications beta feature language on Preferences page - https://phabricator.wikimedia.org/T134014#2252402 (10jmatazzoni) [21:33:11] etonkovidova, well, the int: is translated because that is referencing an existing string that has been there for a while. The rest should be translated on Beta Cluster, but maybe it hasn't propogated yet. [21:33:23] 03Collab-Team-2016-Q4, 10Notifications: Clarify Notifications beta feature language on Preferences page - https://phabricator.wikimedia.org/T134014#2252402 (10jmatazzoni) Comments from anyone? If not, I'll move this to RFP. [21:34:59] matt_flaschen: ok - just was interesting to see that it's listed as translated on https://translatewiki.net/w/i.php?title=Special:Translations&message=MediaWiki%3Aecho-popup-footer-beta-invitation-link [21:35:13] matt_flaschen: and not seeing it in UI [21:36:45] Oh, because RoanKattouw reverted it. :) [21:36:51] Because the i18n bot is broken. [21:37:46] Wait, it was put back though [21:41:41] etonkovidova, I checked on the command-line. It should be right now. I wouldn't worry about it unless it persists: [21:41:42] https://phabricator.wikimedia.org/P2979 [21:47:35] matt_flaschen: it miraculously appeared :) Erhalte hier Benachrichtigungen von anderen Wikis. Teste die Betafunktion „Erweiterte Benachrichtigungen“. [22:19:50] 06Collaboration-Team-Interested, 10MediaWiki-ContentHandler, 07Schema-change: Add index to page.page_content_model - https://phabricator.wikimedia.org/T103389#2252696 (10Danny_B) [22:29:50] I'm going to go home, and continue from there.