[00:00:28] (03CR) 10Mattflaschen: [C: 04-1] "While testing, I found it only counts bases of bundles, which means you can still end up with over 2000 total." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [00:00:55] Taking a break. [00:02:44] RoanKattouw: you can't [00:03:08] wat [00:03:09] the fallbacks are done at a very low level, someone else complained about this recently. i think it was wikidata folks [00:03:14] There are 14k accounts on enwiki with language=en-gb [00:03:19] you can do equals-english, yes [00:03:20] :D [00:03:20] Yeah, that's what I thought [00:03:31] Who the ... has James_F been hypnotizing people or something [00:07:31] 03Collab-Team-2016-Q4, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Collab Phlogiston velocity chart doesn't match recently closed list - https://phabricator.wikimedia.org/T133173#2241765 (10JAufrecht) [00:23:46] (03CR) 10Catrope: [C: 032] "Cool story Jenkins" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285395 (owner: 10Sbisson) [00:23:52] (03CR) 10Catrope: [C: 032] "Cool story Jenkins" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285394 (owner: 10Sbisson) [00:33:28] (03Merged) 10jenkins-bot: Browser tests: fix user agent for no-js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285395 (owner: 10Sbisson) [00:33:31] (03CR) 10jenkins-bot: [V: 04-1] Browser tests: Wait for TextField to be enabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285394 (owner: 10Sbisson) [00:44:10] (03CR) 10Catrope: [C: 032] Browser tests: Wait for TextField to be enabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285394 (owner: 10Sbisson) [00:55:39] (03Merged) 10jenkins-bot: Browser tests: Wait for TextField to be enabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285394 (owner: 10Sbisson) [01:23:14] 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 10Community-Liaisons (Apr-Jun-2016): Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2241825 (10jeblad) Yes I'm aware of... [02:24:09] See you all tomorrow [04:14:40] 03Collab-Team-2016-Q4, 10Notifications, 07Performance: Cache foreign notification count in memcached - https://phabricator.wikimedia.org/T133623#2237621 (10Catrope) a:03Catrope [07:13:51] (03PS1) 10Catrope: Make EchoForeignNotifications::getApiEndpoints() static [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285595 [07:13:54] (03PS1) 10Catrope: ForeignNotifications: Use ALL instead of null as defaults for $section params [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285596 [07:13:57] (03PS1) 10Catrope: ForeignNotifications: Move preference check out of constructor and allow force-enable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285597 [07:14:00] (03PS1) 10Catrope: NotifUser: Refactor getNotificationCount() and friends, add caching for global counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285598 (https://phabricator.wikimedia.org/T133623) [07:18:22] (03PS3) 10Catrope: Repurpose survey call-out in the footer for beta feature invitation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) [07:20:30] (03CR) 10Catrope: Repurpose survey call-out in the footer for beta feature invitation (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) (owner: 10Catrope) [07:20:37] (03PS4) 10Catrope: Repurpose survey call-out in the footer for beta feature invitation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) [07:22:28] (03CR) 10Catrope: Repurpose survey call-out in the footer for beta feature invitation (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) (owner: 10Catrope) [07:23:33] (03PS5) 10Catrope: Repurpose survey call-out in the footer for beta feature invitation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) [07:24:10] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2242102 (10Catrope) a:05Pginer-WMF>03Catrope [07:32:56] 03Collab-Team-2016-Q4, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review: Enable Flow as a Beta feature on French Wikisource - https://phabricator.wikimedia.org/T132914#2242110 (10Trizek-WMF) @Mattflaschen A user with some pages already archived has a problem: th... [07:54:30] (03PS1) 10Catrope: NotifUser: Reduce queries in resetNotificationCount() by hackily computing some values from others [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 [07:57:52] (03CR) 10jenkins-bot: [V: 04-1] NotifUser: Reduce queries in resetNotificationCount() by hackily computing some values from others [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 (owner: 10Catrope) [07:59:30] (03PS2) 10Catrope: NotifUser: Reduce queries in resetNotificationCount() by hackily computing some values from others [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 [08:02:53] (03CR) 10jenkins-bot: [V: 04-1] NotifUser: Reduce queries in resetNotificationCount() by hackily computing some values from others [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 (owner: 10Catrope) [08:13:48] (03PS3) 10Catrope: NotifUser: Reduce queries in resetNotificationCount() by hackily computing some values from others [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 [08:14:14] (03CR) 10Catrope: "I haven't tested this rigorously at all yet." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285598 (https://phabricator.wikimedia.org/T133623) (owner: 10Catrope) [08:22:31] (03CR) 10jenkins-bot: [V: 04-1] NotifUser: Reduce queries in resetNotificationCount() by hackily computing some values from others [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 (owner: 10Catrope) [09:09:13] 06Collaboration-Team-Interested, 10Flow: User don't receive email notifications concerning their Flow talk page when "Talk page message" is on, but "Flow" is off - https://phabricator.wikimedia.org/T132426#2242256 (10Trizek-WMF) >>! In T132426#2237320, @Mattflaschen wrote: > I like @Pginer-WMF's "More conversa... [10:06:11] 10Thanks: Thank for edit link of history page - https://phabricator.wikimedia.org/T133768#2242348 (10Peachey88) [10:14:26] 10Thanks: Thank for edit link of history page - https://phabricator.wikimedia.org/T133768#2242356 (10TerraCodes) I blanked my common.js and the problem went away, so I will see what script caused the problem. [10:26:57] 10Thanks: Thank for edit link of history page - https://phabricator.wikimedia.org/T133768#2242389 (10TerraCodes) The first script I added back turned out to the the one causing the problem (the scrip was [[ http://en.wikipedia.org/wiki/User:Bility/convert24hourtime.js ]]) [10:40:57] 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 10Community-Liaisons (Apr-Jun-2016): Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2242432 (10jeblad) There will be no... [12:59:00] 10Notifications, 10ArticlePlaceholder, 10Wikidata: Echo phpunit tests fail together with other extensions - https://phabricator.wikimedia.org/T133774#2242704 (10JanZerebecki) [13:14:28] 10Notifications, 10ArticlePlaceholder, 10Wikidata, 13Patch-For-Review: Echo phpunit tests fail together with other extensions - https://phabricator.wikimedia.org/T133774#2242759 (10JanZerebecki) [14:51:00] (03PS19) 10Sbisson: Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [14:55:05] (03CR) 10Sbisson: [C: 032] Make EchoForeignNotifications::getApiEndpoints() static [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285595 (owner: 10Catrope) [15:06:45] (03Merged) 10jenkins-bot: Make EchoForeignNotifications::getApiEndpoints() static [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285595 (owner: 10Catrope) [15:09:23] (03PS10) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [15:10:13] (03CR) 10Matthias Mullie: "I have not yet tested last patchset, where Matt's feedback is addressed. Will do so tomorrow." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [15:13:18] (03CR) 10Sbisson: [C: 04-1] "Yes! We have ALL, why infer meaning from null?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285596 (owner: 10Catrope) [15:27:52] (03PS1) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285657 (https://phabricator.wikimedia.org/T128190) [15:28:44] (03Abandoned) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285657 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [15:30:26] (03CR) 10Catrope: "Ha, good catch. I tried to find places where null was passed in directly, but I didn't find any." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285596 (owner: 10Catrope) [15:31:22] (03PS2) 10Catrope: ForeignNotifications: Use ALL instead of null as defaults for $section params [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285596 [15:32:05] stephanebisson: Good catch. As you may have guessed from the timestamps of those commits, I didn't test very carefully [15:32:35] (code code code -- oh crap it's 1am and I have a meeting at 8am) [15:32:39] (03PS1) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [15:34:52] (03PS2) 10Catrope: ForeignNotifications: Move preference check out of constructor and allow force-enable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285597 [15:42:02] (03PS2) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [15:58:54] (03CR) 10Catrope: "This API change in getNotificationCount() would allow us to get rid of the alertCount+msgCount hack in MobileFrontend: https://gerrit.wiki" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285598 (https://phabricator.wikimedia.org/T133623) (owner: 10Catrope) [16:04:59] 06Collaboration-Team-Interested, 10Notifications, 07Design: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264#2243184 (10Pginer-WMF) [16:07:04] (03CR) 10Sbisson: [C: 032] ForeignNotifications: Use ALL instead of null as defaults for $section params [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285596 (owner: 10Catrope) [16:08:36] 06Collaboration-Team-Interested, 10Notifications, 07Design: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264#2243230 (10Pginer-WMF) [16:12:26] (03PS3) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [16:15:11] (03PS4) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [16:16:56] (03Merged) 10jenkins-bot: ForeignNotifications: Use ALL instead of null as defaults for $section params [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285596 (owner: 10Catrope) [16:20:38] (03PS5) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [16:21:04] (03CR) 10Sbisson: [C: 032] Clean up section title handling in mention and edit-user-talk presentation models [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284845 (owner: 10Catrope) [16:23:24] (03PS3) 10Sbisson: ForeignNotifications: Move preference check out of constructor and allow force-enable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285597 (owner: 10Catrope) [16:26:34] (03PS6) 10Zfilipin: WIP Cleanup Cucumber tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285658 (https://phabricator.wikimedia.org/T128190) [16:28:40] (03CR) 10Sbisson: Move section methods into a trait (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284846 (owner: 10Catrope) [16:29:52] (03Merged) 10jenkins-bot: Clean up section title handling in mention and edit-user-talk presentation models [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284845 (owner: 10Catrope) [16:32:11] 06Collaboration-Team-Interested, 10Flow, 10Notifications, 07Crosswiki: Mail notifications should mention the wiki URL - https://phabricator.wikimedia.org/T59441#2243716 (10Quiddity) [16:32:12] 03Collab-Team-2016-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#2243718 (10Quiddity) [16:34:21] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: [[Special:Notifications]] looks very different with JavaScript disabled - https://phabricator.wikimedia.org/T59720#2243788 (10Quiddity) [16:43:03] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 10Flow, 07Easy: Add a "Mark all as read" button at Special:Notifications for mobile and no-JS users - https://phabricator.wikimedia.org/T96061#2243933 (10Quiddity) [16:43:24] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Easy: Add a "Mark all as read" button at Special:Notifications for mobile and no-JS users - https://phabricator.wikimedia.org/T96061#2243935 (10Quiddity) [16:49:35] (03CR) 10Sbisson: [C: 032] ForeignNotifications: Move preference check out of constructor and allow force-enable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285597 (owner: 10Catrope) [16:57:49] (03Merged) 10jenkins-bot: ForeignNotifications: Move preference check out of constructor and allow force-enable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285597 (owner: 10Catrope) [17:06:43] 03Collab-Team-2016-Q4, 10Notifications, 07Easy: User rights change notification email does not specify in body which account was affected - https://phabricator.wikimedia.org/T71981#740217 (10Etonkovidova) Confirmed the bug - username's part in parentheses got dropped when displayed in To header of a receive... [17:08:36] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 10Flow: Visiting Special:Notifications should not mark all Flow messages as read - https://phabricator.wikimedia.org/T97057#2244020 (10Quiddity) [17:09:58] 06Collaboration-Team-Interested, 10MediaWiki-General-or-Unknown, 10MobileFrontend, 10Reading-Web, and 2 others: Rename watchlist icon in main menu to not collide with OOJS - https://phabricator.wikimedia.org/T133156#2244027 (10MBinder_WMF) [17:10:09] 06Collaboration-Team-Interested, 10MediaWiki-General-or-Unknown, 10MobileFrontend, 10Reading-Web, 03Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters: Regression: Oojs ui icon applying to main menu watch star when echo/editor used - https://phabricator.wikimedia.org/T131931#2244034 (... [17:17:09] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 10Flow: Visiting Special:Notifications should not mark all Flow messages as read - https://phabricator.wikimedia.org/T97057#2244113 (10Mooeypoo) This is addressed in https://gerrit.wikimedia.org/r/#/c/276256/ which added 'mark as read' button to n... [17:19:03] 03Collab-Team-2016-Q4, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Collab Phlogiston velocity chart doesn't match recently closed list - https://phabricator.wikimedia.org/T133173#2244125 (10JAufrecht) p:05Triage>03Normal [17:19:10] 03Collab-Team-2016-Q4, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Collab recently closed Phlogiston report has 1000s of invalid items - https://phabricator.wikimedia.org/T133172#2244126 (10JAufrecht) p:05Triage>03Normal [17:25:13] I'm going to write a quick patch to add the Alert/Messages sorting to DisplayNotificationConfiguration. It's weird that those are per-type, not per-category. [17:33:12] Sounds good [17:33:46] 06Collaboration-Team-Interested, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#2244166 (10Arlolra) a:05Arlolra>03None [17:50:25] 03Collab-Team-2016-Q4, 10Notifications: Gracefully handle outdated echo_unread_wikis rows when a notification type has changed categories (alert->message or v.v.) - https://phabricator.wikimedia.org/T132954#2244233 (10jmatazzoni) [17:50:27] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07Epic, 07Tracking: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2244232 (10jmatazzoni) [17:51:41] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2244234 (10jmatazzoni) [17:51:43] 03Collab-Team-2016-Q4, 10Notifications: Gracefully handle outdated echo_unread_wikis rows when a notification type has changed categories (alert->message or v.v.) - https://phabricator.wikimedia.org/T132954#2215113 (10jmatazzoni) [17:54:22] (03PS2) 10Sbisson: NotifUser: Refactor getNotificationCount() and friends, add caching for global counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285598 (https://phabricator.wikimedia.org/T133623) (owner: 10Catrope) [18:01:18] 03Collab-Team-2016-Q4, 10Notifications: Gracefully handle outdated echo_unread_wikis rows when a notification type has changed categories (alert->message or v.v.) - https://phabricator.wikimedia.org/T132954#2244292 (10Catrope) [18:01:21] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2244291 (10Catrope) [18:01:55] 03Collab-Team-2016-Q4, 10Notifications: Gracefully handle outdated echo_unread_wikis rows when a notification type has changed categories (alert->message or v.v.) - https://phabricator.wikimedia.org/T132954#2244299 (10jmatazzoni) [18:01:57] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#2244298 (10jmatazzoni) [18:06:23] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#2244343 (10jmatazzoni) [18:06:25] 03Collab-Team-2016-Q4, 10Notifications: Remove automatic mark-as-read (of alerts) when you open the popup - https://phabricator.wikimedia.org/T132525#2244342 (10jmatazzoni) [18:07:27] 03Collab-Team-2016-Q4, 10Notifications: Remove automatic mark-as-read (of alerts) when you open the popup - https://phabricator.wikimedia.org/T132525#2201485 (10jmatazzoni) [18:07:29] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#1919410 (10jmatazzoni) [18:15:57] Getting lunch [18:21:22] 03Collab-Team-2016-Q4, 10Flow, 13Patch-For-Review: FlowReplies is not firing in production - https://phabricator.wikimedia.org/T96620#2244424 (10Catrope) The current FlowReplies schema seems reasonably useful for tracking bounce rate etc as Neil says, but it doesn't track which editor the user used, so it do... [18:21:56] matt_flaschen: https://phabricator.wikimedia.org/T96620#2237298 says that https://gerrit.wikimedia.org/r/#/c/282841/ is no longer WIP but Gerrit disagrees [18:22:08] Did you forgot to upload a patchset, or did you just forget to change the commit message? [18:37:24] the only logical conclusion is that you should review my patch instead [18:38:57] haha yes [18:41:04] (03CR) 10Catrope: [C: 031] "This looks fine, but why is the dynamic dependency even necessary? I thought there was a helper in EventLogging that did mw.loader.using( " (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) (owner: 10Mattflaschen) [18:43:22] ha this patch is smaller than I thought, only 280 lines [18:51:03] 10Notifications: Fatal error: Call to undefined method ApiEchoNotifications::getNotifications() in NotificationsTest.php on line 27 - https://phabricator.wikimedia.org/T133797#2244516 (10aude) [18:55:38] 10Notifications: Fatal error: Call to undefined method ApiEchoNotifications::getNotifications() in NotificationsTest.php on line 27 - https://phabricator.wikimedia.org/T133797#2244539 (10Catrope) This test file was created by @Legoktm in 2013 (3e94bfac8b3e6a86a108c1588dc08d5882d856fe) and hasn't been modified si... [18:57:21] RoanKattouw, re: problems with tests, see also this, in case you hadn't already https://phabricator.wikimedia.org/T133774 [18:58:53] I hadn't seen that particular one, but there have been several mysterious test failures no one understands [18:59:03] Almost certainly unrelated to this stray file though [19:02:09] stephanebisson: Hmm, so for plain text you create aPlainTextDigestEmailFormatter that you pass all the data, but for HTML you create an EmailDigest that you pass all the data again, then pass that EmailDigest instance to an HTMLEmailFormatter? [19:02:39] Also it looks like in the HTML case $textEmailDigestFormatter->format() is called and its result is later thrown away [19:02:43] RoanKattouw: this patch is just for plaintext [19:02:54] Ooh [19:02:58] I see the left side now [19:03:15] but the plaintext result is not thrown away, it is included in the html result [19:03:28] as a multipart body [19:03:54] Oh yes I see, $content is used on line 273 before it's overwritten on line 276 [19:19:35] 10Notifications, 07Technical-Debt: Echo uses deprecated "apitoken_edit" - https://phabricator.wikimedia.org/T133802#2244646 (10He7d3r) [19:19:56] 10Notifications, 07Technical-Debt: Echo: Update usage of deprecated "apitoken_edit" - https://phabricator.wikimedia.org/T133802#2244660 (10He7d3r) [19:29:05] RoanKattouw: should I remove the icon from the notification email until we fix it? [19:33:51] 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 4 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2244668 (10ArielGlenn) Ok, I see from https://wikitech.wikimedia.org/wiki/Deployments that barring any issues it will be deployed to all wikis T... [19:35:41] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 13Patch-For-Review, and 2 others: Exception in getDeepestCommonRoot() when viewing certain post-reply notifications - https://phabricator.wikimedia.org/T133731#2240951 (10Etonkovidova) General regression testing is done on testwiki. No problems found. [19:43:59] (03CR) 10Mattflaschen: [C: 032] Repurpose survey call-out in the footer for beta feature invitation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) (owner: 10Catrope) [19:53:37] (03Merged) 10jenkins-bot: Repurpose survey call-out in the footer for beta feature invitation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) (owner: 10Catrope) [19:54:03] stephanebisson: Until we fix what? [19:54:09] The SVG issue? [19:54:14] RoanKattouw: yeah [19:54:35] is it just in gmail or is it widespread? [19:57:41] 03Collab-Team-2016-Q4, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review: Enable Flow as a Beta feature on French Wikisource - https://phabricator.wikimedia.org/T132914#2244718 (10Mattflaschen) >>! In T132914#2242110, @Trizek-WMF wrote: > @Mattflaschen A user wit... [20:01:09] 06Collaboration-Team-Interested, 10Notifications, 10ArticlePlaceholder, 10Wikidata, 13Patch-For-Review: Echo phpunit tests fail together with other extensions - https://phabricator.wikimedia.org/T133774#2244724 (10Mattflaschen) [20:01:41] I don't know how widespread iti s [20:01:57] But the fact that Google is holding back adoption of SVG this way is a bit lame :/ [20:03:05] stephanebisson: I'm inclined to say, let's keep them in, and work around it later [20:03:25] We may be able to use RLIM automagic PNG conversion [20:03:30] *RLIM's [20:03:52] alright [20:11:47] (03PS1) 10Sbisson: [WIP] HTML email formatter using presentation models [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285720 (https://phabricator.wikimedia.org/T121067) [20:19:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] HTML email formatter using presentation models [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285720 (https://phabricator.wikimedia.org/T121067) (owner: 10Sbisson) [20:27:18] (03PS2) 10Sbisson: [WIP] HTML email formatter using presentation models [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285720 (https://phabricator.wikimedia.org/T121067) [20:29:12] 03Collab-Team-2016-Q4, 10Flow, 10MediaWiki-Patrolling: Flow "mark as patrolled" links don't work (claims "Session failure") - https://phabricator.wikimedia.org/T133341#2228761 (10Etonkovidova) Re-checked in betalabs cawiki (and also just general testing for patrolling) - could not reproduce. The tested sce... [20:35:37] 06Collaboration-Team-Interested, 10Notifications, 10UI-Standardization: HTML emails triggered from echo should use a visual design that mimics OOUI style layout and controls - https://phabricator.wikimedia.org/T64969#2244842 (10Jdforrester-WMF) [20:41:00] (03CR) 10Mattflaschen: [C: 04-1] "I noticed something new, which I didn't see before, and also didn't hit in testing because I have over 2000, but don't have over 2000 bund" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [20:51:36] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 10Flow: Visiting Special:Notifications should not mark notifications as read - https://phabricator.wikimedia.org/T97057#2244898 (10Mattflaschen) [20:51:49] 10Collab-Notifications-Page, 06Collaboration-Team-Interested: Visiting Special:Notifications should not mark notifications as read - https://phabricator.wikimedia.org/T97057#1231795 (10Mattflaschen) [20:52:17] 06Collaboration-Team-Interested, 10Flow: [betalabs-Regression] 'Browse topics' "[FLOW] Rendered topic not found when attempting to scroll" - https://phabricator.wikimedia.org/T133213#2244901 (10Etonkovidova) Moving the issue to Collaboration Q4 board. Two reason - most likely related to {T122873} - much easi... [20:53:22] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2244906 (10Mattflaschen) [20:54:08] 03Collab-Team-2016-Q4, 10Flow: [betalabs-Regression] 'Browse topics' "[FLOW] Rendered topic not found when attempting to scroll" - https://phabricator.wikimedia.org/T133213#2244907 (10Etonkovidova) [20:59:58] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2244932 (10Mattflaschen) > Make the Talk Page category apply to all talk page notifications, including Flow notifications. We should also rename it to clarify it only... [21:00:28] (03CR) 10Catrope: Add plain text email formatter (0310 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [21:00:35] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2244938 (10Mattflaschen) [21:02:22] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2225404 (10Mattflaschen) However, there are some extensions that are only on certain wikis, e.g. EducationProgram. Thus, they'll only be displayed where they're enabled. [21:05:06] Sorry, missed some scrollback, so reading belatedly. RoanKattouw, re https://phabricator.wikimedia.org/T96620#2237298 neither. I meant *if* we decided to not fix it now, but also not remove it (#1), I would just unmark it as WIP (but document that a lot of it still didn't work). [21:05:25] Oh OK [21:07:04] stephanebisson: I reviewed your email formatter patch ---^^ . The comments are on an older PS, sorry about that. It looks good, the only thing I'm worried about is issues with mixing HTML-escaped text and plain text [21:08:23] 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 4 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2244961 (10Mattflaschen) Sounds good, thanks. [21:32:47] 03Collab-Team-2016-Q4, 10Notifications: [production] minor: 'Mark as read' cross-wiki alerts displays blank flyout - https://phabricator.wikimedia.org/T132202#2245054 (10Etonkovidova) [21:35:03] 03Collab-Team-2016-Q4, 10Flow: [betalabs] 'Uncaught TypeError: Cannot read property 'commandRegistry' of null' for posting new topic - https://phabricator.wikimedia.org/T121614#2245086 (10Etonkovidova) Re-checked in betalabs -no errors in Console are displayed. [21:36:24] 10Notifications: Notifications hangs at nowiki - https://phabricator.wikimedia.org/T133817#2245092 (10jeblad) [21:43:06] 10Notifications: Notifications hangs at nowiki - https://phabricator.wikimedia.org/T133817#2245122 (10jeblad) [21:43:36] 03Collab-Team-2016-Q4, 10Flow: [production] Regression: FF only- flow-menu-js-drop cannot be dismissed after pressing Cancel - https://phabricator.wikimedia.org/T132211#2245123 (10Etonkovidova) [21:45:07] (03PS1) 10Mattflaschen: Display special: Add which section (curr. Alert v. Msg.) each type's in [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285760 (https://phabricator.wikimedia.org/T123018) [21:47:03] 03Collab-Team-2016-Q4, 10Flow: [betalabs-Regression] 'Browse topics' "[FLOW] Rendered topic not found when attempting to scroll" - https://phabricator.wikimedia.org/T133213#2245139 (10Etonkovidova) For testing: re-check {T128431} after the fix. [21:48:32] 10Notifications: Notifications hangs at nowiki - https://phabricator.wikimedia.org/T133817#2245092 (10Catrope) This is because there's code extending `Array.prototype`. I'll add a `hasOwnProperty` check shortly. [21:59:33] (03PS1) 10Catrope: Follow-up 1608a5e6fc: add hasOwnProperty check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285762 (https://phabricator.wikimedia.org/T133817) [21:59:46] matt_flaschen: Wanna trade code reviews? [22:00:00] RoanKattouw, sure. [22:00:04] I'd like to get that ---^^ in for SWAT and the wmf21 cherry-pick is going to be slightly conflicty [22:01:34] (03CR) 10Mattflaschen: [C: 032] Follow-up 1608a5e6fc: add hasOwnProperty check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285762 (https://phabricator.wikimedia.org/T133817) (owner: 10Catrope) [22:04:17] (03CR) 10Catrope: [C: 032] Display special: Add which section (curr. Alert v. Msg.) each type's in (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285760 (https://phabricator.wikimedia.org/T123018) (owner: 10Mattflaschen) [22:04:31] Thanks [22:05:56] matt_flaschen: You re-opened https://phabricator.wikimedia.org/T100515 [GettingStarted] having said "We can always reopen if it happens again..." – I assume that means it did happen again? [22:07:54] James_F, yes. https://phabricator.wikimedia.org/T94154#2066037 [22:09:47] James_F, my theory is that Redis is losing its entire database, including but not limited to this, maybe due to OOM, or someone restarting the service, or the whole server... [22:10:58] 10Notifications, 13Patch-For-Review: Notifications hangs at nowiki - https://phabricator.wikimedia.org/T133817#2245195 (10jeblad) My extension, its used in two gadgets. [22:11:25] RoanKattouw, yeah, the ucfirst hack is... interesting. I was almost going to put a comment about how HHVM doesn't like call_user_func. I ended up leaving it like that since AttributeManager itself also does it. [22:12:07] hah [22:12:08] (03CR) 10Legoktm: [C: 032] Follow-up 1608a5e6fc: add hasOwnProperty check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285762 (https://phabricator.wikimedia.org/T133817) (owner: 10Catrope) [22:12:17] lol [22:12:25] uh weird, gerrit didn't show me that it was already +2'd >.> [22:12:34] Hey BTW legoktm now that you're here [22:12:46] Do you know why mw-config was made ff-only? [22:13:01] nope [22:13:01] (Maybe this was answered in -releng, I haven't skipped through the overnight backscroll yet) [22:13:15] Cause there are some annoying Zuul bugs with that :/ [22:13:21] like what? [22:13:25] My workflow while doing SWAT yesterday was: [22:13:28] * +2 a patch [22:13:34] * Zuul starts gate-and-submit [22:13:56] * Zuul V+2s the patch and tries to submit [22:14:00] RoanKattouw, I'll do the follow up after I finish the External Store beta thing. [22:14:04] * Submit fails because the patch needs a rebase [22:14:12] (This was foreseeable when the g-a-s job was first queued) [22:14:18] (which the ff-only thing is also somewhat annoying for) [22:14:19] * Roan hits the rebase button [22:14:30] * The +2 sticks on the rebased patch [22:14:33] * Zuul does nothing [22:14:38] * Remove the +2 and add it back again [22:14:45] * Now Zuul runs gate-and-submit again, and it merges this time [22:15:07] ff-only is a good idea to make sure deployers aren't tripping over each other [22:15:25] I would suggest pulling all the patches you want to merge locally, and cherry-picking them on top of each other so you have a stack you can merge [22:15:35] So 1) Zuul will happily try testing and submitting patches that cannot merge because of the ff-only criterion, and 2) Zuul doesn't rerun gate-and-submit when a rebase preserves a +2 [22:16:06] I usually do them in sequence anyway (+2, wait for merge, pull, deploy, +2 next one) [22:16:15] So that's fine, I just need to add "rebase" to that sequence [22:16:25] yeah, just make sure rebase is your #1 step [22:16:27] My annoyance is that it's kind of unforgiving if you don't rebase at the right time [22:27:37] matt_flaschen: Plausible. Thanks. [22:29:46] 03Collab-Team-2016-Q4, 10Beta-Cluster-Infrastructure, 10DBA, 03Collab-Archive-2015-2016, 13Patch-For-Review: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2245311 (10Mattflaschen) Working fine. I did a couple tests at http://test.wikimedia.beta.wmflabs.org/wiki/Vorlage:Lk... [22:35:28] RoanKattouw, testwiki on Beta Cluster is now using External Store for both Flow and regular content. If you +1 https://gerrit.wikimedia.org/r/285765 (doing it everywhere on Beta Cluster), I'll merge and test that as well. [22:35:40] Excellent! [22:35:45] RoanKattouw, I think etonkovidova can QA them together. There's nothing really distinct about testwiki. That was just to make sure it didn't completely break everything. [22:36:01] Yeah sounds good [22:36:02] +1ed [22:36:36] matt_flaschen: yes, I saw comments on the ticket(s) . Will do it. [22:37:38] Thanks, etonkovidova. I just +2'ed https://gerrit.wikimedia.org/r/#/c/285765/ . [22:39:51] 03Collab-Team-2016-Q4, 10Beta-Cluster-Infrastructure, 10DBA, 03Collab-Archive-2015-2016, 13Patch-For-Review: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2245341 (10Mattflaschen) A few DB queries I used to verify (260 is http://test.wikimedia.beta.wmflabs.org/wiki/Vorlage... [22:45:20] (03PS3) 10Catrope: Move section methods into a trait [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284846 [22:48:02] (03CR) 10Catrope: Move section methods into a trait (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284846 (owner: 10Catrope) [22:48:56] (03PS4) 10Catrope: NotifUser: Reduce queries in resetNotificationCount() by hackily computing some values from others [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285601 [22:49:42] 03Collab-Team-2016-Q4, 10Beta-Cluster-Infrastructure, 10DBA, 03Collab-Archive-2015-2016, 13Patch-For-Review: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2245384 (10Mattflaschen) Tested enwiki at http://en.wikipedia.beta.wmflabs.org/wiki/UserMergeoujuvz and http://en.wiki... [22:51:40] Now everywhere on Beta Cluster [22:51:53] (03PS2) 10Catrope: Display special: Add which section (curr. Alert v. Msg.) each type's in [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285760 (https://phabricator.wikimedia.org/T123018) (owner: 10Mattflaschen) [22:52:13] (03CR) 10Catrope: "PS2: fix phpcs failure" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285760 (https://phabricator.wikimedia.org/T123018) (owner: 10Mattflaschen) [23:08:30] RoanKattouw, I grepped for getAlertEvents and getMessageEvents, to see if I should get rid of them, or just have them call a common function. [23:08:31] "Oh good, there are no callers". Wait... [23:15:51] Ha. [23:20:56] 06Collaboration-Team-Interested, 10MediaWiki-General-or-Unknown, 10MobileFrontend, 10Reading-Web-Backlog, and 2 others: Rename watchlist icon in main menu to not collide with OOJS - https://phabricator.wikimedia.org/T133156#2223776 (10Jdlrobson) a:03Jdlrobson [23:21:25] (03CR) 10Mattflaschen: [C: 04-1] "Will amend to fix the ucfirst thing." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285760 (https://phabricator.wikimedia.org/T123018) (owner: 10Mattflaschen) [23:50:07] (03PS3) 10Mattflaschen: Display special: Add which section (curr. Alert v. Msg.) each type's in [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285760 (https://phabricator.wikimedia.org/T123018) [23:56:16] (03CR) 10jenkins-bot: [V: 04-1] Follow-up 1608a5e6fc: add hasOwnProperty check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285762 (https://phabricator.wikimedia.org/T133817) (owner: 10Catrope)