[00:24:01] 03Collab-Team-2016-Q4, 10MediaWiki-Unit-tests, 05MW-1.27-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): UIDGeneratorTest::testTimestampedUID is flaky (currently disabled) - https://phabricator.wikimedia.org/T131549#2237599 (10jmatazzoni) 05Open>03Resolved [00:27:13] 03Collab-Team-2016-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: Deleted wikitext Talk page cannot be restored after EnableFlow creates the same page - https://phabricator.wikimedia.org/T104591#1421736 (10jmatazzoni) @matthiasmullie @Mattflaschen @Catrope, before I close this, what about the... [00:34:51] (03CR) 10Mattflaschen: [C: 032] "Looka foos, NS Log file and force-recovery-conversion work for me as expected." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273903 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [00:36:15] (03CR) 10Mattflaschen: "s/Looka foos, NS/Looks good./" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273903 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [00:41:13] 10Notifications, 07Performance: Cache foreign notification count in memcached? - https://phabricator.wikimedia.org/T133623#2237621 (10Catrope) [00:43:03] (03Merged) 10jenkins-bot: Add a source store that uses import results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273903 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [00:44:59] 10Notifications, 07Performance: Cache foreign notification count in memcached? - https://phabricator.wikimedia.org/T133623#2237649 (10ori) > Should we cache this in memcached too? My gut says it can't hurt, especially since we already do a getMulti() to memc so there would be essentially zero additional cost t... [01:21:07] 06Collaboration-Team-Interested, 10Flow: User don't receive email notifications concerning their Flow talk page when "Talk page message" is on, but "Flow" is off - https://phabricator.wikimedia.org/T132426#2237703 (10Mattflaschen) https://www.mediawiki.org/wiki/Special:DisplayNotificationsConfiguration may hel... [01:22:30] 03Collab-Team-2016-Q4, 10Notifications, 07Documentation, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): Display documentation for notification types configuration on Wikimedia - https://phabricator.wikimedia.org/T132127#2237716 (10Mattflaschen) You can see this at https://www.mediawiki.org/... [01:27:23] 03Collab-Team-2016-Q4, 10Notifications, 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2237719 (10Catrope) >>! In T117669#2237319, @jmatazzoni wrote: > **INFORMATION [?] TOOLTIP/HOVER TEXT: **This panel provides informatio... [01:30:46] 03Collab-Team-2016-Q4, 10Notifications, 07Performance: Cache foreign notification count in memcached? - https://phabricator.wikimedia.org/T133623#2237721 (10Catrope) [01:31:19] 03Collab-Team-2016-Q4, 10Notifications, 07Performance: Cache foreign notification count in memcached? - https://phabricator.wikimedia.org/T133623#2237621 (10Catrope) [01:31:54] 03Collab-Team-2016-Q4, 10Notifications, 07Performance: Cache foreign notification count in memcached - https://phabricator.wikimedia.org/T133623#2237621 (10Catrope) [01:33:28] 03Collab-Team-2016-Q4, 10Flow, 10MediaWiki-Vagrant: Split Flow role - https://phabricator.wikimedia.org/T133629#2237725 (10Mattflaschen) [01:34:12] 03Collab-Team-2016-Q4, 10Flow, 10MediaWiki-Vagrant: Split Flow role - https://phabricator.wikimedia.org/T133629#2237725 (10Mattflaschen) [01:34:17] (03PS1) 10Catrope: Repurpose survey call-out in the footer for beta feature invitation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) [01:34:53] 03Collab-Team-2016-Q4, 10Flow, 10MediaWiki-Vagrant: Split Flow role - https://phabricator.wikimedia.org/T133629#2237725 (10Mattflaschen) [01:35:11] 03Collab-Team-2016-Q4, 10Flow, 10MediaWiki-Vagrant: Split Flow role - https://phabricator.wikimedia.org/T133629#2237725 (10Mattflaschen) [01:36:02] 03Collab-Team-2016-Q4, 10Notifications, 07Performance: Cache foreign notification count in memcached - https://phabricator.wikimedia.org/T133623#2237747 (10Catrope) Probably the best way to do this would be to have a global memc key containing the total global notification count. [01:36:26] matt_flaschen: Review on https://gerrit.wikimedia.org/r/285326 would be welcome [01:39:43] RoanKattouw, sure, will take a look tomorrow morning. [01:39:54] I'm probably going to head out pretty soon. [01:50:53] 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 10Community-Liaisons (Apr-Jun-2016): Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2237759 (10Mattflaschen) >>! In T13... [02:03:19] Have a good night, everyone. [03:54:47] 10Flow, 06translatewiki.net: Message Mediawiki:Flow-terms-of-use-edit - https://phabricator.wikimedia.org/T133571#2237915 (10jayvdb) Interesting that both of these are correct https://no.wikipedia.org/wiki/MediaWiki:Flow-terms-of-use-edit/nb https://no.wikipedia.org/wiki/MediaWiki:Flow-terms-of-use-edit/no fw... [03:55:20] 10Flow, 06translatewiki.net: Message Mediawiki:Flow-terms-of-use-edit on nowp is English - https://phabricator.wikimedia.org/T133571#2237921 (10jayvdb) [05:22:28] 06Collaboration-Team-Interested, 10Notifications, 10MassMessage, 13Patch-For-Review: Override user-talk Echo notification with something more MassMessage-specific - https://phabricator.wikimedia.org/T59234#2238111 (10MZMcBride) I left a relevant note at T71954#2237889. [05:22:57] 06Collaboration-Team-Interested, 10Notifications: "MediaWiki message delivery left you a message on Wikipedia" and similar e-mail subject lines need further thought - https://phabricator.wikimedia.org/T62119#2238117 (10MZMcBride) I left a relevant note at T71954#2237889. [08:04:52] 06Collaboration-Team-Interested, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, and 2 others: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2238374 (10darthbhyrava) a:03darthbhyrava [08:25:19] 06Collaboration-Team-Interested, 10Thanks, 10pywikibot-core, 03Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2238405 (1001tonythomas) Welcome to #google-summer-of-code-2016 and to the Community Bonding period! Happy to have you here, an... [09:24:00] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2238667 (10Pginer-WMF) >>! In T117669#2237719, @Catrope wrote: >>>! In T117669#2237319, @jmatazzoni wrote: >> **I... [09:35:37] (03CR) 10Matthias Mullie: Server-side crosswiki requests (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [09:35:49] (03PS12) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [10:37:52] 10Thanks, 06Project-Admins, 10pywikibot-core: Create 'Pywikibot-Thanks' project - https://phabricator.wikimedia.org/T133665#2238857 (10darthbhyrava) [10:39:55] 10Flow, 06translatewiki.net: Message Mediawiki:Flow-terms-of-use-edit on nowp is English - https://phabricator.wikimedia.org/T133571#2238872 (10jeblad) An user at noiki set the message locally to correct the English message. [10:58:37] 06Collaboration-Team-Interested, 10Thanks, 10pywikibot-core, 03Google-Summer-of-Code-2016: Community bonding evaluation for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133666#2238880 (10darthbhyrava) [11:14:37] 06Collaboration-Team-Interested, 10Thanks, 10pywikibot-core, 03Google-Summer-of-Code-2016: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2238922 (10darthbhyrava) [12:30:38] (03PS16) 10Sbisson: Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [13:02:51] 03Collab-Team-2016-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2239228 (10Pginer-WMF) I tried to capture the current status of bundles below, as a reference to define later the concise text for items inside a bundle, and also eval... [13:11:10] 03Collab-Team-2016-Q4, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2239292 (10SBisson) >>! In T127813#2239228, @Pginer-WMF wrote: > For **user-rights** I'm not sure if messages such as "Your user rights were changed. You have been ad... [13:35:32] (03PS1) 10Sbisson: Browser tests: Wait for TextField to be enabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285394 [13:35:43] (03PS1) 10Sbisson: Browser tests: fix user agent for no-js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285395 [13:56:40] 06Collaboration-Team-Interested, 10Thanks, 10pywikibot-core, 03Google-Summer-of-Code-2016: Community bonding evaluation for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133666#2239483 (10Sumit) [14:11:46] (03PS17) 10Sbisson: Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [14:16:30] (03PS1) 10Zfilipin: Do not run broken Selenium test in CI [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285397 (https://phabricator.wikimedia.org/T128190) [14:20:06] (03CR) 10Zfilipin: "The patch fixes the Jenkins job: https://integration.wikimedia.org/ci/view/selenium/job/selenium-Echo-2016-04-26/" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285397 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [14:23:30] 10Thanks, 06Project-Admins, 10pywikibot-core, 15User-Luke081515: Create 'Pywikibot-Thanks' project - https://phabricator.wikimedia.org/T133665#2239566 (10Luke081515) p:05Triage>03Normal a:03Luke081515 [14:25:24] 10Thanks, 06Project-Admins, 10pywikibot-core, 15User-Luke081515: Create 'Pywikibot-Thanks' project - https://phabricator.wikimedia.org/T133665#2238857 (10Luke081515) 05Open>03Resolved Created #Pywikibot-Thanks. [14:29:13] 06Collaboration-Team-Interested, 10Flow, 06Editing-Department, 10MobileFrontend: Edit pencil icon displayed as protected unnecessarily when viewing Flow page in MobileFrontend - https://phabricator.wikimedia.org/T130322#2239593 (10Zppix) a:03Jdforrester-WMF [15:29:39] (03PS2) 10Zfilipin: WIP Do not run broken Selenium test in CI [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285397 (https://phabricator.wikimedia.org/T128190) [15:31:35] (03PS1) 10Zfilipin: WIP page-object 1.1.1, are you breaking stuff? [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285410 [15:39:30] (03Abandoned) 10Zfilipin: WIP Do not run broken Selenium test in CI [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285397 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [15:40:14] (03PS2) 10Zfilipin: page-object 1.1.1 causes a scenario to fail [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285410 (https://phabricator.wikimedia.org/T128190) [15:41:35] (03CR) 10Zfilipin: "Tested at https://integration.wikimedia.org/ci/view/selenium/job/selenium-Echo-2016-04-26/" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285410 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [15:43:14] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2239896 (10jmatazzoni) I think it's OK to skip the tooltip (and remove the ? icon.) [15:50:29] (03Abandoned) 10Zfilipin: page-object 1.1.1 causes a scenario to fail [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285410 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [15:51:06] (03Restored) 10Zfilipin: WIP Do not run broken Selenium test in CI [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285397 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [15:51:16] (03PS3) 10Zfilipin: Do not run broken Selenium test in CI [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285397 (https://phabricator.wikimedia.org/T128190) [15:53:37] (03CR) 10Zfilipin: [C: 032] Do not run broken Selenium test in CI [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285397 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [16:11:01] (03Merged) 10jenkins-bot: Do not run broken Selenium test in CI [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285397 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [16:26:24] (03PS18) 10Sbisson: Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [17:10:54] stephanebisson, this is my problem, but none of the solutions work for me. https://www.google.ca/search?q=google+hangout+autoadjust+microphone - i currently blame pulseaudio. My box is due for a reinstall though, so maybe that will resolve it. [17:36:12] 06Collaboration-Team-Interested, 10MediaWiki-General-or-Unknown, 10MobileFrontend, 03Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): Rename watchlist icon in main menu to not collide with ... - https://phabricator.wikimedia.org/T133156#2240434 [18:24:17] Getting lunch [18:36:03] 06Collaboration-Team-Interested, 10Flow, 06Editing-Department, 10MobileFrontend: Edit pencil icon displayed as protected unnecessarily when viewing Flow page in MobileFrontend - https://phabricator.wikimedia.org/T130322#2240686 (10Jdforrester-WMF) a:05Jdforrester-WMF>03None [18:40:25] stephanebisson: I cannot view any page in betalabs (except User talk pages) via Search box - "The character encoding of the HTML document was not declared." [18:40:39] 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review: Flow shows errors when users don't have VisualEditor installed - https://phabricator.wikimedia.org/T131055#2240705 (10Jdforrester-WMF) p:05Triage>03Lowest [18:40:55] stephanebisson: RoanKattouw: what possibly it could be? via url all seems to be fine [18:41:11] WTF [18:41:14] That could be a bug in MW [18:41:28] stephanebisson: RoanKattouw: https://en.wikipedia.beta.wmflabs.org/w/index.php?search=Mavetuna&title=Special%3ASearch&go=Go [18:42:05] Yup I see it [18:42:23] RoanKattouw: not ours, I hope? [18:42:30] No, not our bug [18:44:09] RoanKattouw: good [18:44:09] I told Erik, he's on it [18:46:58] RoanKattouw: thx! [19:04:39] (03PS2) 10Catrope: Repurpose survey call-out in the footer for beta feature invitation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) [19:05:01] 03Collab-Team-2016-Q4, 10MediaWiki-Vagrant, 10MediaWiki-extensions-GlobalBlocking, 03Collab-Archive-2015-2016, 13Patch-For-Review: Add role for GlobalBlocking - https://phabricator.wikimedia.org/T69104#740731 (10Etonkovidova) Checked on local machine - Special:GlobalBlock and Special:GlobalBlockList work... [19:09:50] 10Flow, 10VisualEditor, 10VisualEditor-ContentEditable: Cursor ends up inside template in Flow mention inspector (and possibly other inline templates) - https://phabricator.wikimedia.org/T133608#2240856 (10Jdforrester-WMF) p:05Triage>03High [19:19:51] [20:18:54] mediawiki.org Special:Notifications is throwing a Exception encountered, of type "BadMethodCallException" [19:20:40] Looking [19:20:59] WFM, looking at logs [19:21:53] Exception from line 753 of /srv/mediawiki/php-1.27.0-wmf.22/extensions/Flow/includes/Notifications/Controller.php: Call to a member function equals() on a non-object (null) [19:23:09] matt_flaschen: That --^^ is your DeepestCommonRoot code [19:23:29] * RoanKattouw files UBN bug [19:24:07] :(, thanks. [19:26:04] 10Notifications: Exception in getDeepestCommonRoot() when viewing certain post-reply notifications - https://phabricator.wikimedia.org/T133731#2240951 (10Catrope) [19:26:20] 03Collab-Team-2016-Q4, 10Notifications: Exception in getDeepestCommonRoot() when viewing certain post-reply notifications - https://phabricator.wikimedia.org/T133731#2240963 (10Catrope) p:05Triage>03Unbreak! a:03Mattflaschen [19:27:14] Reedy, it would help if I knew their MediaWiki.org username. What channel were they in? [19:27:22] #mediawiki [19:32:36] RoanKattouw, I think I found it. Writing a quick test. [19:37:18] (03CR) 10Catrope: [C: 031] "Looks good, pending review from the security team" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [19:37:25] (03PS9) 10Catrope: Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [19:37:29] (03CR) 10Catrope: [C: 032] Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [19:46:55] (03PS1) 10Mattflaschen: Fix deepest common root when first path is longer and later is a prefix [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285448 (https://phabricator.wikimedia.org/T133731) [19:48:42] 03Collab-Team-2016-Q4, 10Notifications: Exception in getDeepestCommonRoot() when viewing certain post-reply notifications - https://phabricator.wikimedia.org/T133731#2241096 (10Mattflaschen) Gerrit said "internal server error" when I first uploaded it, and evidently the bot missed it. It's https://gerrit.wiki... [19:48:54] ^ RoanKattouw [19:53:49] stephanebisson, are the two TextArea->enabled? at https://gerrit.wikimedia.org/r/#/c/285394/1/tests/browser/features/support/extensions.rb deliberate? [19:54:24] matt_flaschen: oups, not the second one [19:56:06] (03CR) 10Mattflaschen: [C: 032] Browser tests: fix user agent for no-js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285395 (owner: 10Sbisson) [19:58:00] 03Collab-Team-2016-Q4, 06Collaboration-Team-Interested, 10Flow, 06Editing-Department, 10MobileFrontend: Edit pencil icon displayed as protected unnecessarily when viewing Flow page in MobileFrontend - https://phabricator.wikimedia.org/T130322#2241137 (10Mattflaschen) [19:58:37] quiddity, did you try getting a new microphone? [19:59:00] (03PS2) 10Sbisson: Browser tests: Wait for TextField to be enabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285394 [20:00:02] matt_flaschen, My webcam mic works erratically, so I got a plain external mic-jack standalone mic. (just a $10 thing. So I could potentially upgrade it...) I'll try poking at the webcam mic again, this evening. [20:02:16] (03CR) 10Mattflaschen: [C: 032] Browser tests: Wait for TextField to be enabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285394 (owner: 10Sbisson) [20:05:02] 03Collab-Team-2016-Q4, 10Notifications: Exception in getDeepestCommonRoot() when viewing certain post-reply notifications - https://phabricator.wikimedia.org/T133731#2241155 (10Mattflaschen) [20:05:29] 03Collab-Team-2016-Q4, 10Flow, 10Notifications: Exception in getDeepestCommonRoot() when viewing certain post-reply notifications - https://phabricator.wikimedia.org/T133731#2240951 (10Mattflaschen) [20:18:47] 06Collaboration-Team-Interested, 10Notifications, 10Wikidata, 07Need-volunteer, and 2 others: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#1582085 (10JanZerebecki) With https://gerrit.wikimedia.org/r/#/c/285423/ retesting https:... [20:19:50] (03CR) 10Catrope: [C: 032] Fix deepest common root when first path is longer and later is a prefix [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285448 (https://phabricator.wikimedia.org/T133731) (owner: 10Mattflaschen) [20:20:01] Thanks matt_flaschen [20:20:12] Once that merges I'll cherry-pick it and put it up for SWAT [20:23:18] Thanks, RoanKattouw. [20:23:28] RoanKattouw, jmatazzoni__, stephanebisson, mlitn, etonkovidova, anything to flag at Scrum of Scrums? So far I have: External Store, Flow dumps (blocked on ops), Special:DisplayNotificationsConfiguration done, Moderation, bundling refactoring, MVC in-progress. [20:24:23] matt_flaschen: Cross-wiki notifs out of beta tentatively scheduled for the week of May 9th [20:24:29] (Provided blockers are resolved etc) [20:25:16] Thanks, added. [20:25:27] matt_flaschen: GlobalBlocking and TorBlock ? [20:28:09] etonkovidova, good idea. Matthias got a patch for GlobalBlocking merged yesterday as well, so we can mention it all together. [20:36:18] (03Merged) 10jenkins-bot: Fix deepest common root when first path is longer and later is a prefix [extensions/Flow] - 10https://gerrit.wikimedia.org/r/285448 (https://phabricator.wikimedia.org/T133731) (owner: 10Mattflaschen) [20:49:45] 10Thanks, 06Project-Admins, 10pywikibot-core, 15User-Luke081515: Create 'Pywikibot-Thanks' project - https://phabricator.wikimedia.org/T133665#2241351 (10darthbhyrava) Thanks @Luke081515! [20:54:20] 06Collaboration-Team-Interested, 10Thanks, 10pywikibot-core, 03Google-Summer-of-Code-2016: Weekly Reports for Pywikibot Support for Thanks - https://phabricator.wikimedia.org/T133667#2241356 (10darthbhyrava) [21:02:03] 06Collaboration-Team-Interested, 06Community-Tech, 06TCB-Team, 07Category, and 3 others: Improve diff compare screen - https://phabricator.wikimedia.org/T121469#2241376 (10Jdforrester-WMF) [21:03:48] RoanKattouw, I'm seeing an inconsistent state on my own cross-wiki notifications. [21:04:06] Hm? [21:04:15] MediaWiki.org shows "More messages from another wiki English Wikipedia". [21:04:28] Clicking Expand shows, "There are no notifications". [21:04:36] Actually going to English Wikipedia shows two messages. [21:04:59] Probably will be obsoleted by the server-side rewrite, don't know if it's a regression or not. [21:10:38] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 07WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2241391 (10Catrope) OK, thanks. I've amended the patch to remove the info icon. [21:11:04] Hmm, interesting [21:11:17] Can you see if there's anything weird going on with the CORS request from mw.org to enwiki? [21:11:26] It's possible that some of the patches I merged in wmf22 broke things [21:11:39] Or... no ugh I realize what happened [21:11:53] This is a wmf22 wiki's frontend talking to a wmf21 wiki's backend [21:12:01] An API parameter name was changed in wmf22 [21:12:04] So this goes badly [21:12:33] 06Collaboration-Team-Interested, 10Thanks, 10Pywikibot-Thanks, 10pywikibot-core, 03Google-Summer-of-Code-2016: Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#2241392 (10darthbhyrava) [21:17:08] (03CR) 10Mattflaschen: [C: 04-1] "Suggestion regarding int: inline." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285326 (https://phabricator.wikimedia.org/T117669) (owner: 10Catrope) [21:19:54] (03PS1) 10Catrope: Remove forced -p (progress) flag from phpcs.xml [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285523 [21:20:15] legoktm: ---^^ I wonder if we have that anywhere else [21:20:40] RoanKattouw: Loads of places. [21:20:52] Not in MW core it looks like [21:21:06] VE, OOUI both have it, I think. [21:21:07] RoanKattouw: can you add it to the command in composer.json? [21:21:22] -p -s should be in composer.json, not phpcs.xml [21:21:28] Oh, yeah, we normally have it but in composer.json. [21:21:43] (03PS2) 10Catrope: Remove forced -p (progress) flag from phpcs.xml [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285523 [21:21:49] Like so? [21:22:02] We also don't have -s forced anywhere [21:22:04] afaict [21:22:04] (03CR) 10Legoktm: [C: 032] Remove forced -p (progress) flag from phpcs.xml [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285523 (owner: 10Catrope) [21:22:09] yeah [21:22:28] -s prints the full sniff code which some people (me) find useful [21:23:18] RoanKattouw: https://github.com/wikimedia/oojs-ui/blob/master/composer.json#L71 https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/composer.json#L9 https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/composer.json#L9 [21:23:35] OK [21:23:37] I'll add that in Echo too then [21:23:38] legoktm: Something for your devDependencies script to do a run on? [21:23:48] 06Collaboration-Team-Interested, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, and 3 others: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2241408 (10darthbhyrava) [21:23:53] It's OK if -p -s is in composer.json so long as it's not in phpcs.xml, cause the latter breaks Atom [21:24:00] Probably [21:24:04] Fun. [21:24:11] (Really it's due to weird behavior in phpcs, but it's hard to convince them that it's a bug if -p is set) [21:25:40] legoktm: I've not done a mass let's-+2-everything-from-legoktm run in ages. :-) [21:25:54] heh [21:26:11] we're due for a mw-cs release, I'll see have time for it tonight [21:26:18] Fun. [21:38:48] (03Merged) 10jenkins-bot: Remove forced -p (progress) flag from phpcs.xml [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285523 (owner: 10Catrope) [21:44:33] RoanKattouw, sent you something for the wedding card. [21:44:46] Yup, got it [22:08:23] I'm out for a bit, IRL errands whilst businesses are open. bbl. [22:11:15] matt_flaschen: interesting, betalabs through Tor Browser blocks seems to blacklist some users from the same IP but not all of them ... [22:13:22] etonkovidova, hmm, I don't know that much about TorBlock, but I don't know why that would be unless one of the users is exempt from blocking. [22:14:26] matt_flaschen: yes, it's interesting - I am kind just look around :) nothing wrong with torblock stuff as far as I could see [22:18:51] matt_flaschen: well, it seems that I did not quite understand how tor browser works - all is fine :) [22:23:52] (03PS1) 10Catrope: Fix deepest common root when first path is longer and later is a prefix [extensions/Flow] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285537 (https://phabricator.wikimedia.org/T133731) [22:47:18] Be back in a couple minutes. [22:55:39] (03PS1) 10Catrope: Follow-up 57ee9759: add notnoforn=1 for b/c with wikis running old code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285545 [22:57:57] (03PS1) 10Catrope: Follow-up b10bd7003: allow object instead of array for b/c with wikis running old code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285546 [22:58:05] matt_flaschen: I found the cause of the issue you reported. If you could review+merge these two commits ---^^ then I can SWAT them [22:58:14] Yep [22:59:00] (Sorry, my timing isn't great re finding the cause 2 minutes before SWAT time, but I can work around that by running today's SWAT myself) [22:59:24] (03CR) 10Mattflaschen: [C: 032] Follow-up 57ee9759: add notnoforn=1 for b/c with wikis running old code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285545 (owner: 10Catrope) [23:00:45] Quis SWAT quadrigis in carcere? [23:01:11] (03CR) 10Catrope: [C: 032] Fix deepest common root when first path is longer and later is a prefix [extensions/Flow] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285537 (https://phabricator.wikimedia.org/T133731) (owner: 10Catrope) [23:02:19] (03CR) 10Mattflaschen: [C: 032] Follow-up b10bd7003: allow object instead of array for b/c with wikis running old code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285546 (owner: 10Catrope) [23:03:11] I'm going to take a break to watch the election returns, probably 5-ish Pacific? [23:06:20] (03Merged) 10jenkins-bot: Follow-up 57ee9759: add notnoforn=1 for b/c with wikis running old code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285545 (owner: 10Catrope) [23:09:00] Cool [23:09:07] Thanks for +2ing those two patches [23:09:18] (03PS1) 10Catrope: Follow-up 57ee9759: add notnoforn=1 for b/c with wikis running old code [extensions/Echo] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285549 [23:09:24] (03CR) 10Catrope: [C: 032] Follow-up 57ee9759: add notnoforn=1 for b/c with wikis running old code [extensions/Echo] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285549 (owner: 10Catrope) [23:12:16] (03Merged) 10jenkins-bot: Fix deepest common root when first path is longer and later is a prefix [extensions/Flow] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285537 (https://phabricator.wikimedia.org/T133731) (owner: 10Catrope) [23:12:19] (03Merged) 10jenkins-bot: Follow-up b10bd7003: allow object instead of array for b/c with wikis running old code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/285546 (owner: 10Catrope) [23:15:36] (03PS1) 10Catrope: Follow-up b10bd7003: allow object instead of array for b/c with wikis running old code [extensions/Echo] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285550 [23:15:43] (03CR) 10Catrope: [C: 032] Follow-up b10bd7003: allow object instead of array for b/c with wikis running old code [extensions/Echo] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285550 (owner: 10Catrope) [23:19:11] (03Merged) 10jenkins-bot: Follow-up 57ee9759: add notnoforn=1 for b/c with wikis running old code [extensions/Echo] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285549 (owner: 10Catrope) [23:21:05] 03Collab-Team-2016-Q4, 10MediaWiki-Vagrant, 10MediaWiki-extensions-TorBlock, 03Collab-Archive-2015-2016, 13Patch-For-Review: TorBlock role for MediaWiki-Vagrant - https://phabricator.wikimedia.org/T130876#2149311 (10Etonkovidova) Checked with enabled torblock role on vagrant - general regression testing... [23:25:43] (03Merged) 10jenkins-bot: Follow-up b10bd7003: allow object instead of array for b/c with wikis running old code [extensions/Echo] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285550 (owner: 10Catrope) [23:31:24] matt_flaschen: Confirmed that the "there are no notifications bug" is now fixed for me on mw.org [23:31:26] Thanks for finding that [23:31:56] No problem. [23:32:04] I had forgotten that we need to be super careful about making breaking API changes that affect cross-wiki notifications [23:33:05] Yeah, me too. [23:33:10] RoanKattouw, you also deployed the topmost fix, right? [23:33:13] Yes [23:33:44] Okay, I pinged wmat. [23:34:08] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-05-01_(1.27.0-wmf.23): Exception in getDeepestCommonRoot() when viewing certain post-reply notifications - https://phabricator.wikimedia.org/T133731#2241724 (10Catrope) This was backported and deployed just now. [23:36:36] Hmm I just realized I forgot something in my beta invitation patch [23:36:41] Only showing it if the message is translated [23:37:01] Does anyone know if there's a way to find out if a message is translated? [23:37:29] I remember we talked about it when doing the Echo cross-wiki names, but I think it was dropped. [23:37:32] I guess the hacky way to do it would be if ( $lang !== 'en' && $msg->inLanguage( 'en' )->text() === $msg->text() ), but that would break for en-gb [23:40:02] RoanKattouw, haven't tested, but it looks like it's just $lang->getMessage( $key ) [23:40:10] I.E. check the Language object directly rather than the normal path. [23:40:22] Non-null means it's in that language. [23:40:41] MessageCache line 869 ("Check the CDB cache") [23:43:00] That doesn't seem to work in prod [23:43:05] > echo $wgLang->getCode() [23:43:05] ca [23:43:05] > echo $wgLang->getMessage($key) [23:43:05] Provide feedback. [$2 $1] [23:43:17] The way that the i18n cache works in prod, I'm not sure if it's possible to tell [23:48:11] Meh, I'll just do the "equals English" hack, and then we won't show the invite to the 3 people with en-gb