[00:03:16] 10Flow: Enable specific talk pages to not use Flow - https://phabricator.wikimedia.org/T132955#2221379 (10Yaron_Koren) For what it's worth, I figured out a way to do this: create the page in the main namespace, then move it to to the talk namespace. Whether that's a good solution is another question. [00:04:59] 03Collab-Team-2016-Q4, 10Flow: [betalabs-Regression] 'Mark as resolve' is affected by VE errors - https://phabricator.wikimedia.org/T132646#2221400 (10Catrope) [00:06:08] 03Collab-Team-2016-Q4, 10Notifications: [betalabs] Templates displayed as links in Flow-topic-resolved notifications - https://phabricator.wikimedia.org/T132226#2221410 (10Catrope) [00:06:24] 03Collab-Team-2016-Q4, 10Notifications: [betalabs] Templates displayed as links in Flow-topic-resolved notifications - https://phabricator.wikimedia.org/T132226#2221412 (10Catrope) [00:06:26] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22), 07user-notice: Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2221413 (10Catrope) [00:17:30] 03Collab-Team-2016-Q4, 15User-JAufrecht: Refine Collab 2016Q4 Phlogiston - https://phabricator.wikimedia.org/T132983#2221438 (10JAufrecht) [00:19:48] 03Collab-Team-2016-Q4, 15User-JAufrecht: Refine Collab 2016Q4 Phlogiston - https://phabricator.wikimedia.org/T132983#2221440 (10JAufrecht) 05Open>03Resolved there are some bugs in the report as set up, but the categories seem to be reading okay. Look at it again next week when there is more data, especial... [00:20:01] 03Collab-Team-2016-Q4, 10Phlogiston↝Burnup-support, 15User-JAufrecht: Refine Collab 2016Q4 Phlogiston - https://phabricator.wikimedia.org/T132983#2221442 (10JAufrecht) [00:20:16] 03Collab-Team-2016-Q4, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Refine Collab 2016Q4 Phlogiston - https://phabricator.wikimedia.org/T132983#2216141 (10JAufrecht) [00:31:11] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Cross-wiki notifications on mobile show separate bundles for alerts and messages, should be one bundle - https://phabricator.wikimedia.org/T131683#2221472 (10jmatazzoni) 05Open>03Resolved Noticing some hinky stuff in the screenshots with dates n... [00:44:22] 10Flow: All moderated posts newer than showPostId should be shown - https://phabricator.wikimedia.org/T133133#2221477 (10Mattflaschen) [00:45:13] 03Collab-Team-2016-Q4, 10Notifications, 07Mobile: Abbreviated timestamps not shown in notifications on mobile - https://phabricator.wikimedia.org/T133134#2221493 (10Catrope) [00:49:10] 03Collab-Team-2016-Q4, 10Notifications, 10Collaboration-Community-Engagement, 07Epic, 07Tracking: Enable cross-wiki notifications by default - https://phabricator.wikimedia.org/T130655#2221508 (10jmatazzoni) [00:49:11] 06Collaboration-Team-Interested, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2221510 (10jmatazzoni) [00:49:12] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Add tooltips for "X" and "..." icons - https://phabricator.wikimedia.org/T130831#2221507 (10jmatazzoni) 05Open>03Resolved [00:50:19] 03Collab-Team-2016-Q4, 10Notifications, 07Mobile: Abbreviated timestamps not shown in notifications on mobile - https://phabricator.wikimedia.org/T133134#2221512 (10Catrope) a:05Mooeypoo>03Catrope [00:53:10] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Make 'your page' bold in Notifications for bundled edits from User talk wikitext pages - https://phabricator.wikimedia.org/T131476#2221520 (10jmatazzoni) 05Open>03Resolved [00:53:11] (03PS1) 10Catrope: Apply momentjs hack for short relative times on mobile too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284380 (https://phabricator.wikimedia.org/T133134) [00:54:44] 03Collab-Team-2016-Q4, 10Flow, 13Patch-For-Review: [betalabs] 'Update summary' on blank summary will create an empty view-topic-summary page - https://phabricator.wikimedia.org/T132531#2221525 (10jmatazzoni) 05Open>03Resolved [01:07:05] (03PS1) 10Mattflaschen: Link to topmost unread post, but highlight all the unread posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284383 (https://phabricator.wikimedia.org/T133133) [01:07:36] RoanKattouw, that ended up pretty http://xkcd.com/1425/ , but it works. [01:08:32] lol [01:09:03] RoanKattouw, the common root part is just to avoid loading the whole topic. Hopefully, that optimization helps (did not benchmark it). Other than that, it's just pre-order depth first search. [01:09:38] Whoops, I tagged the wrong one. [01:10:06] 10Flow: All moderated posts newer than showPostId should be shown - https://phabricator.wikimedia.org/T133133#2221559 (10Mattflaschen) Sorry, that patch does not fix this bug. [01:11:16] I first tried to figure it out by just using some sort of sort, given the UIDs (then the comparator of the sort could check "are we siblings", if not, etc.), but I didn't figure that all the way out, so I tried this approach. [01:11:55] (03PS2) 10Mattflaschen: Link to topmost unread post, but highlight all the unread posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284383 (https://phabricator.wikimedia.org/T126264) [01:12:43] This looks pretty sensible [01:12:49] The only thing I'm worried about is the highlighting [01:13:02] Or does showPostId do that? [01:13:22] There's some sort of magic that causes both the post and all newer posts to get a blue bar highlight thingy [01:13:45] If that works based on showPostId, you're fine, but if it works based on the anchor, you probably broke something [01:14:42] Oh nm, found your changes to flow-board.js [01:15:58] (03CR) 10jenkins-bot: [V: 04-1] Link to topmost unread post, but highlight all the unread posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284383 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [01:16:24] RoanKattouw, yep. There is a pre-existing issue that this doesn't handle moderated posts except the first chronologically, but I tested the blue bar part. [01:16:32] OK cool [01:18:02] (03CR) 10Catrope: [C: 04-1] "Cause of jsduck failure identified inline, looks good otherwise." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284383 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [01:18:23] (03PS3) 10Mattflaschen: Link to topmost unread post, but highlight all the unread posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284383 (https://phabricator.wikimedia.org/T126264) [01:19:06] (03CR) 10Catrope: [C: 032] Link to topmost unread post, but highlight all the unread posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284383 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [01:20:00] matt_flaschen: Thanks for fixing this, this is great [01:20:14] I'd been hemming and hawing on this one for a while, because it seemed hard and I wasn't sure if it was worth the effort [01:20:38] So when I asked you if you had any brilliant ideas, I was expecting a "no" to justify me in burying this task in the backlog somewhere :P [01:20:59] RoanKattouw, no problem. Now I have a fresh answer for the last time I used explicitly CS-y things. :) [01:21:05] haha [01:21:08] That's always fun [01:21:12] I liked that about VE too [01:21:50] Well, one time they asked me to link to the post that was closest to the top of the page, so I did a pre-order depth first search. [01:23:10] RoanKattouw, what's one from VE? [01:23:16] At the Jerusalem hackathon there was this problem that I insisted was simple and Ed and Coren insisted was difficult, so I sat down during dinner after the event on Sunday and wrote it [01:23:55] Now I realize that that's probably because I wrote a bunch of the browser bug workarounds in VE, so I'm comfortable writing generic functions with complex loops that do DOM manipulation [01:24:27] (03CR) 10jenkins-bot: [V: 04-1] Link to topmost unread post, but highlight all the unread posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284383 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [01:24:54] matt_flaschen: Probably everything to do with the transaction system and data model [01:25:25] Also I think the model->DOM converter is recursive but the DOM->model converter is iterative, or maybe the other way around [01:25:39] Whitespace buffering is especially hairy [01:26:20] None of these are clear-cut "use this kind of tree operation" CS things necessarily, but they're at that kind of level of abstraction [01:26:48] Most of the explicit CS stuff there is stacks I think [01:27:10] RoanKattouw, yeah, I think the intense data-structure stuff (which VE has a lot of) definitely counts. [01:27:16] There are some functions that start with a stack of one level, then run while(stack.length) and grow+shrink the stack until done [01:29:16] Yeah, agreed [01:29:39] Also, you have to know basic big-O stuff, because you want to avoid O(n^2) if n is the size of [[Barack Obama]] [01:30:27] Not much formal stuff but a lot of glancing at things to decide if they're O(n) or not [01:32:44] I think my favorite part was sitting down with David Chan (also somebody who likes explicit CS things) and rewrote the "get a model offset from a DOM position" function: https://github.com/wikimedia/VisualEditor/blob/master/src/ce/ve.ce.js#L163 [01:33:17] It was the kind of thing where we had to come up with our own rules and invariants and stuff [01:42:33] 03Collab-Team-2016-Q4, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review: Enable Flow as a Beta feature on French Wikisource - https://phabricator.wikimedia.org/T132914#2221591 (10jayvdb) [01:42:35] 06Collaboration-Team-Interested, 10Flow, 10Wikimedia-Site-requests, 07Tracking: Enable the Flow personal talk opt-in Beta Feature on some wikis - https://phabricator.wikimedia.org/T117990#2221590 (10jayvdb) [01:44:57] (03CR) 10Mattflaschen: [C: 032] Apply momentjs hack for short relative times on mobile too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284380 (https://phabricator.wikimedia.org/T133134) (owner: 10Catrope) [01:50:53] (03Merged) 10jenkins-bot: Apply momentjs hack for short relative times on mobile too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284380 (https://phabricator.wikimedia.org/T133134) (owner: 10Catrope) [01:52:31] 06Collaboration-Team-Interested, 10Flow, 10Wikimedia-Site-requests: Enable Flow in Odia (Oriya) Wikipedia - https://phabricator.wikimedia.org/T110846#1587972 (10jayvdb) >>! In T110846#2139462, @Quiddity wrote: > Also, it looks like all the interface messages still need to be translated at https://translatewi... [02:01:19] 03Collab-Team-2016-Q4, 10Notifications, 07Documentation, 13Patch-For-Review: Display documentation for notification types configuration on Wikimedia - https://phabricator.wikimedia.org/T132127#2221603 (10Mattflaschen) > updates to https://www.mediawiki.org/wiki/Extension:Echo#Configuration [Done](https://... [02:49:04] matt_flaschen: Can I pawn off the frwikisource Flow beta enable SWAT on you? I was gonna do it on Monday at 4pm but I have a meeting then [03:03:37] 03Collab-Team-2016-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2221640 (10Shizhao) [03:03:39] 10Flow, 03Collab-Archive-2015-2016: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#2221641 (10Shizhao) [06:32:04] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2221791 (10Pginer-WMF) >>! In T129366#2216199, @jmatazzoni wrote: > @Pginer-WMF, two questions come to mind about the items in the lef... [07:15:16] 10Flow: Enable specific talk pages to not use Flow - https://phabricator.wikimedia.org/T132955#2221815 (10Trizek-WMF) >>! In T132955#2221379, @Yaron_Koren wrote: > For what it's worth, I figured out a way to do this: create the page in the main namespace, then move it to to the talk namespace. Whether that's a g... [08:05:37] 06Collaboration-Team-Interested, 10Flow, 10Wikimedia-Site-requests: Enable Flow in Odia (Oriya) Wikipedia - https://phabricator.wikimedia.org/T110846#2221861 (10Trizek-WMF) There is no rule, but, based on experiences, we prefer to strongly suggest to have the translations done before the Beta feature is depl... [08:22:35] 06Collaboration-Team-Interested, 10Flow, 10Wikimedia-Site-requests: Enable Flow in Odia (Oriya) Wikipedia - https://phabricator.wikimedia.org/T110846#2221874 (10jayvdb) Thanks @Trizek-WMF , my interest was due to Indonesian Wikipedia [[https://id.wikipedia.org/wiki/Wikipedia:Warung_Kopi_(Teknis)#Mencoba_Flow... [09:30:24] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2222140 (10Trizek-WMF) Asked some specific communities about translations, especially Ch... [09:32:15] 06Collaboration-Team-Interested, 10Notifications, 10MediaWiki-extensions-ContentTranslation, 07Design, 07WorkType-NewFunctionality: Notify inactive translators that new suggestions are available - https://phabricator.wikimedia.org/T113586#2222163 (10Amire80) [09:32:18] 06Collaboration-Team-Interested, 10Notifications, 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: Special:ContentTranslation three-dots menu overflows the Notifications fly-out - https://phabricator.wikimedia.org/T124873#2222164 (10Amire80) [10:43:31] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4: List wikis and pages with unread notifications in the Notification Page left nav - https://phabricator.wikimedia.org/T129366#2222589 (10Pginer-WMF) >>! In T129366#2221791, @Pginer-WMF wrote: > User (talk) pages are also presented on top of other pages in the... [10:49:42] 03Collab-Team-2016-Q4: [betalabs] flow-topic-resolved notifications should have a summary excerpt - https://phabricator.wikimedia.org/T133088#2222602 (10SBisson) >>! In T133088#2221569, @jmatazzoni wrote: > Would there, for instance, ever be a case where a summary would pre-exist the Resolution (so that there wa... [12:27:04] (03CR) 10Sbisson: [C: 032] Use plaintextParams() for snippets and sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284119 (https://phabricator.wikimedia.org/T132872) (owner: 10Catrope) [12:37:08] (03Merged) 10jenkins-bot: Use plaintextParams() for snippets and sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284119 (https://phabricator.wikimedia.org/T132872) (owner: 10Catrope) [12:53:07] (03PS1) 10Sbisson: Use the right message for flow-new-topic on user-talk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284452 (https://phabricator.wikimedia.org/T133100) [12:53:37] 03Collab-Team-2016-Q4, 13Patch-For-Review: [betalabs] Bundled flowusertalk-new-topic notifications refer to a user talk page with a full title. - https://phabricator.wikimedia.org/T133100#2223073 (10SBisson) p:05Triage>03Normal a:03SBisson [14:54:30] 03Collab-Team-2016-Q4, 10Notifications, 07Crosswiki: Change "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2223704 (10Trizek-WMF) [[https://www.mediawiki.org/wiki/Topic:T2f5c9lwpd8ln01k | That feedback]] may... [14:56:45] 06Collaboration-Team-Interested, 10Flow, 10Wikimedia-Site-requests: Enable Flow in Odia (Oriya) Wikipedia - https://phabricator.wikimedia.org/T110846#2223715 (10Trizek-WMF) @jayvdb, I've left a message on id.wikipedia to follow up. Let's discuss there, or on a separate task! :) [14:58:39] 03Collab-Team-2016-Q4, 10Notifications, 07Crosswiki: Change "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2115268 (10Braveheart) Seems to be related to Internet Explorer and its privacy settings, since the s... [15:18:38] 06Collaboration-Team-Interested, 10MediaWiki-General-or-Unknown, 10MobileFrontend, 03Reading-Web-Sprint-71-m: Rename watchlist icon in main menu to not collide with OOJS - https://phabricator.wikimedia.org/T133156#2223776 (10Jhernandez) [15:22:40] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement: Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2223814 (10Trizek-WMF) @Catrope and @jmatazzoni, do we need to do something more than that: https://www.mediawiki.org/w/index.php?tit... [16:08:23] 10Flow: Enable specific talk pages to not use Flow - https://phabricator.wikimedia.org/T132955#2224010 (10Yaron_Koren) Ah, sorry, I missed that one. That's great to hear! [16:58:22] 03Collab-Team-2016-Q4, 10Phlogiston: Collab recently closed Phlogiston report has 1000s of invalid items - https://phabricator.wikimedia.org/T133172#2224219 (10JAufrecht) [17:00:12] 03Collab-Team-2016-Q4, 10Phlogiston (Burnup-Support): Collab Phlogiston velocity chart doesn't match recently closed list - https://phabricator.wikimedia.org/T133173#2224232 (10JAufrecht) [17:04:42] (03PS9) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [17:05:15] (03CR) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [17:33:45] RoanKattouw, (re the frwikisource), sure, do you have a preference between morning and evening SWATs? [17:34:41] 03Collab-Team-2016-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Write email formatter that uses presentation models - https://phabricator.wikimedia.org/T121067#2224354 (10Catrope) [17:34:43] 06Collaboration-Team-Interested, 10Flow, 10Notifications: Email notifications sent both by Echo for core edits and by Flow for replys/mentions/etc should include as much context as is feasible so i can just read my email and not visit the website. - https://phabricator.wikimedia.org/T90067#2224353 (10Catrope) [17:37:13] matt_flaschen: No preference, I'm unavailable for both anyway [17:37:30] I think Trizek|away may prefer the morning one [17:37:42] I had told them it was scheduled for the evening one, but it's a week away so we can change it easily [17:37:46] So whatever works for you [17:39:19] (03CR) 10Catrope: [C: 032] Use the right message for flow-new-topic on user-talk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284452 (https://phabricator.wikimedia.org/T133100) (owner: 10Sbisson) [17:44:09] 06Collaboration-Team-Interested, 10Flow, 10Wikimedia-Site-requests: Enable Flow in Odia (Oriya) Wikipedia - https://phabricator.wikimedia.org/T110846#2224395 (10Quiddity) >>! In T110846#2221594, @jayvdb wrote: > I note that it was enabled on Catalan Wikipedia in T120829, even for user talk opt-in, but only h... [17:47:31] (03Merged) 10jenkins-bot: Use the right message for flow-new-topic on user-talk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284452 (https://phabricator.wikimedia.org/T133100) (owner: 10Sbisson) [17:48:48] RoanKattouw, sounds good. I'll do morning. [17:52:04] 03Collab-Team-2016-Q4, 10Notifications, 07Crosswiki: Change "Error Access to the remote domain was denied." (echo-api-failure-cross-wiki) message and use errorObj? - https://phabricator.wikimedia.org/T129764#2224425 (10Catrope) >>! In T129764#2223719, @Braveheart wrote: > Seems to be related to Internet Expl... [18:13:27] 03Collab-Team-2016-Q4, 10Flow, 10Notifications: Email notifications sent both by Echo for core edits and by Flow for replys/mentions/etc should include as much context as is feasible so i can just read my email and not visit the website. - https://phabricator.wikimedia.org/T90067#2224524 (10jmatazzoni) [18:34:02] (03CR) 10Catrope: [C: 032] Link to topmost unread post, but highlight all the unread posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284383 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [18:46:58] (03Merged) 10jenkins-bot: Link to topmost unread post, but highlight all the unread posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284383 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [18:54:38] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2224819 (10Qgil) [18:54:46] (03PS1) 10Catrope: Use 'csrf' token instead of deprecated 'edit' token [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284505 [19:08:07] (03CR) 10Sbisson: [C: 032] Use 'csrf' token instead of deprecated 'edit' token [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284505 (owner: 10Catrope) [19:08:25] RoanKattouw: ^ this is fixed for Echo in the big front-end patch [19:09:24] Nice [19:17:05] (03Merged) 10jenkins-bot: Use 'csrf' token instead of deprecated 'edit' token [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284505 (owner: 10Catrope) [19:22:47] lunching [19:24:36] 06Collaboration-Team-Interested, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016): Draft and review a public announcement concerning Flow support - https://phabricator.wikimedia.org/T130730#2144787 (10Mattflaschen) We should discuss this further. I still have some issues with the ne... [20:27:39] 10Notifications, 07I18n, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): The notifications drop down menu displays numbers using the wrong numeral system on Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T123845#1939264 (10Quiddity) Side-note: There's some details about this ove... [20:35:20] (03PS1) 10Mattflaschen: Topmost: Minor follow-up to add fallback for missing topmost post ID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284524 (https://phabricator.wikimedia.org/T126264) [20:39:47] 03Collab-Team-2016-Q4: [betalabs-Regression] 'Browse topics' "[FLOW] Rendered topic not found when attempting to scroll" - https://phabricator.wikimedia.org/T133213#2225264 (10Etonkovidova) [20:47:19] 06Collaboration-Team-Interested, 10Flow: Give users the option to delete their own messages in Flow - https://phabricator.wikimedia.org/T130646#2225308 (10Catrope) 05Open>03declined [21:04:08] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2225404 (10jmatazzoni) [21:06:51] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2225419 (10jmatazzoni) a:03Pginer-WMF [21:07:17] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2225404 (10jmatazzoni) a:05Pginer-WMF>03None [21:07:22] 03Collab-Team-2016-Q4: [betalabs-Regression] 'Browse topics' "[FLOW] Rendered topic not found when attempting to scroll" - https://phabricator.wikimedia.org/T133213#2225422 (10Etonkovidova) [21:07:59] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2225404 (10jmatazzoni) a:03jmatazzoni [21:08:03] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2225404 (10jmatazzoni) @Mattflaschen is working on a special page that lists all the notifications and their categories. This will be very helpful for this task; Matt p... [21:14:17] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2225446 (10jmatazzoni) [21:14:19] 03Collab-Team-2016-Q4, 10Notifications: Allow disabling a notification category from within the notifications popup - https://phabricator.wikimedia.org/T132977#2225445 (10jmatazzoni) [21:15:35] matt_flaschen: For https://phabricator.wikimedia.org/T126264 - so, a user should be always re-directed to the top-most reply even if that reply was posted earlier than other replies? [21:15:50] 03Collab-Team-2016-Q4, 10Phlogiston, 15User-JAufrecht: Collab recently closed Phlogiston report has 1000s of invalid items - https://phabricator.wikimedia.org/T133172#2225448 (10JAufrecht) [21:15:55] 03Collab-Team-2016-Q4, 10Notifications: Allow disabling a notification category from within the notifications popup - https://phabricator.wikimedia.org/T132977#2215972 (10jmatazzoni) a:03Pginer-WMF [21:15:57] 03Collab-Team-2016-Q4, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Collab Phlogiston velocity chart doesn't match recently closed list - https://phabricator.wikimedia.org/T133173#2225450 (10JAufrecht) [21:16:05] matt_flaschen: just to double-check if I understood correctly ... [21:16:33] 03Collab-Team-2016-Q4, 10Notifications: Allow disabling a notification category from within the notifications popup - https://phabricator.wikimedia.org/T132977#2225453 (10jmatazzoni) Assigning this to Pau as a first step, so he can define menu options/icon. [21:17:15] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2225457 (10jmatazzoni) [21:17:17] 06Collaboration-Team-Interested, 10Flow: User don't receive email notifications concerning their Flow talk page when "Talk page message" is on, but "Flow" is off - https://phabricator.wikimedia.org/T132426#2225456 (10jmatazzoni) [21:43:52] matt_flaschen: I still see redirection to the earliest reply, not to the top-most :( in https://phabricator.wikimedia.org/T126264 [21:46:44] etonkovidova, did you refresh the page where you saw the notification? [21:47:30] Refreshing the topic page once you already have the old link won't work. [21:47:43] matt_flaschen: hmm... I saw a notifcation came - and I click the notifcation. It should point to the top-most not to the earliest? [21:48:06] etonkovidova, correct, it should be topmost. Let's do a screen share. [21:48:12] Do you have a moment now? [21:48:27] matt_flaschen: I have a meeting with Roan at 3:00 [21:48:48] etonkovidova, are you testing on Beta or locally? [21:49:12] matt_flaschen: beta [21:49:33] etonkovidova, which Beta? [21:49:51] matt_flaschen: regular betalabs [21:50:14] enwiki beta, testwiki beta? Just asking so I can test in the same place. [21:50:41] matt_flaschen: sorry, it's enwiki [21:50:56] etonkovidova, okay, thanks. I'll see if it's deployed there and test. [21:51:22] matt_flaschen: what I did: first reply at the top, second reply at the end; then, vice versa [21:52:08] matt_flaschen: also tried with three replies - one of them in the middle; I have a sneaking suspicion that it depends on the exact nesting... [21:52:35] etonkovidova, can you link me to the example that failed? [21:53:11] matt_flaschen: argh - should've taken a notice. Hold on [21:56:24] matt_flaschen: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:Ssdtiorv8kz5p3iw&topic_showPostId=t2hb83p76inquhd7&fromnotif=1#flow-post-t2hb83p76inquhd7 [21:57:27] matt_flaschen: if you can see it - not sure; First reply at the end at 2:55 and the second is at the top 2:56 - the time is typed in replies [21:58:14] etonkovidova, it just failed for me too. [21:58:44] matt_flaschen: argh :( [21:58:53] etonkovidova, just before that it worked. [21:59:36] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:T2d0n09ma39wwgew&topic_showPostId=t2hb52nycqv94l7v&fromnotif=1#flow-post-t2hb5m4piv8b7b4o , http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:T2d0n09ma39wwgew&topic_showPostId=t2hb740icu1wnxug&fromnotif=1#flow-post-t2hb740icu1wnxug , and http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:T2d0n09ma39wwgew&topic_showPostId=t2hba99re93icsiz& [21:59:37] fromnotif=1#flow-post-t2hba99re93icsiz [21:59:44] matt_flaschen: could it be just because of some specific placement inside nested replies? I think that I had successful cases too [22:00:15] 06Collaboration-Team-Interested, 10Flow: scroll or right clicking on flow-newtopic-container triggers click - https://phabricator.wikimedia.org/T131332#2225587 (10Catrope) 05Open>03declined This doesn't seem to be easily fixable, because we listen to the `focusin` event, which is fired any time the focus (... [22:00:15] etonkovidova, yes, possibly. [22:00:34] matt_flaschen: ok - let me to dig it more ... [22:13:17] I isolated it in the shell. Still figuring out cause. [22:23:57] Never mind, I was testing it wrong in the shell. [22:32:23] matt_flaschen: great! [22:54:05] etonkovidova, RoanKattouw, figured it out. It wasn't including the current event (it didn't earlier either, but the chronologically earliest was never the current event so no one noticed). [22:58:47] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2225746 (10jmatazzoni) [23:00:16] Hah [23:05:06] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2225781 (10jmatazzoni) I've updated the ticket description to reflect our discussions and am moving this back t... [23:06:08] 06Collaboration-Team-Interested, 10Notifications: Echo notification table indexes don't support the new feature changes - https://phabricator.wikimedia.org/T72363#750525 (10Catrope) #2 is not done, but could be a good idea. [23:07:53] 03Collab-Team-2016-Q4: [betalabs] flow-topic-resolved notifications should have a summary excerpt - https://phabricator.wikimedia.org/T133088#2225790 (10jmatazzoni) Stephane has clarified, > a notification should be sent every time. Thank you. I've updated the ticket description for T125654 to reflect that. [23:08:41] (03PS1) 10Mattflaschen: Fix an issue where latest post wasn't considered as potentially topmost [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284611 (https://phabricator.wikimedia.org/T126264) [23:09:17] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#1993603 (10jmatazzoni) [23:09:19] 03Collab-Team-2016-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): [betalabs] Flow-topic-resolved notifications display topic id in a secondary link - https://phabricator.wikimedia.org/T132229#2225794 (10jmatazzoni) 05Open>03Resolved [23:10:05] ^ etonkovidova, when that's merged, it should fix the issue you found. It should only affect cases where the topmost was also the most recent. [23:10:25] matt_flaschen: thanks :) [23:11:01] RoanKattouw, yeah, it's pretty confusing that getBundledEvents does not include the current, and a little confusing that the "base" of the bundle is the most recent. [23:12:32] I'm assuming that the new bundle system changes a bunch of that so I decided against adding a new method or includeCurrent (which there already is for count). [23:25:28] That's right, it changes a lot [23:30:47] There won't be a bundle base any more [23:30:58] The concept of a base is incompatible with needing to be able to moderate any event [23:31:34] (03CR) 10Catrope: [C: 032] Fix an issue where latest post wasn't considered as potentially topmost [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284611 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [23:32:24] 06Collaboration-Team-Interested, 10Notifications: Couple page link notification to watchlist - https://phabricator.wikimedia.org/T70060#728650 (10Catrope) {T132980} is related to this, but is not the same. [23:40:00] (03Merged) 10jenkins-bot: Fix an issue where latest post wasn't considered as potentially topmost [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284611 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [23:56:13] (03PS5) 10Mattflaschen: BREAKING CHANGE: Change $wgEchoDefaultNotificationTypes to be logical [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284124 (https://phabricator.wikimedia.org/T132820) [23:56:36] (03PS3) 10Mattflaschen: Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127)