[00:01:23] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2216363 (10jmatazzoni) That looks good to me. Thanks Matt. [00:05:01] (03PS1) 10Mattflaschen: Fix quotes for "mark as resolved" on history and IRC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284109 [00:11:05] 03Collab-Team-2016-Q4: [betalabs] Templates displayed as links in Flow-topic-resolved notifications - https://phabricator.wikimedia.org/T132226#2216394 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [00:47:00] (03PS16) 10Sbisson: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [00:47:19] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [00:51:20] (03PS17) 10Sbisson: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [00:56:09] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [01:01:01] 06Collaboration-Team-Interested: [betalabs] Add bundling for page-linked notifications in case one-to-many - https://phabricator.wikimedia.org/T132824#2216524 (10jmatazzoni) [01:07:58] 03Collab-Team-2016-Q4, 10Notifications: Accessibility of diff pages from Notifications - https://phabricator.wikimedia.org/T131631#2173209 (10jmatazzoni) Note: these View Changes links are the third links for their respective notifications. They should be placed in the dotdotdot menu. [01:13:16] (03CR) 10Catrope: [C: 032] Fix quotes for "mark as resolved" on history and IRC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284109 (owner: 10Mattflaschen) [01:15:28] (03PS1) 10Catrope: Use plaintextParams() for snippets and sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284119 (https://phabricator.wikimedia.org/T132872) [01:17:01] 06Collaboration-Team-Interested, 10Notifications: "Mute" button on Echo items that you don't want to hear about anymore (was: Allow excluding pages from the link notifications) - https://phabricator.wikimedia.org/T46787#479453 (10Catrope) We discussed this, and one way we could solve this in the short term is... [01:19:09] (03CR) 10jenkins-bot: [V: 04-1] Use plaintextParams() for snippets and sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284119 (https://phabricator.wikimedia.org/T132872) (owner: 10Catrope) [01:20:55] (03Merged) 10jenkins-bot: Fix quotes for "mark as resolved" on history and IRC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284109 (owner: 10Mattflaschen) [01:22:21] (03CR) 10Catrope: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284119 (https://phabricator.wikimedia.org/T132872) (owner: 10Catrope) [01:23:16] (03CR) 10Catrope: [C: 032] Add tooltips for 'mark as read' and 'more options' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283746 (https://phabricator.wikimedia.org/T130831) (owner: 10Sbisson) [01:24:36] (03CR) 10Catrope: [C: 04-1] "We conventionally bold "your talk page", you only bolded "talk page"." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283692 (https://phabricator.wikimedia.org/T131476) (owner: 10Sbisson) [01:31:37] (03CR) 10Catrope: [C: 04-1] "This fixes mobile but breaks desktop. On desktop, the "More notifications from 2 wikis" bundle now appears in both the alerts and the mess" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283699 (https://phabricator.wikimedia.org/T131683) (owner: 10Sbisson) [01:33:31] (03Merged) 10jenkins-bot: Add tooltips for 'mark as read' and 'more options' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283746 (https://phabricator.wikimedia.org/T130831) (owner: 10Sbisson) [01:50:07] (03CR) 10Catrope: [C: 04-1] [WIP] Moderate notifications (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [02:05:55] matt_flaschen: Speaking of browser tests, they started failing for some reason [02:06:14] https://gerrit.wikimedia.org/r/#/c/284119/ is V-1ed over that, but the same failure occured in the post-merge build for https://gerrit.wikimedia.org/r/#/c/283746/ [02:08:28] (03PS2) 10Catrope: Use plaintextParams() for snippets and sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284119 (https://phabricator.wikimedia.org/T132872) [02:11:53] (03CR) 10jenkins-bot: [V: 04-1] Use plaintextParams() for snippets and sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284119 (https://phabricator.wikimedia.org/T132872) (owner: 10Catrope) [02:21:28] (03CR) 10Catrope: [WIP] Moderate notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [02:26:53] 03Collab-Team-2016-Q4, 10MediaWiki-extensions-GuidedTour: GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't) - https://phabricator.wikimedia.org/T132989#2216668 (10Mattflaschen) Is there no way to depend on skins in Jenkins config? Yo... [02:29:41] 03Collab-Team-2016-Q4, 10Notifications: Allow disabling a notification category from within the notifications popup - https://phabricator.wikimedia.org/T132977#2215972 (10Mattflaschen) >>! In T132977#2216351, @jmatazzoni wrote: > Before we build we need to answer some questions about this feature: > > - 1)... [02:32:42] RoanKattouw, the same failure happened earlier on my patch, and went away on retry. [02:32:45] So it must be flaky. [02:32:54] Hmm OK [02:33:02] I rechecked and it happened again [02:33:09] But maybe I should recheck it again again [02:33:17] Good news is, this doesn't block +2 AFAIK [02:37:52] (03CR) 10Catrope: [WIP] Moderate notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [02:38:00] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#1993170 (10Verdy_p) Have a look on bugs I first submitted by replying to the announcemen... [02:43:04] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2216683 (10Verdy_p) For a couple of entries, I added some corrections in the "/qqq" doc... [02:47:17] (03CR) 10Catrope: "Follow-up review comments inline. For the indexes, you need to go through the schema change process. The index additions work just like th" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [02:48:19] (03CR) 10Catrope: "Re removing bundle_base: I just realized that would have to be in a separate change anyway for backwards compatibility (we can't atomicall" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [03:01:41] (03PS1) 10Mattflaschen: WIP: BREAKING CHANGE: Change $wgEchoDefaultNotificationTypes to be logical [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284124 (https://phabricator.wikimedia.org/T132820) [03:03:26] (03PS2) 10Mattflaschen: WIP: BREAKING CHANGE: Change $wgEchoDefaultNotificationTypes to be logical [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284124 (https://phabricator.wikimedia.org/T132820) [03:06:38] (03CR) 10jenkins-bot: [V: 04-1] WIP: BREAKING CHANGE: Change $wgEchoDefaultNotificationTypes to be logical [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284124 (https://phabricator.wikimedia.org/T132820) (owner: 10Mattflaschen) [03:08:11] (03PS1) 10Mattflaschen: Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127) [03:13:19] (03CR) 10jenkins-bot: [V: 04-1] Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127) (owner: 10Mattflaschen) [03:14:14] (03PS3) 10Mattflaschen: WIP: BREAKING CHANGE: Change $wgEchoDefaultNotificationTypes to be logical [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284124 (https://phabricator.wikimedia.org/T132820) [03:16:26] I dislike the "Unnecessary empty comment found" rule. It makes it impossible to have a comment block (visible as a single block) with multiple paragraphs. [03:17:01] Huh? [03:17:09] (03PS4) 10Mattflaschen: WIP: BREAKING CHANGE: Change $wgEchoDefaultNotificationTypes to be logical [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284124 (https://phabricator.wikimedia.org/T132820) [03:17:10] Oh, is this for // -style comments? [03:17:26] (03PS2) 10Mattflaschen: Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127) [03:17:27] Oh I see [03:17:39] We *can* disable that rule, but I expect to be yelled at and told to use /* ... */ instead [03:18:23] It seems to be conventional to use // exclusively in extension setup files and MW settings documentation but I don't know why [03:18:32] I just know That's What You Do [03:19:50] RoanKattouw, i think convention is to always use // except for docblocks. This is spelled out for JS, but not for PHP. I could try using /* for PHP and see if people complain. [03:19:52] https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Comments [03:20:13] Hah [03:20:33] Yeah you wouldn't want to use /** because that would freak out the doc system [03:20:58] (03CR) 10jenkins-bot: [V: 04-1] Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127) (owner: 10Mattflaschen) [03:22:15] The PHP does say /***** Do not comment like this ***/ [03:22:22] but it doesn't address an actual legitimate block. [03:22:38] But I have seen other cases where the JS says it, and PHP doesn't, and it's just kind of understood to do it for both. [03:22:46] Anyway, heading out. See you all tomorrow. [03:23:13] o/ [03:23:47] quiddity, i think you'll like the special page. It can be tweaked as needed. [03:24:04] The special page itself is not a WIP, but it depends on a WIP. [03:24:51] :) [03:25:20] (03CR) 10jenkins-bot: [V: 04-1] WIP: BREAKING CHANGE: Change $wgEchoDefaultNotificationTypes to be logical [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284124 (https://phabricator.wikimedia.org/T132820) (owner: 10Mattflaschen) [03:25:57] https://en.wikipedia.org/wiki/Tweek_Tweak is one of my spirit animals. [03:56:28] 10Thanks: Better workflow for thanking yourself - https://phabricator.wikimedia.org/T133003#2216730 (10APerson) [04:58:33] 10Thanks: Better workflow for thanking yourself - https://phabricator.wikimedia.org/T133003#2216730 (10Peachey88) Why would one be thanking themselves? [05:00:16] 10Thanks: Better workflow for thanking yourself - https://phabricator.wikimedia.org/T133003#2216843 (10APerson) @Peachey88, I was messing around with some improvements I recently made to the Navigation Popups gadget on ENWP, and decided to thank myself for something to see how far I could get before the software... [05:20:38] 06Collaboration-Team-Interested, 10Thanks: False "thanked" confirmation for users with thanks disabled - https://phabricator.wikimedia.org/T57401#2216861 (10Nemo_bis) I think there is consensus that we should not give false expectations to people. If we're unsure about revealing the target user's preferences,... [06:47:17] 10Thanks: Better workflow for thanking yourself - https://phabricator.wikimedia.org/T133003#2216941 (10Aklapper) p:05Triage>03Lowest [08:27:21] 10Thanks: Better workflow for thanking yourself - https://phabricator.wikimedia.org/T133003#2216730 (10Legoktm) > If it's possible to disable the confirmation button client-side, we should be doing that (with an appropriate error message) Given that Special:Thanks is a no-JS fallback, this doesn't make sense. [09:32:07] 03Collab-Team-2016-Q4, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 13Patch-For-Review: Enable Flow as a Beta feature on French Wikisource - https://phabricator.wikimedia.org/T132914#2217305 (10Trizek-WMF) [09:54:11] 06Collaboration-Team-Interested, 10Flow: Add redirect capability to Flow - https://phabricator.wikimedia.org/T102300#2217414 (10Trizek-WMF) [[https://www.mediawiki.org/wiki/Topic:T2cnkf7zk2nuun1g|New request]] on a wiki, plus an other one from a CL. At the moment it is possible to create a redirect like that:... [11:24:05] (03PS2) 10Sbisson: Bold 'talk page' in edit-user-talk bundled notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283692 (https://phabricator.wikimedia.org/T131476) [11:29:10] (03CR) 10jenkins-bot: [V: 04-1] Bold 'talk page' in edit-user-talk bundled notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283692 (https://phabricator.wikimedia.org/T131476) (owner: 10Sbisson) [12:37:10] (03PS3) 10Sbisson: Display only one foreign bundle on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283699 (https://phabricator.wikimedia.org/T131683) [12:42:42] (03CR) 10jenkins-bot: [V: 04-1] Display only one foreign bundle on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283699 (https://phabricator.wikimedia.org/T131683) (owner: 10Sbisson) [12:52:40] (03CR) 10Sbisson: "Looks good but I'm not sure how to test this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282400 (owner: 10Mattflaschen) [14:11:13] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2217972 (10Trizek-WMF) Thanks @Verdy_p! [14:38:22] (03PS1) 10Sbisson: Browser tests: fix nojs tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284194 [14:43:17] (03PS2) 10Sbisson: Browser tests: fix nojs tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284194 [15:04:55] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2218098 (10Verdy_p) Is this error related to the ongoing tests of transfer of net-center... [15:10:01] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2218130 (10Verdy_p) Note: we do not always see the message "the wiki is in read-only mod... [15:10:26] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2218131 (10Trizek-WMF) Yes it is. Please wait a bit before adding new translations. :) [15:12:16] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2218143 (10Verdy_p) However Wikidata is functional, as well as Wikipedia (I tested "fr",... [15:21:22] (03PS8) 10Sbisson: [WIP] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) [15:22:00] (03CR) 10Sbisson: [WIP] Moderate notifications (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [15:22:55] (03PS19) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [15:23:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [15:26:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [15:29:50] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2218230 (10Verdy_p) Well those errors are also part of the results of this short test (w... [15:49:15] (03CR) 10Jforrester: [C: 032] "Nice work-around. Sorry for the breakage." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284194 (owner: 10Sbisson) [15:49:28] (03PS18) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 [15:49:46] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [15:50:03] 06Collaboration-Team-Interested, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2218287 (10Trizek-WMF) @Verdy_p, that Phabricator task is not dedicated to the Server sw... [15:56:23] (03Merged) 10jenkins-bot: Browser tests: fix nojs tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284194 (owner: 10Sbisson) [16:02:29] (03PS3) 10Sbisson: Use plaintextParams() for snippets and sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284119 (https://phabricator.wikimedia.org/T132872) (owner: 10Catrope) [16:02:44] (03PS4) 10Sbisson: Display only one foreign bundle on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283699 (https://phabricator.wikimedia.org/T131683) [16:06:23] (03CR) 10Catrope: [C: 032] Bold 'talk page' in edit-user-talk bundled notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283692 (https://phabricator.wikimedia.org/T131476) (owner: 10Sbisson) [16:07:24] (03PS3) 10Jforrester: Bold 'talk page' in edit-user-talk bundled notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283692 (https://phabricator.wikimedia.org/T131476) (owner: 10Sbisson) [16:07:54] (03CR) 10Jforrester: [C: 032] Bold 'talk page' in edit-user-talk bundled notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283692 (https://phabricator.wikimedia.org/T131476) (owner: 10Sbisson) [16:08:54] (03PS19) 10Sbisson: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [16:09:59] (03PS20) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [16:10:59] (03CR) 10Catrope: [C: 032] Display only one foreign bundle on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283699 (https://phabricator.wikimedia.org/T131683) (owner: 10Sbisson) [16:17:00] (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo) [16:19:05] (03Merged) 10jenkins-bot: Bold 'talk page' in edit-user-talk bundled notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283692 (https://phabricator.wikimedia.org/T131476) (owner: 10Sbisson) [16:19:10] (03Merged) 10jenkins-bot: Display only one foreign bundle on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/283699 (https://phabricator.wikimedia.org/T131683) (owner: 10Sbisson) [16:39:55] 03Collab-Team-2016-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Bundle messages with imprecise amount of "other" not properly localizable - https://phabricator.wikimedia.org/T127288#2218555 (10jmatazzoni) 05Open>03Resolved [16:41:36] matt_flaschen: Should https://phabricator.wikimedia.org/T106363 still be assigned to Matthias or should it be assigned to you? [16:44:22] 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 4 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2218628 (10Catrope) [16:44:24] 03Collab-Team-2016-Q4, 10Flow, 10Datasets-General-or-Unknown, 13Patch-For-Review, and 2 others: Create XML Schema for Flow dump format(s) - https://phabricator.wikimedia.org/T112799#2218627 (10Catrope) 05Open>03Resolved [16:45:27] 03Collab-Team-2016-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review, 07Performance: Significant performance degradation in new (split) notifications - https://phabricator.wikimedia.org/T114012#2218635 (10Catrope) a:05matthiasmullie>03None [16:48:25] (03PS1) 10Aaron Schulz: Trigger base API class read-only mode checks for API [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/284224 [17:03:34] trying to join standup, but keeps failing... [17:12:45] 03Collab-Team-2016-Q4, 10Flow: Add redirect capability to Flow - https://phabricator.wikimedia.org/T102300#2218783 (10Catrope) [17:17:22] 03Collab-Team-2016-Q4, 10Flow: Add redirect capability to Flow - https://phabricator.wikimedia.org/T102300#1361833 (10Catrope) Fixing {T132955} would also accomplish this. [17:27:39] 10Thanks: $1 displayed for Thanks error (upon trying to thank self) - https://phabricator.wikimedia.org/T133003#2218939 (10Mattflaschen) [17:29:27] (03CR) 10Mattflaschen: "Run:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282400 (owner: 10Mattflaschen) [17:30:34] (03CR) 10Mattflaschen: "You have to be in the top-level Flow directory when you run the installhooks command." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282400 (owner: 10Mattflaschen) [17:40:21] 10Flow: Script to allow migrating Flow content between External Store clusters - https://phabricator.wikimedia.org/T133074#2219021 (10Mattflaschen) [17:40:28] 10Flow: Script to allow migrating Flow content between External Store clusters - https://phabricator.wikimedia.org/T133074#2219006 (10Mattflaschen) [17:40:38] 03Collab-Team-2016-Q4, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 07WorkType-Maintenance: Migrate Flow content to new separate logical External Store in production - https://phabricator.wikimedia.org/T106363#2219024 (10Mattflaschen) [17:40:47] matt_flaschen: Random brain-picking: I'm inclined to put aside https://phabricator.wikimedia.org/T126264 as a "meh this is hard" thing; any ideas for how we could determine the "correct" anchor to point to from a notification? [17:41:12] 03Collab-Team-2016-Q4, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 07WorkType-Maintenance: Migrate Flow content to new separate logical External Store in production - https://phabricator.wikimedia.org/T106363#2219056 (10Mattflaschen) a:05matthiasmullie>03Mattflasch... [17:41:22] RoanKattouw, he wrote the script, but that has since become a tracking task. I created a separate one for the script and assigned myself to the tracking since I'm coordinating it on the Flow side. [17:41:37] i.e. given a timestamp, of the replies that occurred at or after that timestamp, find the one that is going to be rendered nearest the top of the page [17:42:31] 10Flow: Enable specific talk pages to not use Flow - https://phabricator.wikimedia.org/T132955#2219065 (10Mattflaschen) [17:42:33] 03Collab-Team-2016-Q4, 10Flow: Add redirect capability to Flow - https://phabricator.wikimedia.org/T102300#2219064 (10Mattflaschen) [17:43:44] RoanKattouw, I think it's solvable. I need to think it out. I will see if I can figure it out after lunch. [17:44:10] OK [17:56:29] RoanKattouw, matt_flaschen, even just getting sent to the top of the topic, would be preferable to being sent to something too far down. [17:57:47] plus that helps remind us to re-read the context, before the 'new reply'. [17:58:09] Hmm I guess then we could render a bunch of timestamp anchors at the top so that you are sent to the top but we still highlight the correct replies [18:10:15] 03Collab-Team-2016-Q4, 10Flow: Flow: If blocked, the user has no Reply buttons - https://phabricator.wikimedia.org/T61928#2219183 (10jmatazzoni) [18:10:37] 03Collab-Team-2016-Q4, 10Flow, 13Patch-For-Review: FlowReplies is not firing in production - https://phabricator.wikimedia.org/T96620#2219185 (10jmatazzoni) [18:43:51] 03Collab-Team-2016-Q4, 13Patch-For-Review: [betalabs] Flow-topic-resolved notifications display topic id in a secondary link - https://phabricator.wikimedia.org/T132229#2219408 (10Etonkovidova) Checked the fix in betalabs - Flow board page title is displayed as a secondary link - the secondary link (the secon... [18:46:18] (03PS21) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [18:49:43] 03Collab-Team-2016-Q4, 10Flow, 10Notifications: Bundled flow-post-reply notifications, should send editors to the top-most reply - https://phabricator.wikimedia.org/T126264#2219422 (10Mattflaschen) a:05Catrope>03Mattflaschen [18:51:37] RoanKattouw, quiddity, ignoring the techical issues, do you prefer always linking to the top of the topic, or to the topmost new post? [18:56:10] I figured out that the top-ness is just a pre-order depth-first search tree traversal. [18:56:55] Where children at any given level are ordered by insertion order. [18:59:41] 03Collab-Team-2016-Q4: [betalabs] flow-topic-resolved notifications should have a summary excerpt - https://phabricator.wikimedia.org/T133088#2219478 (10Etonkovidova) [19:04:49] matt_flaschen, ignoring the technical issues, linking to the topmost new post is probably ideal, for consistency. [19:11:39] officewiki: Notice: Array to string conversion in /srv/mediawiki/php-1.27.0-wmf.21/extensions/Flow/includes/Conversion/Utils.php on line 450 [19:11:48] seeing those when just initializing mediawiki via eval.php [19:18:39] (03CR) 10Sbisson: "I've added the indexes and testing the whole thing right now." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [19:28:49] 03Collab-Team-2016-Q4: [betalabs] flow-topic-resolved notifications should have a summary excerpt - https://phabricator.wikimedia.org/T133088#2219478 (10Etonkovidova) [19:28:53] 03Collab-Team-2016-Q4, 10Flow, 13Patch-For-Review: [betalabs] 'Update summary' on blank summary will create an empty view-topic-summary page - https://phabricator.wikimedia.org/T132531#2219703 (10Etonkovidova) [19:28:56] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2219701 (10Etonkovidova) [19:42:23] 03Collab-Team-2016-Q4: [betalabs] flow-topic-resolved notifications should have a summary excerpt - https://phabricator.wikimedia.org/T133088#2219478 (10SBisson) > if a topic's summary was added simultaneously with Resolving the topic The problem is: Resolve and Summarize are independent actions that don't happ... [19:42:46] stephanebisson: Any additional work should be done for https://phabricator.wikimedia.org/T132531 "[betalabs] 'Update summary' on blank summary will create an empty view-topic-summary page" ? [19:42:58] stephanebisson: it's in 'Needs Review' column ... [19:43:13] etonkalthough it's merged and working [19:43:48] etonkovidova: the person who merged forgot to move it to the QA column [19:44:59] stephanebisson: ah ok :) and I'll talk to jmatazzoni__ about your comment on T133088 [19:45:00] T133088: [betalabs] flow-topic-resolved notifications should have a summary excerpt - https://phabricator.wikimedia.org/T133088 [19:54:47] (03CR) 10Sbisson: "I ran `make installhooks` and create a new commit with tons of js errors. It went through just fine. What is supposed to happen in this ca" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282400 (owner: 10Mattflaschen) [19:56:43] 03Collab-Team-2016-Q4, 10Flow, 13Patch-For-Review: [betalabs] 'Update summary' on blank summary will create an empty view-topic-summary page - https://phabricator.wikimedia.org/T132531#2219843 (10Etonkovidova) Verified the fix in betalabs - the null edits for summary are blocked from appearing in history. [20:06:14] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Add tooltips for "X" and "..." icons - https://phabricator.wikimedia.org/T130831#2219904 (10Etonkovidova) Checked in betalabs - the tooltips are added to all types of notifications (incl bundled and cross-wiki bundled). [20:17:41] RoanKattouw, anything to mention at Scrum of Scrums? So far I have external store, Flow dumps, and Echo moderation, bundling, MVC, and special page work. [20:18:13] I talked to Matthias about Flow dumps and he said that he believed it's not blocked on our end, just waiting for Ariel to finish it [20:18:36] etonkovidova, stephanebisson: Sorry, I thought I'd moved all the tasks for things I'd merged [20:19:10] RoanKattouw, yes. That's what I'll be saying tomorrow in SoS. [20:19:43] legoktm, are you still getting that officewiki error? I don't see it on terbium. [20:20:34] matt_flaschen: I am not...weird. [20:20:58] matt_flaschen: Don't use terbium, use whatsitsname in codfw [20:21:10] $output[] = "$wgCookiePrefix$key=$value"; [20:21:23] I find it unlikely that $wgCookiePrefix is an array, so that would mean $value was an array [20:21:57] wasat! [20:22:59] Which would mean $wgRequest->getResponse()->cookies (private, so accessed through reflection) is an array of arrays [20:23:52] Right, wasat [20:23:56] What was THAT named after [20:25:29] The server is seriously called wasat... [20:26:22] RoanKattouw, but I don't see the error there either. [20:27:01] RoanKattouw, it doesn't necessarily means cookies is entirely an array of arrays. It could just be one glitchy $value that is an array. (Or it could be the $key). [20:27:03] RoanKattouw: https://en.wikipedia.org/wiki/Delta_Geminorum [20:27:09] Right [20:27:16] $key can't be an array, can it? [20:27:23] $value could be [20:27:31] Especially if someone set a cookie called 'foo[]' [20:29:00] Yeah you're right. I was thinking it shouldn't be, but you're also right it can't be. [20:29:35] well, I shouldn't have had any cookies [20:30:08] It calls $user->setCookies() [20:30:17] https://paste.fedoraproject.org/357522/61097808/raw/ [20:30:33] the script I was running is called purgeSidebarCache.php in my homedir on wasat [20:30:45] I don't know what generateForwardedCookieForCli does exactly but it looks like black magic [20:31:34] legoktm, RoanKattouw, it generates cookies on the CLI so you can access private wikis like officewiki. [20:31:54] Basically it gives you access to the wiki as the talk page manager. [20:32:21] Otherwise Parsoid wouldn't be able to do anything. [20:32:41] If it happens again, someone should file a task. [20:42:50] 03Collab-Team-2016-Q4: [betalabs] Bundled flowusertalk-new-topic notifications refer to a user talk page with a full title. - https://phabricator.wikimedia.org/T133100#2220118 (10Etonkovidova) [20:50:42] 03Collab-Team-2016-Q4: [betalabs] Bundled flowusertalk-new-topic notifications refer to a user talk page with a full title. - https://phabricator.wikimedia.org/T133100#2220165 (10Etonkovidova) [20:51:59] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Make 'your page' bold in Notifications for bundled edits from User talk wikitext pages - https://phabricator.wikimedia.org/T131476#2220230 (10Etonkovidova) Fixed - checked in betalabs. The screenshot shows bundled notifications about edits on wikite... [21:27:36] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Cross-wiki notifications on mobile show separate bundles for alerts and messages, should be one bundle - https://phabricator.wikimedia.org/T131683#2174675 (10Etonkovidova) Checked on iOS (betalabs) - Alerts and messages are presented in a chronolog... [21:36:56] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2220529 (10Etonkovidova) @jmatazzoni Please review @SBisson comment on {T133088}. I moved both tickets to Prod... [22:30:24] RoanKattouw: any chance you could do thursday morning? [22:31:16] legoktm: Sure. I'm free between 11 and 12 [22:31:42] It doesn't have to be Thursday either, I'm just shooting for some time this week or early next [22:31:57] Since this is due next Friday (1.5 weeks from now) and I try not to cut it too close [22:38:45] RoanKattouw: ok, thanks, 11 is good for me [22:39:05] Cool, thanks [22:57:52] (03PS1) 10Catrope: Update OOUI hacks for I8987dade5ed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284374 [22:58:00] James_F: ---^^ [22:58:37] (03CR) 10Jforrester: [C: 032] Update OOUI hacks for I8987dade5ed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284374 (owner: 10Catrope) [23:02:31] ^ ew. :/ [23:02:42] Yeah... [23:02:46] i'm having second thoughts about the OOUI change. eh [23:03:04] Thing is, even if you ignore the 1.875em vs 1.5em thing, scaling icons to the font size used to work [23:03:21] Now they're limited to being at least 24x24 [23:03:47] for IE11 we could try the calc() workaround [23:04:11] I suspected there might be one [23:04:14] What is it exactly? [23:04:31] I was thinking something like calc(1.875em + 0.1px) but that probably doesn't work [23:05:13] RoanKattouw: calc(1.875 * 1em) [23:05:15] IIRC [23:05:26] i linked a task explaining it somewhere on that gerrit change [23:05:31] You gotta be kidding me [23:05:34] nope [23:05:37] it rounds ems [23:05:38] multiply by one, really <_< [23:05:41] not plain numbers [23:06:28] RoanKattouw: https://phabricator.wikimedia.org/T102364 [23:06:58] (03Merged) 10jenkins-bot: Update OOUI hacks for I8987dade5ed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284374 (owner: 10Catrope) [23:09:06] 03Collab-Team-2016-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: Deleted wikitext Talk page cannot be restored after EnableFlow creates the same page - https://phabricator.wikimedia.org/T104591#2221103 (10Etonkovidova) Checked the fix in betalabs - the error message is not present anymore.... [23:51:09] 10Notifications, 06Commons: notifications incorrectly parse tl-wrapped templates - https://phabricator.wikimedia.org/T133128#2221263 (10FDMS) [23:56:43] 03Collab-Team-2016-Q4, 15User-JAufrecht: Refine Collab 2016Q4 Phlogiston - https://phabricator.wikimedia.org/T132983#2221321 (10JAufrecht) a:05JAufrecht>03None [23:57:35] 03Collab-Team-2016-Q4, 15User-JAufrecht: Refine Collab 2016Q4 Phlogiston - https://phabricator.wikimedia.org/T132983#2221332 (10JAufrecht) a:03Catrope Looked at with Joe. Roan, any double-checking? Also, note that Q4 Other has about five tasks in it (see them at the bottom of http://phlogiston.wmflabs.org/...