[00:17:21] 03Collab-Team-2016-Q4, 10Notifications: Accessibility of diff pages from Notifications - https://phabricator.wikimedia.org/T131631#2201794 (10jmatazzoni) [00:21:44] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4: Timestamps in mobile special:notifications can differ from desktop - https://phabricator.wikimedia.org/T131733#2201818 (10Catrope) [00:28:44] 03Collab-Team-2016-Q4, 06Editing-Analysis, 13Patch-For-Review: Notification dashboards miscount time-to-read - https://phabricator.wikimedia.org/T131206#2201847 (10Catrope) >>! In T131206#2201517, @mforns wrote: > This repository is very old and is not handled by Gerrit. Do you want me to create a pull reque... [00:33:40] 03Collab-Team-2016-Q4, 10Notifications, 07WorkType-NewFunctionality: Clarify read/unread status for notifications - https://phabricator.wikimedia.org/T126214#2201848 (10Catrope) [00:59:20] 10Flow: "Mark as resolved" does nothing if board is protected - https://phabricator.wikimedia.org/T132537#2201857 (10Catrope) [01:00:58] (03CR) 10Mattflaschen: [C: 04-1] "I don't know how you could get around this (since I think the original data is at second-level granularity), but it's likely that there co" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273903 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [01:04:34] (03PS1) 10Catrope: Use plaintext for topic titles in resolved notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/283114 (https://phabricator.wikimedia.org/T131073) [01:04:39] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4, 13Patch-For-Review: Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2201872 (10Catrope) [01:05:20] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4, 13Patch-For-Review: Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2155245 (10Catrope) a:03Catrope [01:57:19] (03PS1) 10Mattflaschen: Fix sink-handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/283117 (https://phabricator.wikimedia.org/T89398) [02:01:20] 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2201915 (10Mattflaschen) >>! In T89398#2198392, @ArielGlenn wrote: > I expect to be able to pass --output:bz2:/mnt/data/xmldatadumps/..../mediaw... [02:03:20] 10Flow: "Mark as resolved" does nothing if board is protected - https://phabricator.wikimedia.org/T132537#2201857 (10Mattflaschen) You tested as non-admin? [02:03:39] Have a good night, all. [02:29:50] matt_flaschen: you were right, the notification got auto-read when I visited the talkpage [03:08:52] 03Collab-Team-2016-Q4, 10Notifications: Remove automatic mark-as-read - https://phabricator.wikimedia.org/T132525#2202007 (10Pokefan95) p:05Triage>03Normal [06:41:52] (03CR) 10Catrope: [C: 04-1] "Comments from reading the code, I haven't tested this yet." (0318 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [07:39:57] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2202253 (10Pginer-WMF) > One interesting question that came up: what should happen to bundled notifications when they're being viewed from a differ... [07:52:56] 10Flow: User don't receive email notifications concerning their Flow talk page when "Talk page message" is on, but "Flow" is off - https://phabricator.wikimedia.org/T132426#2202276 (10Trizek-WMF) The most important is the final result: * "Talk page message": user wants to receive emails from the talk page, not... [08:00:19] 03Collab-Team-2016-Q4, 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review: FlowReplies is not firing in production - https://phabricator.wikimedia.org/T96620#2202279 (10Pginer-WMF) >>! In T96620#2197860, @Catrope wrote: > I don't care much about this data FWIW, but Joe, Pau and Neil may have other... [09:07:46] 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2202466 (10ArielGlenn) Yep sorry, I guarantee I got the option right when doing my manual tests, shoulda copypasted here. [11:10:59] 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2202692 (10ArielGlenn) datasets@snapshot1005:~$ php /srv/mediawiki/multiversion/MWScript.php extensions/Flow/maintenance/dumpBackup.php --wiki... [11:23:33] 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2202718 (10ArielGlenn) Because both current and full dumps can be produced for Flow pages according to the options for the script at any rate, d... [11:56:33] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2202773 (10matej_suchanek) [11:56:35] 06Collaboration-Team-Interested, 10Notifications: multiple new links notification should provide names of newly linked pages - https://phabricator.wikimedia.org/T67662#2202772 (10matej_suchanek) [12:44:56] (03CR) 10ArielGlenn: [C: 031] Fix sink-handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/283117 (https://phabricator.wikimedia.org/T89398) (owner: 10Mattflaschen) [12:47:53] (03CR) 10Sbisson: [C: 032] Use plaintext for topic titles in resolved notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/283114 (https://phabricator.wikimedia.org/T131073) (owner: 10Catrope) [12:56:23] (03Merged) 10jenkins-bot: Use plaintext for topic titles in resolved notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/283114 (https://phabricator.wikimedia.org/T131073) (owner: 10Catrope) [13:01:28] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4, 13Patch-For-Review, 07user-notice: Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2202988 (10Trizek-WMF) [13:06:10] (03CR) 10Sbisson: [C: 032] Use topic-of-post-text-from-html for all UI purposes, never use topic-of-post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/281252 (https://phabricator.wikimedia.org/T131628) (owner: 10Catrope) [13:14:07] (03Merged) 10jenkins-bot: Use topic-of-post-text-from-html for all UI purposes, never use topic-of-post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/281252 (https://phabricator.wikimedia.org/T131628) (owner: 10Catrope) [14:07:37] 03Collab-Team-2016-Q4, 10Notifications: Remove automatic mark-as-read (of alerts) when you open the popup - https://phabricator.wikimedia.org/T132525#2203190 (10Mattflaschen) [14:40:41] (03CR) 10Matthias Mullie: [C: 032] Fix sink-handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/283117 (https://phabricator.wikimedia.org/T89398) (owner: 10Mattflaschen) [14:45:48] 06Collaboration-Team-Interested, 10Notifications: multiple new links notification should provide names of newly linked pages - https://phabricator.wikimedia.org/T67662#695388 (10Mattflaschen) RecentChangesLinked shows changes to pages linked *from* the specified page, whereas the notification is about links *t... [14:46:06] 06Collaboration-Team-Interested, 10Notifications: multiple new links notification should provide names of newly linked pages - https://phabricator.wikimedia.org/T67662#2203357 (10Mattflaschen) [14:48:55] 06Collaboration-Team-Interested, 10Notifications: multiple new links notification should provide names of newly linked pages - https://phabricator.wikimedia.org/T67662#2203361 (10Mattflaschen) [14:49:21] 06Collaboration-Team-Interested, 10Notifications: multiple new links notification should provide names of newly linked pages - https://phabricator.wikimedia.org/T67662#695388 (10Mattflaschen) Sorry, I should have read more closely. I see from the page (and your comment) there is an option to go the other way. [14:49:45] (03Merged) 10jenkins-bot: Fix sink-handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/283117 (https://phabricator.wikimedia.org/T89398) (owner: 10Mattflaschen) [14:53:15] mlitn, the rev-range path for the dumps is broken. It doesn't output the revisions at all. I'm going to fix that, and also update some docs. [14:54:39] mmh [14:54:47] mlitn, it's unintuitive for topics/post content. AFAICT, it gives you topics where the topic was last updated in the range. That is not the same as updates to topics in that range. If the range is Jan. 1 to Jan. 31 2016, and the topic was last updated yesterday, it won't show up, even though there could have been plenty of topic changes and new posts/edits in that range. [14:56:06] true [14:56:37] wonder if there’s a reason I did it this way [14:56:53] mlitn, I think because it's easier to query workflow table. [14:57:15] I don't know if this is is useful to anyone, but I'm not sure a different behavior would either, so I'm just going to update the docs. Ariel is inquiring at T89398, but I'm not sure if either behavior would actually be helpful. [14:58:07] I probably just implemented revrange because the search iterators already had start & end ids [14:58:16] Yeah [14:58:17] and never even considered the case you just described [14:58:36] I doubt it’s useful to anyone anyway :) [14:58:53] It might actually still be useful for real-world cases if you just don't use an end revision ID. [14:59:04] Get all topics updated since I last did the dump. [15:01:21] or with end id for batches [15:01:32] (though I see no practical use there :p) [15:02:18] It also apparently does all boards regardless, which is not great, but not the end of the world. [15:02:24] It just does empty tags. [15:05:25] (03CR) 10Matthias Mullie: Add a source store that uses import results (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273903 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [15:05:30] (03PS4) 10Matthias Mullie: Add a source store that uses import results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273903 (https://phabricator.wikimedia.org/T119509) [15:14:04] mlitn, do you think it should do all revisions of affected headers/topics, or just those in range? I'm probably not going to change how it chooses which headers/topics are affected. [15:14:09] At least not now [15:14:25] I guess it should be those in range. [15:14:38] We're already doing a permission check for each one, so it shouldn't be a slowdown compared to that. [15:15:04] just those in range makes most sense [15:15:19] but then it’ll be impossible to import data like that, I think [15:15:30] (with incomplete history) [15:15:42] mlitn, it should still work, because we already handle gaps due to moderation. [15:16:09] yeah, but I think there’s some special handling to rewrite history and pretend those gaps were not there, iirc [15:20:14] mlitn, I'm revising my statement to "it might still work". I'm thinking the rewriting history logic might work here. I'll ask you to do a test, so I don't have to mess with my DB. [15:21:58] hmm [15:22:40] but then if we rewrite history, it’ll probably be impossible to import batches [15:22:41] there may be multiple revisions of 1 thing in multiple time spans [15:22:54] and if we rewrite history, they may not be imported as 1 post? [15:23:11] IDK what the exact usecases of revrange usually are [15:24:15] Yeah, me neither. Ariel indicated they might use it for batching to generate new fulls. [15:24:52] https://phabricator.wikimedia.org/T89398#2202718 [15:29:30] Oh, I see. With moderated items reconstruction, by definition it's no *longer* moderated (if it was there wouldn't be a gap, it would all be gone). And since it's no longer moderated, the first revision is always visible (since that in itself is by definition unmoderated, and it's not affected by current moderation of a later revision, since in this case there is none). [15:30:10] So I see why importing a range might not work. [15:30:38] do you have any idea how the process ariel described (that 2-stage process) works? [15:31:01] I can’t seem to find where core dumper takes an existing dump to work with [15:32:20] mlitn, not at all, all I know is what I just linked. You could check with Ariel. [15:32:57] Got to go to a meeting now. [15:44:30] 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 4 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2203659 (10matthiasmullie) @ArielGlenn: Where does that 2-stage process happen? I took a quick look at core's dumpBackup.php but that one didn't... [15:44:45] matt_flaschen: updated the ticket [15:51:08] 03Collab-Team-2016-Q4, 10Flow, 13Patch-For-Review: compare-post-revisions page displays numeric character reference in topic titles - https://phabricator.wikimedia.org/T131628#2203698 (10Etonkovidova) Checked the fix in betalabs. [16:30:29] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4, 13Patch-For-Review, 07user-notice: Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2203857 (10Etonkovidova) Checked the fix in betalabs (including 
, ,   and templates (for regression)).  Tags in...
[16:36:18] 	 03Collab-Team-2016-Q4, 10Flow, 03Collab-Archive-2015-2016, 13Patch-For-Review: topic-title-plaintext content format to treat topic-title-wikitext as plain text - https://phabricator.wikimedia.org/T129439#2203886 (10Etonkovidova) Since {T120291} and {T131073} are fixed/verified, and general regression for t...
[17:53:05] 	 Getting lunch
[18:04:43] 	 10Flow: Can't find username beginning with 2 capital letters if I'm using lowercase - https://phabricator.wikimedia.org/T132608#2204219 (10Elitre)
[18:29:06] 	 Okay, I'm fairly sure something's truly screwed up with resource loader's dependencies now
[18:29:20] 	 I have dependencies that are not loading
[18:30:57] 	 So, I have mw.loader.using( 'ext.echo.ui.desktop', function () { ... } ) --> inside it, I have "bla = new mw.echo.Controller();"
[18:31:19] 	 ext.echo.ui.desktop has a dependency a module 'ext.echo.controller' which holds the controller file and is dependent on ext.echo.api.
[18:31:36] 	 The code breaks INSIDE that callback function saying that mw.echo.Controller is unrecognized
[18:32:22] 	 I put the file itself outside its module, just to check, and inside the general module, and things worked - except then I got an error with ext.echo.api files that aren't loaded even though the *module* ext.echo.api is marked as ready.
[18:32:23] 	 wtf.
[18:35:27] 	 stephanebisson, are you around by any chance?
[18:35:40] 	 mooeypoo: yep
[18:36:03] 	 I hereby shine the stephane-shaped spotlight upon the cloudy skies
[18:36:28] 	 help :\ I'm missing something, for sure, and I could use an extra pair of eyes if you have a moment. The dependencies aren't loading.... it makes no sense.
[18:36:43] 	 (03PS6) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 
[18:36:51] 	 mooeypoo: upload the patch as it is and I'll take a look
[18:36:54] 	 ^^ in this version, I have ext.echo.controller as its own module
[18:37:04] 	 (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo)
[18:37:19] 	 I have it as the dependency of the dm, who is, in turn, the dependency of the UI, who is, in turn the dependency of the "desktop" module, which I am loading
[18:37:21] 	 ok, let me check
[18:37:27] 	 and yet it fails! 
[18:37:58] 	 There's a file literally in there in the dm segment that I commented out -- if you bring it back in, it works -- but then the *API* module isn't loading inside the mw.echo.dm.NotificationsList
[18:38:06] 	 ... but the api is its dependency...
[18:38:14] * mooeypoo rips out bright red hair
[18:40:32] 	 first, dm shouldn't depend on controller
[18:40:47] 	 logically, the coupling is the other way around
[18:40:59] 	 yes. 
[18:41:00] 	 Agreed.
[18:41:06] 	 But since it wasn't loading, I was trying everything :\
[18:41:25] 	 Feel free to change whatever order you think should work -- so far it doesn't seem to work with the dependencies at all
[18:53:10] 	 10Flow: Can't find username beginning with 2 capital letters if I'm using lowercase - https://phabricator.wikimedia.org/T132608#2204468 (10Mattflaschen)
[18:53:12] 	 06Collaboration-Team-Interested, 10Flow: case-insensitive autocomplete for mentions - https://phabricator.wikimedia.org/T101254#2204469 (10Mattflaschen)
[18:59:30] 	 mooeypoo, are you familiar with mw.loader.getState and mw.inspect?
[19:04:06] 	 matt_flaschen, I am, that's why I said that the module is loaded but the file isn't
[19:04:13] 	 I checked wtih mw.loader.getState( ... )
[19:04:21] 	 so weird and frustrating. I'm doing *something* wrong
[19:04:40] 	 Yeah, sorry, I asked that before reading the full scrollback.
[19:04:57] 	 mooeypoo, do you want to screenshare?
[19:05:12] 	 mooeypoo, or I could just download it if it's up to date.
[19:05:21] 	 it should be
[19:05:26] 	 stephanebisson said he's also taking a look
[19:13:17] 	 mooeypoo: should I upload a new PS?
[19:16:23] 	 stephanebisson, please!
[19:16:34] 	 is it working resource-loader-wise ?
[19:16:50] 	 (03PS7) 10Sbisson: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo)
[19:16:59] 	 I think so
[19:17:08] 	 (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo)
[19:17:28] 	 it fails later on with ModelManager not being an EventEmitter
[19:17:47] 	 but I think it loads
[19:19:45] 	 that I can fix
[19:20:00] 	 it failed for not recognizing files it supposedly already loaded
[19:20:59] 	 stephanebisson, "Cannot read property 'ForeignAPIHandler' of undefined TypeError: Cannot read property 'ForeignAPIHandler' of undefined"
[19:21:09] 	 are you getting this error when opening the popup ? 
[19:21:20] 	 It's once again not recognizing ext.echo.api module... 
[19:21:21] 	 no...
[19:21:26] 	 ok let me hard-refresh
[19:21:32] 	 did you fix the EventEmitter thing?
[19:22:27] 	 I am not getting the EventEmitter thing
[19:22:37] 	 I'm getting Exception in load-callback in module ext.echo.ui.desktop:
[19:22:41] 	 ypeError: Cannot read property 'ForeignAPIHandler' of undefined TypeError: Cannot read property 'ForeignAPIHandler' of undefined(�)log @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:178handler @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:155fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin
[19:22:42] 	 =vector&version=km%2BnqWer:45self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:46self.fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:46mw.track @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:155handlePending @ load.php?debug=false&lang=en&modules=jquery%
[19:22:42] 	 2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:159markModuleReady @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:162(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:162fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:45self.add @ load.php?
[19:22:49] 	 debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:45promise.always @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:46runScript @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:162checkCssHandles @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=k
[19:22:54] 	 m%2BnqWer:163(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:163fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=km%2BnqWer:45self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2C
[19:22:58] 	 .... oops wow
[19:22:58] 	 pretty
[19:23:00] 	 ... sorry, apparently it copied the entire thing
[19:23:18] 	 anyways, the "cannot read property 'ForeignApiHandler' of undefined comes from trying to set a new API handler
[19:23:25] 	 it's not recognizing mw.echo.api.*
[19:23:31] 	 .... again, module loading problem :\
[19:24:12] 	 I should also see that, but I don't
[19:24:56] 	 what the hell
[19:25:16] 	 I keep getting the same thing
[19:26:39] 	 stephanebisson, you pull the patch, then click one of the badges -- you don't get this error??
[19:27:42] 	 I get "this.emit is not a function"
[19:27:46] 	 stephanebisson, I just fixed the EventEmitter thing, but I am still getting the API error. I have no idea what is going on
[19:27:47] 	 hang on
[19:28:04] 	 (03PS8) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 
[19:28:05] 	 pull that ^^
[19:28:10] 	 that should fix the EventEmitter thing
[19:28:22] 	 (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo)
[19:28:51] 	 This patchset on my computer is cursed
[19:29:22] 	 I get NO error, and then "this.notificationsWidget.resetNotificationItems" when I close the flyout
[19:29:34] 	 "his.notificationsWidget.resetNotificationItems is not a function"
[19:29:35] 	 what in the flying...
[19:29:54] 	 yeah that makes sense
[19:29:58] 	 it's not implemented yet
[19:30:04] 	 ... but I'm not even getting to that stage
[19:30:14] 	 stephanebisson, are you seeing any items in the popup at all?
[19:30:21] 	 no, it's empty
[19:30:29] 	 yeah, see, that's what I was trying to figure out first
[19:30:36] 	 but it keeps crashing on the API thing
[19:30:50] * mooeypoo is going to try and reboot her infernal laptop
[19:30:51] 	 bbiab
[19:32:42] 	 stephanebisson: if I Mark as read a bundled notification such as "There are 5 new topics on your talk page" - the counter goes down only by one. Is this a desired behavior?  
[19:34:05] 	 etonkovi_: Yes, it's always been like that. It counts as 1. But we are going to change that with dynamic bundles. It will count as 5 because you will be able to actually see the 5 notifications.
[19:34:29] 	 stephanebisson: understood :) thx!
[19:54:00] 	 this is insane. I'm still getting the same error.
[19:54:43] 	 I can trace that the controller, api, widgets are loaded in echo.init.js
[19:54:56] 	 where is the error happening?
[19:55:55] 	 is there a RL cache that needs flushing?
[19:55:59] 	 inside mw.echo.api.NetworkHandler.prototype.addApiHandler
[19:56:11] 	 which makes no sense, because that file is *part* of the ext.echo.api module!
[19:56:23] 	 and what is the error again?
[19:56:25] 	 *and* the network handler is loaded last, so it shouldn't be about order of loading, either
[19:56:38] 	 this.addCustomApiHandler(name, new mw.echo.api.ForeignAPIHandler(config.url,config)); <-- it gets stuck on this
[19:56:49] 	 Uncaught TypeError: Cannot read property 'ForeignAPIHandler' of undefined
[19:56:54] 	 and what is the error?
[19:56:56] 	 how the hell is that possible?
[19:57:15] 	 mw.echo.api is absolutely set up at that point, because that code is *inside* mw.echo.api.NetworkHandler 
[19:57:18] 	 .... what the hell
[19:57:22] 	 meaning "mw.echo.api" is undefined??
[19:57:28] 	 yes!
[19:57:43] 	 wait...
[19:57:46] 	 i have a feeling
[19:58:02] * mooeypoo wonders if this is a mix with a context issue
[19:58:46] 	 hm, nope... 
[19:58:57] 	 what in the name of JavaScript is going on
[20:02:12] 	 stephanebisson_, I put a debugger inside the mw.echo.api.NetworkHandler constructor. It triggered well... then it crashes on that "cannot read property.. of undefined" error from INSIDE mw.echo.api.NetworkHandler
[20:02:14] 	 what the hell
[20:04:05] 	 is this starting at "echoApi = new mw.echo.api.EchoApi();" in ext.echo.init.js?
[20:06:29] 	 no, that part goes well
[20:07:26] 	 it seems to fail when the controller runs "fetchLocalNotifications" and then calls controller.api.registerForeignSources( notifData.sources );
[20:07:28] 	 Hello again.
[20:10:04] 	 stephanebisson_, it all happens in "fetchLocalNotifications" inside the controller. It runs and goes into the EchoAPI successfully, then calls the NetworkHandler successfully (both using mw.echo.api prefix!) and then fails INSIDE that method on thinking that mw.echo.api is undefined. What the hell.
[20:12:28] 	 stephanebisson_, I managed to "fix" it
[20:12:56] 	 ..ok, I'm gong to use this hack for now, but this is crazy. We're apparently loading one of the mw.echo= {} definitions *after* things are already loaded
[20:13:05] 	 so I added mw.echo = mw.echo || {};
[20:13:14] 	 we can figure out where and why this double-loading happens later
[20:13:19] * mooeypoo considers this progress
[20:13:53] 	 Does RL always include the dependencies or only if there are not already loaded?
[20:14:40] 	 it *should*
[20:14:45] 	 but... I'm not sure anymore?
[20:15:53] 	 wait... dm is including "mw.echo.js", which defines mw.echo
[20:16:51] 	 stephanebisson_, it is definitely not supposed to double-load things.
[20:16:59] 	 If it's already 'ready' it should not be re-executed.
[20:18:37] 	 mooeypoo: I would move the file "mw.echo.js" from "ext.echo.dm" to "ext.echo.ui"
[20:22:42] 	 stephanebisson_, but dm loads first as a dependency
[20:22:57] 	 stephanebisson_, actually, it should probably be in either 'base' or init
[20:23:03] 	 yeah
[20:23:23] 	 stephanebisson_, i'm ignoring this for a  moment - I'm super close to getting the widget to populate
[20:23:36] 	 the only problem I have right now is that it seems to not be listening to the "update" event from the manager
[20:23:52] 	 or alternatively that the event is fired too soon before the widget attached the event
[20:24:49] 	 stephanebisson_, I am also having a small issue with the separation of the badges (both suddenly turn blue after opening the message one) but that's probably a typo on my part in the init
[20:24:52] 	 less worried about thta
[20:26:10] 	 stephanebisson_, so far walking-through the code, things work well
[20:26:25] 	 the manager builds 2 models - local and xwiki - and populates them with correct items
[20:26:30] 	 pretty excited about that 
[20:34:17] 	 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 4 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2204827 (10ArielGlenn) These dumps should make it possible for someone to set up a mirror (right to fork).  That means that all data available t...
[20:49:19] 	 03Collab-Team-2016-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 4 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2204906 (10Mattflaschen) >>! In T89398#2204827, @ArielGlenn wrote: > "Current" ought to dump topics currently visible on a page.  It does.  Also...
[21:02:07] 	 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2204951 (10Sadads)
[21:03:22] 	 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2187762 (10Sadads)
[21:05:30] 	 (03PS1) 10Mattflaschen: Remove revision range [extensions/Flow] - 10https://gerrit.wikimedia.org/r/283328 (https://phabricator.wikimedia.org/T89398) 
[21:08:08] 	 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2204977 (10Quiddity)
[21:10:08] 	 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2204982 (10Sadads)
[21:12:18] 	 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2204986 (10Ocaasi)
[21:13:30] 	 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2187762 (10Ocaasi)
[21:14:47] 	 10Notifications, 10The-Wikipedia-Library: Quarry the number editors effect per month by 500 edits and 6 months notification - https://phabricator.wikimedia.org/T132088#2204995 (10egalvezwmf) Alright - I tried but can't seem to get it to work.  http://quarry.wmflabs.org/query/8929   @Capt_Swing  - can you help...
[21:15:02] 	 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2204997 (10Sadads)
[21:15:33] 	 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2204999 (10Mattflaschen) We decided at standup today {T132384} was not a blocker, so we'll deploy it again today at 4 PM...
[21:23:50] 	 (03PS9) 10Mooeypoo: [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 
[21:23:55] 	 ok I'm off to sleep
[21:24:01] 	 see you day after tomorrow
[21:24:19] 	 (03CR) 10jenkins-bot: [V: 04-1] [wip^n] Refactoring Echo's front end for MVC [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282677 (owner: 10Mooeypoo)
[21:34:32] 	 10Notifications: Email notification content has nothing to see with the real message content, if there is a .ogg to read in it - https://phabricator.wikimedia.org/T132633#2205050 (10JackPotte)
[21:40:31] 	 10Flow: User don't receive email notifications concerning their Flow talk page when "Talk page message" is on, but "Flow" is off - https://phabricator.wikimedia.org/T132426#2205070 (10Mattflaschen) >>! In T132426#2202276, @Trizek-WMF wrote: > The most important is the final result:  > * "Talk page message": user...
[21:42:02] 	 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2205076 (10Quiddity)
[21:43:55] 	 06Collaboration-Team-Interested, 10Flow: Move indentation model to rendering - https://phabricator.wikimedia.org/T105438#2205083 (10Mattflaschen)
[21:43:57] 	 06Collaboration-Team-Interested, 10Flow, 07Tracking: Flow's indentation model (tracking) - https://phabricator.wikimedia.org/T108998#2205082 (10Mattflaschen)
[21:45:01] 	 03Collab-Team-2016-Q4, 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review: FlowReplies is not firing in production - https://phabricator.wikimedia.org/T96620#2205090 (10Mattflaschen) There are lots of tasks related to the indentation model (e.g. {T105438}, {T93024}, {T108998}).  OT: Since this is...
[21:50:15] 	 Getting dinner
[22:09:18] 	 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-12_(1.27.0-wmf.21): [Regression wmf.18] Messages badge sometimes shows negative number - https://phabricator.wikimedia.org/T130853#2148673 (10Etonkovidova) Checked in betalabs - could not see any discrepancies  in updating(or...
[23:06:33] 	 (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Echo] (wmf/1.27.0-wmf.20) - 10https://gerrit.wikimedia.org/r/282714 (owner: 10Mattflaschen)
[23:06:42] 	 (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/Echo] (wmf/1.27.0-wmf.20) - 10https://gerrit.wikimedia.org/r/282715 (https://phabricator.wikimedia.org/T128937) (owner: 10Mattflaschen)
[23:17:11] 	 (03Merged) 10jenkins-bot: FooterNoticeWidget: Set image height explicitly [extensions/Echo] (wmf/1.27.0-wmf.20) - 10https://gerrit.wikimedia.org/r/282714 (owner: 10Mattflaschen)
[23:17:59] 	 (03Merged) 10jenkins-bot: Also show the survey tooltip on click [extensions/Echo] (wmf/1.27.0-wmf.20) - 10https://gerrit.wikimedia.org/r/282715 (https://phabricator.wikimedia.org/T128937) (owner: 10Mattflaschen)
[23:39:22] 	 03Collab-Team-2016-Q4: [betalabs-Regression] 'Mark as resolve' is affected by VE errors - https://phabricator.wikimedia.org/T132646#2205498 (10Etonkovidova)
[23:40:31] 	 03Collab-Team-2016-Q4: [betalabs-Regression] 'Mark as resolve' is affected by VE errors - https://phabricator.wikimedia.org/T132646#2205510 (10Etonkovidova)
[23:55:21] 	 03Collab-Team-2016-Q4: [betalabs] minor: 'Mark as resolve'  and 'Reopen topic' have checkmark icon black - https://phabricator.wikimedia.org/T132648#2205548 (10Etonkovidova)
[23:57:23] 	 03Collab-Team-2016-Q4: [betalabs] minor: 'Mark as resolve'  and 'Reopen topic' have checkmark icon black - https://phabricator.wikimedia.org/T132648#2205568 (10Etonkovidova)
[23:58:45] 	 10Flow: User don't receive email notifications concerning their Flow talk page when "Talk page message" is on, but "Flow" is off - https://phabricator.wikimedia.org/T132426#2205572 (10jmatazzoni) > Should the user get an email if the user's talk page is Flow, they have "Talk page message" email notifications off...