[01:07:45] okay, the subject line "Board changes and ideas for further changes" really got me ;) [01:17:20] 3Collab-Team-2016-Q4, 10Flow, 3Collab-Archive-2015-2016, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2185753 (10Mattflaschen) >>! In T127693#2098664, @Trizek-WMF wrote: > However, when the targeted page has been deleted, it has been... [01:21:42] 10Flow, 3Collab-Archive-2015-2016: WikiToLearn: Problem while converting from LiquidThreads to Flow - https://phabricator.wikimedia.org/T128949#2185762 (10Mattflaschen) [01:24:33] 3Collab-Team-2016-Q4, 10MediaWiki-Vagrant, 3Collab-Archive-2015-2016, 13Patch-For-Review: Port mwrepl to MediaWiki-Vagrant - https://phabricator.wikimedia.org/T127759#2185767 (10Mattflaschen) [01:27:10] 3Collab-Team-2016-Q4, 10Flow, 3Collab-Archive-2015-2016, 13Patch-For-Review, 5WMF-deploy-2016-04-05_(1.27.0-wmf.20): Please add user-agent header in your requests to Parsoid - https://phabricator.wikimedia.org/T131173#2185785 (10Mattflaschen) [01:30:34] 3Collab-Team-2016-Q4, 10MediaWiki-Vagrant, 3Collab-Archive-2015-2016, 13Patch-For-Review: Port mwrepl to MediaWiki-Vagrant - https://phabricator.wikimedia.org/T127759#2185790 (10Mattflaschen) [01:34:20] 3Collab-Team-2016-Q4, 10Collaboration-Team-Sprint-D-2015-06-30, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, and 5 others: E10. Have Flow use ExternalStore on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T95870#1202103 (10Mattflaschen) [04:16:40] 10Pywikibot-Flow: Update Pywikibot for Flow change to topic title markup - https://phabricator.wikimedia.org/T111221#2185963 (10happy5214) p:5Triage>3Normal [04:18:01] 10Pywikibot-Flow: Update Pywikibot for Flow change to topic title markup - https://phabricator.wikimedia.org/T111221#1598327 (10happy5214) [04:18:04] 10Pywikibot-Flow: Implement support for Flow topic titles in Pywikibot - https://phabricator.wikimedia.org/T109441#2185966 (10happy5214) [08:22:23] 10Flow: Consider including a little more info in the Recent Changes and User Contributions entries when a user creates a new Flow topic or comments on a Flow topic - https://phabricator.wikimedia.org/T132027#2186221 (10The_Discoverer) [10:08:02] (03Merged) 10jenkins-bot: Remove mobile event logging code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [12:20:49] 3Collab-Team-2016-Q4, 10Notifications: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2186498 (10Mooeypoo) This needs to be enabled in production for the relevant wikis, I have no access. Ping @Catrope on this [12:34:01] 3Collab-Team-2016-Q4, 6Collaboration-Team-Backlog, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-04-05_(1.27.0-wmf.20): No-js users cannot un-collapse moderated posts - https://phabricator.wikimedia.org/T62627#2186505 (10SBisson) a:3Catrope [14:22:00] (03CR) 10Sbisson: [C: 032] Update notifications when reopening the popup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279428 (https://phabricator.wikimedia.org/T127027) (owner: 10Mooeypoo) [14:32:23] (03Merged) 10jenkins-bot: Update notifications when reopening the popup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279428 (https://phabricator.wikimedia.org/T127027) (owner: 10Mooeypoo) [14:33:25] 3Collab-Team-2016-Q4, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2186841 (10SBisson) So the decision here is to change the mark-as-reviewed to be closer to community consensus and avoid the use of shadow messages. The message `notific... [14:36:40] 3Collab-Team-2016-Q4, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2186846 (10SBisson) Actually, this change[1] has been deployed to enwiki on March 3rd[2], so just over a month ago. Have we received any feedback that the current text is... [15:22:40] 3Collab-Team-2016-Q4, 10Notifications: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2186980 (10jmatazzoni) Thanks @Mooeypoo. Is it otherwise ready to go? With the French text and URL? [15:46:16] 3Collab-Team-2016-Q4, 10Notifications: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2187098 (10Mooeypoo) The text should be translateable in translate-wiki, and the URL is a wiki-specific configuration option that should be adde... [15:49:10] 3Collab-Team-2016-Q4, 10Notifications: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2187147 (10jmatazzoni) > The text should be translateable in translate-wiki Does that mean we can't use the translation Benoit provided, above... [16:14:15] 10Flow: Flow should use getCategories from core - https://phabricator.wikimedia.org/T132065#2187227 (10Mattflaschen) [17:05:02] 6Collaboration-Team-Backlog, 10Flow: [betalabs]: Permalink for a topic directs to Flow Archive page - https://phabricator.wikimedia.org/T128431#2187437 (10Mattflaschen) [17:05:16] 3Collab-Team-2016-Q4, 6Collaboration-Team-Backlog, 10Flow: [betalabs]: Permalink for a topic directs to Flow Archive page - https://phabricator.wikimedia.org/T128431#2074552 (10Mattflaschen) [17:32:57] 3Collab-Team-2016-Q4, 10MediaWiki-extensions-PageCuration, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2187551 (10Quiddity) >>! In T126803#2186846, @SBisson wrote: > Actually, this change[1] has been deployed to enwiki on March 3rd[2]... [17:34:56] Getting lunch [18:14:07] 3Collab-Team-2016-Q4, 10MediaWiki-extensions-PageCuration, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2187735 (10SBisson) >>! In T126803#2187551, @Quiddity wrote: >>>! In T126803#2186846, @SBisson wrote: >> Actually, this change[1] h... [18:24:34] 6Collaboration-Team-Backlog, 10Notifications, 10The-Wikipedia-Library: Notify editors that new Wikipedia Library access is available to them - https://phabricator.wikimedia.org/T131210#2187779 (10Quiddity) [18:27:39] 6Collaboration-Team-Backlog, 10Notifications, 10The-Wikipedia-Library: Notify editors that a new Wikipedia Library database is available to them - https://phabricator.wikimedia.org/T131210#2187805 (10Quiddity) [18:35:15] 6Collaboration-Team-Backlog, 10Flow, 10Notifications: Allow Notifications similar to Special:Geonotice - https://phabricator.wikimedia.org/T132087#2187825 (10Sadads) [18:36:32] legoktm, re the workboard email, LOL, that was unintentional though. [18:39:33] mooeypoo, I will prep this one, but in the future, you can prep the mediawiki-config changes yourself and list them for SWAT at https://wikitech.wikimedia.org/wiki/Deployments . [18:39:46] I do have production access, but normally I just use SWAT unless there are special circumstances. [18:52:23] 3Collab-Team-2016-Q4, 10Notifications: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2187856 (10Mattflaschen) Per @mooeypoo and discussion at standup, normally we just rely on the [translatewiki.net](https://translatewiki.net/) t... [18:54:31] ^ stephanebisson, jmatazzoni__ , see above regarding the French translation. stephanebisson, you could maybe take a quick glance at it since Benoît is probably offline. [18:54:54] matt_flaschen: I was just reading that... [18:55:18] It's probably fine, though it is not the same as Benoît's translation. The one in the code seems to be more literal, judging by Google Translate. [18:55:37] I will list a SWAT just removing the English for now, and we can amend it once we decide what to do about French. [18:56:15] well, Benoit's is better imo, especially the first part [18:57:03] is there a reason we can't edit fr.json? [18:59:22] stephanebisson, I don't think it syncs both directions. I'm worried the bot (l10n-bot@translatewiki.net) will just overwrite it next time it outputs to fr.json. But you could edit translatewiki.net and we can wait for it to sync. Or not wait but understand it will use the old translation at first. [19:00:37] I tried to create a translatewiki.net account, went through a wizard where I had not clue what was asked then got an email saying my account was rejected :( [19:00:49] I'm not sure, but https://www.mediawiki.org/wiki/Localisation#Changing_existing_messages says, "If the extension is supported by translatewiki.net, please only change the English source message and/or key, and the accompanying entry in qqq.json." [19:03:14] stephanebisson, Nikerabbit or Siebrand can probably sort that out for you. [19:03:52] stephanebisson, in the meantime, if you think it's better, I'll see if I can change it on translatewiki.net. [19:04:56] matt_flaschen: yeah, I really think it's better. The other one is hard to read. [19:05:29] Sounds good. Will do. [19:06:50] 3Collab-Team-2016-Q4, 10Notifications: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2187879 (10jmatazzoni) Matt writes: > The current French translation in the code is: > "echo-popup-footer-feedback-survey": "Répondre à ce son... [19:13:36] 3Collab-Team-2016-Q4, 10MediaWiki-extensions-PageCuration, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2187883 (10jmatazzoni) > I suggest we defer the current ticket until needed. Apparently I had a misunderstanding. I thought I'd b... [19:16:28] jmatazzoni__, we want the bold shown in the French translation in the user interface, right? [19:17:34] I.E. I'm just confirming "Donnez-nous votre avis." whether should be bold in the UI. [19:18:34] jmatazzoni__, also, we're going to change the translation on translatewiki.net. Then, I guess we should we wait for the translation to update to the code. [19:19:10] Unless you want to use the old French translation temporarily. [19:19:31] Do you mean to say we are substituting Benoit's translation? [19:19:38] (Which I prefer) [19:20:29] If we are using Benoit's text, then the following part of the header is bold: Donnez-nous votre avis. [19:21:00] And the following part is the link: Merci de participer à ce sondage sur les notifications. [19:21:40] If we're not using Benoit's, I have no idea, since the translator changed the format of the message from two sentences to one. [19:21:41] Oh, I see. My bad. Unnecessary question. [19:22:08] Are we using Benoit's text? [19:22:17] Yes, we're using Benoît's. [19:22:30] But we have to wait for it to sync over after I update it. [19:22:39] Great. Thanks. I see this more as a message to users than a piece of interface text, so that makes sense to me. [19:25:03] 3Collab-Team-2016-Q4, 10Notifications, 3Collab-Archive-2015-2016, 13Patch-For-Review, 5WMF-deploy-2016-04-12_(1.27.0-wmf.21): cross-wiki notifications: after clicking 'View changes' - 'There are no notifications' is displayed. - https://phabricator.wikimedia.org/T127027#2187905 (10Etonkovidova) Checked... [19:30:49] 3Collab-Team-2016-Q4, 10Notifications: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2187913 (10jmatazzoni) @Trizek-WMF, never mind. It looks like we're going with your text after all. [19:36:37] 3Collab-Team-2016-Q4, 10Notifications: Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2187914 (10Mattflaschen) Yeah, I've updated it on translatewiki.net. The bot should come along and commit it to the git repository in a while (... [19:37:33] BTW, the translator didn't actually change the format, I was just looking at 2/3 of the messages accidentally. [19:45:20] 3Collab-Team-2016-Q4, 10MediaWiki-extensions-PageCuration, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2187946 (10SBisson) Here's my understanding of the various elements of this problem. 1. We have changed the page-triage messages t... [20:49:45] 3Collab-Team-2016-Q4, 10MediaWiki-extensions-PageCuration, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2188198 (10jmatazzoni) Thanks for the clarification Stephane. I'm fine with the proposal to send this to the backlog. Anyone object? [21:07:13] matt_flaschen: if I see: Undefined index: upload in /mnt/srv/mediawiki-staging/wmf-config/InitialiseSettings.php on deployment-tin.eqiad.wmflabs [21:07:22] matt_flaschen: nothing to worry about? [21:07:40] etonkovidova, no, I'll fix it. [21:07:51] matt_flaschen: thx! [21:07:53] It's not necessarily actually doing the wrong thing, but at best it's spamming the logs. [21:10:02] matt_flaschen: I see [21:11:29] etonkovidova, where do you see that? [21:12:20] matt_flaschen:deployment-tin.eqiad.wmflabs mwrepl [21:13:35] etonkovidova, does it just show for you right away, or only in response to a method call? [21:13:54] I think it is from wgUploadThumbnailRenderHttpCustomDomain but it is hard to tell for sure without a line number. [21:14:11] matt_flaschen: it's shown after hphpd> continue [21:14:22] matt_flaschen: and yes, after just mwrepl [21:23:33] Weird, I didn't get it the first time but then I retried and I did. [21:23:44] It is that line. [21:26:30] etonkovidova, do you have +2 in mediawiki-config? https://gerrit.wikimedia.org/r/282290 [21:26:42] matt_flaschen: nope [21:32:50] etonkovidova, it's deployed to the Beta Cluster. You should no longer see the warning (though it only showed for me once *before* I fixed it). [21:33:52] matt_flaschen: thanks! [21:39:42] matt_flaschen: I am checking https://phabricator.wikimedia.org/T127759. For hhvmsh frwiki echo $wgDBname; will be just wiki [21:40:17] etonkovidova, it should be 'frwiki'. Is it wrong? [21:40:42] matt_flaschen: is it ok? for QA you specified hhvmsh without anything. But I thought that hhvmsh should be like mwrepl ? [21:41:59] etonkovidova, with the new version, hhvmsh and mwrepl should do exactly the same things. [21:42:05] You can run either with or without specifying a wiki. [21:42:15] If you don't specify, it should be 'wiki. If you do specify, it should be what you specified. [21:42:45] I was on a different branch. I'm re-provisioning now to check, but it should be working because I tested that kind of stuff earlier. [21:42:56] matt_flaschen: sigh - does not work. And it's merged, I see it in git log [21:43:06] etonkovidova, you need to re-provision, did you do that? [21:43:15] matt_flaschen: oops sorry [21:43:36] No problem [21:43:42] (Except that it takes forever when you do have to do it) [21:59:02] matt_flaschen: it's working! sorry again - and yes, it takes about almost 30 min [22:00:47] 3Collab-Team-2016-Q4, 10MediaWiki-Vagrant, 3Collab-Archive-2015-2016, 13Patch-For-Review: Port mwrepl to MediaWiki-Vagrant - https://phabricator.wikimedia.org/T127759#2053128 (10Etonkovidova) Checked - hhvmsh frwiki will access the specified wiki; see the output below: ``` vagrant@mediawiki-vagrant:~$ hh... [22:01:03] etonkovidova, yeah, for me not that long (I think last time I timed it it was more 15-20), but still bad. [22:02:34] This one will be useful for testing cross-wiki stuff. [22:03:16] matt_flaschen: ok :) [22:04:19] 3Collab-Team-2016-Q4, 10MediaWiki-Vagrant, 3Collab-Archive-2015-2016, 13Patch-For-Review: Port mwrepl to MediaWiki-Vagrant - https://phabricator.wikimedia.org/T127759#2188477 (10Etonkovidova) 5Open>3Resolved [22:46:27] (03PS4) 10Mattflaschen: Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) [22:52:04] (03CR) 10jenkins-bot: [V: 04-1] Disable submit buttons if we know the user can't edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279568 (https://phabricator.wikimedia.org/T108762) (owner: 10Mattflaschen) [22:54:34] 10Flow, 10Notifications: Shared commit hooks and related setup for Collaboration team extensions - https://phabricator.wikimedia.org/T132113#2188696 (10Mattflaschen) [22:54:45] 6Collaboration-Team-Backlog, 10Flow, 10Notifications: Shared commit hooks and related setup for Collaboration team extensions - https://phabricator.wikimedia.org/T132113#2188708 (10Mattflaschen) [23:10:39] 3Collab-Team-2016-Q4, 10Notifications, 6Research-and-Data: Numerous Notification Tracking Graphs Stopped Working at End of 2015 - https://phabricator.wikimedia.org/T132116#2188759 (10jmatazzoni) [23:46:10] 3Collab-Team-2016-Q4, 10Flow, 3Collab-Archive-2015-2016, 13Patch-For-Review, 5WMF-deploy-2016-04-05_(1.27.0-wmf.20): Please add user-agent header in your requests to Parsoid - https://phabricator.wikimedia.org/T131173#2158175 (10Etonkovidova) Checked - User Agent field is added to Flow Parsoid requests. [23:46:54] 3Collab-Team-2016-Q4, 10Flow, 3Collab-Archive-2015-2016, 13Patch-For-Review, 5WMF-deploy-2016-04-05_(1.27.0-wmf.20): Please add user-agent header in your requests to Parsoid - https://phabricator.wikimedia.org/T131173#2188854 (10Etonkovidova) 5Open>3Resolved