[00:03:25] 3Collab-Team-2016-Q4, 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 10Notifications, 7user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#2159597 (10jmatazzoni) [00:11:09] 3Collab-Team-2016-Q4, 6Collaboration-Team-Backlog, 6Design-Research, 10Notifications: Evaluate designs for new notification panel actions - https://phabricator.wikimedia.org/T116741#2159605 (10jmatazzoni) [00:22:53] (03CR) 10Catrope: [C: 032] Fix ApiRevThankTest::testValidRequest() [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280334 (https://phabricator.wikimedia.org/T130973) (owner: 10Legoktm) [00:23:50] (03CR) 10Catrope: [C: 032] Make sure error code is always passed to 'thanks-error-undefined' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280332 (https://phabricator.wikimedia.org/T130880) (owner: 10Legoktm) [00:24:16] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7Regression: [betalabs] Regression: Thank action failed (error code: $1). - https://phabricator.wikimedia.org/T130880#2159635 (10Catrope) [00:33:00] (03Merged) 10jenkins-bot: Fix ApiRevThankTest::testValidRequest() [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280334 (https://phabricator.wikimedia.org/T130973) (owner: 10Legoktm) [00:33:03] (03Merged) 10jenkins-bot: Make sure error code is always passed to 'thanks-error-undefined' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280332 (https://phabricator.wikimedia.org/T130880) (owner: 10Legoktm) [00:33:25] 6Collaboration-Team-Backlog, 10Notifications: Change "read" field in Echo notifications API (and db) to boolean - https://phabricator.wikimedia.org/T119455#2159682 (10Mattflaschen) Would break analytics queries like https://phabricator.wikimedia.org/diffusion/ANLE/browse/master/ee/distribution_of_response_time... [00:38:26] (03PS1) 10Catrope: Change threshold for survey invitation from 2 unread notifs to 1 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/280367 (https://phabricator.wikimedia.org/T128937) [00:38:49] matt_flaschen: Could you SWAT that ---^^ ? [00:41:16] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-22_(1.27.0-wmf.18): [[MediaWiki:Apihelp-echomarkseen-param-type/en]] i18n issue - https://phabricator.wikimedia.org/T126908#2159702 (10Mattflaschen) 5Open>3Resolved This has nothing to do with the user interf... [00:41:39] RoanKattouw, sure. Tomorrow morning, right? [00:41:51] Oh, crap [00:41:59] I thought my laptop clock was on Eastern but it's still on Pacific [00:42:11] So it's already past 5pm even on the West Coast [00:42:28] So yeah, tomorrow morning then [00:42:38] (03CR) 10Mattflaschen: [C: 032] Change threshold for survey invitation from 2 unread notifs to 1 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/280367 (https://phabricator.wikimedia.org/T128937) (owner: 10Catrope) [00:44:24] RoanKattouw, okay, I'll add it unless you're already doing that. [00:44:48] Thanks [00:44:56] 6Collaboration-Team-Backlog, 10Thanks, 13Patch-For-Review: Failing test ApiRevThankTest::testValidRequest UsageException: Revision ID is not valid - https://phabricator.wikimedia.org/T130973#2159709 (10Paladox) 5Open>3Resolved a:3Legoktm [00:44:58] I won't be, I'll be recovering from jetlag [00:45:22] 6Collaboration-Team-Backlog, 10Thanks: Failing test ApiRevThankTest::testValidRequest UsageException: Revision ID is not valid - https://phabricator.wikimedia.org/T130973#2152481 (10Paladox) [00:45:31] Yeah, I just meant if you were adding it to the wiki page. [00:45:36] But I've got that. [00:45:46] Oh OK, right [00:46:46] (03CR) 10Paladox: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280315 (owner: 10L10n-bot) [00:46:58] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280315 (owner: 10L10n-bot) [00:51:13] (03Merged) 10jenkins-bot: Change threshold for survey invitation from 2 unread notifs to 1 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/280367 (https://phabricator.wikimedia.org/T128937) (owner: 10Catrope) [00:51:41] 3Collaboration-Team-Current, 10Flow, 10Thanks: Flow failure with Thanks 'check experimental' - https://phabricator.wikimedia.org/T128628#2159714 (10Paladox) [00:52:17] 3Collaboration-Team-Current, 10Flow, 10Thanks: Flow failure with Thanks 'check experimental' - https://phabricator.wikimedia.org/T128628#2080976 (10Paladox) @Legoktm and @Janzerebecki can I add you to task please [00:52:32] (03PS1) 10Mattflaschen: Change threshold for survey invitation from 2 unread notifs to 1 [extensions/Echo] (wmf/1.27.0-wmf.18) - 10https://gerrit.wikimedia.org/r/280369 (https://phabricator.wikimedia.org/T128937) [00:52:53] (03PS1) 10Mattflaschen: Change threshold for survey invitation from 2 unread notifs to 1 [extensions/Echo] (wmf/1.27.0-wmf.19) - 10https://gerrit.wikimedia.org/r/280370 (https://phabricator.wikimedia.org/T128937) [00:53:53] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications: Echo and Flow fail on Thanks 'check experimental' ('generic') tests - https://phabricator.wikimedia.org/T128613#2159720 (10Paladox) [00:56:02] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications: Echo and Flow fail on Thanks 'check experimental' ('generic') tests - https://phabricator.wikimedia.org/T128613#2159724 (10Paladox) [00:56:49] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications: Echo and Flow fail on Thanks 'check experimental' ('generic') tests - https://phabricator.wikimedia.org/T128613#2080472 (10Paladox) [01:08:07] jmatazzoni__, are you there? [01:32:20] 6Collaboration-Team-Backlog, 10Notifications: Change "read" field in Echo notifications API (and db) to boolean - https://phabricator.wikimedia.org/T119455#2159740 (10Neil_P._Quinn_WMF) As far as I can think, it wouldn't just break those queries—it would make them impossible to replicate unless we added the sa... [01:32:31] 6Collaboration-Team-Backlog, 6Editing-Analysis, 10Notifications: Change "read" field in Echo notifications API (and db) to boolean - https://phabricator.wikimedia.org/T119455#2159742 (10Neil_P._Quinn_WMF) [01:49:22] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth, 13Patch-For-Review: Not all wikis are attached to the global username - https://phabricator.wikimedia.org/T126484#2159778 (10Mattflaschen) [01:49:24] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth, 13Patch-For-Review: localnames is not up to date because migratePass0 does not run - https://phabricator.wikimedia.org/T126480#2159776 (10Mattflaschen) 5Open>3Resolved Yes [02:02:23] 3Collaboration-Team-Current, 10Beta-Cluster-Infrastructure, 10DBA, 13Patch-For-Review, and 2 others: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2159788 (10Mattflaschen) @demon The script should work now. Do you want to pair again on this, or should I just do it? [02:17:30] (03PS1) 10Catrope: RevertedPresentationModel: Don't double-parse summary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/280374 (https://phabricator.wikimedia.org/T131087) [02:17:43] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Raw HTML shown in revert notification - https://phabricator.wikimedia.org/T131087#2159811 (10Catrope) a:3Catrope [02:21:35] Heading out, have a good night. [02:21:45] Night [09:46:07] 6Collaboration-Team-Backlog, 10Notifications, 7Persona-Active-Editor: Explore ways to adjust the badge prominence for cross-wiki notifications - https://phabricator.wikimedia.org/T131234#2160243 (10Pginer-WMF) [09:48:04] 3Collab-Team-2016-Q4, 6Collaboration-Team-Backlog, 10Notifications, 7Persona-Active-Editor: Adjust notification badge prominence for cross-wiki notifications - https://phabricator.wikimedia.org/T130363#2133785 (10Pginer-WMF) [09:59:00] 3Collab-Team-2016-Q4, 6Collaboration-Team-Backlog, 10Notifications, 7Persona-Active-Editor: Adjust notification badge prominence for cross-wiki notifications - https://phabricator.wikimedia.org/T130363#2160272 (10Pginer-WMF) >>! In T130363#2159074, @jmatazzoni wrote: > Thanks Pau for clarifying the proposa... [10:46:47] 6Collaboration-Team-Backlog, 6Editing-Analysis, 10Notifications: Change "read" field in Echo notifications API (and db) to boolean - https://phabricator.wikimedia.org/T119455#2160331 (10Pginer-WMF) >>! In T119455#2159740, @Neil_P._Quinn_WMF wrote: > @jmatazzoni, @Pginer-WMF, how important is that "distributi... [11:18:51] (03CR) 10Matthias Mullie: "There's no reason it couldn't be 1 key. But then again I'm not sure why we'd want that." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279382 (https://phabricator.wikimedia.org/T127687) (owner: 10Matthias Mullie) [11:46:19] 3Collaboration-Team-Current, 10Notifications: Figure out if the Echo API with format=html is being used - https://phabricator.wikimedia.org/T130661#2160417 (10matthiasmullie) Also note that MobileFrontend is still using ¬format=flyout, which is also deprecated. [11:46:33] 3Collab-Team-2016-Q4, 6Collaboration-Team-Backlog, 10Notifications: Cross-wiki notifications on mobile show separate alerts and messages bundles, but each bundle contains both alerts and messages - https://phabricator.wikimedia.org/T130801#2160418 (10matthiasmullie) a:3matthiasmullie [13:57:53] (03CR) 10Paladox: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/280302 (owner: 10L10n-bot) [13:58:02] (03CR) 10Paladox: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/280302 (owner: 10L10n-bot) [13:58:29] (03CR) 10Paladox: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280315 (owner: 10L10n-bot) [13:58:39] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280315 (owner: 10L10n-bot) [14:17:50] (03PS1) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 [14:18:31] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [14:18:42] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Haven't looked at the other code so far." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) (owner: 10Paladox) [14:22:17] (03PS2) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 [14:22:39] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [14:26:53] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [14:34:27] (03PS3) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 [14:34:51] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [14:37:36] (03PS4) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 [14:37:50] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [14:37:53] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [14:38:42] (03PS5) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 [14:38:56] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [14:43:31] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [14:44:35] (03PS6) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 [14:44:47] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [14:49:48] (03PS7) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 [14:50:03] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [15:01:17] (03PS8) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 [15:01:35] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [15:02:41] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/Echo] (wmf/1.27.0-wmf.18) - 10https://gerrit.wikimedia.org/r/280369 (https://phabricator.wikimedia.org/T128937) (owner: 10Mattflaschen) [15:02:49] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/Echo] (wmf/1.27.0-wmf.19) - 10https://gerrit.wikimedia.org/r/280370 (https://phabricator.wikimedia.org/T128937) (owner: 10Mattflaschen) [15:03:54] (03PS9) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 [15:04:51] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [15:06:56] (03Abandoned) 10Paladox: Test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/280447 (owner: 10Paladox) [15:12:54] (03CR) 10jenkins-bot: [V: 04-1] Change threshold for survey invitation from 2 unread notifs to 1 [extensions/Echo] (wmf/1.27.0-wmf.18) - 10https://gerrit.wikimedia.org/r/280369 (https://phabricator.wikimedia.org/T128937) (owner: 10Mattflaschen) [15:16:07] (03CR) 10Mattflaschen: [C: 032] "Spurious npm failure." [extensions/Echo] (wmf/1.27.0-wmf.18) - 10https://gerrit.wikimedia.org/r/280369 (https://phabricator.wikimedia.org/T128937) (owner: 10Mattflaschen) [15:16:31] (03Merged) 10jenkins-bot: Change threshold for survey invitation from 2 unread notifs to 1 [extensions/Echo] (wmf/1.27.0-wmf.19) - 10https://gerrit.wikimedia.org/r/280370 (https://phabricator.wikimedia.org/T128937) (owner: 10Mattflaschen) [15:27:13] (03Merged) 10jenkins-bot: Change threshold for survey invitation from 2 unread notifs to 1 [extensions/Echo] (wmf/1.27.0-wmf.18) - 10https://gerrit.wikimedia.org/r/280369 (https://phabricator.wikimedia.org/T128937) (owner: 10Mattflaschen) [15:38:04] 6Collaboration-Team-Backlog, 10Flow: Give users the option to delete their own messages in Flow - https://phabricator.wikimedia.org/T130646#2160980 (10Trizek-WMF) a:3Trizek-WMF Reasons you raised @Quiddity are enough to decline that idea IMHO. Any other thoughts? If not, I'll close that task soon. [15:39:42] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7Schema-change: Delete notifications that are disabled in preferences and maybe uninstalled/non-existent ones. - https://phabricator.wikimedia.org/T129727#2160986 (10Mattflaschen) https://gerrit.wikimedia.org/r... [15:46:14] (03CR) 10Jcrespo: "Nothing against the SQL change itself. I would suggest as a long-term task of making sure that all indexes of that table are really useful" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [16:07:05] 3Collaboration-Team-Current, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests, and 2 others: Enable Flow as a Beta feature on Polish Wikipedia - https://phabricator.wikimedia.org/T130009#2161048 (10Trizek-WMF) 5Open>3stalled Nothing more. Stalled task until a clear decision is ma... [16:28:07] Getting lunch [16:37:34] 3Collab-Team-2016-Q4, 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 10Notifications, 7user-notice: Prepare and review announcements concerning Cross-wiki Notifications as a by-default feature on all wikis - https://phabricator.wikimedia.org/T129643#2161114 (10Trizek-WMF) @Catrope sen... [16:39:31] thank you to whomever left the stickers on my desk :)) [16:50:32] 6Collaboration-Team-Backlog, 6Editing-Analysis, 10Notifications: Change "read" field in Echo notifications API (and db) to boolean - https://phabricator.wikimedia.org/T119455#2161149 (10jmatazzoni) 5Open>3declined My recollection is that in the triage meeting the other day the team didn't see this as a p... [18:04:42] 3Collaboration-Team-Current, 6Design-Research-Backlog, 10Notifications, 13Patch-For-Review, and 2 others: Invite Users to Take Notifications Survey (Using Notifications Panel) - https://phabricator.wikimedia.org/T128937#2161582 (10Trizek-WMF) French translation will be provided before Friday. [18:52:26] Darn it, I forgot to go to Scrum of Scrums. [19:22:39] 3Collaboration-Team-Current, 10MediaWiki-Vagrant: hhvmsh does not load extensions - https://phabricator.wikimedia.org/T131286#2162067 (10Mattflaschen) [19:23:04] 3Collaboration-Team-Current, 10MediaWiki-Vagrant: Port mwrepl to MediaWiki-Vagrant - https://phabricator.wikimedia.org/T127759#2162081 (10Mattflaschen) a:3Mattflaschen [20:05:28] 3Collaboration-Team-Current, 10MediaWiki-Vagrant: Port mwrepl to MediaWiki-Vagrant - https://phabricator.wikimedia.org/T127759#2162405 (10Mattflaschen) [20:05:30] 3Collaboration-Team-Current, 10MediaWiki-Vagrant: hhvmsh does not load extensions - https://phabricator.wikimedia.org/T131286#2162404 (10Mattflaschen) [20:18:39] (03CR) 10Legoktm: [C: 032] RevertedPresentationModel: Don't double-parse summary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/280374 (https://phabricator.wikimedia.org/T131087) (owner: 10Catrope) [20:19:25] (03CR) 10Legoktm: [C: 032] jscs: Enable checkRedundantParams and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279657 (owner: 10Catrope) [20:19:31] (03CR) 10Legoktm: [C: 032] jscs: Enable checkRedundantReturns and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279656 (owner: 10Catrope) [20:29:37] (03Merged) 10jenkins-bot: RevertedPresentationModel: Don't double-parse summary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/280374 (https://phabricator.wikimedia.org/T131087) (owner: 10Catrope) [20:36:30] (03Merged) 10jenkins-bot: jscs: Enable checkRedundantReturns and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279656 (owner: 10Catrope) [20:36:34] (03CR) 10jenkins-bot: [V: 04-1] jscs: Enable checkRedundantParams and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279657 (owner: 10Catrope) [21:12:20] 6Collaboration-Team-Backlog, 10Notifications, 7Design, 7WorkType-NewFunctionality: Let cross-wiki users set preferences for what types of notifications they see where - https://phabricator.wikimedia.org/T117670#2162707 (10MGChecker) [21:48:27] (03PS1) 10Legoktm: Remove Wikimedia-specific MessageCache::get hook handler [extensions/Flow] - 10https://gerrit.wikimedia.org/r/280588 (https://phabricator.wikimedia.org/T129397) [21:55:19] 10Flow, 3Collab-Archive-2015-2016, 13Patch-For-Review: FlowHooks::onMessageCacheGet() may be called during load.php and depends on the session user language - https://phabricator.wikimedia.org/T129397#2162849 (10Legoktm) a:3Legoktm [22:18:56] (03PS53) 10Paladox: Add extension.json, empty PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) [22:22:24] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [22:22:46] (03CR) 10Paladox: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [22:25:01] (03CR) 10Paladox: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [22:50:21] (03CR) 10Mattflaschen: Add topic-title-plaintext content format to reduce boilerplate code (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276401 (https://phabricator.wikimedia.org/T129439) (owner: 10Mattflaschen)