[00:01:24] * mooeypoo is going to check
[00:01:48] <mooeypoo>	 We should have more RTL tests, btw. If something's testing RTL behavior, I'm pretty happy about that even if it fails to revert the direction :P
[00:08:22] <matt_flaschen>	 It's not very unit-y, but it is an effort to test RTL. :)
[00:08:55] <matt_flaschen>	 Well, it's trying to be unit-y, but looking at it now, it could be a lot simpler and not really touch the DOM.
[00:34:15] <mooeypoo>	 matt_flaschen, GuidedTour qunit stuff pass without RTLing the content.
[00:36:07] <mooeypoo>	 And I have tons of failures all over the place when I run the entire thing
[00:36:16] <matt_flaschen>	 mooeypoo, weird.
[00:36:27] <mooeypoo>	 the whole thing dies with "Uncaught TypeError: Fake server request processing threw exception: Cannot read property 'match' of null"
[00:36:33] <mooeypoo>	 on mediawiki.ForeignApi.test.js
[00:36:35] <mooeypoo>	 :\
[00:37:53] <matt_flaschen>	 https://phabricator.wikimedia.org/F3718768
[00:37:58] <matt_flaschen>	 Maybe it's an interacton with something else.
[00:38:03] <mooeypoo>	 hee
[00:38:07] <matt_flaschen>	 Though that shouldn't happen when I run just that module.
[00:38:13] <mooeypoo>	 It's pretty awesome
[00:38:14] <mooeypoo>	 :P
[00:38:46] <mooeypoo>	 Also, I'm fairly impressed at the encapsulation of things (though not surprised, since most things in each line are individually wrapped in <spans>
[00:46:30] <mooeypoo>	 k, I'm wrapping up for the weekend. See you later, everyone, have a great weekend
[00:56:17] <matt_flaschen>	 mooeypoo, have a good weekend.
[01:31:58] <matt_flaschen>	 I'm heading out too.  Have a great weekend, everyone.
[05:32:22] <wikibugs>	 10Pywikibot-Flow: Implement support for Flow topic titles in Pywikibot - https://phabricator.wikimedia.org/T109441#2152766 (10happy5214)
[12:01:08] <grrrit-wm>	 (03CR) 10Paladox: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279490 (owner: 10L10n-bot)
[12:10:07] <grrrit-wm>	 (03CR) 10Paladox: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/279510 (owner: 10L10n-bot)
[12:10:19] <grrrit-wm>	 (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/279510 (owner: 10L10n-bot)
[12:12:10] <grrrit-wm>	 (03CR) 10Paladox: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279487 (owner: 10L10n-bot)
[12:12:21] <grrrit-wm>	 (03CR) 10Paladox: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/279487 (owner: 10L10n-bot)
[12:13:45] <paladox>	 Hi could i have some help to fix flow and thanks tests.
[12:15:25] <paladox>	 Im trying to switch them to generic tests in ci but im gettings error related to echo. Thanks is failing all its tests including non generic. The generic one is also failing with an additional error related to echo.
[12:15:42] <paladox>	 See flow failing at https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/7379/consoleFull
[12:15:54] <paladox>	 And thanks failing at  https://gerrit.wikimedia.org/r/#/c/279510/ 
[12:17:07] <paladox>	 It looks like flow and thanks test more then they would with non generic meaning they tested till 98% when they should only do it to 96%
[13:25:48] <grrrit-wm>	 (03PS1) 10Paladox: Test: DO NOT MERGE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279699 
[13:26:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Test: DO NOT MERGE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279699 (owner: 10Paladox)
[13:28:11] <grrrit-wm>	 (03PS1) 10Paladox: TEST: DO NOT MERGE [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/279700 
[13:28:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] TEST: DO NOT MERGE [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/279700 (owner: 10Paladox)
[13:33:05] <grrrit-wm>	 (03PS2) 10Paladox: Test: DO NOT MERGE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279699 
[13:33:20] <grrrit-wm>	 (03PS2) 10Paladox: TEST: DO NOT MERGE [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/279700 
[13:36:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] TEST: DO NOT MERGE [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/279700 (owner: 10Paladox)
[13:41:57] <grrrit-wm>	 (03CR) 10Paladox: "This partaly broke thanks extension. Please update thanks to use what ever code was changed. See https://integration.wikimedia.org/ci/job/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279567 (https://phabricator.wikimedia.org/T121137) (owner: 10Mattflaschen)
[13:44:49] <grrrit-wm>	 (03Abandoned) 10Paladox: Test: DO NOT MERGE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279699 (owner: 10Paladox)
[13:44:53] <grrrit-wm>	 (03Abandoned) 10Paladox: TEST: DO NOT MERGE [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/279700 (owner: 10Paladox)
[14:55:19] <wikibugs>	 6Collaboration-Team-Backlog, 10Notifications: Advanced User preferences for cross-wiki notifications - https://phabricator.wikimedia.org/T114917#2153070 (10MGChecker)