[00:06:35] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#2125038 (10ssastry) As far as HTML representation of template args is concerned, one issue we were talking about was that the HTML represen... [00:07:07] RoanKattouw, https://phabricator.wikimedia.org/T121945 [00:07:52] 3Collaboration-Team-Current, 10Notifications: Instrument opening of cross-wiki notification GroupItems - https://phabricator.wikimedia.org/T121945#2125056 (10Catrope) 5Open>3Resolved [00:11:21] (03PS9) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [00:28:09] (03PS10) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [00:28:38] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on current no-JS version of Special:Notifications - https://phabricator.wikimedia.org/T115528#2125100 (10Mooeypoo) >>! In T115528#2111871, @Pginer-WMF wrote: > As for the minimal changes,... [00:29:41] (03PS11) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [00:33:24] 3Collaboration-Team-Current, 10Notifications: Clicking a marked-as-unread notification should mark it as read - https://phabricator.wikimedia.org/T129898#2119358 (10Mooeypoo) The notification is wrapped with a link at the moment () to make it possible to right-click it. We do not intercept those clicks wit... [00:43:02] (03CR) 10Catrope: [C: 04-1] Add MobileNotificationsWrapper for Mobile display (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [00:45:54] 3Collaboration-Team-Current, 10Notifications: Clicking a marked-as-unread notification should mark it as read - https://phabricator.wikimedia.org/T129898#2125114 (10Mooeypoo) a:3Mooeypoo Actually, forget everything I said above. We **are** catching the click event anyways for logging. We can attach a state-c... [00:54:29] (03PS1) 10Mooeypoo: Clicking a marked-as-unread notification should mark it as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277703 (https://phabricator.wikimedia.org/T129898) [00:54:42] 6Collaboration-Team-Backlog, 10Notifications: Cross-site notifications loads slowly - https://phabricator.wikimedia.org/T129787#2116356 (10Quiddity) @jeblad Are notifications still having problems at Nowiki? I believe the database of older notifications was being synchronized, and had progressed up to around... [00:58:07] 6Collaboration-Team-Backlog, 10Notifications: Cross-site notifications loads slowly - https://phabricator.wikimedia.org/T129787#2116356 (10Catrope) >>! In T129787#2125128, @Quiddity wrote: > @jeblad Are notifications still having problems at Nowiki? > I believe the database of older notifications was being s... [03:03:04] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 6Design-Research, 5Design Research and product team collaboration, 7Surveys: Use of Notifications survey - https://phabricator.wikimedia.org/T127257#2125215 (10Capt_Swing) [09:38:51] (03CR) 10Zfilipin: "Yes, sorry, forgot to update here, I ran out of time yesterday, I will continue testing the patch today." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/277261 (https://phabricator.wikimedia.org/T94153) (owner: 10Mattflaschen) [10:22:34] 3Collaboration-Team-Current, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests, and 2 others: Enable Flow as a Beta feature on Polish Wikipedia - https://phabricator.wikimedia.org/T130009#2125659 (10Trizek-WMF) a:5Catrope>3Trizek-WMF I also understand an 7 for and 5 against, and,... [10:22:43] 3Collaboration-Team-Current, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests, and 2 others: Enable Flow as a Beta feature on Polish Wikipedia - https://phabricator.wikimedia.org/T130009#2125663 (10Trizek-WMF) p:5Triage>3Normal [10:46:13] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests, 13Patch-For-Review: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2125723 (10Trizek-WMF) a:3Catrope Deployment is scheduled for today. [11:03:49] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Give a way for users to opt-out Cross-wiki Notifications - https://phabricator.wikimedia.org/T129077#2125771 (10Trizek-WMF) a:3Catrope Can we consider that task as resolved or am I missing something? [11:17:22] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 10Notifications: Explore ways to avoid cross-wiki spam from welcome bots - https://phabricator.wikimedia.org/T129904#2125783 (10Trizek-WMF) French Wikipedia has the following welcome system: any user who create an account on fr receive a mess... [11:18:26] 3Collaboration-Team-Current, 10Notifications, 7Crosswiki, 13Patch-For-Review, 7user-notice: Echo counts unread messages incorrectly - https://phabricator.wikimedia.org/T129726#2125785 (10Trizek-WMF) [11:29:45] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on current no-JS version of Special:Notifications - https://phabricator.wikimedia.org/T115528#2125818 (10Pginer-WMF) >>! In T115528#2125100, @Mooeypoo wrote: > Done, done and done. Awaitin... [11:47:57] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Action and timestamp position needs adjustment - https://phabricator.wikimedia.org/T125969#2125888 (10Pginer-WMF) > We can reduce that space more if needed that way, it seems like the most straight-forward implementation rather than calculatin... [12:34:15] 6Collaboration-Team-Backlog, 10Flow, 7Browser-Tests, 13Patch-For-Review, 5WMF-deploy-2016-03-29_(1.27.0-wmf.18): Fix Flow scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily - https://phabricator.wikimedia.org/T94153#2125952 (10zeljkofilipin) a:3zeljkofilipin [13:33:07] (03PS2) 10Sbisson: [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) [13:36:54] 6Collaboration-Team-Backlog, 10Notifications: Define a minimum length for action labels to avoid - https://phabricator.wikimedia.org/T130109#2126031 (10Pginer-WMF) [13:39:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) (owner: 10Sbisson) [13:40:20] (03PS3) 10Sbisson: [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) [13:46:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) (owner: 10Sbisson) [14:59:27] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests, 13Patch-For-Review: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2126224 (10The_Discoverer) Thanks Trizek and Catrope. Will all the talk and... [15:06:45] 3Collaboration-Team-Current, 10Notifications: Define a minimum length for action labels to avoid - https://phabricator.wikimedia.org/T130109#2126240 (10jmatazzoni) [15:09:38] 3Collaboration-Team-Current, 10Notifications: Define a minimum length for action labels to avoid - https://phabricator.wikimedia.org/T130109#2126262 (10jmatazzoni) I think this is a good idea and would like to do it. However, if it is more complicated somehow than it seems, please speak up. [15:36:02] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Action and timestamp position needs adjustment - https://phabricator.wikimedia.org/T125969#2126353 (10jmatazzoni) @Pginer-WMF , I can't tell from this discussion. Are we done with these or are further adjustments needed? [15:40:06] 3Collaboration-Team-Current, 10Flow: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#1899790 (10matthiasmullie) Tested following scenarios: * Delete wikitext page: ok * Delete Flow page: ok * Restore deleted wikitext... [15:42:04] 3Collaboration-Team-Current, 10Flow: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#2126364 (10matthiasmullie) [15:42:06] 3Collaboration-Team-Current, 10Flow: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#2126362 (10matthiasmullie) 5Open>3Resolved a:3matthiasmullie [15:42:57] 3Collaboration-Team-Current, 10Flow: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#1899800 (10matthiasmullie) 5Open>3Resolved Couldn't find any issues (apart from {T104591}) [15:44:45] 3Collaboration-Team-Current, 10Flow: Update.php Flow - Error: 1 index flow_wiki_ref_idx_v2 already exists with SQLITE - https://phabricator.wikimedia.org/T126587#2126392 (10matthiasmullie) a:3matthiasmullie [15:55:53] 6Collaboration-Team-Backlog, 6Commons, 10Notifications: Message notifications hanging in Chrome - https://phabricator.wikimedia.org/T129942#2126429 (10Fae) A bit of trial and error, shows that the fault can be suppressed by commenting out twinkle in my common.js: ``` importScript('User:Kanonkas/twinkle.js');... [17:27:46] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests, 13Patch-For-Review: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2126754 (10Catrope) >>! In T128359#2125723, @Trizek-WMF wrote: > Deployment... [17:29:09] (03CR) 10Catrope: [C: 032] Clicking a marked-as-unread notification should mark it as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277703 (https://phabricator.wikimedia.org/T129898) (owner: 10Mooeypoo) [17:29:24] (03CR) 10Catrope: [C: 032] Message tweak for flow-action-not-page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/277611 (https://phabricator.wikimedia.org/T129920) (owner: 10Mattflaschen) [17:29:35] (03CR) 10Mooeypoo: Add MobileNotificationsWrapper for Mobile display (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [17:29:47] (03PS14) 10Mooeypoo: Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) [17:30:00] RoanKattouw_away, ^^ mobile is re-ready [17:30:05] mooeypoo, are you able to go to SoS? I'm at the Design Critique. I wrote stuff at https://etherpad.wikimedia.org/p/Scrum-of-Scrums [17:30:24] Sorry, should have asked earlier. [17:31:58] It'll be my first time doing that, not sure I'm updated in everything we're doing enough O.o is there a list of things? I see only cross-wiki feedback and welcome bots [17:33:43] (03CR) 10Catrope: [C: 031] Block undeleting an article over an existing Flow board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/277536 (https://phabricator.wikimedia.org/T104591) (owner: 10Matthias Mullie) [17:33:53] Ok I'll just run into the room and see if they need anything [17:35:23] (03CR) 10Catrope: [C: 032] LQT import fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274090 (owner: 10Matthias Mullie) [17:35:49] mooeypoo, yeah, that's all I listed. [17:36:27] (03CR) 10Catrope: [C: 032] Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [17:37:01] (03CR) 10Catrope: [C: 032] Adjust bottom-alignment of action buttons in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277690 (https://phabricator.wikimedia.org/T125969) (owner: 10Mooeypoo) [17:37:13] (03CR) 10Catrope: [C: 032] Adjust line-height of bundle group titles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277693 (https://phabricator.wikimedia.org/T128069) (owner: 10Mooeypoo) [17:48:45] (03Merged) 10jenkins-bot: Clicking a marked-as-unread notification should mark it as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277703 (https://phabricator.wikimedia.org/T129898) (owner: 10Mooeypoo) [17:48:48] (03Merged) 10jenkins-bot: Message tweak for flow-action-not-page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/277611 (https://phabricator.wikimedia.org/T129920) (owner: 10Mattflaschen) [17:57:26] (03Merged) 10jenkins-bot: LQT import fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274090 (owner: 10Matthias Mullie) [17:57:29] (03Merged) 10jenkins-bot: Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [17:58:10] (03Merged) 10jenkins-bot: Adjust bottom-alignment of action buttons in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277690 (https://phabricator.wikimedia.org/T125969) (owner: 10Mooeypoo) [17:58:13] (03Merged) 10jenkins-bot: Adjust line-height of bundle group titles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277693 (https://phabricator.wikimedia.org/T128069) (owner: 10Mooeypoo) [17:58:53] matt_flaschen: Reminder that https://gerrit.wikimedia.org/r/#/c/276099/ is still -1ed and blocking the whole 99+ thing [18:00:59] RoanKattouw, thanks for the reminder. I will follow up on it today. [18:25:24] (03PS4) 10Sbisson: [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) [18:26:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) (owner: 10Sbisson) [18:31:47] (03PS5) 10Sbisson: [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) [18:38:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) (owner: 10Sbisson) [18:40:25] (03PS6) 10Sbisson: [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) [18:44:11] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests, 13Patch-For-Review: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2127074 (10The_Discoverer) Hello @Catrope, you can replace all existing tal... [18:49:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) (owner: 10Sbisson) [18:53:47] (03PS7) 10Sbisson: [WIP] Stop counting notifications objects on the client [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277609 (https://phabricator.wikimedia.org/T129726) [19:02:44] mooeypoo: are you busy? [19:06:54] Since I missed standup due to design critique, my update: Minor update to an External Storage patch, merged an Echo patch, Design Critique workshop, and continued going through my email backlog. [19:07:16] Called into the critique from home. Will now get lunch and go into the coworking place. [19:24:12] stephanebisson: She's out at lunch [19:25:25] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests, 13Patch-For-Review: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2127264 (10Catrope) >>! In T128359#2127074, @The_Discoverer wrote: > Hello... [19:26:23] matt_flaschen: for vagrant external storage set up should I add smth $wgExternalStores $wgExternalServers to settings.d ? [19:54:04] 6Collaboration-Team-Backlog, 10Flow, 7Wikimedia-log-errors: Fatal error: Class undefined: ReplyAction - https://phabricator.wikimedia.org/T107921#2127376 (10mmodell) 5Resolved>3Open a:5demon>3None `Fatal error: Class undefined: ReplyAction in /srv/mediawiki/php-1.27.0-wmf.17/includes/actions/Action.p... [19:54:15] 6Collaboration-Team-Backlog, 10Flow, 7Wikimedia-log-errors: Fatal error: Class undefined: ReplyAction - https://phabricator.wikimedia.org/T107921#2127383 (10mmodell) [20:37:18] 6Collaboration-Team-Backlog, 10Notifications: [betalabs] Regression: 'Mark as unread' box is misplaced - https://phabricator.wikimedia.org/T130153#2127453 (10Etonkovidova) [20:38:30] etonkovidova, T95870 should not be in QA Review yet. That's why I moved it back. There is another patch pending to MediaWiki-Vagrant itself. [20:38:30] T95870: E10. Have Flow use ExternalStore on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T95870 [20:39:27] I could tell you how to set it up manually if you need it for another patch, but I would recommend waiting unless it's urgent. [20:44:09] RoanKattouw, I just left it 250 since that's what it was trying to do before. Should I change it to 100? [20:44:27] I think that'd be best for consistency [20:44:39] Will do [20:44:45] matt_flaschen: Also, random question. What, if anything, is action=reply used for in Flow? [20:44:59] Because I'm poking at T107921 and I don't understand how it ever worked [20:45:00] T107921: Fatal error: Class undefined: ReplyAction - https://phabricator.wikimedia.org/T107921 [20:45:55] Flow.php is doing $wgAction[$action] = true; which requires that {$action}Action exists in the top namespace, which AFAICT it never has [20:46:18] Also... holy shit ?action=view is in there [20:46:27] Should we even be writing to $wgAction at all? o.O [20:50:22] RoanKattouw, isn't that how all of our actions are registered. We could look into using PerformAction, but we're not currently. [20:50:45] Yeah I now discovered it's needed for replying in no-JS to work (action=reply) [20:51:13] But here's the problem [20:51:24] http://localhost/w/index.php?title=Topic:Szxy6m3c2uc5ic8r&action=reply works as you'd expect, and breaks if you remove the $wgAction stuff [20:51:34] http://localhost/w/index.php?title=Talk:Main_Page&action=reply says "No such action" [20:51:41] http://localhost/w/index.php?title=Main_Page&action=reply throws an exception [20:52:01] How is that even possible?!? [20:52:29] Also, $wgFlowActions includes 'view' which has a handler class, which means that Flow *overrides core's entry for action=view* [20:52:54] RoanKattouw: Wow, a trivial 503 on a GET request. [20:52:55] Thankfully it's overwritten with "true" which means "use \ViewAction" which is already the value that core puts there, but ..... what [20:52:58] RoanKattouw: That's… poor. [20:54:06] James_F: Found your request in fatal.log, only the second one today [20:54:07] 2016-03-16 20:52:40 mw1071 mediawikiwiki 1.27.0-wmf.17 fatal ERROR: [a103ad61] PHP Fatal Error: Class undefined: ReplyAction [20:54:12] * RoanKattouw writes down some of his rant on the bg [20:54:14] RoanKattouw: :-) [20:54:38] RoanKattouw: So I can freak out RelEng by getting a bot to hammer that URL and make people worry that prod is down? ;-) [20:54:47] This part of the code has been on my list to learn better. [20:54:48] Probably [20:54:50] I guess now is the time. [20:55:04] Sorry matt_flaschen I assumed you'd know about it [20:55:29] I sometimes forget you have only been around the Flow code base a few months longer than me, because it doesn't feel that way (and never has) [20:56:30] It's fine, wish I had an answer to this, but I don't right away. Not sure where ReplyAction is coming from. The 'reply' handler class is FlowAction. [20:56:53] I also don't understand how overriding 'view' (apparently unconditionally) works. [20:57:05] I understand why it doesn't break if that's what you mean [20:57:17] But from what I can tell, the existence of the ReplyAction class is conditional on the title parameter [20:57:31] Which is insane [20:58:46] those actions should come form the ContentHandler implementation [20:58:51] Ooooh! [20:58:59] RoanKattouw, how does 'view' work on a non-Flow request? [20:59:06] I didn't realize ContentHandler made actions conditionally exist but that makes some amount of sense [20:59:19] matt_flaschen: Core sets $wgActions['view'] = true; , and then we set it again for good measure [20:59:32] $wgActions['view'] = true; is shorthand for $wgActions['view'] = 'ViewAction'; [20:59:55] Apparently ContentHandler does interception that allows us to make stuff work when the title refers to something whose content model is Flow [21:00:14] Which would explain how ?title=Topic:blah&action=reply can even work, because there's no ReplyAction class in the global namespace [21:05:06] RoanKattouw, so it should be in the overrides, but is not, so it falls through to: [21:05:14] return ucfirst( $action ) . 'Action'; [21:06:20] 6Collaboration-Team-Backlog, 10Notifications: [betalabs] Regression: 'Mark as read/unread' box is misplaced - https://phabricator.wikimedia.org/T130153#2127528 (10Etonkovidova) [21:07:09] Oh right there's an overrides thing [21:07:13] Well, "should" [21:07:22] I'd hope that Flow wouldn't hijack core's action=view [21:08:41] RoanKattouw, well, whether it should be in the list depends on what the request is. [21:08:56] RoanKattouw, unrelated, I'm seeing "Unknown user" in the top right on some pages in MediaWiki.org [21:09:10] Yeah me too [21:10:47] Oh, now I see getActionOverrides() [21:11:01] In BoardContentHandler [21:11:20] And that makes me understand how this stuff works [21:11:46] So... what we want to do is not supported in MW core it seems [21:12:06] We want to have action=reply only be in the ActionOverrides for one content model, but not be recognized for anything else, baiscally [21:12:16] But MW core doesn't let you do that [21:13:08] Oh, I thought you found that before. [21:13:20] I'm trying to figure out why https://www.mediawiki.org/wiki/Talk:MediaWiki?action=reply&uselang=qqx is triggering flow-error-default. [21:13:21] You MUST set $wgActions['reply'] = true; in order for overrides to work which means you MUST ensure a ReplyAction class exists in the global namespace otherwise there's an exception when somebody calls ?action=reply on a wikitext page [21:13:53] matt_flaschen: No I'm a bit behind but I understand the exception stuff now and it's a core bug [21:14:28] Re flow-error-default, interesting [21:14:43] At least the basic behavior of it returning an error screen (but not an exception) is desired [21:14:52] RoanKattouw, yeah, I'm going to debug through. That's in our court, since it is a Flow board (but not topic). [21:15:00] Yeah [21:15:02] This might be another reason to separate topic content model, but I need to figure out what is going on. [21:15:07] I'll write up a rant on T107921 [21:15:08] T107921: Fatal error: Class undefined: ReplyAction - https://phabricator.wikimedia.org/T107921 [21:15:19] matt_flaschen: Maybe, but it seems easy enough to put in a namespace check right? [21:16:07] Yeah, I guess, but it's a hack, so we would at least want to note it as another reason. [21:16:46] Yeah, fair [21:17:33] My mouse hand/arm has started bothering me. Need to find a better position or switch chairs or something. [21:25:10] 3Collaboration-Team-Current, 10MobileFrontend, 10Notifications, 7Mobile, and 2 others: Use same OOUI widgets for notifications popup on mobile and desktop - https://phabricator.wikimedia.org/T124188#2127566 (10Jdlrobson) 5stalled>3Resolved Thanks guys!! Now let me source some Stroopwafels... [21:27:34] matt_flaschen: If you like you can have an ergonomics person come out and help you set up your work station. HR started doing that for new hires by default a while ago, and for anyone who asks (both local and remote) [21:27:44] https://office.wikimedia.org/wiki/HR_Corner/Ergonomics#WMF_ergonomics_program [21:28:03] * RoanKattouw reminds himself to sign up for the next time the ergonomics person comes to the SF office [21:31:34] RoanKattouw, thanks. That might be a good idea. [21:44:31] (03PS1) 10Mattflaschen: Actions: Use invalid-action as intended, fix a doc block. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/277896 [21:44:47] No hack necessary. I just fixed it to show the same error as core. [21:52:31] (03CR) 10Catrope: [C: 032] Actions: Use invalid-action as intended, fix a doc block. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/277896 (owner: 10Mattflaschen) [21:54:09] 3Collaboration-Team-Current, 10Notifications: [betalabs] Regression: 'Mark as read/unread' box is misplaced - https://phabricator.wikimedia.org/T130153#2127656 (10Luke081515) [21:58:43] 3Collaboration-Team-Current, 10Notifications: [betalabs] Regression: 'Mark as read/unread' box is misplaced - https://phabricator.wikimedia.org/T130153#2127453 (10Catrope) Also reproducible if you lower the text size ("zoom out") to the point where the scroll bar in the notifications popup goes away. [21:58:49] 3Collaboration-Team-Current, 10Notifications: [betalabs] Regression: 'Mark as read/unread' box is misplaced - https://phabricator.wikimedia.org/T130153#2127669 (10Catrope) p:5Triage>3Unbreak! [21:59:49] 6Collaboration-Team-Backlog, 10Notifications: [betalabs] edit-user-talk notifications do not display text excerpts - https://phabricator.wikimedia.org/T130157#2127672 (10Etonkovidova) [22:02:29] (03Merged) 10jenkins-bot: Actions: Use invalid-action as intended, fix a doc block. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/277896 (owner: 10Mattflaschen) [22:07:16] (03PS4) 10Mattflaschen: Corresponding changes for Echo 99+ refactoring [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) [22:08:18] 3Collaboration-Team-Current, 10Notifications: [betalabs] Regression: 'Mark as read/unread' box is misplaced - https://phabricator.wikimedia.org/T130153#2127696 (10Catrope) This is an #OOJS-UI regression from https://gerrit.wikimedia.org/r/#/c/276664/ (for T129521). The culprit is `this.needsCustomPosition = cl... [22:08:40] (03CR) 10jenkins-bot: [V: 04-1] Corresponding changes for Echo 99+ refactoring [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [22:12:22] (03CR) 10Mattflaschen: "Changed to use 100 instead of 250, and removed other function." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [22:12:27] RoanKattouw: D: [22:12:36] Yeeeaaahhh [22:12:40] (03PS5) 10Mattflaschen: Corresponding changes for Echo 99+ refactoring [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) [22:12:46] Currently building the OOUI demo to see if I can point to breakage in OOUI's own widgets [22:15:48] Hmm, nothing in the widgets demo uses overlays [22:16:03] RoanKattouw: there's a $overlay demo in dialogs. but i tested it well [22:16:29] Aha [22:17:07] eh, we really need to start reviewing OOUI code better. we had a couple of embarassing breakages [22:17:15] Yeah but those are all scrollable [22:17:30] Let me see if I can generate an example where there are no scroll bars internal to the dialog [22:19:51] 3Collaboration-Team-Current, 6Design-Research-Backlog, 10Notifications: Invite Users to Take Notifications Survey (Using Notifications Panel) - https://phabricator.wikimedia.org/T128937#2127752 (10jmatazzoni) **SPEC: FEEDBACK LINK IN NOTIFICATIONS PANEL** First Deployment, Invitation for Notifications Survey... [22:20:03] Oh God so many level of scrollable containers [22:20:12] The good news there is though that it should be easy to work around this bug in Echo [22:20:16] Just add overflow-y: auto; somewhere [22:21:22] RoanKattouw: yeah, the way we detect scrollable containers is broken [22:21:45] but fixing it would probably make it stupidly slow [22:22:43] 3Collaboration-Team-Current, 6Design-Research-Backlog, 10Notifications: Invite Users to Take Notifications Survey (Using Notifications Panel) - https://phabricator.wikimedia.org/T128937#2127757 (10jmatazzoni) a:5Pginer-WMF>3None [22:24:00] Argh: [22:24:06] > .oo-ui-popupWidget-body { [22:24:07] // Work around scrollbar rendering bug in Chrome [22:24:09] overflow: visible; [22:24:10] } [22:24:21] I very vaguely remember this bug [22:24:51] I wonder if overflow-y: auto; is also good enough to make that bug not happen (the default for popup widgets is hidden) [22:32:32] Hmm, so yes, overflow-y: auto; on that particular container makes the Chrome bug come back [22:32:38] I'll need to find something else to make scrollable then [22:37:39] AHA [22:38:06] So, it turns out what I REALLY need to work around the Chrome bug is overflow-y: visible;, not overflow: visible; [22:38:06] One of these days I will put a camera and live-stream RoanKattouw working on a Browser bug. [22:38:11] This must exist for posterity. [22:38:16] And science. [22:38:16] It doesn't matter what overflow-x is for the purposes of working around the Chrome scrollbar bug [22:38:35] ... and I cannot in good conscience keep this from the world. [22:38:36] Which means that I can set overflow-x: auto; , which is a no-op, and is enough to trick OOUI into believing it's scrollable, which works around the FloatableElement bug [22:40:06] > .oo-ui-popupWidget-body { [22:40:07] // Work around scrollbar rendering bug in Chrome [22:40:09] overflow-y: visible; [22:40:10] // Work around OO.ui.FloatableElement bug (T130153) [22:40:11] T130153: [betalabs] Regression: 'Mark as read/unread' box is misplaced - https://phabricator.wikimedia.org/T130153 [22:40:12] overflow-x: auto; [22:40:13] } [22:42:19] (03CR) 10Mattflaschen: Make plural support for large values (100 or more) explicit in l10n (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [22:43:46] (03PS15) 10Mattflaschen: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) [22:44:33] (03PS1) 10Catrope: Work around regression in OO.ui.FloatableElement [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277908 (https://phabricator.wikimedia.org/T130153) [22:45:59] (03CR) 10Mattflaschen: [C: 04-1] "When rebasing, you'll have to change it to MAX_BADGE_COUNT. I wanted to clarify it, since this has nothing to do with the underlying stor" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277242 (owner: 10Matthias Mullie) [22:47:33] RoanKattouw: do you have some smaller test case you could file a bug for OOUI with? [22:48:20] (03PS1) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [22:48:27] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Minimal JS version of Special:Notifications - https://phabricator.wikimedia.org/T129176#2127849 (10Mooeypoo) a:3Mooeypoo [22:49:24] MatmaRex: Yeah I'm working on a patch for the demo [22:51:21] (03CR) 10Mooeypoo: [C: 032] Work around regression in OO.ui.FloatableElement [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277908 (https://phabricator.wikimedia.org/T130153) (owner: 10Catrope) [22:58:24] (03PS1) 10Mooeypoo: Rename MobileNotificationsWrapper to NotificationsWrapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277915 [23:00:34] (03Merged) 10jenkins-bot: Work around regression in OO.ui.FloatableElement [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277908 (https://phabricator.wikimedia.org/T130153) (owner: 10Catrope) [23:01:47] (03PS2) 10Mooeypoo: Rename MobileNotificationsWrapper to NotificationsWrapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277915 [23:06:37] (03PS2) 10Mooeypoo: [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) [23:08:03] (03CR) 10jenkins-bot: [V: 04-1] Rename MobileNotificationsWrapper to NotificationsWrapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277915 (owner: 10Mooeypoo) [23:09:23] mooeypoo: https://phabricator.wikimedia.org/T128937 [23:12:09] (03CR) 10jenkins-bot: [V: 04-1] [wip] Initial version of Special:Notifications Javascript page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/277912 (https://phabricator.wikimedia.org/T129176) (owner: 10Mooeypoo) [23:34:25] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 10Notifications, 13Patch-For-Review: cross-wiki notification on mediawiki-vagrant uses port 8080 for foreign wikis even when accessing the page with https on port 4430 - https://phabricator.wikimedia.org/T126378#2012766 (10Etonkovidova) @SBisson: I can see... [23:51:39] 6Collaboration-Team-Backlog, 10Flow, 7Wikimedia-log-errors: Fatal error: Class undefined: ReplyAction - https://phabricator.wikimedia.org/T107921#1507265 (10Catrope) I found out that this happens consistently if you add `?action=reply` to the URL for a non-Flow page, e.g. https://www.mediawiki.org/wiki/Main_... [23:57:55] 3Collaboration-Team-Current, 6Design-Research-Backlog, 10Notifications: Invite Users to Take Notifications Survey (Using Notifications Panel) - https://phabricator.wikimedia.org/T128937#2128132 (10jmatazzoni) a:3Mooeypoo