[00:00:59] 6Collaboration-Team-Backlog, 10Notifications, 13Patch-For-Review, 7Wikimedia-log-errors: Echo: Call to a member function getLocalURL() on a non-object (null) in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129715#2113817 (10Mattflaschen) [00:01:01] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: BadMethodCallException in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129641#2113818 (10Mattflaschen) [00:01:04] 6Collaboration-Team-Backlog, 10Notifications, 13Patch-For-Review, 7Wikimedia-log-errors: Echo: Call to a member function getLocalURL() on a non-object (null) in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129715#2113820 (10demon) 5duplicate>3Open p:5Triage>3Normal [00:01:17] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7Wikimedia-log-errors: BadMethodCallException in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129641#2111502 (10Mattflaschen) [00:03:34] RoanKattouw, I can monitor the SWAT for the thank-you-edit, if you want to move it up to Monday morning. [00:03:34] legoktm, meh, can you help with this? I have no idea what that failure is about? https://integration.wikimedia.org/ci/job/mwext-Echo-testextension-hhvm/444/consoleFull (context, this commit: https://gerrit.wikimedia.org/r/#/c/276684/) [00:03:39] matt_flaschen: Yes please [00:03:41] * RoanKattouw moves [00:04:26] mooeypoo: you didn't add the new class to autoload.php [00:04:31] mooeypoo: run scripts/gen-autoload.php [00:04:35] I did through the script [00:04:42] oh... uhm... maybe I didn't [00:04:47] I did the special page commit, ha [00:04:54] legoktm, thanks, will do that now [00:05:16] legoktm, btw, why are we using this instead of composer ? [00:05:29] mw already uses composer anyways, and it has that autoloading thing as it is, no? [00:05:46] we don't use composer for autoloading [00:05:56] why not? [00:06:00] because it requires a build process, that MW doesn't require [00:06:20] like, you'd have to run "composer dump-autoload" before anything would work [00:06:25] hm, good point... [00:06:28] instead of just checking out git and go [00:06:36] although we already have that in mw core [00:06:43] we have to do composer install for it to work [00:06:58] (As I've learned repeatedly with newbies missing that step and having no mw in their localhost:\ ) [00:07:09] or you can clone mediawiki/vendor [00:07:25] And people know to do that? [00:07:44] it's documented :) https://www.mediawiki.org/wiki/Download_from_Git#Fetch_external_libraries [00:07:56] ha, okay, fair enough [00:09:22] ok it seems I actually DID run that script but for some incredibly weird reason, it added '__construct' => ... [00:09:39] I re-ran it now locally and the script erases that line, but legoktm look here: https://gerrit.wikimedia.org/r/#/c/276684/1/autoload.php O.o [00:09:42] wtf? [00:10:01] lolwut [00:10:05] (I'm out, helping a neighbour for a bit. Back later, or a bit over the weekend. Have a good one, if I don't catch y'all later. :) [00:10:19] I didn't change any of this manually, I ran the script. Also, it seemed to change [ to array( but I assume that's ok? [00:10:38] short array syntax is fine [00:10:44] idk why it' doing the _construct thing [00:10:49] legoktm, did this script change lately, though? [00:10:50] (03CR) 10Catrope: [C: 04-1] Add 'mark section as read' to Special:Notifications (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [00:10:53] why would it change it now suddenly? [00:11:12] idk... [00:11:18] fix it manually for now and file a bug? [00:11:29] My theory is that she ran the script while the PHP file was syntactically invalid or something [00:11:34] oh, the new file now fixes it, but not the array bit [00:11:44] which is harmless, i just don't understand why it suddenly changed it now [00:11:53] because the script changed in core [00:11:56] (03PS2) 10Mooeypoo: [WIP] OOUI'fy the Special Page notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276684 [00:12:03] yeah that's what I thought [00:12:22] there's no __construct in the new file (just pushed) but I have no idea why it would even be there [00:14:10] So while you guys are here, I have some patches of mine that need review :) [00:14:26] https://gerrit.wikimedia.org/r/276687 rewrites DiscussionParser::getTextSnippet() to not be insane and be much more similar to what Flow does [00:14:57] https://gerrit.wikimedia.org/r/276683 adds the post-betafeature-stage opt-out thing that Benoît filed a task for [00:15:11] https://gerrit.wikimedia.org/r/276692 is a minor cleanup thing [00:15:46] And https://gerrit.wikimedia.org/r/274051 is a one-liner that the Parsoid team would like to see merged [00:16:38] mooeypoo: https://gerrit.wikimedia.org/r/276694 and https://gerrit.wikimedia.org/r/276695 are more bidi patches [00:17:47] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth, 13Patch-For-Review: localnames is not up to date because migratePass0 does not run - https://phabricator.wikimedia.org/T126480#2015523 (10Catrope) Is this fixed now? [00:26:23] (03PS6) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [00:27:18] The itzy bidi spider climbed up the tuops retaw [00:30:47] (03CR) 10jenkins-bot: [V: 04-1] Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [00:32:42] (03CR) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [00:36:35] 6Collaboration-Team-Backlog, 10Notifications, 13Patch-For-Review, 7Wikimedia-log-errors: Echo: Call to a member function getLocalURL() on a non-object (null) in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129715#2113892 (10Mattflaschen) [00:36:37] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7Wikimedia-log-errors: BadMethodCallException in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129641#2113893 (10Mattflaschen) [00:36:54] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7Wikimedia-log-errors: BadMethodCallException in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129641#2111502 (10Mattflaschen) p:5Triage>3Normal [00:41:48] RoanKattouw: oh yay, finally made it to wikimedia-l :D [00:42:09] Yeah :) [00:42:25] I emailed -owners and Richard cleared it while I was having lunch [01:12:05] 6Collaboration-Team-Backlog, 10Notifications: Subobtimal behavior when lots of notifications are received (e.g. mass-reverts) - https://phabricator.wikimedia.org/T129722#2113942 (10Catrope) [01:25:32] 6Collaboration-Team-Backlog, 10WikiLove: [edit] link in WikiLove preview screen causes data loss - https://phabricator.wikimedia.org/T129692#2113974 (10Peteforsyth) For what it's worth, I looked on Meta Wiki, and asked about enabling WikiLove, here: https://meta.wikimedia.org/wiki/Meta:Babel#Enable_WikiLove_he... [01:35:03] 3Collaboration-Team-Current: Notification titles should differentiate subpages of the talk page - https://phabricator.wikimedia.org/T129686#2114005 (10jmatazzoni) What would you suggest as a fix? I'd hope this could be fixed without having to add yet more notifications and/or notification types. E.g., these u... [01:36:27] 3Collaboration-Team-Current: Notification titles should differentiate subpages of the talk page - https://phabricator.wikimedia.org/T129686#2112745 (10Catrope) >>! In T129686#2114005, @jmatazzoni wrote: > What would you suggest as a fix? I'd hope this could be fixed without having to add yet more notifications... [01:36:40] 3Collaboration-Team-Current, 10Notifications: Notification titles should differentiate subpages of the talk page - https://phabricator.wikimedia.org/T129686#2114010 (10Catrope) [01:59:05] (03CR) 10Mattflaschen: [C: 032] "It would be nice to be able to grep for skipped tests, rather than un-skipped. That is how e.g. PHPUnit works." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274355 (https://phabricator.wikimedia.org/T94153) (owner: 10Zfilipin) [02:02:22] 6Collaboration-Team-Backlog, 10Notifications, 7Crosswiki: Echo counts unread messages incorrectly - https://phabricator.wikimedia.org/T129726#2114065 (10He7d3r) [02:10:03] (03Merged) 10jenkins-bot: Disable scenarios that fail at en.wikipedia.beta.wmflabs.org from running daily [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274355 (https://phabricator.wikimedia.org/T94153) (owner: 10Zfilipin) [02:12:49] 6Collaboration-Team-Backlog, 10MediaWiki-Watchlist, 10Notifications: Allow e-mail notifocations about changes of watched without having to log in and load the entire pages again. - https://phabricator.wikimedia.org/T129710#2114091 (10Purodha) Okay, I do not mind much for now, but my suggestion and the reques... [02:14:54] 6Collaboration-Team-Backlog, 10Notifications, 7Crosswiki: Echo counts unread messages incorrectly - https://phabricator.wikimedia.org/T129726#2114093 (10He7d3r) Also, after marking all messages as read, it goes instantaneously to zero, but on page reload it goes up to 27 again. A second click on mark all as... [02:18:20] 3Collaboration-Team-Current, 6Design-Research-Backlog, 10Notifications: Invite Users to Take Notifications Survey (Using Notifications Panel) - https://phabricator.wikimedia.org/T128937#2114096 (10jmatazzoni) > What I was proposing is to use the feedback icon we used in other parts of the UI, while still kee... [03:08:03] 6Collaboration-Team-Backlog, 10Notifications: Delete notifications that are disabled in preferences and maybe uninstalled/non-existent ones. - https://phabricator.wikimedia.org/T129727#2114138 (10Mattflaschen) [03:14:53] (03CR) 10Mattflaschen: [C: 04-1] "Change MAX_NOTIFICATION_COUNT to something else, like MAX_BADGE_COUNT. This is still a confusing name. See https://gerrit.wikimedia.org/" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [03:15:36] (03CR) 10Mattflaschen: [C: 04-1] "Doesn't reliably work if the unread count is under $wgEchoMaxUpdateCount, but read notifications need to be deleted." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [03:19:12] 6Collaboration-Team-Backlog, 10Notifications, 7Crosswiki: Echo counts unread messages incorrectly - https://phabricator.wikimedia.org/T129726#2114065 (10Mattflaschen) Maybe slave lag? Does ChronologyProtector cover the shared DB used by UnreadWikis? [03:19:58] Have a good weekend, everyone. [10:54:34] (03PS1) 10Amire80: Add i18n/en.json authors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276949 [13:14:17] 6Collaboration-Team-Backlog, 10Notifications: Support cross-wiki rights change notification in Echo - https://phabricator.wikimedia.org/T53540#2114606 (10matej_suchanek) [13:14:19] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-TranslationNotifications, 10Notifications: Deliver notification using Echo where available - https://phabricator.wikimedia.org/T48310#2114605 (10matej_suchanek) [15:08:58] 6Collaboration-Team-Backlog, 10MediaWiki-Email, 10MediaWiki-User-preferences, 10MediaWiki-extensions-PasswordReset, and 2 others: Proposal: allow a second email address (wikimail, password reset, notifications) - https://phabricator.wikimedia.org/T129747#2114755 (10Gradzeichen) [18:41:42] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#2114920 (10ssastry) [19:46:04] 6Collaboration-Team-Backlog, 10WikiLove: [edit] link in WikiLove preview screen causes data loss - https://phabricator.wikimedia.org/T129692#2114962 (10Peteforsyth) Apparently a 2012 Meta vote rejected enabling WikiLove: https://meta.wikimedia.org/wiki/Meta:Babel/Archives/2012-05#Proposal:_Enable_WikiLove_on_M... [19:49:15] 6Collaboration-Team-Backlog, 10Notifications, 7I18n, 7RTL: remove from notification-header-flow-new-topic-v2 - https://phabricator.wikimedia.org/T129755#2114964 (10Amire80)